1 2011-04-10T00:09:13 *** MattMaker
2 2011-04-10T00:09:59 *** MattMaker
3 2011-04-10T03:22:20 *** ronny
4 2011-04-10T05:13:30 *** MattMaker
5 2011-04-10T06:10:02 *** m4k3r
6 2011-04-10T06:35:23 *** m4k3r
7 2011-04-10T09:47:29 *** ronny
8 2011-04-10T11:08:34 * dreimark had added points
9 2011-04-10T11:08:39 <dreimark> bbl
10 2011-04-10T11:18:19 *** MattMaker
11 2011-04-10T11:54:11 *** m4k3r
12 2011-04-10T11:56:00 *** m4k3r
13 2011-04-10T11:56:16 *** m4k3r
14 2011-04-10T12:16:26 *** greg_f
15 2011-04-10T12:29:59 <ronny> moin
16 2011-04-10T12:51:19 <m4k3r> moin
17 2011-04-10T14:11:25 <ronny> whats the state on the test stuff students
18 2011-04-10T14:16:38 <dreimark> ronny: we invited all test stuff students to fix a test or to introduce a new test
19 2011-04-10T14:25:52 <ronny> dreimark: do they have the right branch? or can they just fox the current testsuite as well
20 2011-04-10T14:27:14 <ThomasWaldmann> to show that they can do reasonable work, i think it would be sufficient to do it with py.test 1.3.4
21 2011-04-10T14:54:17 <dreimark> ronny: they can do this with the current moin-2. Anyway they need to fix or work with stuff based on that
22 2011-04-10T14:54:53 <ronny> k
23 2011-04-10T15:55:49 <ThomasWaldmann> looks like our students needed a break after applications
24 2011-04-10T17:09:38 *** raignarok
25 2011-04-10T17:10:50 *** raignarok
26 2011-04-10T17:46:54 <dreimark> we should remove env from test setup
27 2011-04-10T17:48:48 <ThomasWaldmann> ?
28 2011-04-10T17:50:20 <ThomasWaldmann> somehow it calls init_test_app much more often than deinit_test_app
29 2011-04-10T17:57:05 <dreimark> ThomasWaldmann: http://hg.moinmo.in/moin/2.0/file/e8f61cbd661b/MoinMoin/conftest.py#l22
30 2011-04-10T17:57:31 <dreimark> we should add env also
31 2011-04-10T18:00:05 <ThomasWaldmann> that doesn't work anyway
32 2011-04-10T18:01:38 <dreimark> ok
33 2011-04-10T18:05:51 <ThomasWaldmann> argh. found a bad c&p error.
34 2011-04-10T18:07:59 * dreimark waits for the cs
35 2011-04-10T18:09:16 *** sinha
36 2011-04-10T18:16:11 *** sinha
37 2011-04-10T18:23:49 <CIA-25> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 175:d3b415b65562 2.0/MoinMoin/conftest.py: fix copy&paste error in conftest
38 2011-04-10T18:34:01 *** greg_f
39 2011-04-10T18:38:19 *** xjjk
40 2011-04-10T18:38:26 *** xjjk
41 2011-04-10T18:48:16 *** m4k3r
42 2011-04-10T18:49:02 *** m4k3r
43 2011-04-10T18:54:52 <ThomasWaldmann> i guess I'll remove the class and module level stuff from conftest
44 2011-04-10T18:55:08 <ThomasWaldmann> so it only sets up / tears down on method level
45 2011-04-10T18:55:29 <ThomasWaldmann> (if needed, we could add function level later)
46 2011-04-10T18:55:56 <ThomasWaldmann> i don't think it makes sense on class or module level, because it nests badly
47 2011-04-10T18:56:33 <ThomasWaldmann> (I'll keep the module level stuff for coverage, of course)
48 2011-04-10T19:06:55 *** Ardavan
49 2011-04-10T19:07:44 *** raignarok
50 2011-04-10T19:07:55 *** raignarok
51 2011-04-10T19:16:40 *** hardy_89
52 2011-04-10T19:39:18 *** hardy_89
53 2011-04-10T19:43:51 <CIA-25> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 176:429ca1c60a1f 2.0/MoinMoin/conftest.py: (log message trimmed)
54 2011-04-10T19:43:51 <CIA-25> py.test conftest fixes, details see below, updated copyright
55 2011-04-10T19:43:51 <CIA-25> init_test_app / deinit_test_app: removed the calls on class level
56 2011-04-10T19:43:51 <CIA-25> this should not be needed as we call them with setup_method and
57 2011-04-10T19:43:51 <CIA-25> teardown_method and we don't have support for nesting these calls.
58 2011-04-10T19:43:52 <CIA-25> init_test_app on module level: removed, for similar reasons.
59 2011-04-10T19:43:53 <CIA-25> I checked the tests with and without this and we seem to no need init_test_app
60 2011-04-10T19:53:45 *** Ardavan
61 2011-04-10T20:23:44 *** ronny
62 2011-04-10T20:25:51 *** ronny
63 2011-04-10T21:23:09 * ThomasWaldmann tries to implement some storage close that frees up resources
64 2011-04-10T22:56:51 <CIA-25> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 177:9cc75ad9d6d1 2.0/MoinMoin/ (8 files in 3 dirs):
65 2011-04-10T22:56:52 <CIA-25> infrastructure to shutdown / close resources of the app, storage, etc.
66 2011-04-10T22:56:52 <CIA-25> storage backends now have a close() method, that shall close/free all
67 2011-04-10T22:56:52 <CIA-25> resources used.
68 2011-04-10T22:56:52 <CIA-25> currently, this is mostly used to dispose sqlalchemy engines.
69 2011-04-10T22:57:32 <ThomasWaldmann> from 1.1GB down to ~430MB for a full test run
70 2011-04-10T23:13:08 <dreimark> re
71 2011-04-10T23:13:12 <dreimark> wow
72 2011-04-10T23:14:16 * dreimark tries
73 2011-04-10T23:51:19 *** m4k3r
74
MoinMoin: MoinMoinChat/Logs/moin-dev/2011-04-10 (last edited 2011-04-09 22:45:02 by IrcLogImporter)