1 2011-04-23T02:04:29 *** MattMaker
2 2011-04-23T03:48:58 *** MattMaker
3 2011-04-23T04:27:36 <dreimark> re
4 2011-04-23T07:18:34 *** kursor
5 2011-04-23T10:03:48 *** kursor
6 2011-04-23T10:44:27 *** sinha
7 2011-04-23T10:49:19 *** Marchael
8 2011-04-23T10:49:37 <Marchael> moin
9 2011-04-23T11:54:19 *** sinha
10 2011-04-23T12:14:43 *** Marchael
11 2011-04-23T12:58:26 <ThomasWaldmann> moin
12 2011-04-23T13:15:07 <ronny> TheSheep: you going to ep? im in search for room sharing
13 2011-04-23T13:23:27 *** greg_f
14 2011-04-23T13:23:57 <dreimark> moin
15 2011-04-23T15:02:06 <ThomasWaldmann> btw, if someone is bored and looking for moin todo: i filled some stuff into the moin-2.0 bitbucket issue tracker
16 2011-04-23T15:17:34 <ThomasWaldmann> content_rights_valid vs. functions_rights_valid? ideas for better naming?
17 2011-04-23T15:22:43 <TheSheep> ronny: yes, but we have 4 already
18 2011-04-23T15:23:18 <TheSheep> ronny: ThomasWaldmann had a room for sharing
19 2011-04-23T15:25:47 <ronny> TheSheep: i see
20 2011-04-23T16:14:05 *** RogerHaase
21 2011-04-23T16:38:39 <RogerHaase> ThomasWaldmann: I pushed 2 small changes to BB related to interwiki. I have a failing test http://paste.pocoo.org/show/376853/ that I have not resolved. Simple interwiki links work on my test pages, but no interwiki links are recognized on the pytest.
22 2011-04-23T17:05:05 <ThomasWaldmann> the css fixes are ok
23 2011-04-23T17:05:17 <ThomasWaldmann> the changeset about interwiki looks strange
24 2011-04-23T17:05:41 <ThomasWaldmann> ah, no, i misread the comment
25 2011-04-23T17:05:55 <ThomasWaldmann> add support for interwiki links like MoinMoin:RecentChanges
26 2011-04-23T17:06:12 <ThomasWaldmann> i think we intentionally left out that stuff
27 2011-04-23T17:06:24 <ThomasWaldmann> because of too many problems
28 2011-04-23T17:07:16 <ThomasWaldmann> RogerHaase: look into moinwiki19_in.py
29 2011-04-23T17:13:25 <ThomasWaldmann> the idea is that the 19 converter is mostly compatible to moin 1.9 parser,
30 2011-04-23T17:14:41 <ThomasWaldmann> but the one without "19" gets rid of some problematic stuff, like free links (CamelCase links), free interwiki links (FooBar:BarBaz)
31 2011-04-23T17:16:36 <RogerHaase> ThomasWaldmann: On 1.9 MonMoin:FrontPage links to moinmo.in/FrontPage and displays as <icon>FrontPage, same as my changset for 2.0. Invalid links display as normal text.
32 2011-04-23T17:17:33 <ThomasWaldmann> see the code in moinwiki19_in, we already do that there
33 2011-04-23T17:17:58 <ThomasWaldmann> but we don't want that in moinwiki_in
34 2011-04-23T17:18:35 <ThomasWaldmann> (btw, what's really missing, AFAICS, is [[MoinMoin:SomePage]] support in moinwiki_in)
35 2011-04-23T17:19:40 <ThomasWaldmann> btw, have a look at what config.chars_upper and .char_lower is to see one reason why we should get rid of that
36 2011-04-23T17:21:04 <ThomasWaldmann> or write some arbitrary text to see how often you have to work against the CamelCase link magic
37 2011-04-23T17:22:10 <RogerHaase> OK, If I understand correctly now: we are trying to eliminate thinks like MoinMoin:SomePage and convert these to [[MoinMoin:SomePage]]
38 2011-04-23T17:22:36 <RogerHaase> thinks/things
39 2011-04-23T17:22:52 <ThomasWaldmann> well, conversion is not really solved yet (iirc), but we support it only in moinwiki19_in, not in moinwiki_in
40 2011-04-23T17:23:18 *** kursor
41 2011-04-23T17:24:26 <ThomasWaldmann> RogerHaase: btw, have you looked at rietveld already?
42 2011-04-23T17:26:51 <ThomasWaldmann> for moin < 1.6 CamelCase support made a lot of sense, just because non-camelcase link syntax was a even bigger pain
43 2011-04-23T17:27:54 <ThomasWaldmann> since link syntax cleanup in 1.6, it is easy to have [[non camelcase links]], so since then camelcase is the bigger pain
44 2011-04-23T17:30:41 <RogerHaase> looking at reitveld...seems to be svn?
45 2011-04-23T17:32:12 <ThomasWaldmann> no, works good with hg
46 2011-04-23T17:32:30 <ThomasWaldmann> http://codereview.appspot.com/4448041/ < playground i made
47 2011-04-23T17:33:34 <ThomasWaldmann> we can use that for codereview in general. because if one uses mercurial/bitbucket to publish a changeset for review, it is a bit problematic if the changeset can't be pulled like it is
48 2011-04-23T17:36:22 <RogerHaase> OK, will use that for next change. Will work on adding support for [[MoinMoin:SomePage]] links. (and try to figure out how to back off last change on BB).
49 2011-04-23T17:37:18 <ThomasWaldmann> well, doing a fresh clone and reapplying the good changes only would work
50 2011-04-23T17:37:27 <ThomasWaldmann> not sure if there is a more elegant way
51 2011-04-23T17:41:49 <ThomasWaldmann> upload.py works, btw
52 2011-04-23T18:42:50 *** sinha
53 2011-04-23T19:11:31 <ThomasWaldmann> hi sinha
54 2011-04-23T19:12:26 <sinha> ThomasWaldmann: Hi
55 2011-04-23T19:12:30 <ThomasWaldmann> https://bitbucket.org/sinha/moin-2.0/changeset/4e65fd38d171#chg_MoinMoin/static/js/navigate-index.js_newline66
56 2011-04-23T19:12:41 <ThomasWaldmann> i am just looking at your recent changesets
57 2011-04-23T19:12:54 <ThomasWaldmann> can you be a bit more careful with whitespace?
58 2011-04-23T19:13:28 <sinha> you mean at the end of line
59 2011-04-23T19:13:40 <ThomasWaldmann> load ,as
60 2011-04-23T19:13:56 <ThomasWaldmann> pastvalue
61 2011-04-23T19:14:13 <ThomasWaldmann> also, try to make more meaningful comments
62 2011-04-23T19:15:26 <ThomasWaldmann> e.g. if you comment a line ExpandAll(); you should never tell that you "call a ExpandAll function", that's pretty obvious
63 2011-04-23T19:15:57 <sinha> yes thats correct
64 2011-04-23T19:16:06 <ThomasWaldmann> treeState=0; //Initialize the variable to 0 i.e. tree is not is expanded state
65 2011-04-23T19:16:07 <sinha> but i didnt have anything else to write there
66 2011-04-23T19:16:18 <ThomasWaldmann> same for this one
67 2011-04-23T19:16:52 <sinha> can u suggest that what is should have written at treeState=0 line ? such that i could get some idea
68 2011-04-23T19:16:56 <ThomasWaldmann> often, if you have to comment such code, something might be wrong
69 2011-04-23T19:16:58 <sinha> /s/is/I
70 2011-04-23T19:17:33 <ThomasWaldmann> e.g. if treeState has only two states, 0 = not expanded and 1 = expanded, it should not be "treeState", but rather "treeExpanded"
71 2011-04-23T19:18:11 <sinha> okay i see
72 2011-04-23T19:18:49 <sinha> i didn't get this "often, if you have to comment such code, something might be wrong"
73 2011-04-23T19:19:33 <ThomasWaldmann> if you choose good variable names, the code might be easy understandable, even without comments
74 2011-04-23T19:19:54 <sinha> yes
75 2011-04-23T19:20:00 <ThomasWaldmann> if you have to comment trivial stuff, it might be an indication for bad names
76 2011-04-23T19:20:19 <ThomasWaldmann> if (treeState==1)
77 2011-04-23T19:20:50 <ThomasWaldmann> e.g. if that is if (treeExpanded) it reads more easily
78 2011-04-23T19:21:13 <sinha> yes
79 2011-04-23T19:21:25 <ThomasWaldmann> btw, I am not used to js coding, so you maybe know better about ==1, True/False stuff, etc.
80 2011-04-23T19:22:39 <ThomasWaldmann> but if it is just 0/1, maybe false/true is more appropriate here?
81 2011-04-23T19:23:23 <sinha> yes false/true is applicable here
82 2011-04-23T19:23:53 <sinha> but i have worked with 0/1 with other coding langs like C
83 2011-04-23T19:24:38 <ThomasWaldmann> please ignore everything you know from C :)
84 2011-04-23T19:25:25 <ThomasWaldmann> btw, is there some special reason why you leave a blank before tag-closing > in html?
85 2011-04-23T19:25:46 <ThomasWaldmann> <a id="moin-expandAll" title="{{ _("Expand or Collapse the below tree") }}" href="#" >
86 2011-04-23T19:25:49 <ThomasWaldmann> like there?
87 2011-04-23T19:29:51 <ThomasWaldmann> (maybe do a global review for such stuff in your code)
88 2011-04-23T19:31:16 <ThomasWaldmann> and maybe also try rietveld for codereview, it is nice and saves changesets
89 2011-04-23T19:35:38 *** greg_f
90 2011-04-23T19:40:35 <sinha> ThomasWaldmann: will work on codereview ! and no special reasons to leave white space at the end of tag ,just tried to make it clean 1
91 2011-04-23T19:42:19 <ThomasWaldmann> tag ,just
92 2011-04-23T19:42:28 <ThomasWaldmann> are you typing too fast? :)
93 2011-04-23T19:43:06 <sinha> i don't know,i might have got habit of doing such silly things :)
94 2011-04-23T19:43:14 <ThomasWaldmann> no problem on irc, i just noticed that this is same issue :)
95 2011-04-23T19:43:28 <sinha> yes you can say that
96 2011-04-23T19:43:51 <ThomasWaldmann> for english, it is always a blank after comma or dot or colon.
97 2011-04-23T19:44:14 <sinha> exactly
98 2011-04-23T19:44:16 <ThomasWaldmann> and never a blank before comma, dot, colon, exclamation mark, q. mark
99 2011-04-23T19:45:03 <sinha> yes i guess i need to follow these
100 2011-04-23T19:46:35 <ThomasWaldmann> btw, did you run py.test in your repo?
101 2011-04-23T19:46:36 <sinha> currently i am going through some documentation regarding jinja and flask and know about them more and as well as some moin docs and coding rules
102 2011-04-23T19:46:59 <sinha> no ! i never did
103 2011-04-23T19:47:20 <sinha> i thought it wasn't required and no one have suggested it yet 1
104 2011-04-23T19:47:20 <ThomasWaldmann> just activate the virtual env and run py.test from the toplevel dir
105 2011-04-23T19:48:29 <ThomasWaldmann> there's maybe not much for js testing yet, but e.g. it'll run the pep8 checker over the python code
106 2011-04-23T19:48:55 * sinha running py.test
107 2011-04-23T19:49:20 <ThomasWaldmann> and there are quite some failing tests currently. make sure the count does not increase due to your changes.
108 2011-04-23T19:52:13 <sinha> There are around 50 FAILED tests.
109 2011-04-23T19:54:28 *** kursor
110 2011-04-23T19:54:34 <ThomasWaldmann> i have 53, but it might depend a bit on the stuff you have installed
111 2011-04-23T19:57:25 <sinha> yes i guess so
112 2011-04-23T19:57:44 <sinha> do i need to run py.test before doing any commit ?
113 2011-04-23T19:58:08 <ThomasWaldmann> well, i would be good
114 2011-04-23T19:58:37 <ThomasWaldmann> sometimes one can avoid having to do additional changesets just to fix bugs, pep8 or whatever
115 2011-04-23T19:59:00 <ThomasWaldmann> and you can use the time while it runs to just read hg diff line by line
116 2011-04-23T19:59:15 <ThomasWaldmann> and hg status
117 2011-04-23T20:00:08 <ThomasWaldmann> one can also run tests more selectively, e.g. by giving the test filename or invoke it like py.test -k keyword
118 2011-04-23T20:01:40 <ThomasWaldmann> btw, when working on html/css/js, you may want to use some other checkers also, e.g. the validators.
119 2011-04-23T20:03:32 <sinha> okay html validators and some accessibility checks ?
120 2011-04-23T20:04:39 <sinha> This used to check web accessibility http://achecker.ca/checker/index.php
121 2011-04-23T20:15:32 <ThomasWaldmann> don't know that one, try it :)
122 2011-04-23T20:16:19 <sinha> it is throwing around 76 errors on moinmo.in homepage
123 2011-04-23T20:16:52 <ThomasWaldmann> that's moin 1.9 then
124 2011-04-23T20:25:01 *** ronny
125 2011-04-23T20:33:37 * ThomasWaldmann splits acls into content acls and function acls
126 2011-04-23T20:34:26 <ThomasWaldmann> TheSheep: i am still searching for a good name, but I didn't fully get the sentient (idea|joke)
127 2011-04-23T20:35:47 <ThomasWaldmann> acl_functions = u'JoeDoe:superuser TrustedEditorGroup:notextcha' # that's how it looks like right now
128 2011-04-23T20:37:09 <ThomasWaldmann> (and someone with admin rights can't get superuser capability by editing a revision, because superuser is not a content capability, so the content acl won't understand and will ignore it)
129 2011-04-23T20:37:42 *** ronny
130 2011-04-23T20:51:32 <TheSheep> ThomasWaldmann: as in "not bot"
131 2011-04-23T20:51:47 <TheSheep> ThomasWaldmann: it was a bad joke
132 2011-04-23T21:26:35 *** RogerHaase
133 2011-04-23T21:34:51 *** sinha
134 2011-04-23T21:51:57 <CIA-25> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 185:fa88b784cd08 2.0/MoinMoin/ (11 files in 7 dirs): (log message trimmed)
135 2011-04-23T21:51:57 <CIA-25> split ACLs into ACLs to control functionality access and ACLs to control content access
136 2011-04-23T21:51:57 <CIA-25> related wikiconfig attributes:
137 2011-04-23T21:51:57 <CIA-25> acl_functions - Access Control List for functions
138 2011-04-23T21:51:57 <CIA-25> acl_rights_contents - Valid tokens for right sides of content ACL entries
139 2011-04-23T21:51:58 <CIA-25> acl_rights_functions - Valid tokens for right sides of function ACL entries
140 2011-04-23T21:51:59 <CIA-25> FunctionACL - subclass of AccessControlList accepting stuff valid for function acls
141 2011-04-23T23:39:19 * ThomasWaldmann write a require_permission decorator
142 2011-04-23T23:52:34 <CIA-25> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 186:5dd1db45ed55 2.0/MoinMoin/ (apps/admin/views.py security/__init__.py): implement require_permission decorator
