1 2011-05-27T00:17:50 <ThomasWaldmann> ok
2 2011-05-27T00:29:03 *** m4k3r
3 2011-05-27T00:32:10 <ThomasWaldmann> RogerHaase: so it's all in those 3 changesets?
4 2011-05-27T00:33:05 <ThomasWaldmann> btw, did you change name/email? it doesn't map 2 of 3 changesets to bb user
5 2011-05-27T00:35:01 <RogerHaase> 1 is just deleting badinterwiki class name which is no longer used, 2 is replacing white_cloud.png file with jpg, 3 is interwiki/mailto fixes
6 2011-05-27T00:35:26 <RogerHaase> I don't understand change name/email?
7 2011-05-27T00:35:59 <ThomasWaldmann> https://bitbucket.org/RogerHaase/moin-2.0/overview
8 2011-05-27T00:36:13 <ThomasWaldmann> compare 1. / 2. with 3. changeset
9 2011-05-27T00:37:58 <RogerHaase> oh, guess I need practice forking
10 2011-05-27T00:39:36 <RogerHaase> hmm, not sure how I did that or how to correct it
11 2011-05-27T00:41:17 <RogerHaase> OK, think I got it, try refreshing bb page
12 2011-05-27T00:43:00 <ThomasWaldmann> looks better now. did you change name/email?
13 2011-05-27T00:45:01 *** grzywacz
14 2011-05-27T00:45:17 <RogerHaase> I cloned your 2.0 bb locally, rebuilt all my changes on top of it and pushed all 3 changes at once. I don't understand how the last 2 did not recognize my name.
15 2011-05-27T00:45:37 <ThomasWaldmann> https://bitbucket.org/RogerHaase/moin-2.0/changeset/a74e93f21623 line 752
16 2011-05-27T00:46:09 <ThomasWaldmann> where does the new code eat the // ?
17 2011-05-27T01:00:43 <RogerHaase> I think the (%(url_schemas)s): skips past the //
18 2011-05-27T01:07:38 <ThomasWaldmann> no, that just eats proto and :
19 2011-05-27T01:07:42 <RogerHaase> bad answer, gtg now, will get back with a better answer tomorrow
20 2011-05-27T01:07:53 <ThomasWaldmann> ok, thanks
21 2011-05-27T01:08:06 *** RogerHaase
22 2011-05-27T01:48:57 *** ronny
23 2011-05-27T02:01:29 *** ronny
24 2011-05-27T05:04:32 *** Marchael
25 2011-05-27T05:08:14 <Marchael> moin
26 2011-05-27T05:38:37 *** Marchael
27 2011-05-27T05:39:19 *** Marchael
28 2011-05-27T06:18:38 *** m4k3r
29 2011-05-27T06:27:38 <Marchael> hm, cool.
30 2011-05-27T06:27:48 * Marchael write first working test
31 2011-05-27T06:28:11 <Marchael> Althought it was peace of cake, but /me happy :)
32 2011-05-27T06:35:10 <Marchael> ThomasWaldmann: Now, what set of values I should use for testing tokenizer? My tokenizers based on ContencAcl and Type classes, it is already tested
33 2011-05-27T07:40:10 *** m4k3r
34 2011-05-27T07:42:37 <ThomasWaldmann> moin
35 2011-05-27T07:43:52 <ThomasWaldmann> Marchael: in general you use sets of input data that cover all cases, that trigger all code pathes
36 2011-05-27T07:44:17 <Marchael> ThomasWaldmann: also, look at ep
37 2011-05-27T07:48:17 *** m4k3r
38 2011-05-27T07:54:55 *** m4k3r
39 2011-05-27T09:40:39 *** hardy_89
40 2011-05-27T09:40:45 *** hardy_89
41 2011-05-27T10:01:14 *** hardy_89
42 2011-05-27T10:03:35 <hardy_89> hi ThomasWaldmann
43 2011-05-27T10:03:50 <hardy_89> i made a change in setup.py
44 2011-05-27T10:04:05 <hardy_89> and changed the py.test 1.3.4 to pytest
45 2011-05-27T10:04:13 <hardy_89> deleted the related repo
46 2011-05-27T10:04:22 <hardy_89> run ./quickinstall
47 2011-05-27T10:04:26 <hardy_89> but NOW
48 2011-05-27T10:04:34 <hardy_89> my test refuse to run
49 2011-05-27T10:06:54 <ThomasWaldmann> hardy_89: hi. i guess your mentor(s) and your fellow student can answer that much better.
50 2011-05-27T10:07:22 <hardy_89> ThomasWaldmann: i've msgd pkumar to come in.
51 2011-05-27T10:07:25 <ThomasWaldmann> you could also just have a look at pkumar's repo maybe.
52 2011-05-27T10:07:34 <hardy_89> ThomasWaldmann: we've been working on it since yesterday
53 2011-05-27T10:07:50 <hardy_89> ThomasWaldmann: i pulled it too. did ./quickinstall
54 2011-05-27T10:07:54 <hardy_89> yet no win
55 2011-05-27T10:08:15 <ThomasWaldmann> and create your diary, NOW
56 2011-05-27T10:09:11 <hardy_89> ThomasWaldmann: sure
57 2011-05-27T10:09:56 * ThomasWaldmann can't comment on pytest2 stuff, didn't try it yet. but as there are 2 students, 2 mentors and ronny working on that, that should be enough.
58 2011-05-27T10:10:17 <hardy_89> ThomasWaldmann: 2 mentors?
59 2011-05-27T10:10:21 <hardy_89> waldi is one
60 2011-05-27T10:10:28 <hardy_89> who's the other mentor?
61 2011-05-27T10:10:28 <ronny> hi
62 2011-05-27T10:10:38 <hardy_89> ronny: hi :)
63 2011-05-27T10:10:47 <ThomasWaldmann> hardy_89: pkumar's mentor is xoraxax, obviously
64 2011-05-27T10:10:57 <ronny> hardy_89: there are some branches around that fix the issues
65 2011-05-27T10:11:06 <ronny> hardy_89: the defaul branch does NOT work with pytest2
66 2011-05-27T10:11:27 <ronny> a starting point is my and pkumars forks on bitbucket
67 2011-05-27T10:11:44 <ronny> his fixes a few more things on top of mine i think
68 2011-05-27T10:12:16 <hardy_89> ronny: all right. checking...
69 2011-05-27T10:13:01 <hardy_89> ronny:I cloned his repo yesterday only.
70 2011-05-27T10:13:15 <ronny> hardy_89: you might need to update to the pytest2 branch
71 2011-05-27T10:14:16 <hardy_89> ronny: this is what i get --> http://paste.pocoo.org/show/396050/
72 2011-05-27T10:16:22 <ronny> afair that as fixed on pkumars stuff
73 2011-05-27T10:16:29 <ronny> (its renamed to exc)
74 2011-05-27T10:17:02 <hardy_89> ronny: ok
75 2011-05-27T10:26:33 *** hardy_89
76 2011-05-27T10:28:29 *** hardy_89
77 2011-05-27T10:51:54 *** andialbrecht_
78 2011-05-27T11:25:15 *** hardy_89
79 2011-05-27T12:01:57 *** Marchael
80 2011-05-27T12:18:16 *** greg_f
81 2011-05-27T12:27:14 *** hardy_89
82 2011-05-27T12:34:10 *** pkumar
83 2011-05-27T12:34:41 <pkumar> ronny: hi ronny. Need your help again. :)
84 2011-05-27T12:36:22 <pkumar> ronny: the tests in pytest runs slower than py.test and it also have so many function calls
85 2011-05-27T12:36:46 <pkumar> for pytest : http://paste.pocoo.org/show/396100/
86 2011-05-27T12:37:01 <pkumar> for py.test: http://paste.pocoo.org/show/396101/
87 2011-05-27T12:39:09 <ronny> pkumar: seeems WAAAAAY off
88 2011-05-27T12:39:22 <pkumar> the results are just for the code:
89 2011-05-27T12:39:30 <pkumar> import pytest
90 2011-05-27T12:39:33 *** Marchael
91 2011-05-27T12:39:35 <pkumar> and import py.test
92 2011-05-27T12:39:43 <ronny> ok
93 2011-05-27T12:39:45 <pkumar> in both the cases
94 2011-05-27T12:39:57 <ronny> pkumar: well, py.test goes via pylibs apipkg, then grabs pytest into it
95 2011-05-27T12:40:38 <ronny> oh, and you dont do import py.test
96 2011-05-27T12:40:45 <ronny> you do import py, then use py.test
97 2011-05-27T12:41:34 <ronny> pkumar: btw, how do you run the profiler?
98 2011-05-27T12:42:31 <ronny> pkumar: ok, the real difference is that for some reason, the py.test import will trigger the initial module setup of pytest
99 2011-05-27T12:42:46 <pkumar> I just used the command: python -m cProfile test_sample.py
100 2011-05-27T12:43:15 <pkumar> in case of pytest2 I just imported pytest
101 2011-05-27T12:44:20 <pkumar> import pytest
102 2011-05-27T12:45:15 <pkumar> and for other tests in MoinMoin these tests varies a lot more
103 2011-05-27T12:45:19 <pkumar> ronny: ^
104 2011-05-27T12:45:39 <pkumar> lots of function calls and time difference
105 2011-05-27T12:45:51 <ronny> pkumar: ok, the reason is simple, the py.test aliasmodule does some extra hops to initialize pytest and provide compatibility
106 2011-05-27T12:46:42 <ronny> but that should happen anyway
107 2011-05-27T12:48:40 <pkumar> ronny: yeah, so doesn't it make it kind'a less efficient (I'm not sure of it). or can we do something to reduce these many number of function calls?
108 2011-05-27T12:53:33 <pkumar> ronny: ?
109 2011-05-27T12:59:09 <ronny> pkumar: it doesnt happen on every import, only the first one
110 2011-05-27T13:07:02 <pkumar> ronny: Also as you had suggested, I looked into generators but not sure how to intercept them to run them as single test items. I would be great if you could suggest something for it.
111 2011-05-27T13:07:20 <pkumar> It*
112 2011-05-27T13:11:12 <ronny> pkumar: inspect.isgeneratorfunction
113 2011-05-27T13:11:18 <ronny> in makeitem
114 2011-05-27T13:12:40 <ronny> i suppose a subclass of function would help
115 2011-05-27T13:12:54 <ronny> one that takes the generator, but overrides runtest
116 2011-05-27T13:15:25 <ronny> pkumar: actually it might suffice if you make it functions, and override pyfunc_call
117 2011-05-27T13:22:55 <pkumar> so, I need create such functions in all the generator tests right?
118 2011-05-27T13:23:04 <pkumar> ronny: ^
119 2011-05-27T13:23:27 <ronny> pkumar: no, you need the makeitem hook and a extension of the pyfunc_call hook
120 2011-05-27T13:23:33 <ronny> (to make them work for now
121 2011-05-27T13:24:43 <pkumar> make the hooks in conftest.py?
122 2011-05-27T13:25:00 <ronny> yes
123 2011-05-27T13:25:10 <ronny> basically you create function items even for generator, but have a custom pyfunc_call that will consume the iterators
124 2011-05-27T13:31:16 <pkumar> ronny: ok, I'll try that out. thanks
125 2011-05-27T13:31:27 <pkumar> :)
126 2011-05-27T13:36:31 *** Marchael
127 2011-05-27T13:53:55 <eSyr> btw, note about diary: it's nice if one would add level 1 headings on separate day pages, in that case they'll be showed up in tooltips in monthcalendar macro.
128 2011-05-27T13:55:00 <eSyr> (also, HelpOnMacro/Include contains nice examples of usinc Include macro to include complete diary, or most fresh entries, on some page)
129 2011-05-27T13:55:08 <eSyr> *using
130 2011-05-27T14:06:48 *** hardy_89
131 2011-05-27T14:08:57 *** m4k3r
132 2011-05-27T14:18:36 <dreimark> moin
133 2011-05-27T14:28:58 <pkumar> xorAxAx: http://moinmo.in/pkumar_diary/2011-05-26
134 2011-05-27T14:30:28 *** m4k3r
135 2011-05-27T14:32:02 *** m4k3r
136 2011-05-27T14:35:17 *** pkumar
137 2011-05-27T15:10:03 <xorAxAx> cool
138 2011-05-27T15:11:53 <xorAxAx> pkumar, please regenerate the profile stats in a sorted manner
139 2011-05-27T15:14:15 <ThomasWaldmann> how is that profile useful for us?
140 2011-05-27T16:04:22 *** Marchael
141 2011-05-27T16:05:01 *** andialbrecht
142 2011-05-27T17:20:38 *** RogerHaase
143 2011-05-27T17:24:50 <RogerHaase> ThomasWaldmann: re. line 752 of https://bitbucket.org/RogerHaase/moin-2.0/changeset/a74e93f21623, the // does not get eaten here: the iri (with or without a //) is placed into link_url and passed to Iri of iri.py.
144 2011-05-27T17:25:41 <RogerHaase> ThomasWaldmann: removing the // enables mailto: to be recognized and passed along as an iri.
145 2011-05-27T17:38:10 <ThomasWaldmann> RogerHaase: so, nothing is malfunctioning although the behaviour with // changed?
146 2011-05-27T17:38:33 <ThomasWaldmann> i was just wondering because the // stuff only changed at one place, but no other change was made
147 2011-05-27T17:39:03 <ThomasWaldmann> I mean the link_url was without // before the change, right=
148 2011-05-27T17:39:04 <ThomasWaldmann> ?
149 2011-05-27T17:46:58 <RogerHaase> I used moinwiki19_in as an example ~ line 134. Using the url_schemas is more specific than looking for a character string followed by :/.
150 2011-05-27T17:47:51 <ThomasWaldmann> yeah, that change is great
151 2011-05-27T17:48:13 <ThomasWaldmann> just theoretically wondering about unwanted side effects.
152 2011-05-27T17:48:41 <ThomasWaldmann> tests (automated and manual) for http://server/path work?
153 2011-05-27T17:52:26 <RogerHaase> http://paste.pocoo.org/show/396265/
154 2011-05-27T17:55:00 <ThomasWaldmann> hmm, some strange errors there
155 2011-05-27T17:55:11 <ThomasWaldmann> did you also have 53 fails before that change?
156 2011-05-27T17:55:24 <RogerHaase> I cannot say everything is now working, I claim more things are working than before (interwiki and mailto).
157 2011-05-27T17:56:55 <ThomasWaldmann> can you locate the test that tests your code with http://... and see if it works?
158 2011-05-27T17:57:55 <ThomasWaldmann> ehrm, looks like all moinwiki*_in are working. then please only look whether we HAVE such a test :)
159 2011-05-27T17:58:17 <ThomasWaldmann> if so, I'll pull/merge :)
160 2011-05-27T18:06:07 <RogerHaase> 3rd test of test_moinwiki_in.py is : (u'[[http://moinmo.in/]]',
161 2011-05-27T18:06:07 <RogerHaase> '<page><body><p><a xlink:href="http://moinmo.in/">http://moinmo.in/</a></p></body></page>'),
162 2011-05-27T18:07:13 <RogerHaase> miscounted, it is 4th test
163 2011-05-27T18:09:21 <RogerHaase> 7th test is: (u'{{http://moinmo.in/}}',
164 2011-05-27T18:09:22 <RogerHaase> '<page><body><p><object xlink:href="http://moinmo.in/" /></p></body></page>', None, 'unknown'),
165 2011-05-27T18:16:41 <ThomasWaldmann> ok, looks good. not sure why, but still :)
166 2011-05-27T18:17:28 <RogerHaase> I am confused again. Let me do one more test.
167 2011-05-27T18:20:44 <ThomasWaldmann> i see one test_sourcecode fail, btw. in text_csv_in.py - did you do changes there?
168 2011-05-27T18:24:05 <RogerHaase> no changes made to text_csv_in.py.
169 2011-05-27T18:32:14 <RogerHaase> New bug found, If I try to create a page with {{http://moinmo.in}} I get a traceback. But on test.moinmo.in, I get an Internal Server Error.
170 2011-05-27T18:35:23 <ThomasWaldmann> hehe. maybe use some url WITH path.
171 2011-05-27T18:38:55 <RogerHaase> Yes, that "works", embedding it within a paragraph also "works"
172 2011-05-27T18:39:24 <RogerHaase> OK, I think the change is good to go
173 2011-05-27T18:48:31 <ronny> hmm
174 2011-05-27T19:00:41 <Marchael> ThomasWaldmann: I write additional test http://paste.pocoo.org/show/396306/
175 2011-05-27T19:00:41 <Marchael> but don't what to do with unicode test
176 2011-05-27T19:11:15 <ronny> Marchael: that one looks like a good canidate for generative tests
177 2011-05-27T19:22:08 <ThomasWaldmann> ronny: we begin easy :)
178 2011-05-27T19:23:04 <ronny> heh
179 2011-05-27T19:23:14 <ThomasWaldmann> Marchael: you did not understand the point
180 2011-05-27T19:24:13 <ThomasWaldmann> use a list of input/output tuples, start with easy ones (not such a monster as you have right now) and proceed to more complex ones
181 2011-05-27T19:25:11 <ThomasWaldmann> and please use correct python syntax
182 2011-05-27T19:25:30 <Marchael> ThomasWaldmann: this is not a monster, It was example from test_security
183 2011-05-27T19:25:35 <Marchael> :)
184 2011-05-27T19:25:46 <ThomasWaldmann> it is a monster, much too complex
185 2011-05-27T19:26:03 <ThomasWaldmann> and that you copied it from existing code doesn't imply it's great
186 2011-05-27T19:27:46 <ThomasWaldmann> e.g. begin with a trivial edge case, like u"" as input
187 2011-05-27T19:28:05 <ThomasWaldmann> that shouldn't crash your code, but yield reasonable output
188 2011-05-27T19:28:21 <ThomasWaldmann> then proceed to other simple cases, like
189 2011-05-27T19:29:04 <ThomasWaldmann> u"Default" and u"JoeDoe:read,write"
190 2011-05-27T19:29:39 <ThomasWaldmann> etc.
191 2011-05-27T19:29:45 * ThomasWaldmann brb
192 2011-05-27T19:30:36 <Marchael> ThomasWaldmann: I not quite understand your point. I we've one(althought a big test value) why we should split it on many pieces?
193 2011-05-27T19:40:26 *** greg_f
194 2011-05-27T19:51:38 <Marchael> ThomasWaldmann: pls, highlogjt me when you go back
195 2011-05-27T19:54:53 <ronny> ok
196 2011-05-27T19:55:34 <ronny> ThomasWaldmann: i digured why pkumar found that small amount of calls in import py.test for pytest1.3, i remembered everything in it is actually completely lazy-loaded
197 2011-05-27T19:55:38 <ronny> *figured
198 2011-05-27T20:05:37 <ThomasWaldmann> Marchael: if that big one fails, who wants to waste half and hour analysing what exactly failed?
199 2011-05-27T20:06:16 <ThomasWaldmann> an*
200 2011-05-27T20:06:41 <ThomasWaldmann> thus i'ld like multipe smaller ones, each one for one aspect of the problem
201 2011-05-27T20:18:00 * Marchael backs
202 2011-05-27T20:18:35 <Marchael> reasonable
203 2011-05-27T20:35:07 <dreimark> bbl
204 2011-05-27T20:44:38 *** RogerHaase
205 2011-05-27T20:47:32 *** RogerHaase
206 2011-05-27T20:49:56 <CIA-69> Roger Haase <crosseyedpenguin@yahoo.com> default * 238:58fc3bb9cee5 2.0/MoinMoin/themes/modernized/static/css/common.css: remove unused classes badinterwiki and moin-badinterwiki
207 2011-05-27T20:49:57 <CIA-69> RogerHaase default * 239:144b6aa9516d 2.0/MoinMoin/themes/modernized/static/ (css/common.css img/white-clouds.jpg img/white_clouds.png): replace white_clouds.png file with smaller white-clouds.jpg
208 2011-05-27T20:49:57 <CIA-69> RogerHaase default * 240:a74e93f21623 2.0/MoinMoin/converter/ (5 files in 2 dirs): correct rendering of interwiki and mailto links
209 2011-05-27T21:04:46 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/396339/
210 2011-05-27T21:16:34 <ThomasWaldmann> if you look at that code, do you see anything remarkable
211 2011-05-27T21:16:47 <ThomasWaldmann> ?
212 2011-05-27T21:17:47 <Marchael> you mean 3 repeated lines in each test?
213 2011-05-27T21:17:55 <ThomasWaldmann> yes
214 2011-05-27T21:18:14 <Marchael> oh
215 2011-05-27T21:18:19 <ThomasWaldmann> a simple for loop would've done it
216 2011-05-27T21:21:27 <ronny> make it a generative test?
217 2011-05-27T21:21:40 <Marchael> ThomasWaldmann: I should write a function with this 3 lines?
218 2011-05-27T21:21:44 <ronny> and really just list case name, input, output
219 2011-05-27T21:21:51 <Marchael> and call it in each test
220 2011-05-27T21:21:53 <Marchael> ?
221 2011-05-27T21:24:03 <Marchael> ah, loop in tuple
222 2011-05-27T21:24:06 <Marchael> great
223 2011-05-27T21:24:16 <ThomasWaldmann> for i, e in testcases:
224 2011-05-27T21:24:22 <Marchael> yes
225 2011-05-27T21:24:22 <ThomasWaldmann> o = f(i)
226 2011-05-27T21:24:28 <ThomasWaldmann> assert o == e
227 2011-05-27T21:56:01 <Marchael> I got "ValueError: need more than 1 value to unpack" when trying loop
228 2011-05-27T21:56:46 <Marchael> http://paste.pocoo.org/show/396355/
229 2011-05-27T22:02:14 <ThomasWaldmann> so, what is the question?
230 2011-05-27T22:03:18 <Marchael> what right type for value_list?
231 2011-05-27T22:03:22 <ThomasWaldmann> and can you pleeease check the data type of meta[ACL] before continuing to do strange tests
232 2011-05-27T23:14:07 <ronny> oO
233 2011-05-27T23:37:47 <dreimark> Marchael: s/inpt, outpt/input, output/
234 2011-05-27T23:37:56 <dreimark> in http://paste.pocoo.org/show/396339/
235 2011-05-27T23:38:30 <ThomasWaldmann> nope
