1 2011-05-30T00:00:20 <CIA-69> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 246:727e03c59dbf 2.0/MoinMoin/ (apps/frontend/views.py items/__init__.py): simplify form validation check, fix indentation
2 2011-05-30T00:13:34 <RogerHaase> ThomasWaldmann: dreimark: one more try on transclusion overlays: http://codereview.appspot.com/4535086/
3 2011-05-30T00:14:21 <RogerHaase> overlay now looks like this: http://test.moinmo.in/AlternativeTransclusionOverlay
4 2011-05-30T00:16:08 <ThomasWaldmann> why is it showing the angles for multiple objects?
5 2011-05-30T00:18:08 <RogerHaase> when transcluding paragraphs of text into pages of text, it is helpful to show the size of the transcluded item. (it is less helpful as shown in tables.)
6 2011-05-30T00:18:37 <RogerHaase> The example is nested 3 levels deep.
7 2011-05-30T00:22:44 <ThomasWaldmann> yes, but shouldn't it just show the angles for the item where the mouseover is?
8 2011-05-30T00:24:40 <RogerHaase> It does. In this case the mouse pointer is over 3 nested transcluded items.
9 2011-05-30T00:25:39 <ThomasWaldmann> but not over their left corners, that is just one
10 2011-05-30T00:27:32 <RogerHaase> Yes, mousing over a transcluded item shows ul and lr corners of item overlays. Mousing over either ul or lr overlay shows the overlay background and arrow.
11 2011-05-30T00:40:48 <ThomasWaldmann> can you make it so it just shows the current object's corners?
12 2011-05-30T00:46:50 <RogerHaase> Probably, but in most cases there will only be 1 transclusion and if there are nested transclusions it is helpful to show all so one understands the page.
13 2011-05-30T00:52:15 <RogerHaase> gtg, dinner time here
14 2011-05-30T01:05:21 *** m4k3r
15 2011-05-30T01:48:55 *** ronny
16 2011-05-30T02:01:49 *** ronny
17 2011-05-30T03:52:26 *** RogerHaase
18 2011-05-30T03:59:06 *** xorAxAx
19 2011-05-30T03:59:51 *** xorAxAx
20 2011-05-30T05:56:00 *** Marchael
21 2011-05-30T05:56:30 <Marchael> moin
22 2011-05-30T09:08:37 * dreimark Linus Torvalds Approves Linux 3.0 RC1
23 2011-05-30T09:53:02 *** andialbrecht_
24 2011-05-30T09:59:18 <waldi> no, he decided
25 2011-05-30T10:04:00 *** ronny
26 2011-05-30T10:19:19 <Marchael> may be stupid question, but what is meta[ACL]?
27 2011-05-30T10:30:12 <dreimark> Marchael: we moved every command from text 1.9 to meta in 2.0
28 2011-05-30T10:30:44 <dreimark> if you had before #acl User:read on top of the text
29 2011-05-30T10:30:49 <dreimark> you now have it meta
30 2011-05-30T10:33:31 <dreimark> Marchael: see
31 2011-05-30T10:33:38 <dreimark> from MoinMoin.config import ACL
32 2011-05-30T10:35:12 <Marchael> ok
33 2011-05-30T10:35:13 <Marchael> thx
34 2011-05-30T11:04:54 *** ronny
35 2011-05-30T11:10:04 <ThomasWaldmann> moin
36 2011-05-30T11:11:51 <ronny> moin
37 2011-05-30T11:13:13 *** greg_f
38 2011-05-30T11:34:19 <Marchael> ThomasWaldmann: hi
39 2011-05-30T11:34:24 <Marchael> http://paste.pocoo.org/show/397575/
40 2011-05-30T11:41:47 <ThomasWaldmann> please decide whether you want " or '
41 2011-05-30T11:43:00 <ThomasWaldmann> compare 19 to 22
42 2011-05-30T11:43:28 <Marchael> oops
43 2011-05-30T11:44:05 <ThomasWaldmann> are those trailing blanks in input data required?
44 2011-05-30T11:45:42 <Marchael> may be it's will be good for testing
45 2011-05-30T11:46:48 * Marchael update previous paste
46 2011-05-30T11:46:55 <Marchael> *updated
47 2011-05-30T11:47:05 <ThomasWaldmann> btw, you did not do a single commit/push yet
48 2011-05-30T11:49:18 <ThomasWaldmann> s/value_list/test_cases/
49 2011-05-30T11:49:55 <ThomasWaldmann> what is testUnicode good for?
50 2011-05-30T11:50:49 <ThomasWaldmann> and where does that AssertionError come from?
51 2011-05-30T11:51:53 <ThomasWaldmann> new pastebin please after you did ALL changes
52 2011-05-30T11:57:23 <Marchael> testUnicode checks what given string in Unicode, if it useless I'll remove this.
53 2011-05-30T11:57:23 <Marchael> AssertionError comes from ContentACL I guess
54 2011-05-30T11:59:08 <ThomasWaldmann> well, if not the test code raises the AssertionError, but code you call, you maybe should add a comment about what exactly you are testing and where the AE comes from
55 2011-05-30T11:59:51 <ThomasWaldmann> s/acl_token/acl_tokenizer/
56 2011-05-30T12:00:18 <ThomasWaldmann> what's "its"?
57 2011-05-30T12:01:38 <ThomasWaldmann> isn't it a "token"?
58 2011-05-30T12:02:17 * ThomasWaldmann brb
59 2011-05-30T12:02:26 <Marchael> yes, it's a token
60 2011-05-30T12:22:43 <Marchael> http://paste.pocoo.org/show/397600/
61 2011-05-30T12:35:21 <ThomasWaldmann> isn't 103 a list of tokens? (NOT a list of ACLs)
62 2011-05-30T12:35:56 <ThomasWaldmann> same 101, it isn't expected_acl, it is expected_tokens
63 2011-05-30T12:36:49 <ThomasWaldmann> 101 testing_acl (it is not just a right [like read, write], but a complete access control list)
64 2011-05-30T12:37:43 <ThomasWaldmann> it seems that you are unclear about the meaning of +/- in ACLs, please read HelpOnAccessControlLists
65 2011-05-30T12:37:56 <ThomasWaldmann> (or the new docs about it in moin2)
66 2011-05-30T12:38:07 <Marchael> ok
67 2011-05-30T12:38:56 <ThomasWaldmann> for the tokenizer output, we can define what +/- in front of the right means
68 2011-05-30T12:39:38 <ThomasWaldmann> but from the tests it seems a bit confusing regarding whether +Joe:read shall really give same output as Joe:read
69 2011-05-30T12:40:38 <ThomasWaldmann> you can do it like that maybe, but then behaviour should be specified / explained (e.g. in the code which latest version i did not see yet)
70 2011-05-30T12:43:15 <ThomasWaldmann> also, about these trailing spaces: if they are not required, you should leave them away
71 2011-05-30T12:43:43 <ThomasWaldmann> and then duplicate one test case and just add some spaces to see if it results in same output (but do no other change then)
72 2011-05-30T12:44:43 <ThomasWaldmann> also, think about the usage of list data type - does ORDER really matter in those tokens? or are you testing a implementation detail that is unimportant?
73 2011-05-30T12:45:00 <ThomasWaldmann> in case order does not matter, what would be a better data type?
74 2011-05-30T12:45:03 <ThomasWaldmann> gtg/bbl
75 2011-05-30T12:46:44 *** sinha
76 2011-05-30T13:04:48 *** sinha
77 2011-05-30T13:36:24 <Marchael> ThomasWaldmann: 74, 94
78 2011-05-30T13:36:26 <Marchael> on ep
79 2011-05-30T14:12:29 <Marchael> ThomasWaldmann: I think what order is don't really matter, because tokenizer should do only parsing, not checking user rights on different objects.
80 2011-05-30T14:20:08 <Marchael> also, what you mean "better data type"? For better type for what?
81 2011-05-30T14:20:24 <Marchael> s/For better/better/
82 2011-05-30T15:17:17 *** sinha
83 2011-05-30T15:54:40 *** andialbrecht
84 2011-05-30T16:07:12 <dreimark> sinha: moin
85 2011-05-30T16:07:30 <sinha> dreimark: hi
86 2011-05-30T16:07:58 <sinha> dreimark: was travelling last weekend back to hostel, didnt able to work those days, will compensate them this week
87 2011-05-30T16:08:37 <dreimark> sinha: ok, please give some infos to your diary pages
88 2011-05-30T16:08:46 <dreimark> and if possible do some commits
89 2011-05-30T16:09:14 <dreimark> there is also a cia.vc client for bitbucket avail. so we can see incoming commits in this channel
90 2011-05-30T16:09:55 <sinha> dreimark:okay, will update diary regularly now onwards
91 2011-05-30T16:26:11 <sinha> dreimark: i am still stuck at that format_date function of babel, does anyone know what data type pass or how to convert timestamp into date using babel ?
92 2011-05-30T16:51:00 *** sinha
93 2011-05-30T16:56:42 <Marchael> ThomasWaldmann: also, we don't discussed question: "What happend if user will search for rev_no && acl for example?"
94 2011-05-30T16:58:53 <Marchael> I'm not sure what someone will do this, but revisions_schema doesn't content acl field, so user can't search for acl & rev_no simultaneously
95 2011-05-30T16:59:13 <Marchael> or in one time
96 2011-05-30T17:10:36 <Marchael> bbl
97 2011-05-30T17:10:40 *** Marchael
98 2011-05-30T17:31:30 *** m4k3r
99 2011-05-30T17:37:21 *** ronny
100 2011-05-30T17:40:35 *** kursor
101 2011-05-30T17:55:00 *** RogerHaase
102 2011-05-30T18:11:14 *** sinha
103 2011-05-30T18:23:46 <ThomasWaldmann> sinha: do you have uncommitted stuff in your workdir?
104 2011-05-30T18:24:03 <sinha> yes..i am stuck at one place
105 2011-05-30T18:24:04 <ThomasWaldmann> or unpushed changesets in your local repo?
106 2011-05-30T18:24:15 <sinha> i just need help in these thing
107 2011-05-30T18:24:25 <ThomasWaldmann> so, why don't you ask? :)
108 2011-05-30T18:24:29 <sinha> how to convert a timestamp to date through babel
109 2011-05-30T18:24:37 <sinha> i have asked it here many times.
110 2011-05-30T18:24:59 <ThomasWaldmann> well, I've looked into babel and seen why it behaves differently for date/datetime
111 2011-05-30T18:25:06 <sinha> i dont knwo how to use format_date function of babel for the timestamp
112 2011-05-30T18:25:12 <sinha> s/knwo/know
113 2011-05-30T18:25:27 <sinha> all other functions in dates.py are working for timestamp
114 2011-05-30T18:25:28 <dreimark> sinha: https://gist.github.com/988517
115 2011-05-30T18:25:32 <ThomasWaldmann> read the respective src of babel, it doesn't accept timestamps there
116 2011-05-30T18:26:17 <sinha> so how to do that ? can i write my own function
117 2011-05-30T18:26:50 <sinha> by using timezone of user
118 2011-05-30T18:26:56 <ThomasWaldmann> sinha: you could try to fix babel (if it is fixable) or provide an acceptable data type to format_date
119 2011-05-30T18:27:33 <sinha> what is that data type to be given to format_date function ?
120 2011-05-30T18:27:49 <ThomasWaldmann> use the source, luke
121 2011-05-30T18:28:28 <ThomasWaldmann> and maybe show your source more often, I don't know how your are using it currently
122 2011-05-30T18:28:44 * dreimark asked for a commit too
123 2011-05-30T18:29:05 <sinha> okay will do one in next half hour
124 2011-05-30T18:32:34 <ThomasWaldmann> btw, also note that the day boundaries are different depending on in which TZ the user is
125 2011-05-30T18:34:07 <ThomasWaldmann> http://babel.edgewall.org/wiki/Documentation/0.9/dates.html
126 2011-05-30T18:49:29 *** kursor
127 2011-05-30T18:57:59 *** greg_f
128 2011-05-30T19:02:13 *** ronny
129 2011-05-30T19:08:52 <dreimark> bbl
130 2011-05-30T19:54:21 *** sinha
131 2011-05-30T19:54:22 *** sinha1
132 2011-05-30T20:04:43 *** hardy89
133 2011-05-30T20:34:35 *** hardy89
134 2011-05-30T20:57:10 <ThomasWaldmann> re
135 2011-05-30T20:58:50 <sinha1> ThomasWaldmann: in showing global history, there is no translation done as of now ? ex. for showing content type ..so should i bother about this ?
136 2011-05-30T21:03:02 <ThomasWaldmann> translation like?
137 2011-05-30T21:03:49 * ThomasWaldmann wouldn't translate "text/plain"
138 2011-05-30T21:07:35 <sinha1> okay and also shouldn't translate the action like SAVE,TRASH,COPY etc ? i have used them in title attribute
139 2011-05-30T21:11:28 <ThomasWaldmann> not now
140 2011-05-30T21:12:06 <ThomasWaldmann> i was thinking about whether I'ld get rid of that "action", but didn't decide yet
141 2011-05-30T21:13:05 <sinha1> okay
142 2011-05-30T21:34:23 <sinha1> ThomasWaldmann: dreimark: changeset for grouping of the global history https://bitbucket.org/sinha/moin2/changeset/b07dfe4ceb8d
143 2011-05-30T21:38:06 <ronny> hi
144 2011-05-30T21:39:25 <ThomasWaldmann> sinha1: that only works correctly for users in utc timezone, right?
145 2011-05-30T21:41:54 <sinha1> what that format_date function of babel ?
146 2011-05-30T21:42:07 <ThomasWaldmann> ?
147 2011-05-30T21:42:48 <sinha1> yes it is always showing the utc timing
148 2011-05-30T21:46:32 <ThomasWaldmann> not only that
149 2011-05-30T21:46:44 <ThomasWaldmann> it also likely does the grouping in utc tz
150 2011-05-30T21:47:06 <sinha1> yes it is
151 2011-05-30T21:47:10 <ThomasWaldmann> so even if the timestamps would get adapted afterwards somehow, the grouping would be wring
152 2011-05-30T21:47:13 <ThomasWaldmann> wrong
153 2011-05-30T21:47:42 <dreimark> re
154 2011-05-30T21:47:48 <sinha1> before any edition done by me, the timestamps for the revision was the same
155 2011-05-30T21:48:04 <sinha1> i.e the utc datetime for each revision
156 2011-05-30T21:48:15 <sinha1> i have just reused those functions to do the grouping
157 2011-05-30T21:48:17 <ThomasWaldmann> how about using format_date from flask-babel?
158 2011-05-30T21:49:41 <sinha1> i get it .you are talking about this function datetime.utcfromtimestamp(rev.timestamp) ?
159 2011-05-30T21:50:05 <sinha1> and after that i am calling the format_date function with a datetime object
160 2011-05-30T21:50:47 <ThomasWaldmann> you are using babel.dates directly. it doesn't know about wiki user's tz. use flask-babel
161 2011-05-30T21:50:53 <dreimark> sinha1: please keep your repo in sync with the main repo
162 2011-05-30T21:51:29 <sinha1> dreimark: i have merged it when i started to do the changes
163 2011-05-30T21:51:48 <sinha1> dreimark: and re-merged it when i am done doing change
164 2011-05-30T21:51:50 <dreimark> your quickinstall is different
165 2011-05-30T21:52:29 <dreimark> moment
166 2011-05-30T21:52:54 <dreimark> sinha1: sorry likly i have an old version
167 2011-05-30T21:53:15 <sinha1> ThomasWaldmann: but earlier also in the template file itself datetimeformat filter was being used and also it was showing the output in UTC
168 2011-05-30T21:54:12 <ThomasWaldmann> then you did not log in or did not set your tz, right?
169 2011-05-30T21:54:33 <ThomasWaldmann> the default is utc, of course
170 2011-05-30T21:55:16 <ThomasWaldmann> https://bitbucket.org/sinha/moin2/changeset/b07dfe4ceb8d#chg_MoinMoin/templates/global_history.html_newline14 that is crappy style
171 2011-05-30T21:57:21 <sinha1> then how do i print the item of list ?
172 2011-05-30T21:58:08 <ThomasWaldmann> i mean putting something completely different and unrelated into l[0] than into l[1..]
173 2011-05-30T21:58:43 <ThomasWaldmann> instead of just using a new name for the headline
174 2011-05-30T22:00:29 <sinha1> okay, but by this way it made passing data easier
175 2011-05-30T22:00:48 <ThomasWaldmann> you may want to use 2-tuples there (headline, revlist)
176 2011-05-30T22:00:55 <ThomasWaldmann> or similar
177 2011-05-30T22:01:17 <sinha1> ThomasWaldmann: yes i am getting wrong date from format_date function, it is showing the utc date always
178 2011-05-30T22:01:19 <ThomasWaldmann> {% set rev_list = rev_list[1:] %} that saves you from having to do such stuff
179 2011-05-30T22:01:50 <sinha1> ThomasWaldmann: how do i fix this ?
180 2011-05-30T22:02:30 <ThomasWaldmann> it's not wrong, you are just calling the wrong function. and i already told you twice how to fix it.
181 2011-05-30T22:02:42 <sinha1> but this format_date function doesn't accepts usertz as parameter unlike the format_datetime function
182 2011-05-30T22:03:17 <ThomasWaldmann> the flask-babel stuff will likely do the right thing, magically
183 2011-05-30T22:03:36 <ThomasWaldmann> as it does if you use those filters in the template
184 2011-05-30T22:05:38 <ThomasWaldmann> btw, one usually doesn't use foo_list, but just plural, like foos
185 2011-05-30T22:06:28 <ThomasWaldmann> also don't use temp_list if you can easily choose a better name
186 2011-05-30T22:08:14 <sinha1> ThomasWaldmann: yes it got fixed, used flaskext.babel to import the function format_date
187 2011-05-30T22:10:23 <ThomasWaldmann> btw, you seem to rely on a specific date formatting, but you don't specify it. can't that break easily?
188 2011-05-30T22:11:19 <sinha1> ThomasWaldmann: i guess no
189 2011-05-30T22:12:33 <dreimark> is localisation working ?
190 2011-05-30T22:12:55 <dreimark> because i would expect 2011-05-30 if I set locale to english?
191 2011-05-30T22:13:15 <dreimark> currently I get 30.05.2011
192 2011-05-30T22:15:11 <ThomasWaldmann> how did you set locale?
193 2011-05-30T22:15:38 <sinha1> dreimark: yes its working
194 2011-05-30T22:15:38 <dreimark> Settings, Personal settings
195 2011-05-30T22:16:01 <sinha1> If i change it to English i get as May 30, 2011
196 2011-05-30T22:16:04 <dreimark> it changes the language of the navigations etc but not the format
197 2011-05-30T22:16:23 <dreimark> sinha1: in your new version?
198 2011-05-30T22:16:37 <sinha1> yes
199 2011-05-30T22:16:39 <ronny> btw, whats the password to the moinmoin mumble server?
200 2011-05-30T22:16:48 <ThomasWaldmann> May 30, 2011 6:58:17 PM that's what i get with en locale
201 2011-05-30T22:16:51 <dreimark> ronny: moin
202 2011-05-30T22:17:05 <dreimark> sinha1: ok, now i pulled again
203 2011-05-30T22:17:18 <dreimark> can you setup bb to write cs messages to this channel please
204 2011-05-30T22:17:21 <ThomasWaldmann> 30.05.2011 18:58:17 with de locale
205 2011-05-30T22:17:25 <dreimark> pkumar did already
206 2011-05-30T22:18:12 <sinha1> okay
207 2011-05-30T22:18:21 <dreimark> ThomasWaldmann: works now here too, haven't got that there is a new cs
208 2011-05-30T22:21:47 <ThomasWaldmann> ronny: moin
209 2011-05-30T22:22:17 <ThomasWaldmann> dreimark: that stuff wasn't changed recently
210 2011-05-30T22:22:18 <dreimark> i told already
211 2011-05-30T22:22:55 <ThomasWaldmann> ah, right
212 2011-05-30T22:26:05 <ThomasWaldmann> ronny: done with mumble testing?
213 2011-05-30T22:27:45 <dreimark> sinha1: "Describe AkashSinha/Gsoc2011Diary/2011-05-26 here. "
214 2011-05-30T22:28:15 <dreimark> can be replaced by the content.
215 2011-05-30T22:29:00 <sinha1> yes
216 2011-05-30T22:29:26 <dreimark> if possible use H1 see http://moinmo.in/4ct10n/info/AkashSinha/Gsoc2011Diary/2011-05-23?action=diff&rev2=4&rev1=3
217 2011-05-30T22:29:46 <dreimark> because then H1 is shown on mouse over at the date
218 2011-05-30T22:30:46 <dreimark> level 1 headings are showed in month calendar tooltip
219 2011-05-30T22:31:23 <sinha1> i see
220 2011-05-30T22:34:43 <dreimark> sinha1: do a useful sentence which gives some info about the content on the page
221 2011-05-30T22:35:16 <dreimark> if you add always "summary" then it is in the tooltip spam
222 2011-05-30T22:35:35 <dreimark> e.g. http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-05-25
223 2011-05-30T22:35:54 <dreimark> = grouping of history results on day basis =
224 2011-05-30T22:36:30 <ronny> ThomasWaldmann: yeah, now that i know how to get it working, we can use it later when it makes sense
225 2011-05-30T22:43:00 *** pkumar
226 2011-05-30T22:43:15 <ronny> hi pkumar
227 2011-05-30T22:43:21 <pkumar> ronny: hi
228 2011-05-30T22:43:41 <sinha1> dreimark: is the current changes fine ? should i move on to next step
229 2011-05-30T22:44:30 <pkumar> ronny: I was working on your suggestions and have some progress as well as blockages
230 2011-05-30T22:45:04 <ronny> whats the blockers?
231 2011-05-30T22:46:19 <pkumar> ronny: pyfun_call part is almost done. But in the MoinTestFunction part, I'm kindd'a stuck
232 2011-05-30T22:46:56 <ronny> i suppose you dont understand how to build it best?
233 2011-05-30T22:47:29 <pkumar> ronny: When I use try to inherit from pytest.collect.Function it shows some internal error, which I'm not able to figure out
234 2011-05-30T22:47:40 <ronny> pastebin please
235 2011-05-30T22:47:45 <pkumar> here: http://paste.pocoo.org/show/397917/
236 2011-05-30T22:48:37 <pkumar> ronny: I can work on the solution if I know the problem at least
237 2011-05-30T22:49:17 <ronny> pkumar: you make EVERYTHING a function, even classes
238 2011-05-30T22:49:32 <ronny> you shouldnt make anything for stuff thats not a function/method
239 2011-05-30T22:50:31 <pkumar> ronny: may sound silly, but pytest.collect.Function is a class right?
240 2011-05-30T22:50:39 <ronny> pkumar: yes
241 2011-05-30T22:50:51 <ronny> pkumar: but makeitem is called for classes as well
242 2011-05-30T22:51:02 <ronny> so instead of a python function, it will get a python class
243 2011-05-30T22:51:15 <ronny> and pytest.collect.Function is meant to run a python function
244 2011-05-30T22:51:22 <ronny> a python class is not a python function
245 2011-05-30T22:51:31 <ronny> so dont pass it in to pytest.collect.Function
246 2011-05-30T22:52:15 <sinha1> gn
247 2011-05-30T22:52:18 *** sinha1
248 2011-05-30T22:52:32 <ronny> pkumar: got it, or do i need to rephase?
249 2011-05-30T22:53:04 <pkumar> Could you please explain more?
250 2011-05-30T22:53:10 <pkumar> ronny: ^
251 2011-05-30T22:53:23 * dreimark looks
252 2011-05-30T22:53:46 <ronny> basically you are not supposed to pass anything other than functions or method as object into Function's constructor
253 2011-05-30T22:53:51 <ronny> but you pass it a class
254 2011-05-30T22:53:59 <ronny> it cant deal with that
255 2011-05-30T22:59:27 <pkumar> so, now what I'm supposed to fix it? I don't return anyting in makeitem?
256 2011-05-30T22:59:39 <pkumar> ronny:^
257 2011-05-30T22:59:53 <ronny> please show the code
258 2011-05-30T23:00:49 <pkumar> ronny: just a moment, it is little messed up due to my experiments. I'll clean it a bit
259 2011-05-30T23:02:36 <ronny> pkumar: i dont care how clean it is, i want the exact code that caused your exact error
260 2011-05-30T23:03:40 <pkumar> ok
261 2011-05-30T23:05:01 <ronny> pkumar: in future it may be helpfull if you used the multifile feature of paste.pocoo.org and combined errors + related code into a single paste
262 2011-05-30T23:05:35 <pkumar> okay
263 2011-05-30T23:06:25 <pkumar> http://paste.pocoo.org/show/397933/
264 2011-05-30T23:06:30 <pkumar> ronny :^
265 2011-05-30T23:08:07 <ronny> pkumar: please read the condition in the makeitem hook very careful, then think about what you did
266 2011-05-30T23:10:28 <pkumar> yeah, I returned MoinTestFunction which is not supposed to be there(I know it now). Though MoinClassCollector was there earlier.
267 2011-05-30T23:11:03 <ronny> and what do you need to do?
268 2011-05-30T23:11:36 <pkumar> I need to return function items I guess
269 2011-05-30T23:11:58 <pkumar> ?
270 2011-05-30T23:12:05 <ronny> and in what case?
271 2011-05-30T23:12:41 <pkumar> if it is generator
272 2011-05-30T23:13:06 <pkumar> and what in normal cases?
273 2011-05-30T23:13:50 <ronny> for now the right answer is every time you get a matching test function in a class
274 2011-05-30T23:14:54 <ronny> where matching means fits the naming scheme
275 2011-05-30T23:16:03 <pkumar> also, how do I access function item in makeitem hook? Since pyfuncitem is not a hook argument in makeitem?
276 2011-05-30T23:16:29 * dreimark looks at http://svg-edit.googlecode.com/svn-history/r1771/trunk/editor/svg-editor.html
277 2011-05-30T23:16:33 <dreimark> 2.6alpha
278 2011-05-30T23:17:59 <ronny> pkumar: makeitem is supposed to return a instance of FunctionItem
279 2011-05-30T23:18:20 <ronny> pkumar: just like it returned a instance of Class before
280 2011-05-30T23:20:35 <pkumar> ok, after the change (using MoinTestFunction) make item will return instance of FunctionItem right?
281 2011-05-30T23:20:51 <pkumar> ronny:^
282 2011-05-30T23:21:05 <ronny> yeah
283 2011-05-30T23:26:19 <pkumar> ronny: so, in the present case just returning the function item from makeitem and modifying MoinTestFunction should do right?
284 2011-05-30T23:26:42 <ronny> yes
285 2011-05-30T23:30:39 <pkumar> ronny: and what about Module class? even if I delete the whole content of Module class(just leaving the definition since it is in makemodule hook), tests runs without errors and failures
286 2011-05-30T23:31:49 <pkumar> ronny: at least those tests which I tried
287 2011-05-30T23:32:38 <ronny> pkumar: i'd keep the coverage part, kill the stuff about class
288 2011-05-30T23:33:25 <pkumar> okay
289 2011-05-30T23:35:40 <pkumar> ronny: also, what do I use in place of collector.classnamefilter(name) in makeitem?
290 2011-05-30T23:37:05 <ronny> pkumar: funcnamefilter on collector
291 2011-05-30T23:38:53 <ronny> pkumar: also check if they are really callable
292 2011-05-30T23:39:27 <pkumar> ok
293 2011-05-30T23:46:10 <pkumar> ronny: seems like nothing is being executed inside 'if condition' for funcnamefilter. as a result still showing the internal error stuff
294 2011-05-30T23:47:47 <ronny> pkumar: current code and current error please
295 2011-05-30T23:48:54 <pkumar> just a mom
296 2011-05-30T23:55:46 <pkumar> ronny: I think name would be the name of a class and obj a class instance. http://paste.pocoo.org/show/397951/
297 2011-05-30T23:57:18 <ronny> pkumar: i said KILL the class stuff from module, not put function there
298 2011-05-30T23:57:37 <ronny> cause then it gets used instead of Class for actual classes
299 2011-05-30T23:58:49 <pkumar> ronny: oh, I thought you were talking about class in class Module. I'll correct it, thanks.
300 2011-05-30T23:59:46 <ronny> pkumar: if you use isfunction, you also have to use ismethod
