1 2011-06-03T00:11:32 <dreimark> re
2 2011-06-03T00:12:59 <dreimark> ThomasWaldmann: not sure - does this mean the button is then on default not displayed
3 2011-06-03T00:14:23 <ThomasWaldmann> yes
4 2011-06-03T00:14:43 <ThomasWaldmann> one can just type the search query and hit enter
5 2011-06-03T00:26:34 <dreimark> ok, we should make it similiar to ff, with the magnifying glass
6 2011-06-03T00:28:18 <dreimark> and if we can have the pull down selection box too
7 2011-06-03T00:28:48 <dreimark> one could add, eg. Text, Tag, User, etc
8 2011-06-03T00:30:48 <ThomasWaldmann> we'll have a simple search (that one) and an advanced search with an own view
9 2011-06-03T00:34:12 <ThomasWaldmann> but the magnifying glass is a good idea
10 2011-06-03T00:37:04 <dreimark> ok
11 2011-06-03T00:38:31 <dreimark> http://code.google.com/p/html5shiv/ opinions to this please
12 2011-06-03T00:42:55 <ThomasWaldmann> docs?
13 2011-06-03T00:52:20 <dreimark> http://www.youtube.com/watch?v=f-CYAMhxbW4 2:54
14 2011-06-03T01:01:12 *** m4k3r
15 2011-06-03T01:05:32 <dreimark> mrtopf explained it at the barcamp
16 2011-06-03T01:05:59 <dreimark> gn
17 2011-06-03T01:49:42 *** ronny
18 2011-06-03T01:51:29 *** ronny
19 2011-06-03T02:27:53 *** m4k3r
20 2011-06-03T05:38:41 *** Marchael
21 2011-06-03T05:42:16 <Marchael> moin
22 2011-06-03T07:43:19 <ThomasWaldmann> moin
23 2011-06-03T07:56:09 *** andialbrecht_
24 2011-06-03T07:58:59 *** m4k3r
25 2011-06-03T08:05:01 *** m4k3r
26 2011-06-03T08:50:58 *** xjjk
27 2011-06-03T08:51:07 *** xjjk
28 2011-06-03T09:52:52 *** greg_f
29 2011-06-03T12:38:01 *** sinha
30 2011-06-03T12:48:15 <sinha> dreimark: In my implementation i need to preserve the insertion order of keys into the dictionary, i have found some OrderDict API, should i go for them (wont they affect performance) or do some change in coding itself ( like use a list to keep track of the keys ) ? What do you suggest ?
31 2011-06-03T12:57:32 *** sinha
32 2011-06-03T15:50:17 *** sinha
33 2011-06-03T15:51:03 <Marchael> ThomasWaldmann: 285 on ep
34 2011-06-03T16:04:30 <Marchael> ThomasWaldmann: I done with opening, please look at ep
35 2011-06-03T16:08:41 *** andialbrecht
36 2011-06-03T17:16:22 <ronny> sinha: if you use the stdlibs OrderedDict, stuff should be fine
37 2011-06-03T17:56:41 <sinha> ronny: that need to installed separately in the environment ?
38 2011-06-03T17:57:16 <sinha> ronny: as of now i managed to do the job by using list to manage keys of dict
39 2011-06-03T17:57:47 <Marchael> ThomasWaldmann: please, highlight me when you go back
40 2011-06-03T18:55:03 *** Marchael
41 2011-06-03T19:11:52 <ronny> sinha: its in the stdlib of 2.7
42 2011-06-03T19:16:09 <sinha> ronny: i am having python2.7 but when i do "from ordereddict import ordereddict" I get a ImportError:No module named ordereddict
43 2011-06-03T19:17:52 <ThomasWaldmann> re
44 2011-06-03T19:18:37 <ThomasWaldmann> sinha: currently we have 2.6 as minimum requirement
45 2011-06-03T19:19:39 <sinha> so i guess using a list to store keys wont be a bad idea fo now ?
46 2011-06-03T19:19:53 <sinha> i mean we can update it when we get the better support
47 2011-06-03T19:21:49 <ThomasWaldmann> you can also rip the piece of code from 2.7 stdlib and add it to MoinMoin.util.... and import it from there
48 2011-06-03T19:22:18 <ThomasWaldmann> (assuming it is pure python code and works on 2.6 also and is not contained in 2.6 anyway)
49 2011-06-03T19:27:23 <sinha> i have seen this implementation of odict, http://www.voidspace.org.uk/downloads/odict.py can we use this code ? means wont it affect the performance (because i have seen it written somewhere ) and is using list to store keys matter a much ( i know it will be eating memory a little bit more, but no performance issues i guess)
50 2011-06-03T19:32:04 <ThomasWaldmann> can you first check 2.7 stdlib?
51 2011-06-03T19:32:54 *** greg_f
52 2011-06-03T19:42:14 <sinha> ThomasWaldmann: I am not seeing it in my folders at /usr/lib/python2.7/
53 2011-06-03T19:53:00 <ThomasWaldmann> from collections import OrderedDict (2.7)
54 2011-06-03T19:56:21 <ThomasWaldmann> you could add some code to MoinMoin.util.monkeypatch to add the name to stdlib if it is not there
55 2011-06-03T19:57:03 <ThomasWaldmann> see how it patches werkzeug.sys and do it similar to that
56 2011-06-03T19:57:26 <ThomasWaldmann> ehrm, posixemulation.sys
57 2011-06-03T20:02:22 *** m4k3r
58 2011-06-03T20:17:38 <sinha> ThomasWaldmann: how should i do it ? should i copy the code od Class OrderedDict from that collections.py file to a new file inside MoinMoin/util folder ?
59 2011-06-03T20:24:40 <ThomasWaldmann> yes
60 2011-06-03T20:26:03 <ThomasWaldmann> and please add a comment from which python version exactly it came from
61 2011-06-03T20:32:07 <sinha> okay
62 2011-06-03T20:37:34 <sinha> ThomasWaldmann: I have copied the code and tested it as a stand alone, but i am not sure regarding which imports in the original file (collections.py) will be needed here, ( i mean we should remove the unnecessary imports)
63 2011-06-03T20:42:39 <ThomasWaldmann> use search function of editor?
64 2011-06-03T20:51:19 <ThomasWaldmann> and use py 2.6 to run your code
65 2011-06-03T20:55:56 <ThomasWaldmann> sinha: maybe name the file python27.py, so we can put other useful stuff there also
66 2011-06-03T20:57:06 <sinha> okay, and also i guess i should push it separately ( not mixing it with my other changes) , how should i do this ?
67 2011-06-03T20:57:19 <ThomasWaldmann> yes
68 2011-06-03T20:57:19 <sinha> because when a do hg commit it will commit all the things
69 2011-06-03T20:57:28 <sinha> s/a/I
70 2011-06-03T20:57:57 <ThomasWaldmann> hg commit --help
71 2011-06-03T20:58:27 <ThomasWaldmann> (and hg add that file, of course)
72 2011-06-03T20:59:53 <sinha> yes, and one more thing i have changed the name of the class from OrderedDict to odict, such that it wont confuse the others, is it ok ?
73 2011-06-03T21:06:42 <ThomasWaldmann> you use the same name as it has in 2.7
74 2011-06-03T21:07:12 <ThomasWaldmann> and you only patch it in if it is not there
75 2011-06-03T21:15:56 <sinha> ThomasWaldmann: this OrderedDict class already there in the file env/lib/python2.7/site-packages/sqlalchemy/util/_collections.py
76 2011-06-03T21:16:22 <sinha> can i use that ? i
77 2011-06-03T21:17:11 <sinha> like from sqlalchemy import util
78 2011-06-03T21:26:49 <ThomasWaldmann> add it to monkeypatch and patch it to where it belongs :)
79 2011-06-03T21:32:22 <sinha> ThomasWaldmann: i am not sure i am getting you clearly
80 2011-06-03T21:33:15 *** pkumar
81 2011-06-03T21:33:42 <pkumar> ronny: hi
82 2011-06-03T21:34:18 <sinha> do i save that file to util folder and push it to my repo at bitcuket ? or you are saying something different
83 2011-06-03T21:34:57 <pkumar> ronny: why some of the arguments in some files are showing undefined/unknown
84 2011-06-03T21:36:02 <pkumar> ronny: to be precise in converter.test_smiley 'input' is not found
85 2011-06-03T21:36:50 <pkumar> ronny: http://paste.pocoo.org/show/400213/
86 2011-06-03T21:37:37 <pkumar> ronny: or should I temporarily skip those till we find a solution for this
87 2011-06-03T21:38:29 <ronny> pkumar: let me taake a look
88 2011-06-03T21:38:55 <pkumar> ronny: I tried pytest_addoption and pytest_funcarg_ hooks also but not working properly.
89 2011-06-03T21:40:50 <ronny> pkumar: atm i get them skipped, but executed
90 2011-06-03T21:41:17 <pkumar> ronny: A similar case in _test.test_sourcecode.py but for 'path' argument
91 2011-06-03T21:44:31 <ronny> pkumar: that looks awfully like pytest locally broken for you
92 2011-06-03T21:44:45 <ronny> pkumar: can you kill your virtualenv, and kill all pyc files
93 2011-06-03T21:45:09 <pkumar> ok.
94 2011-06-03T21:45:14 <pkumar> just a mom
95 2011-06-03T21:47:43 <ThomasWaldmann> sinha: what file?
96 2011-06-03T21:48:19 <ThomasWaldmann> you just said you want to use the copy(?) from sqla
97 2011-06-03T21:48:29 <sinha> yes
98 2011-06-03T21:48:37 <sinha> i can just do import from sqlalchemy
99 2011-06-03T21:48:44 <sinha> no need to add any new file
100 2011-06-03T21:49:03 <ThomasWaldmann> no, i said you shall monkeypatch it to where it is in py 2.7
101 2011-06-03T21:49:20 <ThomasWaldmann> so everybody can use the usual import, even on 2.6
102 2011-06-03T21:50:09 <sinha> you mean i should include these lines like from sqlalchemy.util import OrderedDict in the monkeypatch file ?
103 2011-06-03T21:50:29 <ThomasWaldmann> see then end of that file
104 2011-06-03T21:50:32 <ThomasWaldmann> the*
105 2011-06-03T21:52:17 <sinha> that monkeypatch file has some werkzeug patching
106 2011-06-03T21:53:02 <ThomasWaldmann> yes and you want to do some collections patching, but only if needed
107 2011-06-03T21:59:40 <pkumar> ronny: hey, I removed all the pyc files and tried restarting the virtual environment. But same issue.
108 2011-06-03T22:00:18 <pkumar> ronny: but it works well with previous code of conftest.py
109 2011-06-03T22:01:15 <sinha> ThomasWaldmann: okay you mean i should add that OrderedDict code to monkeypatch file under the collections patching section ? or just include that import path of sqlalchemy ?
110 2011-06-03T22:04:12 *** MattMaker
111 2011-06-03T22:09:52 *** RogerHaase
112 2011-06-03T22:10:47 <ThomasWaldmann> sinha: as long as we depend on sqla, you can just import it
113 2011-06-03T22:12:15 <ThomasWaldmann> please pastebin your solution before commit
114 2011-06-03T22:12:29 <sinha> okay comfortable for me, but if will it work simply in files if we use directly try to create instance of OrderedDict, i mean no need to import that monleypatch
115 2011-06-03T22:13:42 <sinha> s/monley/monkey
116 2011-06-03T22:14:03 <ThomasWaldmann> that file is imported early (and only at one place)
117 2011-06-03T22:19:12 <ronny> pkumar: paste your current patch please
118 2011-06-03T22:19:13 <sinha> ThomasWaldmann: I have added these lines, but when that OrderedDict is called in the views.py file it raises error
119 2011-06-03T22:19:24 <ronny> pkumar: what i pulled last from you just works
120 2011-06-03T22:20:00 <sinha> ThomasWaldmann: ^ NameError: global name 'OrderedDict' is not defined
121 2011-06-03T22:20:22 <ronny> sinha: it needs a import from collections
122 2011-06-03T22:20:35 <sinha> ThomasWaldmann: added these lines http://paste.pocoo.org/show/400236/, sry for above line
123 2011-06-03T22:20:55 <sinha> ronny: yes i know, but to make it working for the version < 2.7 i am doing that
124 2011-06-03T22:21:19 <sinha> i could have done it easily by importing through collections
125 2011-06-03T22:21:28 <ronny> that needs a alternative imlementation
126 2011-06-03T22:21:36 <ThomasWaldmann> can you just transfer from the werkzeug patch to a collections patch?
127 2011-06-03T22:23:17 <sinha> ThomasWaldmann: this is my monkeypatch.py file http://paste.pocoo.org/show/400240/
128 2011-06-03T22:23:29 <sinha> tell me where to do changes
129 2011-06-03T22:24:17 <ThomasWaldmann> werkzeug is missing the sys thing, the py 2.6 is missing the OrderDict thing
130 2011-06-03T22:24:19 <ThomasWaldmann> so...
131 2011-06-03T22:24:32 <ThomasWaldmann> py 2.6 collections* ...
132 2011-06-03T22:24:42 *** m4k3r
133 2011-06-03T22:30:45 <ThomasWaldmann> http://www.crackajack.de/ lol. man beachte die film-unterschrift.
134 2011-06-03T22:31:43 <ThomasWaldmann> oops, wrong chan
135 2011-06-03T22:31:50 *** m4k3r
136 2011-06-03T22:32:50 <sinha> ThomasWaldmann: will this work now for python2.6 ==> from sqlalchemy.util import OrderedDict \n
137 2011-06-03T22:32:50 <sinha> collections.OrderedDict = OrderedDict
138 2011-06-03T22:33:21 <sinha> and included that from collections import OrderedDict in that views.py file
139 2011-06-03T22:36:28 *** m4k3r
140 2011-06-03T22:36:54 <ThomasWaldmann> you need to also import collections first, of course
141 2011-06-03T22:37:31 <sinha> yeah did, everything working fine now :)
142 2011-06-03T22:37:43 <ThomasWaldmann> and that'ld work then for 2.x. but, for 2.7, you'ld overwrite the existing code, which is not what you want.
143 2011-06-03T22:37:58 <sinha> so ?
144 2011-06-03T22:38:00 <ThomasWaldmann> thus you have to do that only if it is not there
145 2011-06-03T22:38:19 <sinha> i should check it first, you mean
146 2011-06-03T22:38:57 <ThomasWaldmann> yes
147 2011-06-03T22:45:02 <ronny> is sqlalchemy necessary in any case?
148 2011-06-03T22:45:10 <ronny> if yes, just import from there
149 2011-06-03T22:45:27 <ronny> no need for overwrite magic if there is a import path that will always work
150 2011-06-03T22:48:28 <ThomasWaldmann> ronny: currently, it is used for indexing some metadata
151 2011-06-03T22:49:09 <ThomasWaldmann> that might change, maybe, some day to whoosh, but that still has to be seen
152 2011-06-03T23:26:45 <RogerHaase> ThomasWaldmann: I updated http://codereview.appspot.com/4535086 with changes that add transclusions button to itemview bar
153 2011-06-03T23:39:29 * ThomasWaldmann looks
154 2011-06-03T23:41:49 <dreimark> re
155 2011-06-03T23:56:45 <CIA-69> Akash Sinha <akash2607@gmail.com> * a4afec9ff526 r253 default/MoinMoin/util/monkeypatch.py: "patch for collections module added, for the python versions < 2.7 "
156 2011-06-03T23:56:45 <CIA-69> Akash Sinha <akash2607@gmail.com> * 72dbe801338e r254 default/MoinMoin/ (3 files in 3 dirs): Grouping of global history results on item name basis and after that on the date basis done. Also added features like diff links and editor grouping.
157 2011-06-03T23:56:51 <dreimark> :)
