1 2011-06-07T00:10:52 <ronny> ThomasWaldmann: when is the next student meeting, i feel like i should get my hands on the testing students
2 2011-06-07T00:17:17 <ThomasWaldmann> wed 14:00 utc as every week, the testing guys begin 1h before that
3 2011-06-07T00:20:02 <ronny> ok
4 2011-06-07T00:28:06 <sinha> gn
5 2011-06-07T00:28:08 *** sinha
6 2011-06-07T00:29:26 *** raignarok
7 2011-06-07T00:30:49 <dreimark> gn
8 2011-06-07T00:40:09 *** RogerHaase
9 2011-06-07T01:50:01 *** ronny
10 2011-06-07T01:52:16 *** ronny
11 2011-06-07T03:29:18 <Marchael> moin
12 2011-06-07T05:39:55 * Marchael doesn't understand the point of whoosh author
13 2011-06-07T05:40:22 <Marchael> If I use entoken as analyzer, so why I can't just put list to index?
14 2011-06-07T05:42:16 <Marchael> or I should use tricks to make it work...
15 2011-06-07T06:59:54 *** m4k3r
16 2011-06-07T07:42:55 *** m4k3r
17 2011-06-07T07:50:52 <Marchael> ThomasWaldmann: I corrected AclTokenizer() and now I accept unicode lines, but I don't know how I can put list or tuple throught whoosh checks to entoken(), it raises ValueError http://paste.pocoo.org/show/401999/
18 2011-06-07T07:52:43 <Marchael> s/I accept/it's accept/
19 2011-06-07T08:00:14 <dreimark> the function assumes each token was separated by one space
20 2011-06-07T08:12:50 <Marchael> entoken() assumes what tokens are in list or tuple
21 2011-06-07T08:13:21 *** andialbrecht_
22 2011-06-07T08:13:50 <Marchael> but u'asd sdd' -> [u'a', u's', u'd', u' ', u's', u'd', u'd']
23 2011-06-07T08:14:52 <Marchael> also names can contain blanks
24 2011-06-07T08:17:20 <Marchael> I think, what I can use input like u"item one;item two" and write additional analyzer what accept unicode line and split it to list
25 2011-06-07T08:17:50 <Marchael> u"item one;item two" -> [u"item one", u"item two"]
26 2011-06-07T08:24:54 <dreimark> have you asked whoosh author about that ?
27 2011-06-07T08:25:13 <dreimark> may be he agrees to have this a new method
28 2011-06-07T08:27:27 <Marchael> dreimark: entoken() is written by Matt himself
29 2011-06-07T08:27:42 <Marchael> and implemented in 1.8.3
30 2011-06-07T08:28:08 <Marchael> but I don't understand why I can't use entoken as analyzer in whoosh schema
31 2011-06-07T08:29:44 <Marchael> rather say I can, but it'll accepts only unicode objects
32 2011-06-07T08:37:26 <CIA-69> Reimar Bauer <rb.proj AT googlemail DOT com> default * 564:6aefd777e2dd extensions/data/plugin/macro/ListPages.py: ListPages: list_type of content introduced. It renders the selected pages content instead of the page titles.
33 2011-06-07T09:14:52 * Marchael searching in indexes
34 2011-06-07T09:15:33 <Marchael> seems like that stuff works :)
35 2011-06-07T10:14:05 *** sinha
36 2011-06-07T10:23:29 <Marchael> sems like whoosh.QueryParser.parse() truncates blanks from begin and end
37 2011-06-07T10:48:21 <ThomasWaldmann> moin
38 2011-06-07T10:49:10 <Marchael> hi ThomasWaldmann
39 2011-06-07T10:49:53 <ThomasWaldmann> Marchael: i put some links on EP where that new stuff is described. also if one reads those diffs of matt's changes, one sees that it automatically uses entoken internally when it detects that it is given a list, not unicode.
40 2011-06-07T10:50:18 <Marchael> strange
41 2011-06-07T10:50:29 <ThomasWaldmann> this is why i said that you do not need to use/give entoken yourself
42 2011-06-07T10:52:36 <ThomasWaldmann> btw, are you using the latest whoosh release? or did you create that virtualenv before that?
43 2011-06-07T10:53:30 <Marchael> I use 1.8.3
44 2011-06-07T10:54:33 <Marchael> I just copy whoosh from /usr/lib to env/lib/python/
45 2011-06-07T10:56:16 <ThomasWaldmann> activate your env, import whoosh ; print whoosh.__version__
46 2011-06-07T10:58:44 <Marchael> (1, 8, 3)
47 2011-06-07T11:09:45 <ThomasWaldmann> try removing lines 155, 156 from fields.py
48 2011-06-07T11:12:00 <Marchael> ok
49 2011-06-07T11:13:10 <Marchael> no error is gone
50 2011-06-07T11:13:13 <Marchael> *now
51 2011-06-07T11:13:27 <Marchael> I try to search in index
52 2011-06-07T11:18:36 *** raignarok
53 2011-06-07T11:19:41 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/402058/
54 2011-06-07T11:20:51 <Marchael> sorry, 1..7 duplicated
55 2011-06-07T11:22:29 <Marchael> but wildcard mask like "firs*" gives me 1 result
56 2011-06-07T11:28:01 <dreimark> re
57 2011-06-07T11:33:43 *** greg_f
58 2011-06-07T11:36:52 <ThomasWaldmann> Marchael: try to search for u"'first tag'"
59 2011-06-07T11:37:44 <Marchael> yes
60 2011-06-07T11:37:59 <Marchael> for query = Term("tags", u"first tag") it's working
61 2011-06-07T11:38:29 <Marchael> but for And([Term('tags', u'first'), Term('tags', u'tag')]) isn't
62 2011-06-07T11:39:22 <ThomasWaldmann> yes, that's because it only finds what you put into index
63 2011-06-07T11:39:43 <ThomasWaldmann> and there is "first tag", not "first" and "tag"
64 2011-06-07T11:44:39 <Marchael> ThomasWaldmann: but then we need parser what can process "first tag" as (u"first tag") not u"first" AND u"tag"
65 2011-06-07T11:44:55 <Marchael> *(u"first" AND u"tag")
66 2011-06-07T11:47:36 <ThomasWaldmann> no
67 2011-06-07T11:47:50 <ThomasWaldmann> a tag usually is a single word
68 2011-06-07T11:48:20 <ThomasWaldmann> and if someone thinks he needs to use stuff with blanks, then he needs to search for 'stuff with blanks'
69 2011-06-07T11:49:23 <ThomasWaldmann> same for itemlinks/transclusions
70 2011-06-07T11:49:54 <ThomasWaldmann> in item names, blanks are widespread, but still you can search exactly for that string by quoting it
71 2011-06-07T11:50:46 <ThomasWaldmann> (and if we create search queries in the code, we won't use the qp anyway)
72 2011-06-07T12:11:04 <Marchael> ThomasWaldmann: may create issue about incorrect ValueError on sourceforge?
73 2011-06-07T12:13:58 *** sinha
74 2011-06-07T12:16:30 <ThomasWaldmann> Marchael: https://bitbucket.org/mchaput/whoosh/issue/145/too-restrictive-type-check-in
75 2011-06-07T12:17:04 <Marchael> oh, thx
76 2011-06-07T12:17:07 <ThomasWaldmann> yeah, good idea :)
77 2011-06-07T12:17:26 <ThomasWaldmann> (but on bb, not sf)
78 2011-06-07T12:17:41 <Marchael> yup :)
79 2011-06-07T12:54:41 <ThomasWaldmann> how does MimeTokenizer.__call__ look like in your workdir?
80 2011-06-07T12:54:46 <ThomasWaldmann> Marchael:
81 2011-06-07T12:55:19 <Marchael> class MimeTokenizer(Tokenizer):
82 2011-06-07T12:55:19 <Marchael> def __call__(self, value, start_pos=0, positions=False, **kwargs):
83 2011-06-07T12:56:06 <ThomasWaldmann> do you use start_pos, positions in your code?
84 2011-06-07T12:56:11 <Marchael> yes
85 2011-06-07T12:56:19 <ThomasWaldmann> ok
86 2011-06-07T12:56:26 <Marchael> It is necessary, because whoosh requires it
87 2011-06-07T12:56:50 <ThomasWaldmann> maybe upload another workdir state to codereview soon
88 2011-06-07T12:57:03 <Marchael> I'm still writing tests
89 2011-06-07T12:57:05 <ThomasWaldmann> if i look at the latest state in your repo, there are still lots of errors
90 2011-06-07T12:57:58 <ThomasWaldmann> in general, try to commit/push more often. concentrate on a single thing, make it perfect, ask for review, commit, push
91 2011-06-07T13:33:11 *** gwork
92 2011-06-07T14:20:32 <Marchael> ThomasWaldmann: for example I have add_document(foo=u"bar", foo1=u"bar2", foo3=u"bar3"). How can I add all arguments foo,foo1 etc. using something value? I meam add_document(value_list)
93 2011-06-07T14:28:10 *** m4k3r
94 2011-06-07T14:43:25 * Marchael found
95 2011-06-07T14:48:55 <ThomasWaldmann> Marchael: it is unclear what you try to achieve
96 2011-06-07T14:49:35 * Marchael want to ask what does it mean **kwargs and how to use it
97 2011-06-07T14:49:48 <Marchael> but now it is not neccesary :)
98 2011-06-07T14:56:11 <ThomasWaldmann> maybe read some python docs, these are basics of python
99 2011-06-07T15:02:19 *** sinha
100 2011-06-07T15:15:58 <Marchael> hm, seens like our search is case dependent :)
101 2011-06-07T15:16:07 <Marchael> *seems
102 2011-06-07T15:16:30 * Marchael trying to find stuff startng with capital letter
103 2011-06-07T15:17:19 <Marchael> it is impossible to find stuff, for exapmle itemlinks which starts from capital letter
104 2011-06-07T15:19:04 <ThomasWaldmann> Marchael: it is expected that tags, itemlinks, itemtransclusions do only exact matches
105 2011-06-07T15:19:50 <Marchael> ThomasWaldmann: sure, but if you have tag "Tag" them you didn't find it
106 2011-06-07T15:20:20 <ThomasWaldmann> if you search for "Tag" you do not find "Tag" ?
107 2011-06-07T15:20:25 <Marchael> yes
108 2011-06-07T15:20:37 <ThomasWaldmann> ehrm
109 2011-06-07T15:20:53 <Marchael> test fails on it
110 2011-06-07T15:21:04 <ThomasWaldmann> show test and result
111 2011-06-07T15:22:26 <Marchael> http://paste.pocoo.org/show/402150/ there is test
112 2011-06-07T15:22:44 <Marchael> there is result http://paste.pocoo.org/show/402151/
113 2011-06-07T15:23:57 <ThomasWaldmann> please do not format stuff like that
114 2011-06-07T15:24:22 <Marchael> but it is readeble
115 2011-06-07T15:24:26 <ThomasWaldmann> I mean do not align all ":" in same column
116 2011-06-07T15:24:35 <ThomasWaldmann> that's a pain to maintain
117 2011-06-07T15:25:07 <ThomasWaldmann> and creates bigger diffs than needed, e.g. if you add one line that doesn't fit into current layout, you need to reformat all other lines, too
118 2011-06-07T15:25:32 <Marchael> ok
119 2011-06-07T15:26:24 <ThomasWaldmann> ehrm, do you need to call estimated_length to get the length of the result?
120 2011-06-07T15:26:34 <Marchael> yes
121 2011-06-07T15:26:47 <ThomasWaldmann> why?
122 2011-06-07T15:26:55 <Marchael> is it;s empty than we didn't find anything
123 2011-06-07T15:27:27 <Marchael> say "empty" I mean it is 0
124 2011-06-07T15:27:43 <ThomasWaldmann> i mean why don't you look at result directly?
125 2011-06-07T15:28:18 <Marchael> for what reason? If we found some stuff than search is working
126 2011-06-07T15:28:47 <ThomasWaldmann> add a print result there and look at what it outputs
127 2011-06-07T15:28:52 <Marchael> *working as we expected
128 2011-06-07T15:29:41 <ThomasWaldmann> btw, as you still don't clean up, those tests are filling your temp dir
129 2011-06-07T15:29:43 <Marchael> ThomasWaldmann: why? I have only one documents for each schema
130 2011-06-07T15:30:01 <Marchael> hm, I still writing it :)
131 2011-06-07T15:30:35 <ThomasWaldmann> and stuff like creating tempdir and removing them should be in test setup and teardown
132 2011-06-07T15:31:15 <ThomasWaldmann> "itemlinks" : [u"Home", u"Find"],
133 2011-06-07T15:31:35 <ThomasWaldmann> E + where 0 = <Top 0 Results for Term(u'itemlinks', u'home') runtime=0.000137805938721>.estimated_length()
134 2011-06-07T15:31:52 <Marchael> yes
135 2011-06-07T15:31:53 <ThomasWaldmann> (u"itemlinks", u"Home"),
136 2011-06-07T15:32:06 <ThomasWaldmann> so, the conclusion is?
137 2011-06-07T15:32:35 <Marchael> I understand reason of it but I don't know what to do :)
138 2011-06-07T15:32:49 <ThomasWaldmann> tell the reason
139 2011-06-07T15:33:11 <Marchael> Term(u'itemlinks', u'home')
140 2011-06-07T15:33:11 <Marchael> u"Home"
141 2011-06-07T15:33:18 <Marchael> it's rather obvious
142 2011-06-07T15:33:32 <Marchael> we searching for "home" not for "Home"
143 2011-06-07T15:33:39 <ThomasWaldmann> why?
144 2011-06-07T15:34:14 <Marchael> because QueryParser.parse() parse 'Home' as 'home'
145 2011-06-07T15:34:54 <ThomasWaldmann> exactly, so we have a problem that the queryparser lowercases (at query time), but at index time, we just use "as is"
146 2011-06-07T15:36:02 <ThomasWaldmann> show your schema
147 2011-06-07T15:36:41 <Marchael> http://paste.pocoo.org/show/402157/
148 2011-06-07T15:37:11 <Marchael> > itemlinks=TEXT(stored=True),
149 2011-06-07T15:37:19 <ThomasWaldmann> you still did not rename "items"
150 2011-06-07T15:37:42 <ThomasWaldmann> (to "latestrevisions" or so)
151 2011-06-07T15:37:51 <Marchael> ok
152 2011-06-07T15:38:37 <ThomasWaldmann> well, it looks like that is caused by the default analyzer it uses for TEXT fields
153 2011-06-07T15:39:01 <ThomasWaldmann> so, either using TEXT is wrong, or using TEXT with the standard analyzer is wrong
154 2011-06-07T15:39:25 <Marchael> yes, but if you use one analyzer for indexing and quering than why results are different?
155 2011-06-07T15:39:28 <ThomasWaldmann> as that stuff is rather made for exact match, i guess using TEXT is wrong
156 2011-06-07T15:39:52 <ThomasWaldmann> as you give a list, it doesn't use analyzer at index time
157 2011-06-07T15:40:11 <ThomasWaldmann> it just uses the strings from the list as token text
158 2011-06-07T15:40:24 <ThomasWaldmann> try ID
159 2011-06-07T15:40:42 *** Gnarlodious
160 2011-06-07T15:40:52 <Marchael> but ID using only for one value
161 2011-06-07T15:41:09 <ThomasWaldmann> sure?
162 2011-06-07T15:41:33 <Marchael> hm, than why Matt write IDLIST? :)
163 2011-06-07T15:42:07 *** Gnarlodious
164 2011-06-07T15:43:10 <ThomasWaldmann> just a minute, i use teh source
165 2011-06-07T15:43:56 <ThomasWaldmann> try ID
166 2011-06-07T15:45:13 <ThomasWaldmann> (we do NOT have whitespace separated tokens, so we don't use IDLIST)
167 2011-06-07T15:45:54 <ThomasWaldmann> names can be misleading :)
168 2011-06-07T15:46:02 <Marchael> same thing
169 2011-06-07T15:46:12 <Marchael> it doesn't make sense
170 2011-06-07T15:46:38 <ThomasWaldmann> show source and output
171 2011-06-07T15:46:43 <Marchael> I put the same values and it raises error
172 2011-06-07T15:46:55 <Marchael> hm
173 2011-06-07T15:47:47 <Marchael> I change only ``tags=ID(stored=True)'',
174 2011-06-07T15:47:52 <ThomasWaldmann> bitbucket is slow...
175 2011-06-07T15:48:01 <Marchael> traceback is the same
176 2011-06-07T15:49:58 <ThomasWaldmann> IDAnalyzer does not lowercase by default
177 2011-06-07T15:50:59 <Marchael> I think what it is whoosh issue
178 2011-06-07T15:51:48 <Marchael> we should use one analyzer for indexing and parsing
179 2011-06-07T15:52:12 <Marchael> lowercase or "as is"
180 2011-06-07T15:52:12 <ThomasWaldmann> you don't need an analyzer if you already have the tokens
181 2011-06-07T15:53:13 <ThomasWaldmann> and i think it should work like I told
182 2011-06-07T15:53:32 * ThomasWaldmann did not try, but I read the code :)
183 2011-06-07T15:53:53 <Marchael> I changed to tags=ID(stored=True) and result is the same
184 2011-06-07T15:54:40 <Marchael> s/I/tags=TEXT(stored=True)/
185 2011-06-07T15:55:31 <ThomasWaldmann> ?
186 2011-06-07T15:55:48 <ThomasWaldmann> show test output (with ID)
187 2011-06-07T15:56:21 <Marchael> http://paste.pocoo.org/show/402163/
188 2011-06-07T15:57:19 <Marchael> may be add print for debugging output?
189 2011-06-07T16:03:09 <Marchael> there is with debug http://paste.pocoo.org/show/402167/
190 2011-06-07T16:03:20 <Marchael> *debug output
191 2011-06-07T16:05:22 <ThomasWaldmann> that's not very useful
192 2011-06-07T16:06:23 <ThomasWaldmann> "content" : u"Oh moin gott", < LOL :)
193 2011-06-07T16:06:57 <Marchael> hm, forget to change :D
194 2011-06-07T16:16:12 <ThomasWaldmann> I don't find a place where it should lowercase. I suggest you ignore that for now.
195 2011-06-07T16:16:43 <ThomasWaldmann> get your code in a committable state for all other concerns, post it to codereview
196 2011-06-07T16:17:29 <Marchael> ok
197 2011-06-07T16:19:36 <ThomasWaldmann> >>> ia=IDAnalyzer()
198 2011-06-07T16:19:37 <ThomasWaldmann> >>> list(ia(u"FooBar"))
199 2011-06-07T16:19:37 <ThomasWaldmann> [Token(positions=False, chars=False, stopped=False, mode='', text=u'FooBar', removestops=True, boost=1.0)]
200 2011-06-07T16:26:48 <ThomasWaldmann> you are using bad names
201 2011-06-07T16:28:05 <Marchael> is there are wat to remove directory using mask?
202 2011-06-07T16:28:19 <ThomasWaldmann> schema_name is NOT the name of the schema attribute. thus it should be called index_name rather.
203 2011-06-07T16:28:31 <Marchael> ok
204 2011-06-07T16:28:33 <ThomasWaldmann> (in your tests)
205 2011-06-07T16:28:59 <ThomasWaldmann> you know how the directory name is, you don't need a mask
206 2011-06-07T16:29:30 <ThomasWaldmann> schema = getattr(index_object, self.schema_name)
207 2011-06-07T16:29:53 <Marchael> no, I mean to remove directory from previous tests
208 2011-06-07T16:29:54 <ThomasWaldmann> wrong, that must be index = getattr(index_object, self.index_name)
209 2011-06-07T16:30:04 <Marchael> for example if they fail
210 2011-06-07T16:30:43 <ThomasWaldmann> use setup and teardown, that should work. and you only need to remove in teardown what you created in setup
211 2011-06-07T16:33:20 <Marchael> ok
212 2011-06-07T16:48:51 <Marchael> ThomasWaldmann: but, tempfile.mkdtemp can only create directory under existing directories, how can I create parent directory for all indexes?
213 2011-06-07T16:49:12 <Marchael> (working on Windows and Linux)
214 2011-06-07T16:50:23 <Marchael> If I understand right you mean what I create /tmp/moin/ and create tmp dirs here
215 2011-06-07T16:50:46 <ThomasWaldmann> Marchael: you don't need to
216 2011-06-07T16:50:58 *** andialbrecht
217 2011-06-07T16:51:09 <ThomasWaldmann> don't make it more complicated than needed
218 2011-06-07T16:51:35 <ThomasWaldmann> and I did not say that, btw
219 2011-06-07T16:55:46 <Marchael> ThomasWaldmann: then what is setup and teardown?
220 2011-06-07T17:04:34 <ThomasWaldmann> look at TestFuid class in moin src
221 2011-06-07T17:05:09 <ThomasWaldmann> and btw, I can't reproduce the whoosh problem
222 2011-06-07T17:06:31 <ThomasWaldmann> http://pastebin.com/A88AfYqx
223 2011-06-07T17:07:40 <ThomasWaldmann> works perfectly for me
224 2011-06-07T17:08:22 <ThomasWaldmann> btw, need to go soon
225 2011-06-07T17:10:52 * Marchael looks
226 2011-06-07T17:14:46 <Marchael> It's working
227 2011-06-07T17:14:50 <Marchael> strange
228 2011-06-07T17:15:01 <Marchael> ah
229 2011-06-07T17:15:25 <Marchael> yeah, ID working
230 2011-06-07T17:21:04 <Marchael> now code raises AE on acl :)
231 2011-06-07T17:21:19 * ThomasWaldmann bbl
232 2011-06-07T17:46:50 <Marchael> I got strange error with acl, there is a code http://paste.pocoo.org/show/402225/, and there is traceback http://paste.pocoo.org/show/402226/
233 2011-06-07T18:16:48 *** greg_f
234 2011-06-07T18:32:23 <Marchael> bbl
235 2011-06-07T18:32:31 *** Marchael
236 2011-06-07T19:31:38 *** ronny
237 2011-06-07T19:38:53 <sinha> dreimark: got my review-comments reply in mail ?
238 2011-06-07T20:22:01 <dreimark> sinha: yes
239 2011-06-07T20:22:10 <dreimark> i had a talk with a colleague
240 2011-06-07T20:23:48 <dreimark> sinha: i go home now, I'll look at it in some minutes
241 2011-06-07T20:24:37 <sinha> dreimark: fine, thanks
242 2011-06-07T20:44:54 *** grzywacz
243 2011-06-07T20:53:01 <dreimark> re
244 2011-06-07T21:02:41 *** raignarok
245 2011-06-07T21:03:43 *** m4k3r
246 2011-06-07T21:04:49 *** m4k3r
247 2011-06-07T21:05:52 <dreimark> sinha: you are right, that will not be good to have that also in the template
248 2011-06-07T21:06:18 <sinha> so should i leave it as it is ?
249 2011-06-07T21:06:28 <dreimark> yes
250 2011-06-07T21:07:59 <dreimark> sinha: do you know import this ?
251 2011-06-07T21:08:24 <dreimark> because of the second last statement
252 2011-06-07T21:08:34 <dreimark> "If the implementation is easy to explain, it may be a good idea."
253 2011-06-07T21:10:14 <dreimark> that fits to the "grouping the revno" comment / source
254 2011-06-07T21:11:03 <dreimark> discussions
255 2011-06-07T21:13:47 <sinha> should i upload my code for review again ? or just push it
256 2011-06-07T21:14:27 <dreimark> please first for review
257 2011-06-07T21:14:40 * sinha uploading
258 2011-06-07T21:32:15 <sinha> dreimark: updated in the previous review url, http://codereview.appspot.com/4539113 patch set 2
259 2011-06-07T21:38:32 *** m4k3r
260 2011-06-07T21:42:31 <dreimark> sinha: delta patch works now :)
261 2011-06-07T21:42:51 <sinha> :)
262 2011-06-07T21:56:13 <dreimark> sinha: 4 comments / findings
263 2011-06-07T21:56:41 <sinha> looking into that
264 2011-06-07T21:57:22 <dreimark> pylint is a nice tool - it is a bit too verbose
265 2011-06-07T21:57:42 <dreimark> but it helps a lot to find typos, unused stuff etv
266 2011-06-07T21:57:48 <dreimark> s/v/c
267 2011-06-07T22:01:58 <sinha> i have included some indenting rules in my .vimrc file found on moinmo.in/CodingStyle , after that whenever i create a new line indentation goes wrong, thats why some of them keeps happening
268 2011-06-07T22:02:15 <sinha> and also my pep8 checker isnt working
269 2011-06-07T22:04:20 <sinha> when i run that test_sourcecode.py file, i get error on this import `from . import pep8`, but when i remove this `from .` and do just `import pep8` i don't get any error, but also my coe doesn't get processed
270 2011-06-07T22:06:11 <dreimark> hmm
271 2011-06-07T22:09:12 <dreimark> sinha: moin-2.0-sinha$ py.test -k test_sourcecode
272 2011-06-07T22:09:16 <dreimark> that works for me
273 2011-06-07T22:09:39 <dreimark> and it finds in monkeypatch a pep8 failure
274 2011-06-07T22:10:03 <dreimark> moin-2.0-sinha$ pylint MoinMoin/util/monkeypatch.py
275 2011-06-07T22:11:39 <dreimark> sinha: i added to the EP my .vimrc settings
276 2011-06-07T22:14:06 <sinha> yes i have this same setting, in this only when i create a new line in between codes, it tries to indent them automatically and sometime results in wrong spacing
277 2011-06-07T22:16:54 <sinha> now code is passed from that testing
278 2011-06-07T22:18:56 <sinha> dreimark: i have done the changes, should i push it now ? or wait for Thomas review ?
279 2011-06-07T22:21:34 *** ronny
280 2011-06-07T22:21:45 <dreimark> sinha: show it on rietveld
281 2011-06-07T22:25:53 * dreimark looks
282 2011-06-07T22:26:12 <sinha> dreimark: also removed a trailing space from monkeypatch based on pep8 checker, that also got uploaded there
283 2011-06-07T22:29:22 <dreimark> separate cs please
284 2011-06-07T22:29:34 <sinha> yes ofcourse
285 2011-06-07T22:29:47 <dreimark> sinha: don't forget to add your name to the copyrights
286 2011-06-07T22:30:13 <sinha> in that monekeypacth file or all these files ?
287 2011-06-07T22:30:46 <dreimark> in all files you contributed
288 2011-06-07T22:31:11 <dreimark> just not if you do only pep8 fixes and haven't added new code
289 2011-06-07T22:31:32 <sinha> :)
290 2011-06-07T22:31:48 <dreimark> monkeypatch needs a newline at bottom
291 2011-06-07T22:33:43 * dreimark looks good to me
292 2011-06-07T22:35:04 <dreimark> push it
293 2011-06-07T22:40:41 <sinha> dreimark: i have added that macro in utils.html, that is independent of my current module, new changeset for that, i guess ?
294 2011-06-07T22:48:00 <CIA-69> Akash Sinha <akash2607@gmail.com> * be9511c527b0 r255 default/MoinMoin/util/monkeypatch.py: removed trailing spaces, caught in pep8 checker
295 2011-06-07T22:48:00 <CIA-69> Akash Sinha <akash2607@gmail.com> * 8c22eeb5c407 r256 default/MoinMoin/util/monkeypatch.py: added new line at end
296 2011-06-07T22:48:00 <CIA-69> Akash Sinha <akash2607@gmail.com> * 08e3faf4c020 r257 default/MoinMoin/templates/utils.html: new separate macro added to display the editor info, which could be helpful when one just wants to display editor info.
297 2011-06-07T22:48:00 <CIA-69> Akash Sinha <akash2607@gmail.com> * 58a29a7fd016 r258 default/MoinMoin/ (templates/global_history.html apps/frontend/views.py): grouping of the global history results on item name and date basis (code cleaned)
298 2011-06-07T22:54:05 <ThomasWaldmann> re
299 2011-06-07T23:01:09 *** raignarok
300 2011-06-07T23:03:31 *** ronny
301 2011-06-07T23:29:48 <sinha> gn
302 2011-06-07T23:29:49 *** sinha
303 2011-06-07T23:54:23 *** grzywacz
304 2011-06-07T23:55:44 *** ronny
305
