1 2011-06-24T02:47:36 *** sinha
2 2011-06-24T03:19:48 *** waldbaer
3 2011-06-24T03:20:27 *** balu
4 2011-06-24T03:22:20 <sinha> dreimark: should i commit this change http://codereview.appspot.com/4635066
5 2011-06-24T03:42:29 *** MattMaker
6 2011-06-24T03:48:39 *** MattMaker
7 2011-06-24T04:13:51 *** waldbaer
8 2011-06-24T04:16:14 *** balu
9 2011-06-24T04:43:53 *** MattMaker
10 2011-06-24T04:53:30 *** MattMaker
11 2011-06-24T05:19:10 *** Marchael
12 2011-06-24T05:19:46 <Marchael> moin
13 2011-06-24T05:22:12 *** Marchael
14 2011-06-24T05:25:29 *** Marchael
15 2011-06-24T07:12:30 *** MattMaker
16 2011-06-24T08:13:04 *** sinha
17 2011-06-24T08:13:19 *** sinha
18 2011-06-24T09:10:37 <ThomasWaldmann> moin
19 2011-06-24T09:12:53 <sinha> ThomasWaldmann: can you please review this small change http://codereview.appspot.com/4635066, such that i could commit it and move forward
20 2011-06-24T09:32:27 <dreimark> moin
21 2011-06-24T09:34:16 <dreimark> sinha: i do in the break
22 2011-06-24T09:43:14 *** greg_f
23 2011-06-24T09:51:38 <Marchael> Could I write and delete document from indexes using one index writer>
24 2011-06-24T09:51:38 <Marchael> ?
25 2011-06-24T10:07:50 <ThomasWaldmann> your question is rather unclear
26 2011-06-24T10:08:29 <ThomasWaldmann> except if "yes" is the expected answer
27 2011-06-24T10:08:55 <ThomasWaldmann> Marchael:
28 2011-06-24T10:20:58 *** Marchael
29 2011-06-24T10:35:31 <dreimark> sinha: done
30 2011-06-24T10:46:12 *** MattMaker
31 2011-06-24T10:53:52 *** Marchael
32 2011-06-24T10:56:05 <Marchael> ThomasWaldmann: sorry, netwrok problem
33 2011-06-24T10:56:19 <Marchael> what is unclear for you?
34 2011-06-24T11:10:19 <dreimark> Marchael: if this question is only about if you can do this it is answered
35 2011-06-24T11:10:50 <dreimark> if you are blocked somwhere tell what it is
36 2011-06-24T11:12:04 <Marchael> I asked about using add_document() and delete_document() for one index writer
37 2011-06-24T11:12:41 *** m4k3r
38 2011-06-24T11:13:21 <m4k3r> TheSheep: congratulations :)
39 2011-06-24T11:18:37 *** pkumar
40 2011-06-24T11:32:31 <pkumar> ThomasWaldmann : hi, I was just wondering if you could suggest me, which parts of current tests may possibly have complex structure/code and should be simplified or can be done in a more efficient way.
41 2011-06-24T11:38:01 <dreimark> pkumar: i suggest you read the tests and suggests one which one you want to work
42 2011-06-24T11:40:42 * ThomasWaldmann too
43 2011-06-24T11:43:29 <pkumar> dreimark : I went through some of them and most of them are assert statements. So, I thought it would be great if somebody could suggest like -> handling of tests at this part of test is a bit complex and can be done more efficiently. Though I'll look into the codes.
44 2011-06-24T11:48:24 <dreimark> look at coverge
45 2011-06-24T11:49:21 <dreimark> look into the tests - some won't give specific fail messages
46 2011-06-24T11:50:24 <ThomasWaldmann> pkumar: did you finish with your previous task?
47 2011-06-24T11:51:25 <pkumar> ThomasWaldmann : regarding faster tests. yes. though a task regarding test cleanup is remaining which has been added in the TODO list in EP
48 2011-06-24T11:52:15 <pkumar> dreimark : ok, thanks. will do that
49 2011-06-24T11:52:55 <ThomasWaldmann> didn't you search for memory leaks?
50 2011-06-24T11:53:56 <pkumar> ThomasWaldmann : no, I think hardy89 was working on memory leaks. I was working on logging and Faster tests.
51 2011-06-24T11:57:14 <dreimark> this is hardy89 working on
52 2011-06-24T11:57:30 <dreimark> it is assigned to him in ep
53 2011-06-24T11:57:44 <pkumar> yeah
54 2011-06-24T12:01:25 * ThomasWaldmann confused it, sorry
55 2011-06-24T12:04:19 *** MattMaker
56 2011-06-24T12:10:51 *** MattMaker
57 2011-06-24T12:13:48 <Marchael> ThomasWaldmann: please review http://codereview.appspot.com/4539114/patch/55003/50009
58 2011-06-24T12:13:58 <Marchael> do not pay attention to prints
59 2011-06-24T12:14:23 <Marchael> I remove them later
60 2011-06-24T12:14:33 <Marchael> *I'll
61 2011-06-24T12:41:03 * Marchael brb
62 2011-06-24T12:55:53 <sinha> dreimark: should i commit it now http://codereview.appspot.com/4626068/ | do you want me to convert this paging code in a function right now, or later when we need this ( i guess we may need this in the that alphabetic display of index )
63 2011-06-24T12:58:47 <dreimark> sinha: you can refactor that later
64 2011-06-24T12:59:00 * dreimark reviews
65 2011-06-24T13:04:45 <ThomasWaldmann> Marchael: review done
66 2011-06-24T13:04:58 * Marchael looks
67 2011-06-24T13:05:45 <ThomasWaldmann> it would really help if you just slowly read your stuff a 2nd time.
68 2011-06-24T13:05:52 <ThomasWaldmann> (hg diff|less)
69 2011-06-24T13:06:21 <ThomasWaldmann> you wouldn't only find those typos, but also some other stuff.
70 2011-06-24T13:07:09 <dreimark> sinha: ok push it
71 2011-06-24T13:07:20 <sinha> okay
72 2011-06-24T13:08:17 <CIA-70> Akash Sinha <akash2607@gmail.com> * 17ee0418e93c r271 default/MoinMoin/ (user.py apps/frontend/views.py): function to get the count for results per page has been modified, and minor modification(based upon previous) in global_history function
73 2011-06-24T13:08:18 <CIA-70> Akash Sinha <akash2607@gmail.com> * c04d1ca903c7 r272 default/MoinMoin/ (templates/history.html apps/frontend/views.py): paging for item history results added
74 2011-06-24T13:43:58 <sinha> bbl
75 2011-06-24T13:44:00 *** sinha
76 2011-06-24T13:53:13 <pkumar> bbl
77 2011-06-24T13:53:26 *** pkumar
78 2011-06-24T14:19:45 <dreimark> re
79 2011-06-24T16:29:12 * Marchael back from open air concert
80 2011-06-24T19:19:15 *** Marchael
81 2011-06-24T19:45:42 *** greg_f
82 2011-06-24T21:57:02 *** pkumar
83 2011-06-24T21:57:03 <xorAxAx> pkumar: please explain efc0fcd76f43 - why do you init the test app again for every testitem!? (This message has been postponed.)
84 2011-06-24T21:57:04 <xorAxAx> pkumar: your performance of the past week was not enough to warrant passing midterm evals if you do not catch up (This message has been postponed.)
85 2011-06-24T22:04:37 <pkumar> xorAxAx : hi, I did not init test app for every test item. It was just in test_item. Though mostly a new app was needed in storage module(which has been taken care in conftest,py), 1/2 tests are still there which need a new app outside storage module.
86 2011-06-24T22:06:08 <xorAxAx> pkumar: ah, sorry, misread the changeset
87 2011-06-24T22:07:43 <pkumar> xorAxAx : http://moinmo.in/pkumar_diary/2011-06-23
88 2011-06-24T22:08:15 <xorAxAx> nice
89 2011-06-24T22:08:25 <xorAxAx> but not unexpected
90 2011-06-24T22:10:02 <pkumar> xorAxAx : yeah, though I'll try to work more effectively on the project :)
91 2011-06-24T22:13:40 <pkumar> xorAxAx : also, all the tasks assigned to me yet in EP has been completed(except this week's) and the cleanup part
92 2011-06-24T22:17:23 <xorAxAx> yeah, but then we should reschedule things
93 2011-06-24T22:17:27 <xorAxAx> to me more tense
94 2011-06-24T22:17:29 <xorAxAx> s/me/be/
95 2011-06-24T22:18:53 <pkumar> xorAxAx : rescheduling like?
96 2011-06-24T22:19:11 <xorAxAx> add more tasks :-P
97 2011-06-24T22:21:35 <pkumar> xorAxAx : yeah, sure. :)
98 2011-06-24T22:51:16 <pkumar> xorAxAx : I was wondering if I should also work on improving the test coverage with the current task? because improving test coverage is kinda in the in the same category of task, i.e. 'Test Improvement' as in EP
99 2011-06-24T22:52:55 <xorAxAx> pkumar: i dont understand
100 2011-06-24T22:53:46 <pkumar> xorAxAx : should I also work on improving test coverage at this time?
101 2011-06-24T22:53:59 <xorAxAx> sure
102 2011-06-24T22:54:12 <xorAxAx> when did you plan doing so accordingto yourinitial schedule?
103 2011-06-24T22:54:49 <pkumar> xorAxAx : lemme check to be sure.
104 2011-06-24T22:56:13 <pkumar> xorAxAx : though it was originally scheduled after mid term. http://moinmo.in/pkumar_pytest-2
105 2011-06-24T22:56:39 <xorAxAx> i am fine with starting that task early as long as the other tasks are finished
106 2011-06-24T22:56:51 <xorAxAx> that were planned
107 2011-06-24T23:01:55 <pkumar> porting and fixing issues on my part of task is already over. Even according to original schedule we are going fine. so, it should be fine if we do the coverage part with this task I guess.
108 2011-06-24T23:02:00 <pkumar> xorAxAx : ^
109 2011-06-24T23:02:55 <xorAxAx> yeah
110 2011-06-24T23:03:39 <pkumar> xorAxAx : ok, thanks.
111 2011-06-24T23:17:34 *** sinha
112 2011-06-24T23:42:29 <pkumar> bbl
113 2011-06-24T23:42:34 *** pkumar
114 2011-06-24T23:55:03 <dreimark> moin
MoinMoin: MoinMoinChat/Logs/moin-dev/2011-06-24 (last edited 2011-06-24 01:00:03 by IrcLogImporter)