1 2011-06-25T00:10:40  <dreimark> sinha: how much items do i need to see the paginatio implementation
   2 2011-06-25T00:13:54  <sinha> you can set the count in your settings
   3 2011-06-25T00:14:05  <sinha> keep it small to see the effect
   4 2011-06-25T00:14:25  <sinha> dreimark: ^^
   5 2011-06-25T00:14:54  <dreimark> ok, i try with a new account, currently i have my existing one used
   6 2011-06-25T00:16:31  <dreimark> sinha: ok
   7 2011-06-25T00:16:50  <dreimark> it is not enabled on default because there is no value, right?
   8 2011-06-25T00:17:37  <sinha> no its enabled, just the value is set to be 50
   9 2011-06-25T00:18:03  <sinha> if you have more than this much results, it will appear
  10 2011-06-25T00:18:39  <dreimark> in my new account there is no value in that field
  11 2011-06-25T00:22:04  <dreimark> sinha: http://test.moinmo.in/Usersettings
  12 2011-06-25T00:24:59  <sinha> dreimark: you mean translation, but i have used the similar lines as done for other input boxes, you can see the code here https://bitbucket.org/sinha/moin2/changeset/82261b274b68#chg_MoinMoin/apps/frontend/views.py_newline1259
  13 2011-06-25T00:25:46  <dreimark> sinha: no not translation of the text
  14 2011-06-25T00:25:50  <dreimark> i mean the field
  15 2011-06-25T00:25:55  <dreimark> there is nothing in it
  16 2011-06-25T00:26:09  <sinha> yes by default there is nothing in it
  17 2011-06-25T00:26:19  <sinha> i mean we have the default value in config
  18 2011-06-25T00:26:32  <sinha> if someone sets it, then the value appears there
  19 2011-06-25T00:26:35  <dreimark> well the user should see what he has to chenge
  20 2011-06-25T00:26:44  <dreimark> s/e/a/
  21 2011-06-25T00:27:56  <dreimark> sinha: this is useability
  22 2011-06-25T00:29:12  <sinha> dreimark: but during initialization the value sets to be None
  23 2011-06-25T00:29:30  <dreimark> ThomasWaldmann: http://paste.pocoo.org/show/418538/
  24 2011-06-25T00:30:04  <dreimark> sinha: is None in that case equivalent to 0 ?
  25 2011-06-25T00:30:27  <sinha> yes, i mean there is no value stored for that field
  26 2011-06-25T00:30:38  <sinha> when someone saves its settings, then it gets some value
  27 2011-06-25T00:31:02  <dreimark> i mean if we can use 0 for the same functioality as you now did with None
  28 2011-06-25T00:31:21  <dreimark> because that is similiar to the size of the editor lines
  29 2011-06-25T00:31:29  <dreimark> there 0 means all lines
  30 2011-06-25T00:32:38  <dreimark> or biggest size of edit window
  31 2011-06-25T00:34:03  <sinha> but wouldn't keeping it blank will point towards using the default value
  32 2011-06-25T00:34:38  <sinha> as of now, i didnt make any check for 0 value, as in current implementation it may  never happen
  33 2011-06-25T00:35:31  <sinha> if it is blank, then the default will be used, if it is something then that will be used
  34 2011-06-25T00:35:53  <sinha> otherwise, if you say, i will work with the 0 as default for user
  35 2011-06-25T00:36:12  <dreimark> sinha: this is a useabilty problem
  36 2011-06-25T00:36:51  <dreimark> there must be a value in it. if 50 is active then we need it there
  37 2011-06-25T00:37:41  <dreimark> if we want an unlimited number we can use the 0 for that, because that has the same meaning for the editor box
  38 2011-06-25T00:37:56  <dreimark> if you enter 10 youe have there 10 editor lines
  39 2011-06-25T00:44:37  <sinha> okay, doing that
  40 2011-06-25T00:51:47  <dreimark> ronny: http://www.hotelsilla.it/de/festival_of_san_giovanni_and_historic_florentine_soccer_03de31239en.htm
  41 2011-06-25T01:28:06  <sinha> dreimark: regarding replacing contenttype by icons, what would you suggest in it http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-06-24?action=AttachFile&do=view&target=mime-icons.png
  42 2011-06-25T01:28:30  <sinha> dreimark: i mean keep the icons in a different column, or keep it with the item name
  43 2011-06-25T01:40:53  *** sinha has quit IRC
  44 2011-06-25T01:41:12  *** sinha has joined #moin-dev
  45 2011-06-25T01:59:26  *** MattMaker has quit IRC
  46 2011-06-25T02:05:07  *** m4k3r has quit IRC
  47 2011-06-25T04:12:40  *** balu has joined #moin-dev
  48 2011-06-25T04:15:04  *** waldbaer has quit IRC
  49 2011-06-25T05:15:21  *** Marchael has joined #moin-dev
  50 2011-06-25T05:16:02  <Marchael> moin
  51 2011-06-25T05:16:27  *** pkumar has joined #moin-dev
  52 2011-06-25T05:44:52  *** MattMaker has joined #moin-dev
  53 2011-06-25T06:30:30  <Marchael> ThomasWaldmann: I fix some stuff in scrip, now it working http://codereview.appspot.com/4539114
  54 2011-06-25T06:30:39  <Marchael> *script
  55 2011-06-25T06:36:47  *** sinha has quit IRC
  56 2011-06-25T06:37:03  *** sinha has joined #moin-dev
  57 2011-06-25T07:28:47  *** m4k3r has joined #moin-dev
  58 2011-06-25T07:30:04  <sinha> dreimark: reg that considering 0 as  default value, in that UI setting, should it accept negative value for count ( i mean why editor size is accepting negative value there), or we keep a limit to enter only non negative values ?
  59 2011-06-25T07:31:13  <CIA-70> pkumar <contactprashantat@gmail.com> * e2794fc7f3fb r283 pytest2/MoinMoin/ (conftest.py util/_tests/test_crypto.py): test added to check the type in util/test_crypto.
  60 2011-06-25T07:31:14  <CIA-70> pkumar <contactprashantat@gmail.com> * 36c443f4b37f r284 pytest2/MoinMoin/util/_tests/test_crypto.py: added testvalidpassword and testupgradepassword in test_crypto.py
  61 2011-06-25T07:31:14  <CIA-70> pkumar <contactprashantat@gmail.com> * accc2bfda374 r285 pytest2/MoinMoin/util/_tests/test_crypto.py: test added for Tokens in test_crypto.py
  62 2011-06-25T07:31:14  <CIA-70> pkumar <contactprashantat@gmail.com> * aec005cc5725 r286 pytest2/MoinMoin/util/_tests/test_crypto.py: testcache_key added to test_crypto.py
  63 2011-06-25T07:31:14  <CIA-70> pkumar <contactprashantat@gmail.com> * bbd6da3dc2f2 r287 pytest2/MoinMoin/util/_tests/test_crypto.py: fixed a silly mistake
  64 2011-06-25T07:31:37  <pkumar> bbl
  65 2011-06-25T07:31:43  *** pkumar has quit IRC
  66 2011-06-25T08:08:02  <dreimark> sinha: i discuss contenttype by icons position with ThomasWaldmann ronny and TheSheep
  67 2011-06-25T08:08:28  <dreimark> I prefereable want to have it before the time and after the item name
  68 2011-06-25T08:08:59  <dreimark> for the editor value I have to look into the source too
  69 2011-06-25T08:09:04  <dreimark> likly after breakfast
  70 2011-06-25T08:09:22  <sinha> okay
  71 2011-06-25T08:10:25  <ronny> oO
  72 2011-06-25T08:10:48  <ronny> dreimark: get down here, food :)
  73 2011-06-25T08:11:32  <dreimark> ronny: yay showering now
  74 2011-06-25T08:45:36  * Marchael bbl
  75 2011-06-25T09:19:57  *** xjjk has quit IRC
  76 2011-06-25T09:48:27  *** xjjk has joined #moin-dev
  77 2011-06-25T10:01:44  *** xjjk has quit IRC
  78 2011-06-25T10:12:39  <Marchael> ThomasWaldmann: please, make review, I can't continue work while this task undone
  79 2011-06-25T10:13:20  *** xjjk has joined #moin-dev
  80 2011-06-25T11:25:37  <CIA-70> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 255:76a4e3cc8705 2.0/MoinMoin/ (6 files in 6 dirs):
  81 2011-06-25T11:25:37  <CIA-70> add +download view for just downloading a revision with forced content-disposition: attachment
  82 2011-06-25T11:25:37  <CIA-70> minor code cleanups, removed MimeType.content_disposition as it did not match send_file api,
  83 2011-06-25T11:25:37  <CIA-70> replaced it by a as_attachment method.
  84 2011-06-25T11:25:37  <CIA-70> removed duplicate get_item list entry.
  85 2011-06-25T11:44:44  *** greg_f has joined #moin-dev
  86 2011-06-25T11:46:08  *** sinha has quit IRC
  87 2011-06-25T11:46:52  *** sinha has joined #moin-dev
  88 2011-06-25T11:50:43  <sinha> re
  89 2011-06-25T12:32:25  <CIA-70> bsx <bsx+bitbucket@0xcafec0.de> default * 256:02888ad76719 2.0/MoinMoin/items/__init__.py: added exception handling if PIL can't diff the image
  90 2011-06-25T13:07:56  <ThomasWaldmann>  /names
  91 2011-06-25T13:14:54  <Marchael> ThomasWaldmann: could you make review?
  92 2011-06-25T13:33:13  <Marchael> ok bbl
  93 2011-06-25T13:35:56  *** sinha has quit IRC
  94 2011-06-25T13:38:24  <ThomasWaldmann> Marchael: no
  95 2011-06-25T13:39:06  <ThomasWaldmann> (because you did not read it yourself before asking for review)
  96 2011-06-25T13:43:33  <ThomasWaldmann> neither you read my last review
  97 2011-06-25T13:46:40  <ThomasWaldmann> (or at least you did not react to about half of it)
  98 2011-06-25T14:28:08  *** m4k3r has quit IRC
  99 2011-06-25T14:28:47  *** m4k3r has joined #moin-dev
 100 2011-06-25T16:09:37  <CIA-70> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 257:eea3a94a4061 2.0/MoinMoin/ (6 files in 2 dirs):
 101 2011-06-25T16:09:37  <CIA-70> refactored calling convention of converters, add rev=n qs argument for Iris (fixes #21)
 102 2011-06-25T16:09:37  <CIA-70> Now converters get fed either with the revision (for binary items) or
 103 2011-06-25T16:09:37  <CIA-70> the markup lines (for text items).
 104 2011-06-25T16:09:37  <CIA-70> Converters getting revisions (rev=... in qs) now create links to specific revnos.
 105 2011-06-25T16:14:10  <CIA-70> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 258:f6ca659f4a4f 2.0/MoinMoin/templates/history.html: use +download for download link in revision history
 106 2011-06-25T17:06:45  <CIA-70> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 259:50cc68af8874 2.0/MoinMoin/templates/ (base.html layout.html show.html):
 107 2011-06-25T17:06:45  <CIA-70> modify templates to not use 'with context' because this kills pypy's performance
 108 2011-06-25T17:06:45  <CIA-70> this is due to use of sys._getframe by jinja2.
 109 2011-06-25T17:06:45  <CIA-70> one also needs to patch logging/__init__.py of pypy and set _srcfile to None for
 110 2011-06-25T17:06:45  <CIA-70> same reasons.
 111 2011-06-25T17:20:04  <dreimark> ThomasWaldmann: one of the last changes breaks modify
 112 2011-06-25T17:28:33  <dreimark> ThomasWaldmann: hg revert -r 256 --all and it is working
 113 2011-06-25T17:29:38  <dreimark> 256:02888ad76719
 114 2011-06-25T17:48:11  <Marchael> ThomasWaldmann: > if it is a list, it should be called rev_nos
 115 2011-06-25T17:48:11  <Marchael> but this list contains only one value
 116 2011-06-25T17:48:50  <dreimark> why isn't it a scalar?
 117 2011-06-25T17:48:53  <Marchael> it list because i use revision.keys() for that
 118 2011-06-25T17:50:35  <dreimark> it is named keys and not key because of the same reason
 119 2011-06-25T17:51:07  <dreimark> and if you use a list with one element usually you want it as scalar
 120 2011-06-25T17:51:24  <Marchael> but revsion is dict looking like {rev_no: {revision fields}}
 121 2011-06-25T17:52:33  <dreimark> why don't you tell that on first place
 122 2011-06-25T17:53:02  <ThomasWaldmann> Marchael: just fix all the other stuff, then I'll do another review
 123 2011-06-25T17:53:17  <Marchael> ok
 124 2011-06-25T17:56:29  <Marchael> > didn't i tell you to use set operations?
 125 2011-06-25T17:56:29  <Marchael> ThomasWaldmann: you mean set()? But that list containst dictonaties of revisions
 126 2011-06-25T17:58:56  <ThomasWaldmann> set(d.keys()) maybe
 127 2011-06-25T17:59:13  * ThomasWaldmann assumed it was just a list of revnos, but the above gives you that set
 128 2011-06-25T18:09:54  <CIA-70> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 260:51e077feea0b 2.0/MoinMoin/templates/ (base.html layout.html show.html):
 129 2011-06-25T18:09:54  <CIA-70> revert changset 50cc68af8874 because of issues
 130 2011-06-25T18:09:54  <CIA-70> itemviews (and maybe other templates) need the context, so "without context"
 131 2011-06-25T18:09:54  <CIA-70> gives wrong results.
 132 2011-06-25T18:09:54  <CIA-70> Armin Ronacher told to fix the "with context" pypy performance issue in jinja2,
 133 2011-06-25T18:18:05  <Marchael> but with d.keys() I can get only field names, without thei content
 134 2011-06-25T18:20:38  <Marchael> *their
 135 2011-06-25T18:30:43  <Marchael> > why? explain the semantics of above 2 lines please.
 136 2011-06-25T18:30:43  <Marchael> when I search for backend revision in whoosh indexes, searcher may didn't find any results, then it returns None, so we can get list looking like [None, {revision}, None, {revision}]
 137 2011-06-25T18:31:02  <Marchael> it's about 97,98
 138 2011-06-25T18:32:16  <CIA-70> Reimar Bauer <rb.proj AT googlemail DOT com> default * 261:4c5e7dbfe63d 2.0/ (MoinMoin/templates/base.html quickinstall wikiconfig.py): mathjax call implemented and to quickinstall added
 139 2011-06-25T18:33:06  <Marchael> ThomasWaldmann: ^
 140 2011-06-25T18:44:46  *** hardy89 has joined #moin-dev
 141 2011-06-25T18:47:33  <ThomasWaldmann> (17:51) <  Marchael> but revsion is dict looking like {rev_no: {revision fields}}
 142 2011-06-25T18:47:40  <ThomasWaldmann> keys() for that is a list of revnos
 143 2011-06-25T18:47:59  <dreimark> set([1,2,3,4,5,6,7,8]) - set([1,2,3,4,5])
 144 2011-06-25T18:48:13  <ThomasWaldmann> and in general, please answer on codereview
 145 2011-06-25T18:48:14  <Marchael> ah, ok :)
 146 2011-06-25T18:48:25  <Marchael> I answered
 147 2011-06-25T18:52:24  <Marchael> but why I can't just store all revisions for adding to indexes in one list? amount of memory?
 148 2011-06-25T18:52:30  <ThomasWaldmann> can you just completely process a review? if it is clear, fix it, if it is unclear, ask there?
 149 2011-06-25T18:52:39  <Marchael> ok
 150 2011-06-25T18:54:02  <ThomasWaldmann> well, in fact you only know after doing the set differences what exactly you need to do. quite some of the informations you collect right now are thrown away.
 151 2011-06-25T19:01:33  *** hardy89 has quit IRC
 152 2011-06-25T19:04:40  *** m4k3r_ has joined #moin-dev
 153 2011-06-25T19:07:35  *** m4k3r has quit IRC
 154 2011-06-25T19:08:49  *** waldi has quit IRC
 155 2011-06-25T19:20:01  *** hardy89 has joined #moin-dev
 156 2011-06-25T19:21:21  *** pkumar has joined #moin-dev
 157 2011-06-25T19:24:16  <hardy89> hi ThomasWaldmann
 158 2011-06-25T19:24:51  <pkumar> xorAxAx : I added few tests today, so if you could review it and tell me is it all right or some modifications are needed?
 159 2011-06-25T19:32:56  <pkumar> hardy89 : can you please run  _tests/test_sourcecode or converter/test_smiley?
 160 2011-06-25T19:33:50  <pkumar> hardy89 : can you please paste the result if you get an Error?
 161 2011-06-25T19:34:00  <hardy89> pkumar: hey
 162 2011-06-25T19:34:03  <hardy89> pkumar: sure
 163 2011-06-25T19:34:51  <hardy89> pkumar: should i pull the changes if you've made any first?
 164 2011-06-25T19:36:08  <pkumar> hardy89 : no, you can try without that.
 165 2011-06-25T19:36:32  <xorAxAx> pkumar: will do in the next days
 166 2011-06-25T19:37:15  <hardy89> pkumar: here http://www.pastie.org/2121394
 167 2011-06-25T19:38:23  <pkumar> xorAxAx : ok. I just noticed that there were no tests for some of the classes so I just added for them in util/test_crypto.py. Though I've checked from my side and it works well.
 168 2011-06-25T19:38:51  <pkumar> hardy89 : thanks, lemme check.
 169 2011-06-25T19:39:05  <hardy89> pkumar: np
 170 2011-06-25T19:40:07  <pkumar> hardy89 : can you do the same for _test/test_sourcecode.py
 171 2011-06-25T19:40:36  <hardy89> pkumar: sure
 172 2011-06-25T19:42:15  <hardy89> pkumar: http://www.pastie.org/2121417
 173 2011-06-25T19:43:28  <pkumar> hardy89 : ok, I just had to confirm, it's not breaking only for me.
 174 2011-06-25T19:44:21  <hardy89> pkumar: hm. np
 175 2011-06-25T19:45:37  <pkumar> hardy89 : Also in your system clone your repo and pull my changesets in the new one, so that you will have a backup of the original one.
 176 2011-06-25T19:46:12  <Marchael> ThomasWaldmann: is there any way to get item from storage using name and rev_no? except iter_items_noindex()
 177 2011-06-25T19:46:28  <hardy89> pkumar: all right. will do it. and in case i see anything wrong with it, will let you know.
 178 2011-06-25T19:46:34  <Marchael> s/item/revision/
 179 2011-06-25T19:47:35  <pkumar> hardy89 : sure
 180 2011-06-25T19:48:31  <ThomasWaldmann> Marchael: get_item and get_revision (or so)
 181 2011-06-25T19:48:50  * ThomasWaldmann must go
 182 2011-06-25T19:49:08  <dreimark> ronny: sonewhere here ?
 183 2011-06-25T19:49:30  <Marchael> ok, thx
 184 2011-06-25T19:50:13  <hardy89> hi ThomasWaldmann : i'm unable to make a diary entry of 21st June. this is what i get -->Page could not get locked. Missing 'current' file?
 185 2011-06-25T19:52:12  <dreimark> hardy89: url?
 186 2011-06-25T19:52:38  <hardy89> dreimark: http://moinmo.in/Himanshu%20Awasthi/Diary%20Page/2011-06-21#preview
 187 2011-06-25T19:55:25  <dreimark> hardy89: ack, use http://moinmo.in/Himanshu Awasthi/Diary Page/2011-06-21a for now
 188 2011-06-25T19:55:31  <dreimark> bbl
 189 2011-06-25T19:56:05  <hardy89> Sure. Thanks dreimark
 190 2011-06-25T20:25:01  *** hardy89 has quit IRC
 191 2011-06-25T20:36:01  *** MattMaker_ has joined #moin-dev
 192 2011-06-25T20:38:56  *** MattMaker has quit IRC
 193 2011-06-25T20:38:56  *** MattMaker_ is now known as MattMaker
 194 2011-06-25T20:44:59  *** greg_f has quit IRC
 195 2011-06-25T20:46:06  <dreimark> re
 196 2011-06-25T21:00:21  <Marchael> dreimark: when I try to get trashed item from backend I got a error, but this item exist
 197 2011-06-25T21:01:05  <dreimark> which error
 198 2011-06-25T21:01:24  <Marchael> btw, script fails because it assume what user add new revision
 199 2011-06-25T21:01:50  <Marchael> raise NoSuchItemError("No such item '%r'." % itemname)
 200 2011-06-25T21:02:18  <Marchael> it happens when I try to get last revison of trashed item
 201 2011-06-25T21:02:51  <dreimark> if an item is trashed it is moved out of scope.
 202 2011-06-25T21:03:04  <Marchael> also, when item gone to trash, revision counter++
 203 2011-06-25T21:03:10  <dreimark> and the recent location of the item is completly free
 204 2011-06-25T21:03:18  <dreimark> for a recreation of a different item
 205 2011-06-25T21:03:38  <Marchael> but why revision counter is increased?
 206 2011-06-25T21:03:58  <Marchael> it confusing
 207 2011-06-25T21:04:11  <dreimark> not sure now, but it can be that it goes as a new revision into the trash
 208 2011-06-25T21:04:26  <Marchael> yes
 209 2011-06-25T21:04:36  <Marchael> but that revision not in backend
 210 2011-06-25T21:04:46  <dreimark> it is in the trash backend
 211 2011-06-25T21:05:54  <Marchael> So I should catch this exception and remove document from index? any suggestions?
 212 2011-06-25T21:10:11  <Marchael> dreimark: ^
 213 2011-06-25T21:15:09  *** waldi has joined #moin-dev
 214 2011-06-25T21:15:10  *** waldi has joined #moin-dev
 215 2011-06-25T21:31:58  <dreimark> Marchael: yes
 216 2011-06-25T21:32:18  <Marchael> ok
 217 2011-06-25T21:32:27  <dreimark> later on you should  have  an index for stuff in the trashbin too
 218 2011-06-25T21:33:03  <Marchael> for searching in trashbin i guess
 219 2011-06-25T21:35:00  <dreimark> :)
 220 2011-06-25T21:54:46  *** sinha has joined #moin-dev
 221 2011-06-25T21:54:53  <sinha> re
 222 2011-06-25T21:56:02  <Marchael> 2011-06-26 01:53:11,893 WARNING MoinMoin.log:111 /home/marchael/Downloads/moin/moin2/moin-2.0/MoinMoin/error.py:39: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
 223 2011-06-25T21:56:09  <Marchael> what does it mean?
 224 2011-06-25T21:57:10  <sinha> dreimark: have you looked upon that why editor size accept negative values ? as of now i have kept restriction on that results_per_page as non-negative, is it ok ? OR just accept any value and check if its greater than 0 then use it otherwise use the default one ?
 225 2011-06-25T22:00:06  <dreimark> sinha: i guess negative is not used and we have to catch that
 226 2011-06-25T22:00:32  <dreimark> so no negative values
 227 2011-06-25T22:03:42  <Marchael> ThomasWaldmann: I rewrited most part of code what you pointed me http://codereview.appspot.com/4539114
 228 2011-06-25T22:12:37  <sinha> dreimark: so as of now i have to check in the function itself whether the value is greater than 0 or not, and yes got rid of that AttributeError exception block , [patch set 3] http://codereview.appspot.com/4633059/
 229 2011-06-25T22:18:07  *** pkumar has quit IRC
 230 2011-06-25T22:45:26  <dreimark> sinha: you have just only to use the value set there
 231 2011-06-25T22:45:52  <dreimark> and if it is 0 entered it just means a very long integer - no pagination
 232 2011-06-25T22:46:19  <dreimark> and if one enters negative value, this is invalid
 233 2011-06-25T22:47:34  <sinha> dreimark: but i thought 0 means the default value
 234 2011-06-25T22:48:34  <dreimark> that was a misunderstanding
 235 2011-06-25T22:49:17  <dreimark> the box must be initialized with the default value
 236 2011-06-25T22:49:21  <sinha> dreimark: then i might have to change the implementation of paging code, there i didn't check if the count is 0 or not, i was just using the value right away assuming that it could never be lesser than 1
 237 2011-06-25T22:49:21  <dreimark> if this is 50
 238 2011-06-25T22:49:27  <dreimark> the user gets 50 in that
 239 2011-06-25T22:49:36  <dreimark> if the user changes it to 10
 240 2011-06-25T22:49:43  <dreimark> then it is 10
 241 2011-06-25T22:49:52  <dreimark> and if the user writes 0 in it
 242 2011-06-25T22:50:07  <dreimark> it meant unlimited, just no pagination
 243 2011-06-25T22:50:19  <dreimark> this is how it is with the editor box
 244 2011-06-25T22:50:23  <dreimark> you can try that
 245 2011-06-25T22:52:54  <dreimark> it is better it behaves the similiar to the editor counter, otherwise this becomes confusing to the user of it
 246 2011-06-25T22:54:12  <sinha> dreimark: so 0 means no paging, but eidto_rows get the value 20 if it is set to be 0
 247 2011-06-25T22:54:21  <sinha> dreimark: it takes default value for 0
 248 2011-06-25T22:54:36  <sinha> s/edito/editor
 249 2011-06-25T22:54:42  * dreimark tries it again
 250 2011-06-25T22:55:31  <Marchael> ThomasWaldmann: ping
 251 2011-06-25T22:58:05  <dreimark> sinha: i can try tom on a larger screen, it may be that it looks like the same as 25 but it should behave like to use all free available space
 252 2011-06-25T22:58:14  <dreimark> for me is 0 currently 21
 253 2011-06-25T22:59:30  <dreimark> it should behave similiar to 1.x
 254 2011-06-25T22:59:55  <dreimark> don't ask me not why that is not like it yet/now/currently
 255 2011-06-25T23:00:42  <dreimark> -not-
 256 2011-06-25T23:04:14  <sinha> dreimark: ok so 0 means no pagination, but when to use the default value set in config ? for non-logged in users ?
 257 2011-06-25T23:05:23  <dreimark> yes
 258 2011-06-25T23:06:07  <dreimark> for non logged in users and showing in the text field for logged in users unless of course they enter their own value
 259 2011-06-25T23:10:54  <sinha> okay, fine, i guess have to do some more changes now
 260 2011-06-25T23:12:00  <dreimark> ;)
 261 2011-06-25T23:12:15  <dreimark> me has to sleep soon, travelling tom
 262 2011-06-25T23:12:24  <sinha> dreimark: and one more thing, do i need to create function there in user.py just has to get the value
 263 2011-06-25T23:12:39  <sinha> i mean its just a single line then
 264 2011-06-25T23:15:28  <dreimark> if its necessary do, you should be able to read cfg there too
 265 2011-06-25T23:23:52  <Marchael> gn/bbl
 266 2011-06-25T23:28:53  <dreimark> gn
 267 2011-06-25T23:29:37  <ronny> re
 268 2011-06-25T23:43:32  *** m4k3r_ has quit IRC
 269 

MoinMoin: MoinMoinChat/Logs/moin-dev/2011-06-25 (last edited 2011-06-24 22:45:03 by IrcLogImporter)