1 2011-07-05T00:00:07 <sinha> okay, i have used that default one ( en_US) now my sorting changes, all non-english names comes at first now
2 2011-07-05T00:01:00 <sinha> previously without passing any param, non-english(s) were coming at the end
3 2011-07-05T00:01:45 <dreimark> that's interesting, and it means the wiki has a different default than your user
4 2011-07-05T00:03:01 <ThomasWaldmann> sinha: why do you want to touch the locale?
5 2011-07-05T00:03:06 <dreimark> sinha: ask ThomasWaldmann to look at that in the next review
6 2011-07-05T00:03:40 <sinha> ThomasWaldmann: to sort the item names
7 2011-07-05T00:04:33 <ThomasWaldmann> you never ever change the locale
8 2011-07-05T00:05:01 <sinha> so i dont use locale.setlocale
9 2011-07-05T00:08:25 <sinha> okay works fine without setting the locale
10 2011-07-05T00:25:53 *** sinha
11 2011-07-05T00:26:08 *** sinha
12 2011-07-05T00:26:14 <RogerHaase> dreimark: sinha: sorry, busy on other things and missed the please take a look. I like the new format. One thing that concerns me is sinha's comment about font size in px. em usually works better.
13 2011-07-05T00:27:10 <RogerHaase> so if you are using float left, users with big fonts just get fewer columns.
14 2011-07-05T00:28:15 <ThomasWaldmann> RogerHaase: for the font itself, you mean pt maybe? (as em is relative to m size, it can't be used for the font itself, can it?)
15 2011-07-05T00:28:43 <sinha> ThomasWaldmann: but i guess relative is a good choice
16 2011-07-05T00:29:21 <sinha> it fits, based on resolution
17 2011-07-05T00:31:59 <RogerHaase> iirc, pt is recommented only for printed output. px is ok to use, but I am not sure if all browsers will enlarget he text if user does ctrl+
18 2011-07-05T00:33:30 <dreimark> if em validates for font then nothing holds us back
19 2011-07-05T00:34:58 <ThomasWaldmann> afaik em is for giving e.g. a block width, relative to to width of a "m" character
20 2011-07-05T00:35:30 <ThomasWaldmann> it doesn't make sense to define a font size using it, as that would be self-referential, no?
21 2011-07-05T00:37:05 <ThomasWaldmann> http://en.wikipedia.org/wiki/Em_%28typography%29
22 2011-07-05T00:38:57 <RogerHaase> am I not understanding common.css, line 56: h1 { font-size: 2em; margin: .67em 0; }
23 2011-07-05T00:40:25 <dreimark> http://kyleschaeffer.com/best-practices/css-font-size-em-vs-px-vs-pt-vs/
24 2011-07-05T00:40:59 <dreimark> 1em = 12pt = 16px = 100%.
25 2011-07-05T00:41:04 <RogerHaase> http://www.w3.org/TR/CSS2/sample.html
26 2011-07-05T00:42:16 <dreimark> In theory, the em unit is the new and upcoming standard for font sizes ...
27 2011-07-05T00:44:56 <dreimark> we should use em
28 2011-07-05T00:45:02 <dreimark> anyway gn
29 2011-07-05T00:46:51 <RogerHaase> gn dreimark. I must go as well.
30 2011-07-05T00:47:16 *** RogerHaase
31 2011-07-05T01:18:39 *** sinha
32 2011-07-05T02:02:08 *** gmgall
33 2011-07-05T02:02:34 *** gmgall
34 2011-07-05T07:15:33 *** m4k3r
35 2011-07-05T08:32:22 <dreimark> moin
36 2011-07-05T08:34:30 <faina> Good morning
37 2011-07-05T09:08:19 *** xjjk
38 2011-07-05T09:31:45 *** mkerrin
39 2011-07-05T09:36:39 *** faina
40 2011-07-05T10:43:08 *** pkumar
41 2011-07-05T10:53:57 *** m4k3r
42 2011-07-05T10:54:14 *** m4k3r
43 2011-07-05T11:20:24 *** m4k3r
44 2011-07-05T11:20:53 *** m4k3r
45 2011-07-05T11:43:19 <dreimark> moin
46 2011-07-05T11:45:25 *** greg_f
47 2011-07-05T13:19:10 *** pkumar
48 2011-07-05T13:19:34 *** pkumar
49 2011-07-05T13:34:16 <xorAxAx> pkumar: hi
50 2011-07-05T13:34:38 <xorAxAx> pkumar: my feedback to your commits:
51 2011-07-05T13:34:56 <xorAxAx> accc2bfda374 contains a method testvalidtoken -- please use more underscores in method names :)
52 2011-07-05T13:35:34 <xorAxAx> pkumar: aec005cc5725 contains a copy&paste error - result1 != result1. please make tests fail before you make them pass
53 2011-07-05T13:35:48 <xorAxAx> pkumar: then such bugs cant happen
54 2011-07-05T13:36:04 <xorAxAx> ah, the next cs fixes that, but my advise still holds
55 2011-07-05T13:36:59 <xorAxAx> 60e6936eaf4c contains the name invlid_result which contains a typo
56 2011-07-05T13:37:18 <Marchael> moin
57 2011-07-05T13:37:27 <xorAxAx> b3aeaf60adcc "assert result == False" can be written as "assert not result"
58 2011-07-05T13:37:49 <Marchael> ThomasWaldmann: what's the difference betwenn remove_rev() and remove_item() in indexing.py
59 2011-07-05T13:38:02 <xorAxAx> 069bb2764aaf and probably other tests contain whitespace at the end of the line
60 2011-07-05T13:38:20 <xorAxAx> please configure your editor to alert you when such whitespace exists
61 2011-07-05T13:39:04 <xorAxAx> 1476764d3857 whats the point of self.makefile(self.src1, 'src1')?
62 2011-07-05T13:39:41 <xorAxAx> 837d949a4539 repr tests are not very useful IMHO because reprs might change
63 2011-07-05T13:40:43 <xorAxAx> f67e58bf2f3e contains a == False again
64 2011-07-05T13:42:18 <xorAxAx> b016b5b3c0e2 is unclean and contains a checkin of "import pytest" and a pdb call
65 2011-07-05T13:43:08 <xorAxAx> pkumar: but besides that, the tests look nice
66 2011-07-05T13:43:29 <xorAxAx> but i still have the impression that you could spend more time on gsoc than you are doing now
67 2011-07-05T13:55:19 <dreimark> Marchael: i guess without looking at it remove_rev removes a revision and remove_item removes the whole item
68 2011-07-05T13:56:25 <Marchael> > note: does not remove revisions, these should be removed first
69 2011-07-05T13:56:35 <Marchael> it's from comment to remove_item
70 2011-07-05T13:57:55 <Marchael> if I understand right it removes only latest revision
71 2011-07-05T14:04:23 <pkumar> xorAxAx : hi, I was just away for a while
72 2011-07-05T14:04:51 <pkumar> xorAxAx : reading your feedback
73 2011-07-05T14:07:02 <pkumar> xorAxAx : ok, I'll fix the changesets as you have suggested.
74 2011-07-05T14:08:32 <pkumar> xorAxAx : also, as in the beginning, it took a little time in reading and understanding the codes. work should be faster from now onwards. :)
75 2011-07-05T14:09:28 <xorAxAx> pkumar: ok :)
76 2011-07-05T14:17:02 <pkumar> bbl
77 2011-07-05T14:17:08 *** pkumar
78 2011-07-05T14:17:56 <Marchael> ThomasWaldmann: if I understand right remove_item() and remove_rev() do the same things with different ways
79 2011-07-05T14:19:04 <Marchael> but remove_rev() using in IndexingRevisionMixin, and remove_item() in IndexingItemMixin
80 2011-07-05T14:23:22 <Marchael> dreimark: what difference between item and revision?
81 2011-07-05T14:23:55 <ronny> sup
82 2011-07-05T14:27:58 <dreimark> Marchael: change an item and look at History of it
83 2011-07-05T14:28:11 <dreimark> then I think you get what the meaning is
84 2011-07-05T14:52:00 *** gmgall
85 2011-07-05T15:54:54 *** raignarok
86 2011-07-05T15:57:05 <Marchael> update_item() should only update latest_revs_index? or latest_revs_index+all_revs_index?
87 2011-07-05T16:13:25 *** m4k3r
88 2011-07-05T16:13:57 *** m4k3r
89 2011-07-05T16:42:00 *** xjjk
90 2011-07-05T16:51:33 *** xjjk
91 2011-07-05T16:54:27 *** xjjk
92 2011-07-05T17:00:22 *** sinha
93 2011-07-05T17:01:27 *** gmgall
94 2011-07-05T17:18:18 *** gmgall
95 2011-07-05T17:29:17 *** pkumar
96 2011-07-05T17:35:06 *** blah
97 2011-07-05T17:35:43 <blah> hey everyone
98 2011-07-05T17:36:15 <blah> i was just looking at the various python projects out there and i happened to glance upon moin-moin
99 2011-07-05T17:36:29 <blah> is there anything i can help out with? testing?
100 2011-07-05T17:38:44 <pkumar> blah : hey, you might want to have a look at http://bitbucket.org/thomaswaldmann/moin-2.0
101 2011-07-05T17:38:52 <pkumar> to begin with
102 2011-07-05T17:39:02 <blah> is that the main branch?
103 2011-07-05T17:39:07 <blah> pkumar: ^
104 2011-07-05T17:39:21 <pkumar> blah : yeah
105 2011-07-05T17:39:26 <blah> cool, thanks!
106 2011-07-05T17:39:50 <blah> any TODO page for moin-moin? :|
107 2011-07-05T17:40:34 <pkumar> blah : you can also have a look at http://static.moinmo.in/m2/html/. was helpful for me.
108 2011-07-05T17:41:02 <blah> thank you
109 2011-07-05T17:41:13 <pkumar> blah : np
110 2011-07-05T17:41:21 <pkumar> :)
111 2011-07-05T17:48:35 <Marchael> I'm trying to solve this https://bitbucket.org/thomaswaldmann/moin-2.0/issue/33/uuid-is-changing-for-default-documents and I'm need to know which function add revisions for items in fs2 backend
112 2011-07-05T17:49:53 <Marchael> I found _add_item_internally_locked() in fs2.py, but seems like that function uing only for creating new revisions
113 2011-07-05T17:50:01 <Marchael> s/revisions/items/
114 2011-07-05T17:59:18 *** MattMaker
115 2011-07-05T18:00:32 <Marchael> ThomasWaldmann: ^
116 2011-07-05T18:04:26 * dreimark who is her
117 2011-07-05T18:04:28 <dreimark> e
118 2011-07-05T18:06:50 <dreimark> ThomasWaldmann: waldi xorAxAx pkumar sinha ping
119 2011-07-05T18:06:58 <pkumar> pong
120 2011-07-05T18:07:01 <waldi> peng
121 2011-07-05T18:07:03 <sinha> present
122 2011-07-05T18:07:33 <dreimark> at least two mentors and their students are here
123 2011-07-05T18:07:59 <dreimark> it is meeting time since 5 mins
124 2011-07-05T18:08:21 <dreimark> sinha: can you start?
125 2011-07-05T18:08:25 <sinha> okay
126 2011-07-05T18:08:34 <sinha> LAST/CURRENT: Working on the alphabetic (filtering/sorting) view for global index
127 2011-07-05T18:08:34 <sinha> BLOCKER: To display the item names, i was using locale.setlocale(LC_ALL,"") to sort them, but as ThomasWaldmann told not to change the locale, so now having simple python sort function, but the sort order is not coming what expected, all lowercase names are coming after all the upercase names.so how to sort them properly without setting the locale.
128 2011-07-05T18:08:34 <sinha> NEXT: Will put the same look and feel as global index to item index page
129 2011-07-05T18:10:28 <dreimark> so the sort problem can be solved meanwhile doing the changes of item index page
130 2011-07-05T18:10:47 <sinha> yes, it could be
131 2011-07-05T18:10:48 <dreimark> I think there can be a lambda added to sort for comparison
132 2011-07-05T18:11:18 <sinha> here i am sorting list of tuples, so using the lambda
133 2011-07-05T18:11:24 <sinha> index.sort(cmp=locale.strcoll, key=lambda tup: tup[1])
134 2011-07-05T18:11:52 <dreimark> sorted("This is a test string from Andrew".split(), key=str.lower)
135 2011-07-05T18:12:32 <sinha> use this sorted function ?
136 2011-07-05T18:13:03 <dreimark> probably it also works with the sort method
137 2011-07-05T18:13:23 <dreimark> i think we schedule this and ask google a bit
138 2011-07-05T18:13:55 <sinha> okay
139 2011-07-05T18:14:01 <dreimark> sinha: do you think you need more than a day to change the item index view?
140 2011-07-05T18:14:13 <sinha> no
141 2011-07-05T18:14:23 <sinha> once i am done with global index
142 2011-07-05T18:14:30 <sinha> it will be done in a day
143 2011-07-05T18:15:05 <dreimark> ok, because we set goals always for the next meeting
144 2011-07-05T18:15:26 <sinha> okay so for NEXT, i guess it will be full diff of revisions
145 2011-07-05T18:15:36 <sinha> that inline diff
146 2011-07-05T18:15:45 <dreimark> or do you plans do add e.g. a filter to the indexes
147 2011-07-05T18:16:28 <dreimark> e.g show only text items
148 2011-07-05T18:16:41 <sinha> okay, i will do that
149 2011-07-05T18:17:20 <sinha> do this filtering after completing with the item index view also ?
150 2011-07-05T18:17:29 <dreimark> that would be great, because that makes the transistion easier
151 2011-07-05T18:17:37 <dreimark> yes
152 2011-07-05T18:17:43 <sinha> okay
153 2011-07-05T18:18:14 <dreimark> people of old moins do have only pages in index for titles
154 2011-07-05T18:18:52 <dreimark> with a text mimetype.
155 2011-07-05T18:19:06 <sinha> dreimark: and i am yet to do paging, should i also go for this ?
156 2011-07-05T18:19:44 <sinha> i mean index is coming as list, so for paging it would be just selecting the indexes of that list
157 2011-07-05T18:20:09 <dreimark> yes, sounds good
158 2011-07-05T18:20:43 <dreimark> the filter for itemtypes should be optional, e.g. checkboxes
159 2011-07-05T18:21:18 <dreimark> for what is shown
160 2011-07-05T18:21:23 <sinha> so display all kind of mime-types, eg. text, image, video, application
161 2011-07-05T18:21:35 <sinha> and let user select one or more
162 2011-07-05T18:21:37 <dreimark> yes
163 2011-07-05T18:22:07 <dreimark> all enaabled on default, so he reduces list
164 2011-07-05T18:22:30 <sinha> yes
165 2011-07-05T18:22:45 <dreimark> ok, i think we are clear about that and can discuss later more
166 2011-07-05T18:22:50 <sinha> sure
167 2011-07-05T18:23:00 * dreimark any more questions to sinha ?
168 2011-07-05T18:23:40 <dreimark> thanks sinha
169 2011-07-05T18:24:01 <dreimark> xorAxAx: waldi pkumar can you continue please
170 2011-07-05T18:24:25 <pkumar> sure :)
171 2011-07-05T18:24:38 <pkumar> this week:
172 2011-07-05T18:24:39 <pkumar> worked on improving the test coverage.
173 2011-07-05T18:24:39 <pkumar> mostly worked on the modules : util, apps, MoinMoin, themes and improved their test coverage.
174 2011-07-05T18:24:39 <pkumar> Also went through the tests and codes of the modules config and some files of converter modules.
175 2011-07-05T18:24:39 <pkumar> among the modules assigned to me on ep other two(script, signalling) don't have any test so they'll be taken care in next phase of test improvement.
176 2011-07-05T18:24:39 <pkumar> NEXT: planning to work on other modules i.e. apps, config and converter for 2/3 days more. will add the task in ep for further dates after discussing with hardy89 by today or max tomorrow.
177 2011-07-05T18:24:43 <pkumar> Blockers: nothing as of now.
178 2011-07-05T18:26:49 <dreimark> pkumar: planning to works sounds to me that this can happen always
179 2011-07-05T18:27:38 <dreimark> may be try to make an estimation of promises what you think/can work on in pauses of other work
180 2011-07-05T18:27:45 * ThomasWaldmann late, sorry, was stuck in traffic
181 2011-07-05T18:28:06 <dreimark> you can always change this, but it gives a better communication path about that
182 2011-07-05T18:28:28 <dreimark> welcome ThomasWaldmann you are not the only one missing
183 2011-07-05T18:29:28 <dreimark> pkumar: also the discussion with hardy89 about the modules is easier if both of you add them earlier
184 2011-07-05T18:30:17 <dreimark> waldi: do you have questions?
185 2011-07-05T18:30:28 <dreimark> xorAxAx: missing?
186 2011-07-05T18:30:40 <dreimark> or any one else?
187 2011-07-05T18:31:27 <pkumar> ok, will work on the test improvement of the above mentioned modules
188 2011-07-05T18:31:28 <pkumar> in next 3 days
189 2011-07-05T18:31:59 <waldi> dreimark: nope
190 2011-07-05T18:32:15 <pkumar> dreimark : yeah. I can't see hardy89 here either to discuss about plans
191 2011-07-05T18:32:32 <dreimark> pkumar: and the once for the 4 days until next meeting will be soon in the ep
192 2011-07-05T18:32:32 <pkumar> or tasks
193 2011-07-05T18:32:54 <dreimark> pkumar: yeah, i miss him too not only at meeting time
194 2011-07-05T18:34:13 <dreimark> ok, thanks pkumar
195 2011-07-05T18:34:17 <ThomasWaldmann> last commit of hardy was 6d ago
196 2011-07-05T18:34:19 <pkumar> :)
197 2011-07-05T18:34:21 *** blah
198 2011-07-05T18:34:39 <dreimark> Marchael: you are next
199 2011-07-05T18:34:42 <Marchael> This week I'm working on emproving cli syntax for index script, also I merged building and updating script to one and make some bugfixes
200 2011-07-05T18:34:42 <Marchael> Next week I'll be working on updating index at moin runtime, I'm using AsyncWriter for now, but in the nearest future I 'll using normal writer with locking.
201 2011-07-05T18:34:42 <Marchael> BLOCKER: bug with uuid changing for default items, I wrote about it above.
202 2011-07-05T18:35:45 <ThomasWaldmann> s/this/last/ s/next/this ?
203 2011-07-05T18:36:19 <Marchael> yeah :)
204 2011-07-05T18:36:30 <ThomasWaldmann> how exactly is that blocker a blocker?
205 2011-07-05T18:37:20 <ThomasWaldmann> (I mean, if you do have an issue with the preload items, you do not need to use them)
206 2011-07-05T18:37:29 <Marchael> when I searching for uuid and revno in indexes sometimes I couldn't find default documents
207 2011-07-05T18:37:44 <Marchael> with names "Home", "rst", "creole"
208 2011-07-05T18:37:56 <ThomasWaldmann> well, use your own?
209 2011-07-05T18:38:23 <Marchael> because first revision always has uuid == name, and others have different uuid
210 2011-07-05T18:39:02 <Marchael> not use? how?
211 2011-07-05T18:39:08 <dreimark> this are some items which where loaded on initialising the wiki
212 2011-07-05T18:39:15 <dreimark> i think you can ommit that
213 2011-07-05T18:39:25 <dreimark> and just create your own items
214 2011-07-05T18:39:55 <Marchael> but thats items duplicated
215 2011-07-05T18:39:58 <ThomasWaldmann> well, i think the tip of using load_xml = None was quite frequent here on the channel
216 2011-07-05T18:40:23 <Marchael> So I have two different "Home"
217 2011-07-05T18:40:38 <dreimark> Marchael: just read what i explained
218 2011-07-05T18:40:41 <ThomasWaldmann> if you use that, you have no items at all.
219 2011-07-05T18:40:41 <Marchael> in latest and all revs indexes
220 2011-07-05T18:40:51 <dreimark> you don't have any items then
221 2011-07-05T18:40:58 <ThomasWaldmann> so, does your stuff work for items you have saved on your own?
222 2011-07-05T18:41:05 <dreimark> you should then use the wiki and create some
223 2011-07-05T18:41:07 <Marchael> yes
224 2011-07-05T18:41:18 <dreimark> then go that path
225 2011-07-05T18:41:25 <ThomasWaldmann> so, in what way is that a blocker then?
226 2011-07-05T18:41:29 <Marchael> ok, but another problem
227 2011-07-05T18:42:01 <Marchael> if I use name and revno for searching revision, I can't find trashed revisions
228 2011-07-05T18:42:26 <ThomasWaldmann> well, find out why
229 2011-07-05T18:42:47 <Marchael> so I point your attention to this bug, because I want to use uuid + revno
230 2011-07-05T18:43:08 <Marchael> but if i can ommit that, it doesn't matter
231 2011-07-05T18:43:12 <ThomasWaldmann> for now, you use name and revno
232 2011-07-05T18:43:18 <Marchael> yes
233 2011-07-05T18:43:53 <Marchael> but it's also no good because user can rename item
234 2011-07-05T18:43:55 <ThomasWaldmann> ok, so I guess we have no blocker
235 2011-07-05T18:44:16 <Marchael> I guess so
236 2011-07-05T18:44:25 <ThomasWaldmann> we only have the problem that progress is much too slow
237 2011-07-05T18:44:35 <dreimark> Marchael: we know that you are not able to make a perfect solution because of the given limitations we have
238 2011-07-05T18:44:56 <dreimark> but we work on all those parts and at the end it will be perfect
239 2011-07-05T18:45:15 <ThomasWaldmann> (17:47) < Marchael> I'm trying to solve this https://bitbucket.org/thomaswaldmann/moin-2.0/issue/33/uuid-is-changing-for-default-documents and I'm need to know which function add revisions for items in fs2 backend
240 2011-07-05T18:45:39 <ThomasWaldmann> and i'ld like to suggest that you concentrate on search code, not try to fix uuid bugs
241 2011-07-05T18:45:52 <Marchael> ok
242 2011-07-05T18:46:16 <ThomasWaldmann> (because that would cost you at least a lot if not infinite time, time that you do not have)
243 2011-07-05T18:48:15 <Marchael> ThomasWaldmann: recently you told me about database to test, can you share this?
244 2011-07-05T18:48:23 <Marchael> s/to/for/
245 2011-07-05T18:48:23 <dreimark> you can set markers for XXX or ToDo into the code also. but don't let you blocked by this circumstances
246 2011-07-05T18:48:34 <ThomasWaldmann> btw, you should try to at least have indexing in a GOOD state until midterm
247 2011-07-05T18:49:29 <ThomasWaldmann> (and that includes some data indexing)
248 2011-07-05T18:50:12 *** pkumar
249 2011-07-05T18:50:49 * dreimark any more questions to Marchael ?
250 2011-07-05T18:51:10 <ThomasWaldmann> nope
251 2011-07-05T18:51:31 <dreimark> thanks Marchael
252 2011-07-05T18:52:18 <dreimark> hardy89 is still missing
253 2011-07-05T18:52:42 * dreimark meeting is over
254 2011-07-05T18:52:53 *** pkumar
255 2011-07-05T18:52:53 <ThomasWaldmann> well, considering his nonexisting recent commits, it looks a bit like he is not that interested in his project
256 2011-07-05T18:53:56 <Marchael> ThomasWaldmann: I found what ItemIndex.get_uuid_revno_name() in indexing.py not using in other parts of code, can I ignore that?
257 2011-07-05T18:53:57 <ThomasWaldmann> waldi: try to contact him and ask him what's up
258 2011-07-05T18:53:57 <dreimark> so this time schedule for tuesday was only a little bit better than for wednesday. The one who introduced the change of the day is missing.
259 2011-07-05T18:54:27 <ThomasWaldmann> Marchael: in indexing you just add what you need for whoosh
260 2011-07-05T18:55:06 <ThomasWaldmann> (and you keep it clearly separate from the existing code there)
261 2011-07-05T18:55:06 <Marchael> I just add whoosh code to existing functions of ItemIndex object
262 2011-07-05T18:55:13 <Marchael> hm
263 2011-07-05T18:55:53 <waldi> ThomasWaldmann: sure
264 2011-07-05T18:56:38 <ThomasWaldmann> Marchael: you can do that as long as it is clearly visible what's for what
265 2011-07-05T19:05:41 <Marchael> ThomasWaldmann: for now I do indexing in this way http://paste.pocoo.org/show/430201/
266 2011-07-05T19:05:54 *** mkerrin
267 2011-07-05T19:07:09 <Marchael> I added my code to existing functions in ItemIndex class
268 2011-07-05T19:13:32 <ThomasWaldmann> that patch has unintended changes
269 2011-07-05T19:15:05 <ThomasWaldmann> don't change ANYTHING without reason
270 2011-07-05T19:15:56 <ThomasWaldmann> it still seems to not use app.cfg
271 2011-07-05T19:15:58 <Marchael> ok, I separate my code from already writeen
272 2011-07-05T19:16:07 <Marchael> *written
273 2011-07-05T19:17:33 <Marchael> I try to use init_backends with different apps, but have no result
274 2011-07-05T19:17:51 *** m4k3r
275 2011-07-05T19:19:06 *** m4k3r
276 2011-07-05T19:26:22 *** pkumar
277 2011-07-05T19:27:28 <ThomasWaldmann> Marchael: didn't we already discuss that enough and how to solve it?
278 2011-07-05T19:27:52 <Marchael> m, yes I remember
279 2011-07-05T19:27:56 <dreimark> bbl
280 2011-07-05T19:34:46 *** sinha
281 2011-07-05T19:34:59 *** sinha
282 2011-07-05T19:50:14 *** greg_f
283 2011-07-05T19:54:30 <Marchael> ThomasWaldmann: now I have access to app.cfg http://paste.pocoo.org/show/430253/
284 2011-07-05T20:01:31 <ThomasWaldmann> Marchael: btw, it would be much more comfortable if you just used codereview
285 2011-07-05T20:01:58 <Marchael> ok
286 2011-07-05T20:01:59 <ThomasWaldmann> and you don't create an app in ItemIndex
287 2011-07-05T20:02:18 <ThomasWaldmann> (because you already have one)
288 2011-07-05T20:02:28 <Marchael> hm, but I'm need only app.cfg
289 2011-07-05T20:02:45 <ThomasWaldmann> it's stupid, don't do it
290 2011-07-05T20:03:22 <ThomasWaldmann> all you do there has already been done for you
291 2011-07-05T20:04:27 <Marchael> so my mistake what I try create flask app, what already exist?
292 2011-07-05T20:04:32 <ThomasWaldmann> (and we already talked about the solution yesterday)
293 2011-07-05T20:05:39 <ThomasWaldmann> you already have an "app" a few level above, you just need to pass it there
294 2011-07-05T20:10:24 <CIA-114> Radomir Dopieralski <sheep-devel@sheep.art.pl> default * 5785:62202e5435e2 1.9/MoinMoin/action/revert.py:
295 2011-07-05T20:10:24 <CIA-114> Catch iand display all SaveErrors when revert failed, not just RevertError and
296 2011-07-05T20:10:24 <CIA-114> Unchanged.
297 2011-07-05T20:10:24 <CIA-114> Fixes http://moinmo.in/MoinMoinBugs/SaveError%20on%20revert%20due%20to%20BadContent
298 2011-07-05T20:11:21 <ThomasWaldmann> ah :)
299 2011-07-05T20:11:58 <dreimark> :)
300 2011-07-05T20:15:41 <Marchael> but I looked whole indexing.py and can't find this "app"
301 2011-07-05T20:22:14 * Marchael don't know how get access to flask app inside app
302 2011-07-05T20:36:58 <dreimark> Marchael: read again http://moinmo.in/MoinMoinChat/Logs/moin-dev/2011-07-04#CA-f9f8362ac3da1d2822ec19b0a550bec67338ea6f_113
303 2011-07-05T20:57:23 *** m4k3r
304 2011-07-05T20:57:51 *** m4k3r
305 2011-07-05T21:09:40 <dreimark> Marchael: you are allowed to change init_backends or something else if that helps, you don't need to create only new code you can extend existings also
306 2011-07-05T21:12:20 <Marchael> dreimark: I understand what I'm need initialize backends with init_backends() to get access to config, but I don't understand where do I get that app.
307 2011-07-05T21:13:00 <Marchael> s/init_backends()/init_backends(app)/
308 2011-07-05T21:13:09 <dreimark> read init_backends
309 2011-07-05T21:13:37 <Marchael> > unprotected_storage = router.RouterBackend(unprotected_mapping, index_uri=index_uri)
310 2011-07-05T21:14:30 <Marchael> but I'm access to app.cfg for unprotected_mapping
311 2011-07-05T21:14:40 <dreimark> read some lines above
312 2011-07-05T21:14:55 <dreimark> look how index_uri is passed
313 2011-07-05T21:15:14 <Marchael> index_uri = app.cfg.router_index_uri
314 2011-07-05T21:15:50 <dreimark> look at IndexingBackendMixin how it is received
315 2011-07-05T21:18:40 <Marchael> > index_uri = kw.pop('index_uri', None)
316 2011-07-05T21:18:54 <Marchael> I can pop unprotected_mapping?
317 2011-07-05T21:19:21 <dreimark> at least you can pass it similiar
318 2011-07-05T21:19:34 <dreimark> you just don't need to create a new app
319 2011-07-05T21:21:09 <dreimark> bbl
320 2011-07-05T21:34:00 *** m4k3r
321 2011-07-05T21:35:32 *** m4k3r
322 2011-07-05T21:39:52 <Marchael> I have infinite recursion with router.RouterBackend in ItemIndex
323 2011-07-05T21:41:07 <Marchael> because RouterBackend inherit from IndexingBackendMixin, and there we calling ItemIndex.__init__()
324 2011-07-05T21:41:17 <Marchael> with RouterBackend
325 2011-07-05T21:55:45 <ThomasWaldmann> well, as it worked before your modification, you likely did something wrong
326 2011-07-05T21:58:20 <Marchael> I try to pass app.cfg.index_dir in init_backends(), but it fails
327 2011-07-05T21:59:19 <Marchael> http://paste.pocoo.org/show/430349/
328 2011-07-05T21:59:23 <Marchael> 9,16
329 2011-07-05T22:00:44 <Marchael> I can get access to index_dir, but code don't working http://paste.pocoo.org/show/430351/
330 2011-07-05T22:02:01 <ThomasWaldmann> http://labs.twistedmatrix.com/ maybe we need such a highscore table, too :D
331 2011-07-05T22:03:48 <ThomasWaldmann> 42!
332 2011-07-05T22:04:24 <Marchael> yes, app.cfg raises exceptio here
333 2011-07-05T22:05:03 <Marchael> so I commented this line to see what happend further
334 2011-07-05T22:05:09 *** gmgall
335 2011-07-05T22:06:55 <ThomasWaldmann> doesn't look that bad
336 2011-07-05T22:07:05 <ThomasWaldmann> but you're giving None as dir to whoosh
337 2011-07-05T22:08:32 <Marchael> I check this
338 2011-07-05T22:16:50 <Marchael> rather mystic stuff
339 2011-07-05T22:18:02 <Marchael> Althought seems like the main reason in index_rebuild()
340 2011-07-05T22:18:24 <Marchael> because it don't pass index_dir to ItemIndex
341 2011-07-05T22:20:05 <Marchael> line 132, 133 from app.py
342 2011-07-05T22:23:46 <Marchael> I add debug output, http://paste.pocoo.org/show/430382/ lines 5-8, 12
343 2011-07-05T22:23:56 <Marchael> *added
344 2011-07-05T22:26:38 <Marchael> ThomasWaldmann: what you suggest me? I feel what reason in app.unprotected_storage.index_rebuild()
345 2011-07-05T22:36:29 <ThomasWaldmann> if you change some functionality, you need to change all users of it, too
346 2011-07-05T22:37:27 <ThomasWaldmann> File "/home/marchael/Downloads/moin/moin2/moin-2.0/MoinMoin/app.py", line 197, in import_export_xml
347 2011-07-05T22:37:30 <ThomasWaldmann> index_uri='sqlite://')
348 2011-07-05T22:40:29 <Marchael> oh, working, thanks!
349 2011-07-05T22:47:28 <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> default * 276:0513cfd0aaeb 2.0/ (quickinstall wikiconfig.py): use XStatic-MathJax package, require it via setup.py, remove it from quickinstall scripts
350 2011-07-05T22:47:46 <Marchael> ThomasWaldmann: please, review http://codereview.appspot.com/4650073
351 2011-07-05T23:06:46 * xorAxAx didnt know about the new meeting time
352 2011-07-05T23:11:55 <dreimark> oj
353 2011-07-05T23:16:41 <dreimark> it was first topic at last meeting http://moinmo.in/MoinMoinChat/Logs/moin-dev/2011-06-29#CA-bbc29b03e434c21ee85df02e2f8e34ee1224858c_230
354 2011-07-05T23:22:24 * Marchael need some rest
355 2011-07-05T23:22:27 <Marchael> gn/bbl
356 2011-07-05T23:23:37 <sinha> dreimark: just need to know about the locale, before uploading the code
357 2011-07-05T23:23:42 <sinha> should i set it or not
358 2011-07-05T23:25:29 <dreimark> don't set it
359 2011-07-05T23:25:49 <dreimark> that makes lots of problems
360 2011-07-05T23:26:01 <dreimark> sinha: ^
361 2011-07-05T23:26:29 <sinha> then how to sort, that time you said to use key=str.lower
362 2011-07-05T23:26:32 <dreimark> Marchael: good night
363 2011-07-05T23:26:38 <sinha> will it work in case of unicodes
364 2011-07-05T23:27:16 <sinha> and i already have key set in my sort function ( because of tuples )
365 2011-07-05T23:27:23 <dreimark> add a ToDo we solve it later
366 2011-07-05T23:28:26 <dreimark> i guess it is a one or two liner but have had not time to search for it
367 2011-07-05T23:28:47 <sinha> okay, fine
368 2011-07-05T23:29:06 <dreimark> that is later a simple cs
369 2011-07-05T23:30:07 <sinha> and also as of now we are just checking the first letter, so is regex required for that, i mean it could also be achieved from str.startswith() function ( which i did initially)
370 2011-07-05T23:31:03 <dreimark> good point, simplify it it can be changed when it is needed
371 2011-07-05T23:31:34 <dreimark> I have currently low bandwith because of a bb repo upload of mathjax
372 2011-07-05T23:32:49 <dreimark> fsck abort because of timeout, i think i try that with a cable later again
373 2011-07-05T23:33:46 <xorAxAx> dreimark: hmm
374 2011-07-05T23:36:45 <dreimark> xorAxAx: i was also a bit late. you have tom. the pytest meeting?
375 2011-07-05T23:37:09 <xorAxAx> dreimark: you mean the meeting that has never really worked out? :)
376 2011-07-05T23:37:21 <dreimark> yeah
377 2011-07-05T23:37:45 <xorAxAx> who organized the main meeting move?
378 2011-07-05T23:38:12 <dreimark> it was introduces by hardy89 who also didn't attend
379 2011-07-05T23:38:45 <dreimark> thomas looked at this repo today and there were no changes since 6 days
380 2011-07-05T23:41:06 <xorAxAx> well, he didnt move "our" meeting, so lets just meet as usual
381 2011-07-05T23:41:10 <xorAxAx> and see who will attend
382 2011-07-05T23:42:32 <dreimark> the usual meeting was from me (x) set. I welcome the move to tuesday afternoon
383 2011-07-05T23:42:52 <xorAxAx> i dont understand
384 2011-07-05T23:43:18 <dreimark> the new doodle result was that 8 have time at tuesday
385 2011-07-05T23:43:53 <dreimark> i have problems to attend wednesday because i have regular meetings at the time we scheduled it
386 2011-07-05T23:44:31 <dreimark> and therfore i said jein, because these meetings don't be each week
387 2011-07-05T23:46:11 <dreimark> http://www.doodle.com/srhzaz7h56fmb5nh
388 2011-07-05T23:46:50 <dreimark> works better for me
389 2011-07-05T23:47:53 <dreimark> if it did not fit into your plans we need a new doodle again
390 2011-07-05T23:50:10 <xorAxAx> no, tuesday 16 UTC is fine
391 2011-07-05T23:50:24 <xorAxAx> i just wasnt at home today at that time
392 2011-07-05T23:50:44 *** jek
393 2011-07-05T23:51:25 <dreimark> :)
394 2011-07-05T23:54:05 <dreimark> gn
395 2011-07-05T23:54:48 <xorAxAx> gn dreimark
