1 2011-07-08T00:11:40  <ThomasWaldmann> dreimark: https://bitbucket.org/thomaswaldmann/xstatic-jquery/changeset/8b2242c126f7 please do an equivalent change for all your packages
   2 2011-07-08T00:20:28  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 280:a9afdff3f42f 2.0/ (quickinstall quickinstall.bat setup.py): XStatic: pin XStatic==0.0.1 and compatible ressource packages
   3 2011-07-08T00:21:29  <ThomasWaldmann> dreimark: please add you package versions in the same way as you see there ^^ (AFTER updating the ressource packages to require XStatic==0.0.1)
   4 2011-07-08T01:20:40  *** sinha has quit IRC
   5 2011-07-08T04:01:53  *** Marchael has quit IRC
   6 2011-07-08T04:29:29  *** Marchael has joined #moin-dev
   7 2011-07-08T06:42:54  <Marchael> moin
   8 2011-07-08T07:23:38  *** m4k3r has joined #moin-dev
   9 2011-07-08T07:38:47  *** Marchael has quit IRC
  10 2011-07-08T07:43:48  *** Marchael has joined #moin-dev
  11 2011-07-08T08:04:23  * Marchael looks in MoinMoin.converter
  12 2011-07-08T08:04:42  <Marchael> Should I implment all of this converters to indexing?
  13 2011-07-08T08:31:58  <Marchael> ThomasWaldmann: ping
  14 2011-07-08T08:49:43  <Marchael> when you go bac, please look at ep
  15 2011-07-08T08:49:47  <Marchael> *back
  16 2011-07-08T08:58:04  *** hardy89 has joined #moin-dev
  17 2011-07-08T09:43:44  *** m4k3r has quit IRC
  18 2011-07-08T09:44:02  *** m4k3r has joined #moin-dev
  19 2011-07-08T09:59:13  *** hardy89 has quit IRC
  20 2011-07-08T10:01:17  *** mkerrin has joined #moin-dev
  21 2011-07-08T10:17:51  <Marchael> http://geekandpoke.typepad.com/.a/6a00d8341d3df553ef015432bf9167970c-pi
  22 2011-07-08T10:30:02  *** greg_f has joined #moin-dev
  23 2011-07-08T10:54:24  *** pkumar has joined #moin-dev
  24 2011-07-08T11:08:02  *** hardy89 has joined #moin-dev
  25 2011-07-08T11:11:38  <hardy89> hi pkumar
  26 2011-07-08T11:11:59  <pkumar> hey
  27 2011-07-08T11:12:18  <hardy89> pkumar: i've repaired my repo. i guess it is fine now
  28 2011-07-08T11:12:29  <pkumar> lemme see
  29 2011-07-08T11:12:31  <hardy89> pkumar: https://bitbucket.org/89hardy/moin_pytest
  30 2011-07-08T11:12:46  <hardy89> pkumar: yes please
  31 2011-07-08T11:13:46  <pkumar> ok, looks fine
  32 2011-07-08T11:13:53  <hardy89> pkumar: thanks.
  33 2011-07-08T11:16:25  <hardy89> pkumar: i even have a doubt
  34 2011-07-08T11:16:42  <hardy89> regarding pytest-cov
  35 2011-07-08T11:17:15  <hardy89> once a test is checked for coverage, and the report is generated,
  36 2011-07-08T11:17:37  <hardy89> 1. what % of coverage is considered to be good.
  37 2011-07-08T11:18:04  <hardy89> 2. if some test has less % of coverage, then what should be the next step
  38 2011-07-08T11:18:30  <hardy89> pkumar: please guide
  39 2011-07-08T11:19:19  <pkumar> hardy89 : there can be different approach to improve test coverage.
  40 2011-07-08T11:19:53  <pkumar> one is you can find the missing parts of file i.e. parts of files which are not executed when the test is run
  41 2011-07-08T11:20:20  <pkumar> you can get those missing parts using pytest-cov
  42 2011-07-08T11:21:02  <pkumar> read the link I provided yesterday and you'll know hoe to find the missing parts/line
  43 2011-07-08T11:21:08  <pkumar> how*
  44 2011-07-08T11:21:20  <hardy89> pkumar: yeah that i've read. its there.
  45 2011-07-08T11:21:23  <pkumar> then you writ test for them
  46 2011-07-08T11:21:28  <pkumar> write*
  47 2011-07-08T11:22:35  <hardy89> ok
  48 2011-07-08T11:23:48  <hardy89> pkumar: any other approach to this?
  49 2011-07-08T11:26:19  <pkumar> I found tis one a little convenient. other thing is you can read both test and file and see if there is something that is without tests and add them
  50 2011-07-08T11:27:14  <hardy89> pkumar: ok. and what % of coverage is considered to be good?
  51 2011-07-08T11:28:18  <pkumar> it again depends on file. you should try that almost everything executable in the file is tested
  52 2011-07-08T11:28:44  <pkumar> % decreases with more number of comment in it
  53 2011-07-08T11:29:39  <hardy89> pkumar: all right. thanks :)
  54 2011-07-08T11:29:44  <pkumar> np
  55 2011-07-08T11:29:59  <pkumar> brb
  56 2011-07-08T11:38:42  <ThomasWaldmann> hardy89: you have to write your diary daily (and every other student too)
  57 2011-07-08T11:38:57  <ThomasWaldmann> not once a week for the whole week, that is not acceptable
  58 2011-07-08T11:39:37  <hardy89> sorry ThomasWaldmann. i could not due to internet hiccups. will take care of that.
  59 2011-07-08T11:41:16  <ThomasWaldmann> ah.
  60 2011-07-08T11:47:55  *** hardy89 has quit IRC
  61 2011-07-08T11:51:40  *** hardy89 has joined #moin-dev
  62 2011-07-08T11:57:22  <Marchael> ThomasWaldmann: if I undertstand right, I can use RouterItem for accessing to Item. But whereI should put my code? In RouterBackend?
  63 2011-07-08T11:57:52  <Marchael> or may be IndexingBackendMixin
  64 2011-07-08T11:59:35  <ThomasWaldmann> what code?
  65 2011-07-08T12:00:02  <Marchael> code for convertion
  66 2011-07-08T12:00:19  <Marchael> I mean code which use code for conversion :)
  67 2011-07-08T12:00:20  <ThomasWaldmann> that's indexing related, obviously, so ...
  68 2011-07-08T12:00:36  <Marchael> IndexingBackendMixin?
  69 2011-07-08T12:00:51  <ThomasWaldmann> indexing.py
  70 2011-07-08T12:01:13  <ThomasWaldmann> and first get a clue what you want to do exactly, before putting code anywhere
  71 2011-07-08T12:02:15  <Marchael> first, I want access to some fields fo Item class, which accessable in RouterItem
  72 2011-07-08T12:02:42  <ThomasWaldmann> no
  73 2011-07-08T12:03:19  <ThomasWaldmann> just read and understand the code I gave you (see urls in EP chat)
  74 2011-07-08T12:03:30  <ThomasWaldmann> bbl
  75 2011-07-08T13:00:47  <pkumar> bbl
  76 2011-07-08T13:00:50  *** pkumar has quit IRC
  77 2011-07-08T13:15:41  <Marchael> ThomasWaldmann: I look at MoinMoin.items and I want to ask how can I pass Item object to indexing.py?
  78 2011-07-08T13:18:25  <ThomasWaldmann> hmm, maybe in this case you could use the create class method to create such a highlevel item there, and then use some of the methods of it to convert
  79 2011-07-08T13:20:10  <Marchael> ok, I created Item, but it hasn't content
  80 2011-07-08T13:26:13  <Marchael> bbl
  81 2011-07-08T13:27:57  *** sinha has joined #moin-dev
  82 2011-07-08T13:31:08  *** m4k3r has quit IRC
  83 2011-07-08T13:32:45  *** m4k3r has joined #moin-dev
  84 2011-07-08T13:53:20  <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> * 88d8b4663efc r303 default/setup.py: setup: require MathJax, missed in previous changeset
  85 2011-07-08T13:53:21  <CIA-114> Akash Sinha <akash2607@gmail.com> * 200c0e1774df r304 default/setup.py: branch merged with main repo
  86 2011-07-08T13:53:21  <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> * ab67dd35c5f2 r305 default/setup.py: setup.py: only Flask == 0.7.1 until we have fixed moin2 for newer releases
  87 2011-07-08T13:53:21  <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> * 6addf72bd94e r306 default/setup.py: setup.py: reverted to 88d8b4663efc
  88 2011-07-08T13:53:22  <CIA-114> Akash Sinha <akash2607@gmail.com> * e0c30f63e6c0 r307 default/setup.py: branch merged with main repo
  89 2011-07-08T13:53:22  <CIA-114> Akash Sinha <akash2607@gmail.com> * 55c1d404dd12 r308 default/MoinMoin/templates/global_index.html: code refactored ( due to API upgrades)
  90 2011-07-08T13:53:22  <CIA-114> Akash Sinha <akash2607@gmail.com> * 4307261bac75 r309 default/MoinMoin/ (3 files in 3 dirs): item index view modified
  91 2011-07-08T14:19:28  <sinha> dreimark: code for subitem flagging has been refactored here http://codereview.appspot.com/4631094/diff2/4001:3002/MoinMoin/items/__init__.py
  92 2011-07-08T14:21:16  <dreimark> re
  93 2011-07-08T14:32:38  <dreimark> sinha: reviewed
  94 2011-07-08T14:36:29  <sinha> dreimark: unit test after committing this or both of them together ?
  95 2011-07-08T14:37:50  <dreimark> sinha: both together. usually you make a unittest after the concept before coding the module or method
  96 2011-07-08T14:38:31  <dreimark> if you do it after the code written commit it with the code
  97 2011-07-08T14:38:31  <sinha> okay, so i am naming the module as `get_detailed_index`, is it ok ?
  98 2011-07-08T14:38:39  <dreimark> yes
  99 2011-07-08T14:38:56  <dreimark> http://hg.moinmo.in/moin/2.0/file/a9afdff3f42f/MoinMoin/items/_tests/test_Item.py
 100 2011-07-08T14:39:11  <dreimark> add the test there, and look how the others are made
 101 2011-07-08T14:39:43  <sinha> okay, fine
 102 2011-07-08T14:40:15  <dreimark> you can run your test by py.test -k test_get_detailed_index then
 103 2011-07-08T14:40:36  <dreimark> and all tests by py.test
 104 2011-07-08T14:41:05  <sinha> okay thanks, will show you when i am done
 105 2011-07-08T14:41:11  <dreimark> ok
 106 2011-07-08T14:47:38  <ThomasWaldmann> dreimark: did you read my stuff from last night?
 107 2011-07-08T14:48:42  <sinha> dreimark: i need to add one more item name there in tests to check this new module ? ( because there is no item with subitem except 'Foo' )
 108 2011-07-08T14:49:45  <sinha> or i can just create one item with name '', then it can be tested
 109 2011-07-08T14:55:15  *** raignarok has joined #moin-dev
 110 2011-07-08T15:24:05  <sinha> dreimark: http://codereview.appspot.com/4631094/ [ Patch Set 4]
 111 2011-07-08T15:33:40  *** brunomartin has left #moin-dev
 112 2011-07-08T16:20:18  <dreimark> ThomasWaldmann: yes and I will work on it after I am at home
 113 2011-07-08T16:20:44  <dreimark> I did a big migration step today from a lib and still get requests from my users
 114 2011-07-08T16:22:50  <dreimark> sinha: you can create any item you need just check that after your test it is removed.
 115 2011-07-08T16:25:59  <sinha> dreimark: i have uploaded the code here, http://codereview.appspot.com/4631094/ [Set 4], see this when you are free
 116 2011-07-08T16:26:53  <dreimark> topitem = Item.create('') I would name that root_item, but also if that Foo/ij/kl is created
 117 2011-07-08T16:27:15  <dreimark> you can test  for having subitem kl?
 118 2011-07-08T16:29:03  <sinha> yes for that i need to create item Foo/ij
 119 2011-07-08T16:30:25  <sinha> dreimark: is there any difference ? i mean from testing point of view, is usage of root item  ignored?
 120 2011-07-08T16:30:34  <dreimark> there should be one test also for something else than the /
 121 2011-07-08T16:31:37  *** hardy89 has quit IRC
 122 2011-07-08T16:31:40  <dreimark> per definition somewhere in item code everything below / is a subitem
 123 2011-07-08T16:34:15  <sinha> dreimark: and also to test that kl, i need to get Foo/ij in index , and for that i need to add one more entry in that name list, should i do that (then i may have to change the assert output for above two functions also)
 124 2011-07-08T16:35:47  <sinha> thats i reason i went with this topitem, such that i don't have to alter things much
 125 2011-07-08T16:37:49  <dreimark> sinha: http://hg.moinmo.in/moin/2.0/file/a9afdff3f42f/MoinMoin/items/_tests/test_Item.py#l86
 126 2011-07-08T16:38:01  <dreimark> that creates Foo/ij/kl
 127 2011-07-08T16:38:09  <sinha> yes it creates
 128 2011-07-08T16:38:19  <sinha> but its parent item will be Foo/ij, right ?
 129 2011-07-08T16:38:26  <dreimark> yes
 130 2011-07-08T16:38:36  <dreimark> then use this as base
 131 2011-07-08T16:39:10  <dreimark> you can check if Foo/ij has subitems
 132 2011-07-08T16:39:10  <sinha> but if i use this as base, the flat_index() which get returned will only have kl as item
 133 2011-07-08T16:39:44  <sinha> to check Foo/ij has subitem, first i need to get it as output of  flat_index(), which isnt happening
 134 2011-07-08T16:40:11  <sinha> because that flat_index() is passed as param for that get_detailed_function()
 135 2011-07-08T16:44:51  <dreimark> ok
 136 2011-07-08T16:45:00  <sinha> dreimark: so i add one entry there ?
 137 2011-07-08T16:45:27  <dreimark> yes, make sure that you don't break other tests functionality
 138 2011-07-08T16:45:37  <sinha> yeah ok
 139 2011-07-08T16:55:10  <sinha> dreimark: http://codereview.appspot.com/4631094 [ Set 5], can i commit this now ?
 140 2011-07-08T17:18:27  *** m4k3r has quit IRC
 141 2011-07-08T17:38:44  * dreimark looks
 142 2011-07-08T17:40:55  <dreimark> sinha: yes
 143 2011-07-08T17:41:05  *** hardy89 has joined #moin-dev
 144 2011-07-08T17:54:30  <Marchael> ThomasWaldmann: also, why you point me to Item? It's rather base for other classes in MoinMoin.items
 145 2011-07-08T17:56:19  <Marchael> may be I should select class using contenttype?
 146 2011-07-08T18:03:43  *** m4k3r has joined #moin-dev
 147 2011-07-08T18:14:38  <ThomasWaldmann> Marchael: use the create method of the base class and it will give you an appropriate instance for the content-type of the revision
 148 2011-07-08T18:15:33  <Marchael> ah, so I can just pass contentype to create()
 149 2011-07-08T18:16:55  <ThomasWaldmann> you give it name and revno
 150 2011-07-08T18:17:39  <Marchael> and backend item I guess
 151 2011-07-08T18:18:43  <ThomasWaldmann> if you already have an item instance, yes, you can provide it
 152 2011-07-08T18:30:19  *** m4k3r has quit IRC
 153 2011-07-08T18:33:29  *** mkerrin has quit IRC
 154 2011-07-08T18:46:26  <Marchael> btw, I can't pass item there because I haven't it. In  add_revision_whoosh() I have only item revision metadata
 155 2011-07-08T18:49:18  <Marchael> ThomasWaldmann: then I should use Item._write_stream() to add content?
 156 2011-07-08T18:51:53  <ThomasWaldmann> eh?
 157 2011-07-08T18:52:41  <Marchael> ignore that
 158 2011-07-08T18:53:26  <Marchael> I missed item = flaskg.storage.get_item(name)
 159 2011-07-08T18:54:16  <ThomasWaldmann> you just use that item to do the conversion, nothing else
 160 2011-07-08T18:59:39  <dreimark> ThomasWaldmann: i need a shower and some fresh air, afterwards I do the changes for my xstatic packages
 161 2011-07-08T19:00:05  <dreimark> and also package svg-edit-moin
 162 2011-07-08T19:00:09  <dreimark> bbl
 163 2011-07-08T19:02:29  *** hardy89 has quit IRC
 164 2011-07-08T19:21:43  <Marchael> ThomasWaldmann: please review http://codereview.appspot.com/4675066
 165 2011-07-08T19:21:57  <Marchael> I created Item object and now playing with it.
 166 2011-07-08T19:22:06  <Marchael> How can I access to content?
 167 2011-07-08T19:29:36  <ThomasWaldmann> you read the Item class :)
 168 2011-07-08T19:40:57  <Marchael> ah, I just want           to see this sneaky content
 169 2011-07-08T19:53:40  <Marchael> ThomasWaldmann: I can use Item.internal_representation() to build a DOM tree, but what I should do next?
 170 2011-07-08T19:54:09  <Marchael> use converter DOM -> plaintext?
 171 2011-07-08T19:55:27  *** greg_f has quit IRC
 172 2011-07-08T20:00:10  <ThomasWaldmann> Marchael: i don't think there is such a converter already, but try the moinwiki_out converter for now
 173 2011-07-08T20:03:04  <Marchael> ok
 174 2011-07-08T20:24:28  * ThomasWaldmann drives home
 175 2011-07-08T20:26:40  *** brunomartin has joined #moin-dev
 176 2011-07-08T20:29:42  <brunomartin> Hi!
 177 2011-07-08T20:34:23  <brunomartin> I'm making a theme for moin 2, with some custom tamplates, that are in MoinMoin/themes/mytheme/templates. t = themes.get_current_theme(); t.templates_path give me the right path, but it doesn't load my templates unless I put template_dirs = ['MoinMoin/themes/mytheme/templates', ] in wikiconfig...
 178 2011-07-08T20:44:58  <dreimark> ThomasWaldmann: your cdn in jquery is may be now wrong, because of the version string
 179 2011-07-08T20:54:05  <dreimark> brunomartin: I think this is the current state, because we have no plugin managmeanagment currently
 180 2011-07-08T20:54:52  <Marchael> ThomasWaldmann: I converted DOM to text/x.moin.wiki but I still don't see content
 181 2011-07-08T20:55:57  *** m4k3r has joined #moin-dev
 182 2011-07-08T20:58:08  <brunomartin> dreimark: yeah... thats what I thought... It was using changeset from some weeks ago, and it was working, but stoped after I made an update...  but it's ok... works fine with template_dirs set in wikiconfig....
 183 2011-07-08T20:58:58  <dreimark> brunomartin: if you have a good bandwidth, wait for my next commit and reinstall env then.
 184 2011-07-08T20:59:12  <dreimark> because we switched to flask-0.2
 185 2011-07-08T20:59:16  <dreimark> fsck
 186 2011-07-08T20:59:36  <dreimark> flask-0.7.2 and there was some refactoring nec.
 187 2011-07-08T21:02:41  <dreimark> and XStatic packages
 188 2011-07-08T21:04:04  * dreimark works on svg-edit package
 189 2011-07-08T21:04:35  <brunomartin> dreimark: I noticed... I'm using flask 0.7.2 here too and already refactored my app... ;-) Is the jquery.fileupload working? I really need use it, and I think I can help it work...
 190 2011-07-08T21:05:34  <CIA-114> Akash Sinha <akash2607@gmail.com> * 19b257c0e102 r310 default/MoinMoin/ (3 files in 3 dirs): code to get the subitem index flag has been refactored and moved under items/__init__.py and also unitest is added for the same.
 191 2011-07-08T21:05:35  <CIA-114> Akash Sinha <akash2607@gmail.com> * 3a3aea61aa1b r311 default/MoinMoin/apps/frontend/views.py: code for getting subitem flag in global_index function, replaced by the get_detailed_index() module
 192 2011-07-08T21:06:11  <Marchael> ThomasWaldmann: patchset 2 http://codereview.appspot.com/4675066/
 193 2011-07-08T21:08:50  <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> default * 281:3f4ebd1f2fd0 2.0/setup.py: XStatic: pin XStatic==0.0.1 and compatible ressource packages 2nd part
 194 2011-07-08T21:09:30  <dreimark> brunomartin: works for me, it is index2, we need a much better place for it
 195 2011-07-08T21:09:42  <brunomartin> dreimark: We are doing a prototype here, with moin2, for Learning purposes ... and almost 300 users are going to test it! :-D  the file upload is the last feature I need in the prototype ...
 196 2011-07-08T21:10:18  <dreimark> look at index2 it works in a fresh env,
 197 2011-07-08T21:10:52  <dreimark> currently my gsoc student sinha refactors and extend all index stuff.
 198 2011-07-08T21:11:05  <brunomartin> dreimark: sorry, it works here to!!!
 199 2011-07-08T21:11:54  <dreimark> see here for an imressive new look and feel http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-07-07
 200 2011-07-08T21:11:55  <brunomartin> dreimark: there way some mine piece of code breaking it....
 201 2011-07-08T21:12:39  <dreimark> or this for gobal index http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-07-05
 202 2011-07-08T21:13:06  <dreimark> next will be a filter method on content type
 203 2011-07-08T21:13:37  <sinha> dreimark: moving towards contenttype filter, where should i implement this filter in flat_index() function (similar to that startswith parameter) ?
 204 2011-07-08T21:15:12  <dreimark> sinha: quite similiar, it needs to work for gi too and it must be a list of types.
 205 2011-07-08T21:15:25  <dreimark> for now i think major type is enough
 206 2011-07-08T21:15:40  <sinha> and i need to extract the major part from contenttype, and i will create a small function for it, so where to put that function ? in themes/  ?
 207 2011-07-08T21:15:57  <sinha> without function i can do splitting and selection in the code itself, but it will look ugly
 208 2011-07-08T21:16:19  <dreimark> may be this extract is already in util, we have had this in 1.9
 209 2011-07-08T21:16:32  <sinha> let me check
 210 2011-07-08T21:17:52  <dreimark> http://hg.moinmo.in/moin/1.9/file/62202e5435e2/MoinMoin/wikiutil.py#l928 was it in 1.9
 211 2011-07-08T21:18:09  <dreimark> i guess we have that in 2.0
 212 2011-07-08T21:19:12  <dreimark> sinha: http://hg.moinmo.in/moin/2.0/file/3f4ebd1f2fd0/MoinMoin/util/mimetype.py
 213 2011-07-08T21:19:18  <sinha> wel i dont need this much detailed all i have to do is major_type=contenttype.split('/', 1)[0]
 214 2011-07-08T21:20:29  <sinha> to use this mimetype i need to create this MimeType object for each item, will it be good ? i mean as i showed you above i just need to do that
 215 2011-07-08T21:20:43  <dreimark> then this needs no extra function
 216 2011-07-08T21:20:55  <dreimark> sinha: you have this in meta
 217 2011-07-08T21:21:33  <dreimark> you don't need if you have the equivalent info already, which you have in index
 218 2011-07-08T21:21:47  <sinha> yes i have contenttype here available
 219 2011-07-08T21:22:28  <sinha> but just a question here, how will i pass the whole list of params from frontend ? POST method ?
 220 2011-07-08T21:23:09  <dreimark> please use POST, I don't think a user will enter those by get
 221 2011-07-08T21:23:27  <sinha> through GET, it could be like ?shoeType=text,image,video
 222 2011-07-08T21:23:33  <sinha> s/shoe/show
 223 2011-07-08T21:24:24  <sinha> but to generate this kind of GET query i will use javascript
 224 2011-07-08T21:24:48  <sinha> so i go with POST now
 225 2011-07-08T21:24:56  <dreimark> I think I added a note on ep, that we need checkboxes where the user
 226 2011-07-08T21:25:03  <dreimark> disables what we not want to see
 227 2011-07-08T21:25:23  <dreimark> if you do it the other way the problem can be that the user never sees something
 228 2011-07-08T21:25:34  <dreimark> because of browser autocompletion
 229 2011-07-08T21:25:46  <dreimark> therefore POST is also better
 230 2011-07-08T21:31:10  <dreimark> brunomartin: if you have some ideas how to improve that jquery uploader, we have to guess contentype currently
 231 2011-07-08T21:31:43  <dreimark> and also meta is not directly connected, just the one we can calculate
 232 2011-07-08T21:32:10  <ThomasWaldmann> re
 233 2011-07-08T21:33:30  <Marchael> ThomasWaldmann: i just try to print converted DOM tree, but see only item fields
 234 2011-07-08T21:33:43  <Marchael> you can look at codereview
 235 2011-07-08T21:36:36  <dreimark> url?
 236 2011-07-08T21:36:58  <ThomasWaldmann> Marchael: see there
 237 2011-07-08T21:37:19  <Marchael> dreimark: http://codereview.appspot.com/4675066
 238 2011-07-08T21:37:26  * Marchael looks
 239 2011-07-08T21:38:26  <ThomasWaldmann> Marchael: http://hg.moinmo.in/moin/2.0/file/3f4ebd1f2fd0/MoinMoin/apps/frontend/views.py#l148
 240 2011-07-08T21:39:04  <Marchael> ok
 241 2011-07-08T21:39:55  *** grzywacz has joined #moin-dev
 242 2011-07-08T21:39:56  *** grzywacz has joined #moin-dev
 243 2011-07-08T21:48:42  <Marchael> ThomasWaldmann: converter doesn't working without calling Item.__init__()
 244 2011-07-08T21:49:37  <ThomasWaldmann> we use it all the time and I showed you how.
 245 2011-07-08T21:53:15  <Marchael> ThomasWaldmann: I left one comment with traceback
 246 2011-07-08T21:54:45  *** m4k3r has quit IRC
 247 2011-07-08T21:55:11  *** m4k3r has joined #moin-dev
 248 2011-07-08T21:56:33  *** RogerHaase has joined #moin-dev
 249 2011-07-08T21:59:51  <ThomasWaldmann> Marchael: look at Item code, e.g. _render_data to see how to use this stuff
 250 2011-07-08T22:01:18  *** m4k3r has quit IRC
 251 2011-07-08T22:02:22  *** m4k3r has joined #moin-dev
 252 2011-07-08T22:05:38  <Marchael> ThomasWaldmann: why?
 253 2011-07-08T22:06:07  <Marchael> for output I use print
 254 2011-07-08T22:06:58  <Marchael> and Item._render_data() returns list of fields
 255 2011-07-08T22:07:26  <Marchael> nope, just string with fields
 256 2011-07-08T22:07:29  <dreimark> Marchael: join ?
 257 2011-07-08T22:10:51  <Marchael> oh, there is
 258 2011-07-08T22:16:48  *** grzywacz has quit IRC
 259 2011-07-08T22:17:58  *** pkumar has joined #moin-dev
 260 2011-07-08T22:19:14  <Marchael> ThomasWaldmann: _render_data doesn't work for item after conversion
 261 2011-07-08T22:22:07  <ThomasWaldmann> Marchael: can you just look into the WORKING code of Item class?
 262 2011-07-08T22:29:02  <brunomartin> dreimark: I will try the jquery uploader, follow  the related commits, and soon see how it works on prototype, and let you know about ideas e problems that I get...
 263 2011-07-08T22:36:24  <dreimark> brunomartin: thx
 264 2011-07-08T22:41:09  <CIA-114> pkumar <contactprashantat@gmail.com> * 134e57c7ea10 r363 pytest2/MoinMoin/_tests/test_user.py: added testfor quicklinks related functions of user.User in _test/test_user
 265 2011-07-08T22:41:09  <CIA-114> pkumar <contactprashantat@gmail.com> * e12ed6de9e41 r364 pytest2/MoinMoin/_tests/test_user.py: test for Trail related functions in user.User added to _test/test_user
 266 2011-07-08T22:41:09  <CIA-114> pkumar <contactprashantat@gmail.com> * 70bf6d6b2191 r365 pytest2/MoinMoin/_tests/test_user.py: added display messages on failure in _tests/test_user
 267 2011-07-08T22:41:10  <CIA-114> pkumar <contactprashantat@gmail.com> * 57efdd8f955d r366 pytest2/MoinMoin/_tests/test_user.py: added tests for User.generate_recovery_token, User.apply_recovery_token, User.signature of user in _tests/test_user
 268 2011-07-08T22:46:36  <brunomartin> dreimark: I thank you...  ;-)
 269 2011-07-08T23:04:43  *** pkumar has quit IRC
 270 2011-07-08T23:31:47  *** esyr_ has joined #moin-dev
 271 2011-07-08T23:33:49  *** esyr_ has quit IRC
 272 2011-07-08T23:44:13  *** m4k3r has quit IRC
 273 2011-07-08T23:46:05  *** esyr_ has joined #moin-dev
 274 

MoinMoin: MoinMoinChat/Logs/moin-dev/2011-07-08 (last edited 2011-07-07 22:45:03 by IrcLogImporter)