1 2011-07-11T00:26:09 *** raignarok
2 2011-07-11T00:29:10 *** sinha
3 2011-07-11T01:12:24 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 290:6ecab9748faa 2.0/MoinMoin/translations/MoinMoin.pot: update MoinMoin.pot
4 2011-07-11T01:12:25 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 291:46e37e4197d4 2.0/MoinMoin/translations/de/LC_MESSAGES/messages.po: updated german translation
5 2011-07-11T01:34:46 * ThomasWaldmann compiles python 2.6
6 2011-07-11T01:34:57 <ThomasWaldmann> (.0)
7 2011-07-11T05:58:13 *** Marchael
8 2011-07-11T06:45:21 <Marchael> moin
9 2011-07-11T07:43:26 <dreimark> moin
10 2011-07-11T07:43:42 <dreimark> Marchael: please read backlog from yesterday
11 2011-07-11T07:44:29 <Marchael> ok
12 2011-07-11T07:46:08 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4675066 Patchset 12
13 2011-07-11T07:46:30 <dreimark> I suggest you solve first what you find in the backlog
14 2011-07-11T07:48:24 <Marchael> dreimark: ok, I'll merge my repo after next commit
15 2011-07-11T07:50:29 <dreimark> why not now, you can cherrypick what you have
16 2011-07-11T07:50:45 <dreimark> and you are waiting for a review
17 2011-07-11T07:51:58 <dreimark> hg diff > whatihavenow.patch
18 2011-07-11T07:53:12 <dreimark> bbl
19 2011-07-11T09:11:09 *** hardy89
20 2011-07-11T09:16:26 *** raignarok
21 2011-07-11T09:55:33 <hardy89> hi waldi
22 2011-07-11T09:56:07 <hardy89> waldi: for mail module, the pytest-cov gives the following results
23 2011-07-11T09:56:14 <hardy89> http://paste.pocoo.org/show/435948/
24 2011-07-11T09:56:38 <hardy89> and line 74-179 is this http://paste.pocoo.org/show/435946/
25 2011-07-11T09:57:31 <hardy89> but i'm finding it difficult to understand why does covers % is less
26 2011-07-11T09:59:12 <waldi> lines vs. statements?
27 2011-07-11T10:02:42 <hardy89> waldi: please explain.
28 2011-07-11T10:03:14 *** mkerrin
29 2011-07-11T10:03:40 <hardy89> you mean to say thats cos of too many statements in comparison to lines of code?
30 2011-07-11T10:08:06 *** raignarok
31 2011-07-11T10:10:10 *** raignarok
32 2011-07-11T10:14:01 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 0adb935309cb r313 moin-2.0/: fixing multiple heads
33 2011-07-11T10:14:01 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * c41fdeb81880 r314 moin-2.0/setup.py: fixing before merge
34 2011-07-11T10:14:02 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 748054b11929 r315 moin-2.0/ (31 files in 9 dirs): Fixing multiple heads
35 2011-07-11T10:14:03 <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> * 0513cfd0aaeb r316 moin-2.0/ (wikiconfig.py quickinstall): use XStatic-MathJax package, require it via setup.py, remove it from quickinstall scripts
36 2011-07-11T10:14:03 <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> * 88d8b4663efc r317 moin-2.0/setup.py: setup: require MathJax, missed in previous changeset
37 2011-07-11T10:14:03 <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> * ab67dd35c5f2 r318 moin-2.0/setup.py: setup.py: only Flask == 0.7.1 until we have fixed moin2 for newer releases
38 2011-07-11T10:14:04 <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> * 6addf72bd94e r319 moin-2.0/setup.py: setup.py: reverted to 88d8b4663efc
39 2011-07-11T10:14:04 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * a9afdff3f42f r320 moin-2.0/ (quickinstall.bat setup.py quickinstall): XStatic: pin XStatic==0.0.1 and compatible ressource packages
40 2011-07-11T10:14:04 <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> * 3f4ebd1f2fd0 r321 moin-2.0/setup.py: XStatic: pin XStatic==0.0.1 and compatible ressource packages 2nd part
41 2011-07-11T10:14:04 <CIA-114> Reimar Bauer <rb.proj AT googlemail DOT com> * d28a3434b40c r322 moin-2.0/ (4 files in 2 dirs): use XStatic-svg-edit-moin==2011.07.07.1, require it via setup.py, remove it from quickinstall scripts
42 2011-07-11T10:14:36 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * da04ea3f5817 r323 moin-2.0/quickinstall: remove download of svgedit from quickinstall, it is handled via XStatic package now
43 2011-07-11T10:14:36 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 5afd19296f66 r324 moin-2.0/ (quickinstall.bat quickinstall): removed unneeded stuff from quickinstall*
44 2011-07-11T10:14:36 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 865c3780d091 r325 moin-2.0/ (wikiconfig.py quickinstall.bat setup.py quickinstall): upgrade to XStatic 0.0.2 and packages made for it
45 2011-07-11T10:14:36 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * f0288e2a7d09 r326 moin-2.0/docs/admin/ (install.rst requirements.rst): update docs: now every dependency is installed via setup.py, no wget any more
46 2011-07-11T10:14:36 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * a4461b58fba3 r327 moin-2.0/MoinMoin/app.py: app: cosmetic changes
47 2011-07-11T10:14:37 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * e6f585ac9766 r328 moin-2.0/MoinMoin/ (conftest.py app.py): use teardown_request (teardown_wiki) instead of after_request (after_wiki), because it is called when an exception happened
48 2011-07-11T10:15:36 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 1c377ccaf6a1 r329 moin-2.0/docs/admin/serve.rst: docs: for deployment just point to Flask deployment docs
49 2011-07-11T10:15:36 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 6ecab9748faa r330 moin-2.0/MoinMoin/translations/MoinMoin.pot: update MoinMoin.pot
50 2011-07-11T10:15:36 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 46e37e4197d4 r331 moin-2.0/MoinMoin/translations/de/LC_MESSAGES/messages.po: updated german translation
51 2011-07-11T10:15:36 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 6111e4d47e04 r332 moin-2.0/ (12 files in 6 dirs): merged
52 2011-07-11T10:15:36 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 29cc4f25eec8 r333 moin-2.0/ (setup.py MoinMoin/converter/moinwiki_out.py): Ignoring href splitting for IRI in moinwiki_out
53 2011-07-11T10:15:37 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * c552332cb53e r334 moin-2.0/MoinMoin/ (3 files in 3 dirs): Content indexing for runtime working and scripts, fix bug in move_index()
54 2011-07-11T10:17:05 <Marchael> I fixed my repo and commited last changes
55 2011-07-11T10:34:47 <Marchael> bbl
56 2011-07-11T10:52:01 <hardy89> hi ThomasWaldmann
57 2011-07-11T10:54:37 <hardy89> ThomasWaldmann: Is the issue when an item is considered created and published documented anywhere?
58 2011-07-11T11:00:40 <hardy89> waldi: also, please guide me on how to deal with the failures in test_serialization.py
59 2011-07-11T11:09:04 *** raignarok
60 2011-07-11T11:10:04 *** greg_f
61 2011-07-11T11:11:19 <ThomasWaldmann> hardy89: did you read MoinMoin/storage/__init__.py?
62 2011-07-11T11:13:26 <hardy89> ThomasWaldmann: reading again :)
63 2011-07-11T11:13:29 *** raignarok
64 2011-07-11T11:16:38 <Marchael> re
65 2011-07-11T11:18:20 <Marchael> ThomasWaldmann: could you review patchset 12?
66 2011-07-11T11:27:19 <ThomasWaldmann> Marchael: review done
67 2011-07-11T11:28:26 <ThomasWaldmann> Marchael: btw, moin does not even start for me.
68 2011-07-11T11:29:09 <Marchael> ThomasWaldmann: could you give me traceback?
69 2011-07-11T11:29:19 <ThomasWaldmann> from MoinMoin.script.maint.update_indexes import UpdateIndexes
70 2011-07-11T11:29:19 <ThomasWaldmann> ImportError: No module named update_indexes
71 2011-07-11T11:29:35 <ThomasWaldmann> you maybe should run moin more often
72 2011-07-11T11:30:49 <Marchael> I forget remove that import line, sorry
73 2011-07-11T11:31:22 *** raignarok
74 2011-07-11T11:35:12 *** moinBot`
75 2011-07-11T11:38:32 *** moinBot`
76 2011-07-11T11:42:07 *** brunomartin
77 2011-07-11T11:42:08 *** [bsx]
78 2011-07-11T11:42:08 *** waldi
79 2011-07-11T11:42:08 *** moinBot
80 2011-07-11T11:46:32 *** [bsx]
81 2011-07-11T11:48:47 *** waldi
82 2011-07-11T11:48:48 *** waldi
83 2011-07-11T11:56:30 <ThomasWaldmann> Marchael: can you commit just that fix, please?
84 2011-07-11T11:56:48 <Marchael> sec
85 2011-07-11T11:57:35 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * daedbbcaa1cb r335 moin-2.0/MoinMoin/script/maint/index.py: Removed break import line
86 2011-07-11T12:08:47 <ThomasWaldmann> Marchael: http://paste.pocoo.org/show/436005/
87 2011-07-11T12:09:39 <ThomasWaldmann> maybe you just test your stuff yourself and tell me if it is fixed so it doesn't crash immediately any more
88 2011-07-11T12:09:59 <Marchael> ok
89 2011-07-11T12:14:42 *** raignarok
90 2011-07-11T12:46:29 *** raignarok
91 2011-07-11T12:52:25 *** raignarok
92 2011-07-11T12:55:34 *** sinha
93 2011-07-11T12:59:33 *** sinha
94 2011-07-11T13:03:09 *** greg_f
95 2011-07-11T13:04:18 *** greg_f
96 2011-07-11T13:39:06 <ThomasWaldmann> Marchael: the MoinMoin.items code is not really made to be called outside a request
97 2011-07-11T13:39:27 *** hardy89
98 2011-07-11T13:43:01 *** brunomartin
99 2011-07-11T13:55:52 *** hardy89
100 2011-07-11T13:56:35 *** pkumar
101 2011-07-11T14:04:08 *** hardy89
102 2011-07-11T14:04:44 <hardy89> ThomasWaldmann: i reddit, but i still have a doubt :|
103 2011-07-11T14:06:20 <hardy89> Ah, i got it. Sorry. Thanks :)
104 2011-07-11T14:12:23 <dreimark> hardy89: have you merged?
105 2011-07-11T14:13:23 <hardy89> dreimark: i made a new repo cos the issue of multiple heads was causing a problem while pulling changesets
106 2011-07-11T14:13:37 <dreimark> hardy89: url please
107 2011-07-11T14:14:24 <hardy89> dreimark: https://bitbucket.org/89hardy/moin_pytest
108 2011-07-11T14:14:37 <hardy89> dreimark: i even changed the link in my wiki page
109 2011-07-11T14:14:55 <dreimark> good
110 2011-07-11T14:15:13 <hardy89> dreimark: thanks :)
111 2011-07-11T14:15:54 *** Marchael
112 2011-07-11T14:16:50 *** hardy89
113 2011-07-11T14:44:50 *** hardy89
114 2011-07-11T14:56:12 <ThomasWaldmann> xorAxAx: waldi: dreimark: please try if you student's code works. works == works with python 2.6(.0 if possible)
115 2011-07-11T14:58:03 <xorAxAx> ok
116 2011-07-11T14:58:29 <xorAxAx> pkumar: did you read my last message to you in this channel?
117 2011-07-11T14:58:53 <ThomasWaldmann> http://paste.pocoo.org/show/436063/ this is a setup.py for python 2.6(.0) that at least works on ubuntu 11.04 (the original one fails and doesn't find zlib/sqlite3 lib)
118 2011-07-11T14:59:59 <ThomasWaldmann> ./configure ; make ; make altinstall -> you have a /usr/local/bin/python2.6 (.0) which can be used for virtualenv -p ...
119 2011-07-11T15:00:54 <pkumar> xorAxAx : I'm sorry if I'm missing something but I didn't notice any message. Was i about going through the chat log, I read it today.
120 2011-07-11T15:01:17 <ThomasWaldmann> (for compiling, you also need some headers: for zlib*-dev sqlite3*-dev etc.
121 2011-07-11T15:01:21 <ThomasWaldmann> )
122 2011-07-11T15:07:33 <pkumar> xorAxAx : what message are you referring to?
123 2011-07-11T15:08:00 <xorAxAx> pkumar: the one containing your name
124 2011-07-11T15:08:04 <xorAxAx> please ALWAYS read the logs
125 2011-07-11T15:23:16 <pkumar> xorAxAx : I had read today's log, but some parts were in yesterday's log too. just read it.
126 2011-07-11T15:24:17 <pkumar> xorAxAx : also in my system I can see just one head and in bb too. where am I mistaking?
127 2011-07-11T15:25:10 <xorAxAx> dreimark: where did you see 2 heads exactly?
128 2011-07-11T15:25:58 * xorAxAx checks
129 2011-07-11T15:25:59 <pkumar> hg heads | grep change gives me just 1 head
130 2011-07-11T15:26:34 <xorAxAx> pkumar: then clone your repo from bb again
131 2011-07-11T15:26:40 <xorAxAx> and realise that there are 2 heads
132 2011-07-11T15:26:46 <xorAxAx> please close one head ...
133 2011-07-11T15:28:59 <xorAxAx> you must have used force without thinking at some time
134 2011-07-11T15:31:26 <pkumar> xorAxAx : no, I didn't use force yet
135 2011-07-11T15:31:36 <xorAxAx> sure you did
136 2011-07-11T15:31:47 <xorAxAx> hg will not create new remote branches without force
137 2011-07-11T15:32:22 <xorAxAx> ah, but its probably because of your second branch
138 2011-07-11T15:32:26 <xorAxAx> that you get a new head
139 2011-07-11T15:32:45 <xorAxAx> makes sense to keep it, pkumar
140 2011-07-11T15:33:38 <pkumar> xorAxAx : yeah I have two branches, default and pytest2
141 2011-07-11T15:33:50 <xorAxAx> yeah, then ignore us on this matter :)
142 2011-07-11T15:34:15 <pkumar> ok :)
143 2011-07-11T15:39:33 <dreimark> ah, ok, me forget about that too
144 2011-07-11T15:40:45 <dreimark> pkumar: can you explain why you see only 1 head? and me fetching a fresh clone then 2?
145 2011-07-11T15:41:33 <pkumar> dreimark : are you fetching from https://bitbucket.org/pkumar/pytest_moin?
146 2011-07-11T15:44:14 <dreimark> yes
147 2011-07-11T15:45:11 <dreimark> pkumar: http://paste.pocoo.org/show/436087/
148 2011-07-11T15:50:47 <pkumar> dreimark : I just cloned the repo and I got this : http://paste.pocoo.org/show/436090/
149 2011-07-11T15:51:58 <dreimark> I clone it again
150 2011-07-11T15:52:34 <pkumar> ok
151 2011-07-11T15:52:46 <dreimark> pkumar: have you seen my comment on one of your diary pages?
152 2011-07-11T15:53:12 <dreimark> I have the same result
153 2011-07-11T15:53:49 <dreimark> as in my last pastebin, two heads
154 2011-07-11T15:53:59 <pkumar> dreimark : which date?
155 2011-07-11T15:55:18 <pkumar> dreimark : lemme check
156 2011-07-11T15:55:31 <pkumar> ok, got it
157 2011-07-11T15:56:32 <pkumar> dreimark : I'll verify it by today
158 2011-07-11T15:56:41 <pkumar> hardy89 : hey you there?
159 2011-07-11T16:03:47 <dreimark> pkumar: you can re subscribe all diary pages
160 2011-07-11T16:06:40 <pkumar> dreimark : ok, I'll go through all diary pages once more.
161 2011-07-11T16:07:24 <dreimark> pkumar: not needed from my site, i look for the one I added my text
162 2011-07-11T16:07:43 <dreimark> it was something about that in setup was no change for py.test 2
163 2011-07-11T16:09:00 <dreimark> pkumar: http://moinmo.in/pkumar_diary/2011-07-08
164 2011-07-11T16:09:48 <dreimark> 'py==1.3.4', # py.test 1.3.4 is needed by unit tests
165 2011-07-11T16:14:34 <pkumar> dreimark : I have updated that to pytest. after updating pytest2 branch, you get the changes made.
166 2011-07-11T16:15:16 <pkumar> dreimark : Also, I'll check if any other requirements are there.
167 2011-07-11T16:15:24 <dreimark> ok, thanks
168 2011-07-11T16:16:16 <pkumar> dreimark : and about the repo, I'm not sure about it.
169 2011-07-11T16:19:26 <dreimark> pkumar: the comment is wrong, now it is 'pytest', # py.test 1.3.4 is needed by unit tests
170 2011-07-11T16:20:33 <pkumar> dreimark : oh, I missed it. I'll update it, thanks
171 2011-07-11T16:40:53 <pkumar> bbl
172 2011-07-11T16:40:57 *** pkumar
173 2011-07-11T16:51:41 *** hardy89
174 2011-07-11T16:55:10 *** sinha
175 2011-07-11T17:11:21 *** Marchael
176 2011-07-11T17:11:43 <Marchael> moin
177 2011-07-11T17:12:53 *** RogerHaase
178 2011-07-11T17:12:56 <Marchael> ThomasWaldmann: I installed moin from my repo again and have same issue http://paste.pocoo.org/show/436005/
179 2011-07-11T17:17:07 <Marchael> Althought without save/load xml that stuff working
180 2011-07-11T17:19:58 <Marchael> So I think what during save/load xml moin tries add documents to backend and index, but flaskg doesn' initialized at this time
181 2011-07-11T17:20:44 <Marchael> I could not recognize that problem because I switch off save\load xml
182 2011-07-11T17:25:48 <ThomasWaldmann> Marchael: exactly :)
183 2011-07-11T17:26:20 <Marchael> but how can I solve it? test_request_context()?
184 2011-07-11T17:26:25 <ThomasWaldmann> Marchael: do you still have to patch whoosh or are the needed fixes included in the download release version?
185 2011-07-11T17:26:39 <ThomasWaldmann> i sent you a changeset that fixes it for now
186 2011-07-11T17:26:51 <Marchael> yes, Multi index writer working
187 2011-07-11T17:27:12 <Marchael> I can add this in any time
188 2011-07-11T17:27:14 <ThomasWaldmann> but it crashes on startup due to some typo problem in whoosh
189 2011-07-11T17:27:30 <ThomasWaldmann> type*
190 2011-07-11T17:28:26 <Marchael> i tested multi writer and it's working normal
191 2011-07-11T17:28:37 <Marchael> about 3 weeks ago :)
192 2011-07-11T17:28:50 <ThomasWaldmann> it crashes because you give a list and it excepts unicode for indexing
193 2011-07-11T17:29:09 <ThomasWaldmann> just try it "as is" in a fresh repo without config, it'll crash
194 2011-07-11T17:29:09 <Marchael> hm, iirc Matt applied this fix
195 2011-07-11T17:29:14 <Marchael> in 1.8.4
196 2011-07-11T17:30:27 <Marchael> ok, but I'm need to solve problem with save\load xml first, I guess
197 2011-07-11T17:35:38 <Marchael> ThomasWaldmann: may be flaskg should be initialized in create_app_ext()?
198 2011-07-11T17:36:25 <Marchael> that could also solve problem with timers
199 2011-07-11T17:37:47 <ThomasWaldmann> Marchael: what problem with flaskg do you have after applying my changeset?
200 2011-07-11T17:38:24 <Marchael> what changeset?
201 2011-07-11T17:38:26 <ThomasWaldmann> (and you don't call create_app* from functions called from create_app*)
202 2011-07-11T17:38:31 <ThomasWaldmann> see your email inbox
203 2011-07-11T17:40:53 <Marchael> sorry, gmail moves your mail to spam :)
204 2011-07-11T17:41:00 <Marchael> *moved
205 2011-07-11T17:41:04 <ThomasWaldmann> gna :|
206 2011-07-11T17:41:24 <ThomasWaldmann> Marchael: please forward the "spam" email to me
207 2011-07-11T17:42:37 <Marchael> sended
208 2011-07-11T17:44:33 <ThomasWaldmann> hmm, that doesn't have the original headers any more. can you send me the headers of the mail you got as spam?
209 2011-07-11T17:44:46 <Marchael> sec
210 2011-07-11T17:47:14 <Marchael> done
211 2011-07-11T17:52:09 * ThomasWaldmann did not get the mail yet
212 2011-07-11T17:52:29 <ThomasWaldmann> ah, now
213 2011-07-11T17:54:13 <ThomasWaldmann> hmm, no indication of why that was considered as spam. it even tells that spf was ok
214 2011-07-11T17:54:56 <Marchael> hm, may thunderbird consider what that may be spam
215 2011-07-11T17:56:39 * Marchael applied patch
216 2011-07-11T17:57:32 <ThomasWaldmann> maybe you should whitelist your mentor :P
217 2011-07-11T17:57:56 <Marchael> am, I don't apply any special filter to thunderbird :)
218 2011-07-11T17:59:11 <Marchael> ok, now whoosh
219 2011-07-11T18:00:16 <ThomasWaldmann> btw, in case we need to patch whoosh (again), we could do so in quickinstall (and require whoosh==1.8.4 in setup.py, not >= )
220 2011-07-11T18:01:19 * ThomasWaldmann formats backup hdds
221 2011-07-11T18:01:41 <Marchael> ok, I'll create patch and add it to quickinstall
222 2011-07-11T18:11:20 <Marchael> ThomasWaldmann: src/whoosh/filedb/multiproc.py ?
223 2011-07-11T18:12:04 <Marchael> I thought what whoosh stored in env/lib/python2.6/site-packages/whoosh
224 2011-07-11T18:13:21 <Marchael> http://paste.pocoo.org/show/436191/
225 2011-07-11T18:14:25 <ThomasWaldmann> the env directory is in that shell variable, don't hardcode "env"
226 2011-07-11T18:15:49 <Marchael> but I haven't src/ directory
227 2011-07-11T18:17:01 <ThomasWaldmann> env/lib/python2.x/site-packages/whoosh/...
228 2011-07-11T18:22:00 <dreimark> may be we should have the py version number in the env var
229 2011-07-11T18:22:32 <Marchael> yes, without that I can't apply patches
230 2011-07-11T18:24:04 <Marchael> or I should be very lucky to guess what python use wiki admin
231 2011-07-11T18:27:46 <ThomasWaldmann> hmm
232 2011-07-11T18:30:49 <ThomasWaldmann> Marchael: if it is too complicated, just add a whoosh184-fix.patch to the toplevel dir
233 2011-07-11T18:31:13 <ThomasWaldmann> maybe have a look first how matt fixed the issues (he used a different type check)
234 2011-07-11T18:34:42 <Marchael> where i can see this?
235 2011-07-11T18:37:47 <dreimark> ThomasWaldmann: can you show a diff of you py2.6 changes, on 10.10 it is different
236 2011-07-11T18:40:39 <ThomasWaldmann> you have the full modified setup.py, you can diff it yourself :)
237 2011-07-11T18:41:32 <ThomasWaldmann> (it had to do with the lib pathes and with some bug that got fixed in 2.6.1)
238 2011-07-11T18:42:27 <dreimark> right, me restores it
239 2011-07-11T18:44:51 <Marchael> ThomasWaldmann: so how I should apply this patch? use unix "patch"?
240 2011-07-11T18:45:25 <ThomasWaldmann> yes.
241 2011-07-11T18:45:51 * ThomasWaldmann hopes that there will be a whoosh 1.8.5 soon fixing these issues.
242 2011-07-11T18:46:05 <ThomasWaldmann> btw, some guy ported whoosh to python3.
243 2011-07-11T18:56:25 *** mkerrin
244 2011-07-11T19:08:05 <Marchael> ThomasWaldmann: patchset 1 http://codereview.appspot.com/4681050/patch/1/2
245 2011-07-11T19:17:41 <Marchael> ThomasWaldmann: btw, content indexing for index script working normal
246 2011-07-11T19:18:02 <Marchael> with test_request_context() of course
247 2011-07-11T19:20:30 <Marchael> ThomasWaldmann: also, for avoiding start up problems with load/save xml may be we could check what flaskg is initialized and call test_request_context() if not.
248 2011-07-11T19:29:58 <ThomasWaldmann> i guessed you knew meanwhile what a endless recursion is
249 2011-07-11T19:31:17 <Marchael> you think what test_request_context() will call this?
250 2011-07-11T19:32:00 <ThomasWaldmann> before create_app is finished, you don't even have an app.
251 2011-07-11T19:35:00 <Marchael> ThomasWaldmann: but how can I avoid this? rewrite item class?
252 2011-07-11T19:35:03 <Marchael> *Item
253 2011-07-11T19:38:36 <ThomasWaldmann> did you apply my changeset?
254 2011-07-11T19:38:44 <Marchael> yes
255 2011-07-11T19:38:54 <ThomasWaldmann> so, what's the problem now?
256 2011-07-11T19:39:44 <Marchael> > data = 'TODO'
257 2011-07-11T19:41:24 <ThomasWaldmann> so, you don't have any other crashes to fix?
258 2011-07-11T19:42:02 <Marchael> m, I fixed other crashes http://codereview.appspot.com/4681050/patch/1/2
259 2011-07-11T19:42:18 <ThomasWaldmann> i just reviewed that
260 2011-07-11T19:42:52 <Marchael> ah, I don't see
261 2011-07-11T19:43:03 <ThomasWaldmann> and btw, you have hardcoded env and python2.6 in there
262 2011-07-11T19:43:42 <Marchael> but env is relative
263 2011-07-11T19:44:05 <ThomasWaldmann> my 2.6.0 env is called env260, my pypy env is called env-pypy, ...
264 2011-07-11T19:45:10 <ThomasWaldmann> but i guess you better don't waste too much time on this
265 2011-07-11T19:45:43 <ThomasWaldmann> so just strip a/env/lib/python2.6/site-packages/ and b/... from the patch and remove your quickinstall changes
266 2011-07-11T19:45:58 <ThomasWaldmann> so we can apply the patch manually until matt releases next whoosh
267 2011-07-11T19:49:42 <ThomasWaldmann> btw, i suggest you test your existing code (that's what I will do later also) and fix whatever problem you find before I find it :)
268 2011-07-11T19:50:07 <Marchael> ok :)
269 2011-07-11T19:50:32 <ThomasWaldmann> also read through the etherpad and check whether all stuff that is related to already "done" code is really done
270 2011-07-11T19:50:49 <ThomasWaldmann> hint: it's not
271 2011-07-11T19:54:33 *** hardy89
272 2011-07-11T20:00:08 <hardy89> waldi: test_serialization.py is now working fine.
273 2011-07-11T20:01:11 <hardy89> dreimark: i'm still not able to make diary entry of 21/6 :|
274 2011-07-11T20:01:23 <Marchael> ThomasWaldmann: what for example?
275 2011-07-11T20:02:30 <Marchael> may be start with clocks in MoinMoin/items/__init__.py ?
276 2011-07-11T20:03:08 <ThomasWaldmann> Marchael: fix your stuff, not mine :)
277 2011-07-11T20:03:20 *** pkumar
278 2011-07-11T20:04:16 <hardy89> hey pkumar
279 2011-07-11T20:05:03 <hardy89> sorry could not respond back to you earlier.
280 2011-07-11T20:07:32 <pkumar> hardy89 : hi, its alright. Can you please run apps module and paste the result somewhere
281 2011-07-11T20:07:44 <hardy89> pkumar: lemme see
282 2011-07-11T20:07:47 <pkumar> I mean tests on apps modules
283 2011-07-11T20:09:29 <hardy89> pkumar: http://paste.pocoo.org/show/436264/
284 2011-07-11T20:09:31 <hardy89> there you go
285 2011-07-11T20:09:37 <Marchael> ThomasWaldmann: if you tell me what exactly I should fix you save me a lot of time :)
286 2011-07-11T20:11:05 <pkumar> hardy89 : did you update your flask to flask==0.7?
287 2011-07-11T20:12:05 <ThomasWaldmann> Marchael: first check if all your code works as expected
288 2011-07-11T20:12:28 <Marchael> ok
289 2011-07-11T20:15:22 <hardy89> pkumar: yes. i have 0.7.2
290 2011-07-11T20:15:43 <Marchael> ThomasWaldmann: is test_request_context() in MoinMoin/items/__init__.py still needed?
291 2011-07-11T20:16:15 <pkumar> hardy89 : ok, thanks.
292 2011-07-11T20:16:24 <Marchael> or I can apply your changeset and forget about contend indexing for now.
293 2011-07-11T20:16:48 <hardy89> pkumar: also, please look into fs2 issues cos i'm almost done with rest of them.
294 2011-07-11T20:17:44 <ThomasWaldmann> Marchael: with that changeset, it does not use converters from items/__init__.py for indexing any more
295 2011-07-11T20:18:17 <pkumar> hardy89 : yeah, I'm little busy with writing tests in util module, I'll look into it soon, till the time you keep trying on it.
296 2011-07-11T20:18:34 <hardy89> pkumar: all right. not a problem.
297 2011-07-11T20:23:37 *** RogerHaase
298 2011-07-11T20:35:03 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/436282/
299 2011-07-11T20:35:19 <Marchael> may be you mean "type"?
300 2011-07-11T20:36:05 <ThomasWaldmann> no, I mean Type
301 2011-07-11T20:36:18 <ThomasWaldmann> how did you apply my changeset?
302 2011-07-11T20:36:58 <ThomasWaldmann> and are you duplicating code from indexing.py to index.py?
303 2011-07-11T20:37:24 <hardy89> waldi: Test improvement week
304 2011-07-11T20:37:24 *** hardy89
305 2011-07-11T20:37:32 <Marchael> yes that code duplicatingm, but how can I avoid this?
306 2011-07-11T20:38:21 *** hardy89
307 2011-07-11T20:38:31 <hardy89> ^sorry for that. pls ignore.
308 2011-07-11T20:38:34 *** hardy89
309 2011-07-11T20:38:35 <Marchael> May be I should place that in another module, so other modules can access that?
310 2011-07-11T20:38:59 <Marchael> :)
311 2011-07-11T20:39:08 *** greg_f
312 2011-07-11T20:44:24 <ThomasWaldmann> Marchael: you import what you need
313 2011-07-11T20:45:49 <Marchael> ThomasWaldmann: convert_data(item, rev_no) in MoinMoin/scripts/maint/index.py and def convert_data(self, rev, rev_no) in MoinMoin/storage/backends/indexing
314 2011-07-11T20:46:06 <Marchael> so they are duplicate not at all
315 2011-07-11T20:46:43 <Marchael> they both return converted revision, but takes different parameters
316 2011-07-11T20:51:14 <Marchael> ThomasWaldmann: so first takes item, and second takes item revision
317 2011-07-11T20:57:56 <ThomasWaldmann> i changed the interface slightly, so it is more usable
318 2011-07-11T21:02:24 <Marchael> ььбрьб
319 2011-07-11T21:02:46 <Marchael> mm, I couldn't add your changeset to index script
320 2011-07-11T21:04:39 <Marchael> Althought, I can change some stuff in build/update and it'll working
321 2011-07-11T21:08:24 <CIA-114> pkumar <contactprashantat@gmail.com> * ef9377e3b8ee r389 pytest2/MoinMoin/util/_tests/test_diff_html.py: util/test_diff_html changed to test different conditions - charobj.ratio() < 0.5 and charobj.ratio() > 0.5.
322 2011-07-11T21:08:25 <CIA-114> pkumar <contactprashantat@gmail.com> * d395c0a10138 r390 pytest2/MoinMoin/util/_tests/test_md5crypt.py: test added for util.md5crypt in util/test_md5crypt
323 2011-07-11T21:12:29 <pkumar> xorAxAx : I have some new changesets, can you please go through it and suggest the modifications. I think it's from b4784426e4c8.
324 2011-07-11T21:13:17 <xorAxAx> ok
325 2011-07-11T21:13:19 <xorAxAx> will do
326 2011-07-11T21:13:32 <pkumar> thanks
327 2011-07-11T21:15:46 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4675080
328 2011-07-11T21:30:47 <xorAxAx> sigh, today i tried to make mango lassi and it didnt taste well. my mango fruit wasnt good enough
329 2011-07-11T21:35:48 <ThomasWaldmann> hmm, mangos :)
330 2011-07-11T21:36:17 * ThomasWaldmann has an indian neighbor as mango supply :)
331 2011-07-11T21:37:29 * Marchael waiting for review
332 2011-07-11T21:40:33 <ThomasWaldmann> done
333 2011-07-11T21:41:52 <Marchael> (23:42:36) ThomasWaldmann: so just strip a/env/lib/python2.6/site-packages/ and b/... from the patch and remove your quickinstall changes
334 2011-07-11T21:41:52 <Marchael> hm
335 2011-07-11T21:42:14 <ThomasWaldmann> read exactly what i write :)
336 2011-07-11T21:42:25 <ThomasWaldmann> i told you what part to remove, not the whole line :)
337 2011-07-11T21:42:27 <Marchael> may be I dont't understand your point, but you told me remove thaht lines
338 2011-07-11T21:42:36 <ThomasWaldmann> no, i did not
339 2011-07-11T21:42:46 <Marchael> oops, sorry :)
340 2011-07-11T21:42:57 <ThomasWaldmann> just remove that part of the path
341 2011-07-11T21:43:28 <Marchael> you replace it to src/?
342 2011-07-11T21:43:35 <Marchael> or just remove
343 2011-07-11T21:46:09 <ThomasWaldmann> we just need a path that is meaningful and correct for everybody
344 2011-07-11T21:47:01 <Marchael> http://codereview.appspot.com/4675080/ patchset 2
345 2011-07-11T21:55:34 <Marchael> ThomasWaldmann: ?
346 2011-07-11T21:58:06 <ThomasWaldmann> yes, looks better. try if it applies.
347 2011-07-11T21:59:20 <ThomasWaldmann> brb
348 2011-07-11T22:22:41 <Marchael> hm, I can't apply multi index writer patch
349 2011-07-11T22:23:39 <Marchael> oops. I mean fields
350 2011-07-11T22:26:27 <Marchael> Hunk #1 FAILED at 152
351 2011-07-11T22:26:39 <Marchael> Althought previous patch aplleid normal
352 2011-07-11T22:26:57 <Marchael> *normally
353 2011-07-11T22:27:48 <Marchael> ThomasWaldmann: could you check this?
354 2011-07-11T22:33:35 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 76887b57c7d2 r336 moin-2.0/MoinMoin/storage/backends/indexing.py: add a quick and dirty hack for data indexing to stop it crashing, needs more work
355 2011-07-11T22:33:35 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 79a8c0c5a820 r337 moin-2.0/setup.py: Strict checking for whoosh version
356 2011-07-11T22:33:38 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * eb34de0b4489 r338 moin-2.0/ (3 files in 3 dirs): Added patch for whoosh 1.8.4, remove content indexing due Item class not avaivable when flaskg not initialized
357 2011-07-11T22:34:26 <Marchael> ThomasWaldmann: could you try to test my stuff
358 2011-07-11T22:34:41 * Marchael not sure about patch
359 2011-07-11T22:35:19 <brunomartin> How can I speedup moin2 reload after code changes?
360 2011-07-11T22:37:32 <ThomasWaldmann> brunomartin: yes, once you have loaded some example items into the backend, you can use load_xml = None
361 2011-07-11T22:37:41 <ThomasWaldmann> also index_rebuild = False
362 2011-07-11T22:40:31 * dreimark has filed first priliminary evaluation
363 2011-07-11T22:40:44 <brunomartin> ThomasWaldmann: yeah! thats what I need... thanks very, very much! ;-)
364 2011-07-11T22:48:46 <dreimark> brb
365 2011-07-11T23:00:30 <Marchael> ThomasWaldmann: could you test?
366 2011-07-11T23:17:34 <ThomasWaldmann> yes...
367 2011-07-11T23:20:18 <ThomasWaldmann> (env260)tw@x300:~/w/moin-2.0-whoosh/env260/lib/python2.6/site-packages$ patch -p1 <../../../../whoosh184-fix.patch
368 2011-07-11T23:20:21 <ThomasWaldmann> patching file whoosh/filedb/multiproc.py
369 2011-07-11T23:20:24 <ThomasWaldmann> patching file whoosh/fields.py
370 2011-07-11T23:20:26 <ThomasWaldmann> Hunk #1 FAILED at 152.
371 2011-07-11T23:20:29 <ThomasWaldmann> 1 out of 1 hunk FAILED -- saving rejects to file whoosh/fields.py.rej
372 2011-07-11T23:22:11 <Marchael> hm, I tried to apply this patch and had same results
373 2011-07-11T23:23:27 <Marchael> Althought, I have done diff -u and had same patch...
374 2011-07-11T23:24:28 <ThomasWaldmann> NameError: global name 'text_type' is not defined
375 2011-07-11T23:24:42 <ThomasWaldmann> (after applying manually)
376 2011-07-11T23:26:48 <Marchael> I appplied this patch manually too, but I haven't NameError
377 2011-07-11T23:27:09 <Marchael> at least at moin start up
378 2011-07-11T23:36:58 <ThomasWaldmann> it is triggered by the load_xml code
379 2011-07-11T23:37:20 <Marchael> now I see
380 2011-07-11T23:38:22 <Marchael> I copy that 2lines lines, but forget to see other changesin fields.py
381 2011-07-11T23:38:35 <Marchael> now I fixing my mistake
382 2011-07-11T23:47:46 <Marchael> ThomasWaldmann: Matt using whoosh.compat module for importing text_type
383 2011-07-11T23:48:03 <Marchael> but bad news what 1.8.54 haven't that module...
384 2011-07-11T23:48:15 <Marchael> *1.8.4
385 2011-07-11T23:48:37 <Marchael> so may be I just applied your patch?
386 2011-07-11T23:51:05 *** pkumar
387 2011-07-11T23:59:53 <Marchael> gn/bbl
