1 2011-07-12T00:19:32 <dreimark> re
2 2011-07-12T00:25:07 <dreimark> hmm, if i run pytest in pkumars repo I get
3 2011-07-12T00:25:09 <dreimark> Ran 39 test cases in 0.26s (0.21s CPU), 1 errors, 2 failures
4 2011-07-12T00:25:28 <dreimark> is that all? we have had before that refactoring much more tests
5 2011-07-12T00:26:16 <dreimark> ERROR: test_no_setup_cfg (test_easy_install.TestEasyInstallTest)
6 2011-07-12T00:26:33 <dreimark> AttributeError: DistributionWithoutHelpCommands instance has no attribute 'commands'
7 2011-07-12T00:26:44 <dreimark> pkumar, any hints ^^
8 2011-07-12T00:26:57 <dreimark> FAIL: testBasics (test_resources.EntryPointTests)
9 2011-07-12T00:28:50 *** raignarok
10 2011-07-12T00:29:16 <ThomasWaldmann> are you using the right branch?
11 2011-07-12T00:31:30 <dreimark> i did hg update to head of pytest2, so i think yes
12 2011-07-12T00:34:19 <dreimark> gn
13 2011-07-12T00:40:13 <ThomasWaldmann> gn dreimark
14 2011-07-12T04:27:54 <Marchael> moin
15 2011-07-12T05:30:52 <Marchael> ThomasWaldmann: I found what problem was in that patch
16 2011-07-12T05:31:53 <Marchael> each line in fields.y ending in ^M, but for some reason that patch doesn't contain this ^M
17 2011-07-12T05:32:06 <Marchael> s/in/on/
18 2011-07-12T05:33:21 <Marchael> Also, I can't use same type as Matt do, because whoosh.compat is unavailable in 1.8.4
19 2011-07-12T05:43:47 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 430223bb9701 r339 moin-2.0/whoosh184-fix.patch: Add missing ^M in whoosh patch
20 2011-07-12T05:43:59 <Marchael> ThomasWaldmann: try this^
21 2011-07-12T06:23:59 *** sinha
22 2011-07-12T07:16:02 <dreimark> Marchael: do you know what ^M is?
23 2011-07-12T07:17:00 <dreimark> hi sinha
24 2011-07-12T07:17:12 <sinha> dreimark: hello
25 2011-07-12T07:19:35 <dreimark> Marchael: why should a ^M anything change ?
26 2011-07-12T07:22:11 <Marchael> dreimark: don't know but patch doesn't applies without that
27 2011-07-12T07:32:03 <dreimark> Marchael: it is a windows linefeed
28 2011-07-12T07:33:11 <dreimark> please check if your source you created or have edited has always this special linefeed
29 2011-07-12T07:33:27 <dreimark> and compare it to the original source
30 2011-07-12T07:33:46 <Marchael> hm, i compared
31 2011-07-12T07:33:51 <dreimark> or if it is only in the original source
32 2011-07-12T07:34:08 <Marchael> btw, Thomas patch contains ^M too
33 2011-07-12T07:34:31 <Marchael> https://bitbucket-assetroot.s3.amazonaws.com/mchaput/whoosh/20110607/145/list_fix.diff
34 2011-07-12T07:34:52 <Marchael> I opened this file in vim, and saw ^M
35 2011-07-12T07:35:37 <dreimark> ok, now we know whoosh is written by a windows editor program
36 2011-07-12T07:35:47 <Marchael> :)
37 2011-07-12T07:36:23 <dreimark> usually you have to add an empty line to a pastebin diff
38 2011-07-12T07:36:34 <dreimark> to get it by patch into another program
39 2011-07-12T07:36:52 <dreimark> pastebin eats newlines at the end
40 2011-07-12T07:37:46 <dreimark> brb
41 2011-07-12T08:41:27 *** Marchael
42 2011-07-12T09:28:45 *** sinha
43 2011-07-12T09:31:27 *** sinha
44 2011-07-12T09:40:18 *** gwork
45 2011-07-12T09:41:22 <sinha> dreimark: please see this http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-07-11
46 2011-07-12T09:41:30 <dreimark> sinha: i am looking soon, please also merge then
47 2011-07-12T09:41:42 <sinha> ok
48 2011-07-12T09:42:22 <dreimark> because your quickinstall does not fit to version of current XStatic packages ...
49 2011-07-12T09:43:16 <sinha> i will commit this one and then merge it
50 2011-07-12T09:43:34 <dreimark> yes, wait reviewing
51 2011-07-12T09:47:49 *** mkerrin
52 2011-07-12T09:48:52 *** Marchael
53 2011-07-12T10:01:04 <dreimark> sinha: reviewed
54 2011-07-12T10:03:02 *** Marchael1
55 2011-07-12T10:03:22 <dreimark> may be Filter items by content type, because that can save always using items attribute
56 2011-07-12T10:04:56 <Marchael1> ThomasWaldmann: could you please test my stuff?
57 2011-07-12T10:05:06 <sinha> dreimark: by contenttype you mean type like text/moin, image/jpg, like this ?
58 2011-07-12T10:05:24 <dreimark> on the image you showed
59 2011-07-12T10:06:00 *** Marchael
60 2011-07-12T10:06:01 <dreimark> it is always [x] * items
61 2011-07-12T10:07:21 <sinha> so you mean at a time, we should show only item of any single contenttype ?
62 2011-07-12T10:07:39 <dreimark> sinha: look at http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-07-11
63 2011-07-12T10:07:59 <dreimark> i m speaking about the informations in the box
64 2011-07-12T10:08:11 <dreimark> it is repeating items in each line
65 2011-07-12T10:08:28 <dreimark> and we don't have something else.
66 2011-07-12T10:08:55 <dreimark> so we can have the word in the headline
67 2011-07-12T10:09:12 <sinha> okay yes i was thinking to remove that "items" string
68 2011-07-12T10:09:17 <dreimark> ok
69 2011-07-12T10:09:26 <dreimark> thats goood too
70 2011-07-12T10:10:59 <sinha> and reg that contenttype_group function, (rather than line breaking in that), i mean is their any way ti simply that
71 2011-07-12T10:11:34 <sinha> s/their/there, s/ti/to
72 2011-07-12T10:12:41 <dreimark> i don't know currently, i guess yes, but for now make it better readable
73 2011-07-12T10:12:52 <dreimark> then it is also easier to discuss it with others
74 2011-07-12T10:13:52 <dreimark> and a unittest helps to refactor it later
75 2011-07-12T10:15:35 <sinha> and the unittest is working fine for the flat_index function (may be i need to add one test by passing those params also)
76 2011-07-12T10:15:50 <sinha> and also i am adding the unittest to that contenttype_group function
77 2011-07-12T10:16:10 <dreimark> :)
78 2011-07-12T10:16:29 <dreimark> just check that your params are covered
79 2011-07-12T10:16:50 <sinha> okay, i will show you after doing that
80 2011-07-12T10:16:56 <dreimark> thx
81 2011-07-12T10:29:31 <ThomasWaldmann> sinha: you got another review :)
82 2011-07-12T10:29:46 * sinha looking
83 2011-07-12T10:31:18 *** jek
84 2011-07-12T10:31:18 *** xorAxAx
85 2011-07-12T10:32:28 <sinha> ThomasWaldmann: yes, first i was trying to run the logic and then thought to simply these group selection, anyways posting it in next code review
86 2011-07-12T10:33:36 *** greg_f
87 2011-07-12T10:38:11 *** xorAxAx
88 2011-07-12T10:39:09 <dreimark> xorAxAx: waldi ThomasWaldmann can we have today before the students meeting a midterm meeting?
89 2011-07-12T10:39:55 <dreimark> e.g.15:00 UTC ?
90 2011-07-12T10:40:03 <xorAxAx> yes, works for me
91 2011-07-12T10:45:42 *** pkumar
92 2011-07-12T10:46:40 <pkumar> dreimark : hey, I just read what you said in chat logs. can you please explain the problem to me once again?
93 2011-07-12T10:47:26 <dreimark> pkumar: i cloned, hg update to head pytest2, quickinstall, pytest
94 2011-07-12T10:47:45 <dreimark> what should be the estimated result?
95 2011-07-12T10:49:13 <pkumar> just a sec
96 2011-07-12T10:53:47 <pkumar> dreimark : 36 failed, 852 passed, 15 skipped, 7 xpassed, 6 error in 199.74 seconds
97 2011-07-12T10:54:33 <pkumar> dreimark : on 'hg branch' your active branch is pytest2 right?
98 2011-07-12T10:55:37 <pkumar> dreimark : the failures are in storage and in converter module
99 2011-07-12T10:57:03 <pkumar> dreimark : also, those tests with generator functions are iterated/tested in conftest.py.
100 2011-07-12T10:58:21 <pkumar> dreimark : you may need to update flask==0.7.2 and aqlalchemy==0.7.1
101 2011-07-12T11:01:21 <pkumar> dreimark : 4 errors are in test_backends_fs2 and two are regarding funcargs due to change of pytest.collect.Class to pytest.collect.Function
102 2011-07-12T11:01:32 <pkumar> in conftest.py
103 2011-07-12T11:03:45 <pkumar> more precisely errors are in _tests/test_sourcecode.py and converter/_tests/test_smiley.py
104 2011-07-12T11:03:51 <pkumar> dreimark : ^
105 2011-07-12T11:11:47 <ThomasWaldmann> sinha: iirc it is only used in one item class method, right?
106 2011-07-12T11:12:44 <sinha> yes in that modify_type_selection
107 2011-07-12T11:13:14 <ThomasWaldmann> yes, it is ok to modify that
108 2011-07-12T11:13:20 <sinha> okay
109 2011-07-12T11:17:27 *** Marchael1
110 2011-07-12T11:18:42 <dreimark> pkumar: hg branch is pytest2
111 2011-07-12T11:18:54 <dreimark> i look at version of sqla and flask
112 2011-07-12T11:19:34 *** Marchael
113 2011-07-12T11:19:41 <dreimark> but if you require qslalchemy==0.7.1 this should be in setup.py
114 2011-07-12T11:20:52 <pkumar> dreimark : yeah, I've updated it after you suggested about requirements last night. I'll push it in bb. having a slow connection right now.
115 2011-07-12T11:22:02 <dreimark> pkumar: which python version do you run?
116 2011-07-12T11:22:16 <pkumar> python - 2.6
117 2011-07-12T11:22:20 <dreimark> mine is currently 2.6.5
118 2011-07-12T11:22:24 <dreimark> ok
119 2011-07-12T11:23:16 <pkumar> dreimark : are your results varying from mine for the test run?
120 2011-07-12T11:24:15 <pkumar> dreimark : if so, please point out the differences. I'll fix it asap.
121 2011-07-12T11:26:42 <CIA-114> pkumar <contactprashantat@gmail.com> * b872a744a615 r391 pytest2/setup.py: installation version of sqlalchemy and Flask changed to latest versions, comment for pytest requirement corrected
122 2011-07-12T11:26:42 <CIA-114> pkumar <contactprashantat@gmail.com> * fe69557cd5ff r392 pytest2/MoinMoin/util/_tests/test_mimetype.py: test added for util.mimetype in util/test_mimetype
123 2011-07-12T11:26:42 <CIA-114> pkumar <contactprashantat@gmail.com> * 3454f76eca1b r393 pytest2/MoinMoin/util/_tests/test_mimetype.py: added test for mimetype.MimeType.mime_type() in util/test_mimetype
124 2011-07-12T11:32:30 *** Marchael
125 2011-07-12T11:55:48 *** Marchael
126 2011-07-12T12:30:09 <xorAxAx> pkumar: why do you add "('Expected "%(expected)s" but got "%(result_added)s"') % locals()" everywhere?
127 2011-07-12T12:30:44 <xorAxAx> pkumar: a42e136162a5 - you should use your name and not thomas'
128 2011-07-12T12:31:37 <pkumar> xorAxAx : I added to so that it would show a neater result if the test fails in any case
129 2011-07-12T12:31:51 <xorAxAx> pkumar: doesnt pytest do exactly that?
130 2011-07-12T12:33:31 <pkumar> xorAxAx : it does but sometimes when it prints long result it looks a little dirty, so I thought to add by myself.
131 2011-07-12T12:34:04 <pkumar> xorAxAx : ok, so I need to add my name there. I'll correct it.
132 2011-07-12T12:34:43 <xorAxAx> pkumar: no, this is a task pytest should do, please remove all those , ....expected stuff again
133 2011-07-12T12:35:05 <pkumar> xorAxAx : ok. will do it
134 2011-07-12T12:36:59 *** Marchael
135 2011-07-12T12:40:46 *** Marchael
136 2011-07-12T12:47:06 *** raignarok
137 2011-07-12T12:53:26 <dreimark> pkumar: it looks like this to me http://paste.pocoo.org/show/436893/
138 2011-07-12T12:54:53 <pkumar> dreimark : I ran it using py.test,
139 2011-07-12T12:56:06 <pkumar> dreimark : lemme try with pytest
140 2011-07-12T12:56:08 <dreimark> aha
141 2011-07-12T13:01:34 *** pkumar
142 2011-07-12T13:22:16 <waldi> dreimark: sorry, no time
143 2011-07-12T13:28:26 *** pkumar
144 2011-07-12T13:46:33 <pkumar> dreimark : the test runner for pytest v2.0.3 is py.test right? so why to use pytest to run the tests?
145 2011-07-12T14:29:48 *** pkumar
146 2011-07-12T14:30:52 *** pkumar
147 2011-07-12T14:41:25 <Marchael> ThomasWaldmann: when you get some free time, please test my stuff. Or point me to something from my todo.
148 2011-07-12T14:50:13 <ThomasWaldmann> you just read your etherpad, there is lots of todo, even for your current code
149 2011-07-12T14:54:19 <Marchael> ok, then I start writing docstrings to code
150 2011-07-12T14:54:50 <ThomasWaldmann> good idea :)
151 2011-07-12T14:55:17 <ThomasWaldmann> btw, if there is anything useful on EP that should go into a docstring, move it
152 2011-07-12T15:46:48 <Marchael> btw, could I copypaste some stuff from whoosh docs?
153 2011-07-12T15:47:02 <Marchael> e.g. related with analyzers
154 2011-07-12T15:49:24 <ThomasWaldmann> not sure if that makes sense.
155 2011-07-12T15:49:41 <ThomasWaldmann> if someone is interested in that, he can read whoosh docs
156 2011-07-12T15:49:53 <ThomasWaldmann> Marchael: where do you index the wikiname?
157 2011-07-12T15:50:23 <Marchael> hm, nowhere...
158 2011-07-12T15:50:38 <Marchael> I guess there should be a line in config
159 2011-07-12T15:51:06 <Marchael> and I just can add this in backend_to_index()
160 2011-07-12T15:51:20 <dreimark> pkumar: because i read that before. interestingly it had not crashed on default
161 2011-07-12T15:52:21 <ThomasWaldmann> Marchael: that wiki name stuff is right at the top of your etherpad, why do you need me to point you at this?
162 2011-07-12T15:52:50 <pkumar> dreimark : I was finding the difference between pytest and py.test and I landed on http://comments.gmane.org/gmane.comp.python.sympy/1838
163 2011-07-12T15:53:03 <Marchael> ThomasWaldmann: sorry, I'll add that after write docstrings
164 2011-07-12T15:53:35 <Marchael> I almost done for MoinMoin.search
165 2011-07-12T15:54:22 <pkumar> dreimark : in the pytest documentation they have mentioned to use py.test to invoke the tests
166 2011-07-12T15:55:53 <dreimark> somehow i believed that was changed for 2.0
167 2011-07-12T15:57:14 <pkumar> dreimark : the names do sound confusing sometimes.
168 2011-07-12T15:57:18 <pkumar> :)
169 2011-07-12T16:07:46 <pkumar> bbl
170 2011-07-12T16:07:50 *** pkumar
171 2011-07-12T16:14:26 <sinha> dreimark: please see this http://codereview.appspot.com/4686045 [Patch Set 3]
172 2011-07-12T16:15:32 <ThomasWaldmann> Marchael: your (C) is missing in indexing.py
173 2011-07-12T16:16:33 <Marchael> MoinMoin.stoage.backends.indexing?
174 2011-07-12T16:16:46 <ThomasWaldmann> yes
175 2011-07-12T16:17:03 <Marchael> ok, add this now
176 2011-07-12T16:17:20 <Marchael> ThomasWaldmann: btw, review http://codereview.appspot.com/4709041
177 2011-07-12T16:17:32 <Marchael> there are some docstrings
178 2011-07-12T16:17:54 <Marchael> (sorry for my english ;))
179 2011-07-12T16:20:18 *** jek
180 2011-07-12T16:21:09 <ThomasWaldmann> Marchael: the tags stuff seems to work with whoosh, congrats
181 2011-07-12T16:21:27 <Marchael> thx :)
182 2011-07-12T16:21:56 <ThomasWaldmann> I just asked myself whether there might be some better way than reading all docs from the index.
183 2011-07-12T16:22:14 <ThomasWaldmann> 15 class TokenizerTestBase(object):
184 2011-07-12T16:22:16 <ThomasWaldmann> 16 """ analyzers: base class for testing analyzers """
185 2011-07-12T16:22:40 <ThomasWaldmann> that's a good example for a worthless docstring
186 2011-07-12T16:22:55 <Marchael> I try to do in the same way as _test_security.py
187 2011-07-12T16:23:06 <ThomasWaldmann> (it doesn't say anything that the class name did not already say)
188 2011-07-12T16:24:16 <Marchael> then this class are self-explained :)
189 2011-07-12T16:27:20 *** mkerrin
190 2011-07-12T16:31:41 <Marchael> > always use same style for docstrings
191 2011-07-12T16:31:42 <Marchael> ThomasWaldmann: what is style?
192 2011-07-12T16:36:19 <Marchael> ah, ok
193 2011-07-12T16:37:44 <ThomasWaldmann> hehe
194 2011-07-12T16:52:12 <Marchael> ThomasWaldmann: patchset 2 http://codereview.appspot.com/4709041/
195 2011-07-12T17:01:01 * xorAxAx tried mango lassi with kardamom today, this time with mango juice. tastes much better
196 2011-07-12T17:09:56 <Marchael> ThomasWaldmann: thank you for review, may I commit?
197 2011-07-12T17:23:35 <xorAxAx> pkumar, my student, can you please check whether all tasks from the EP prolog (in green by thomas) have been included in the work items at the bottom of the EP?
198 2011-07-12T17:23:54 <xorAxAx> pkumar, it looks to me like you forgot to allocate time for rewriting tests for example
199 2011-07-12T17:40:46 *** pkumar
200 2011-07-12T17:46:40 *** hardy89
201 2011-07-12T17:48:30 <ThomasWaldmann> Marchael: commit when you feel it is in a good state
202 2011-07-12T17:49:14 <Marchael> I fixed your last notices, so I think what time is come
203 2011-07-12T17:49:52 <xorAxAx> pkumar, my student, i hereby cancel the meeting on wednesday that was still dangling there
204 2011-07-12T17:50:56 <pkumar> xorAxAx : all right, so is it like any new time shift or just canceled
205 2011-07-12T17:51:03 <xorAxAx> canceled
206 2011-07-12T17:51:11 <xorAxAx> pkumar: did you see my other messages?
207 2011-07-12T17:51:43 <xorAxAx> i hope you did, otherwise it means that you didnt read logs again
208 2011-07-12T17:52:09 <pkumar> xorAxAx : they are there just now in the chat log. looking at it
209 2011-07-12T17:52:22 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 5c6ef2031235 r340 moin-2.0/MoinMoin/ (5 files in 3 dirs): Update dosctrings for MoinMoin.search, add (c) in MoinMoin.storage.backends.indexing
210 2011-07-12T17:53:00 <pkumar> xorAxAx : ok, I'll just go through it and add required stuffs
211 2011-07-12T17:54:47 *** gwork
212 2011-07-12T17:56:14 <waldi> i can't attend the meeting today, sorry
213 2011-07-12T17:56:19 <waldi> xorAxAx: can you please cover for me?
214 2011-07-12T17:57:21 <hardy89> hi
215 2011-07-12T17:57:41 <xorAxAx> yes
216 2011-07-12T17:58:15 <pkumar> xorAxAx : for rewriting the tests we had [June 18 - June 25] but as most of the tests are assert statements, I didn't find tests to rewrite them in my modules. so, dreimark also suggested to add the tests to the existing tests
217 2011-07-12T17:58:34 <pkumar> and not to change them unless the are broken
218 2011-07-12T17:58:54 <pkumar> they*
219 2011-07-12T17:59:16 <xorAxAx> so ThomasWaldmann should check what else he expected
220 2011-07-12T18:00:26 <pkumar> xorAxAx : I'll add test_sourcecode / pep8 testing as the task in a week soon.
221 2011-07-12T18:01:11 <pkumar> fix failing imports was taken care in the days - [June 18 - June 25]
222 2011-07-12T18:01:31 <ThomasWaldmann> ok, welcome to your weekly meeting at midterm.
223 2011-07-12T18:01:49 <ThomasWaldmann> Marchael: please begin
224 2011-07-12T18:02:06 <Marchael> Last week I'm working on improving index script and runtime indexing.
225 2011-07-12T18:02:06 <Marchael> Add show_index() to script, so admin can view documents in indexes.
226 2011-07-12T18:02:06 <Marchael> Fix in move_index(), so now it doesn't remove index in some cases.
227 2011-07-12T18:02:06 <Marchael> I done runtime content indexing using Item class(add, remove, update revisions, show all tags) to acceess backend but my mistake was what switched off load\save xml at start up,
228 2011-07-12T18:02:06 <Marchael> so after installing moin it doesn't work because flaskg don't initialized at this time
229 2011-07-12T18:02:47 <Marchael> I applied ThomasWaldmann chageset and add it to my todo
230 2011-07-12T18:03:12 <Marchael> also commit some docs for MoinMoin.search(see above)
231 2011-07-12T18:03:59 <ThomasWaldmann> Marchael: please prepare for meetings, so you can c&p
232 2011-07-12T18:05:04 <ThomasWaldmann> next & blockers?
233 2011-07-12T18:05:20 <Marchael> This week 'll be working on other todo on ep
234 2011-07-12T18:05:20 <Marchael> blockers: none
235 2011-07-12T18:06:13 <Marchael> other = add wiki_name and try multi index writer
236 2011-07-12T18:06:49 <ThomasWaldmann> Marchael: btw, for better (manual) testing, it would be good to have a simple search functionality. the query field is already there, i guess you could quickly implement a very simply search with debug-like output in plain text
237 2011-07-12T18:07:27 <ThomasWaldmann> so add this on your list for this week also
238 2011-07-12T18:07:30 <Marchael> ThomasWaldmann: moin index --for all--action show
239 2011-07-12T18:07:56 <Marchael> i can see all revisions in all and latest
240 2011-07-12T18:08:12 <ThomasWaldmann> ok, but you'll need search anyway, so :)
241 2011-07-12T18:08:27 <Marchael> but I'll add this
242 2011-07-12T18:09:22 <ThomasWaldmann> in general, you need to speed up. we are at midterm now and more than half of time is gone already (iirc), but less than half of work is done.
243 2011-07-12T18:10:00 <Marchael> ThomasWaldmann: but what we'll do with content indexation?
244 2011-07-12T18:10:25 <Marchael> without Item it'll be difficult ti implement this
245 2011-07-12T18:10:27 <ThomasWaldmann> I'll think about that, just continue as it would work.
246 2011-07-12T18:10:57 <Marchael> ok
247 2011-07-12T18:11:20 <ThomasWaldmann> questions for Marchael ?
248 2011-07-12T18:12:49 * ThomasWaldmann takes that as a no. dreimark / sinha, your stage. thanks Marchael.
249 2011-07-12T18:12:55 <dreimark> Marchael: please merge regulary
250 2011-07-12T18:13:01 <sinha> okay
251 2011-07-12T18:13:07 <sinha> LAST: Modified the item index view (made it similar to global index) and a navigation path added and also did code refactoring for the module which is used to find out, whether a item has subitem or not.
252 2011-07-12T18:13:08 <sinha> Changeset i): https://bitbucket.org/sinha/moin2/changeset/4307261bac75 ( for view modification)
253 2011-07-12T18:13:08 <sinha> ii): https://bitbucket.org/sinha/moin2/changeset/19b257c0e102 ( for code rafactoring)
254 2011-07-12T18:13:08 <sinha> ScreenShot: http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-07-07?action=AttachFile&do=get&target=item_index.png
255 2011-07-12T18:13:08 <sinha> NOW: working on contenttype filtering on global index page
256 2011-07-12T18:13:08 <sinha> Latest Codereview: http://codereview.appspot.com/4686045 [ PatchSet 3]
257 2011-07-12T18:13:08 <sinha> BLOCKER: Not as such, maybe i'll get some when i convert current filter form to a flatland form
258 2011-07-12T18:13:09 <sinha> Screenshot: http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-07-11?action=AttachFile&do=get&target=global_index.png
259 2011-07-12T18:13:09 <sinha> NEXT: Maybe will start on the module inline(full) diff of item revisions
260 2011-07-12T18:13:25 <ThomasWaldmann> guttenberg would be proud!
261 2011-07-12T18:14:41 <dreimark> hmm?
262 2011-07-12T18:14:57 <ThomasWaldmann> for copy&paste performance
263 2011-07-12T18:15:04 <sinha> :P
264 2011-07-12T18:15:12 <Marchael> :D
265 2011-07-12T18:15:21 <dreimark> sinha: we should have index first in a very good state before working on a different part
266 2011-07-12T18:15:28 <sinha> yes i agree
267 2011-07-12T18:15:43 <sinha> thats why i have written "Maybe" :)
268 2011-07-12T18:15:51 *** pkumar
269 2011-07-12T18:15:51 <dreimark> ok
270 2011-07-12T18:15:56 <ThomasWaldmann> do we still have 3 "index" things?
271 2011-07-12T18:16:11 <sinha> gloabl_index, index, index2
272 2011-07-12T18:16:35 <dreimark> if you look in detail in global index and item index there is not much difference
273 2011-07-12T18:16:35 <ThomasWaldmann> can we unify them? does it make sense?
274 2011-07-12T18:16:56 <dreimark> it is only the starting point
275 2011-07-12T18:17:29 <dreimark> index2 is something which I think is not an index
276 2011-07-12T18:17:36 <sinha> yes, item_index and global_index are moreover same, except few functionality is only for global_index currently
277 2011-07-12T18:18:51 <xorAxAx> where have all my students gone ...
278 2011-07-12T18:18:58 <ThomasWaldmann> dreimark: well, it shows subitems and you even can up and download them
279 2011-07-12T18:19:03 <ThomasWaldmann> so index+x
280 2011-07-12T18:19:08 <xorAxAx> long time passing
281 2011-07-12T18:19:18 <xorAxAx> where have all my students gone? long time ago
282 2011-07-12T18:19:37 <ThomasWaldmann> let's see if he returns
283 2011-07-12T18:20:32 <dreimark> ThomasWaldmann: for example the drop box should be something available on each item
284 2011-07-12T18:20:48 <ThomasWaldmann> dreimark: my idea was index == (show sub)directory somehow
285 2011-07-12T18:21:00 <hardy89> here
286 2011-07-12T18:21:03 <ThomasWaldmann> and you can not only see what's there, but even up and download
287 2011-07-12T18:21:45 <ThomasWaldmann> sinha: how your time planning in general?
288 2011-07-12T18:22:02 <xorAxAx> ThomasWaldmann: lets take hardy first
289 2011-07-12T18:22:24 <ThomasWaldmann> I didn't expect a longish answer.
290 2011-07-12T18:22:34 <sinha> ThomasWaldmann: After completing this index part
291 2011-07-12T18:22:40 <sinha> i will move to full diff thing
292 2011-07-12T18:22:45 <ThomasWaldmann> xorAxAx: do you need to run somewhere?
293 2011-07-12T18:22:49 <xorAxAx> no
294 2011-07-12T18:22:59 <xorAxAx> first, i.e. instead of waiting for pkumar
295 2011-07-12T18:22:59 <dreimark> gives time to pkumar to return
296 2011-07-12T18:22:59 <sinha> then we will have load meta using ajax
297 2011-07-12T18:23:28 <sinha> and lets see if we can start using some ajax stuff after that
298 2011-07-12T18:24:07 <ThomasWaldmann> ok, anything else for sinha?
299 2011-07-12T18:24:36 <dreimark> not now, but we should become clear about that uploading thingies in the next days
300 2011-07-12T18:24:46 <ThomasWaldmann> sinha: maybe we can extend that ajax view thing even a bit (without big effort).
301 2011-07-12T18:25:11 <sinha> yes
302 2011-07-12T18:25:27 <sinha> i am completely comfortable in JQuery/Ajax stuff
303 2011-07-12T18:25:34 <dreimark> :)
304 2011-07-12T18:25:54 <dreimark> ThomasWaldmann: should we change order
305 2011-07-12T18:25:58 <ThomasWaldmann> ok, guess we are through, thanks to sinha and dreimark. hardy89, your stage.
306 2011-07-12T18:26:01 <dreimark> first ajax stuff then diff
307 2011-07-12T18:26:22 <ThomasWaldmann> dreimark: we'll talk afterwards about this.
308 2011-07-12T18:26:26 <dreimark> ok
309 2011-07-12T18:26:29 <hardy89> LAST & BLOCKERS
310 2011-07-12T18:26:29 <hardy89> *Removed failures of test_middleware_acl.py, test_serialization.py, test_backends_sqla.py,test_backend_fs.py, test_backend_router.py and test_backend_memory.py | Down from 27 failures to 14 failures in storage module
311 2011-07-12T18:26:29 <hardy89> *Solved the UUID issue of the test by manually comparing the XML with the help of xml.dom
312 2011-07-12T18:26:29 <hardy89> *Improved coverage of storage module which was earlier not good due to failures etc.
313 2011-07-12T18:26:29 <hardy89> *Fixed rename method in router backend
314 2011-07-12T18:26:41 <hardy89> NEXT
315 2011-07-12T18:26:42 <hardy89> * Will sanitize the tests of the rest of the module and make them more neat.
316 2011-07-12T18:26:42 <hardy89> * Write new test for other modules,if required.
317 2011-07-12T18:26:42 <hardy89> * Will work on the project which will be decided for further dates on EP by me, pkumar and our mentors.
318 2011-07-12T18:27:47 <ThomasWaldmann> hardy89: i just looked into your repo, but had a bit a hard time to find changesets except the recent few ones.
319 2011-07-12T18:27:50 <dreimark> hardy89: where is that changeset url?
320 2011-07-12T18:28:27 <hardy89> https://bitbucket.org/89hardy/moin_pytest/changesets
321 2011-07-12T18:28:40 <hardy89> ThomasWaldmann, dreimark : ^
322 2011-07-12T18:28:55 <dreimark> for this test_backend_memory.py | Down from 27 failures to ..
323 2011-07-12T18:30:06 <ThomasWaldmann> hardy89: i only see 5 very recent changesets there.
324 2011-07-12T18:30:06 <hardy89> this was over the last three changesets in the link given above
325 2011-07-12T18:30:36 <hardy89> ThomasWaldmann: i took time to commit.
326 2011-07-12T18:30:39 *** pkumar
327 2011-07-12T18:30:57 <pkumar> re
328 2011-07-12T18:31:02 <xorAxAx> wb pkumar
329 2011-07-12T18:31:05 <xorAxAx> pkumar: internet problems?
330 2011-07-12T18:31:22 <pkumar> xorAxAx : thanks, the wifi had stopped working
331 2011-07-12T18:32:30 <pkumar> xorAxAx : who's turn is it?
332 2011-07-12T18:32:38 <ThomasWaldmann> hardy89: https://bitbucket.org/89hardy/moin_pytest/changeset/d9eb2bd90918#chg_MoinMoin/storage/backends/router.py_oldline122 maybe tell me after meeting why this is a fix
333 2011-07-12T18:32:43 <xorAxAx> pkumar: hardy89
334 2011-07-12T18:32:48 <pkumar> ok
335 2011-07-12T18:33:51 <hardy89> ThomasWaldmann: will sure do
336 2011-07-12T18:35:10 <ThomasWaldmann> hardy89: about the minidom stuff - you are aware of emeraldtree?
337 2011-07-12T18:35:36 <hardy89> ThomasWaldmann: in lxml or the standard python libs?
338 2011-07-12T18:35:59 <dreimark> hardy89: you know what the base of moin-2 dom tree is?
339 2011-07-12T18:36:00 <ThomasWaldmann> it's a fork of elementtree we use for moin
340 2011-07-12T18:37:03 <hardy89> I wasnt aware of that. initially I tried lxml and xmldiff as well but it didn't work. I was not able to compare the two xmls as the ordering was always different. I read about some normalization that lxml does, but could not make it work
341 2011-07-12T18:38:05 <hardy89> I had asked for the xml comparison tools, but only xmldiff was suggested, forums suggested lxml
342 2011-07-12T18:38:35 <ThomasWaldmann> https://bitbucket.org/89hardy/moin_pytest/changeset/462163be25bc btw, that likely made a good failing test not fail any more
343 2011-07-12T18:39:13 <dreimark> https://bitbucket.org/89hardy/moin_pytest/changeset/7899736d7ede#chg_MoinMoin/_tests/test_wikiutil.py_newline259
344 2011-07-12T18:39:21 <dreimark> this is a typo
345 2011-07-12T18:39:57 <ThomasWaldmann> hehe, phonetic typos
346 2011-07-12T18:40:14 <ThomasWaldmann> ok, but we are getting too much into details
347 2011-07-12T18:41:26 <ThomasWaldmann> hardy89: your recent activity is nice, but somehow the overall progress and output seems to be very low
348 2011-07-12T18:41:29 <dreimark> in general rietveld helps much in reviewing before commit
349 2011-07-12T18:42:21 <ThomasWaldmann> and also communication is rather sporadic
350 2011-07-12T18:43:05 <hardy89> ThomasWaldmann: it took quite some time to familiarize with the codebase which I found quite daunting at my initial skill level and one week of no internet hampered the communication
351 2011-07-12T18:43:33 <ThomasWaldmann> i don't mean just that one week
352 2011-07-12T18:44:11 <hardy89> I did attend all meetings except one during that week
353 2011-07-12T18:44:22 <xorAxAx> wrong
354 2011-07-12T18:44:34 <xorAxAx> you missed most of the meetings we had scheduled before the main meeting
355 2011-07-12T18:44:50 <hardy89> I also stay in touch with pkumar
356 2011-07-12T18:45:11 <hardy89> xorAxAx: during the community bonding period?
357 2011-07-12T18:45:18 <xorAxAx> hardy89: no
358 2011-07-12T18:45:26 <dreimark> hardy89: no the testing studenbt meeting
359 2011-07-12T18:45:28 <ThomasWaldmann> but we can talk more about that later, so we get through with the official meeting.
360 2011-07-12T18:46:43 <ThomasWaldmann> hardy89: you can also talk with your mentor later, he's currently not here
361 2011-07-12T18:46:54 <hardy89> xorAxAx: will take care of those from now on
362 2011-07-12T18:46:59 <hardy89> ThomasWaldmann: ok
363 2011-07-12T18:47:00 <dreimark> waldi: ping
364 2011-07-12T18:47:04 <xorAxAx> hardy89: i just cancelled them
365 2011-07-12T18:47:12 <hardy89> dreimark: he had left earlier
366 2011-07-12T18:47:15 <ThomasWaldmann> ok, last 15mins for pkumar and xoraxax.
367 2011-07-12T18:47:27 <hardy89> bbl
368 2011-07-12T18:47:29 *** hardy89
369 2011-07-12T18:47:43 <pkumar> The task for last week was to add tests for all the existing tests as a part of improvement of test coverage.
370 2011-07-12T18:47:44 <pkumar> Also, to add tests in the util module for the files which don't have any.
371 2011-07-12T18:47:44 <pkumar> - Went through all the modules assigned to me and added tests to the existing tests.
372 2011-07-12T18:47:44 <pkumar> - Added tests for following in util modules
373 2011-07-12T18:47:44 <pkumar> mimetype.py
374 2011-07-12T18:47:44 <pkumar> thread_monitor
375 2011-07-12T18:47:47 <pkumar> md5crypt
376 2011-07-12T18:47:50 <pkumar> diff_html
377 2011-07-12T18:47:53 <pkumar> also worked on pycdb, SubProcess and kvstore but are incomplete. partial code is done but they are breaking at some places. have to look into that.
378 2011-07-12T18:47:56 <pkumar> NEXT : work on util till 15th, then all other modules by next week to 15th.
379 2011-07-12T18:47:57 <pkumar> Blockers - nothing at present.
380 2011-07-12T18:48:04 *** hardy89
381 2011-07-12T18:48:13 <hardy89> sorry. bbl was for wrong channel.
382 2011-07-12T18:51:05 <pkumar> with all other modules I meant the modules currently assigned to me in ep
383 2011-07-12T18:52:05 <dreimark> pkumar: do you run test_sourcecode ?
384 2011-07-12T18:53:01 <pkumar> dreimark : yeah, I'll check once more for white spaces due to my latest changesets
385 2011-07-12T18:53:50 *** raignarok
386 2011-07-12T18:54:04 <dreimark> 16 failed for me only by test_sourcecode
387 2011-07-12T18:54:47 <pkumar> dreimark : ok, will take care of that by today itself
388 2011-07-12T18:54:54 <pkumar> thanks
389 2011-07-12T18:55:58 <dreimark> if you invent new tests you should add your name to the copyright
390 2011-07-12T18:56:06 <dreimark> holder place
391 2011-07-12T18:56:36 <dreimark> https://bitbucket.org/pkumar/pytest_moin/changeset/d395c0a10138 e.g. or is that test by ThomasWaldmann ?
392 2011-07-12T18:56:49 <pkumar> dreimark : I was unaware of that part. I thought it is some MoinMoin copyright thing
393 2011-07-12T18:57:08 <pkumar> xorAxAx told me to correct it today. will do it
394 2011-07-12T18:57:24 <dreimark> if you look in some other scripts, e.g. item.__init__ you see lots of entries
395 2011-07-12T18:57:32 <xorAxAx> pkumar: it shows the name of the person(s) who contributed significant things to a particular file
396 2011-07-12T18:57:56 <dreimark> nothing more to say than that
397 2011-07-12T18:58:11 <pkumar> will make the changes
398 2011-07-12T19:00:09 <ThomasWaldmann> pkumar: thread_monitor? do we use that code?
399 2011-07-12T19:01:45 <pkumar> ThomasWaldmann : util/thread_monitor
400 2011-07-12T19:02:54 <pkumar> ThomasWaldmann : I'm not sure, I thought it is used as it was in the util module
401 2011-07-12T19:03:14 <dreimark> hmm, may be leftover from 1.9
402 2011-07-12T19:03:38 <dreimark> pkumar: you can'
403 2011-07-12T19:03:51 <dreimark> t know the history of our stuff
404 2011-07-12T19:04:03 <dreimark> but you can look if some code is used somewhere
405 2011-07-12T19:04:25 <dreimark> and select those first
406 2011-07-12T19:04:45 <ThomasWaldmann> grep is your friend
407 2011-07-12T19:04:56 *** hardy89
408 2011-07-12T19:05:01 <dreimark> such findings "why the hell do we have .... who needs that is also welcome"
409 2011-07-12T19:05:58 <pkumar> hehe, seems like efforts for that was in vain. anyway, I'll first check from now onwards.
410 2011-07-12T19:06:31 <dreimark> please report if you catch something like this too
411 2011-07-12T19:06:46 <pkumar> ok, will surely do
412 2011-07-12T19:08:02 <dreimark> we had in the past a cli command for that, may be we add it again
413 2011-07-12T19:08:22 <Marchael> ThomasWaldmann: I'm afraid I have another problem with load\save xml becasue now it's preventing me to access to app.cfg.wiki_name at start up
414 2011-07-12T19:08:25 <dreimark> ot it was only a helper
415 2011-07-12T19:08:43 <dreimark> Marchael: wait, we are still in the meeting - please
416 2011-07-12T19:08:50 <Marchael> dreimark: sorry
417 2011-07-12T19:09:36 <pkumar> dreimark : it can be added if it could tell which codes are being used right now
418 2011-07-12T19:10:04 <pkumar> or do we have better ways?
419 2011-07-12T19:10:09 <dreimark> pkumar: there is another thing you should care on, that's parts where sinha works on
420 2011-07-12T19:10:19 <dreimark> e.g. bookmarks
421 2011-07-12T19:11:12 <dreimark> he also should write unit tests for his parts.
422 2011-07-12T19:11:30 <pkumar> dreimark : currently I'm not aware much of his works. though I'll check his repo
423 2011-07-12T19:12:27 <dreimark> thx, later on all repos become merged
424 2011-07-12T19:13:19 <pkumar> sinha : after meeting we can talk about your stuffs and effects on the project(mine/yours')
425 2011-07-12T19:13:32 <sinha> pkumar: sure
426 2011-07-12T19:14:08 <pkumar> :)
427 2011-07-12T19:14:13 <dreimark> xorAxAx: ThomasWaldmann we are behind the "last quarter"
428 2011-07-12T19:14:23 <dreimark> last words?
429 2011-07-12T19:14:36 <ThomasWaldmann> meeting finished :)
430 2011-07-12T19:14:42 <dreimark> yay
431 2011-07-12T19:15:19 <pkumar> best for the last words :)
432 2011-07-12T19:38:52 <dreimark> bbl
433 2011-07-12T19:40:24 <Marchael> ThomasWaldmann: do you read my last quiestion?
434 2011-07-12T19:40:35 <Marchael> I asked about wikiname
435 2011-07-12T19:42:45 <Marchael> I guess I should as solve this problem as problem with index_dir
436 2011-07-12T19:43:18 <ThomasWaldmann> Marchael: oh, yeah, that's a problem :|
437 2011-07-12T19:44:08 <ThomasWaldmann> so, put a comment at the place where it is missing, but don't make it crash
438 2011-07-12T19:44:22 <ThomasWaldmann> (just so we don't forget. # TODO ...)
439 2011-07-12T19:45:26 <Marchael> ThomasWaldmann: but why I can't just pass wikiname parameter to ItemIndex?
440 2011-07-12T19:45:40 <Marchael> as with index_dir
441 2011-07-12T19:46:34 <ThomasWaldmann> ah, right, yeah.
442 2011-07-12T19:46:40 <Marchael> good
443 2011-07-12T19:46:56 <ThomasWaldmann> and before you pass 1000 things via single params, you just pass cfg there
444 2011-07-12T19:46:59 <ThomasWaldmann> :)
445 2011-07-12T19:47:14 <Marchael> ok :)
446 2011-07-12T19:50:27 <dreimark> please a refactoring changeset for that
447 2011-07-12T19:50:46 <dreimark> not mixed with new functionality
448 2011-07-12T19:52:00 <Marchael> dreimark: am, I should firs pass app.cfg to ItemIndex, then commit. And after commit wikiname?
449 2011-07-12T19:52:50 <dreimark> if you pass app.cfg you also can remove index_dir, if it is in cfg too
450 2011-07-12T19:53:07 <Marchael> yes
451 2011-07-12T19:54:13 <dreimark> i have not in detailed looked what you do now
452 2011-07-12T19:54:52 <dreimark> if wikiname getting from there fits into the same scope do it in one
453 2011-07-12T19:55:08 <Marchael> dreimark: I implementing wikiname field to whoosh schema, so wiki admin can use one index file to store indexes for many wikis
454 2011-07-12T19:55:18 <dreimark> if it is because wikiname is needed for another change too then do this with the other change
455 2011-07-12T19:55:51 <Marchael> *on index_dir
456 2011-07-12T19:55:55 <Marchael> **one
457 2011-07-12T19:56:15 <Marchael> ok
458 2011-07-12T19:56:28 <dreimark> the point is that reading the diff is easier if you know
459 2011-07-12T19:56:43 <dreimark> this is basically refactoring and this is some new function
460 2011-07-12T19:57:34 <dreimark> bbl
461 2011-07-12T19:59:30 <pkumar> bbl
462 2011-07-12T19:59:33 *** pkumar
463 2011-07-12T20:00:40 *** greg_f
464 2011-07-12T20:00:56 <Marchael> ThomasWaldmann: btw, you try history?
465 2011-07-12T20:01:52 <Marchael> I mean that history using whoosh indexes
466 2011-07-12T20:03:45 *** raignarok
467 2011-07-12T20:16:58 <Marchael> I have working wikiname in my repo
468 2011-07-12T20:17:21 <Marchael> need some tests btw
469 2011-07-12T20:17:32 <Marchael> but at least build works ok
470 2011-07-12T20:20:53 <Marchael> runtime seems ok
471 2011-07-12T20:25:33 <Marchael> ThomasWaldmann: please review http://codereview.appspot.com/4705044
472 2011-07-12T20:36:36 <dreimark> Marchael: some hints from me
473 2011-07-12T20:36:45 *** hardy89
474 2011-07-12T20:40:14 <Marchael> dreimark: thx!
475 2011-07-12T20:48:15 <dreimark> ThomasWaldmann: http://labs.abeautifulsite.net/projects/js/jquery/contextMenu/demo/
476 2011-07-12T20:48:25 <dreimark> what do you thint about this
477 2011-07-12T20:51:04 <sinha> dreimark: should i commit this now http://codereview.appspot.com/4686045/ [ Set3] ?
478 2011-07-12T20:51:15 *** grzywacz
479 2011-07-12T20:51:26 *** grzywacz
480 2011-07-12T20:51:30 * dreimark looks
481 2011-07-12T20:57:11 *** raignarok
482 2011-07-12T20:57:31 <Marchael> thunderbird tracking me
483 2011-07-12T20:58:09 <Marchael> *tricking
484 2011-07-12T20:58:25 <Marchael> ThomasWaldmann: I answered
485 2011-07-12T21:02:29 <dreimark> sinha: reviewes
486 2011-07-12T21:02:38 <dreimark> sinha: reviewed
487 2011-07-12T21:03:19 <dreimark> brb
488 2011-07-12T21:05:39 *** hardy89
489 2011-07-12T21:09:32 <ThomasWaldmann> re
490 2011-07-12T21:11:00 <Marchael> wb
491 2011-07-12T21:13:06 <Marchael> > app.cfg.index_uri = app.cfg.router_index_uri
492 2011-07-12T21:13:06 <Marchael> why is it bad?
493 2011-07-12T21:13:34 <Marchael> You told me earlier what I should pass cfg object
494 2011-07-12T21:14:59 <ThomasWaldmann> see reply
495 2011-07-12T21:15:08 <Marchael> ok
496 2011-07-12T21:15:28 <ThomasWaldmann> i wasn't aware that it sometimes needs different stuff than configured
497 2011-07-12T21:16:31 <ThomasWaldmann> so, i guess we still want to pass cfg (for everything we need to READ from there), but we need to handle that one thing differently
498 2011-07-12T21:17:44 *** pkumar
499 2011-07-12T21:32:12 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4705044/ patchset 2
500 2011-07-12T21:40:36 *** pkumar
501 2011-07-12T21:44:59 <Marchael> ThomasWaldmann: ?
502 2011-07-12T22:02:01 *** jek
503 2011-07-12T22:02:01 *** jek
504 2011-07-12T22:07:04 * ThomasWaldmann was busy otherwise
505 2011-07-12T22:07:39 <Marchael> ok
506 2011-07-12T22:14:18 <ThomasWaldmann> looks ok
507 2011-07-12T22:14:47 <Marchael> ok, may I commit?
508 2011-07-12T22:15:49 <ThomasWaldmann> sure
509 2011-07-12T22:17:13 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 459fda5f2079 r341 moin-2.0/MoinMoin/ (4 files in 4 dirs): Add wikiname field support for runtime indexing and index script, now wiki admin can create wikis farm using one app.cfg.index_dir
510 2011-07-12T22:18:53 <Marchael> ok, after I sleep some hours I'll work on implementing multi index writer
511 2011-07-12T22:33:27 <dreimark> re
512 2011-07-12T22:33:36 <dreimark> Marchael: good night
513 2011-07-12T22:35:02 *** Marchael
514 2011-07-12T22:35:47 *** raignarok
515 2011-07-12T22:51:43 *** grzywacz
516 2011-07-12T23:21:00 <dreimark> http://dilbert.com/strips/comic/2011-07-12/
517 2011-07-12T23:26:39 <ThomasWaldmann> hehe
518 2011-07-12T23:44:49 <dreimark> gn
