1 2011-07-27T00:08:04 *** raignarok
2 2011-07-27T04:26:29 <Marchael> moin
3 2011-07-27T05:15:47 <Marchael> ThomasWaldmann: some hours ago I already asked you, how can I access to item revision content at moin start up? I looking at MoinMoin.apps.frontend.views but that function uses flaskg which unreachable in start up time.
4 2011-07-27T06:28:50 *** Marchael
5 2011-07-27T07:03:44 *** raignarok
6 2011-07-27T07:10:08 *** raignarok
7 2011-07-27T07:22:32 <ThomasWaldmann> moin
8 2011-07-27T07:22:43 <ThomasWaldmann> xorAxAx: from MoinMoin.app:
9 2011-07-27T07:22:44 <ThomasWaldmann> # XXX wrong place / name - this is a generic preload functionality, not just for tests
10 2011-07-27T07:22:48 <ThomasWaldmann> # To make some tests happy
11 2011-07-27T07:22:50 <ThomasWaldmann> app.cfg.test_num_pages = item_count
12 2011-07-27T07:23:14 <ThomasWaldmann> sounds like something for pkumar
13 2011-07-27T07:23:36 <ThomasWaldmann> (== get rid of this)
14 2011-07-27T07:24:30 *** pkumar
15 2011-07-27T07:32:51 <ThomasWaldmann> ah, good timing :)
16 2011-07-27T07:32:57 <ThomasWaldmann> moin pkumar
17 2011-07-27T07:33:31 <pkumar> ThomasWaldmann : moin
18 2011-07-27T07:33:53 <ThomasWaldmann> i just found something for the tests cleanup task
19 2011-07-27T07:34:14 <pkumar> ThomasWaldmann : yeah, please tell me
20 2011-07-27T07:34:23 <ThomasWaldmann> look into MoinMoin/app.py
21 2011-07-27T07:34:30 <ThomasWaldmann> (07:21) < ThomasWal> # XXX wrong place / name - this is a generic preload functionality, not just for tests
22 2011-07-27T07:34:33 <ThomasWaldmann> (07:21) < ThomasWal> # To make some tests happy
23 2011-07-27T07:34:35 <ThomasWaldmann> (07:21) < ThomasWal> app.cfg.test_num_pages = item_count
24 2011-07-27T07:35:14 <ThomasWaldmann> that load_xml thing is loading some items into the backend
25 2011-07-27T07:35:47 <ThomasWaldmann> currently it does that every time moin starts up (except if switched off), which is a bit annoying
26 2011-07-27T07:36:44 <ThomasWaldmann> iirc i tried to move that to a script, but couldn't, because the some tests depend on app.cfg.test_num_pages being set there
27 2011-07-27T07:37:39 <ThomasWaldmann> so, we should get rid of that dependency
28 2011-07-27T07:38:57 <pkumar> ok, can you please tell me what does that statement exactly do?
29 2011-07-27T07:39:29 <ThomasWaldmann> it loads some items into backend and counts them, then makes the count available there
30 2011-07-27T07:40:45 <ThomasWaldmann> and most of the code deal with not doing that multiple times if the items are already put there
31 2011-07-27T07:41:40 <pkumar> so, first I think I need to find which all tests use this, right?
32 2011-07-27T07:42:12 <ThomasWaldmann> yes. and then about whether this is needed or can be done better.
33 2011-07-27T07:42:47 <ThomasWaldmann> in any case, we don't want to have that in normal application startup.
34 2011-07-27T07:43:24 <ThomasWaldmann> and if you can avoid doing that for every test app creation, i think you could speed up tests significantly.
35 2011-07-27T07:44:30 <pkumar> ok, will schedule it in ep now itself.
36 2011-07-27T08:39:28 <dreimark> moin
37 2011-07-27T08:40:06 <pkumar> ThomasWaldmann : seems like test_test_environment and test_wikiutil are the only test which use that statement. rest all the test runs fine.
38 2011-07-27T08:41:56 <ThomasWaldmann> well, it can't be removed unless no tests use it
39 2011-07-27T08:42:37 <pkumar> ok,
40 2011-07-27T08:43:37 <pkumar> I'll check once more to confirm and then try to fix that
41 2011-07-27T09:04:16 *** Marchael
42 2011-07-27T10:07:57 *** pkumar
43 2011-07-27T10:08:09 <dreimark> ThomasWaldmann: https://github.com/biesiad/multiDownload/blob/master/jquery.multiDownload.js
44 2011-07-27T10:08:35 <dreimark> should I ask for dual licensing or is that not needed for this kind of "license"
45 2011-07-27T10:12:35 <dreimark> bbl
46 2011-07-27T10:55:54 <ThomasWaldmann> dreimark: the license seems rather liberal. but you could ask him to cleanup the license header. there are some linefeeds missing.
47 2011-07-27T11:02:49 *** greg_f
48 2011-07-27T11:19:25 <ThomasWaldmann> Marchael: see your issue tracker
49 2011-07-27T11:51:49 *** gwork
50 2011-07-27T11:52:25 <gwork> moin
51 2011-07-27T14:00:17 *** MattMaker
52 2011-07-27T14:51:00 *** Marchael
53 2011-07-27T16:05:09 <brunomartin> ThomasWaldmann: tiny bug in Marchael repo on script/maint/index.py... https://bitbucket.org/marchael/moin-2.0/issue/5/tiny-ident-bug ;-)
54 2011-07-27T16:31:54 *** pkumar
55 2011-07-27T17:00:25 *** pkumar
56 2011-07-27T17:01:23 *** pkumar
57 2011-07-27T17:04:13 *** pkumar
58 2011-07-27T17:04:18 *** pkumar
59 2011-07-27T17:35:30 *** gwork
60 2011-07-27T18:15:50 *** pkumar
61 2011-07-27T18:19:06 *** MattMaker
62 2011-07-27T18:20:34 <ThomasWaldmann> brunomartin: ident?
63 2011-07-27T18:21:53 <brunomartin> ThomasWaldmann: *indent...
64 2011-07-27T18:21:55 <brunomartin> :-P
65 2011-07-27T18:24:02 <ThomasWaldmann> brunomartin: iirc you can edit the title
66 2011-07-27T18:24:37 <brunomartin> ThomasWaldmann: done!
67 2011-07-27T18:29:16 *** MattMaker
68 2011-07-27T18:34:51 <brunomartin> ThomasWaldmann: There is another problem, but I not sure if I should report, couse seems that its gonna be rewrite by Marchael... In backands/indexining.py, when loading a xml file that has items with revisions (I think this is note the case of initial data), it fail like this: http://paste.pocoo.org/show/447507/ here the method involved: http://paste.pocoo.org/show/447505/
69 2011-07-27T18:38:29 *** greg_f
70 2011-07-27T18:39:14 <brunomartin> ThomasWaldmann: seems that it cannot find the item by uuid, then it tries to insert the item again and fail... I did a workaround for me, but if its a problem for moin2 I file it on bugtracker...
71 2011-07-27T18:51:16 <ThomasWaldmann> uuid stuff is a bit broken still
72 2011-07-27T19:05:44 <brunomartin> ThomasWaldmann: should I file it as a bug? but the concept is to have only a uuid to item ando all revisions, even if the item name changes, right?
73 2011-07-27T19:11:48 <brunomartin> ThomasWaldmann: using ipdb, I figure out that the meta value that comes in to update_item has uuid diferent than the one that is saved on table, but they have the same name...
74 2011-07-27T19:22:37 <ThomasWaldmann> yes, that's the concept
75 2011-07-27T19:23:08 <ThomasWaldmann> i have still to make my 3rd attempt to fix the uuid stuff
76 2011-07-27T19:25:10 <ThomasWaldmann> brb
77 2011-07-27T19:40:12 * brunomartin is impressed with whoosh! :-)
78 2011-07-27T20:23:15 <dreimark> moin
79 2011-07-27T20:24:21 *** MattMaker
80 2011-07-27T20:48:56 *** raignarok
81 2011-07-27T21:08:33 *** MattMaker
82 2011-07-27T21:21:09 *** MattMaker
83 2011-07-27T21:27:23 <brunomartin> When an item is created, it is in revision 0, or it has no revision?
84 2011-07-27T21:27:31 <brunomartin> in moin2
85 2011-07-27T21:28:17 <ThomasWaldmann> first rev is 0
86 2011-07-27T21:33:10 <brunomartin> ThomasWaldmann: but the user's profile item doesn't have a rev? I'm getting this trying to update whoosh index: http://paste.pocoo.org/show/447605/
87 2011-07-27T21:34:04 <brunomartin> ThomasWaldmann: I think that I can ignore itens that don't have any have, am I right?
88 2011-07-27T21:52:02 <dreimark> brunomartin: a user profile item has only one revision
89 2011-07-27T21:52:05 <dreimark> no history
90 2011-07-27T21:53:54 <dreimark> hmm, i don't think that useritems should go into the whoosh index
91 2011-07-27T22:02:20 <brunomartin> dreimark: but item.get_revision(-1) on these items raises NoSuchRevisionError, is this expected?
92 2011-07-27T22:13:56 <dreimark> it is expectd that it has no revisions
93 2011-07-27T22:14:17 <dreimark> not sure if it should race this
94 2011-07-27T22:14:40 <dreimark> also not sure if this is a valid call for such items
95 2011-07-27T22:18:17 <brunomartin> dreimark: well, this is called this way when updating index, but Marchael is working there, so I will talk to him before file a bug.. it's nota problem to me now...
96 2011-07-27T22:23:55 <dreimark> yes better discuss it with marchael or thomas, for me it looks like it should not give a traceback or fail earlier
97 2011-07-27T22:24:41 <brunomartin> ok... thanks
98 2011-07-27T22:28:28 * dreimark looks like i can make a new package soon http://code.google.com/p/svg-edit/issues/detail?id=821
99 2011-07-27T22:31:06 *** raignarok
100 2011-07-27T23:15:11 <ThomasWaldmann> re
101 2011-07-27T23:27:40 * dreimark plays with webkit2png
102 2011-07-27T23:52:58 *** MattMaker_
103 2011-07-27T23:56:25 *** MattMaker
104 2011-07-27T23:56:26 *** MattMaker_
105
