1 2011-07-29T00:12:45  <ThomasWaldmann> brunomartin: can you try a patch for the charset issue?
   2 2011-07-29T00:13:05  <ThomasWaldmann> (first revert the first patch :)
   3 2011-07-29T00:21:11  <ThomasWaldmann> safari & moin2 users here?
   4 2011-07-29T00:28:55  <ThomasWaldmann> or IE < IE8?
   5 2011-07-29T00:35:52  *** m4k3r_ has quit IRC
   6 2011-07-29T00:36:31  <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 296:1e9ec607913d 2.0/MoinMoin/util/send_file.py: fix downloading of items with non-ascii names (for most modern browsers), implement RFC2231/5987
   7 2011-07-29T00:36:37  <ThomasWaldmann> please test :)
   8 2011-07-29T00:36:45  <brunomartin> ThomasWaldmann: yes...
   9 2011-07-29T00:37:22  <ThomasWaldmann> it works for me on ff5.0
  10 2011-07-29T00:37:47  <ThomasWaldmann> safari and older browsers would be interesting
  11 2011-07-29T00:38:22  <ThomasWaldmann> they won't support that new rfc, but maybe they just fall back to last url component then (and decode it correctly)
  12 2011-07-29T00:38:50  <ThomasWaldmann> that is an old issue btw
  13 2011-07-29T00:39:38  <brunomartin> I will test here on firefox 3.6 and safari...
  14 2011-07-29T00:39:41  <brunomartin> brb
  15 2011-07-29T00:43:23  <ThomasWaldmann> http://moinmo.in/MoinMoinBugs/Non-ASCII%20attachment%20names%20corrupted%20on%20download annoying people since 2007, at least
  16 2011-07-29T00:43:42  <brunomartin> hehehe...
  17 2011-07-29T00:48:17  <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/41/non-ascii-download-filenames-dont-work give feedback there
  18 2011-07-29T04:26:16  *** Marchael has joined #moin-dev
  19 2011-07-29T04:28:56  <Marchael> moin
  20 2011-07-29T07:07:52  *** m4k3r has joined #moin-dev
  21 2011-07-29T07:21:12  *** pkumar has joined #moin-dev
  22 2011-07-29T08:11:28  *** m4k3r_ has joined #moin-dev
  23 2011-07-29T08:11:43  *** m4k3r has quit IRC
  24 2011-07-29T08:18:39  <CIA-114> pkumar <contactprashantat@gmail.com> * e6d1643d27d7 r437 pytest2/MoinMoin/datastruct/backends/_tests/test_wiki_dicts.py: dded test for wiki_dicts.WikiDicts._retrieve_items in test_wiki_dicts in datastruct module
  25 2011-07-29T08:18:39  <CIA-114> pkumar <contactprashantat@gmail.com> * fa8cf6537cba r438 pytest2/MoinMoin/datastruct/backends/_tests/test_config_dicts.py: added test to test_config_dicts for config_dicts.ConfigDicts.__iter__() in datastruct module
  26 2011-07-29T08:18:40  <CIA-114> pkumar <contactprashantat@gmail.com> * 35471ebbf23f r439 pytest2/MoinMoin/items/_tests/test_Item.py: added test for Item.meta_filter() in test_Item in Item module
  27 2011-07-29T08:18:40  <CIA-114> pkumar <contactprashantat@gmail.com> * da96ef105861 r440 pytest2/MoinMoin/items/_tests/test_Item.py: added tests for meta_dict_to_text and meta_text_to_dict in test_item
  28 2011-07-29T08:18:40  <CIA-114> pkumar <contactprashantat@gmail.com> * 67da6b2f409a r441 pytest2/MoinMoin/items/_tests/test_Item.py: added test for items.rename in test_Item
  29 2011-07-29T08:18:40  <CIA-114> pkumar <contactprashantat@gmail.com> * 9115a203b363 r442 pytest2/MoinMoin/items/_tests/test_Item.py: woops test name should be test_rename
  30 2011-07-29T08:18:41  <CIA-114> pkumar <contactprashantat@gmail.com> * 8ab608b4e538 r443 pytest2/MoinMoin/items/_tests/test_Item.py: added test for items.delete in test_Item
  31 2011-07-29T08:18:41  <CIA-114> pkumar <contactprashantat@gmail.com> * 83c5d5d0cc73 r444 pytest2/MoinMoin/items/_tests/test_Item.py: added test for Item.revert() in test_Item in items module
  32 2011-07-29T08:18:46  <CIA-114> pkumar <contactprashantat@gmail.com> * 34aeed3ae75a r445 pytest2/MoinMoin/items/_tests/test_Item.py: added test for Item.modify() in test_Item in items module
  33 2011-07-29T08:18:46  <CIA-114> pkumar <contactprashantat@gmail.com> * c1ca6b16bba1 r446 pytest2/MoinMoin/items/_tests/test_Item.py: test for Item.modify() modified to check previous and later conditions
  34 2011-07-29T08:18:46  <CIA-114> pkumar <contactprashantat@gmail.com> * e8eb969ff26b r447 pytest2/MoinMoin/items/_tests/test_Item.py: tests in test_Item modified to be less complex and more neat
  35 2011-07-29T08:18:46  <CIA-114> pkumar <contactprashantat@gmail.com> * 17b028cef24f r448 pytest2/MoinMoin/items/_tests/test_Item.py: added test for item.count_items() in test_Item in items module
  36 2011-07-29T08:18:46  <CIA-114> pkumar <contactprashantat@gmail.com> * cb9d9a259f03 r449 pytest2/MoinMoin/items/_tests/test_Item.py: added test for items.Binary in test_item in items module
  37 2011-07-29T08:18:46  <CIA-114> pkumar <contactprashantat@gmail.com> * 42d368d2e0f1 r450 pytest2/MoinMoin/items/_tests/test_Item.py: use Binary.create in instead of Item.create as testing for class Binary
  38 2011-07-29T08:19:46  <CIA-114> pkumar <contactprashantat@gmail.com> * b72c80e2c67e r451 pytest2/MoinMoin/items/_tests/test_Item.py: added tests for ZipMixin, TransformableBitmapImage, Text in test_Item in items module
  39 2011-07-29T08:19:46  <CIA-114> pkumar <contactprashantat@gmail.com> * 31f3d6617072 r452 pytest2/MoinMoin/items/_tests/test_Item.py: added tests for conversion related functions of Text in test_Item
  40 2011-07-29T08:19:46  <CIA-114> pkumar <contactprashantat@gmail.com> * 3ad1888fe586 r453 pytest2/MoinMoin/items/_tests/test_Item.py: TestTransformableBitmapImage.test_transform() modified after having PIL in the env in test_Item
  41 2011-07-29T08:19:46  <CIA-114> pkumar <contactprashantat@gmail.com> * 5b00e06e5a8b r454 pytest2/MoinMoin/items/_tests/test_Item.py: added test for TransformableBitmapImage._render_data_diff() in test_Item in items module
  42 2011-07-29T08:19:46  <CIA-114> pkumar <contactprashantat@gmail.com> * 4a879ae68b3b r455 pytest2/MoinMoin/items/_tests/test_Item.py: test added for TestTransformableBitmapImage._render_data_diff_text() in test_Item in items module
  43 2011-07-29T08:24:33  <pkumar> brb
  44 2011-07-29T08:24:36  *** pkumar has quit IRC
  45 2011-07-29T08:37:49  *** pkumar has joined #moin-dev
  46 2011-07-29T08:38:06  <dreimark> moin
  47 2011-07-29T08:51:20  *** pkumar has quit IRC
  48 2011-07-29T09:01:24  *** m4k3r_ has quit IRC
  49 2011-07-29T09:12:04  *** m4k3r has joined #moin-dev
  50 2011-07-29T09:14:48  *** m4k3r has quit IRC
  51 2011-07-29T09:17:03  *** m4k3r has joined #moin-dev
  52 2011-07-29T09:21:17  *** raignarok has joined #moin-dev
  53 2011-07-29T09:57:54  *** raignarok has quit IRC
  54 2011-07-29T10:12:46  *** raignarok has joined #moin-dev
  55 2011-07-29T10:34:30  *** greg_f has joined #moin-dev
  56 2011-07-29T10:37:26  <ThomasWaldmann> moin
  57 2011-07-29T12:29:02  *** raignarok has quit IRC
  58 2011-07-29T13:17:12  *** raignarok has joined #moin-dev
  59 2011-07-29T13:19:14  <dreimark> ThomasWaldmann: http://moinmo.in/MoinMoinBugs/CreoleFormatSignature?action=AttachFile&do=view&target=inhibit_p.patch
  60 2011-07-29T13:19:31  <dreimark> I have a similiar problem as the one on that bugreport
  61 2011-07-29T13:19:57  <dreimark> want to add this to 1.9. Do you see a problem by this?
  62 2011-07-29T14:19:27  *** greg_f has quit IRC
  63 2011-07-29T14:22:13  *** greg_f has joined #moin-dev
  64 2011-07-29T14:24:32  *** m4k3r has quit IRC
  65 2011-07-29T14:26:14  *** m4k3r has joined #moin-dev
  66 2011-07-29T14:38:39  *** Marchael has quit IRC
  67 2011-07-29T14:53:35  *** m4k3r_ has joined #moin-dev
  68 2011-07-29T14:54:08  *** m4k3r has quit IRC
  69 2011-07-29T15:18:31  <brunomartin> ThomasWaldmann: Hi! Sorry but I could not test you patch, neither file the image display bug.. I'm gonna travel today, so I think I you do it only on monday....
  70 2011-07-29T15:23:47  <ThomasWaldmann> dreimark: that bug does not even include the traceback it is complaining about
  71 2011-07-29T15:24:21  <ThomasWaldmann> so, i want to see the traceback first.
  72 2011-07-29T15:24:54  <ThomasWaldmann> brunomartin: no problem
  73 2011-07-29T15:48:17  *** greg_f has quit IRC
  74 2011-07-29T15:51:14  *** greg_f has joined #moin-dev
  75 2011-07-29T16:49:36  *** m4k3r_ has quit IRC
  76 2011-07-29T16:51:22  *** m4k3r has joined #moin-dev
  77 2011-07-29T17:08:39  *** pkumar has joined #moin-dev
  78 2011-07-29T17:13:26  *** brunomartin has left #moin-dev
  79 2011-07-29T17:14:21  <pkumar> xorAxAx: hi, I was writing a test for Text._render_data_diff_text() and I got this. please have a look at it. http://paste.pocoo.org/show/448847/.
  80 2011-07-29T17:15:22  <pkumar> xorAxAx : the problem here is statement  - line 27 data_text.split(u'\n') gives a result of type list
  81 2011-07-29T17:15:39  <xorAxAx> pkumar: hmm, looks like the split is wrong
  82 2011-07-29T17:15:44  <xorAxAx> pkumar: try without it
  83 2011-07-29T17:15:48  <pkumar> which further generates Type error in _util
  84 2011-07-29T17:16:14  <pkumar> now this was not the case earlier, seems like the latest changes of thomas
  85 2011-07-29T17:16:49  <pkumar> earlier there was statement  - content = u'\n'.join(content) in
  86 2011-07-29T17:16:59  <pkumar> pygments_in
  87 2011-07-29T17:17:20  <pkumar> which used to take care of this list type
  88 2011-07-29T17:17:26  <pkumar> I guess
  89 2011-07-29T17:17:45  <xorAxAx> well, then the correct interface type should be found out by you and the code be corrected :)
  90 2011-07-29T17:17:52  <xorAxAx> but i guess that passing a list is wrong
  91 2011-07-29T17:18:00  <xorAxAx> also feel free to ask ThomasWaldmann
  92 2011-07-29T17:19:28  <pkumar> Actually, the passing of list would have worked with the previous code(though there are several upgrades of the code) due to join statement
  93 2011-07-29T17:19:46  <pkumar> ThomasWaldmann : ^
  94 2011-07-29T17:21:14  <pkumar> ThomasWaldmann : can you please have a look at http://paste.pocoo.org/show/448847/
  95 2011-07-29T17:27:00  <pkumar> xorAxAx : on my request, waldi had had look at hardy89's repo. seems like his chagesets won't be of much se to us
  96 2011-07-29T17:27:10  <xorAxAx> pkumar: yeah
  97 2011-07-29T17:27:13  <pkumar> use*
  98 2011-07-29T17:28:19  <pkumar> xorAxAx : now as I've merged his chagesets, what would you suggest to do with that?
  99 2011-07-29T17:28:35  <xorAxAx> pkumar: you mean you want to undo the merge?
 100 2011-07-29T17:28:53  <pkumar> yeah, that particular merge,
 101 2011-07-29T17:29:24  <xorAxAx> backout them
 102 2011-07-29T17:30:31  <pkumar> xorAxAx : I don't think I've much idea about this backout thing. I just tried mq and it didn.t work
 103 2011-07-29T17:30:46  <xorAxAx> hg backout
 104 2011-07-29T17:30:46  <pkumar> can you please tell me
 105 2011-07-29T17:30:49  <pkumar> ?
 106 2011-07-29T17:30:49  <xorAxAx> $REV
 107 2011-07-29T17:30:58  <xorAxAx> mq is something entirely different
 108 2011-07-29T17:33:11  <pkumar> I was trying to delete those using mq. anyway, how does  parent and the children of the particular revision is handeled
 109 2011-07-29T17:33:20  <pkumar> xorAxAx : ^
 110 2011-07-29T17:33:49  <xorAxAx> just use backout, it will apply them reversely on your main branch
 111 2011-07-29T17:34:06  <pkumar> lemme try
 112 2011-07-29T17:35:44  <pkumar> k, thanx
 113 2011-07-29T18:01:18  <pkumar> bbl
 114 2011-07-29T18:10:17  *** m4k3r has quit IRC
 115 2011-07-29T18:11:48  *** m4k3r has joined #moin-dev
 116 2011-07-29T18:20:19  *** Marchael has joined #moin-dev
 117 2011-07-29T18:39:15  *** greg_f has quit IRC
 118 2011-07-29T18:45:22  *** raignarok has quit IRC
 119 2011-07-29T19:09:59  <pkumar> re
 120 2011-07-29T19:19:08  *** m4k3r has quit IRC
 121 2011-07-29T19:23:49  *** m4k3r has joined #moin-dev
 122 2011-07-29T19:42:25  *** m4k3r has quit IRC
 123 2011-07-29T19:44:15  *** m4k3r has joined #moin-dev
 124 2011-07-29T19:54:35  *** m4k3r has quit IRC
 125 2011-07-29T19:56:34  *** m4k3r has joined #moin-dev
 126 2011-07-29T20:01:36  *** m4k3r has quit IRC
 127 2011-07-29T20:04:50  *** raignarok has joined #moin-dev
 128 2011-07-29T20:16:20  *** pkumar has quit IRC
 129 2011-07-29T20:29:57  *** Marchael has quit IRC
 130 2011-07-29T20:32:53  <ThomasWaldmann> re
 131 2011-07-29T20:40:27  *** raignarok has quit IRC
 132 2011-07-29T21:11:01  <dreimark> re
 133 2011-07-29T21:11:45  <dreimark> ThomasWaldmann: i add it later
 134 2011-07-29T21:12:01  <dreimark> *traceback
 135 2011-07-29T21:12:32  *** m4k3r has joined #moin-dev
 136 2011-07-29T21:40:12  *** m4k3r has quit IRC
 137 2011-07-29T21:42:15  *** m4k3r has joined #moin-dev
 138 2011-07-29T21:51:48  *** sinha has joined #moin-dev
 139 2011-07-29T22:33:22  *** m4k3r has quit IRC
 140 2011-07-29T22:35:15  *** m4k3r has joined #moin-dev
 141 2011-07-29T23:02:18  *** m4k3r_ has joined #moin-dev
 142 2011-07-29T23:02:43  *** m4k3r has quit IRC
 143 2011-07-29T23:27:35  *** sinha has quit IRC
 144 2011-07-29T23:49:10  *** xorAxAx has quit IRC
 145 2011-07-29T23:49:52  *** xorAxAx has joined #moin-dev
 146

MoinMoin: MoinMoinChat/Logs/moin-dev/2011-07-29 (last edited 2011-07-28 22:45:03 by IrcLogImporter)