1 2011-08-01T00:12:56 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 299:a50ded41a60d 2.0/setup.py: as long as xstatic api doesn't change in an incompatible way, we can just have minimum requirements for the packages
2 2011-08-01T01:07:41 *** MattMaker
3 2011-08-01T01:22:56 *** MattMaker
4 2011-08-01T01:28:12 *** MattMaker
5 2011-08-01T01:37:03 *** raignarok
6 2011-08-01T01:39:41 *** MattMaker
7 2011-08-01T01:45:25 *** MattMaker
8 2011-08-01T01:51:52 *** MattMaker
9 2011-08-01T02:26:31 *** MattMaker
10 2011-08-01T04:08:01 *** MattMaker
11 2011-08-01T06:11:36 *** Marchael
12 2011-08-01T06:12:36 <Marchael> moin
13 2011-08-01T06:13:08 <Marchael> ThomasWaldmann: sorry, me was travelling last 4 days
14 2011-08-01T07:37:13 *** m4k3r
15 2011-08-01T07:40:23 *** pkumar
16 2011-08-01T07:51:18 *** m4k3r_
17 2011-08-01T07:52:41 *** m4k3r
18 2011-08-01T07:59:22 *** m4k3r_
19 2011-08-01T08:03:02 *** m4k3r
20 2011-08-01T08:12:41 *** m4k3r
21 2011-08-01T08:45:51 *** sinha
22 2011-08-01T09:31:29 <Marchael> m, seems like whoosh can't pickling objects passng to analyzers/tokenizers
23 2011-08-01T09:31:43 <Marchael> like moin config
24 2011-08-01T09:32:53 <Marchael> If i pass config to acl tokenizer i get something like this http://paste.pocoo.org/show/450374/
25 2011-08-01T09:33:29 <Marchael> Can't pickle <class 'config.Config'>: import of module config failed
26 2011-08-01T09:33:29 <Marchael> means what whoosh can't pickle config
27 2011-08-01T09:34:12 <Marchael> oops, sorry for obvious :)
28 2011-08-01T09:40:04 <pkumar> ThomasWaldmann : moin, can you please tell me if this is a typo or it is like that: http://paste.pocoo.org/show/450380/ line 9. I'm not sure if it should be context_block instead of content_block
29 2011-08-01T09:43:47 <pkumar> above one is from macro._base
30 2011-08-01T10:03:56 *** m4k3r
31 2011-08-01T10:07:49 <sinha> dreimark: updated that jfu script, now only unique files will be uploaded during the selection, http://codereview.appspot.com/4832043
32 2011-08-01T10:52:48 *** raignarok
33 2011-08-01T10:57:24 *** pkumar
34 2011-08-01T11:17:37 *** greg_f
35 2011-08-01T11:22:44 *** m4k3r
36 2011-08-01T11:24:49 <dreimark> moin
37 2011-08-01T11:34:09 <dreimark> sinha: done
38 2011-08-01T11:34:20 *** m4k3r
39 2011-08-01T11:51:49 *** Marchael
40 2011-08-01T12:09:09 *** Marchael
41 2011-08-01T12:56:46 *** m4k3r
42 2011-08-01T12:58:52 *** m4k3r
43 2011-08-01T13:12:06 *** m4k3r
44 2011-08-01T13:19:13 *** m4k3r
45 2011-08-01T13:24:27 *** m4k3r
46 2011-08-01T13:28:41 *** greg_f
47 2011-08-01T13:31:19 <CIA-114> Akash Sinha <akash2607@gmail.com> * 391944573fc3 r344 default/MoinMoin/static/js/jfu.js: ajax file upload script updated, now only unique files could be uploaded during a upload
48 2011-08-01T13:36:26 *** m4k3r
49 2011-08-01T13:39:49 *** greg_f
50 2011-08-01T13:48:01 *** brunomartin
51 2011-08-01T14:06:53 *** sinha
52 2011-08-01T14:15:10 *** m4k3r
53 2011-08-01T14:36:12 *** raignarok
54 2011-08-01T14:40:14 <ThomasWaldmann> re
55 2011-08-01T14:42:43 <ThomasWaldmann> pkumar: xorAxAx: i think it should be context_block in line 9 of http://paste.pocoo.org/show/450380/
56 2011-08-01T14:43:21 <ThomasWaldmann> Marchael: you solved your issues?
57 2011-08-01T14:45:52 <Marchael> ThomasWaldmann: I made some refactoring in WhooshIndex() http://codereview.appspot.com/4798066 but I found what whoosh can't use dump() (from pickle) to store Config.config http://paste.pocoo.org/show/450374/
58 2011-08-01T14:46:15 <Marchael> it's related with acl tokenizer
59 2011-08-01T14:58:06 <ThomasWaldmann> what is that _ change for?
60 2011-08-01T15:00:42 <Marchael> I use _ for internal values what should not used outside WhooshIndex class
61 2011-08-01T15:01:13 <ThomasWaldmann> so it is a cosmetic change unrelated to your current work?
62 2011-08-01T15:01:55 <Marchael> mm, costetic change is only part of them
63 2011-08-01T15:02:20 <Marchael> i try to pass app.cfg to AclTokenizer
64 2011-08-01T15:02:49 <Marchael> to __init__, but pickle can't dumps() it
65 2011-08-01T15:03:04 <ThomasWaldmann> what i mean is that you should not mess up your changesets
66 2011-08-01T15:03:36 <ThomasWaldmann> if you are trying to solve some difficult problem, you just solve that and not change cosmetics of your sourcecode at the same time
67 2011-08-01T15:04:02 <ThomasWaldmann> making the diff much bigger to review than needed
68 2011-08-01T15:04:29 <Marchael> ok. I do clean changeset
69 2011-08-01T15:04:42 <ThomasWaldmann> (and the opposite thing is of course also true: if you are doing cosmetic changes, you ONLY do cosmetic changes, not solve other problems at the same time)
70 2011-08-01T15:07:17 *** m4k3r
71 2011-08-01T15:10:52 <ThomasWaldmann> Marchael: review done
72 2011-08-01T15:17:59 *** m4k3r_
73 2011-08-01T15:19:37 *** m4k3r
74 2011-08-01T15:22:49 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4798066/ patchset 2
75 2011-08-01T15:38:04 *** Marchael
76 2011-08-01T15:38:09 *** Marchael
77 2011-08-01T15:39:23 <ThomasWaldmann> Marchael: your changeset does unintended changes
78 2011-08-01T15:41:57 <ThomasWaldmann> but better than the first cs
79 2011-08-01T15:42:24 <Marchael> hm, please point me to them in review
80 2011-08-01T15:47:32 <ThomasWaldmann> you added or removed empty lines
81 2011-08-01T15:47:39 *** m4k3r_
82 2011-08-01T15:48:11 <ThomasWaldmann> and you should see such stuff yourself when using hg diff | less
83 2011-08-01T15:48:38 *** m4k3r
84 2011-08-01T15:51:13 * Marchael see only one removed empty line in diff, because it divided one import block
85 2011-08-01T15:54:15 <ThomasWaldmann> yes
86 2011-08-01T16:10:24 <dreimark> bbl
87 2011-08-01T16:16:27 <Marchael> ThomasWaldmann: so, you have idea about pickle issue?
88 2011-08-01T16:18:26 <ThomasWaldmann> Marchael: yes. it needs some change in the acl system, I'll do that.
89 2011-08-01T16:20:20 <ThomasWaldmann> for now, you just make a small changeset that comments the acl fields in the schemas (with #...), commit comment "temporarily remove acl fields from the schema due to pickle issues"
90 2011-08-01T16:21:11 <Marchael> ok
91 2011-08-01T16:21:14 <ThomasWaldmann> and then just work on something different
92 2011-08-01T16:21:51 <ThomasWaldmann> you can apply your changeset as in the last review without those unneeded whitespace changes
93 2011-08-01T16:22:07 <ThomasWaldmann> we'll need that change later then
94 2011-08-01T16:56:06 *** pkumar
95 2011-08-01T16:56:16 *** sinha
96 2011-08-01T17:05:10 <Marchael> ThomasWaldmann: I constantly having conflicts with your changes in setup.py. I added whoosh there and i can't merge without deleting it. Is there something way to avoid this conflicts?
97 2011-08-01T17:05:53 <ThomasWaldmann> if a conflict does not resolve automatically (can happen, as you have seen), you have to resolve it manually
98 2011-08-01T17:06:23 <ThomasWaldmann> and you only have to do that once, per conflict
99 2011-08-01T17:06:35 <Marchael> hm, remove-commit, merge-commit, add-commit/
100 2011-08-01T17:06:37 <Marchael> ?
101 2011-08-01T17:12:59 <ThomasWaldmann> $ hg resolve --help
102 2011-08-01T17:22:33 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 1e9ec607913d r356 moin-2.0/MoinMoin/util/send_file.py: fix downloading of items with non-ascii names (for most modern browsers), implement RFC2231/5987
103 2011-08-01T17:22:35 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 0adc626b1036 r357 moin-2.0/setup.py: setup.py: change requirement to werkzeug >= 0.6.2 after successful test with 0.7.1
104 2011-08-01T17:22:36 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 07143bd03aed r358 moin-2.0/MoinMoin/items/__init__.py: fix pygments converter call for new converter api
105 2011-08-01T17:22:36 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * a50ded41a60d r359 moin-2.0/setup.py: as long as xstatic api doesn't change in an incompatible way, we can just have minimum requirements for the packages
106 2011-08-01T17:22:36 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * f720cf1e8969 r360 moin-2.0/setup.py: fixing multiple heads
107 2011-08-01T17:22:36 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 0fd6527bd6aa r361 moin-2.0/ (3 files in 3 dirs): merged
108 2011-08-01T17:22:36 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * ea543ad2fb6c r362 moin-2.0/MoinMoin/ (3 files in 2 dirs): temporarily remove acl fields from the schema due to pickle issues
109 2011-08-01T17:22:36 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 8b39c8a2140e r363 moin-2.0/setup.py: return whoosh back
110 2011-08-01T17:25:05 <ThomasWaldmann> you please use whoosh>=2.0.0
111 2011-08-01T17:25:15 <ThomasWaldmann> or whatever the current minimum requirement is
112 2011-08-01T17:25:44 <ThomasWaldmann> we only use == with good reasons (e.g. if a later release does not work for us)
113 2011-08-01T17:26:24 <Marchael> m, that's why I add ==
114 2011-08-01T17:26:53 <ThomasWaldmann> ???
115 2011-08-01T17:28:02 <ThomasWaldmann> btw, your merge changeset was a unclean merge. please learn how to do it correctly for next time.
116 2011-08-01T17:28:53 <ThomasWaldmann> btw, there is a free hgbook on the web that answers about any question one has about hg
117 2011-08-01T17:30:08 <Marchael> ok
118 2011-08-01T17:30:51 * Marchael not sure what latest whoosh releases will compatible with our patch
119 2011-08-01T17:31:11 <ThomasWaldmann> usually you can assume compatibility
120 2011-08-01T17:31:14 <Marchael> so I just leave it 2.0.0 until Matt will release new whoosh version
121 2011-08-01T17:31:50 <ThomasWaldmann> and he likely will release a new version with fixes soon. as we want to get such fixes, you should use >=2.0.0
122 2011-08-01T17:32:09 <Marchael> ok, add on next commit
123 2011-08-01T17:32:56 <Marchael> gtg/bbl
124 2011-08-01T17:33:27 *** Marchael
125 2011-08-01T17:44:49 *** m4k3r
126 2011-08-01T18:19:58 *** Marchael
127 2011-08-01T18:20:13 <Marchael> re
128 2011-08-01T18:30:43 <Marchael> ThomasWaldmann: I should use this for creating indexable content? https://bitbucket.org/thomaswaldmann/moin-2.0/src/5158f027bb3f/MoinMoin/apps/frontend/views.py#cl-204
129 2011-08-01T18:30:43 <Marchael> but this function using flaskg
130 2011-08-01T18:51:39 <sinha> dreimark: when a changed the drop zone from that green box to whole white space, then the plugin isnt fabricating the upload form and this is is coming like this http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-08-01?action=AttachFile&do=get&target=upload.png
131 2011-08-01T18:51:47 <sinha> should i beautify it manually ?
132 2011-08-01T18:57:17 *** m4k3r
133 2011-08-01T18:57:20 *** sinha
134 2011-08-01T18:58:39 <ThomasWaldmann> Marchael: see my commits from a week ago or so
135 2011-08-01T18:59:20 * ThomasWaldmann currently modifies AccessControlLists, so they don't need cfg
136 2011-08-01T19:14:16 <Marchael> ThomasWaldmann: oh cool! Your converters works great!
137 2011-08-01T19:14:22 <Marchael> almost
138 2011-08-01T19:14:45 <ThomasWaldmann> hehe
139 2011-08-01T19:14:49 *** sinha
140 2011-08-01T19:16:23 <Marchael> http://paste.pocoo.org/show/450641/ There is traceback, I put my changes soon
141 2011-08-01T19:17:58 <ThomasWaldmann> yup, that needs fixing
142 2011-08-01T19:18:10 <Marchael> there is http://codereview.appspot.com/4835045
143 2011-08-01T19:18:37 <Marchael> It's not critical, moin working with that
144 2011-08-01T19:18:49 <Marchael> and most documents were indexed
145 2011-08-01T19:19:43 <Marchael> I'll remove convert_data() and will user convert_to_indexable() instead
146 2011-08-01T19:20:39 *** sinha
147 2011-08-01T19:20:56 <ThomasWaldmann> Marchael: yes, remove convert_data, that was an older try
148 2011-08-01T19:28:57 *** m4k3r_
149 2011-08-01T19:31:16 *** m4k3r
150 2011-08-01T19:33:56 *** m4k3r
151 2011-08-01T19:35:21 *** m4k3r_
152 2011-08-01T19:44:51 *** greg_f
153 2011-08-01T19:54:28 <pkumar> xorAxAx : hi, what is arguments.positional in http://paste.pocoo.org/show/450666/ in line 9
154 2011-08-01T19:54:51 <pkumar> the code is from macro.GetText
155 2011-08-01T19:55:39 <pkumar> arguments I guess can be either list or string I guess
156 2011-08-01T20:11:00 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 300:e8bd41ab7bdd 2.0/MoinMoin/ (9 files in 7 dirs): (log message trimmed)
157 2011-08-01T20:11:00 <CIA-114> AccessControlList: do not require cfg object
158 2011-08-01T20:11:00 <CIA-114> Giving the cfg to the ACL object caused some issues (for example, the AclTokenizer
159 2011-08-01T20:11:00 <CIA-114> in the whoosh branch needed cfg and was part of the schema. whoosh tries to
160 2011-08-01T20:11:00 <CIA-114> pickle the schema and that did not work for cfg).
161 2011-08-01T20:11:00 <CIA-114> Refactored "auth_trusted" - this is now a user object attribute, so the ACL
162 2011-08-01T20:11:01 <CIA-114> code does not need to know the list of trusted auth methods (which is still in
163 2011-08-01T20:11:01 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 301:7ed1945aeb03 2.0/ (MoinMoin/items/__init__.py setup.py): merged main
164 2011-08-01T20:11:13 <ThomasWaldmann> Marchael: try that ^^
165 2011-08-01T20:11:28 <Marchael> ok
166 2011-08-01T20:11:40 <ThomasWaldmann> and read the full commit comment
167 2011-08-01T20:11:59 <ThomasWaldmann> gtg / brb
168 2011-08-01T20:13:30 <Marchael> ThomasWaldmann: patchset 2 http://codereview.appspot.com/4835045
169 2011-08-01T20:13:32 <Marchael> hm
170 2011-08-01T20:15:05 <Marchael> ThomasWaldmann: but I got this traceback http://paste.pocoo.org/show/450677/
171 2011-08-01T20:15:43 <Marchael> for some reason backend revision doesn't passed to revision_converter
172 2011-08-01T20:43:28 <ThomasWaldmann> you are likely confusing revno and rev
173 2011-08-01T20:45:31 *** pkumar
174 2011-08-01T20:50:03 *** m4k3r_
175 2011-08-01T20:51:56 *** m4k3r
176 2011-08-01T21:02:26 <Marchael> ThomasWaldmann: but I printing rev_no and rev
177 2011-08-01T21:06:07 <ThomasWaldmann> you know what "self" is for?
178 2011-08-01T21:07:07 <Marchael> oh, shi
179 2011-08-01T21:07:13 <Marchael> oops
180 2011-08-01T21:07:38 * Marchael doesn't see so obious thing
181 2011-08-01T21:07:46 <Marchael> *obvious
182 2011-08-01T21:09:04 *** brunomartin
183 2011-08-01T21:12:36 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4835045/ patchset 3
184 2011-08-01T21:22:11 <Marchael> ThomasWaldmann: hm, may be better move backend_to_index to MoinMoin.search.indexing?
185 2011-08-01T21:22:24 <Marchael> as class method
186 2011-08-01T21:24:34 <Marchael> Althought, it's not neccessary to create WhooshIndex object to call this
187 2011-08-01T21:28:09 <ThomasWaldmann> at least the module sounds right
188 2011-08-01T21:29:18 <Marchael> ok, I changed docstring. May I commit this?
189 2011-08-01T21:31:49 <dreimark> re
190 2011-08-01T21:33:37 <ThomasWaldmann> does it work? :)
191 2011-08-01T21:33:47 <ThomasWaldmann> hi dreimark
192 2011-08-01T21:34:15 <Marchael> at least moin starts successfull :D
193 2011-08-01T21:35:40 <ThomasWaldmann> ok
194 2011-08-01T21:35:50 *** brunomartin
195 2011-08-01T21:36:14 <Marchael> but this traceback, what cause it?
196 2011-08-01T21:36:23 <dreimark> good that we have diary pages whith included mailings ;)
197 2011-08-01T21:36:34 * dreimark sends the answer by that
198 2011-08-01T21:44:20 *** sinha
199 2011-08-01T21:45:20 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * c5cc63fd82f6 r364 moin-2.0/ (4 files in 4 dirs):
200 2011-08-01T21:45:20 <CIA-114> Content indexing support
201 2011-08-01T21:45:20 <CIA-114> - backend_to_index() moved to MoinMoin.search.revision_converter and can be used from other places
202 2011-08-01T21:45:20 <CIA-114> - Using plain text converters(thanks Thomas Waldmann) for creating indexable output
203 2011-08-01T21:45:23 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * e8bd41ab7bdd r365 moin-2.0/MoinMoin/ (9 files in 7 dirs): (log message trimmed)
204 2011-08-01T21:45:23 <CIA-114> AccessControlList: do not require cfg object
205 2011-08-01T21:45:23 <CIA-114> Giving the cfg to the ACL object caused some issues (for example, the AclTokenizer
206 2011-08-01T21:45:23 <CIA-114> in the whoosh branch needed cfg and was part of the schema. whoosh tries to
207 2011-08-01T21:45:23 <CIA-114> pickle the schema and that did not work for cfg).
208 2011-08-01T21:45:23 <CIA-114> Refactored "auth_trusted" - this is now a user object attribute, so the ACL
209 2011-08-01T21:45:24 <CIA-114> code does not need to know the list of trusted auth methods (which is still in
210 2011-08-01T21:45:24 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 7ed1945aeb03 r366 moin-2.0/ (setup.py MoinMoin/items/__init__.py): merged main
211 2011-08-01T21:45:25 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 2305be335d83 r367 moin-2.0/MoinMoin/ (9 files in 7 dirs): merged
212 2011-08-01T21:46:41 * Marchael looks to new access control lists
213 2011-08-01T21:48:29 *** MattMaker
214 2011-08-01T21:56:51 *** m4k3r_
215 2011-08-01T22:08:59 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/450748/ that's happening when I trying to create html item with "acl": "-MinusGuy:read"
216 2011-08-01T22:11:22 <Marchael> there is a code http://codereview.appspot.com/4808067
217 2011-08-01T22:27:12 <Marchael> gn/bbl
218 2011-08-01T22:35:46 <ThomasWaldmann> ah, right, that's missing still
219 2011-08-01T22:36:33 *** sinha
220 2011-08-01T22:47:00 *** MattMaker
221 2011-08-01T22:53:03 *** m4k3r
222 2011-08-01T23:28:31 *** MattMaker
223 2011-08-01T23:28:48 *** m4k3r_
224 2011-08-01T23:30:35 *** m4k3r
225 2011-08-01T23:40:37 <xorAxAx> pkumar, good question, blame the code to see who changed the code and how it was before the change
226 2011-08-01T23:47:28 *** m4k3r_
227
