1 2011-08-06T00:00:12 <Marchael> I don't see this bug on my issue tracker because it appeared after backend_to_index() moving
2 2011-08-06T00:01:23 <Marchael> I also applied your fix there, great thanks!
3 2011-08-06T00:10:38 <ThomasWaldmann> see review
4 2011-08-06T00:10:53 <Marchael> yes, I answered
5 2011-08-06T00:11:44 <Marchael> but I have no idea why whoosh index appeared in wiki/index after moin index --for ... --action build
6 2011-08-06T00:12:31 <Marchael> and all docs that were loaded is preloaded items
7 2011-08-06T00:17:06 <ThomasWaldmann> well, usually this is load_xml
8 2011-08-06T00:18:13 <Marchael> but I disabled it
9 2011-08-06T00:18:24 <Marchael> load_xml = None
10 2011-08-06T00:18:27 <Marchael> in wikiconfig
11 2011-08-06T00:19:09 <ThomasWaldmann> that load_xml stuff will get removed later anyway, same for index_rebuild
12 2011-08-06T00:19:17 <ThomasWaldmann> so just go on with your stuff
13 2011-08-06T00:19:56 <Marchael> but then why this indexes appeared?
14 2011-08-06T00:20:02 <Marchael> they shouldn't
15 2011-08-06T00:23:07 <Marchael> ok, may I commit this?
16 2011-08-06T00:23:12 <ThomasWaldmann> did you have load_xml = None when you ran moin index build?
17 2011-08-06T00:23:38 <ThomasWaldmann> no, it's wrong
18 2011-08-06T00:23:39 <Marchael> yes
19 2011-08-06T00:24:27 <Marchael> but I don't open whoosh index in wiki/index
20 2011-08-06T00:24:36 <Marchael> in script
21 2011-08-06T00:24:57 <Marchael> index_object = WhooshIndex(index_dir=app.cfg.index_dir_tmp)
22 2011-08-06T00:29:40 <ThomasWaldmann> can you please concentrate on fixing your stuff and not stuff that will go away anyway?
23 2011-08-06T00:29:57 <ThomasWaldmann> you don't have much time left and you're wasting it
24 2011-08-06T00:30:32 <Marchael> mm, but without that fixes content indexing by scipt doesn't working
25 2011-08-06T00:30:42 <Marchael> *by script
26 2011-08-06T00:31:32 *** RogerHaase
27 2011-08-06T00:31:36 <Marchael> because in previous versions backend_to_index() used conver_to_indexable
28 2011-08-06T00:32:32 <Marchael> I should ignore that for now?
29 2011-08-06T00:34:03 <ThomasWaldmann> on CR i just pointed you to a major issue, why don't you start with fixing that?
30 2011-08-06T00:35:10 *** sinha
31 2011-08-06T00:36:35 <Marchael> ehrm, you give me that link https://bitbucket.org/marchael/moin-2.0/issue/9/content-entered-via-wiki-ui-is-not-indexed, and I used your patch to fix that in http://codereview.appspot.com/4810076/patch/1/3
32 2011-08-06T00:36:35 <Marchael> in additional I made some fixes in building\updating script
33 2011-08-06T00:37:07 <Marchael> http://codereview.appspot.com/4810076/patch/1/2
34 2011-08-06T00:39:04 <ThomasWaldmann> see there, i added one more comment
35 2011-08-06T00:45:17 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4810076/ ps 2
36 2011-08-06T00:46:44 <ThomasWaldmann> well, that'ld fix the crash, but obviously you did not think about it enough, because that all is rather inefficient there.
37 2011-08-06T00:47:39 <Marchael> ok, I try again
38 2011-08-06T00:52:50 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4810076/ ps 3
39 2011-08-06T01:03:13 <ThomasWaldmann> no
40 2011-08-06T01:04:25 <ThomasWaldmann> what you need there is to first check whether all-revs index should be updated (and ONLY then work on every revision) and ELSE, just fetch revno==-1
41 2011-08-06T01:05:00 <Marchael> ah
42 2011-08-06T01:05:10 <ThomasWaldmann> otherwise (like ps 3), you'll do lots of useless computation if all-revs index is not built, only latest revs
43 2011-08-06T01:15:15 <Marchael> hm, runs much faster
44 2011-08-06T01:15:41 <Marchael> ThomasWaldmann: ps 4
45 2011-08-06T01:19:48 <ThomasWaldmann> better, one small comment there
46 2011-08-06T01:21:11 <Marchael> ThomasWaldmann: yes, I know. But as you can see later I pass rev_no parameter to backend_to_index
47 2011-08-06T01:21:19 <Marchael> so, I can't use -1 here
48 2011-08-06T01:22:40 <ThomasWaldmann> hmm, maybe try getting it using -1 and then check the value of revision.rev_no or so.
49 2011-08-06T01:23:24 <Marchael> hm, backend revision hasn't rev_no
50 2011-08-06T01:23:34 <Marchael> I mean revision number at all
51 2011-08-06T01:23:47 <ThomasWaldmann> revno? iirc there was something.
52 2011-08-06T01:26:03 <Marchael> something like?
53 2011-08-06T01:29:19 <ThomasWaldmann> revno
54 2011-08-06T01:29:32 <Marchael> ok
55 2011-08-06T01:39:54 <Marchael> ThomasWaldmann: ps 5
56 2011-08-06T01:54:49 <ThomasWaldmann> just a small comment, otherwise looks ok. try it, commit if it works.
57 2011-08-06T01:57:09 <Marchael> yes, that's user item
58 2011-08-06T01:57:43 <Marchael> ThomasWaldmann: should I correct my comment?
59 2011-08-06T02:03:21 <ThomasWaldmann> # item has no such revision
60 2011-08-06T02:03:37 <ThomasWaldmann> btw, that exception handler has a quite wide scope
61 2011-08-06T02:07:46 *** brunomartin
62 2011-08-06T02:08:05 *** brunomartin
63 2011-08-06T02:08:20 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * ea001bcb5f90 r390 moin-2.0/MoinMoin/ (script/maint/index.py storage/backends/indexing.py):
64 2011-08-06T02:08:20 <CIA-114> Fixed issue with runtime indexation https://bitbucket.org/marchael/moin-2.0/issue/9/content-entered-via-wiki-ui-is-not-indexed
65 2011-08-06T02:08:20 <CIA-114> Fixes issue with content indexing in building\updating script
66 2011-08-06T02:12:40 <ThomasWaldmann> ok, works
67 2011-08-06T02:13:13 <Marchael> ok, now I need to deal with serch form
68 2011-08-06T02:13:19 <ThomasWaldmann> and if you just say "Fixes #9." it would close and interlink that issue automatically.
69 2011-08-06T02:13:23 <Marchael> I mean https://bitbucket.org/marchael/moin-2.0/issue/6/unpretty-search-results-rendering
70 2011-08-06T02:15:09 <ThomasWaldmann> yes, just do it :)
71 2011-08-06T02:19:13 <Marchael> ThomasWaldmann: http://i.imgur.com/FPgA7.png
72 2011-08-06T02:20:48 <Marchael> http://codereview.appspot.com/4843046
73 2011-08-06T02:29:15 <Marchael> ThomasWaldmann: ping
74 2011-08-06T02:37:49 <ThomasWaldmann> yup, much better already
75 2011-08-06T02:38:21 <ThomasWaldmann> i am thinking whether that floating results stats there would look better at the very top content border
76 2011-08-06T02:39:31 <ThomasWaldmann> and as you show the query now rather big in that input field, we maybe don't need to say that "Results for search 'Home'" any more.
77 2011-08-06T02:39:57 <Marchael> ok
78 2011-08-06T02:47:16 <Marchael> ThomasWaldmann: http://i.imgur.com/RAalW.png
79 2011-08-06T02:48:08 <Marchael> don't look on random signs on search input
80 2011-08-06T02:54:22 <Marchael> ThomasWaldmann: ps 2
81 2011-08-06T02:55:41 <ThomasWaldmann> hmm, can you move it more to the top
82 2011-08-06T02:56:19 <Marchael> it?
83 2011-08-06T02:57:21 <Marchael> If you move it to header, then we need to change some stuff in layout.html or so
84 2011-08-06T02:57:32 <Marchael> *If you want
85 2011-08-06T02:58:05 <ThomasWaldmann> no, just at top of content area
86 2011-08-06T02:58:21 <ThomasWaldmann> or maybe just get rid of that hor. line
87 2011-08-06T02:59:03 <Marchael> mm
88 2011-08-06T02:59:57 <Marchael> ThomasWaldmann: you input query form?
89 2011-08-06T03:00:06 <Marchael> *you mean
90 2011-08-06T03:01:54 <ThomasWaldmann> no, the search result stats line
91 2011-08-06T03:07:00 <Marchael> ThomasWaldmann: it's looking ugly
92 2011-08-06T03:07:01 <Marchael> http://i.imgur.com/6fyDI.png
93 2011-08-06T03:07:28 *** MattMaker
94 2011-08-06T03:07:30 <Marchael> for me it's looking good 'as is'
95 2011-08-06T03:09:36 <ThomasWaldmann> http://awesomescreenshot.com/070i14fc5
96 2011-08-06T03:10:29 <Marchael> and?
97 2011-08-06T03:10:51 <ThomasWaldmann> it looks bad where the pointers end
98 2011-08-06T03:11:11 <Marchael> so what should I do with that? remove background?
99 2011-08-06T03:12:13 <ThomasWaldmann> no idea, i rarely deal with css. if you don't know, just provide the item_name to get rid of that "title".
100 2011-08-06T03:13:29 *** MattMaker
101 2011-08-06T03:15:00 <Marchael> ThomasWaldmann: http://i.imgur.com/QRX1s.png
102 2011-08-06T03:15:17 <Marchael> how I can change "handlers need to give it?"
103 2011-08-06T03:16:18 <ThomasWaldmann> i just told you
104 2011-08-06T03:17:21 <Marchael> m?
105 2011-08-06T03:17:43 <ThomasWaldmann> just provide the item_name to get rid of that "title"
106 2011-08-06T03:17:49 <Marchael> aa
107 2011-08-06T03:18:05 <ThomasWaldmann> as a param to the render call, see how other templates are rendered.
108 2011-08-06T03:18:50 <Marchael> and what about search stats?
109 2011-08-06T03:19:57 <ThomasWaldmann> leave it as it is currently
110 2011-08-06T03:21:14 <Marchael> as in latest screenshot you mean?
111 2011-08-06T03:21:25 <ThomasWaldmann> yes
112 2011-08-06T03:21:41 <Marchael> ok
113 2011-08-06T03:23:50 <Marchael> I passed item_name to render_template, but on template it was appeared as link to unexisting object
114 2011-08-06T03:24:38 <Marchael> Is there a way how to make it non linkable, or just leave as is?
115 2011-08-06T03:26:30 <ThomasWaldmann> if you display the current item name, it may be linkable
116 2011-08-06T03:26:46 <Marchael> http://i.imgur.com/JYwk6.png
117 2011-08-06T03:27:20 <ThomasWaldmann> that's not the current item name
118 2011-08-06T03:27:42 <ThomasWaldmann> what's the url of that?
119 2011-08-06T03:28:06 <Marchael> http://localhost:8080/Searching
120 2011-08-06T03:28:24 <Marchael> We can use it for link to HelpToSearch or something
121 2011-08-06T03:28:38 <Marchael> or HelpOnSearching
122 2011-08-06T03:28:41 <ThomasWaldmann> not really
123 2011-08-06T03:28:57 <ThomasWaldmann> we won't have such help pages any more in moin2
124 2011-08-06T03:30:09 <ThomasWaldmann> use the current item name
125 2011-08-06T03:31:18 <Marchael> so user just get back on previous page, right>
126 2011-08-06T03:31:21 <Marchael> ?
127 2011-08-06T03:31:40 <ThomasWaldmann> yes
128 2011-08-06T03:32:08 <ThomasWaldmann> but that's better than something misleading or an error msg
129 2011-08-06T03:33:19 <Marchael> done
130 2011-08-06T03:34:43 <Marchael> http://i.imgur.com/Ojzql.png
131 2011-08-06T03:37:20 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4843046/ ps 3
132 2011-08-06T03:37:41 <ThomasWaldmann> fine, commit
133 2011-08-06T03:38:18 <ThomasWaldmann> don't forget "... Fixes #6."
134 2011-08-06T03:40:38 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 215d7a8f5b3e r391 moin-2.0/MoinMoin/ (3 files in 3 dirs):
135 2011-08-06T03:40:38 <CIA-114> Fixes #6.
136 2011-08-06T03:40:38 <CIA-114> Fixing https://bitbucket.org/marchael/moin-2.0/issue/6/unpretty-search-results-rendering
137 2011-08-06T03:41:44 <Marchael> seems like I should specified ... Fixes #6. in the end :(
138 2011-08-06T03:42:45 <Marchael> but I'm need to sleep some time.
139 2011-08-06T03:42:48 <Marchael> gn/bbl
140 2011-08-06T03:43:46 *** Marchael
141 2011-08-06T03:54:52 *** m4k3r_
142 2011-08-06T04:10:43 *** m4k3r
143 2011-08-06T05:58:52 *** m4k3r
144 2011-08-06T07:35:16 *** pkumar
145 2011-08-06T07:43:49 *** xorAxAx
146 2011-08-06T07:44:30 *** xorAxAx
147 2011-08-06T08:10:46 *** m4k3r
148 2011-08-06T09:22:23 *** m4k3r
149 2011-08-06T09:33:07 *** raignarok
150 2011-08-06T10:01:53 *** raignarok
151 2011-08-06T10:32:18 *** pkumar
152 2011-08-06T10:35:34 *** Marchael
153 2011-08-06T10:37:25 <Marchael> moin
154 2011-08-06T10:40:31 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 902378b07e99 r392 moin-2.0/ (5 files in 5 dirs): (log message trimmed)
155 2011-08-06T10:40:31 <CIA-114> simplify interwiki resolution, remove special case for 'Self' / own interwikiname
156 2011-08-06T10:40:31 <CIA-114> Note: it is required now that the interwiki_map contains entries for our
157 2011-08-06T10:40:31 <CIA-114> own wikiname and also for 'Self' (same url):
158 2011-08-06T10:40:31 <CIA-114> interwiki_map = {
159 2011-08-06T10:40:32 <CIA-114> 'Self': 'http://ourserver/ourpath/',
160 2011-08-06T10:40:33 <CIA-114> 'OurInterWikiName': 'http://ourserver/ourpath/',
161 2011-08-06T10:40:33 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 23a6a6b85d4c r393 moin-2.0/MoinMoin/converter/__init__.py: convert_to_indexable: clarify that usage of rev.seek(0) might be needed
162 2011-08-06T10:40:34 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 8fa4a76d71ff r394 moin-2.0/MoinMoin/ (7 files in 5 dirs): (log message trimmed)
163 2011-08-06T10:40:34 <CIA-114> cleanup interwiki code, new easier/more powerful functions
164 2011-08-06T10:40:35 <CIA-114> removed crappy resolve_interwiki
165 2011-08-06T10:40:35 <CIA-114> added is_known_wiki(wiki_name) - check if <wiki_name> is in the interwiki_map
166 2011-08-06T10:40:36 <CIA-114> added is_local_wiki(wiki_name) - check if <wiki_name> is THIS wiki
167 2011-08-06T10:40:36 <CIA-114> new powerful url_for_item(...) function, that is somehow similar to url_for,
168 2011-08-06T10:40:37 <CIA-114> but also includes computing interwiki URLs. It either can compute standard
169 2011-08-06T10:40:37 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * f39b2747ac16 r395 moin-2.0/MoinMoin/converter/_tests/test_link.py: link converter: fix tests (uses test wiki url_root == '/' now)
170 2011-08-06T12:08:32 *** raignarok
171 2011-08-06T12:50:02 *** raignarok
172 2011-08-06T13:34:26 *** pkumar
173 2011-08-06T13:44:08 <CIA-114> pkumar <contactprashantat@gmail.com> * 50bd0f081899 r456 pytest2/MoinMoin/items/_tests/test_Item.py: added tests for Text._render_data_diff_text() and Text._render_data_highlight() in test_Item in items module
174 2011-08-06T13:44:09 <CIA-114> pkumar <contactprashantat@gmail.com> * 82f80b0b43b8 r457 pytest2/MoinMoin/items/_tests/test_Item.py: added tests for MarkupItem in test_Item in items module
175 2011-08-06T13:44:09 <CIA-114> pkumar <contactprashantat@gmail.com> * 0b15a98fb030 r458 pytest2/MoinMoin/converter/_tests/ (test_moinwiki_in_out.py test_moinwiki_in.py): changes in converter to fix the failures
176 2011-08-06T13:44:09 <CIA-114> pkumar <contactprashantat@gmail.com> * 3f86e5780814 r459 pytest2/MoinMoin/ (5 files in 3 dirs): removed extra whitespaces from different files
177 2011-08-06T13:44:09 <CIA-114> pkumar <contactprashantat@gmail.com> * 240def5ebe18 r460 pytest2/MoinMoin/storage/_tests/test_backends_fs19.py: added tests for fs19._decode_list and fs19._decode_dict in test_backend_fs19 in storage module
178 2011-08-06T13:44:10 <CIA-114> pkumar <contactprashantat@gmail.com> * b9c77994ba3f r461 pytest2/MoinMoin/storage/_tests/test_backends_fs19.py: added test for the fs19.hash_hexdigest in test_backends_fs19
179 2011-08-06T13:44:11 <CIA-114> pkumar <contactprashantat@gmail.com> * 45a9528625cf r462 pytest2/MoinMoin/storage/_tests/test_backends_fs19.py: code clean up for test_backends_fs19
180 2011-08-06T13:44:11 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 1e9ec607913d r463 pytest2/MoinMoin/util/send_file.py: fix downloading of items with non-ascii names (for most modern browsers), implement RFC2231/5987
181 2011-08-06T13:44:35 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 0adc626b1036 r464 pytest2/setup.py: setup.py: change requirement to werkzeug >= 0.6.2 after successful test with 0.7.1
182 2011-08-06T13:44:35 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> * 07143bd03aed r465 pytest2/MoinMoin/items/__init__.py: fix pygments converter call for new converter api
183 2011-08-06T13:44:35 <CIA-114> pkumar <contactprashantat@gmail.com> * 91c5baf0565b r466 pytest2/ (3 files in 3 dirs): merged with default
184 2011-08-06T13:44:35 <CIA-114> pkumar <contactprashantat@gmail.com> * 294c0053e0a5 r467 pytest2/MoinMoin/macro/_tests/test__base.py: added new test for macro._base in test__base : previous one was out of sync with tested code
185 2011-08-06T13:44:36 <CIA-114> pkumar <contactprashantat@gmail.com> * d0ce4067e47c r468 pytest2/MoinMoin/macro/_tests/test__base.py: name changed and comment added for the class
186 2011-08-06T13:44:36 <CIA-114> pkumar <contactprashantat@gmail.com> * 49513dc53fa5 r469 pytest2/MoinMoin/macro/_tests/test__base.py: test__base cleanup
187 2011-08-06T13:45:35 <CIA-114> pkumar <contactprashantat@gmail.com> * b255ecfe87b9 r470 pytest2/MoinMoin/macro/_tests/test_Anchor.py: added new test for macro.Anchor as test_Anchor in macro module
188 2011-08-06T13:45:35 <CIA-114> pkumar <contactprashantat@gmail.com> * 1b0d299e1b18 r471 pytest2/MoinMoin/macro/_tests/test_GetVal.py: added new test for macro.GetVal as test_GetVal in macro module
189 2011-08-06T13:45:35 <CIA-114> pkumar <contactprashantat@gmail.com> * 753acdd70fb5 r472 pytest2/MoinMoin/macro/_tests/test_Verbatim.py: added test for macro.Verbatim as test_Verbatim in macro module
190 2011-08-06T13:45:35 <CIA-114> pkumar <contactprashantat@gmail.com> * 7fd1cbdeec3a r473 pytest2/MoinMoin/macro/_tests/test_DateTime.py: added test for macro.DateTime as test_DateTime in macro module
191 2011-08-06T13:45:36 <CIA-114> pkumar <contactprashantat@gmail.com> * dc7455588fdd r474 pytest2/MoinMoin/macro/_tests/test_DateTime.py: whitespaces cleanup
192 2011-08-06T13:45:36 <CIA-114> pkumar <contactprashantat@gmail.com> * 8c3681129c16 r475 pytest2/MoinMoin/macro/_tests/test_Date.py: added test for macro.Date as test_Date in macro module
193 2011-08-06T13:46:35 <CIA-114> pkumar <contactprashantat@gmail.com> * 10ae983e1137 r476 pytest2/MoinMoin/macro/_tests/test_GetText.py: added new test for macro.GetText as test_GetText in macro module
194 2011-08-06T13:46:35 <CIA-114> pkumar <contactprashantat@gmail.com> * 93ace300d396 r477 pytest2/MoinMoin/security/_tests/test_textcha.py: added test for security.textcha as test_textcha in security module
195 2011-08-06T13:46:35 <CIA-114> pkumar <contactprashantat@gmail.com> * 1c292b6a76b7 r478 pytest2/MoinMoin/security/_tests/test_textcha.py: added test for textcha.TextChaValid, TextCha.test_amend_form. created setup and teardown for test clean up.
196 2011-08-06T13:46:35 <CIA-114> pkumar <contactprashantat@gmail.com> * 05b5d8284031 r479 pytest2/MoinMoin/ (_tests/test_test_environ.py security/_tests/test_textcha.py): removed trailing white spcaes from test_textcha in securit module and test_test_environ in MoinMoin._tests
197 2011-08-06T13:50:20 *** raignarok
198 2011-08-06T13:52:49 <pkumar> xorAxAx : hi, can you please go through my repo and suggest the changes required
199 2011-08-06T13:55:45 <xorAxAx> pkumar: yeah, will do today, sorry for the delay
200 2011-08-06T13:56:42 <pkumar> xorAxAx : ok :)
201 2011-08-06T13:56:54 <pkumar> np
202 2011-08-06T14:35:44 *** pkumar
203 2011-08-06T14:39:07 *** Marchael
204 2011-08-06T14:40:44 *** Marchael
205 2011-08-06T14:41:31 <ThomasWaldmann> moin
206 2011-08-06T14:47:00 <Marchael> ThomasWaldmann: hm, don't you know example using flatland for generation radiobutton?
207 2011-08-06T14:47:06 <Marchael> moin
208 2011-08-06T14:48:56 <ThomasWaldmann> btw, #11 is a very easy fix
209 2011-08-06T14:49:36 <ThomasWaldmann> Marchael: you can also use a checkbox like [ ] search in old revisions, too
210 2011-08-06T14:50:56 <ThomasWaldmann> also #3 is very easy to fix
211 2011-08-06T14:51:42 <ThomasWaldmann> in general, stuff that is very easy to fix and takes little time should be done immediately, just to get it from your todo list
212 2011-08-06T14:53:08 <Marchael> ok
213 2011-08-06T14:56:33 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 79d80bcd1d32 r400 moin-2.0/MoinMoin/script/maint/index.py:
214 2011-08-06T14:56:33 <CIA-114> Fixes issue https://bitbucket.org/marchael/moin-2.0/issue/11/moin-index-script-wrong-unhelpful-texts
215 2011-08-06T14:56:33 <CIA-114> Fixes #11.
216 2011-08-06T14:57:11 <Marchael> 11 doesn't closed
217 2011-08-06T14:58:07 <ThomasWaldmann> you need to configure your bb repo for that.
218 2011-08-06T14:58:43 <Marchael> ah
219 2011-08-06T14:59:27 <ThomasWaldmann> repo - admin - services - "issues"
220 2011-08-06T14:59:43 <Marchael> yes, I added it
221 2011-08-06T15:13:26 <ThomasWaldmann> Marchael: ah, and please do not ONLY use "Fixes #6" as commit comment, but rather "... some short description ... Fixes #6."
222 2011-08-06T15:13:55 <Marchael> in one line?
223 2011-08-06T15:14:26 <ThomasWaldmann> if it is short, yes
224 2011-08-06T15:14:30 <ThomasWaldmann> date: Sat Aug 06 18:52:00 2011 +0000
225 2011-08-06T15:14:59 <ThomasWaldmann> that is still in the future (from your repo history)
226 2011-08-06T15:15:16 <Marchael> time machine
227 2011-08-06T15:15:23 <ThomasWaldmann> is your computer's clock ok?
228 2011-08-06T15:16:01 <ThomasWaldmann> date: Thu Aug 04 12:31:11 2011 +0200
229 2011-08-06T15:16:02 <Marchael> yes, but I not set time zone
230 2011-08-06T15:16:17 <ThomasWaldmann> this is one of my timestamps, notice the correct tz
231 2011-08-06T15:18:19 <Marchael> I have linux and windows on my machine and windows always break my clocks, so I just use "localtime" in my config
232 2011-08-06T15:18:28 <Marchael> on linux
233 2011-08-06T15:20:38 <ThomasWaldmann> in that scenario, you need localtime in your rtc (bios setup) and tell linux that rtc has localtime (not utc time)
234 2011-08-06T15:21:10 <ThomasWaldmann> also, you can easily run ntp under linux (and windows internet time service under windows)
235 2011-08-06T15:22:29 <ThomasWaldmann> after that you can configure correct tz, it'll work then
236 2011-08-06T15:24:50 <ThomasWaldmann> it still shows "handlers need to give it", didn't you fix that already?
237 2011-08-06T15:25:05 <ThomasWaldmann> (on search results)
238 2011-08-06T15:26:17 <Marchael> hm, yes it fixed
239 2011-08-06T15:28:09 <ThomasWaldmann> changeset?
240 2011-08-06T15:29:33 <Marchael> https://bitbucket.org/marchael/moin-2.0/changeset/215d7a8f5b3e
241 2011-08-06T15:33:33 <ThomasWaldmann> ah, my fault, ignore
242 2011-08-06T15:53:43 <ThomasWaldmann> Marchael: what do you work on currently?
243 2011-08-06T15:54:13 <ThomasWaldmann> i think about remove some of my code in your repo that is not needed any more
244 2011-08-06T15:54:49 <ThomasWaldmann> removing*
245 2011-08-06T15:55:14 <Marchael> you can send my diff
246 2011-08-06T15:55:22 <Marchael> currently I working on 3
247 2011-08-06T15:55:38 <Marchael> I think how I can create dicts from generator
248 2011-08-06T15:57:46 <Marchael> also, I don't understand what main point of #3. I see history and it's look ok
249 2011-08-06T15:58:04 <ThomasWaldmann> you first make a list, you can't sort anything else anyway
250 2011-08-06T15:58:30 <ThomasWaldmann> and the list elements need to be tuples, not dicts
251 2011-08-06T15:58:33 <Marchael> or I missed something
252 2011-08-06T15:59:15 <ThomasWaldmann> if your current history looks ok, that is sheer luck
253 2011-08-06T15:59:24 <Marchael> heh
254 2011-08-06T15:59:37 <Marchael> so, I very lucky :)
255 2011-08-06T16:00:02 <ThomasWaldmann> the main point you need to learn is that dict items do not have order
256 2011-08-06T16:00:47 <ThomasWaldmann> for if you iterate over d.items(), the order can is rather arbitrary depending on what keys you have
257 2011-08-06T16:00:59 <ThomasWaldmann> s/is/be/
258 2011-08-06T16:01:49 <Marchael> so I should convert generator -> list -> list with touples?
259 2011-08-06T16:01:50 <ThomasWaldmann> in a tuple (or list), you have a specific order of things and you are in control to setup that specific order
260 2011-08-06T16:02:25 <ThomasWaldmann> yes
261 2011-08-06T16:02:28 <Marchael> it's rather expensive I guess
262 2011-08-06T16:02:56 <ThomasWaldmann> well, if you want to sort, there is no other way
263 2011-08-06T16:03:09 <ThomasWaldmann> and as order is required, you are required to sort
264 2011-08-06T16:04:08 <ThomasWaldmann> btw, you don't need to transform the whole dict, for ordering it is enough to extract the mtime and make tuples (mtime, d)
265 2011-08-06T16:04:48 <ThomasWaldmann> or, you could call sorted in a different way. see the docs of sorted about how to tell it how to get the sort key.
266 2011-08-06T16:05:09 <ThomasWaldmann> i think you better first try that ^^ :)
267 2011-08-06T16:06:04 <ThomasWaldmann> sorted(...) sorted(iterable, cmp=None, key=None, reverse=False) --> new sorted list
268 2011-08-06T16:07:03 <Marchael> ok, I'll try that
269 2011-08-06T16:08:04 <ThomasWaldmann> http://wiki.python.org/moin/HowTo/Sorting/ see there, "Key functions"
270 2011-08-06T16:13:01 <xorAxAx> pkumar, my review results:
271 2011-08-06T16:13:46 <xorAxAx> 35939c292237 - a bit useless, please test things thatare not the repr
272 2011-08-06T16:17:28 <dreimark> re
273 2011-08-06T16:20:25 <xorAxAx> pkumar, sigh, you still dont seem to respect the rule that the test should fail before you make it pass
274 2011-08-06T16:21:15 <xorAxAx> pkumar, i dont see the backouts of the hardy changestes
275 2011-08-06T16:24:23 <xorAxAx> 3ad1888fe586 - "plane" - please make it fail first!
276 2011-08-06T16:27:32 <ThomasWaldmann> xorAxAx: as pkumar is not here, use his issue tracker?
277 2011-08-06T16:27:59 <xorAxAx> ThomasWaldmann: no, he will read the logs
278 2011-08-06T16:28:09 <ThomasWaldmann> hopefully :)
279 2011-08-06T16:28:31 <dreimark> he does
280 2011-08-06T16:31:02 <dreimark> bbl
281 2011-08-06T16:36:38 *** pkumar
282 2011-08-06T17:08:42 <ThomasWaldmann> Marchael: what's the problem? this should be a quick fix.
283 2011-08-06T17:09:15 *** greg_f
284 2011-08-06T17:30:29 *** m4k3r
285 2011-08-06T17:39:09 *** sinha
286 2011-08-06T18:08:15 *** m4k3r_
287 2011-08-06T18:08:28 *** m4k3r
288 2011-08-06T18:22:26 *** m4k3r
289 2011-08-06T18:24:43 *** m4k3r_
290 2011-08-06T18:29:30 * ThomasWaldmann just got an idea about global wiki browsing/searching
291 2011-08-06T18:30:18 <ThomasWaldmann> http://packages.python.org/Whoosh/facets.html that could do all sorts of things via a single mechanism
292 2011-08-06T18:30:51 <ThomasWaldmann> global index = search for everything, sort by name
293 2011-08-06T18:31:14 <ThomasWaldmann> simple recent changes = search for everything, reverse-sort by mtime
294 2011-08-06T18:31:55 <ThomasWaldmann> sort by author, sort by size, sort by contenttype, ...
295 2011-08-06T18:42:18 *** m4k3r
296 2011-08-06T19:06:02 *** raignarok
297 2011-08-06T19:21:51 <ThomasWaldmann> mathjax is a PITA at install/upgrade time
298 2011-08-06T19:23:52 *** m4k3r
299 2011-08-06T19:27:47 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/43/remove-mathjax
300 2011-08-06T19:44:44 *** raignarok
301 2011-08-06T19:47:31 *** greg_f
302 2011-08-06T20:35:51 <dreimark> ThomasWaldmann: what did you do - 12 min for installing mathjax?
303 2011-08-06T20:36:56 <dreimark> is your hard disk broken?
304 2011-08-06T20:41:03 <dreimark> i see
305 2011-08-06T20:41:23 <dreimark> I guess i haven't before because I removed always env
306 2011-08-06T20:46:31 <ThomasWaldmann> you see the command i used in the issue
307 2011-08-06T20:46:46 <ThomasWaldmann> and i have nothing in kernel log (I already looked :)
308 2011-08-06T20:49:14 <ThomasWaldmann> but aside from that: we do not need to put that into moin default install. it can be simply added and configured by whoever needs it
309 2011-08-06T20:49:38 <ThomasWaldmann> (and that is likely <10% of all moin users)
310 2011-08-06T20:49:53 *** m4k3r
311 2011-08-06T20:51:22 <dreimark> I think that is a bug in pip or some kind of problem. Installing alone in a new env in 1m9sec on my system
312 2011-08-06T20:51:23 *** m4k3r
313 2011-08-06T20:51:37 <dreimark> s/in/is/
314 2011-08-06T20:52:08 <dreimark> that means it takes longer than 4mins deleting files
315 2011-08-06T20:52:15 <dreimark> on my system
316 2011-08-06T20:55:28 <ThomasWaldmann> even if only installing it, it takes rather too long to have it by default
317 2011-08-06T20:56:09 <dreimark> I have nothing against removing it, because it is very simple to get it added
318 2011-08-06T20:56:25 <dreimark> but it is the same as having a footnote
319 2011-08-06T20:56:34 <dreimark> you also can count people who uses that
320 2011-08-06T20:56:40 <ThomasWaldmann> no
321 2011-08-06T20:57:17 <ThomasWaldmann> footnotes are a generic thing, having math formulas is limited to specific scientific usage
322 2011-08-06T20:57:36 <ThomasWaldmann> and also we don't need lots of code to support footnotes
323 2011-08-06T20:59:44 <sinha> dreimark: what is the version number of this xstatic package to be put in setup.py file is it "20110717.1" or something else ?
324 2011-08-06T21:00:01 <sinha> dreimark: ^ of jquery_multi_download
325 2011-08-06T21:00:02 <dreimark> it is also for using the greek alphabet
326 2011-08-06T21:00:45 <dreimark> sinha: XStatic-multiDownload 20110717.1
327 2011-08-06T21:00:57 <sinha> dreimark: okay
328 2011-08-06T21:01:04 <dreimark> ThomasWaldmann: http://pypi.python.org/pypi?%3Aaction=search&term=xstatic&submit=search
329 2011-08-06T21:01:12 <dreimark> someone has added django
330 2011-08-06T21:02:41 <dreimark> ThomasWaldmann: yes, but it extends to the greek alphabet too. but however i see too the filespace install problem
331 2011-08-06T21:04:24 <sinha> dreimark: and also changing the contenttype of files on downloading, i will add a url query in the download link as "+download/itemname?ajax=true" and in the download function at views.py and items.py (_do_get function) i will check this term, if it is set i will set contenttype as "application/x-moin" otherwise contenttype will be the one of item's .
332 2011-08-06T21:05:19 <dreimark> ?ajax=true means what exactly?
333 2011-08-06T21:05:52 <dreimark> why not mimetype="application/x-moin" ?
334 2011-08-06T21:05:55 <dreimark> sinha: ^
335 2011-08-06T21:12:57 *** pkumar
336 2011-08-06T21:27:06 *** Marchael
337 2011-08-06T21:31:57 <sinha> dreimark: you mean send this mimetype in url query itself ?
338 2011-08-06T21:32:52 <sinha> i mean in that download function i can check that whether the file is downloaded through ajax by seeing that request.values.get("ajax"), and if ajax is set, i will use the mimetype as "/x-moin"
339 2011-08-06T21:39:05 <ThomasWaldmann> dreimark: ah, interesting
340 2011-08-06T21:43:50 <CIA-114> Akash Sinha <akash2607@gmail.com> * 85c3759de3a6 r349 default/ (5 files in 4 dirs): Download feature for items (integrated with select items) have been added at index page
341 2011-08-06T21:48:45 *** grzywacz
342 2011-08-06T21:48:45 *** grzywacz
343 2011-08-06T21:50:32 <dreimark> sinha: yes, if we send the mimetype we can control that by the querystring always
344 2011-08-06T21:51:00 <dreimark> and if I would be sure that it did not harm on any case then I would set this as default
345 2011-08-06T21:52:41 <dreimark> so now we should keep it as an option. And look if it has some caveats
346 2011-08-06T21:54:04 <dreimark> sinha: so please use it as parameter, the other one is to generic
347 2011-08-06T21:54:19 <dreimark> mimetype=...
348 2011-08-06T21:54:37 <sinha> dreimark: okay fine and earlier you were saying that the uploading isnt working, but i tested again in mine, it is working fine
349 2011-08-06T21:55:00 <dreimark> then i fetch a new clone and try again
350 2011-08-06T21:55:07 <sinha> okay
351 2011-08-06T21:55:48 <sinha> dreimark: and today i found that, some of CSS works on firefox but not in chrome, so i am changing some styles now on index page
352 2011-08-06T21:56:02 <dreimark> to be able to give another mimetype allows also an other app to get something which may be is saved as plain to interpret as csv
353 2011-08-06T21:56:20 <dreimark> ok
354 2011-08-06T21:57:27 <dreimark> sinha: i'll travelling on monday morning and I am not sure if I have internet in the train
355 2011-08-06T21:59:07 <sinha> dreimark: so i will commit my changes related to this download today/tomorrow, you can view that later
356 2011-08-06T21:59:19 <dreimark> ok
357 2011-08-06T21:59:48 <sinha> dreimark: anything else you want to suggest in this, because i guess these changes wont take much time ?
358 2011-08-06T22:00:16 <dreimark> one moment
359 2011-08-06T22:02:24 <dreimark> sinha: setup.py check ==
360 2011-08-06T22:02:51 <sinha> ah, sry
361 2011-08-06T22:04:05 <sinha> dreimark: anything else,as i am re-commiting it or i should wait
362 2011-08-06T22:04:23 <dreimark> I wait up the quickinstall
363 2011-08-06T22:04:27 <sinha> ok
364 2011-08-06T22:10:15 <dreimark> sinha: upload / download works
365 2011-08-06T22:10:42 <sinha> cool
366 2011-08-06T22:13:08 <dreimark> I have no text at the Download "pull down" is that normal?
367 2011-08-06T22:13:45 <dreimark> "download" is shon after clicking on it
368 2011-08-06T22:14:08 <sinha> yes, there is no text
369 2011-08-06T22:14:28 <sinha> when one clickc, he will see the list of actions
370 2011-08-06T22:14:38 <sinha> s/clickc/clicks
371 2011-08-06T22:15:07 <dreimark> yes, my feeling currently is that it needs be better visible. But i have not a good idea yet
372 2011-08-06T22:15:54 <dreimark> for now please implement that discussed stuff.
373 2011-08-06T22:16:10 <sinha> okay, thanks
374 2011-08-06T22:17:22 <dreimark> and think about how the index page could be simplitfied for the ui. ther are lots of functions on it
375 2011-08-06T22:17:59 <dreimark> radomir stated this is normal for moin. he is correct.
376 2011-08-06T22:18:47 <dreimark> one of my ideas is about if it is necessary to show on default all these functions
377 2011-08-06T22:19:08 <dreimark> may be hide until mouseover on a region
378 2011-08-06T22:19:40 *** MattMaker
379 2011-08-06T22:20:17 <sinha> dreimark: yes you are correct, all these functions should be on one place to do that ? there are at 3 different places on page
380 2011-08-06T22:20:26 <sinha> s/there/they
381 2011-08-06T22:21:00 <sinha> or someone wont hover file in any region then he wouldnt see any of those functions
382 2011-08-06T22:21:20 <dreimark> the index letter on top this is quite common
383 2011-08-06T22:21:37 <dreimark> one question is if all the others can go in some kind of sidebar
384 2011-08-06T22:21:47 <dreimark> or some box
385 2011-08-06T22:22:22 <dreimark> for example if you have many subitems you don't see Upload Files
386 2011-08-06T22:22:31 <dreimark> until you scroll down
387 2011-08-06T22:22:55 * ThomasWaldmann kills the sqla based index
388 2011-08-06T22:24:53 <sinha> dreimark: sidebar thing can work well, we can hide/show it on demand
389 2011-08-06T22:26:18 <dreimark> that sounds good. because then upload can be inactive if there is no write right on the hierarchy of the item
390 2011-08-06T22:26:36 * dreimark it needs to be checked always
391 2011-08-06T22:26:43 *** m4k3r
392 2011-08-06T22:26:47 <dreimark> but then noone needs to see this function
393 2011-08-06T22:53:50 *** raignarok
394 2011-08-06T22:58:42 <sinha> dreimark: i am getting some problem in adding the download thing for newly uploaded items
395 2011-08-06T22:59:19 <sinha> as i said earlier that plugin saves all the link in a array on time only, and if new links are being added they can be selected for download
396 2011-08-06T22:59:37 <sinha> i have already added a related issue in the author's repo
397 2011-08-06T23:00:41 <sinha> so what should i do for this case ? leave downloading for newly uploaded items ? or change the plugin myself ?
398 2011-08-06T23:01:07 <dreimark> if you can make a patch, you can add it to the issue tracker
399 2011-08-06T23:02:16 <sinha> okay, beacause i already gt one problem with this, butsomehow managed to skip that, but now it seems unmanageable by doing change on top of the plugin
400 2011-08-06T23:02:18 <dreimark> this is my xstatic repo https://bitbucket.org/ReimarBauer/xstatic-multidownload
401 2011-08-06T23:02:21 <sinha> s/gt/spt
402 2011-08-06T23:02:29 <sinha> *got
403 2011-08-06T23:02:36 <dreimark> I can do a moin specific one but i want to avoid that
404 2011-08-06T23:03:06 <dreimark> currently I am nor sure if thist usecase happens+
405 2011-08-06T23:03:23 <dreimark> that one uploads items and immeaditly wants to download them
406 2011-08-06T23:03:29 *** raignarok
407 2011-08-06T23:03:40 <sinha> yes it could be, one can wait for page reload
408 2011-08-06T23:03:42 <dreimark> it makes somehow no sense because he has everything he did locally
409 2011-08-06T23:03:50 <sinha> yes, exactly
410 2011-08-06T23:04:04 <sinha> and may be putting effort for this may go unused
411 2011-08-06T23:04:07 <dreimark> so a message that he needs to reload the page to downlad
412 2011-08-06T23:04:21 <dreimark> is enough?
413 2011-08-06T23:04:36 <dreimark> anyone else who selects index did not have this problem
414 2011-08-06T23:04:43 <sinha> okay when to display the message ? i mean we wont present the select box before that item
415 2011-08-06T23:05:03 <sinha> no selection, no downloading
416 2011-08-06T23:05:10 <dreimark> this is enough.
417 2011-08-06T23:05:22 <dreimark> ThomasWaldmann: we don't have a message bar or?
418 2011-08-06T23:05:56 <dreimark> sinha: we had this in 1.9 and it is the right place
419 2011-08-06T23:06:11 <dreimark> to give a hint
420 2011-08-06T23:06:29 <sinha> dreimark: i have added a small message bar in last patch
421 2011-08-06T23:06:43 <sinha> if you try clicking on Downloading without selection anything, it will appear
422 2011-08-06T23:06:55 <sinha> s/Dow..ing/Download/
423 2011-08-06T23:07:03 <ThomasWaldmann> dreimark: you mean flashed messages?
424 2011-08-06T23:07:47 <dreimark> ThomasWaldmann: yes, i tried some common functions on test wiki but no msg was shown
425 2011-08-06T23:08:34 <dreimark> sinha: ok
426 2011-08-06T23:09:05 <ThomasWaldmann> we got rid of most messages we showed in 1.9
427 2011-08-06T23:09:13 <ThomasWaldmann> many people found them annoying
428 2011-08-06T23:10:17 <dreimark> heard that too.
429 2011-08-06T23:22:25 <sinha> gn
430 2011-08-06T23:22:38 *** sinha
431 2011-08-06T23:26:38 *** raignarok
432
