1 2011-08-11T00:19:29 *** m4k3r_
2 2011-08-11T00:22:27 *** m4k3r
3 2011-08-11T00:24:56 *** m4k3r_
4 2011-08-11T00:26:42 *** m4k3r
5 2011-08-11T00:55:31 *** m4k3r
6 2011-08-11T00:57:18 *** m4k3r
7 2011-08-11T01:05:26 *** m4k3r
8 2011-08-11T01:22:15 *** sinha
9 2011-08-11T03:02:07 *** grad
10 2011-08-11T05:24:30 *** marchael
11 2011-08-11T05:24:39 <marchael> ThomasWaldmann: http://codereview.appspot.com/4837073 ps 2
12 2011-08-11T05:24:44 <marchael> moin
13 2011-08-11T05:29:12 *** marchael
14 2011-08-11T06:04:23 *** Marchael
15 2011-08-11T06:23:04 *** jrc
16 2011-08-11T06:29:09 *** Marchael
17 2011-08-11T06:32:03 *** Marchael
18 2011-08-11T06:34:07 <jrc> I'm interested in moinmoin, but I noticed version 2.0 is a major upgrade from 1.9. This revelation means I have the opportunity to start out (basically) fresh at 2.0. This is good because I would like to contribute what little I can and gain some better understanding of python too. Does anyone have advice on 2.0 dev to focus on?
19 2011-08-11T06:49:02 <jrc> My main interest is backing up content/cloning wikis
20 2011-08-11T06:50:04 *** m4k3r
21 2011-08-11T06:51:42 *** jrc
22 2011-08-11T06:52:15 *** jrc
23 2011-08-11T07:03:36 *** m4k3r
24 2011-08-11T07:10:47 *** m4k3r
25 2011-08-11T07:27:17 *** m4k3r
26 2011-08-11T07:29:13 *** m4k3r
27 2011-08-11T07:42:41 *** m4k3r
28 2011-08-11T07:44:33 *** m4k3r
29 2011-08-11T07:52:36 *** eSyr
30 2011-08-11T07:58:30 *** eSyr
31 2011-08-11T08:01:34 *** m4k3r_
32 2011-08-11T08:04:00 *** m4k3r
33 2011-08-11T08:14:09 *** pkumar
34 2011-08-11T08:19:55 <ThomasWaldmann> moin
35 2011-08-11T08:20:06 <ThomasWaldmann> Marchael: review done.
36 2011-08-11T08:20:20 <ThomasWaldmann> btw, i will be mostly away today.
37 2011-08-11T08:31:30 *** m4k3r_
38 2011-08-11T08:32:11 *** m4k3r
39 2011-08-11T08:39:50 *** m4k3r
40 2011-08-11T08:40:25 *** m4k3r
41 2011-08-11T08:53:57 <dreimark> moin
42 2011-08-11T08:56:20 *** raignarok
43 2011-08-11T09:24:29 *** m4k3r_
44 2011-08-11T09:27:08 *** m4k3r
45 2011-08-11T09:30:54 *** m4k3r_
46 2011-08-11T09:50:15 *** raignarok
47 2011-08-11T10:29:07 *** raignarok
48 2011-08-11T10:54:06 *** pkumar
49 2011-08-11T11:02:34 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4837073 ps 3
50 2011-08-11T11:18:38 *** greg_f
51 2011-08-11T11:43:56 *** sinha
52 2011-08-11T12:13:21 <dreimark> Marchael: ThomasWaldmann is mostly away today, if you can prepare/work on something else please do, don't await the review
53 2011-08-11T12:24:10 <Marchael> ok
54 2011-08-11T12:43:50 <Marchael> bbl
55 2011-08-11T12:43:54 *** Marchael
56 2011-08-11T13:01:26 <sinha> dreimark: i have used JSON.stringify() funciton to send javascript array of itemnames, in the backend it is received as [u'item1.jpg', u'item2', u'item3'], but this is coming as a string, i am using the function json.loads() to convert into other Datastructure, but nothing is happening
57 2011-08-11T14:22:36 <sinha> dreimark: okay it got solved
58 2011-08-11T16:04:56 *** raignarok
59 2011-08-11T16:08:08 *** Marchael
60 2011-08-11T16:20:55 *** raignarok
61 2011-08-11T16:22:55 *** raignarok
62 2011-08-11T16:23:04 *** raignarok
63 2011-08-11T16:24:47 *** pkumar
64 2011-08-11T16:28:26 *** raignarok
65 2011-08-11T16:31:04 *** raignarok
66 2011-08-11T16:41:17 *** raignarok
67 2011-08-11T17:28:39 *** raignarok
68 2011-08-11T17:57:33 <pkumar> xorAxAx : hi, I was looking into test cleanup, in datastruct to begin with. I was wondering if there is any special reason we use flaskg.storage instead of flaskg.unprotected_storage in MoinMoin._tests.__init__.update_item()?
69 2011-08-11T18:01:42 <pkumar> ThomasWaldmann : ^
70 2011-08-11T18:08:41 <pkumar> brb
71 2011-08-11T18:54:06 *** raignarok
72 2011-08-11T19:01:06 <Marchael> ThomasWaldmann: currently I'm working on https://bitbucket.org/marchael/moin-2.0/issue/18/radiobutton-search-in-current-revision I've done radiobuttons for all and latest, but having difficulties with "checked" atribute. Can you advise me a simple way to check in what revisions user was searching?
73 2011-08-11T19:29:31 <Marchael> done
74 2011-08-11T19:29:34 *** Marchael
75 2011-08-11T19:36:46 *** Marchael
76 2011-08-11T19:37:14 <Marchael> dreimark: how I can integrate sihna's navigation widget to my repo, just copy-paste will be enough?
77 2011-08-11T19:39:16 <Marchael> s/sihna/sinha/
78 2011-08-11T19:39:47 <sinha> Marchael: which navigation widget ?
79 2011-08-11T19:40:02 <Marchael> for history
80 2011-08-11T19:40:30 *** grad
81 2011-08-11T19:41:40 <sinha> i am not getting it, are you talking about the paging thing ?
82 2011-08-11T19:47:24 <Marchael> sinha: yes, I meant paging https://bitbucket.org/sinha/moin2/changeset/b9f0ba2ba779
83 2011-08-11T19:48:21 <sinha> yes just copy that function in util
84 2011-08-11T19:48:34 <sinha> and call it with appropriate parameters
85 2011-08-11T19:48:54 <Marchael> sinha: great thx!
86 2011-08-11T19:49:10 <sinha> feel free to ask if you face any trouble
87 2011-08-11T19:50:21 *** greg_f
88 2011-08-11T19:53:11 *** grad
89 2011-08-11T19:54:05 *** raignarok
90 2011-08-11T20:25:03 <Marchael> sinha: I copy-pasted code from that changeset, and I saw http://paste.pocoo.org/show/456754/ when tried view history. What I should add to my repo to fix this?
91 2011-08-11T20:33:33 <Marchael> ah, found
92 2011-08-11T20:36:02 <sinha> Marchael: okay
93 2011-08-11T20:37:01 *** pkumar
94 2011-08-11T20:39:12 <Marchael> sinha: am, I opening history, but I doesn't see navigation. Should I increase cont of results to see that?
95 2011-08-11T20:39:19 <Marchael> s/cont/count/
96 2011-08-11T20:39:30 <sinha> Marchael: are you logged in ?
97 2011-08-11T20:39:37 <Marchael> nope
98 2011-08-11T20:39:58 <sinha> then if history count is more than 50 then paging button will appear
99 2011-08-11T20:40:16 <Marchael> ok
100 2011-08-11T20:40:22 <sinha> sry, that count is set in cfg
101 2011-08-11T20:40:26 <sinha> you can alter it
102 2011-08-11T20:40:41 <sinha> Marchael: ^
103 2011-08-11T20:40:54 <Marchael> yep
104 2011-08-11T20:42:28 <Marchael> sinha: am, it just "<< >>"? I don't see number of page there
105 2011-08-11T20:44:09 <sinha> yes number of page isnt there
106 2011-08-11T20:46:25 <sinha> actually we are having a generator as big dataset, so when we get the length of generator it get exhausted, this was the problem i seen
107 2011-08-11T20:47:42 <sinha> but we can put what is the numbering of that page as "Page 2", but we cant show it as "Page 2 of 8"
108 2011-08-11T20:50:18 <Marchael> hm, then I live that as is for now.
109 2011-08-11T20:50:25 <Marchael> s/live/leave/
110 2011-08-11T21:06:38 <xorAxAx> pkumar, i dont know
111 2011-08-11T21:12:11 *** raignarok
112 2011-08-11T21:12:59 <ThomasWaldmann> reee
113 2011-08-11T21:23:57 <ThomasWaldmann> Marchael: can you give the current state for codereview?
114 2011-08-11T21:24:33 <Marchael> http://codereview.appspot.com/4837073/ ps 4
115 2011-08-11T21:30:10 <ThomasWaldmann> hmm, somehow CR is slow/borked currently
116 2011-08-11T21:39:42 <ThomasWaldmann> Marchael: review done
117 2011-08-11T21:48:19 <Marchael> ok, /me currently working on integration singa's paging widget, after ending I'll deal with that
118 2011-08-11T21:53:01 <Marchael> ThomasWaldmann: seems like I can't use that widget for navigation, becuase util.getPageContent(results, offset, results_per_page) returns stuff like
119 2011-08-11T21:53:01 <Marchael> ([<Hit {'rev_no': 0, 'contenttype': u'text/x.moin.wiki;charset=utf-8', 'name': u'One', 'itemlinks': [], 'hostname': u'localhost.localdomain', 'uuid': u'389c4cb6dbca447891251231a8bb49df', 'content': u'Home', 'itemtransclusions': [], 'address': u'127.0.0.1', 'mtime': datetime.datetime(2011, 8, 10, 16, 18, 39), 'wikiname': u'MoinMoin2'}>, <Hit {'rev_no': 0, 'contenttype': u'text/x.moin.wiki;charset=utf-8', 'name': u'Two', 'itemlinks': [], 'hostname'
120 2011-08-11T21:53:01 <Marchael> but for displaying search stats I'm need clean "results" like <whoosh.searching.ResultsPage object at 0x2383b90>
121 2011-08-11T21:53:24 <dreimark> Marchael: try autocomplete of your irc client usually it is the tab key, less typos in names
122 2011-08-11T21:54:07 <Marchael> m?
123 2011-08-11T21:54:19 <dreimark> you types twice sinha wrong
124 2011-08-11T21:54:24 <dreimark> s/s/d/
125 2011-08-11T21:54:49 <Marchael> oops, sorry :)
126 2011-08-11T21:57:39 <ThomasWaldmann> Marchael: ask sinha about that stuff
127 2011-08-11T21:57:58 <ThomasWaldmann> can we forget about paging for now and do the more important stuff?
128 2011-08-11T21:58:39 <Marchael> ThomasWaldmann: hm, yes. But paging don't seems hard
129 2011-08-11T21:58:52 <Marchael> sinha: ping
130 2011-08-11T21:59:20 <Marchael> Could you read aboce about problem what I have
131 2011-08-11T21:59:37 <Marchael> s/aboce/above/
132 2011-08-11T22:01:41 <Marchael> hm, I have idea how to improve that
133 2011-08-11T22:01:57 <Marchael> with whoosh's help
134 2011-08-11T22:06:42 <ThomasWaldmann> well, tell :)
135 2011-08-11T22:08:02 <Marchael> you'll see
136 2011-08-11T22:09:27 <dreimark> Marchael: that is sinha job, ping him
137 2011-08-11T22:10:03 <sinha> yes Marchael what is that you wanted to say
138 2011-08-11T22:11:39 <sinha> Marchael: that function would just return the object which you send as list of objects
139 2011-08-11T22:12:14 <sinha> suppose you are passing a generator having integers only, then in return you will get a list of integers
140 2011-08-11T22:12:18 <Marchael> hm, you pointed about problem with generators. With whoosh you could avoid this problem and also show additional info about current page, netxt page, previous, etc. like I do.
141 2011-08-11T22:12:37 <Marchael> and I already use whoosh code for history
142 2011-08-11T22:12:44 <sinha> how would you find the length of a generator ?
143 2011-08-11T22:12:55 <Marchael> len(results)
144 2011-08-11T22:13:07 *** RogerHaase
145 2011-08-11T22:13:13 <sinha> but wont it exhaust the generator itself ?
146 2011-08-11T22:13:19 <Marchael> that's what I do to know search results len
147 2011-08-11T22:13:56 <Marchael> I don't go deep in whoosh source, but seems like it's object which uses generator
148 2011-08-11T22:14:52 <Marchael> and I could use
149 2011-08-11T22:14:52 <Marchael> > results = s.search_page(q, 5, pagelen=20)
150 2011-08-11T22:14:52 <Marchael> to see only 20 results on 5 page
151 2011-08-11T22:15:03 <sinha> Marchael: but object of type 'generator' has no len()
152 2011-08-11T22:15:48 <Marchael> it's not generator, it's whoosh.searching.ResultsPage but yes, that stuff using generator
153 2011-08-11T22:16:41 <Marchael> but I'm not sure
154 2011-08-11T22:35:33 <Marchael> gn/bbl
155 2011-08-11T22:36:49 *** Marchael
156 2011-08-11T23:02:04 <sinha> dreimark: i am already removing/hiding the deleted ones, but leaving the ones who couldnt get deleted
157 2011-08-11T23:02:17 *** raignarok
158 2011-08-11T23:04:39 <sinha> and so for the items who wasnt deleted, i will add a red background color around the item name
159 2011-08-11T23:11:27 <sinha> gn
160 2011-08-11T23:11:33 *** sinha
161 2011-08-11T23:14:02 <dreimark> sinha: :)
