1 2011-08-12T01:08:08 *** RogerHaase
2 2011-08-12T01:53:23 *** raignarok
3 2011-08-12T06:15:20 *** Marchael
4 2011-08-12T06:38:21 <Marchael> moin
5 2011-08-12T07:49:36 *** pkumar
6 2011-08-12T07:58:51 <pkumar> ThomasWaldmann : hi, I was looking into test cleanup. I was wondering if there is any special reason we use flaskg.storage instead of flaskg.unprotected_storage in MoinMoin._tests.__init__.update_item()?
7 2011-08-12T08:35:03 <pkumar> dreimark : ^
8 2011-08-12T08:50:29 <dreimark> pkumar: we use it for test_wiki_groups. to do it similiar to a user you work with storge
9 2011-08-12T08:50:37 <dreimark> +a
10 2011-08-12T08:52:33 <pkumar> dreimark : can't we use flaskg.unprotected_storage instead of flaskg.storage, either way we need a storage backend right?
11 2011-08-12T08:53:02 <pkumar> in there
12 2011-08-12T08:53:50 <dreimark> it depends if you want to have acl protection or not
13 2011-08-12T08:54:07 <dreimark> unprotected == no acl check
14 2011-08-12T08:54:48 <dreimark> you have have to check tests where this is the main test case
15 2011-08-12T08:55:47 <pkumar> dreimark : yeah, thats what I was concluding to. actually, delete rights are not there for flaskg.storage due to acl check, and to clean the backend I need that
16 2011-08-12T08:56:05 <dreimark> become_trusted()
17 2011-08-12T08:56:29 <dreimark> look in test_wiki_groups
18 2011-08-12T08:56:39 <pkumar> dreimark : I tried that too, but trusted user too can't delete it
19 2011-08-12T08:56:40 <dreimark> this is the path a user request goes
20 2011-08-12T08:57:03 <dreimark> if you change this it is not more a real world test
21 2011-08-12T08:57:41 <dreimark> nuke_item() is also in __init__
22 2011-08-12T08:58:08 <dreimark> ahm not used currently
23 2011-08-12T09:00:05 <pkumar> nuke item doesn't work either on flaskg.storage.
24 2011-08-12T09:01:14 *** waldi
25 2011-08-12T09:01:30 <dreimark> a) create items with delete right for TrustedUser
26 2011-08-12T09:01:54 <dreimark> b) set default before rights for that user
27 2011-08-12T09:04:30 <pkumar> dreimark : ok, thanx. I'm on it
28 2011-08-12T09:05:05 <dreimark> if you look in items._save which is used by delete(_rename)
29 2011-08-12T09:05:15 <dreimark> backend = flaskg.storage
30 2011-08-12T09:06:02 <dreimark> so it is not a good idea to move it into unprotected
31 2011-08-12T09:10:07 <pkumar> ok, then I'll idea creating items with delete rights for trusted users
32 2011-08-12T09:11:05 <dreimark> or for the user used in become_trusted e.g. TrustedUser
33 2011-08-12T09:11:44 <pkumar> yeah, that would be better
34 2011-08-12T09:22:53 *** raignarok
35 2011-08-12T09:29:38 *** raignarok
36 2011-08-12T10:16:57 <Marchael> How I can pass SearchForm object to script without submitting page? I try {{ url_for('frontend.search', item_name=item_name, page_num=page_num + 1, search_form=medium_search_form) }} but search_form is unicode object and I can't use it
37 2011-08-12T10:18:03 <Marchael> so it's look like ('search_form', u"{u'q': <String u'q'; value=u'Home'>, u'pagelen': <String u'pagelen'; value=u'25'>, u'submit': <String u'submit'; value=u'Search'>, u'search_in': <String u'search_in'; value=u'current'>}")
38 2011-08-12T10:18:46 <Marchael> but I want CombinedMultiDict([ImmutableMultiDict([('q', u'Home'), ('pagelen', u'25'), ('submit', u'Search'), ('search_in', u'current')]), ImmutableMultiDict([])]) like after submitting page
39 2011-08-12T10:33:06 *** pkumar
40 2011-08-12T10:39:59 <ThomasWaldmann> why do you need to pass it without submitting the page?
41 2011-08-12T10:46:29 <dreimark> Marchael: ^
42 2011-08-12T10:48:47 <Marchael> I'm working on navigation, and i've navigation arrows
43 2011-08-12T10:48:53 <Marchael> not submit buttons
44 2011-08-12T10:51:25 <Marchael> also I pass page_num to script, because I need to know page user want to see
45 2011-08-12T10:55:16 * Marchael brb in 30 minutes
46 2011-08-12T10:55:18 *** greg_f
47 2011-08-12T11:09:04 * ThomasWaldmann wonders why we still work on navigation for search results although i have advised otherwise 1 or 2d ago
48 2011-08-12T11:10:33 <ThomasWaldmann> there are multiple critical and major prio bugs on the issue tracker and search results paging is not critical or major
49 2011-08-12T11:24:43 <Marchael> ThomasWaldmann: ok, I'll do that stuff later
50 2011-08-12T11:42:40 *** raignarok
51 2011-08-12T13:22:56 *** Marchael
52 2011-08-12T13:25:31 *** raignarok
53 2011-08-12T13:45:21 *** greg_f
54 2011-08-12T13:47:59 *** greg_f
55 2011-08-12T14:01:19 *** waldi
56 2011-08-12T14:01:19 *** waldi
57 2011-08-12T14:13:26 *** Marchael
58 2011-08-12T14:27:22 *** raignarok
59 2011-08-12T14:33:53 *** greg_f
60 2011-08-12T14:37:43 *** Marchael
61 2011-08-12T14:38:37 *** greg_f
62 2011-08-12T16:08:59 *** sinha
63 2011-08-12T16:23:46 *** Marchael
64 2011-08-12T16:32:52 *** raignarok
65 2011-08-12T16:46:43 <Marchael> ThomasWaldmann: please review http://codereview.appspot.com/4837073/ ps 5
66 2011-08-12T16:50:46 *** pkumar
67 2011-08-12T17:41:40 <Marchael> bbl
68 2011-08-12T17:49:25 *** RogerHaase
69 2011-08-12T17:54:27 *** sinha
70 2011-08-12T17:55:40 <dreimark> re
71 2011-08-12T17:56:17 *** raignarok
72 2011-08-12T18:03:57 <pkumar> brb
73 2011-08-12T18:30:30 <ThomasWaldmann> Marchael: currently reviewing
74 2011-08-12T18:42:38 <ThomasWaldmann> Marchael: review done
75 2011-08-12T18:53:02 *** raignarok
76 2011-08-12T19:21:21 <Marchael> re
77 2011-08-12T19:55:13 *** raignarok
78 2011-08-12T19:57:40 *** sinha
79 2011-08-12T20:13:17 *** RogerHaase
80 2011-08-12T20:41:29 *** pkumar
81 2011-08-12T20:48:19 *** Marchael
82 2011-08-12T20:48:38 *** Marchael
83 2011-08-12T21:01:14 *** greg_f
84 2011-08-12T22:03:17 <CIA-114> Akash Sinha <akash2607@gmail.com> * 5c86980e7d06 r375 default/MoinMoin/ (5 files in 5 dirs): Ajax delete feature for the items, has been added on index page.
85 2011-08-12T22:12:46 <dreimark> sinha: :)
86 2011-08-12T22:14:02 <sinha> dreimark: if you get some free time please test it and then i can quickly use the same code for destroy feature
87 2011-08-12T22:14:29 <dreimark> sinha: pulled and trying now
88 2011-08-12T22:16:30 *** raignarok
89 2011-08-12T22:17:18 <ThomasWaldmann> Marchael: any progress?
90 2011-08-12T22:23:17 <dreimark> sinha: it is not required to add a comment, if someone don't want to give one, this is also possible
91 2011-08-12T22:23:35 <dreimark> so empty comment, should add a default one
92 2011-08-12T22:28:06 <sinha> dreimark: okay, will remove that check, but what is default one ?
93 2011-08-12T22:29:40 <dreimark> ThomasWaldmann: i guess ifound an acl bug http://paste.pocoo.org/show/457398/
94 2011-08-12T22:30:00 <dreimark> if that configchange should prevent for deleting - it doesn't
95 2011-08-12T22:30:28 <dreimark> hmm it have to check if it is only in sinha's repo
96 2011-08-12T22:32:35 <dreimark> ThomasWaldmann: ignore
97 2011-08-12T22:32:43 <dreimark> sinha: i think that is only in your code
98 2011-08-12T22:33:09 <sinha> dreimark: i might have changes this some time ago
99 2011-08-12T22:33:12 <sinha> *changed
100 2011-08-12T22:34:08 <dreimark> have you used somewhere unprotected storage?
101 2011-08-12T22:34:17 <dreimark> that would cause this problem
102 2011-08-12T22:35:43 <sinha> dreimark: what kind of unprotected storage
103 2011-08-12T22:36:06 <sinha> you mean one can add items without logging in
104 2011-08-12T22:36:11 <dreimark> sinha: these rights give in moin-2 a AccessDeniedError: anonymous darf 'ШаблонДомашняяСтраницаГруппа (2011-08-12 20:30:23 UTC)' nicht write.
105 2011-08-12T22:36:32 <dreimark> but not in yours, there I get the warning nothing is deleted but after a refresh
106 2011-08-12T22:36:36 *** raignarok
107 2011-08-12T22:36:41 <dreimark> everything is gone
108 2011-08-12T22:37:18 <dreimark> sinha: i mean everyone can delete with this settings http://paste.pocoo.org/show/457398/
109 2011-08-12T22:37:46 <dreimark> in your repo
110 2011-08-12T22:37:59 <sinha> yes, but could that be a problem in that implementation
111 2011-08-12T22:38:46 <sinha> and in my repo, only i can access the moin from browser, because i always run it on localhost
112 2011-08-12T22:41:45 <dreimark> i have only checked your new method against the old one, try now the old too
113 2011-08-12T22:49:52 <dreimark> your usual delete method of the theme makes the same deleting without having rights
114 2011-08-12T22:58:58 <sinha> dreimark: i am confused here, i mean i am just using the delete function as it is, i.e item.delete(), so if there is any ACL then the exception will be thrown automatically, i dont think i need to take care of something here
115 2011-08-12T23:04:52 <dreimark> sinha: i know, it must be somewhere in moins code hidden
116 2011-08-12T23:05:02 <dreimark> please continue with destroy
117 2011-08-12T23:05:10 <dreimark> i try to find where that happens
118 2011-08-12T23:05:29 <sinha> okay, thanks
119 2011-08-12T23:06:08 <sinha> dreimark: i have also found a issue in one of mine earlier code, see this http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-08-12
120 2011-08-12T23:18:13 <dreimark> sinha: it is not only in yours broken, moin-2 bug
121 2011-08-12T23:18:25 <sinha> ah, ok
122 2011-08-12T23:19:05 <sinha> dreimark: are you talking about the above subitem flag bug ?
123 2011-08-12T23:30:24 <dreimark> argh, issue in wrong repo
124 2011-08-12T23:30:42 <dreimark> sinha: i move issue 1 to moin-2
125 2011-08-12T23:30:52 <dreimark> i wanted to have it there not in yours
126 2011-08-12T23:33:47 <dreimark> sinha: moved to correct tracker, sorry for the noise
127 2011-08-12T23:33:57 <dreimark> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/44/delete-moves-an-item-without-respecting
128 2011-08-12T23:37:51 <dreimark> .oO i think we found a reason to get back the delete right
