1 2011-08-13T00:00:04 *** raignarok
2 2011-08-13T00:05:49 <ThomasWaldmann> BareRouterItem.rename is likely wrong
3 2011-08-13T00:36:45 *** sinha
4 2011-08-13T00:42:22 <ThomasWaldmann> dreimark: the acl wrapper backend checks only create permission for create_item
5 2011-08-13T00:48:17 <dreimark> and for rename to trash it don't need create
6 2011-08-13T00:48:39 <dreimark> so we have currently a bad design issue
7 2011-08-13T00:48:54 <dreimark> for that trash move
8 2011-08-13T00:48:59 <dreimark> gn
9 2011-08-13T00:57:01 <ThomasWaldmann> sure, it creates an item there
10 2011-08-13T06:57:47 *** MattMaker
11 2011-08-13T07:20:14 *** MattMaker
12 2011-08-13T07:39:40 <Marchael> ThomasWaldmann: sorry, I was sleeping when you post comments :( I read your cr but have troubles with naming radiobuttons, for using 2 radios I'm need to use 1 name, but I can't because they will have one label. I pasted my results to cr http://codereview.appspot.com/4837073/ ps 6
13 2011-08-13T07:39:49 <Marchael> s/post/posted/
14 2011-08-13T08:25:54 *** pkumar
15 2011-08-13T10:23:42 <ThomasWaldmann> moin
16 2011-08-13T10:30:06 <dreimark> moin
17 2011-08-13T10:42:32 <ThomasWaldmann> Marchael: review done. without knowing what exactly went wrong, it is hard to advise.
18 2011-08-13T10:54:39 * Marchael looks
19 2011-08-13T10:58:04 <Marchael> ThomasWaldmann: I try to be more clear. For switching between "Current revisions" and "All revisions" I using 2 radios with the same name "search_in", but I can't set name "search_in" for they both.
20 2011-08-13T10:58:56 <ThomasWaldmann> why not?
21 2011-08-13T10:59:30 <Marchael> give me a sec, I paste screenshot
22 2011-08-13T11:00:50 <Marchael> ThomasWaldmann: it's looking like http://i.imgur.com/BJd8F.png
23 2011-08-13T11:01:36 <Marchael> and I can't use one field, becuase radios will have same label
24 2011-08-13T11:01:42 <ThomasWaldmann> so? what does this have to do with the name?
25 2011-08-13T11:02:26 * ThomasWaldmann guesses this is rather because you pass a value to both
26 2011-08-13T11:03:16 <Marchael> I tried to change name in views.py, but it was useless
27 2011-08-13T11:03:33 <Marchael> I mean "name" in String.using(...)
28 2011-08-13T11:05:24 <Marchael> so if I define
29 2011-08-13T11:05:24 <Marchael> search_in_current = String.using(name='search_in', label='Current revisions', optional=True)
30 2011-08-13T11:05:24 <Marchael> search_in_all = String.using(name='search_in', label='All revisions', optional=True)
31 2011-08-13T11:05:24 <Marchael> I'll take 2 different names
32 2011-08-13T11:09:11 <ThomasWaldmann> how about not giving a value, but leaving everything else unchanged?
33 2011-08-13T11:09:46 <ThomasWaldmann> and please show the resulting html, always
34 2011-08-13T11:10:47 <ThomasWaldmann> ehrm, no
35 2011-08-13T11:11:15 <ThomasWaldmann> forget about removing value, you need this because this is the value that gets posted for the selected item
36 2011-08-13T11:12:19 <ThomasWaldmann> on the html level, the CHECKED attribute determines what one has selected.
37 2011-08-13T11:12:43 <Marchael> they will be selected both
38 2011-08-13T11:13:33 <Marchael> there is html http://paste.pocoo.org/show/457645/
39 2011-08-13T11:14:01 <Marchael> checked doesn't need there because they have different names
40 2011-08-13T11:14:06 <ThomasWaldmann> http://discorporate.us/projects/flatland/docs/tip/templating/genshi.html search for "radio" there. be careful, it is for genshi, but some stuff might apply in general.
41 2011-08-13T11:15:45 <Marchael> I already see this
42 2011-08-13T11:16:36 <ThomasWaldmann> hmm, it applies only for auto_value, we don't have this yet
43 2011-08-13T11:17:32 <ThomasWaldmann> Marchael: in case of doubt and if you see no progress, there is #discorporate to ask flatland questions
44 2011-08-13T11:17:36 <Marchael> and btw, that example show 3 different radios
45 2011-08-13T11:17:53 <Marchael> so you can select 3 at once
46 2011-08-13T11:18:24 *** pkumar
47 2011-08-13T11:19:02 <Marchael> ThomasWaldmann: hm, may be just use that like in ps 5 on cr?
48 2011-08-13T11:19:50 <Marchael> and code also looks more consistent with that( Imean search_result.html)
49 2011-08-13T11:21:13 <Marchael> I mean code like {{ gen.input(medium_search_form['search_in'], type='radio', value='current') }}Current revisions
50 2011-08-13T11:21:23 <Marchael> it will be much simplier
51 2011-08-13T11:21:38 <ThomasWaldmann> ok, use that for now
52 2011-08-13T11:23:23 <ThomasWaldmann> jek: one of the biggest problems with flatland yet is that such stuff is not easy if you did not do it before
53 2011-08-13T11:26:13 <dreimark> bbl
54 2011-08-13T11:31:22 <Marchael> ThomasWaldmann: I http://codereview.appspot.com/4837073/ ps 7
55 2011-08-13T11:31:27 <Marchael> s/I//
56 2011-08-13T11:37:57 <ThomasWaldmann> review done
57 2011-08-13T11:38:46 <Marchael> ah, i18n
58 2011-08-13T11:42:26 <Marchael> ThomasWaldmann: ps 8
59 2011-08-13T11:43:21 <ThomasWaldmann> ok, test it, commit it
60 2011-08-13T11:45:27 <ThomasWaldmann> btw, the "search in current revisions" should be the default
61 2011-08-13T11:45:38 <Marchael> it's default
62 2011-08-13T11:49:18 <ThomasWaldmann> hmm, from the code needed, i guess using a checkbox would've been easier
63 2011-08-13T11:49:41 <ThomasWaldmann> [ ] search also in non-current revisions
64 2011-08-13T11:50:17 <ThomasWaldmann> that basically says also what it does if you do not check it
65 2011-08-13T11:51:33 <Marchael> hm, checked doesn't need ther
66 2011-08-13T11:52:01 <ThomasWaldmann> ?
67 2011-08-13T11:52:02 <Marchael> because if user doesn't pass 'search_in' then script assumes that is "current"
68 2011-08-13T11:52:26 <Marchael> "all" will be used only in case if request object containts it
69 2011-08-13T11:52:42 <ThomasWaldmann> after your current commit, can you try using a checkbox?
70 2011-08-13T11:52:45 <Marchael> ix = index_object.all_revisions_index if request.values.get('search_in') == "all" else index_object.latest_revisions_index
71 2011-08-13T11:53:16 <ThomasWaldmann> it's a Boolean then, so it simplifies your code, it works correctly with the label, etc.
72 2011-08-13T11:53:17 <Marchael> checkbox? why?
73 2011-08-13T11:53:25 <Marchael> hm
74 2011-08-13T11:53:33 <ThomasWaldmann> and we have working code for checkbox :)
75 2011-08-13T11:53:53 <Marchael> but with radio it works fine, why we need checkbox?
76 2011-08-13T11:54:02 <ThomasWaldmann> mailto_author = Boolean.using(label=L_('Publish my email (not my wiki homepage) in author info'), optional=True)
77 2011-08-13T11:54:09 <ThomasWaldmann> (from another form)
78 2011-08-13T11:54:34 <Marchael> and if user clicked on both checkboxes?
79 2011-08-13T11:54:49 <ThomasWaldmann> there is only one checkbox then
80 2011-08-13T11:55:24 <Marchael> ah, you mean checkbox only for all revisions
81 2011-08-13T11:55:25 <ThomasWaldmann> the point why i first thought it should be radio was that the user is completely clear about what happens in both cases
82 2011-08-13T11:55:53 <ThomasWaldmann> but one can also use language to express that, so a checkbox / boolean is enough
83 2011-08-13T11:56:45 <ThomasWaldmann> if one uses "[ ] search also in non-current revisions", then it is somehow clear that if you do NOT check it, it'll only search in current revisions
84 2011-08-13T11:57:54 <ThomasWaldmann> so it is telling a bit more than "[ ] search in all revisions"
85 2011-08-13T12:13:16 <Marchael> ThomasWaldmann: do you mean that http://i.imgur.com/hVBLV.png ?
86 2011-08-13T12:14:21 <Marchael> ThomasWaldmann: there is a code http://codereview.appspot.com/4892042
87 2011-08-13T12:23:13 <ThomasWaldmann> you made that "without markup" to get rid of the dd/dt?
88 2011-08-13T12:23:24 <Marchael> yes
89 2011-08-13T12:23:33 <ThomasWaldmann> ok, test it, commit it
90 2011-08-13T12:25:35 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 6800ab9dd159 r429 moin-2.0/MoinMoin/templates/search_results.html: fixed acl search issue Fixes #14
91 2011-08-13T12:25:36 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 66981eb25822 r430 moin-2.0/MoinMoin/ (3 files in 2 dirs): Added searching in non-current revisions Fixes #18.
92 2011-08-13T12:26:42 <Marchael> ThomasWaldmann: next is https://bitbucket.org/marchael/moin-2.0/issue/26/wildcard-search-in-item-names-does-not ?
93 2011-08-13T12:34:36 <ThomasWaldmann> yes
94 2011-08-13T12:34:54 <ThomasWaldmann> that shoud be a quick one
95 2011-08-13T12:34:59 <ThomasWaldmann> +l
96 2011-08-13T12:38:21 <Marchael> hm, I should use your patch or try update to 2.0.1?
97 2011-08-13T12:38:46 <Marchael> s/2.0.1/2.1.0/
98 2011-08-13T12:39:30 <ThomasWaldmann> what patch?
99 2011-08-13T12:41:17 <Marchael> ThomasWaldmann: https://bitbucket.org/mchaput/whoosh/issue/157/with-fix-unicode-keywords-are-not
100 2011-08-13T12:48:23 <ThomasWaldmann> why is this relevant?
101 2011-08-13T12:50:02 <Marchael> > # note: kwargs == {u'text': u'home*'}
102 2011-08-13T12:50:12 <Marchael> you use wildcard in that example
103 2011-08-13T12:53:04 <ThomasWaldmann> in your issue 26, i proposed a way to deal with wildcard stuff. did you try it and THEN encounter that whoosh issue?
104 2011-08-13T12:53:20 <Marchael> ok, I try
105 2011-08-13T13:00:03 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/457676/
106 2011-08-13T13:01:09 <Marchael> or I should convert query to str before pass that to whoosh?
107 2011-08-13T13:01:50 <Marchael> hm, no for str search doesn't working
108 2011-08-13T13:03:08 <ThomasWaldmann> Marchael: what is your system python version?
109 2011-08-13T13:03:54 <Marchael> python
110 2011-08-13T13:03:54 <Marchael> Python 3.2.1 (default, Jul 11 2011, 12:37:47)
111 2011-08-13T13:04:29 <Marchael> but for moin I using python
112 2011-08-13T13:04:29 <Marchael> Python 2.6 (r26:66714, Jun 16 2011, 20:26:55)
113 2011-08-13T13:05:08 <ThomasWaldmann> do you have 2.6.x x>0 or 2.7?
114 2011-08-13T13:05:37 <Marchael> mm?
115 2011-08-13T13:05:47 <Marchael> 2.6.5
116 2011-08-13T13:09:13 <ThomasWaldmann> ok, please build another virtualenv (e.g. env265) and use that for now
117 2011-08-13T13:09:28 <ThomasWaldmann> see the quickinstall script, just temporarily modify it
118 2011-08-13T13:10:14 <Marchael> ok
119 2011-08-13T13:11:10 *** sinha
120 2011-08-13T13:12:15 <Marchael> ThomasWaldmann: done
121 2011-08-13T13:16:36 <ThomasWaldmann> (don't commit that quickinstall modification)
122 2011-08-13T13:19:32 <Marchael> ThomasWaldmann: what next?
123 2011-08-13T13:19:47 <Marchael> (I don't make any changes since commit)
124 2011-08-13T13:20:00 <Marchael> *since last
125 2011-08-13T13:21:04 <ThomasWaldmann> didn't you need to modify quickinstall script to install your env265?
126 2011-08-13T13:22:04 * ThomasWaldmann put some issues on HOLD because we have to wait for some other stuff being fixed before working on them
127 2011-08-13T13:22:10 <Marchael> You said what I shoudn't commit quickinstall, then I assume what I don't make any changes. just build env265
128 2011-08-13T13:22:33 <ThomasWaldmann> so you revert it afterwards?
129 2011-08-13T13:23:02 <Marchael> yes
130 2011-08-13T13:23:11 <ThomasWaldmann> DIR=env
131 2011-08-13T13:23:11 <ThomasWaldmann> PYTHON=python
132 2011-08-13T13:23:18 <Marchael> yep
133 2011-08-13T13:23:23 <ThomasWaldmann> because i guess you needed to temp. change those lines
134 2011-08-13T13:23:24 <ThomasWaldmann> ok
135 2011-08-13T13:23:55 <ThomasWaldmann> ok, so does the suggested change for searching in name_exact work?
136 2011-08-13T13:25:20 <Marchael> and how I can use it? search for name_exact and then filter found stuff with other keywords?
137 2011-08-13T13:25:51 <ThomasWaldmann> you already search in name and in content
138 2011-08-13T13:26:00 <ThomasWaldmann> now search in name, name_exact and content
139 2011-08-13T13:26:15 <Marchael> I alreddt tried it
140 2011-08-13T13:26:19 <Marchael> *already
141 2011-08-13T13:26:25 <ThomasWaldmann> so?
142 2011-08-13T13:26:34 <Marchael> result with wildcrads is the same
143 2011-08-13T13:26:54 <ThomasWaldmann> then you need to analyse what's going wrong
144 2011-08-13T13:27:47 <Marchael> I guess that's happening becuase whoosh try to concatuate search results from each field.
145 2011-08-13T13:28:34 <Marchael> so "Home*" is equal ("name:Home*" or "name_exact:Home*" or "content:Home*")
146 2011-08-13T13:29:29 <ThomasWaldmann> so that would match on name_exact and produce a hit there
147 2011-08-13T13:30:16 <ThomasWaldmann> which is exactly what we want
148 2011-08-13T13:30:43 <ThomasWaldmann> btw, what whoosh version do you have installed right now?
149 2011-08-13T13:30:48 <Marchael> 2.1.0
150 2011-08-13T13:31:19 <Marchael> btw, if this query failed for one then field, all search failed
151 2011-08-13T13:31:39 <Marchael> "name:Home*" failed and I don't see any results
152 2011-08-13T13:32:08 <ThomasWaldmann> above you said "or" and a "or" is True if one is True
153 2011-08-13T13:32:26 <Marchael> hm
154 2011-08-13T13:32:31 <Marchael> that was query
155 2011-08-13T13:32:39 <ThomasWaldmann> so find out precisely what's happening
156 2011-08-13T13:33:00 <Marchael> whoosh can't process "name:Home*"
157 2011-08-13T13:33:23 <ThomasWaldmann> ?
158 2011-08-13T13:33:23 <Marchael> in normal case that's should work correct
159 2011-08-13T13:34:31 <ThomasWaldmann> are you still guessing? you need to be much more precise and systematic and not guess wildly
160 2011-08-13T13:35:50 <Marchael> ok
161 2011-08-13T13:38:04 <ThomasWaldmann> and btw, it works for me :P
162 2011-08-13T13:38:14 <Marchael> o_0
163 2011-08-13T13:38:23 <ThomasWaldmann> so just show your current code
164 2011-08-13T13:39:05 <Marchael> ThomasWaldmann: https://bitbucket.org/marchael/moin-2.0/src
165 2011-08-13T13:39:30 <Marchael> for whoosh I don't use any patches from my side
166 2011-08-13T13:39:34 <ThomasWaldmann> i mean what you tried about the name_exact change proposed by me
167 2011-08-13T13:39:39 <Marchael> ah
168 2011-08-13T13:41:40 <Marchael> I have slow internet connection, so I need some time to build env265 again
169 2011-08-13T13:42:57 <ThomasWaldmann> you can just have a env (or env260) and env265 in parallel, you do not need to delete it after building it once
170 2011-08-13T13:43:42 <ThomasWaldmann> Marchael: and you could push dreimark to finally remove that huge mathjax :P
171 2011-08-13T13:44:56 <Marchael> :
172 2011-08-13T13:44:57 <Marchael> :)
173 2011-08-13T13:49:46 *** xjjk
174 2011-08-13T13:51:53 <ThomasWaldmann> 'Hom*' -> 'Or([Prefix('name_exact', u'Hom'), Term('name', u'hom'), Prefix('content', u'hom')])'
175 2011-08-13T13:52:00 <ThomasWaldmann> 'Ho*e' -> 'Or([Wildcard('name_exact', u'Ho*e'), And([Term('name', u'ho'), Term('name', u'e')]), Wildcard('content', u'ho*e')])'
176 2011-08-13T13:52:07 <ThomasWaldmann> '*ome' -> 'Or([Wildcard('name_exact', u'*ome'), Term('name', u'ome'), Wildcard('content', u'*ome')])'
177 2011-08-13T13:52:33 <ThomasWaldmann> whoosh is even clever and optimizes some wildcard expressions
178 2011-08-13T13:53:45 <ThomasWaldmann> so, where's your code?
179 2011-08-13T13:54:02 * Marchael still uploading werkzeug
180 2011-08-13T13:54:09 <Marchael> I could try with old env
181 2011-08-13T13:54:14 <Marchael> it's 2.6.5 too
182 2011-08-13T13:54:55 <ThomasWaldmann> and btw, I use a 2.6.0 with whoosh 2.1.0
183 2011-08-13T13:55:01 <ThomasWaldmann> +env
184 2011-08-13T13:59:03 * Marchael downloading sphinx
185 2011-08-13T14:00:31 <ThomasWaldmann> i hope you mean that setup.py / pip is doing that for you
186 2011-08-13T14:01:20 <Marchael> even if I do it by my hands it won't give me a speed advantage
187 2011-08-13T14:08:59 * ThomasWaldmann just reopened one issue (from "on hold")
188 2011-08-13T14:13:48 <Marchael> incoming mathjax
189 2011-08-13T14:19:09 <ThomasWaldmann> so why do you wait for that btw?
190 2011-08-13T14:19:24 <ThomasWaldmann> can't you do something while it is downloading?
191 2011-08-13T14:20:05 <Marchael> yes, I playing on guitar :)
192 2011-08-13T14:20:19 <Marchael> dne
193 2011-08-13T14:20:20 <Marchael> *done
194 2011-08-13T14:21:04 <ThomasWaldmann> guitar play doesn't contribute to SOC score :)
195 2011-08-13T14:21:36 * ThomasWaldmann listens to internet radio
196 2011-08-13T14:24:20 <Marchael> ThomasWaldmann: there is my changes http://codereview.appspot.com/4888043
197 2011-08-13T14:24:30 <Marchael> but traceback is the same
198 2011-08-13T14:26:14 <Marchael> btw, search failed for any list of field
199 2011-08-13T14:26:23 <Marchael> even for "name_exact"
200 2011-08-13T14:27:06 <ThomasWaldmann> precise query? full traceback?
201 2011-08-13T14:27:56 <Marchael> traceback: http://paste.pocoo.org/show/457700/ query: Home*
202 2011-08-13T14:30:25 *** sinha
203 2011-08-13T14:31:16 <ThomasWaldmann> Marchael: $ python
204 2011-08-13T14:31:21 <ThomasWaldmann> import whoosh
205 2011-08-13T14:31:26 <ThomasWaldmann> whoosh.__version__
206 2011-08-13T14:32:25 <ThomasWaldmann> (with activated env with py 2.6.0)
207 2011-08-13T14:33:24 <Marchael> (2, 0, 0)
208 2011-08-13T14:33:24 <Marchael> oops :)
209 2011-08-13T14:33:43 <ThomasWaldmann> pip install --upgrade -e .
210 2011-08-13T14:34:42 <ThomasWaldmann> and while that is downloading the stuff, you put name_exact as first thing, not as 2nd
211 2011-08-13T14:34:43 <Marchael> hm, but it should be 2.1.0
212 2011-08-13T14:34:56 <ThomasWaldmann> well, obviously it isn't
213 2011-08-13T14:35:39 <ThomasWaldmann> if you have some sort of boolean expression, you always put the easy stuff first
214 2011-08-13T14:36:04 <ThomasWaldmann> this will make it run faster due to shortcircuit evaluation
215 2011-08-13T14:37:17 <ThomasWaldmann> http://en.wikipedia.org/wiki/Short-circuit_evaluation
216 2011-08-13T14:42:12 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/457706/ wtf?
217 2011-08-13T14:43:25 <ThomasWaldmann> you need to activate the env
218 2011-08-13T14:43:45 <ThomasWaldmann> you ALWAYS do that, since 2 months
219 2011-08-13T14:44:09 <Marchael> mm? > (env265)[marchael@wtf moin-2.0]
220 2011-08-13T14:44:28 <ThomasWaldmann> and didn't we talk about the 2.6.0 env?
221 2011-08-13T14:44:29 <Marchael> I run '. env265/bin/activate'
222 2011-08-13T14:45:01 <ThomasWaldmann> and why does it tell 2.6(.0) in your 265 env?
223 2011-08-13T14:45:05 <ThomasWaldmann> looks like a mess
224 2011-08-13T14:45:14 *** sinha
225 2011-08-13T14:45:47 <ThomasWaldmann> and after you have activated some env, you just need to enter "python" as the right one is in your path then
226 2011-08-13T14:47:24 <Marchael> hm, I try with 2.6.7
227 2011-08-13T14:48:00 <ThomasWaldmann> if you want to check the unicode keyword thing, you need to use 2.6.0
228 2011-08-13T14:48:00 <ThomasWaldmann> otherwise it won't happen anyway
229 2011-08-13T14:48:22 <ThomasWaldmann> and as the unicode kw issue is fixed in whoosh 2.1.0, there is no such problem any more
230 2011-08-13T14:48:33 <Marchael> that's happend because whoosh 2.0.0
231 2011-08-13T14:48:50 <Marchael> but it should be 2.1.0, hm
232 2011-08-13T14:49:06 <ThomasWaldmann> yes. but as your setup.py says >= 2.0.0, it should be 2.1.0 now
233 2011-08-13T14:49:35 <ThomasWaldmann> but you don't have the right python versions in the right envs
234 2011-08-13T14:50:12 * ThomasWaldmann plays with pypy and moin2 meanwhile
235 2011-08-13T14:52:19 <Marchael> lol
236 2011-08-13T14:52:45 * Marchael put backup of env/lib/../whoosh under root of my repo
237 2011-08-13T14:53:22 <Marchael> so I import whoosh from current workdir and it always been 2.0.0 :)
238 2011-08-13T14:56:06 <ThomasWaldmann> ah X)
239 2011-08-13T15:00:13 <Marchael> ThomasWaldmann: that's happening when I try to search something Traceback (most recent call last): File "/home/marchael/Downloads/moin/moin2/test_repo/moin-2.0/env/lib/python2.6/site-packages/flask/app.py", line 1306, in __call__ return self.wsgi_app(environ, start_response) File "/home/marchael/Downloads/moin/moin2/test_repo/moin-2.0/env/lib/python2.6/site-packages/flask/app.py", line 1294, in wsgi_app response = self.make_response(self.handle_
240 2011-08-13T15:00:17 <Marchael> oops
241 2011-08-13T15:00:30 <Marchael> I'm sorry
242 2011-08-13T15:00:32 <Marchael> http://paste.pocoo.org/show/457712/
243 2011-08-13T15:04:39 <ThomasWaldmann> python version, search query, ...
244 2011-08-13T15:05:03 <ThomasWaldmann> you should always give that info without requiring me to ask for it
245 2011-08-13T15:05:31 <Marchael> python version is the same, it's happening for any query
246 2011-08-13T15:06:17 <ThomasWaldmann> and if you require me to ask "the same as what", i am even less amused
247 2011-08-13T15:07:31 <Marchael> 2.6.0
248 2011-08-13T15:09:13 <ThomasWaldmann> No results for 'any query' < works for me
249 2011-08-13T15:09:39 <ThomasWaldmann> py 2.6.0 and w 2.1.0
250 2011-08-13T15:10:23 <Marchael> may be you could try that with my wiki/ ?
251 2011-08-13T15:10:31 <Marchael> it's about 723K
252 2011-08-13T15:11:13 <ThomasWaldmann> you (and I) can just start from scratch with the default wiki
253 2011-08-13T15:11:37 <Marchael> ok
254 2011-08-13T15:12:45 <Marchael> ThomasWaldmann: working
255 2011-08-13T15:13:00 <Marchael> but we don't know what's may cause that
256 2011-08-13T15:15:26 <ThomasWaldmann> yeah, if you get it again, you need to provide a reproducable test case for mchaput and file a bug in his tracker
257 2011-08-13T15:16:13 <ThomasWaldmann> maybe it could even help if you just give him the traceback and tell that it doesn't happen always and you are unsure about what's triggering it
258 2011-08-13T15:17:34 <Marchael> ok, then what next?
259 2011-08-13T15:18:57 <Marchael> about https://bitbucket.org/marchael/moin-2.0/issue/28/test-for-python-260-compatibility
260 2011-08-13T15:19:13 <Marchael> after updating to 2.1.0 all test are passed
261 2011-08-13T15:19:26 <Marchael> I mean tests in MoinMoin/search/_tests/
262 2011-08-13T15:21:28 <Marchael> ThomasWaldmann: contenttype:text working for me
263 2011-08-13T15:23:16 <Marchael> https://bitbucket.org/marchael/moin-2.0/issue/2/mimetype-analyser-tokenizer-crashes-for it's working
264 2011-08-13T15:23:46 <ThomasWaldmann> well, if the answer to my question there is "no", just require whoosh >= 2.1.0 and close the issue with an appropriate commit comment
265 2011-08-13T15:23:59 <Marchael> ok
266 2011-08-13T15:25:09 <ThomasWaldmann> and as that multitoke_query is fixed now (sane default), try if you still need to give it explicitely
267 2011-08-13T15:26:36 <Marchael> ThomasWaldmann: ok, so could I commit this ? http://paste.pocoo.org/show/457724/
268 2011-08-13T15:27:41 <ThomasWaldmann> yes and refer to the bug you fix with it
269 2011-08-13T15:36:34 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 406966afa113 r431 moin-2.0/MoinMoin/apps/frontend/views.py: Using name_exact schema field for wildcard searching Fixes #26.
270 2011-08-13T15:36:34 <CIA-114> Michael Mayorov <marchael@kb.csu.ru> * 5d805b9f5e91 r432 moin-2.0/setup.py: Require whoosh version not lesser than 2.1.0 Fixes #18.
271 2011-08-13T15:42:27 <Marchael> ThomasWaldmann: what next?
272 2011-08-13T15:43:42 <Marchael> ThomasWaldmann: may be this https://bitbucket.org/marchael/moin-2.0/issue/29/results-ordering-for-search-in-all ? Recently you told me about faceting...
273 2011-08-13T15:44:47 *** m4k3r
274 2011-08-13T15:45:48 <ThomasWaldmann> #28 is still open
275 2011-08-13T15:46:12 <ThomasWaldmann> #17 is also easy
276 2011-08-13T15:51:24 <Marchael> ok, trying #17
277 2011-08-13T16:01:05 <Marchael> bbl
278 2011-08-13T16:04:18 *** m4k3r
279 2011-08-13T16:07:37 <CIA-114> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 319:0c5673f5faa1 2.0/docs/admin/install.rst: updated install docs with some hints for non-system non-default python interpreters, like pypy or other python versions
280 2011-08-13T16:21:47 *** pkumar
281 2011-08-13T17:01:03 *** MattMaker
282 2011-08-13T17:01:30 *** pkumar
283 2011-08-13T17:38:41 *** raignarok
284 2011-08-13T17:40:51 *** raignarok
285 2011-08-13T17:41:25 *** pkumar
286 2011-08-13T17:44:36 *** raignarok
287 2011-08-13T17:50:04 *** MattMaker
288 2011-08-13T17:59:18 <pkumar> xorAxAx : hi, as you know, there were some tests which needed to have app initialized in them specially in storage and datastruct. as per your suggestion for test cleanup I added a function in conftest http://paste.pocoo.org/show/457782/ and removed the app initializations from those tests and seems like it works fine. please tell me if you find something unnecessary/improvement there.
289 2011-08-13T18:01:10 <pkumar> dreimark : ^
290 2011-08-13T18:10:38 *** MattMaker
291 2011-08-13T18:17:55 <pkumar> brb
292 2011-08-13T18:31:32 <xorAxAx> pkumar: looks ok to me
293 2011-08-13T18:33:58 <ThomasWaldmann> ehrm
294 2011-08-13T18:34:43 <ThomasWaldmann> that clean_backend looks strange
295 2011-08-13T18:35:51 <ThomasWaldmann> what shall it do?
296 2011-08-13T18:35:56 <ThomasWaldmann> and why?
297 2011-08-13T18:36:04 *** MattMaker
298 2011-08-13T18:36:46 <xorAxAx> yes, indeed, it destroys all items
299 2011-08-13T18:38:09 <ThomasWaldmann> it looks like it complicatedly works around acls to destroy all items in protected backend
300 2011-08-13T18:38:23 <ThomasWaldmann> and then it also destroy all items in unprotected backend
301 2011-08-13T18:38:31 <ThomasWaldmann> which is the same stuff
302 2011-08-13T18:38:41 <ThomasWaldmann> (just without protection layer)
303 2011-08-13T18:39:40 <ThomasWaldmann> and there is no docstring or comment at all
304 2011-08-13T18:39:53 <ThomasWaldmann> pkumar: ^^
305 2011-08-13T18:40:47 <ThomasWaldmann> pkumar: why aren't you using codereview btw?
306 2011-08-13T18:45:02 *** m4k3r
307 2011-08-13T18:50:17 *** m4k3r
308 2011-08-13T18:51:16 *** m4k3r
309 2011-08-13T18:56:12 *** MattMaker
310 2011-08-13T19:08:40 <pkumar> ThomasWaldmann : hi, sorry for the delay, the code was just for the review. I'll add comments and docstrings to it.
311 2011-08-13T19:12:58 *** m4k3r
312 2011-08-13T19:14:12 *** m4k3r
313 2011-08-13T19:27:18 *** m4k3r
314 2011-08-13T19:58:37 *** raignarok
315 2011-08-13T19:59:40 <Marchael> re
316 2011-08-13T20:03:55 <Marchael> ThomasWaldmann: about #17, aboud additional fields for wiki. How does it will work? wiki admin defines additional fields in wikiconfig, and at application start up this fields will be added to schema?
317 2011-08-13T20:05:50 * dreimark feels pushed. I remove it after i have a local better connection. umts sucks currently
318 2011-08-13T20:06:21 <pkumar> ThomasWaldmann : http://codereview.appspot.com/4900041/
319 2011-08-13T20:08:01 <dreimark> pkumar: cr is much better because we can add comments to lines of source
320 2011-08-13T20:08:42 <dreimark> pkumar: you were faster than me reading backlog over two relays
321 2011-08-13T20:10:35 <pkumar> dreimark : I just put the code in cr : http://codereview.appspot.com/4900041/
322 2011-08-13T20:21:48 <dreimark> pkumar: my comments
323 2011-08-13T20:22:17 <dreimark> bbl
324 2011-08-13T20:24:36 <pkumar> dreimark : laptop out of battery, will reply asap, tanx
325 2011-08-13T20:24:44 *** pkumar
326 2011-08-13T20:33:21 *** MattMaker
327 2011-08-13T20:37:14 *** MattMaker_
328 2011-08-13T20:38:47 *** MattMaker
329 2011-08-13T20:48:24 *** Marchael
330 2011-08-13T20:50:02 *** Marchael
331 2011-08-13T20:51:29 <CIA-114> Akash Sinha <akash2607@gmail.com> * 92314b3890a8 r376 default/MoinMoin/ (3 files in 3 dirs): Ajax destroy feature added on index page (similar to the delete feature).
332 2011-08-13T20:52:37 *** raignarok
333 2011-08-13T20:54:31 <ThomasWaldmann> Marchael: read about dynamic fields in whoosh docs
334 2011-08-13T20:55:01 <Marchael> ThomasWaldmann: I did it.
335 2011-08-13T20:55:42 <ThomasWaldmann> or what i said in the issue tracker. on "problem" with that approach is than key names might look a bit complicated then.
336 2011-08-13T20:55:56 <ThomasWaldmann> just foo won't work for these, must be foo_text or so.
337 2011-08-13T20:56:19 <ThomasWaldmann> so, if one does not want that, configurable fields would be nice.
338 2011-08-13T20:56:33 <ThomasWaldmann> and you can also add dynamic fields there...
339 2011-08-13T20:57:42 <Marchael> I don't quite understand, how user can define dynamic fields configuration?
340 2011-08-13T20:57:50 *** MattMaker_
341 2011-08-13T20:59:15 <ThomasWaldmann> the configuration is python, so the admin can define stuff there, for his users
342 2011-08-13T20:59:37 <Marchael> ok
343 2011-08-13T21:00:51 *** MattMaker
344 2011-08-13T21:01:10 <ThomasWaldmann> of course the stuff that moin needs internally, should not be defined in the config
345 2011-08-13T21:02:47 <Marchael> admin just defines list of dynamic fields, and I use it at moin startup
346 2011-08-13T21:03:16 <ThomasWaldmann> yes
347 2011-08-13T21:03:29 <ThomasWaldmann> make something simple and flexible :)
348 2011-08-13T21:03:52 <Marchael> heh
349 2011-08-13T21:06:06 <Marchael> ThomasWaldmann: hm, but how about compatibility with moin backend?
350 2011-08-13T21:06:39 <Marchael> it'll be add this fields as easy as whoosh?
351 2011-08-13T21:07:12 <ThomasWaldmann> i don't understand the question
352 2011-08-13T21:07:42 <Marchael> hm
353 2011-08-13T21:08:24 <Marchael> Will I have troubles when will be storing content of dynamic fields in moin backend?
354 2011-08-13T21:08:45 <ThomasWaldmann> moin metadata stores anything you want
355 2011-08-13T21:08:52 <Marchael> cool
356 2011-08-13T21:09:29 <ThomasWaldmann> at least any key name, the data types are a bit limited
357 2011-08-13T21:16:32 <Marchael> ThomasWaldmann: I guess, this fields will be added to both schemas?
358 2011-08-13T21:16:51 <ThomasWaldmann> not necessarily
359 2011-08-13T21:17:37 *** MattMaker
360 2011-08-13T21:18:11 <Marchael> ok
361 2011-08-13T21:19:09 <ThomasWaldmann> btw, the internal configuration defaults are in MoinMoin/config/default.py
362 2011-08-13T21:21:23 *** MattMaker
363 2011-08-13T21:36:49 <Marchael> ThomasWaldmann: so value with fields should be defined there?
364 2011-08-13T21:37:59 <Marchael> I defined this value in wikiconfig.py, and have NameError: global name 'dynamic_fields' is not defined
365 2011-08-13T21:38:04 <Marchael> in indexing.py
366 2011-08-13T21:38:23 <Marchael> oops, ignore it
367 2011-08-13T21:40:09 <ThomasWaldmann> first, start thinking about a sane name
368 2011-08-13T21:40:22 *** MattMaker
369 2011-08-13T21:40:23 <ThomasWaldmann> then about a sane default value
370 2011-08-13T21:40:35 <Marchael> hm, seems like whoosh docs confusing me
371 2011-08-13T21:40:37 <ThomasWaldmann> also look at current schema setup code
372 2011-08-13T21:40:44 <Marchael> TypeError: add_field() got an unexpected keyword argument 'glob'
373 2011-08-13T21:40:47 <Marchael> =\
374 2011-08-13T21:41:47 * Marchael looks in whoosh 2.1 docs
375 2011-08-13T21:42:37 <ThomasWaldmann> you don't even need the docs to do that
376 2011-08-13T21:43:56 <Marchael> mm?
377 2011-08-13T21:44:37 <ThomasWaldmann> look how the current fields make up the schema
378 2011-08-13T21:45:40 <Marchael> I add fields to schema after it creation
379 2011-08-13T21:46:09 <Marchael> or I should add fields before creation\opening?
380 2011-08-13T21:47:09 *** MattMaker
381 2011-08-13T21:47:20 <Marchael> and I'm not sure about whoosh actions if index_dir already existed
382 2011-08-13T21:47:45 <Marchael> as for me. better add fields after creation\opening
383 2011-08-13T21:48:21 <Marchael> because in that example Matt create index from scratch
384 2011-08-13T21:48:29 <Marchael> *creates
385 2011-08-13T21:48:54 <Marchael> and added fields _before_ creation
386 2011-08-13T21:53:42 <ThomasWaldmann> well, think about the whole scenario
387 2011-08-13T21:55:22 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4875047
388 2011-08-13T22:02:03 <Marchael> and also dynamic_fields need to be added in default.py
389 2011-08-13T22:02:49 <Marchael> otherwise moin won't started if wiki admin doesn't define that field
390 2011-08-13T22:11:00 <ThomasWaldmann> CR -> incomplete and much too complicated
391 2011-08-13T22:11:45 <Marchael> why is it complicated?
392 2011-08-13T22:12:09 *** MattMaker
393 2011-08-13T22:14:09 *** MattMaker
394 2011-08-13T22:14:12 <ThomasWaldmann> what you need is approx. 4 lines of code, total
395 2011-08-13T22:14:30 <ThomasWaldmann> at least that's my current guess :)
396 2011-08-13T22:14:37 <Marchael> o_)
397 2011-08-13T22:15:05 <ThomasWaldmann> and as the admin is setting up the config, he can also create a fresh index
398 2011-08-13T22:15:42 <ThomasWaldmann> so maybe try directly influencing the schemas
399 2011-08-13T22:16:18 <ThomasWaldmann> and please use 2 config keywords instead of that deeply nested structure
400 2011-08-13T22:16:27 <Marchael> ehrm
401 2011-08-13T22:17:26 <Marchael> ThomasWaldmann: if you just try to add new fields to already existed schema you will break it
402 2011-08-13T22:17:47 <Marchael> and it'll work only afer rebuilding
403 2011-08-13T22:17:55 <Marchael> and it's not dynamic fields
404 2011-08-13T22:18:30 <ThomasWaldmann> so?
405 2011-08-13T22:19:07 <Marchael> wiki admin will be reudilng indexes any time when chaning field configuration
406 2011-08-13T22:19:16 <Marchael> *dynamic_fields
407 2011-08-13T22:20:21 <ThomasWaldmann> how often do you expect wiki admin changes fields?
408 2011-08-13T22:20:39 <Marchael> and if I understand with dynamic fields he doesn't need to rebuild indexes
409 2011-08-13T22:23:14 <Marchael> ThomasWaldmann: it'll be very complicated because wiki admin can't run moiin with broken indexes
410 2011-08-13T22:24:04 <Marchael> he may use old indexes only in case if config correct.
411 2011-08-13T22:24:18 <Marchael> so he need another env to build indexes
412 2011-08-13T22:25:42 <ThomasWaldmann> and you know for sure a changed schema breaks the index, if all previous fields are still there and you just add new ones?
413 2011-08-13T22:26:51 <Marchael> hm, first we try to open
414 2011-08-13T22:27:01 <Marchael> if open fails we create indexes from scratch
415 2011-08-13T22:27:09 <Marchael> so indexes will be erased
416 2011-08-13T22:27:20 <Marchael> at start up
417 2011-08-13T22:27:24 <ThomasWaldmann> does open fail if you just add a new field?
418 2011-08-13T22:27:49 <Marchael> I guess yes, because fields set is different
419 2011-08-13T22:28:01 <Marchael> iirc
420 2011-08-13T22:28:40 * Marchael make test for sure
421 2011-08-13T22:30:29 *** MattMaker
422 2011-08-13T22:31:10 <Marchael> ThomasWaldmann: yes, it failed
423 2011-08-13T22:31:43 <ThomasWaldmann> hmm, fsck :)
424 2011-08-13T22:31:58 <ThomasWaldmann> and you just added a field and not removed one?
425 2011-08-13T22:32:06 <Marchael> yes
426 2011-08-13T22:33:01 <Marchael> It's exit with ValueError: indexname <Schema: ['content', 'path', 'shit', 'title']> is not a string
427 2011-08-13T22:33:27 <Marchael> > ['content', 'path', 'shit', 'title'] are existed fields
428 2011-08-13T22:33:47 <ThomasWaldmann> ok, then you need to do a bit more lines.
429 2011-08-13T22:33:56 <Marchael> :)
430 2011-08-13T22:34:31 <ThomasWaldmann> but that error msg is strange
431 2011-08-13T22:35:49 <Marchael> ThomasWaldmann: there is more vervose version http://paste.pocoo.org/show/457872/
432 2011-08-13T22:36:18 <Marchael> *verbose
433 2011-08-13T22:37:06 <ThomasWaldmann> hmm sounds suspicious
434 2011-08-13T22:37:13 * ThomasWaldmann tries himself
435 2011-08-13T22:37:18 <Marchael> also, you may could help me find out what's wrong with "glob" parameter and I'll make my code working.
436 2011-08-13T22:37:28 <dreimark> sinha: have you seen my request about create item ?
437 2011-08-13T22:39:34 <sinha> dreimark: yes, i am doing that now
438 2011-08-13T22:39:39 <dreimark> ok
439 2011-08-13T22:40:57 <dreimark> sinha: may be the input box could also have this "upload files" as alternative to create only one item
440 2011-08-13T22:42:10 <dreimark> for many items, then we have this on a location where the user finds it always. and we have still the possibility to drag files for uploading
441 2011-08-13T22:42:13 <ThomasWaldmann> Marchael: how did you make it crash, it doesn't crash for me
442 2011-08-13T22:42:41 <sinha> dreimark: we already have upload files button, so you want me to put the same thing there also
443 2011-08-13T22:42:49 <sinha> in the input box
444 2011-08-13T22:45:22 <Marchael> ThomasWaldmann: may be you show me the code what you used?
445 2011-08-13T22:47:50 <Marchael> ThomasWaldmann: if it wasn't crash then you probably erase index
446 2011-08-13T22:48:39 <ThomasWaldmann> i remove the exception handler and added a field to the schema
447 2011-08-13T22:49:27 <Marchael> with create_in?
448 2011-08-13T22:49:52 <dreimark> sinha: http://test.moinmo.in/CreateItem
449 2011-08-13T22:50:04 <dreimark> I mean something like this
450 2011-08-13T22:50:20 <dreimark> and keep on the index page the drop functionality
451 2011-08-13T22:50:29 <ThomasWaldmann> i just did the changes and restarted moin
452 2011-08-13T22:51:03 <Marchael> could you please make moin index --for both --action show?
453 2011-08-13T22:51:17 <sinha> dreimark: so you are saying to move that upload files thing over that obx
454 2011-08-13T22:51:23 <sinha> *box
455 2011-08-13T22:51:59 <Marchael> ThomasWaldmann: I think what you add new field, create new index in index_dir and erase old index
456 2011-08-13T22:52:01 <dreimark> yes, then it is in a context of creating items
457 2011-08-13T22:52:04 <dreimark> sinha: ^
458 2011-08-13T22:52:53 <sinha> okay, so i will move that upload file button to that box and when all the files gets uploaded, i will close the box and then one can see the newly created items at top
459 2011-08-13T22:53:06 <dreimark> sinha: yes
460 2011-08-13T22:55:36 *** MattMaker
461 2011-08-13T22:55:53 <sinha> dreimark: i just have one issue in this, whenever we upload items by clicking on upload button OR by dragging, we see that "Start All", "Cancel All" buttons thing, so how should i handle this, because if i shift that upload form over that box this whole buttons will also get shifted, so when one drags files on screen, how will he see those there ?
462 2011-08-13T22:57:00 <sinha> okay i will try to deal with this by moving the htmls from one div to other
463 2011-08-13T22:58:30 <ThomasWaldmann> hmm, it tells EmptyIndexError
464 2011-08-13T23:00:22 <Marchael> yep
465 2011-08-13T23:00:28 <Marchael> you erased index
466 2011-08-13T23:00:58 <Marchael> so may be we'll try use dynamyc fields then?
467 2011-08-13T23:02:05 <ThomasWaldmann> no, I didn't erase index
468 2011-08-13T23:02:23 <ThomasWaldmann> but it looks like for whoosh a non-matching index is like an empty one?
469 2011-08-13T23:03:03 <Marchael> only if you specifed indexname
470 2011-08-13T23:03:07 <ThomasWaldmann> yeah, as a first step, think about just some dynamic fields
471 2011-08-13T23:03:18 <Marchael> but we don't want duplicate indexnames, right?
472 2011-08-13T23:03:54 <ThomasWaldmann> eh?
473 2011-08-13T23:06:04 <Marchael> if I understand right you just specified another indexanme for new index, you didn't erase old, but create another copy or somelike
474 2011-08-13T23:06:17 <dreimark> sinha: hmm, please try if that can be moved
475 2011-08-13T23:07:39 <sinha> yes
476 2011-08-13T23:08:58 <ThomasWaldmann> no i didn't
477 2011-08-13T23:09:09 <ThomasWaldmann> i just changed the schema in the code
478 2011-08-13T23:10:27 <Marchael> ThomasWaldmann: please show me your code, because I don't understand
479 2011-08-13T23:11:32 <Marchael> ThomasWaldmann: do you using schema.add() for adding new fields?
480 2011-08-13T23:13:56 <ThomasWaldmann> http://paste.pocoo.org/show/457886/ that (after first running moin to have a normal index)
481 2011-08-13T23:19:24 * Marchael looks
482 2011-08-13T23:24:38 <ThomasWaldmann> ignore that, it doesn't make sense
483 2011-08-13T23:24:51 <ThomasWaldmann> the schema is only used at creation time
484 2011-08-13T23:26:17 <ThomasWaldmann> so, first make an easy change with those dynamic fields. built in in moin's internal schema, no configuration.
485 2011-08-13T23:26:25 *** MattMaker
486 2011-08-13T23:26:37 <ThomasWaldmann> think about globs
487 2011-08-13T23:35:14 <dreimark> gn
488 2011-08-13T23:35:23 <Marchael> gn dreimark
489 2011-08-13T23:35:55 <Marchael> ThomasWaldmann: I made it, but take "Invalid JSON." when try to submit page
490 2011-08-13T23:36:13 <Marchael> I want to add something like "short_text": "moooo",
491 2011-08-13T23:37:33 <Marchael> ThomasWaldmann: http://codereview.appspot.com/4875047 ps 2
492 2011-08-13T23:38:37 <ThomasWaldmann> don't have a comma after last item
493 2011-08-13T23:38:48 <ThomasWaldmann> that's ok in py, but not in json
494 2011-08-13T23:39:13 <Marchael> ah :)
495 2011-08-13T23:42:43 <Marchael> doesn't work
496 2011-08-13T23:43:03 <Marchael> I tried add tags for Home and it was useless
497 2011-08-13T23:43:25 <Marchael> s/tags/metadata/
498 2011-08-13T23:45:54 *** raignarok
499 2011-08-13T23:46:02 *** MattMaker
500 2011-08-13T23:48:57 <ThomasWaldmann> tags work
501 2011-08-13T23:49:06 <Marchael> hm?
502 2011-08-13T23:49:20 <Marchael> what a search query?
503 2011-08-13T23:49:57 <Marchael> you meant _tag ?
504 2011-08-13T23:50:06 <ThomasWaldmann> json:
505 2011-08-13T23:50:17 <ThomasWaldmann> "tags": ["foo", "bar"]
506 2011-08-13T23:50:20 <Marchael> mm, no that stuff working correct
507 2011-08-13T23:50:21 <ThomasWaldmann> query:
508 2011-08-13T23:50:24 <ThomasWaldmann> tags:foo
509 2011-08-13T23:50:52 <Marchael> tags working yes, I meant searching in dynamic fields
510 2011-08-13T23:51:23 <ThomasWaldmann> what did you try?
511 2011-08-13T23:51:45 <Marchael> I add taht fields in metadata of Home and try query like short_text:* and didn"short_text": "moooo"'t find anything
512 2011-08-13T23:52:17 <Marchael> "short_text": "moooo" is field: value
513 2011-08-13T23:53:41 <ThomasWaldmann> code looks like?
514 2011-08-13T23:55:02 <Marchael> (03:33:22) Marchael: ThomasWaldmann: http://codereview.appspot.com/4875047 ps 2
515 2011-08-13T23:57:58 <ThomasWaldmann> revert that all and make a SIMPLE change to the builtin schema, as I said
