1 2011-10-02T00:19:07 <dreimark> ThomasWaldmann: how much entries? but also I wonder a bit this can't be much data that it take 92seconds
2 2011-10-02T00:19:35 <ThomasWaldmann> about 5000 revs total
3 2011-10-02T00:26:57 <dreimark> how long takes the query?
4 2011-10-02T00:28:06 <ThomasWaldmann> 50ms
5 2011-10-02T00:28:19 <ThomasWaldmann> i guess i know what's happening
6 2011-10-02T00:29:04 <ThomasWaldmann> the search yields Revision objects (not whoosh documents)
7 2011-10-02T00:30:27 <dreimark> but that are then only 5000 objects, how much data is that.
8 2011-10-02T00:30:40 <ThomasWaldmann> so, depending on what is accessed how, that might trigger quite some code
9 2011-10-02T00:35:20 <ThomasWaldmann> (acl code, accessing storage, opening data files, ...)
10 2011-10-02T00:36:47 <dreimark> everything for gh is in meta
11 2011-10-02T00:37:24 <dreimark> acls need be filered
12 2011-10-02T00:37:40 <dreimark> +t
13 2011-10-02T00:37:54 <ThomasWaldmann> why is that bookmark check in that loop?
14 2011-10-02T00:47:15 * dreimark looks at cr
15 2011-10-02T00:50:10 <dreimark> http://codereview.appspot.com/4592048/patch/9001/10001
16 2011-10-02T00:51:33 <dreimark> i don't see now a reason why it is there, because it is also in the query
17 2011-10-02T00:53:56 <ThomasWaldmann> i'll remove it
18 2011-10-02T00:54:16 <dreimark> wait, may be it is because of days
19 2011-10-02T01:00:32 <dreimark> ThomasWaldmann: it is obsolete
20 2011-10-02T01:00:36 <dreimark> kill it
21 2011-10-02T01:47:54 <ThomasWaldmann> the Revision is only optimized for current rev with the doc from the index
22 2011-10-02T01:49:24 <ThomasWaldmann> for non-current rev stuff is loaded from storage
23 2011-10-02T01:53:34 * dreimark is to tired, gn
24 2011-10-02T01:54:03 <ThomasWaldmann> gn dreimark
25 2011-10-02T08:59:09 *** raignarok
26 2011-10-02T10:03:21 *** birkenfeld
27 2011-10-02T10:07:00 *** birkenfeld
28 2011-10-02T10:24:43 *** raignarok
29 2011-10-02T10:55:51 *** raignarok
30 2011-10-02T11:01:19 *** birkenfeld
31 2011-10-02T11:10:39 *** raignarok
32 2011-10-02T12:08:41 <ThomasWaldmann> moin
33 2011-10-02T12:33:32 *** raignarok
34 2011-10-02T14:01:58 *** greg_f
35 2011-10-02T14:07:14 *** greg_f
36 2011-10-02T14:14:58 *** greg_f
37 2011-10-02T15:33:38 *** raignarok
38 2011-10-02T15:56:04 *** greg_f
39 2011-10-02T16:15:47 *** brunosmartin
40 2011-10-02T16:15:54 *** brunosmartin
41 2011-10-02T16:27:38 *** brunosmartin
42 2011-10-02T16:28:18 *** brunosmartin
43 2011-10-02T16:35:27 *** brunosmartin
44 2011-10-02T16:35:32 *** brunosmartin
45 2011-10-02T16:37:05 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> storage-ng * 915:3b9bef437212 2.0/MoinMoin/apps/frontend/views.py: global history: remove superfluous bookmark comparison, extract from rev what we need only
46 2011-10-02T16:37:06 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> storage-ng * 916:ac600982e40a 2.0/MoinMoin/storage/middleware/indexing.py: (log message trimmed)
47 2011-10-02T16:37:06 <CIA-65> fine tune / optimize Revision object creation, MetaData access
48 2011-10-02T16:37:06 <CIA-65> optimize Revision object creation if we already have the relevant whoosh doc.
49 2011-10-02T16:37:06 <CIA-65> If we do not have the whoosh doc for the revision, load it from index - this
50 2011-10-02T16:37:07 <CIA-65> is good for:
51 2011-10-02T16:37:07 <CIA-65> a) having it (avoid storage access)
52 2011-10-02T16:37:08 <CIA-65> b) triggering a KeyError early if we do not have that revision
53 2011-10-02T16:37:22 *** brunosmartin
54 2011-10-02T16:37:26 *** brunosmartin
55 2011-10-02T17:11:16 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> storage-ng * 917:772c4c8db164 2.0/MoinMoin/storage/middleware/indexing.py: fix optimize_index to accept a tmp param
56 2011-10-02T18:59:34 <ThomasWaldmann> dreimark: http://moinmo.in/WikiSandBox?action=AttachFile&do=get&target=globalhistory.png
57 2011-10-02T19:13:07 <dreimark> ThomasWaldmann: horrible
58 2011-10-02T19:18:01 * dreimark in the past that size had crashed browsers
59 2011-10-02T19:18:20 <dreimark> htg, bbl
60 2011-10-02T19:40:55 *** greg_f
61 2011-10-02T19:41:06 *** raignarok
62 2011-10-02T20:23:13 *** MattMaker
63 2011-10-02T20:52:53 * ThomasWaldmann implements a much simpler global history
64 2011-10-02T22:50:06 *** MattMaker
65 2011-10-02T23:12:25 <dreimark> re
66 2011-10-02T23:43:20 <ThomasWaldmann> wb dreimark
67 2011-10-02T23:43:47 <ThomasWaldmann> global history is much faster now, but also much simpler. will commit soon.
68 2011-10-02T23:56:02 *** raignarok
69
MoinMoin: MoinMoinChat/Logs/moin-dev/2011-10-02 (last edited 2011-10-01 22:45:03 by IrcLogImporter)