MoinMoin: MoinMoinChat/Logs/moin-dev/2011-10-09

   1 2011-10-09T00:00:28  <ThomasWaldmann> both
   2 2011-10-09T00:00:46  <vedranm> :)
   3 2011-10-09T00:01:43  <ThomasWaldmann> the old method of python was inspired by C, btw (at least the basics, they added more power then)
   4 2011-10-09T00:04:03  <vedranm> ok, this doesn't make much sense
   5 2011-10-09T00:04:04  <vedranm> x.set('user.moin-pep8-tested-mtime', '%d' % mtime)
   6 2011-10-09T00:04:16  <vedranm> test_sourcecode.py
   7 2011-10-09T00:04:22  <vedranm> perhaps it would be better like
   8 2011-10-09T00:04:29  <vedranm> x.set('user.moin-pep8-tested-mtime', str(mtime))
   9 2011-10-09T00:05:52  <ThomasWaldmann> be careful, mtime can be float
  10 2011-10-09T00:06:06  <vedranm> ok...
  11 2011-10-09T00:06:19  <vedranm> so, what will be wrong in my approach?
  12 2011-10-09T00:06:26  <vedranm> compared to current one?
  13 2011-10-09T00:06:41  <vedranm> does %d round floats?
  14 2011-10-09T00:08:22  <ThomasWaldmann> >>> '%d' % 1.23
  15 2011-10-09T00:08:22  <ThomasWaldmann> '1'
  16 2011-10-09T00:08:54  <vedranm> so I should do something like str(int(mtime))?
  17 2011-10-09T00:09:09  <ThomasWaldmann> either that or leave it :)
  18 2011-10-09T00:11:36  <vedranm> what is %r?
  19 2011-10-09T00:11:48  <ThomasWaldmann> repr(x)
  20 2011-10-09T00:11:59  <vedranm> ok
  21 2011-10-09T00:32:34  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 941:37f1d312a617 2.0/docs/user/searching.rst: remove duplicate search docs, see search.rst
  22 2011-10-09T00:48:41  <vedranm> ThomasWaldmann: there is a lot of repeating code
  23 2011-10-09T00:48:55  <vedranm> for __repr__ for example
  24 2011-10-09T00:49:06  <vedranm> or let me say it better, it looks repeating to me
  25 2011-10-09T00:50:45  <ThomasWaldmann> like?
  26 2011-10-09T00:52:03  <vedranm> sorry
  27 2011-10-09T00:52:10  <vedranm> it just looks similar
  28 2011-10-09T00:52:17  <vedranm> it deals with different types of objects
  29 2011-10-09T00:52:20  <vedranm> nm
  30 2011-10-09T00:54:04  *** MattMaker has quit IRC
  31 2011-10-09T00:54:25  <vedranm> %.2f means decimal with two digits after dot?
  32 2011-10-09T00:54:50  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 942:e39466232243 2.0/MANIFEST.in: update MANIFEST.in, remove pyc/pyo exclude (these are not added with setup.py sdist anyway)
  33 2011-10-09T00:55:20  <ThomasWaldmann> f = float, yes, 2 digits after dot
  34 2011-10-09T00:56:46  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 943:6276934159df 2.0/Makefile: update Makefile
  35 2011-10-09T00:59:36  <ThomasWaldmann> moin-2.0$ time moin save --file foo.moin # 76MB stuff
  36 2011-10-09T00:59:47  <ThomasWaldmann> real	0m3.349s
  37 2011-10-09T01:00:02  <vedranm> nice :)
  38 2011-10-09T01:00:06  <vedranm> that's for backups?
  39 2011-10-09T01:00:16  <ThomasWaldmann> yes, for example
  40 2011-10-09T01:01:07  <ThomasWaldmann> i don't have comparable timings, but i bet that is much faster than the previous xml stuff
  41 2011-10-09T01:06:17  <ThomasWaldmann> load is not much slower, but building the index afterwards takes time...
  42 2011-10-09T01:07:06  <ThomasWaldmann> ronny: ^^ good idea :)
  43 2011-10-09T01:08:21  <ThomasWaldmann> index build = 4 min (~96MB index files)
  44 2011-10-09T01:11:21  <ThomasWaldmann> that was a single index writer, now trying multi segment writer
  45 2011-10-09T01:31:32  <vedranm> good night
  46 2011-10-09T01:31:45  <vedranm> I will finish the conversion in the morning
  47 2011-10-09T01:35:06  <ThomasWaldmann> gn vedranm
  48 2011-10-09T01:35:34  * ThomasWaldmann reads news about the german state's trojan
  49 2011-10-09T01:49:39  *** raignarok has quit IRC
  50 2011-10-09T02:13:39  *** MattMaker has joined #moin-dev
  51 2011-10-09T02:51:26  *** MattMaker has quit IRC
  52 2011-10-09T02:57:26  *** MattMaker has joined #moin-dev
  53 2011-10-09T03:36:59  *** MattMaker has quit IRC
  54 2011-10-09T04:48:43  *** MattMaker has joined #moin-dev
  55 2011-10-09T06:10:20  *** MattMaker has quit IRC
  56 2011-10-09T07:59:11  *** vedranm has quit IRC
  57 2011-10-09T08:37:06  *** vedranm has joined #moin-dev
  58 2011-10-09T09:18:31  <vedranm> hi ThomasWaldmann
  59 2011-10-09T09:58:50  <vedranm> MoinMoin/util/plugins.py line 170 passes to function variable named type
  60 2011-10-09T09:58:55  <vedranm> which is not optimal
  61 2011-10-09T09:59:13  <vedranm> perhaps we should rename it to typename or something else
  62 2011-10-09T10:38:16  *** greg_f has joined #moin-dev
  63 2011-10-09T11:14:30  *** eSyr has quit IRC
  64 2011-10-09T11:16:55  *** raignarok has joined #moin-dev
  65 2011-10-09T11:21:47  *** eSyr has joined #moin-dev
  66 2011-10-09T12:44:40  *** raignarok has quit IRC
  67 2011-10-09T13:09:03  <ThomasWaldmann> moin
  68 2011-10-09T13:26:43  *** raignarok has joined #moin-dev
  69 2011-10-09T13:41:40  <vedranm> hi ThomasWaldmann
  70 2011-10-09T13:43:29  <vedranm> similar comment as for type MoinMoin/converter/html_out.py has function that uses variable named id
  71 2011-10-09T13:46:03  <ThomasWaldmann> yes, there are some places that use names shadowing builtins
  72 2011-10-09T13:46:21  <ThomasWaldmann> but as i said, try to create clean changesets and concentrate on one thing :)
  73 2011-10-09T13:49:14  <dreimark> bbl
  74 2011-10-09T13:51:48  <vedranm> of course
  75 2011-10-09T13:52:16  <vedranm> just mentioning it
  76 2011-10-09T13:52:53  <ThomasWaldmann> if we like, we can use some sourcecode checker to find them all
  77 2011-10-09T14:27:45  * ThomasWaldmann puts some more bugs / todos into the tracker
  78 2011-10-09T14:29:03  *** raignarok has quit IRC
  79 2011-10-09T14:53:58  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 944:a88cbac3100b 2.0/MoinMoin/storage/backends/fileserver.py: fileserver backend: add real mimetype detection
  80 2011-10-09T15:13:37  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 945:2ba60188efde 2.0/MoinMoin/storage/middleware/indexing.py: indexing: add index close at some places, use try/finally
  81 2011-10-09T15:38:45  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 946:001077ec4540 2.0/MoinMoin/util/mimetype.py: MimeType: do not make potentially wrong assumptions that charset is utf-8
  82 2011-10-09T15:38:46  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 947:b3b26981eb75 2.0/MoinMoin/ (_tests/test_wikiutil.py util/_tests/test_mimetype.py): fix tests for the changed MimeType behaviour
  83 2011-10-09T15:41:43  <ThomasWaldmann> xorAxAx: look at test_mimetype.py to see misc formatting, pep8 and wtf-kind fails
  84 2011-10-09T15:57:20  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 948:77ef4841b4f4 2.0/MoinMoin/storage/middleware/indexing.py: yielding all documents for no kw args is done by whoosh now
  85 2011-10-09T15:57:21  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 949:c93f5999c08e 2.0/MoinMoin/ (config/default.py util/edit_lock.py): remove edit lock code (was not used and did not work anyway. needs to be done differently.)
  86 2011-10-09T16:10:08  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 950:57ac61f78053 2.0/MoinMoin/app.py: MoinMoin.app: remove unneeded imports, cosmetic changes
  87 2011-10-09T17:05:25  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 951:cbb305935d49 2.0/MoinMoin/storage/middleware/indexing.py: prepare for using RegexPlugin
  88 2011-10-09T17:32:25  * ThomasWaldmann fixed 3 whoosh bugs
  89 2011-10-09T18:23:25  *** MattMaker has joined #moin-dev
  90 2011-10-09T19:10:20  <dreimark> re
  91 2011-10-09T19:17:55  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 952:308ba8de39c4 2.0/MoinMoin/storage/middleware/indexing.py: simplify code for finding latest revisions, whoosh >= 2.3.0 now has group value lists in right order
  92 2011-10-09T19:32:50  <dreimark> ThomasWaldmann: is http://localhost:8080/+meta/Home/Bild.JPG expected to work currently?
  93 2011-10-09T19:33:21  <dreimark> hg branch shows me default
  94 2011-10-09T19:35:03  <ThomasWaldmann> hmm, there seems to be some brokenness
  95 2011-10-09T19:35:33  * dreimark makes a issue for that, looking currently on what to add there
  96 2011-10-09T19:36:37  <ThomasWaldmann> the meta link from history works
  97 2011-10-09T19:36:50  <ThomasWaldmann> maybe just a wrong default
  98 2011-10-09T19:37:29  <dreimark> yes, some not all are somehow broken, i try to get a list into the issue
  99 2011-10-09T19:38:08  *** greg_f has quit IRC
 100 2011-10-09T19:38:55  <ThomasWaldmann> uhoh
 101 2011-10-09T19:39:06  <ThomasWaldmann> it does not know what is what
 102 2011-10-09T19:39:38  <ThomasWaldmann> @frontend.route('/+meta/<itemname:item_name>', defaults=dict(rev=CURRENT))
 103 2011-10-09T19:39:38  <moinBot> ThomasWaldmann: Error: "frontend.route('/+meta/<itemname:item_name>'," is not a valid command.
 104 2011-10-09T19:39:38  <ThomasWaldmann> @frontend.route('/+meta/<rev>/<itemname:item_name>')
 105 2011-10-09T19:39:39  <moinBot> ThomasWaldmann: Error: "frontend.route('/+meta/<rev>/<itemname:item_name>')" is not a valid command.
 106 2011-10-09T19:39:53  <ThomasWaldmann> moinBot: shut up
 107 2011-10-09T19:39:53  <moinBot> ThomasWaldmann: Error: "shut" is not a valid command.
 108 2011-10-09T19:40:23  <ThomasWaldmann> the problem is that this url matches both rules
 109 2011-10-09T19:41:36  <dreimark> at least it did not silently give the first,
 110 2011-10-09T19:41:48  <ThomasWaldmann> so, for you case, it thinks that "Home" is a revid
 111 2011-10-09T19:42:41  <ThomasWaldmann> looks like the time for a url redesign has come
 112 2011-10-09T19:43:37  <dreimark> i currently report everything i get which looks broken to the issue tracker
 113 2011-10-09T19:44:12  <dreimark> may be if redesign we can move the restful part at the last position of the url
 114 2011-10-09T19:45:33  <ThomasWaldmann> yes, we need a good plan :)
 115 2011-10-09T19:47:11  <ThomasWaldmann> we could make a part of the url a whoosh query :)
 116 2011-10-09T19:48:02  <dreimark> how does that look like?
 117 2011-10-09T19:48:31  <ThomasWaldmann> revid:13901928301983123
 118 2011-10-09T19:48:48  <ThomasWaldmann> itemid:123123141421313132
 119 2011-10-09T19:49:23  <ThomasWaldmann> name:FooBar (default, so: FooBar)
 120 2011-10-09T19:49:55  <ThomasWaldmann> i think that idea is mad and powerful enough for deeper thinking
 121 2011-10-09T19:51:13  <dreimark> hmm, that looks simple. does it allow to have directaccess for put and get?
 122 2011-10-09T19:51:58  <dreimark> by url. that works currently and I like that.
 123 2011-10-09T19:52:38  <dreimark> i'm not sure how : behaves on IE
 124 2011-10-09T19:53:56  * ThomasWaldmann adds it to the issue tracker
 125 2011-10-09T20:12:09  <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/74/mad-url-redesign-item-lookup-idea
 126 2011-10-09T20:28:54  <ThomasWaldmann> i feel this would be quite powerful :)
 127 2011-10-09T20:31:57  * dreimark looks
 128 2011-10-09T20:33:19  <dreimark> ids are always numbers?
 129 2011-10-09T20:33:37  <dreimark> otherwise we can't destinguiesh names with those
 130 2011-10-09T20:35:08  <dreimark> userid == name? because we should not show the inernal uid for the user object
 131 2011-10-09T20:36:22  <dreimark> and it must make the additional  selection based on acls not exposing stuff
 132 2011-10-09T20:44:45  <ThomasWaldmann> ids are uuids
 133 2011-10-09T20:45:08  <ThomasWaldmann> hex
 134 2011-10-09T20:51:57  <dreimark> ah good, before s_ng it could also be a name.
 135 2011-10-09T20:52:30  <dreimark> we should not allow names like those ids
 136 2011-10-09T20:56:00  <ThomasWaldmann> i think THAT is not a problem
 137 2011-10-09T20:56:20  <ThomasWaldmann> think of what you can type into the search query field
 138 2011-10-09T20:57:03  <ThomasWaldmann> if you type "cafe", it will look up this in the default fields (name, text, name_exact)
 139 2011-10-09T20:57:32  <ThomasWaldmann> if you type "revid:cafe", it will lookup in the revid field
 140 2011-10-09T20:58:10  <ThomasWaldmann> so problematic are just names that resemble fieldname:something
 141 2011-10-09T21:03:39  <ThomasWaldmann> we could disallow names starting with some specific char (like + as we have it now)
 142 2011-10-09T21:03:58  <ThomasWaldmann> then +fieldname is used instead of fieldname
 143 2011-10-09T21:04:33  <ThomasWaldmann> and if there is no +xxxx, the fieldname is missing
 144 2011-10-09T21:07:58  <ThomasWaldmann> (this is mostly an issue that will happen in whoosh's query parser then)
 145 2011-10-09T21:13:50  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 953:326f7a365007 2.0/MoinMoin/ (14 files in 11 dirs): search/indexing: remove all_revs=False params (it is the default)
 146 2011-10-09T21:37:52  * ThomasWaldmann will change that flag to an index name now
 147 2011-10-09T22:44:26  *** vedranm has quit IRC
 148 2011-10-09T22:49:12  *** MattMaker has quit IRC
 149 2011-10-09T23:11:34  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 954:f79d471667b9 2.0/MoinMoin/ (7 files in 6 dirs): search/indexing: replace all_revs (boolean) by idx_name (index name str) - easier code, more flexible
 150 2011-10-09T23:33:22  <dreimark> gn
 151 2011-10-09T23:33:54  <ThomasWaldmann> gn dreimark
 152 2011-10-09T23:49:27  <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 955:b48e18209f1a 2.0/MoinMoin/ (apps/frontend/views.py config/default.py items/__init__.py):
 153 2011-10-09T23:49:27  <CIA-65> remove copy_item, see below
 154 2011-10-09T23:49:27  <CIA-65> there is no implementation for this on storage level.
 155 2011-10-09T23:49:27  <CIA-65> semantics and uses cases are unclear (esp. as we can fork now).
 156 2011-10-09T23:49:27  <CIA-65> if there is a good plan for it, we can reimplement it later.