1 2011-11-23T00:01:22 <ThomasWaldmann> ok, i need to drive home, bbl / tomorrow
2 2011-11-23T00:01:26 <izibi> this works: http://paste.pocoo.org/show/511659/
3 2011-11-23T00:01:40 <izibi> running this two times in a view breaks stuff: http://paste.pocoo.org/show/511656/
4 2011-11-23T00:01:49 <izibi> what's the difference?
5 2011-11-23T00:03:18 <izibi> i think i've found the problem
6 2011-11-23T00:03:27 <izibi> let's see
7 2011-11-23T00:03:55 <jbillsgci11> ThomasWaldmann: I am done. Had to edit html_out.py though. Ill submit a patch soon. I needz food
8 2011-11-23T00:05:03 <ThomasWaldmann> great :)
9 2011-11-23T00:05:06 <ThomasWaldmann> brb
10 2011-11-23T00:05:30 <izibi> yes
11 2011-11-23T00:05:35 <izibi> can't be true...
12 2011-11-23T00:06:02 <izibi> 'openid': form['openid'].value, <-- there's your problem
13 2011-11-23T00:07:41 <izibi> next question: WHY does the openid parameter break everything
14 2011-11-23T00:13:12 *** brunomartin
15 2011-11-23T00:14:31 <izibi> i guess this is the gci of bugs :D
16 2011-11-23T00:21:43 <izibi> so what to do with that openid stuff
17 2011-11-23T00:22:40 <izibi> http://paste.pocoo.org/show/511665/
18 2011-11-23T00:28:50 <jbillsgci11> I have submitted what will hopefully be my last piece of work. I have looked over the patch. It has everything it needs.
19 2011-11-23T00:35:56 *** grzywacz
20 2011-11-23T00:58:51 <ThomasWaldmann> re
21 2011-11-23T00:59:39 <ThomasWaldmann> izibi: why is that a problem? because the form does not have that key?
22 2011-11-23T01:03:41 <ThomasWaldmann> izibi: why is that needed?
23 2011-11-23T01:03:53 <ThomasWaldmann> (i mean the changes in the diff)
24 2011-11-23T01:06:17 <ThomasWaldmann> jbillsgci11: still there?
25 2011-11-23T01:06:24 <jbillsgci11> yup
26 2011-11-23T01:06:41 <ThomasWaldmann> the h4 is missing the font size
27 2011-11-23T01:06:55 <jbillsgci11> It wasnt there orriginally
28 2011-11-23T01:07:03 <ThomasWaldmann> wouldn't it be better and more consistent to have it?
29 2011-11-23T01:07:07 <ThomasWaldmann> ah.
30 2011-11-23T01:07:32 <jbillsgci11> It would be more consistent though
31 2011-11-23T01:07:52 <jbillsgci11> I didnt know if someone had removed it for a reason though
32 2011-11-23T01:08:24 <ThomasWaldmann> the text-deco none is for what?
33 2011-11-23T01:09:15 <jbillsgci11> a line started appearing underneath the paragraph icon
34 2011-11-23T01:09:32 <jbillsgci11> I did not think it was supposed to be there
35 2011-11-23T01:10:33 <ThomasWaldmann> the underlining line or another one?
36 2011-11-23T01:10:54 <jbillsgci11> the underlining
37 2011-11-23T01:11:02 <jbillsgci11> so un undecorated it
38 2011-11-23T01:11:08 <jbillsgci11> oops
39 2011-11-23T01:11:15 <jbillsgci11> one un to many
40 2011-11-23T01:12:02 <ThomasWaldmann> so the underlining now is broken into 2 pieces on hover?
41 2011-11-23T01:12:52 <jbillsgci11> what do you mean?
42 2011-11-23T01:13:11 <ThomasWaldmann> there is one long line under the heading, even on hover?
43 2011-11-23T01:13:24 <jbillsgci11> yup
44 2011-11-23T01:13:30 <ThomasWaldmann> ok
45 2011-11-23T01:13:34 <jbillsgci11> do you want it gone on hover
46 2011-11-23T01:13:38 <jbillsgci11> ?
47 2011-11-23T01:13:43 <jbillsgci11> not to hard to do
48 2011-11-23T01:13:58 <ThomasWaldmann> i'll just apply your patch and look myself :)
49 2011-11-23T01:14:03 <jbillsgci11> ok
50 2011-11-23T01:17:55 <izibi> 23:13 < ThomasWaldmann> that looks like correct if you want to create an authenticated user <-- that's why i've changed the way to fetch the user, i don't know whats better
51 2011-11-23T01:18:06 <izibi> but this doesn't really change anything
52 2011-11-23T01:18:26 <izibi> the only relevant change is omitting the openid kwarg to create_user
53 2011-11-23T01:18:58 <izibi> i don't know why, but then it doesn't work any more
54 2011-11-23T01:19:04 <ThomasWaldmann> ah, interesting, i see other h1 :)
55 2011-11-23T01:21:25 <izibi> ThomasWaldmann: that's the problem http://paste.pocoo.org/show/511683/
56 2011-11-23T01:22:57 <izibi> wait, let's try something
57 2011-11-23T01:23:09 <izibi> (actually i should go to bed but who cares :D)
58 2011-11-23T01:23:31 <jbillsgci11> I agree
59 2011-11-23T01:23:39 <jbillsgci11> who needs sleep
60 2011-11-23T01:23:54 <ThomasWaldmann> jbillsgci11: http://localhost:8080/+history
61 2011-11-23T01:24:37 <ThomasWaldmann> but i guess this needs some fixes at other places
62 2011-11-23T01:24:44 <jbillsgci11> yes
63 2011-11-23T01:25:15 <jbillsgci11> For me to remove it there then I would need to add a class tag to normal page headers
64 2011-11-23T01:25:50 <ThomasWaldmann> http://localhost:8080/+index/
65 2011-11-23T01:26:12 <jbillsgci11> Ya
66 2011-11-23T01:26:23 <jbillsgci11> So about those classes...
67 2011-11-23T01:26:28 <ThomasWaldmann> yeah, can you file a bug about this, so we can solve it later?
68 2011-11-23T01:26:40 <jbillsgci11> where do you file bugs?
69 2011-11-23T01:26:47 <ThomasWaldmann> there should be a good plan. on bitbucket.
70 2011-11-23T01:27:09 <jbillsgci11> Ok
71 2011-11-23T01:27:13 <izibi> ThomasWaldmann: the issue already existed before i started working on it
72 2011-11-23T01:27:20 <izibi> you couldn't create two accounts at all
73 2011-11-23T01:27:27 <jbillsgci11> Ill report
74 2011-11-23T01:27:36 <izibi> as soon as you create a second one, you can't login to the first one any more
75 2011-11-23T01:28:15 <ThomasWaldmann> izibi: hah. i always only had one.
76 2011-11-23T01:28:59 <izibi> should i just leave this line commented out and report a bug for this?
77 2011-11-23T01:30:07 <ThomasWaldmann> you mean the openid? yes.
78 2011-11-23T01:30:47 <izibi> what about the other two changes?
79 2011-11-23T01:31:04 <izibi> just leave them as they are or revert them as they don't change anything?
80 2011-11-23T01:31:38 <ThomasWaldmann> well, if they don't change anything, you don't need them
81 2011-11-23T01:32:12 <izibi> just tell me what's the better way to get a user object ;)
82 2011-11-23T01:33:06 <ThomasWaldmann> as it was is the usual way
83 2011-11-23T01:34:45 <izibi> then one final test ;)
84 2011-11-23T01:34:55 <ThomasWaldmann> ok, i suggest you make it work with 1 user and file a bug about the other problem.
85 2011-11-23T01:36:09 <izibi> if i comment out this one line, it works for more than 1 user. and i didn't get the openid stuff to work at all
86 2011-11-23T01:37:02 <izibi> just say "commit" or "don't commit" (the change that comments out this one line) :P
87 2011-11-23T01:38:33 <ThomasWaldmann> commit
88 2011-11-23T01:38:52 <ThomasWaldmann> use a reasonable comment :)
89 2011-11-23T01:41:50 <jbillsgci11> What priority would the header bug be?
90 2011-11-23T01:43:40 <izibi> awesome!
91 2011-11-23T01:43:50 <izibi> i love melange
92 2011-11-23T01:43:53 <izibi> 500 <3
93 2011-11-23T01:43:56 <ThomasWaldmann> awesome prio :D
94 2011-11-23T01:44:01 <nickr5> ThomasWaldmann: thanks for closing the task!
95 2011-11-23T01:45:23 <izibi> hmm, no error but didn't submit it
96 2011-11-23T01:45:24 <ThomasWaldmann> jbillsgci11: i'll commit your changes now. do you want your name in the (public) commit comment?
97 2011-11-23T01:45:42 <jbillsgci11> If thats ok with you then yes
98 2011-11-23T01:45:57 <ThomasWaldmann> jbills? or what shall it be?
99 2011-11-23T01:46:27 <izibi> ThomasWaldmann: anyway here's the repo: https://bitbucket.org/julianbrost/moin-2.0
100 2011-11-23T01:46:37 <ThomasWaldmann> sure, if you would use mercurial, you would get automatically credit as author
101 2011-11-23T01:47:15 <jbillsgci11> Josiah
102 2011-11-23T01:47:54 <izibi> so one year is not enough to fix this bug? come on google...
103 2011-11-23T01:48:38 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1074:729463ba868b 2.0/MoinMoin/ (2 files in 2 dirs): improved heading style, thanks to Josiah
104 2011-11-23T01:49:13 <izibi> ThomasWaldmann: you don't see any submission there, do you? http://www.google-melange.com/gci/task/view/google/gci2011/7122303
105 2011-11-23T01:49:24 <jbillsgci11> Thanks! :)
106 2011-11-23T01:49:48 <jbillsgci11> I am at peace with myself. for a few hours anyway.
107 2011-11-23T01:50:37 <ThomasWaldmann> izibi: well, no. but as i am mentor, i am not supposed to be able to submit stuff.
108 2011-11-23T01:50:57 <izibi> btw anyone interested in SEO bullshit? i'm getting offers since last GCI :D
109 2011-11-23T01:51:11 <ThomasWaldmann> jbillsgci11: can you compare views of task with izibi?
110 2011-11-23T01:51:40 <ThomasWaldmann> SEO can mean a lot. some is ok, some is abuse.
111 2011-11-23T01:53:36 <izibi> http://paste.pocoo.org/show/Ws6xxrEwgM6mRHFeFzSZ/ i guess that's spam xD
112 2011-11-23T01:56:24 <ThomasWaldmann> izibi: "occurred"
113 2011-11-23T01:56:50 <ThomasWaldmann> "administrator"
114 2011-11-23T01:56:53 <ThomasWaldmann> https://bitbucket.org/julianbrost/moin-2.0/changeset/2ab4ef921cb9
115 2011-11-23T01:57:51 <izibi> and a trailing dot? ;)
116 2011-11-23T01:58:16 <ThomasWaldmann> yes :)
117 2011-11-23T01:58:30 <jbillsgci11> what do you mean compare views?
118 2011-11-23T01:58:31 <ThomasWaldmann> also find out how we write "email", it is maybe rather "e-mail"
119 2011-11-23T01:58:50 <ThomasWaldmann> jbillsgci11: he does not seem to see a submit button
120 2011-11-23T01:59:05 <jbillsgci11> Well i do not have the task
121 2011-11-23T01:59:28 <jbillsgci11> but on my task I had a submit button below an upload button
122 2011-11-23T02:00:03 <izibi> ThomasWaldmann: "email" is used everywhere else in moin so i used that
123 2011-11-23T02:00:46 <izibi> jbillsgci11: yeah right. and clicking this button either does nothing or gives you an 500 error
124 2011-11-23T02:00:59 <jbillsgci11> hit f5 on the page
125 2011-11-23T02:01:03 <jbillsgci11> that will fix it
126 2011-11-23T02:01:19 <jbillsgci11> I got this multiple times
127 2011-11-23T02:01:24 <jbillsgci11> both this year and last
128 2011-11-23T02:01:33 <jbillsgci11> just refresh the task
129 2011-11-23T02:01:38 <jbillsgci11> that will fix it
130 2011-11-23T02:01:51 <ThomasWaldmann> izibi: ok then
131 2011-11-23T02:01:53 <izibi> no, not really
132 2011-11-23T02:02:04 <izibi> @jbillsgci11
133 2011-11-23T02:02:04 <moinBot> izibi: Error: "jbillsgci11" is not a valid command.
134 2011-11-23T02:02:13 <izibi> lol
135 2011-11-23T02:02:18 <jbillsgci11> ummmm...
136 2011-11-23T02:02:20 <jbillsgci11> lol
137 2011-11-23T02:02:33 <jbillsgci11> why did the moinbot just try to command me?
138 2011-11-23T02:02:36 <ThomasWaldmann> izibi: but fix the other small typos
139 2011-11-23T02:02:49 <izibi> i'll commit/push this and then i'll go to bed
140 2011-11-23T02:02:54 <izibi> 5 hours of sleep left. yay :D
141 2011-11-23T02:03:12 <jbillsgci11> good for you
142 2011-11-23T02:03:19 <ThomasWaldmann> ok
143 2011-11-23T02:03:45 <izibi> done
144 2011-11-23T02:06:43 <izibi> melange - best piece of software ever
145 2011-11-23T02:06:46 <izibi> good night
146 2011-11-23T02:07:04 * ThomasWaldmann pulls
147 2011-11-23T02:07:08 <jbillsgci11> by the way dont you think the moin icon should be replaced with the alpha one?
148 2011-11-23T02:07:10 <ThomasWaldmann> izibi: gn :)
149 2011-11-23T02:07:27 <jbillsgci11> the current one has whitespace around it
150 2011-11-23T02:08:29 <CIA-56> Julian Brost <julian.brost@googlemail.com> default * 1075:e31023f329fb 2.0/MoinMoin/apps/frontend/views.py: Removed code duplication in register view.
151 2011-11-23T02:08:30 <CIA-56> Julian Brost <julian.brost@googlemail.com> default * 1076:2ab4ef921cb9 2.0/MoinMoin/ (apps/frontend/views.py config/default.py user.py): Implemented an email verification feature.
152 2011-11-23T02:08:30 <CIA-56> Julian Brost <julian.brost@googlemail.com> default * 1077:034805b541ce 2.0/docs/admin/install.rst: merged
153 2011-11-23T02:08:31 <CIA-56> Julian Brost <julian.brost@googlemail.com> default * 1078:f7d7c7e403c6 2.0/MoinMoin/apps/frontend/views.py: Don't pass openid kwarg to create_user function as this triggers a bug that causes older accounts to disappear. This definitely needs further investigation.
154 2011-11-23T02:08:32 <CIA-56> Julian Brost <julian.brost@googlemail.com> default * 1079:5e77a3307db7 2.0/MoinMoin/apps/frontend/views.py: Fixed some small typos.
155 2011-11-23T02:08:33 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1080:4c00ac966adf 2.0/MoinMoin/ (apps/frontend/views.py config/default.py user.py): merged
156 2011-11-23T02:09:06 <ThomasWaldmann> jbillsgci11: there were times when browsers had issues with alpha. not sure if they are completely gone already.
157 2011-11-23T02:09:23 <jbillsgci11> they should be gone by now
158 2011-11-23T02:09:40 <ThomasWaldmann> IE on XP? :)
159 2011-11-23T02:09:41 <jbillsgci11> could you decrease the image size by a pixel
160 2011-11-23T02:09:46 *** yufra_
161 2011-11-23T02:09:49 <jbillsgci11> probably not
162 2011-11-23T02:10:17 <ThomasWaldmann> why decrease it?
163 2011-11-23T02:14:12 <ThomasWaldmann> nickr5: which name should I put in the commit comment?
164 2011-11-23T02:15:01 <nickr5> Nick Rioux
165 2011-11-23T02:15:48 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1081:5093b67a4791 2.0/docs/intro/ (features.rst general.rst glossary.rst): docs: introduction: proofread and improved English, thanks to Nick Rioux
166 2011-11-23T02:17:06 <nickr5> thanks :)
167 2011-11-23T02:17:47 <ThomasWaldmann> nickr5: btw, did you ever use mercurial?
168 2011-11-23T02:18:21 <ThomasWaldmann> jbillsgci11: ""
169 2011-11-23T02:18:45 <nickr5> this task was my first time using it, although i've used git before
170 2011-11-23T02:19:09 <ThomasWaldmann> ah, so you exported the patch from hg?
171 2011-11-23T02:19:14 <nickr5> yeah
172 2011-11-23T02:19:44 <ThomasWaldmann> but not with hg export, right?
173 2011-11-23T02:20:25 <nickr5> no I used tortoisehg
174 2011-11-23T02:25:10 <ThomasWaldmann> hg export exports WITH metadata (like committer name, date time, comment)
175 2011-11-23T02:25:30 <ThomasWaldmann> and it can get imported again, to reproduce all these metadata
176 2011-11-23T02:52:39 *** jbillsgci11
177 2011-11-23T02:54:20 <ThomasWaldmann> gn
178 2011-11-23T03:18:40 *** nickr5
179 2011-11-23T03:50:27 *** MattMaker
180 2011-11-23T04:23:06 *** MattMaker
181 2011-11-23T04:32:33 *** yufra_
182 2011-11-23T04:52:49 *** MattMaker
183 2011-11-23T05:34:29 *** pkumar
184 2011-11-23T06:20:53 *** MattMaker
185 2011-11-23T06:34:11 *** MattMaker
186 2011-11-23T07:36:26 *** moin6
187 2011-11-23T07:58:55 *** xjjk
188 2011-11-23T08:01:07 *** moin6
189 2011-11-23T08:05:55 *** xjjk
190 2011-11-23T08:14:46 *** pkumar
191 2011-11-23T09:23:05 *** qxcv
192 2011-11-23T09:37:31 *** pkumar
193 2011-11-23T09:48:09 <qxcv> ThomasWaldmann: I claimed the high level view testing task for code-in, I can discuss it whenever you're ready
194 2011-11-23T10:12:17 *** greg_f
195 2011-11-23T10:57:29 *** lanka
196 2011-11-23T11:00:22 <lanka> Moin
197 2011-11-23T11:07:22 <lanka> Moin, I'm interested in participating Google Code in program...
198 2011-11-23T11:07:37 <lanka> I looked at the tasks provided by MoinMoin.
199 2011-11-23T11:07:48 <lanka> and, this looks interesting. http://www.google-melange.com/gci/task/view/google/gci2011/7165202
200 2011-11-23T11:08:40 <lanka> I've already read through the task, and has gone the demo wikis
201 2011-11-23T11:09:03 <lanka> I like to have know the next steps on completing the task
202 2011-11-23T11:09:20 <lanka> any help is highly appreciated.\
203 2011-11-23T11:12:04 <lanka> ThomasWaldmann, are you a mentor for this task? I see that your name is listed there!
204 2011-11-23T11:34:09 *** pkumar
205 2011-11-23T12:01:59 *** lanka
206 2011-11-23T12:15:30 *** lanka
207 2011-11-23T13:00:19 <ThomasWaldmann> moin
208 2011-11-23T13:01:47 <ThomasWaldmann> qxcv: hi
209 2011-11-23T13:01:51 <ThomasWaldmann> lanka: hi
210 2011-11-23T13:01:54 <qxcv> hi
211 2011-11-23T13:04:34 <ThomasWaldmann> qxcv: lanka: try asking specific questions :)
212 2011-11-23T13:06:55 <qxcv> ThomasWaldmann: do the tests I'm writing simply have to check that the views don't cause 500s and give the correct MIME type? no checking of the response body?
213 2011-11-23T13:12:09 <ThomasWaldmann> qxcv: the idea was to have a really simple test that triggers all apps/views. so you don't have to do very specialized content checks for correctness.
214 2011-11-23T13:12:35 <ThomasWaldmann> but status, no exception and maybe a SIMPLE header and/or content check would be nice.
215 2011-11-23T13:12:45 <qxcv> ok, awesome
216 2011-11-23T13:15:56 <lanka> hi ThomasWaldmann
217 2011-11-23T13:16:23 <lanka> my idea about the said project was that....
218 2011-11-23T13:16:29 <ThomasWaldmann> qxcv: and please use url_for()
219 2011-11-23T13:16:52 <qxcv> ok
220 2011-11-23T13:16:53 <lanka> I have to tranfer files between two ftp locations.
221 2011-11-23T13:17:08 <ThomasWaldmann> no, not ftp, web ui
222 2011-11-23T13:17:25 <lanka> i see
223 2011-11-23T13:17:37 <ThomasWaldmann> you have to do that with a browser and copy&paste. the file formats are not compatible.
224 2011-11-23T13:17:42 <lanka> so, just copy pasting of the moin wiki source would work?
225 2011-11-23T13:17:54 <lanka> ah, got it
226 2011-11-23T13:18:02 <ThomasWaldmann> it is about metadata AND data
227 2011-11-23T13:18:30 <lanka> ok, what metadata do i need to preserve?
228 2011-11-23T13:18:59 <ThomasWaldmann> maybe just create/modify one example item on the new test wiki, so you see how it usually looks like
229 2011-11-23T13:19:35 <ThomasWaldmann> you should preserve as much as possible, but at least the important stuff
230 2011-11-23T13:19:35 <lanka> will do
231 2011-11-23T13:19:50 <lanka> ok
232 2011-11-23T13:19:59 <lanka> important stuff like?
233 2011-11-23T13:20:28 <lanka> ThomasWaldmann, and, to get an idea about the size of the work, can you tell me about how many wiki pages are there to copy?
234 2011-11-23T13:20:52 <ThomasWaldmann> depends :) e.g. if some page demos "tags", there are likely a few pages which have tags in their metadata.
235 2011-11-23T13:21:06 <ThomasWaldmann> lanka: see index view
236 2011-11-23T13:21:43 <ThomasWaldmann> you do not have to copy all, if you find random crap, you should not copy it. just the pages needed for the demonstrations linked from the front page.
237 2011-11-23T13:22:07 <ThomasWaldmann> and you only need to transfer the latest revision
238 2011-11-23T13:23:10 <lanka> according to index, about 47 to do i guess then.
239 2011-11-23T13:23:18 <lanka> ok...
240 2011-11-23T13:23:32 <lanka> ThomasWaldmann, I'm now trying to understand the meta... http://test.moinmo.in/+meta/Home
241 2011-11-23T13:23:48 <lanka> hope I can find a way to easily copy these metadata
242 2011-11-23T13:26:45 <lanka> ThomasWaldmann, found the meta editing section.
243 2011-11-23T13:27:14 <lanka> ThomasWaldmann, just to be clear, will direct copy&paste from a meta page like this would work? http://test.moinmo.in/+meta/Home
244 2011-11-23T13:28:56 <ThomasWaldmann> metadata is json, you can copy&paste it as a start. it might need more changes, but that's how you transfer it before maybe needing to change it.
245 2011-11-23T13:29:29 <ThomasWaldmann> and the easiest way is maybe to have the editor open for both source and destination.
246 2011-11-23T13:31:11 <lanka> ThomasWaldmann, yes, I have both editors open. And, made the first edit.
247 2011-11-23T13:31:29 <lanka> can you have a quick look? http://test.moinmo.in:8080/Home
248 2011-11-23T13:33:48 <ThomasWaldmann> you don't need to put that comment, without is fine in that case
249 2011-11-23T13:34:27 <lanka> got it
250 2011-11-23T13:35:00 <lanka> ThomasWaldmann, noticed a bug in the new wiki
251 2011-11-23T13:35:20 <ThomasWaldmann> hmm, i am just seeing that this is namespaces branch code. yeah, there are likely lots of bugs.
252 2011-11-23T13:35:45 <ThomasWaldmann> e.g. address is 0.0.0.0
253 2011-11-23T13:36:39 <lanka> I see
254 2011-11-23T13:37:06 <lanka> I'm not much familiar with the terms though
255 2011-11-23T13:39:06 <lanka> ThomasWaldmann, noticed a bug
256 2011-11-23T13:39:11 <lanka> This was edit was made without being logged in and it worked fine.
257 2011-11-23T13:39:40 <qxcv> I'm attempting to use the pytest_generate_tests hook, but it's not getting called for any of the methods of the test classes in apps/frontend/_tests/test_frontend.py
258 2011-11-23T13:39:47 <lanka> ThomasWaldmann, Then I logged in. Now I can no longer access the wiki. it gives "Internal Server Error"
259 2011-11-23T13:39:48 <qxcv> here's the relevant code: http://paste.pocoo.org/show/BlwzqN8hh5C6vhAnIKrQ/
260 2011-11-23T13:39:53 <lanka> error 500
261 2011-11-23T13:42:46 <ThomasWaldmann> lanka: destroy the browser cookie you have for that url
262 2011-11-23T13:43:36 <ThomasWaldmann> lanka: i can switch it to the default branch code, maybe we should do that for now, as long namespace stuff is that unstable
263 2011-11-23T13:43:55 <ThomasWaldmann> lanka: but then you have to start again
264 2011-11-23T13:45:17 <lanka> are you saying that you will change the OLD wiki to default branch code?
265 2011-11-23T13:45:23 <izibi> ThomasWaldmann: t think it shouldn't crash if you send a wrong cookie?
266 2011-11-23T13:45:23 <lanka> ThomasWaldmann, ^^
267 2011-11-23T13:46:16 <ThomasWaldmann> qxcv: no idea, ronny is our pytest2 specialist :)
268 2011-11-23T13:47:15 <ThomasWaldmann> lanka: no, the NEW one. i accidentally have "namespaces" branch active there (as it was the repo tip at that time)
269 2011-11-23T13:47:59 <lanka> ThomasWaldmann, then I don't understand what you meant by "but then you have to start again"!! :)
270 2011-11-23T13:48:09 <ThomasWaldmann> you lose 1 page
271 2011-11-23T13:49:00 *** raignarok
272 2011-11-23T13:50:39 <lanka> ThomasWaldmann, ok... loosing only 1 page is ok for me
273 2011-11-23T13:51:56 <lanka> what's happening the link is no longer accessible http://test.moinmo.in:8080/Home
274 2011-11-23T13:52:06 <lanka> what's happening? the link is no longer accessible http://test.moinmo.in:8080/Home
275 2011-11-23T13:53:09 <ThomasWaldmann> lanka: ok, try now. you see it when it does not put "namespace" into metadata.
276 2011-11-23T13:53:23 <lanka> ok
277 2011-11-23T13:53:30 <ThomasWaldmann> i just switched the code there
278 2011-11-23T13:53:50 <lanka> Hm, I'm getting to understand what you meant before.... :)
279 2011-11-23T13:54:53 <ThomasWaldmann> the general problem is that if we do major changes to how stuff is stored into the backend, we need conversion (either code or manually)
280 2011-11-23T13:55:06 *** qxcv
281 2011-11-23T13:55:30 *** mcyellen
282 2011-11-23T13:56:20 <lanka> yeah....
283 2011-11-23T13:56:40 <lanka> FWIW the login issue is still there, but now with another error.
284 2011-11-23T13:57:12 <lanka> It says "KeyError: 'is_disabled'" with a traceback
285 2011-11-23T13:57:13 <ThomasWaldmann> X)
286 2011-11-23T13:57:36 <ThomasWaldmann> hah! that sounds like gci code. ;)
287 2011-11-23T13:57:50 <ThomasWaldmann> just do it without login.
288 2011-11-23T13:57:59 <lanka> he he...
289 2011-11-23T13:58:33 <ThomasWaldmann> lanka: can you file a bug (on bitbucket) about this?
290 2011-11-23T13:58:48 <lanka> ThomasWaldmann, with pleasure...
291 2011-11-23T14:00:26 <izibi> huh? did my stuff break something?
292 2011-11-23T14:00:53 <izibi> lanka: can you paste the traceback?
293 2011-11-23T14:01:14 <ThomasWaldmann> eSyr: the hi i18n tasks are in needs review again. did sinha show any signs of life / did you email him?
294 2011-11-23T14:02:44 <izibi> oh, my fault
295 2011-11-23T14:02:58 <izibi> i'll fix it
296 2011-11-23T14:02:59 <lanka> izibi, I can no longer reproduce it. have you fixed it?
297 2011-11-23T14:03:32 <lanka> izibi, ok. now there's no traceback. But it doesn't log me in either.
298 2011-11-23T14:04:13 <lanka> izibi, Now, in the login page, the title is "handlers need to give it"
299 2011-11-23T14:04:58 <izibi> ThomasWaldmann: fix: https://bitbucket.org/julianbrost/moin-2.0/changeset/d1c45405010b
300 2011-11-23T14:05:11 <izibi> let's try submitting to melange again
301 2011-11-23T14:05:33 *** raignarok
302 2011-11-23T14:06:06 <izibi> let's try firefox :D
303 2011-11-23T14:06:26 <lanka> im using firefox
304 2011-11-23T14:07:22 <izibi> nope, doesn't work
305 2011-11-23T14:09:25 <CIA-56> Julian Brost <julian.brost@googlemail.com> default * 1082:d1c45405010b 2.0/MoinMoin/apps/frontend/views.py: user_kwargs['is_disabled'] isn't set when email verification is disabled.
306 2011-11-23T14:09:25 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1083:4909b8d39579 2.0/MoinMoin/apps/frontend/views.py: merged
307 2011-11-23T14:10:05 <ThomasWaldmann> izibi: hi. can you please pull -u before starting to work? avoids some merge changesets.
308 2011-11-23T14:10:19 <lanka> izibi, ThomasWaldmann guys, please be kind enough to inform me when you change the test wiki. Because I'm currently working on it. thanks
309 2011-11-23T14:10:33 <ThomasWaldmann> lanka: i applied it, runs on new code now.
310 2011-11-23T14:10:43 <ThomasWaldmann> sorry for interrupting, you can just re-post.
311 2011-11-23T14:10:53 <lanka> ok, thanks.
312 2011-11-23T14:11:02 <izibi> ThomasWaldmann: yeah, i'd do this usually, but i just quickly changed this now ;)
313 2011-11-23T14:11:33 <izibi> i could try uploading a bundle :D
314 2011-11-23T14:13:49 <ThomasWaldmann> izibi: after a task is successfully closed, you don't need to update it on melange.
315 2011-11-23T14:14:57 <izibi> ThomasWaldmann: but it's not closed. submitting stuff doesn't work for me
316 2011-11-23T14:17:18 <izibi> ah, uploading a file worked
317 2011-11-23T14:17:19 <izibi> wtf?
318 2011-11-23T14:18:18 *** jbillsgci11
319 2011-11-23T14:18:30 <jbillsgci11> I have requested this task
320 2011-11-23T14:18:34 <jbillsgci11> http://www.google-melange.com/gci/task/view/google/gci2011/7159202
321 2011-11-23T14:18:43 <izibi> http://www.google-melange.com/gci/task/view/google/gci2011/7122303 submitted
322 2011-11-23T14:18:52 <izibi> why the hell doesn't melange display newlines?
323 2011-11-23T14:20:00 <jbillsgci11> Its probably a bug
324 2011-11-23T14:20:02 <ronny> re
325 2011-11-23T14:20:27 <ThomasWaldmann> izibi: did you "submit" that bundle as like "work done"?
326 2011-11-23T14:22:28 <izibi> nope, why did they change this? :D
327 2011-11-23T14:25:33 <ThomasWaldmann> no idea :) i just noticed i can't close it.
328 2011-11-23T14:26:20 <izibi> i've submitted it for review now ;)
329 2011-11-23T14:28:05 <lanka> ThomasWaldmann, here's a creole wiki http://test.moinmo.in:8080/creole
330 2011-11-23T14:29:10 <ThomasWaldmann> izibi: just noticed: there are no docs for it yet, right? see docs/admin/configure.rst
331 2011-11-23T14:30:06 *** sinha
332 2011-11-23T14:30:54 <izibi> who needs documentation? :D
333 2011-11-23T14:31:20 <sinha> ThomasWaldmann: hi, i was going through the translation done by aki
334 2011-11-23T14:32:15 <sinha> what i found is, at some places he didn't use the generic translation what most people could understand, instead he used the one provided by google translate
335 2011-11-23T14:32:17 <ThomasWaldmann> sinha: ah, great. so, is it a good translation?
336 2011-11-23T14:32:53 <ThomasWaldmann> ok, as suspected. do you think it can be fixed with good result?
337 2011-11-23T14:32:56 <sinha> i have marked lots of lines which are supposed to be corrected
338 2011-11-23T14:33:12 <sinha> yes some minor (some places major) changes are required
339 2011-11-23T14:33:23 <lanka> ThomasWaldmann, how to handle targz ? http://test.moinmo.in/targz
340 2011-11-23T14:34:16 <ThomasWaldmann> eSyr: can you update all i18n tasks (in melange and in the wiki) to have the line "YOU MUST NOT USE MACHINE TRANSLATION."?
341 2011-11-23T14:34:33 <sinha> so should i write my review in comment there ? mark the lines which needs some change (as he asked)
342 2011-11-23T14:34:34 <sinha> ?
343 2011-11-23T14:36:04 <izibi> ThomasWaldmann: where to add it in this file?
344 2011-11-23T14:36:15 <ThomasWaldmann> sinha: did you mark them as fuzzy?
345 2011-11-23T14:36:49 <sinha> i am seeing those po files in text editor, how to mark as fuzzy (just add some flag in there)
346 2011-11-23T14:37:00 <ThomasWaldmann> sinha: yes, please communicate with the student. in case of doubt via melange, or here, if he joins here.
347 2011-11-23T14:37:19 <ThomasWaldmann> #, fuzzy
348 2011-11-23T14:37:26 <sinha> okay i will be here all day, i can wait
349 2011-11-23T14:37:44 <ThomasWaldmann> above the entry, just look at some file on master that has fuzzy entries
350 2011-11-23T14:37:49 <lanka> ThomasWaldmann, izibi I received this error when creating a tar (TGZ) with only meta http://paste.pocoo.org/show/p7YdpuXTXwxml3HmOLrc/
351 2011-11-23T14:38:06 <lanka> shouldn't it be user-friendlier?
352 2011-11-23T14:38:51 <ThomasWaldmann> sinha: ok, i just clicked on "needs more work" for both parts
353 2011-11-23T14:39:24 <ThomasWaldmann> sinha: make sure you use his latest work for review
354 2011-11-23T14:40:12 <sinha> yes i am using that only
355 2011-11-23T14:41:47 <sinha> if he comes to chat or communicate via email or something, i could give him some suggestions (and at some places he simply used word-word translation, simply from google, which is not making any sense)
356 2011-11-23T14:42:38 <ThomasWaldmann> lanka: creole page looks ok (no regressions at least)
357 2011-11-23T14:43:00 <lanka> ThomasWaldmann, glad to hear that :))
358 2011-11-23T14:43:01 <izibi> ThomasWaldmann: what section would fit best? authentication? anti-spam? mail?
359 2011-11-23T14:43:01 <ThomasWaldmann> izibi: choose some nice place
360 2011-11-23T14:43:19 <ThomasWaldmann> it is either user related stuff or near other email stuff
361 2011-11-23T14:44:31 <izibi> i'll add is below sending email
362 2011-11-23T14:44:49 <ThomasWaldmann> lanka: that is a traceback. it is developer-friendly.
363 2011-11-23T14:45:48 <ThomasWaldmann> lanka: what does it mean "with only meta", did you forget the file upload?
364 2011-11-23T14:46:40 <lanka> ThomasWaldmann, i didn't upload the file, because i couldn't find one
365 2011-11-23T14:47:20 <lanka> ThomasWaldmann, what's the standard way to get the file? the links in that doesn't work.
366 2011-11-23T14:48:09 <lanka> ThomasWaldmann, Further, for PNG images, I've manually downloaded the PNG to my computer and uploaded. Is it the expected procedure?
367 2011-11-23T14:50:06 <izibi> ThomasWaldmann: http://paste.pocoo.org/show/511870/ is this ok?
368 2011-11-23T14:52:50 <lanka> ThomasWaldmann, izibi: is there a way to change the markup type (ie moin -> rst) after a page is created?
369 2011-11-23T14:53:09 <ThomasWaldmann> izibi: AttributeError: 'User' object has no attribute 'openid' - i guess we need a fix openid task
370 2011-11-23T14:53:41 <ThomasWaldmann> lanka: you need to download it from old wiki, then upload it on new wiki
371 2011-11-23T14:54:04 <ThomasWaldmann> yes, that is expected
372 2011-11-23T14:54:16 <izibi> ThomasWaldmann: where does this happen?
373 2011-11-23T14:54:33 <ThomasWaldmann> just tried to create, use and view settings of a new user
374 2011-11-23T14:54:57 <ThomasWaldmann> File "/home/tw/w/moin-2.0/MoinMoin/apps/frontend/views.py", line 1349, in usersettings
375 2011-11-23T14:55:00 <ThomasWaldmann> if form['openid'].value != flaskg.user.openid and user.search_users(openid=form['openid'].value):
376 2011-11-23T14:55:03 <ThomasWaldmann> AttributeError: 'User' object has no attribute 'openid'
377 2011-11-23T14:56:47 <izibi> wtf? please don't tell me that this happens because i omit the openid kwarg on create_user :D
378 2011-11-23T14:57:10 <lanka> ThomasWaldmann, thanks
379 2011-11-23T14:57:36 <lanka> I think the links to tar files are broken.
380 2011-11-23T14:59:55 <izibi> ThomasWaldmann: you should create a task "suffer from openid bugs" :D
381 2011-11-23T15:00:04 <ThomasWaldmann> lanka: please file a bug and keep it onto your todo for later
382 2011-11-23T15:00:23 <jbillsgci11> Does anyone have a test page that contains everything in moinmoin? (images,tables,etc)
383 2011-11-23T15:00:48 <jbillsgci11> I need one to test the css
384 2011-11-23T15:00:58 <ThomasWaldmann> http://test.moinmo.in/moin maybe not everything, but some stuff
385 2011-11-23T15:01:04 <lanka> ok
386 2011-11-23T15:02:29 <izibi> ThomasWaldmann: is the documentation ok like this?
387 2011-11-23T15:03:31 *** pkumar
388 2011-11-23T15:03:45 <ThomasWaldmann> izibi: ... to be able to send e-mails ...
389 2011-11-23T15:03:54 <ThomasWaldmann> 7
390 2011-11-23T15:04:44 <ThomasWaldmann> At account creation time, ... (4)
391 2011-11-23T15:05:39 <izibi> ThomasWaldmann: e-mail in lower case? it's capitalized in the "Sending E-Mails" section
392 2011-11-23T15:06:18 <ThomasWaldmann> ok, keep that as is
393 2011-11-23T15:09:11 <izibi> http://paste.pocoo.org/show/511878/
394 2011-11-23T15:09:51 <ThomasWaldmann> izibi: 'An error occurred while sending the verification email: "%(message)" Please contact an administrator to activate your account.'
395 2011-11-23T15:10:01 <ThomasWaldmann> ValueError: unsupported format character '"' (0x22) at index 67
396 2011-11-23T15:10:33 <izibi> damn, why do i always forget the s? :D
397 2011-11-23T15:10:54 <ThomasWaldmann> docs are ok
398 2011-11-23T15:11:29 <izibi> 1 or 2 commits?
399 2011-11-23T15:11:52 <ThomasWaldmann> 2
400 2011-11-23T15:12:58 <lanka> ThomasWaldmann, apparently this wiki page is orphaned http://test.moinmo.in:8080/MultipleParagraphs
401 2011-11-23T15:13:09 <lanka> anyway to put it in to main page?
402 2011-11-23T15:13:53 <izibi> ThomasWaldmann: i've pushed it
403 2011-11-23T15:14:01 <ThomasWaldmann> lanka: kill it
404 2011-11-23T15:14:20 <lanka> ok. this? http://test.moinmo.in/ObjectTagBug-OverlayPatch
405 2011-11-23T15:16:17 <lanka> there's other orphans. But Google has probably indexed those!
406 2011-11-23T15:16:36 <ThomasWaldmann> izibi: An error occurred while sending the verification email: "{u'tw+tw3@waldmann-edv.de': (501, '5.5.2 <x300.?null?>: Helo command rejected: Invalid name')}" Please contact an administrator to activate your account.
407 2011-11-23T15:16:52 <ThomasWaldmann> looks like our mail server is a bit picky
408 2011-11-23T15:17:15 <ThomasWaldmann> lanka: don't care for google, it is a test wiki
409 2011-11-23T15:17:17 <lanka> here's another http://test.moinmo.in/ObjectTagBug-Tip http://test.moinmo.in/Trans2Inc
410 2011-11-23T15:17:24 <lanka> ok
411 2011-11-23T15:18:04 <lanka> ThomasWaldmann, then, I'm done with the work except the targz thing! :))
412 2011-11-23T15:18:04 <ThomasWaldmann> lanka: if it is about bugs, verify if it still happens. also check issue tracker if an issue links to test wiki.
413 2011-11-23T15:19:51 <izibi> ThomasWaldmann: it works with gmail
414 2011-11-23T15:20:09 <izibi> ThomasWaldmann: is there anything in the mailserver logs?
415 2011-11-23T15:20:39 <ThomasWaldmann> it doesnt like the hostname of my laptop
416 2011-11-23T15:22:33 <izibi> didn't you read the docs? it says that moin must be able to send mails ;)
417 2011-11-23T15:26:12 <ThomasWaldmann> you forgot to document that it crashes otherwise :P
418 2011-11-23T15:27:26 <izibi> it doesn't crash, it just tells you that it's not working :P
419 2011-11-23T15:29:16 <lanka> I'm out for dinner. Now I only have this targz thing :)
420 2011-11-23T15:32:10 <dreimark> moin
421 2011-11-23T15:44:10 <ThomasWaldmann> izibi: the to-address is wrong
422 2011-11-23T15:44:53 <izibi> whatt?
423 2011-11-23T15:44:55 <izibi> -t
424 2011-11-23T15:45:02 <izibi> where?
425 2011-11-23T15:46:32 <izibi> oops, somehow i commited the first version of the docs. damn
426 2011-11-23T15:47:11 <ThomasWaldmann> izibi: i mean in the code / verify emails
427 2011-11-23T15:47:30 <izibi> ?
428 2011-11-23T15:47:41 <ThomasWaldmann> for page change notification, we usually use same from == to address and notify everybody by bcc
429 2011-11-23T15:48:15 <ThomasWaldmann> but for a personal thing like this verification, it should use the real email in the to: field and not bcc
430 2011-11-23T15:48:56 <izibi> i'm just using the same code as for a password reset
431 2011-11-23T15:49:47 <ThomasWaldmann> then it is wrong there also maybe :) can you try it / fix it?
432 2011-11-23T15:51:17 * ThomasWaldmann bbl
433 2011-11-23T15:52:56 *** lanka
434 2011-11-23T16:10:28 <ThomasWaldmann> izibi: when reading that email subject, i think it should be changed from "[WikiName] Verify your email address" to "[WikiName] Please verify your e-mail address."
435 2011-11-23T16:10:44 *** mcyellen
436 2011-11-23T16:11:44 *** lanka
437 2011-11-23T16:12:24 <ThomasWaldmann> lanka: did you file bugs for the stuff you stumbled upon? on bitbucket?
438 2011-11-23T16:13:14 <lanka> ThomasWaldmann, most of them got fixed on the way, but there's one bug to fill I think. I should do it too
439 2011-11-23T16:13:46 <ThomasWaldmann> that should be standard procedure: fix it or file it
440 2011-11-23T16:14:17 <ThomasWaldmann> filing some stuff is good for future gci tasks also :)
441 2011-11-23T16:21:29 *** raignarok
442 2011-11-23T16:46:02 <ThomasWaldmann> dreimark: eSyr: pkumar: waldi: did you ever get some notification email from melange when a student posted a question there?
443 2011-11-23T16:47:21 <waldi> nope
444 2011-11-23T17:00:26 *** jbillsgci11
445 2011-11-23T17:06:49 <ThomasWaldmann> (17:03) < ThomasWal> SRabbelier: is it already known that the profile setting "automatic task subscription" does not work?
446 2011-11-23T17:06:52 <ThomasWaldmann> (17:03) < ThomasWal> i have it set, but AFAIK, i never got en email when a student claimrequested something or put a comment on some task where i am mentor
447 2011-11-23T17:06:55 <ThomasWaldmann> (17:03) <@SRabbelie> ThomasWaldmann: yeah, Madhu was almost finished it
448 2011-11-23T17:06:58 <ThomasWaldmann> (17:04) <@SRabbelie> ThomasWaldmann: you can explicitly click the 'subscribe' button
449 2011-11-23T17:07:01 <ThomasWaldmann> (17:04) < ThomasWal> ah, then it works? ok, trying that.
450 2011-11-23T17:07:03 <ThomasWaldmann> (17:04) < ThomasWal> if madhu has finished it, will it notify for claimrequests also?
451 2011-11-23T17:07:06 <ThomasWaldmann> (17:04) <@SRabbelie> ThomasWaldmann: I think that's the idea, yes, but I'm not sure
452 2011-11-23T17:07:09 <ThomasWaldmann> (17:05) < ThomasWal> ok, let's see
453 2011-11-23T17:07:48 <ThomasWaldmann> so let me suggest that whenever someone sees a claimrequest, he not only accepts it, but also clicks the subscribe button (until we know the profile setting works)
454 2011-11-23T17:23:41 <ThomasWaldmann> sinha: please mark everything as fuzzy you think that is not good hindi and communicate with the student on the melange tracker
455 2011-11-23T17:23:59 <ThomasWaldmann> currently, it is rather unnoticable that you are working on it
456 2011-11-23T17:24:16 <sinha> ThomasWaldmann: okay, sure
457 2011-11-23T17:24:40 <ThomasWaldmann> http://www.google-melange.com/gci/task/view/google/gci2011/7122302 and see there
458 2011-11-23T17:28:59 <sinha> ThomasWaldmann: one more thing i wanted to ask, that how would i know which are the lines he edited, because some might have done earlier OR i should go through each of them
459 2011-11-23T17:29:07 <sinha> (which i am doing now)
460 2011-11-23T17:30:02 <dreimark> ThomasWaldmann: i got after subscribing mails, like not a new bug maybe, but should be fixed.
461 2011-11-23T17:30:07 <dreimark> ThomasWaldmann: i got after subscribing mails, like not a new bug maybe, but should be fixed.
462 2011-11-23T17:30:27 <dreimark> for http://www.google-melange.com/gci/task/view/google/gci2011/7122303
463 2011-11-23T17:31:52 *** jbillsgci11
464 2011-11-23T17:34:41 <ThomasWaldmann> sinha: you can use diff, just grab files from master19.moinmo.in/MoinI18n/hi and from melange and diff them
465 2011-11-23T17:35:01 <ThomasWaldmann> maybe, if order changed, you need some special gettext tool.
466 2011-11-23T17:35:08 <ThomasWaldmann> or just look through them all
467 2011-11-23T17:35:29 <sinha> okay, looking all will be easier and better
468 2011-11-23T17:36:48 <ThomasWaldmann> sinha: it can make sense, so everywhere the same words are used for the same things
469 2011-11-23T17:37:30 <sinha> yes, because currently i am saying different translated words for the same english word
470 2011-11-23T17:45:43 <izibi> re
471 2011-11-23T17:47:02 <izibi> ThomasWaldmann: so what do you want me to change now?
472 2011-11-23T17:48:44 <TheSheep> ThomasWaldmann: I wonder if moin could catch that pickling error and clean the cache by itself...
473 2011-11-23T17:57:44 <sinha> ThomasWaldmann: I am not able to comment on melange? does that page need special privileges ?
474 2011-11-23T18:03:09 *** iwontbecreative
475 2011-11-23T18:04:33 <iwontbecreative> eSyr: Hello, I am doing the french translation task and I wonder if you might help me with generating the .po file.
476 2011-11-23T18:04:59 <iwontbecreative> I used the documentation, but it doesn't work (at least on trunk)
477 2011-11-23T18:05:07 <pkumar> nope! no notifications
478 2011-11-23T18:05:24 <pkumar> ThomasWaldmann :^
479 2011-11-23T18:06:19 <iwontbecreative> eSyr: I get an error: "error: invalid command 'update_catalog'"
480 2011-11-23T18:10:08 <lanka> ThomasWaldmann, izibi: noticed another bug. I'll try to reproduce this and then file a bug http://paste.pocoo.org/show/8g1opTF2WDi6qh1PMrnX/
481 2011-11-23T18:11:16 <lanka> ahh, it seems that this is quite the same as previous one. sorry for the noise
482 2011-11-23T18:12:17 <lanka> ThomasWaldmann, izibi: where should I file bugs. here? https://bitbucket.org/thomaswaldmann/moin-2.0/issues?status=new&status=open
483 2011-11-23T18:38:01 *** greg_f
484 2011-11-23T18:42:37 *** pkumar
485 2011-11-23T18:42:43 <iwontbecreative> eSyr: I'm off for now (I might be back later on), but I would like some help with this issue because I can't start the task until I know how to generate the .po file and I have only 3 days.
486 2011-11-23T18:42:53 *** iwontbecreative
487 2011-11-23T18:43:46 *** pkumar
488 2011-11-23T18:44:10 <pkumar> sinha : hey , had got dcd.
489 2011-11-23T18:44:58 <pkumar> so, difference? I don't see any.
490 2011-11-23T18:45:11 <sinha> then why they are at two places ?
491 2011-11-23T18:45:18 <sinha> i mean comments at both places are same
492 2011-11-23T18:45:19 <sinha> ?
493 2011-11-23T18:46:35 <pkumar> well, first one needed modifications as some of the translations make no sense in hindi. so a new file with better translations hopefully
494 2011-11-23T18:46:44 <pkumar> is uploaded there
495 2011-11-23T18:47:05 <pkumar> sinha : how do ou find translations are
496 2011-11-23T18:47:10 <pkumar> ?
497 2011-11-23T18:47:35 <pkumar> say for "Your changes are not saved"?
498 2011-11-23T18:48:07 <sinha> at some places saved is written as "save" in hindi and some places as "surakshit"
499 2011-11-23T18:48:29 <sinha> and also the translation for word draft is done as "masooda"
500 2011-11-23T18:48:34 <sinha> i have never heard of that word
501 2011-11-23T18:49:06 <sinha> so instead of translating word by word, we should keep the meaning which is understandable by mass and makes sense
502 2011-11-23T18:49:14 <pkumar> sinha : well, apart from word, the translation of the above word here I can see is:
503 2011-11-23T18:49:27 <pkumar> s/word/sentence
504 2011-11-23T18:49:57 <pkumar> "apne pariwartano ko saheja nahi kar rahe hain!
505 2011-11-23T18:49:59 <pkumar> "
506 2011-11-23T18:50:09 <pkumar> is that right?
507 2011-11-23T18:50:17 <sinha> yeah instead of this, it should be "aapka parivartan saheja naih gaya"
508 2011-11-23T18:50:24 <sinha> so its not right there
509 2011-11-23T18:50:29 <sinha> *nahi
510 2011-11-23T18:50:42 <sinha> there are lot of other lines, let me pick em
511 2011-11-23T18:51:09 <pkumar> or " aapke parivartan saheje nai gaye hain!"
512 2011-11-23T18:51:28 <pkumar> kinda more respectful! ;)
513 2011-11-23T18:52:06 <pkumar> though either of the sentences make sense but not the one in the file
514 2011-11-23T18:52:08 <sinha> yes
515 2011-11-23T18:52:17 <sinha> and at some place there is usage of "tum"
516 2011-11-23T18:52:27 <sinha> which is also kinda disrespectful
517 2011-11-23T18:52:42 <pkumar> yeah, not so descent
518 2011-11-23T18:53:11 <pkumar> read for this "The lock you held timed out. Be prepared for editing conflicts!"
519 2011-11-23T18:54:05 <sinha> pkumar: i need to go somewhere, will back in 20 min (if you can, we will carry out discussion then)
520 2011-11-23T18:54:05 <pkumar> For hindi users those sentences are surely not very comfortable
521 2011-11-23T18:54:16 <pkumar> sure!
522 2011-11-23T18:54:25 <sinha> okay, will ping you when i am back !
523 2011-11-23T18:54:42 <pkumar> ok
524 2011-11-23T19:28:57 <ThomasWaldmann> izibi: using the right to: address?
525 2011-11-23T19:29:20 <izibi> that's not a bug in my code :P
526 2011-11-23T19:29:42 <ThomasWaldmann> TheSheep: maybe. it is a rather strange error though, not sure if it ONLY happens in that case. also, cleaning cache while moin is running is maybe also not that great.
527 2011-11-23T19:30:04 <izibi> would it be ok to check the type of the to parameter in the sendmail function?
528 2011-11-23T19:30:06 <ThomasWaldmann> sinha: maybe one needs to be student or mentor, not sure
529 2011-11-23T19:30:17 <izibi> and send it as it is now if its a list
530 2011-11-23T19:30:43 <izibi> and if it's a string, use the correct To: header?
531 2011-11-23T19:31:00 <ThomasWaldmann> lanka: that "no tell" is a api problem. file a bug with the traceback.
532 2011-11-23T19:31:29 <ThomasWaldmann> lanka: yes, on my moin-2.0 bb issue tracker
533 2011-11-23T19:32:07 <ThomasWaldmann> if the french guy returns: we have docs about translation process and they should work.
534 2011-11-23T19:34:32 <ThomasWaldmann> izibi: no, but for personal mails it is kind of expected, so you implement something you need for your code that also fixes the same issue for existing other code.
535 2011-11-23T19:35:21 <izibi> and how should i do this without duplicating all that sendmail code?
536 2011-11-23T19:35:28 <ThomasWaldmann> izibi: i would rather prefer a more explicit way than magic
537 2011-11-23T19:35:55 <ThomasWaldmann> like a use_bcc flag or something
538 2011-11-23T19:36:57 <ThomasWaldmann> maybe the current "to" param should be renamed to bcc
539 2011-11-23T19:37:32 <ThomasWaldmann> and a new "to" param added (that is also a list?)
540 2011-11-23T19:38:09 <ThomasWaldmann> your code would use that new "to" param, pw recovery would also use the new "to", page change notification would use "bcc"
541 2011-11-23T19:39:01 <ThomasWaldmann> we could make a new task for this, considering the amount of change
542 2011-11-23T19:39:07 <ThomasWaldmann> easy :)
543 2011-11-23T19:39:27 <ThomasWaldmann> find bug / fix bug
544 2011-11-23T19:40:08 <ThomasWaldmann> izibi: ^^
545 2011-11-23T19:40:14 <izibi> sendmail(subject, text, to=None, cc=None, bcc=None, mail_from=None)?
546 2011-11-23T19:40:42 <izibi> if i'm changing this anyway, i can also add cc. maybe someone will need it some time ;)
547 2011-11-23T19:41:23 <izibi> can you send an email with an empty To: header?
548 2011-11-23T19:41:45 <ThomasWaldmann> maybe from, to, cc, bcc, subject, text would be a somehow natural order
549 2011-11-23T19:42:00 <izibi> gmail doesn't complain ;)
550 2011-11-23T19:42:03 <ThomasWaldmann> there are not that many callers iirc
551 2011-11-23T19:42:28 <izibi> ThomasWaldmann: but then you would have to use kwargs for everything
552 2011-11-23T19:42:39 <izibi> otherwise you could just pass subject and text
553 2011-11-23T19:43:28 <ThomasWaldmann> some stuff could default to None and if it is None, use the configured value
554 2011-11-23T19:44:05 <ThomasWaldmann> (or not activate some header if there is no data for it)
555 2011-11-23T19:44:47 <izibi> http://paste.pocoo.org/show/512019/
556 2011-11-23T19:44:50 <ThomasWaldmann> btw, i need to move soon, if there are any question: now, or later :)
557 2011-11-23T19:45:01 <izibi> then i'd have to do more input validation
558 2011-11-23T19:45:22 <izibi> because i'd need to give them a default value and need to check whether they were passed
559 2011-11-23T19:45:50 <ThomasWaldmann> yes
560 2011-11-23T19:46:18 <izibi> that would suck :P
561 2011-11-23T19:46:47 <ThomasWaldmann> if foo is not None: ...
562 2011-11-23T19:47:29 <ThomasWaldmann> or: foo = foo or cfg.default_foo
563 2011-11-23T19:47:51 <izibi> what's wrong with using subject and text as first to arguments?
564 2011-11-23T19:48:10 <ThomasWaldmann> it's not wrong, just a bit backwards :)
565 2011-11-23T19:48:13 <izibi> sendmail("Foo", "Bar", to=["mail"])
566 2011-11-23T19:48:44 <ThomasWaldmann> also, is a subject mandatory? or text?
567 2011-11-23T19:48:45 <izibi> but what do you want to set as default for subject and text? :D
568 2011-11-23T19:49:44 <izibi> ThomasWaldmann: i don't want empty mails in my inbox :D
569 2011-11-23T19:50:04 <ThomasWaldmann> it's a great way to detect spam :P
570 2011-11-23T19:50:54 <izibi> sendmail(**kwargs) :D
571 2011-11-23T19:51:06 <ThomasWaldmann> maybe we should have sendmail as a generic way to generate and send mail, allowing everything that is valid
572 2011-11-23T19:51:37 <ThomasWaldmann> and the caller must make sure to use whatever feature one would expect
573 2011-11-23T19:55:17 <izibi> srsly? if someone needs to do something weird, he can directly talk to the smtp server
574 2011-11-23T19:55:40 <izibi> you usually send some notification mails *withÜ* subject and text from a wiki...
575 2011-11-23T20:00:07 <ThomasWaldmann> it is just about order
576 2011-11-23T20:00:27 <ThomasWaldmann> the order i mentioned does not have to be looked up, any email program shows stuff in that order
577 2011-11-23T20:00:53 <ThomasWaldmann> with another order (e.g. as now) it is better with mandatory arguments, but you have to look up the order
578 2011-11-23T20:01:48 <izibi> it's always a bad idea to write code without knowing which argument does what
579 2011-11-23T20:02:34 <izibi> and you would have to use kwargs in that case anyway
580 2011-11-23T20:02:48 <ThomasWaldmann> if we have the usual names for them, one can also easily remember the name and use any order
581 2011-11-23T20:02:55 <izibi> or you'd have to explicitly pass [] or None as first arg for example
582 2011-11-23T20:04:20 <ThomasWaldmann> anyway, need to go now, bbl
583 2011-11-23T20:37:32 <izibi> http://paste.pocoo.org/show/512044/
584 2011-11-23T20:39:10 <izibi> huh? why doesn't it show the whole diff?
585 2011-11-23T20:39:18 <izibi> there is more when you click on raw. strange
586 2011-11-23T20:53:08 *** pkumar
587 2011-11-23T21:10:59 *** grzywacz
588 2011-11-23T21:19:19 *** lanka
589 2011-11-23T21:34:13 <sinha> ThomasWaldmann: Since i am not able to comment there, i have written some suggestions here http://paste.pocoo.org/show/512069/, Please post it there, thank you !
590 2011-11-23T21:43:40 <grzywacz> moin
591 2011-11-23T21:46:47 <sinha> ThomasWaldmann: It is review of this one http://www.google-melange.com/gci/task/view/google/gci2011/7134387
592 2011-11-23T21:46:49 *** sinha
593 2011-11-23T21:57:51 *** MattMaker
594 2011-11-23T22:01:42 *** MattMaker
595 2011-11-23T22:33:51 <dreimark> gn
596 2011-11-23T22:36:04 *** raignarok
597 2011-11-23T22:38:16 *** raignarok
598 2011-11-23T22:55:55 *** moin2
599 2011-11-23T22:56:14 *** moin2
600 2011-11-23T22:56:25 <ploftness> hi
601 2011-11-23T22:56:35 <ploftness> Are any of the Google code-in mentors currently around?
602 2011-11-23T23:00:46 *** MattMaker
603 2011-11-23T23:06:21 *** MattMaker
604 2011-11-23T23:25:40 *** ploftness
605 2011-11-23T23:27:03 *** raignarok
606 2011-11-23T23:43:34 <eSyr> they're too fast for me -_-
607 2011-11-23T23:50:30 *** MattMaker
608 2011-11-23T23:52:51 *** xjjk
609 2011-11-23T23:54:01 *** grzywacz
610 2011-11-23T23:56:06 *** MattMaker
611 2011-11-23T23:57:06 <TheSheep> jbillsgci11: I have a couple of comments about your patch for headings css
612 2011-11-23T23:58:58 <TheSheep> jbillsgci11: first of all, why are all the distances you used in pixels, even though all other distances used in this css file already are in em?
613 2011-11-23T23:59:30 <TheSheep> jbillsgci11: second, you repeated those :hover rules, but instead you could just have a single rule
