MoinMoin: MoinMoinChat/Logs/moin-dev/2011-11-24

   1 2011-11-24T00:00:43  <TheSheep> jbillsgci11: third, please follow the style of the rest of that file in regards to spacing and formatting
   2 2011-11-24T00:01:27  <TheSheep> jbillsgci11: that's from quick look at it, sorry for the delay, I will check the actual looks tomorrow first thing
   3 2011-11-24T05:06:04  *** MattMaker has quit IRC
   4 2011-11-24T05:29:33  *** MattMaker has joined #moin-dev
   5 2011-11-24T06:01:07  *** xjjk has joined #moin-dev
   6 2011-11-24T07:57:51  *** qxcv has joined #moin-dev
   7 2011-11-24T08:44:38  <dreimark> eSyr: http://www.google-melange.com/gci/task/view/google/gci2011/7122302
   8 2011-11-24T09:16:27  <eSyr> dreimark: well, i'm waiting response from Akash Sinha.
   9 2011-11-24T09:17:03  <eSyr> dreimark: he had reviewed first part (and his review made me rather concerning about quality of work).
  10 2011-11-24T09:20:53  <eSyr> *concerned
  11 2011-11-24T10:16:40  *** greg_f has joined #moin-dev
  12 2011-11-24T11:59:59  *** jek has quit IRC
  13 2011-11-24T12:07:21  *** jek has joined #moin-dev
  14 2011-11-24T12:26:14  *** pkumar has joined #moin-dev
  15 2011-11-24T12:44:58  <ThomasWaldmann> moin
  16 2011-11-24T12:50:18  <ThomasWaldmann> eSyr: there also needs to be a check whether it is a correct po file
  17 2011-11-24T12:51:06  <ThomasWaldmann> so before accepting, let the student put it on master19 wiki, to see if processing gives warnings/errors
  18 2011-11-24T12:55:04  <ThomasWaldmann> eSyr: what do you think about changing the translation tasks as i suggested yday?
  19 2011-11-24T12:57:56  *** qxcv has quit IRC
  20 2011-11-24T13:06:03  <eSyr> ThomasWaldmann: hm, i've missed your proposal, checking backlog.
  21 2011-11-24T13:06:19  <eSyr> ah, see.
  22 2011-11-24T13:06:22  <eSyr> hm.
  23 2011-11-24T13:08:13  *** Lanka has joined #moin-dev
  24 2011-11-24T13:20:33  <ThomasWaldmann> Lanka: i just commented on your task in melange
  25 2011-11-24T13:22:48  <Lanka> ThomasWaldmann, I'll have a look
  26 2011-11-24T15:26:31  *** Lanka has quit IRC
  27 2011-11-24T15:27:12  *** jbillsgci11 has quit IRC
  28 2011-11-24T15:40:38  *** Lanka has joined #moin-dev
  29 2011-11-24T16:33:24  *** Lanka has quit IRC
  30 2011-11-24T18:23:18  * ThomasWaldmann throws a needle into the channel
  31 2011-11-24T18:23:55  <ThomasWaldmann> http://www.google-melange.com/gci/task/view/google/gci2011/7122302 needsreview
  32 2011-11-24T18:44:46  *** greg_f has quit IRC
  33 2011-11-24T18:54:48  <eSyr> pkumar: can you review it? Thanks in advance.
  34 2011-11-24T19:15:26  *** grzywacz has joined #moin-dev
  35 2011-11-24T19:15:26  *** grzywacz has joined #moin-dev
  36 2011-11-24T19:23:49  *** Lanka has joined #moin-dev
  37 2011-11-24T19:49:51  <Lanka> ThomasWaldmann, hi, the apparently tar thing does not work. :( http://paste.pocoo.org/show/aT06bxc0ndnW27PmJHWG/
  38 2011-11-24T19:57:57  *** raignarok has joined #moin-dev
  39 2011-11-24T20:11:28  <ThomasWaldmann> hi lanka
  40 2011-11-24T20:12:04  <ThomasWaldmann> zip?
  41 2011-11-24T20:12:37  <Lanka> ThomasWaldmann, haven't tried zip
  42 2011-11-24T20:12:45  <ThomasWaldmann> try
  43 2011-11-24T20:12:51  <Lanka> ok
  44 2011-11-24T20:20:39  <Lanka> ThomasWaldmann, it too generate an error http://test.moinmo.in:8080/zip http://paste.pocoo.org/show/4sz9qKHbFFMUPnHkFv5Y/
  45 2011-11-24T20:21:20  <Lanka> I'm quite certain now that the issue is not from my end, but is some bug
  46 2011-11-24T20:22:11  <ThomasWaldmann> ok, submit and add those urls
  47 2011-11-24T20:22:26  <Lanka> Shall I write a bug or?
  48 2011-11-24T20:23:01  <ThomasWaldmann> yes
  49 2011-11-24T20:24:58  <pkumar> eSyr : sure
  50 2011-11-24T20:25:21  <izibi> ThomasWaldmann: http://paste.pocoo.org/show/512044/ please take a look at this patch (view the raw patch, somehow there's something missing)
  51 2011-11-24T20:25:21  * ThomasWaldmann on android currently
  52 2011-11-24T20:28:19  <Lanka> ThomasWaldmann, https://bitbucket.org/thomaswaldmann/moin-2.0/issue/119/zip-and-tar-uploading-doesnt-work-in-the
  53 2011-11-24T20:29:59  <Lanka> ThomasWaldmann, is there anything else that I can do in this task?
  54 2011-11-24T20:30:47  <Lanka> If not, I'd like to mark this as complete and move in to another task.  :)
  55 2011-11-24T20:34:33  <ThomasWaldmann> izibi: where is bcc used?
  56 2011-11-24T20:35:05  <izibi> ThomasWaldmann: at the moment nowhere. there is no code to send change notifcation mails at the moment
  57 2011-11-24T20:35:22  <ThomasWaldmann> oops
  58 2011-11-24T20:35:28  <izibi> but there are some tests that need to be adjusted
  59 2011-11-24T20:36:37  <izibi> no, they actually use only other functions from the sendmail module
  60 2011-11-24T20:36:52  <pkumar> eSyr : better from previous file. Modifications have been done, still I notice prepositions missing at few places, few sentences still make seems like unusual hindi, though better than earlier.
  61 2011-11-24T20:38:55  <pkumar> few negative sentences are converted into affirmative after translation
  62 2011-11-24T20:42:28  <pkumar> I would say, still big room for improvement.
  63 2011-11-24T20:42:44  <pkumar> to make it usable
  64 2011-11-24T20:47:32  <pkumar> have*
  65 2011-11-24T20:50:50  <ThomasWaldmann> pkumar: if it is beyond repair, failure is an option
  66 2011-11-24T20:51:02  <eSyr> oh, ok.
  67 2011-11-24T20:51:03  <eSyr> hm.
  68 2011-11-24T20:54:44  <ThomasWaldmann> do we have the "no GT" clause meanwhile?
  69 2011-11-24T21:00:19  <pkumar> ThomasWaldmann : I think things can be corrected in there as it's better from previous, but will need some effort
  70 2011-11-24T21:00:39  <pkumar> obviously,
  71 2011-11-24T21:01:25  <pkumar> someone needs to point out individual mistakes as he's not able to figure them out by himself
  72 2011-11-24T21:10:27  <ThomasWaldmann> gt syndrome
  73 2011-11-24T21:11:10  <ThomasWaldmann> mentor does the work
  74 2011-11-24T21:12:20  <izibi> gt?
  75 2011-11-24T21:17:23  <ThomasWaldmann> google translate
  76 2011-11-24T22:04:12  *** Lanka has quit IRC
  77 2011-11-24T22:21:52  <ThomasWaldmann> re
  78 2011-11-24T22:22:07  <ThomasWaldmann> now with real kbd
  79 2011-11-24T22:37:08  *** xjjk has quit IRC
  80 2011-11-24T22:40:50  *** xjjk has joined #moin-dev
  81 2011-11-24T22:41:16  <izibi> ThomasWaldmann: feedback on my patch?
  82 2011-11-24T22:59:14  <ThomasWaldmann> did you run the unit tests, did you try it?
  83 2011-11-24T23:00:19  <ThomasWaldmann> izibi:
  84 2011-11-24T23:09:10  <izibi> ThomasWaldmann: how to run them?
  85 2011-11-24T23:09:38  <ThomasWaldmann> py.test
  86 2011-11-24T23:14:43  <izibi> ThomasWaldmann: http://paste.pocoo.org/show/512564/
  87 2011-11-24T23:16:05  <ThomasWaldmann> did you activate the virtualenv?
  88 2011-11-24T23:17:12  <izibi> yes
  89 2011-11-24T23:17:26  <izibi> using py.test installed in the venv seems to work
  90 2011-11-24T23:19:24  <izibi> ThomasWaldmann: http://paste.pocoo.org/show/512566/
  91 2011-11-24T23:22:43  <ThomasWaldmann> that's unrelated to your change
  92 2011-11-24T23:22:55  <ThomasWaldmann> but interesting, i do not have that. maybe due to pil missing
  93 2011-11-24T23:23:17  <ThomasWaldmann> so you trigger both functions and you get the right mail?
  94 2011-11-24T23:25:28  <ThomasWaldmann> btw, please file a bug for the test failure with pil
  95 2011-11-24T23:25:42  <ThomasWaldmann> or just fix it as next task
  96 2011-11-24T23:26:32  <izibi> i have never used pil :D
  97 2011-11-24T23:27:39  <ThomasWaldmann> the question is whether the import works
  98 2011-11-24T23:27:48  <ThomasWaldmann> if it does not import, other code is used
  99 2011-11-24T23:28:58  <izibi> if the import didn't work, it would have never run the assert line ;)
 100 2011-11-24T23:29:46  <izibi> but apart from this, everything is ok?
 101 2011-11-24T23:30:43  <ThomasWaldmann> for you, the import did work
 102 2011-11-24T23:31:07  <ThomasWaldmann> you didn't answer my question
 103 2011-11-24T23:31:53  <izibi> which one?
 104 2011-11-24T23:32:00  <ThomasWaldmann> (23:21) < ThomasWal> so you trigger both functions and you get the right mail?
 105 2011-11-24T23:34:16  <izibi> yes, both work
 106 2011-11-24T23:35:59  <ThomasWaldmann> ok, commit/push
 107 2011-11-24T23:37:30  <ThomasWaldmann> btw, for next codereview we could use codereview.appspot.com - it's nice :)
 108 2011-11-24T23:40:11  <izibi> done
 109 2011-11-24T23:41:10  <izibi> wohoo, submitting urls to melange works now :D
 110 2011-11-24T23:41:42  <ThomasWaldmann> :)
 111 2011-11-24T23:43:09  <CIA-56> Julian Brost <julian.brost@googlemail.com> default * 1084:a7e861a43371 2.0/MoinMoin/apps/frontend/views.py: Added missing format character.
 112 2011-11-24T23:43:09  <CIA-56> Julian Brost <julian.brost@googlemail.com> default * 1085:02cf8494180b 2.0/docs/admin/configure.rst: Added documentation for e-mail verification feature.
 113 2011-11-24T23:43:10  <CIA-56> Julian Brost <julian.brost@googlemail.com> default * 1086:ba7b8565b854 2.0/docs/admin/configure.rst: Accidentally commited the old version of the documentation.
 114 2011-11-24T23:43:11  <CIA-56> Julian Brost <julian.brost@googlemail.com> default * 1087:699bc605d2da 2.0/MoinMoin/ (mail/sendmail.py user.py): Updated sendmail function to allow adding recipients to To: and CC: headers.
 115 2011-11-24T23:49:49  <ThomasWaldmann> izibi: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/117 find a bug, fix a bug, easy?
 116 2011-11-24T23:52:18  <izibi> wohoo, submitting documents again. most fun part of gci :D
 117 2011-11-24T23:53:50  <izibi> ThomasWaldmann: is it ok to set the account to disabled state and thus probably disallowing any other actions before verifying the mail address?
 118 2011-11-24T23:55:12  *** grzywacz has quit IRC
 119 2011-11-24T23:56:49  <ThomasWaldmann> izibi: if you announce so, before the user triggers it, i think it is acceptable
 120 2011-11-24T23:57:59  <izibi> otherwise we'd need a new flag now ;)