1 2011-11-25T00:05:25 <izibi> ThomasWaldmann: can you create a task for this?
2 2011-11-25T00:06:17 <ThomasWaldmann> aren't there any find bug fix bug easy?
3 2011-11-25T00:06:31 <izibi> yeah, i just threw my phone across the room :D
4 2011-11-25T00:06:46 <izibi> ThomasWaldmann: no, there are no fix bug tasks
5 2011-11-25T00:08:10 <ThomasWaldmann> strange
6 2011-11-25T00:10:15 <eSyr> .цшт18
7 2011-11-25T00:12:24 *** aa_
8 2011-11-25T00:12:24 *** vpv
9 2011-11-25T00:12:24 *** MattMaker
10 2011-11-25T00:12:25 *** izibi
11 2011-11-25T00:12:26 *** xjjk
12 2011-11-25T00:12:30 *** ThomasWaldmann
13 2011-11-25T00:12:32 *** marchael
14 2011-11-25T00:12:34 *** ChanServ
15 2011-11-25T00:17:29 *** xjjk
16 2011-11-25T00:17:29 *** marchael
17 2011-11-25T00:17:29 *** ThomasWaldmann
18 2011-11-25T00:17:29 *** ChanServ
19 2011-11-25T00:17:29 *** pratchett.freenode.net
20 2011-11-25T00:18:24 *** MattMaker
21 2011-11-25T00:18:24 *** izibi
22 2011-11-25T00:18:42 *** aa_
23 2011-11-25T00:18:42 *** vpv
24 2011-11-25T00:21:20 <ThomasWaldmann> we may have significantly more tasks soon
25 2011-11-25T00:33:23 *** raignarok
26 2011-11-25T00:37:38 <ThomasWaldmann> izibi: try now
27 2011-11-25T00:40:18 <izibi> now there are some :)
28 2011-11-25T00:42:10 <izibi> claimed one
29 2011-11-25T00:43:32 <ThomasWaldmann> ok
30 2011-11-25T01:15:26 <izibi> gn
31 2011-11-25T01:18:27 <ThomasWaldmann> gn
32 2011-11-25T02:21:19 *** pkumar
33 2011-11-25T02:41:07 *** nick|2
34 2011-11-25T02:41:17 *** nick|2
35 2011-11-25T02:42:47 *** nick|2
36 2011-11-25T02:42:53 *** nick|2
37 2011-11-25T03:12:44 *** jordonwii
38 2011-11-25T03:21:24 <nickr5> ThomasWaldmann: is proofreading the development section just development.rst, or are other articles included as part of it? the other ones in the 'devel' folder look like they were included under 'getting support/contributing'.
39 2011-11-25T03:22:16 <ThomasWaldmann> let me see...
40 2011-11-25T03:24:51 <ThomasWaldmann> only devel/development
41 2011-11-25T03:25:02 <ThomasWaldmann> rather quick task :)
42 2011-11-25T03:25:12 <nickr5> alright thanks :)
43 2011-11-25T03:26:06 <ThomasWaldmann> docs/index.rst would be a nice extra, if you feel it was too quick
44 2011-11-25T03:28:50 <nickr5> ok
45 2011-11-25T04:09:29 *** jbillsgci11
46 2011-11-25T04:13:46 *** nickr5
47 2011-11-25T04:30:45 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1088:3b8e7106c12c 2.0/docs/ (devel/development.rst index.rst): docs: development: proofread and improved English, thanks to Nick Rioux
48 2011-11-25T04:32:15 *** jordonwii
49 2011-11-25T05:24:27 *** jbillsgci11
50 2011-11-25T05:50:45 *** lanka
51 2011-11-25T06:16:48 *** lanka
52 2011-11-25T06:24:20 <dreimark> moin
53 2011-11-25T06:43:44 *** Trip_
54 2011-11-25T06:45:48 *** Trip_
55 2011-11-25T06:47:29 *** MattMaker
56 2011-11-25T07:07:12 *** jordonwii
57 2011-11-25T07:22:52 *** jordonwii
58 2011-11-25T07:28:03 *** jbillsgci11
59 2011-11-25T07:39:41 *** Trip_
60 2011-11-25T07:40:04 *** MattMaker
61 2011-11-25T07:56:51 *** MattMaker
62 2011-11-25T07:58:29 *** MattMaker
63 2011-11-25T08:18:52 *** jbillsgci11
64 2011-11-25T08:20:13 *** jbillsgci11
65 2011-11-25T09:12:21 *** MattMaker
66 2011-11-25T09:20:11 *** raignarok
67 2011-11-25T09:30:20 <eSyr> he, about 117 messages updated in http://www.google-melange.com/gci/work/download/google/gci2011/7134387?id=14001
68 2011-11-25T09:30:40 <eSyr> (and deadline has passed -_-)
69 2011-11-25T09:30:56 <eSyr> is there some way melange can notify about updates via e-mail?
70 2011-11-25T09:37:33 *** jbillsgci11
71 2011-11-25T09:37:47 *** greg_f
72 2011-11-25T09:38:11 *** jbillsgci11
73 2011-11-25T09:42:41 *** Guest2692
74 2011-11-25T09:55:38 *** Guest2692
75 2011-11-25T10:29:39 *** qxcv
76 2011-11-25T10:34:14 *** raignarok
77 2011-11-25T10:47:13 *** jbillsgci11
78 2011-11-25T10:50:46 *** jbillsgci11
79 2011-11-25T11:32:27 *** raignarok
80 2011-11-25T11:43:54 *** danielszoska
81 2011-11-25T11:44:10 *** danielszoska
82 2011-11-25T11:54:51 *** raignarok
83 2011-11-25T11:55:04 *** raignarok
84 2011-11-25T12:08:23 *** raignarok
85 2011-11-25T12:08:34 *** raignarok
86 2011-11-25T12:38:00 *** jbillsgci11
87 2011-11-25T12:41:49 *** jbillsgci11
88 2011-11-25T12:59:52 <ThomasWaldmann> moin
89 2011-11-25T13:04:56 <qxcv> ThomasWaldmann: I've got a patch for the "write high-level tests for all views" task, but I had to put it at http://paste.pocoo.org/show/8fBtXrreknur8LIQ1532/ because the file upload isn't working
90 2011-11-25T13:06:23 <qxcv> it's 98% finished, but I'm still having some problems with moinmoin's pytest_pymodule_makeitem hooking in MoinMoin/conftest.py
91 2011-11-25T13:08:46 <qxcv> I've marked it as ready-to-review, but I'm still not sure how to fix the problem with my pytest_generate_tests hook conflicting with pytest_pymodule_makeitem
92 2011-11-25T13:13:55 *** raignarok
93 2011-11-25T13:14:51 <ThomasWaldmann> ronny: ^^
94 2011-11-25T13:17:52 *** pkumar
95 2011-11-25T13:18:11 <pkumar> moin
96 2011-11-25T13:22:10 <ThomasWaldmann> qxcv: patch looks interesting
97 2011-11-25T13:23:19 <ThomasWaldmann> you can fork m2 on bitbucket and submit url
98 2011-11-25T13:23:58 <qxcv> ok, this is my first time using mercurial so it could take a while, though :)
99 2011-11-25T13:26:05 <ThomasWaldmann> it's easy
100 2011-11-25T13:30:24 <ThomasWaldmann> eSyr: why did you only prolong the deadline of 1 hi task and not also of the other?
101 2011-11-25T13:30:35 <ThomasWaldmann> why is there no communication on melange?
102 2011-11-25T13:31:28 <pkumar> ThomasWaldmann : moin, was just wondering about the task with testing "skipping/failing tests", it's not there on EasyToPage anymore. ?
103 2011-11-25T13:32:34 <ThomasWaldmann> if you do only look at melange, it looks like bad mentoring as our discussion here is not visible there. if a student submits stuff, there should be review and and answer on melange. esp. if the student is not on this channel.
104 2011-11-25T13:33:28 <ThomasWaldmann> pkumar: i submitted lots of tasks yesterday. after submission, i set the count to -N, so it vanishes from the list.
105 2011-11-25T13:33:46 <ThomasWaldmann> qxcv: you can use the time while we review
106 2011-11-25T13:34:07 <pkumar> ah! ok.
107 2011-11-25T13:34:53 <ThomasWaldmann> btw, did sinha communicate with you eSyr? he is not that much present here.
108 2011-11-25T13:34:59 <qxcv> ok
109 2011-11-25T13:36:05 <ThomasWaldmann> for the hi tasks I would suggest reviewing it, deciding about whether it can be fixed with 1,2d more work, tell the student about the problems.
110 2011-11-25T13:36:34 <ThomasWaldmann> if it can be fixed and the student does so, succeed it. if it is beyond fixing or the student fails to fix it, fail it.
111 2011-11-25T13:37:09 <ThomasWaldmann> but don't let it look like mentor/reviewer/org fail.
112 2011-11-25T13:39:08 <ThomasWaldmann> pkumar: and if sinha has not time, i would very much appreciate if you could help with this.
113 2011-11-25T13:40:21 <pkumar> sure,
114 2011-11-25T13:41:05 <ThomasWaldmann> that doesn't mean btw that you have to do the translation work, that is the task of the student
115 2011-11-25T13:41:10 <pkumar> well, I tink that translation can be fixed with few efforts
116 2011-11-25T13:41:20 <pkumar> think*
117 2011-11-25T13:41:37 <pkumar> 1 day should be more than enough
118 2011-11-25T13:41:39 <ThomasWaldmann> ok, write a few lines about it and we put that 1:1 into melange
119 2011-11-25T13:42:00 <ThomasWaldmann> hi1 and hi2 separately, if there are different issues.
120 2011-11-25T13:42:11 <pkumar> ok
121 2011-11-25T13:42:33 <qxcv> ThomasWaldmann: https://bitbucket.org/qxcv/moin-2.0-viewtests
122 2011-11-25T13:42:42 <pkumar> I just went through those files very roughly. lemme just go trough them once more
123 2011-11-25T13:42:58 <ThomasWaldmann> qxcv: ah :)
124 2011-11-25T14:01:16 <ThomasWaldmann> qxcv: btw, in case you do NOT feel the need to stay anonymous, you could configure mercurial to use you real name / email
125 2011-11-25T14:01:40 <ThomasWaldmann> if i pull the stuff from you repo, it will go into main repo history "as is"
126 2011-11-25T14:02:37 <ThomasWaldmann> also, if you want to do more moin-related stuff, you could name your repo just yourname/moin-2.0, so it also fits for other tasks
127 2011-11-25T14:04:24 <qxcv> will I have to revert my commit and re-commit for a name change in my .hgrc to take effect? or is there an easier way?
128 2011-11-25T14:06:20 <ThomasWaldmann> yes. maybe just kill your public repo, fork a new one under the generic name, clone it locally, reapply patch, commit afte editing .hgrc
129 2011-11-25T14:06:43 <ThomasWaldmann> a bit of work, but then you are all set and get correctly credited in moin history
130 2011-11-25T14:07:15 *** MattMaker
131 2011-11-25T14:08:51 *** jbillsgci11
132 2011-11-25T14:20:58 <qxcv> ThomasWaldmann: https://bitbucket.org/qxcv/moin-2.0
133 2011-11-25T14:21:17 *** raignarok
134 2011-11-25T14:23:40 <pkumar> brb
135 2011-11-25T14:25:21 <ThomasWaldmann> qxcv: as ronny, our py.test magic specialist seems to be currently unavailable, can you just ask on #pylib?
136 2011-11-25T14:26:00 <ThomasWaldmann> or alternatively, run your tests in another way?
137 2011-11-25T14:26:29 <ThomasWaldmann> btw, did you run ALL tests? just py.test in toplevel dir.
138 2011-11-25T14:26:37 <qxcv> yes
139 2011-11-25T14:26:52 <qxcv> only the two which require the pytest_generate_tests hook failed
140 2011-11-25T14:27:06 <qxcv> I'll ask in #pylib
141 2011-11-25T14:27:19 <ThomasWaldmann> ok, but we should get back to 0 fails before merging :)
142 2011-11-25T14:38:24 <ThomasWaldmann> bbl
143 2011-11-25T14:51:27 *** jbillsgci11
144 2011-11-25T14:57:31 <qxcv> ThomasWaldmann: would http://paste.pocoo.org/show/512791/ be an acceptable solution? I've just expanded the parameterised test_item_actions test like a macro
145 2011-11-25T14:58:03 <qxcv> lots of duplicated code, but it works without having to delve into pytest issues
146 2011-11-25T15:08:48 <ThomasWaldmann> hmm, pastebin sloooow
147 2011-11-25T15:09:08 <ThomasWaldmann> how about using codereview.appspot.com in future?
148 2011-11-25T15:09:14 <ThomasWaldmann> pastebin on steroids
149 2011-11-25T15:09:46 <qxcv> looks neat
150 2011-11-25T15:09:59 <ThomasWaldmann> somehow that stuff looks like a loop with a print and a call
151 2011-11-25T15:10:13 <ThomasWaldmann> and some list having the tests tuples
152 2011-11-25T15:12:48 <qxcv> that's how it was generated :)
153 2011-11-25T15:14:09 <qxcv> the reason I unrolled the loop was because otherwise if one test fails then the rest of the tests in that group don't get run
154 2011-11-25T15:40:08 *** raignarok
155 2011-11-25T15:42:23 *** jbillsgci11
156 2011-11-25T15:45:16 <qxcv> ThomasWaldmann: all the tests are running now, ready for review https://bitbucket.org/qxcv/moin-2.0
157 2011-11-25T15:46:35 *** jbillsgci11
158 2011-11-25T16:00:02 *** qxcv
159 2011-11-25T16:04:30 *** MattMaker
160 2011-11-25T16:14:47 * ThomasWaldmann looks
161 2011-11-25T16:22:34 <eSyr> ThomasWaldmann: i wrote two letters to him but he didn't answered.
162 2011-11-25T16:22:56 <ThomasWaldmann> you mean e-mail? :)
163 2011-11-25T16:23:06 <ronny> re
164 2011-11-25T16:23:29 <eSyr> yes.
165 2011-11-25T16:23:47 <ThomasWaldmann> wb ronny. can you have a look there? https://bitbucket.org/qxcv/moin-2.0
166 2011-11-25T16:24:06 <ronny> ThomasWaldmann: the problems qxcv had are caused by the way makeitem works in pytest, the default one does the generate_tests mechanism atm
167 2011-11-25T16:24:51 <ThomasWaldmann> ronny: can we keep the tests as qxcv has them right now?
168 2011-11-25T16:25:01 <ThomasWaldmann> looks easy
169 2011-11-25T16:25:27 <ronny> ThomasWaldmann: yeah, later they can be condesned to a list of tuples
170 2011-11-25T16:28:02 <ThomasWaldmann> ok, i'll do some testing with his changes and accept if there is nothing special
171 2011-11-25T16:32:59 *** jbillsgci11
172 2011-11-25T16:58:33 <izibi> ThomasWaldmann: where to add the warning message that your account will be disabled if you change the email address? just use the flash() function or add it to the template?
173 2011-11-25T16:59:48 <ThomasWaldmann> http://www.google-melange.com/gci/task/view/google/gci2011/7116303 < lol
174 2011-11-25T17:01:15 <ThomasWaldmann> but at least he had doubts :)
175 2011-11-25T17:09:22 <eSyr> uh-oh.
176 2011-11-25T17:12:18 <eSyr> ThomasWaldmann: does melngae have some notification system?
177 2011-11-25T17:12:22 <eSyr> *melange
178 2011-11-25T17:13:40 <eSyr> because i haven't receive any -_-
179 2011-11-25T17:13:53 <ThomasWaldmann> eSyr: theoretically yes. did you manually click on that subscribe button?
180 2011-11-25T17:16:02 <eSyr> ah, i see.
181 2011-11-25T17:16:23 <eSyr> instead of looking at the top of page, i'd go to find something in user preference.
182 2011-11-25T17:16:38 <eSyr> (and found only "subscribe automatically")
183 2011-11-25T17:16:50 <eSyr> (which was checked already)
184 2011-11-25T17:17:00 <eSyr> ThomasWaldmann: thanks!
185 2011-11-25T17:21:44 <ThomasWaldmann> that automatical thing doesn't work yet, and it is known to them
186 2011-11-25T17:23:08 <dreimark> re
187 2011-11-25T17:25:19 <dreimark> ThomasWaldmann: is there still time to upload to upload some tasks?
188 2011-11-25T17:26:53 *** nickr5
189 2011-11-25T17:26:57 <ThomasWaldmann> i don't know the exact deadline, but on the ml there was some post last sunday/monday, about that we have "a week" longer to modify or submit tasks
190 2011-11-25T17:28:52 <dreimark> i added some ideas in the morning
191 2011-11-25T17:29:18 <dreimark> thought i mentioned it here, but may be i was on a different channel
192 2011-11-25T17:29:39 <dreimark> can work on more tasks in the evening
193 2011-11-25T17:30:39 <ThomasWaldmann> if the task is ready until later today, we can try to shoot it
194 2011-11-25T17:31:49 <dreimark> some with delay because of other tasks or todo i set already the count:1
195 2011-11-25T17:34:36 <dreimark> you were faster in commenting of the grammar task ;)
196 2011-11-25T17:34:39 <dreimark> bbl
197 2011-11-25T17:35:41 <ThomasWaldmann> would be perfect if we had a native speaker to check these ones
198 2011-11-25T18:06:18 *** raignarok
199 2011-11-25T18:20:12 <pkumar> ThomasWaldmann : I read both the files and I have few suggestions which I've jotted down http://paste.pocoo.org/show/512880/
200 2011-11-25T18:20:30 <pkumar> the mistakes are repeating in both the files
201 2011-11-25T18:23:57 <pkumar> If point 5 is taken care in there, rest other can be dealt with, simply.
202 2011-11-25T18:25:42 <pkumar> apart from those, translation is fine
203 2011-11-25T18:29:01 <ThomasWaldmann> pkumar: ok, i c&p it into melange
204 2011-11-25T18:29:10 <ThomasWaldmann> how much time is needed to fix?
205 2011-11-25T18:30:02 <eSyr> pkumar: thanks alot!
206 2011-11-25T18:30:05 <pkumar> 2-3 hrs max., if done very carefully, each sentence at a time
207 2011-11-25T18:30:16 <pkumar> np!
208 2011-11-25T18:31:38 <ThomasWaldmann> ok, so i give +24h to avoid tz/sleep/other issues
209 2011-11-25T18:32:29 <ThomasWaldmann> pkumar: thanks for reviewing
210 2011-11-25T18:34:01 <pkumar> that should be good enough time to fix it all.
211 2011-11-25T18:34:07 <pkumar> np!
212 2011-11-25T18:42:15 <ThomasWaldmann> pkumar: how much of the issues came from machine translation?
213 2011-11-25T18:51:53 <pkumar> machine translation? hi(2/2) ?
214 2011-11-25T18:54:00 <ThomasWaldmann> pkumar: i mean for the N issues you found (in total), how many were human errors and how many were machine translation errors without a human fixing them?
215 2011-11-25T18:59:01 <pkumar> well, there were quite a few errors/mistakes in there, didn't count exactly. most of them were machine translation errors.
216 2011-11-25T19:06:04 <ThomasWaldmann> ok, so from now on we'll have a "you must not use machine translation" clause.
217 2011-11-25T19:06:30 <ThomasWaldmann> fixing all those errors is likely more pain for students and mentors than just not using MT
218 2011-11-25T19:08:41 <pkumar> yeah, machine translators do help in words but for sentences sometimes they end up giving alien results.
219 2011-11-25T19:09:14 <pkumar> which becomes a a pain for translations in our case
220 2011-11-25T19:26:55 <izibi> ThomasWaldmann: 16:55 < izibi> ThomasWaldmann: where to add the warning message that your account will be disabled if change the email address? just use the flash() function or add it to the template?
221 2011-11-25T19:32:40 <ThomasWaldmann> izibi: well, you need to detect the change on submit anyway
222 2011-11-25T19:33:56 <ThomasWaldmann> then tell the user that changing email will require verification and that the account will be disabled until done so.
223 2011-11-25T19:36:22 <izibi> ThomasWaldmann: yes, but didn't you say i should warn the user before he changes his email address?
224 2011-11-25T19:40:42 <ThomasWaldmann> yes, but maybe only when he really tries to
225 2011-11-25T19:41:05 <ThomasWaldmann> and give the option to not change after reading the warning
226 2011-11-25T19:41:40 <ThomasWaldmann> i suggest you make a plan for this first, on a wiki page before starting to hack it
227 2011-11-25T19:43:31 *** MattMaker
228 2011-11-25T19:47:03 <izibi> ThomasWaldmann: what's wrong with a nice warning message above the form field?
229 2011-11-25T19:50:50 <ThomasWaldmann> could be also done. provides information not needed as long as you don't change, though.
230 2011-11-25T19:59:39 <ThomasWaldmann> bbl
231 2011-11-25T20:23:13 <pkumar> bbl
232 2011-11-25T20:23:16 *** pkumar
233 2011-11-25T21:07:19 *** grzywacz
234 2011-11-25T21:07:20 *** grzywacz
235 2011-11-25T21:29:19 *** raignarok
236 2011-11-25T21:32:20 *** raignarok
237 2011-11-25T22:10:34 <ThomasWaldmann> re
238 2011-11-25T22:19:50 <ronny> ThomasWaldmann: sup
239 2011-11-25T22:20:42 <ronny> ThomasWaldmann: i changed conftest to work wth generate_tests
240 2011-11-25T22:21:15 <ThomasWaldmann> ah, great
241 2011-11-25T22:21:38 <ThomasWaldmann> how many failing tests do you get if you run just py.test?
242 2011-11-25T22:22:56 <ronny> whops
243 2011-11-25T22:23:02 <ronny> foun a typo again
244 2011-11-25T22:23:06 <ronny> but now it should be fine
245 2011-11-25T22:23:21 <ronny> i moved the setup code to a item_setup hook
246 2011-11-25T22:23:35 <ronny> which means i only need a own function object for generators
247 2011-11-25T22:34:44 <ThomasWaldmann> ronny: did you transform one test as an example to show usage? if so, can you refer to it from conftest.py?
248 2011-11-25T22:38:16 *** grzywacz
249 2011-11-25T22:57:13 *** nickr5
250 2011-11-25T23:04:43 <dreimark> moin
251 2011-11-25T23:05:47 <ronny> ThomasWaldmann: atm i get 14 fails in acl stuff, no idea why
252 2011-11-25T23:44:36 <ThomasWaldmann> ronny: branch "default"?
253 2011-11-25T23:54:01 *** grzywacz
254 2011-11-25T23:54:01 *** grzywacz
255 2011-11-25T23:54:46 <ronny> ThomasWaldmann: yes
256 2011-11-25T23:54:57 <ronny> ThomasWaldmann: i suppose the setup code is not completely allright atm
