MoinMoin: MoinMoinChat/Logs/moin-dev/2011-12-22

   1 2011-12-22T00:04:03  *** grzywacz has quit IRC
   2 2011-12-22T01:32:16  *** qxcv has joined #moin-dev
   3 2011-12-22T01:48:31  <cdbs> ThomasWaldmann: there? app.storage seems to be an IndexingMiddleware object, how do we get a ProtectingMiddleware out of it?
   4 2011-12-22T01:48:52  * cdbs tried
   5 2011-12-22T02:01:43  <cdbs> ThomasWaldmann: On the other hand, from what I'm getting from the code, app.storage IS unprotected storage
   6 2011-12-22T02:01:59  <cdbs> ThomasWaldmann: from before_wifi function in MoinMoin/app.py
   7 2011-12-22T02:04:23  <cdbs> for the unprotected storage, we'd first need to initialize a ProtectingMiddleware opject
   8 2011-12-22T02:04:36  <cdbs> which isn't the case with app.storage because its unprotected in the first place
   9 2011-12-22T02:07:27  *** raignarok has quit IRC
  10 2011-12-22T02:53:39  *** MattMaker has joined #moin-dev
  11 2011-12-22T03:03:25  <cdbs> ThomasWaldmann: Ping me when you're back, I'm usually always here
  12 2011-12-22T08:33:08  <dreimark> moin
  13 2011-12-22T08:33:21  <dreimark> ThomasWaldmann: we need a new textcha on MM
  14 2011-12-22T08:34:33  <dreimark> hmm if we can identify a spammer we should give him his own Sandboxwiki
  15 2011-12-22T08:45:44  <dreimark> and we should be able to adjust surge protection per user
  16 2011-12-22T08:51:58  *** pkumar has joined #moin-dev
  17 2011-12-22T09:06:37  <dreimark> ThomasWaldmann: BC does not update on MM
  18 2011-12-22T10:37:27  *** greg_f has joined #moin-dev
  19 2011-12-22T11:03:23  <ThomasWaldmann> moin
  20 2011-12-22T11:07:41  <ThomasWaldmann> cdbs: yes, protection is setup in before_wiki
  21 2011-12-22T11:09:50  <ThomasWaldmann> maybe try what happens if one does not assign to .storage but .unprotected_storage (and use .storage in before_wiki)
  22 2011-12-22T11:14:49  <ThomasWaldmann> hmm, app.storage = unprotected, flaskg.storage = protected currently
  23 2011-12-22T11:21:52  <ThomasWaldmann> eSyr: what the uk translation task, the student likely needs help
  24 2011-12-22T11:22:01  <ThomasWaldmann> watch the*
  25 2011-12-22T11:34:14  <eSyr> ah, so he returned back.
  26 2011-12-22T11:34:39  <eSyr> ok, i'll put review as comment, just need to clean it up.
  27 2011-12-22T11:37:37  <ThomasWaldmann> dreimark: that spammer was human, he answered all questions correctly, some in 2nd try
  28 2011-12-22T11:39:59  <ThomasWaldmann> so we'll see if he comes back and continues to spam (maybe he sees that it all got reverted and gives up)
  29 2011-12-22T11:49:03  <ThomasWaldmann> maybe as a general comment to all students: always give a link to your gci task if you have questions or posted a comment there
  30 2011-12-22T11:49:53  <ThomasWaldmann> it is not easy to find your task without that, except if it is in some special state (like reviewneeded or claimrequested)
  31 2011-12-22T12:45:30  *** raignarok has joined #moin-dev
  32 2011-12-22T12:46:35  *** raignarok has quit IRC
  33 2011-12-22T12:46:49  *** raignarok has joined #moin-dev
  34 2011-12-22T12:59:08  *** pkumar has quit IRC
  35 2011-12-22T13:29:17  *** pkumar has joined #moin-dev
  36 2011-12-22T13:38:43  *** raignarok has quit IRC
  37 2011-12-22T13:38:54  *** raignarok has joined #moin-dev
  38 2011-12-22T13:56:30  *** raignarok has quit IRC
  39 2011-12-22T13:56:45  *** raignarok has joined #moin-dev
  40 2011-12-22T13:58:37  *** raignarok has quit IRC
  41 2011-12-22T13:58:50  *** raignarok has joined #moin-dev
  42 2011-12-22T15:02:58  *** qxcv has quit IRC
  43 2011-12-22T15:22:11  *** pkumar has quit IRC
  44 2011-12-22T15:50:03  *** raignarok has quit IRC
  45 2011-12-22T17:06:04  <dreimark> bbl
  46 2011-12-22T17:46:54  *** greg_f has quit IRC
  47 2011-12-22T18:22:11  <ThomasWaldmann> eSyr: i just put the uk translation task into "needs more work" because the student did not submit the po file on master19 wiki
  48 2011-12-22T18:22:58  <ThomasWaldmann> eSyr: how is the review of it going? i did not see ANY comment of you there yet.
  49 2011-12-22T19:58:31  *** raignarok has joined #moin-dev
  50 2011-12-22T22:31:55  *** cdbs has quit IRC
  51 2011-12-22T23:17:46  *** cdbs has joined #moin-dev
  52 2011-12-22T23:22:04  <ThomasWaldmann> re
  53 2011-12-22T23:30:31  <cdbs> ThomasWaldmann: Hi, could you review https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/19/fix-issue-130-account_create-fails ?
  54 2011-12-22T23:35:37  <ThomasWaldmann> hi cdbs
  55 2011-12-22T23:35:48  <ThomasWaldmann> yes, will look at it in a minute
  56 2011-12-22T23:41:55  <ThomasWaldmann> cdbs: ok, you ran the unit tests and created an account with this?
  57 2011-12-22T23:42:01  <cdbs> yup I did
  58 2011-12-22T23:42:17  <cdbs> the unit tests failed, but only the ones which were failing before I began writing the patch
  59 2011-12-22T23:42:32  <ThomasWaldmann> looks like you are "lucky" finding melange bugs also :D
  60 2011-12-22T23:42:42  <ThomasWaldmann> sure, 2 fails, right?
  61 2011-12-22T23:42:46  <cdbs> yup
  62 2011-12-22T23:45:31  <ThomasWaldmann> hmm, i have 3 incoming changesets from your repo
  63 2011-12-22T23:46:40  <cdbs> wait, what?
  64 2011-12-22T23:46:43  <cdbs> hmm
  65 2011-12-22T23:46:44  <ThomasWaldmann> and 2 of them are same, 1 is unwanted (the except/pass one)
  66 2011-12-22T23:46:55  <cdbs> ohk
  67 2011-12-22T23:47:45  <ThomasWaldmann> can you strip the repo and reapply 1 valid changeset for the latest work you've done
  68 2011-12-22T23:48:03  <cdbs> that's actually weird
  69 2011-12-22T23:48:08  <cdbs> I don't have a commit for that here
  70 2011-12-22T23:48:24  <cdbs> okay, I get it
  71 2011-12-22T23:48:26  <ThomasWaldmann> or, if nothing else helps, reclone and reapply
  72 2011-12-22T23:48:40  <cdbs> the repo on the server has both changesets, the local one has only the needed one
  73 2011-12-22T23:49:29  <cdbs> I thoght -f should've re-written the change like it did last time, but it didn't
  74 2011-12-22T23:49:31  <ThomasWaldmann> have a backup, kill it, recreate it :)
  75 2011-12-22T23:49:41  <ThomasWaldmann> maybe you could even name it moin-2.0
  76 2011-12-22T23:49:53  <ThomasWaldmann> just in case you want to contribute after gci also :)
  77 2011-12-22T23:50:06  <cdbs> I'll use the bitbucket strip function
  78 2011-12-22T23:51:20  <cdbs> ThomasWaldmann: done, you can check now
  79 2011-12-22T23:52:08  <cdbs> I should've used hg blackout, instead I just did hg rollback and hg revert, that would've avoided the mess in the first place
  80 2011-12-22T23:54:00  <CIA-59> Bilal Akhtar <bilalakhtar@ubuntu.com> default * 1174:dca962df5e93 2.0/MoinMoin/script/account/create.py: Fix crash when running account_create
  81 2011-12-22T23:54:32  <ThomasWaldmann> you need to submit something to melange, so i can close
  82 2011-12-22T23:55:46  <cdbs> ThomasWaldmann: done, now closing issue
  83 2011-12-22T23:56:25  <cdbs> closed :) Thanks a lot!
  84 2011-12-22T23:56:32  <ThomasWaldmann> ok, thanks for working on that (and sorry for the complications :)
  85 2011-12-22T23:56:39  <cdbs> its okay :)
  86 2011-12-22T23:56:58  <cdbs> I've troubled you much more than that, so its kinda balanced :)
  87 2011-12-22T23:59:47  <ThomasWaldmann> btw, did you also do tasks for other orgs?