1 2012-01-03T01:00:39 *** MattMaker
2 2012-01-03T02:23:51 *** qxcv
3 2012-01-03T04:24:21 *** MattMaker
4 2012-01-03T04:51:15 *** Dragooon
5 2012-01-03T04:52:00 <Dragooon> Anybody her?
6 2012-01-03T04:52:09 <Dragooon> here*
7 2012-01-03T04:52:12 <Dragooon> ThomasWaldmann: ?
8 2012-01-03T04:52:35 <Dragooon> dreimark: ?
9 2012-01-03T05:02:55 *** MattMaker
10 2012-01-03T05:04:26 <Dragooon> MattMaker: Are you a mentor?
11 2012-01-03T05:35:36 <MattMaker> I am not
12 2012-01-03T05:36:13 <MattMaker> I mean, you can ask me a question, but I'm just some guy
13 2012-01-03T05:40:29 <Dragooon> Well, you can review if the change I made is correct, right?
14 2012-01-03T06:37:15 <MattMaker> Regrettably, no. I haven't looked at the code in a while. I made some patches awhile back, and I will probably contribute again in the future, but my understanding of the code is not current.
15 2012-01-03T06:38:45 <Dragooon> No problem, I think I figured out a good solution for the problem
16 2012-01-03T08:26:04 *** Dragooon
17 2012-01-03T08:35:32 *** Dragooon
18 2012-01-03T08:37:21 <Dragooon> Back
19 2012-01-03T08:37:22 <Dragooon> N
20 2012-01-03T08:37:24 <Dragooon> No one here?
21 2012-01-03T08:44:41 <dreimark> moin
22 2012-01-03T08:45:08 <dreimark> Dragooon: please don't ask to ask
23 2012-01-03T08:45:25 <dreimark> everyone here if he is able to help will try to help
24 2012-01-03T08:46:07 <Dragooon> Sorry, got a little bit impatient
25 2012-01-03T08:46:52 <Dragooon> I have uploaded the fixed version of atom feed
26 2012-01-03T08:47:45 <dreimark> ThomasWaldmann: i currently look at the sphinx task
27 2012-01-03T09:35:38 <dreimark> ThomasWaldmann: comments added. some more questions should be answered. work is great so far
28 2012-01-03T09:36:07 <dreimark> eSyr: http://www.google-melange.com/gci/task/view/google/gci2011/7196360
29 2012-01-03T09:36:26 <dreimark> is something missing from a translators perspective ?
30 2012-01-03T09:40:53 <Dragooon> dreimark: Can you tell me the difficulty of this issue?
31 2012-01-03T09:40:54 <Dragooon> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/127/footnote-placing-does-not-work
32 2012-01-03T09:50:04 <dreimark> i guess it is easy or medium.
33 2012-01-03T09:51:43 <Dragooon> Uploaded minor fixes
34 2012-01-03T09:54:00 <Dragooon> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/141/empty-item-gives-ugly-rendering
35 2012-01-03T09:54:02 <Dragooon> ^ That one?
36 2012-01-03T10:25:14 *** greg_f
37 2012-01-03T10:54:43 <dreimark> Dragooon: easy
38 2012-01-03T10:55:07 <Dragooon> Yeah okay
39 2012-01-03T10:55:14 <dreimark> http://moinmo.in/EasyToDo some summmarize at end of that page
40 2012-01-03T10:59:34 <Dragooon> Metadata editing sounds easy
41 2012-01-03T11:46:31 <ThomasWaldmann> moin
42 2012-01-03T11:46:45 <Dragooon> We great people like that here?
43 2012-01-03T11:52:08 <ThomasWaldmann> http://moinmo.in/MoinMoinEtymology
44 2012-01-03T11:53:38 <Dragooon> ThomasWaldmann: Hopefully I got the escaping problem figured out now :)
45 2012-01-03T11:55:04 <ThomasWaldmann> if you want review, just give the url.
46 2012-01-03T11:55:23 <Dragooon> ThomasWaldmann: http://codereview.appspot.com/5489133/
47 2012-01-03T12:31:03 <ThomasWaldmann> review done
48 2012-01-03T12:31:40 <ThomasWaldmann> as it is still inconsistent, i did not check for full correctness
49 2012-01-03T12:32:16 <Dragooon> I didn't drop XSLT but decided to correct Mime
50 2012-01-03T12:32:29 <Dragooon> As that way it'll be available for those who support it properly without messing anything
51 2012-01-03T12:32:34 <ThomasWaldmann> comment there
52 2012-01-03T12:33:12 <ThomasWaldmann> and the stuff that is useful long-term should be in the source comments
53 2012-01-03T12:36:08 <Dragooon> ok let me fix
54 2012-01-03T12:36:13 <Dragooon> Trying to install Moin all day
55 2012-01-03T12:37:34 <ThomasWaldmann> ? that should take far less.
56 2012-01-03T12:38:10 <Dragooon> Downloading at 4kbps doesn't help
57 2012-01-03T12:39:06 <ThomasWaldmann> make sure to (re)use the dlc dir if your conn is that slow
58 2012-01-03T12:40:06 <Dragooon> It won't cause conflicts?
59 2012-01-03T12:40:41 <ThomasWaldmann> it is just a download cache, so it won't download same stuff again
60 2012-01-03T12:41:59 <ThomasWaldmann> why is your conn that slow btw?
61 2012-01-03T12:42:11 <Dragooon> It isn't
62 2012-01-03T12:42:16 <Dragooon> Somehow it's been acting up
63 2012-01-03T12:46:02 <Dragooon> Damnit, working on 3 tasks at once doesn't help
64 2012-01-03T12:48:16 <ThomasWaldmann> how is that possible? :)
65 2012-01-03T12:48:48 <Dragooon> I multi task and then get them approved later
66 2012-01-03T12:49:21 <ThomasWaldmann> you mean you work on stuff before claiming?
67 2012-01-03T12:49:44 <Dragooon> Yes
68 2012-01-03T12:50:17 <ThomasWaldmann> risky and not quite intended like that
69 2012-01-03T12:50:33 <Dragooon> Yes
70 2012-01-03T12:56:47 <Dragooon> ThomasWaldmann: "use "..." for attribute values" What?
71 2012-01-03T12:57:20 <ThomasWaldmann> you used '...' at one place and "..." at another place in same file
72 2012-01-03T12:57:29 <Dragooon> It's like this
73 2012-01-03T12:57:36 <Dragooon> "Long title Long title long title…"
74 2012-01-03T12:57:37 <Dragooon> Then at body
75 2012-01-03T12:57:43 <Dragooon> "…Long title long title long title"
76 2012-01-03T12:58:33 <Dragooon> That's so that the titles don't become too long and mess up the reader
77 2012-01-03T12:58:43 <ThomasWaldmann> btw, why is that, is there a length limit for title?
78 2012-01-03T12:58:55 <Dragooon> No, but having a 250 char title is really annoying
79 2012-01-03T12:59:24 <ThomasWaldmann> you are using the comment as title currently
80 2012-01-03T12:59:29 <Dragooon> Yea
81 2012-01-03T12:59:38 <ThomasWaldmann> not sure whether that is that useful
82 2012-01-03T12:59:52 <ThomasWaldmann> because many people are lazy and just saving without comment
83 2012-01-03T12:59:59 <Dragooon> THen it'll say no comment
84 2012-01-03T13:00:13 <Dragooon> Page name doesn't make sense since thats same for eveyrbody
85 2012-01-03T13:00:15 <ThomasWaldmann> it might say that 80% of the time
86 2012-01-03T13:01:26 <ThomasWaldmann> http://moinmo.in/RecentChanges just look at the right area there
87 2012-01-03T13:01:51 <Dragooon> Ah, any suggestions?
88 2012-01-03T13:01:59 <Dragooon> <hash> : <comment>?
89 2012-01-03T13:02:47 <ThomasWaldmann> <name>: <comment>
90 2012-01-03T13:03:03 <Dragooon> But name is already shown in most of the readers
91 2012-01-03T13:03:15 <ThomasWaldmann> where?
92 2012-01-03T13:03:22 <Dragooon> Below the title in mine
93 2012-01-03T13:04:05 <ThomasWaldmann> hmm, then I don't know
94 2012-01-03T13:04:13 <Dragooon> Leave as is?
95 2012-01-03T13:04:39 <ThomasWaldmann> yes
96 2012-01-03T13:08:51 <dreimark> ThomasWaldmann: http://www.google-melange.com/gci/task/view/google/gci2011/7196360
97 2012-01-03T13:09:03 <dreimark> further comments, otherwise i set it to more work
98 2012-01-03T13:10:46 <Dragooon> ThomasWaldmann: Uploaded
99 2012-01-03T13:28:09 *** dave_largo
100 2012-01-03T13:28:14 <ThomasWaldmann> dreimark: http://www.google-melange.com/gci/task/view/google/gci2011/7196360 commented there
101 2012-01-03T13:28:55 <Dragooon> Is it unethical to use type in code?
102 2012-01-03T13:29:11 <ThomasWaldmann> we should not try to extend the scope of a task beyond the original scope
103 2012-01-03T13:29:23 <dreimark> ThomasWaldmann: yes, then we should close it
104 2012-01-03T13:29:50 <dreimark> or May be we need some different mode to get at all first documentation / translation archieved.
105 2012-01-03T13:30:14 <dreimark> if we do that at all, then it is also no problem within that task
106 2012-01-03T13:30:49 <dreimark> +ourselfs
107 2012-01-03T13:33:12 <ThomasWaldmann> maybe you could try to extract and make more precise the parts of your comment that is within the original scope.
108 2012-01-03T13:35:15 <ThomasWaldmann> Dragooon: you mean type(x)?
109 2012-01-03T13:35:20 <Dragooon> Yeah
110 2012-01-03T13:35:52 <ThomasWaldmann> one usually rather uses isinstance(x, type), but only if it is really needed
111 2012-01-03T13:36:21 <Dragooon> Did you get a chance to review my upload?
112 2012-01-03T13:36:31 <ThomasWaldmann> looking now
113 2012-01-03T13:38:21 <Dragooon> BTW, https://bitbucket.org/thomaswaldmann/moin-2.0/issue/134/mediawiki-parser-throws-exception-on-file
114 2012-01-03T13:38:25 <Dragooon> What is the difficulty of that?
115 2012-01-03T13:39:32 <ThomasWaldmann> somehow those unescape calls seem to jump around randomly
116 2012-01-03T13:39:47 <Dragooon> Sorry, should've explained them
117 2012-01-03T13:39:55 <Dragooon> Basically returned content is escaped
118 2012-01-03T13:40:02 <Dragooon> When passing to render_template it gets escaped again
119 2012-01-03T13:40:15 <xorAxAx> Dragooon: have a look at Markup
120 2012-01-03T13:40:21 <Dragooon> In render_diff_atom's case it is not escaped
121 2012-01-03T13:40:21 <xorAxAx> never call unescape
122 2012-01-03T13:41:14 <Dragooon> Hm
123 2012-01-03T13:41:14 <qxcv> dreimark: tried to cover all the stuff in your comment except individual string translation http://moinmo.in/4ct10n/info/SamToyer/SphinxMoinCooperation?action=diff&rev2=22&rev1=20
124 2012-01-03T13:41:17 <Dragooon> That might work
125 2012-01-03T13:42:35 <ThomasWaldmann> xorAxAx: i was pointing at Markup() since a while, but somehow it didn't get through
126 2012-01-03T13:42:59 <Dragooon> Markup was causing me troubles elsewhere, so I didn't think of using it here
127 2012-01-03T13:45:34 <Dragooon> ThomasWaldmann: Tested and uploaded
128 2012-01-03T13:52:24 <ThomasWaldmann> Dragooon: so your initial problems with Markup() are resolved now?
129 2012-01-03T13:52:31 <Dragooon> Yea
130 2012-01-03T13:54:16 <ThomasWaldmann> can you remove unused imports?
131 2012-01-03T13:55:25 <Dragooon> Out of curiosity, do they slow things down?
132 2012-01-03T13:56:24 *** qxcv
133 2012-01-03T13:59:20 <ThomasWaldmann> Dragooon: that depends whether it is the first import of the module or not
134 2012-01-03T14:00:06 <Dragooon> Uploaded
135 2012-01-03T14:00:08 <ThomasWaldmann> if it is first import of that module, yes (significantly), if not, yes (but not significantly)
136 2012-01-03T14:00:14 <Dragooon> Oh okay
137 2012-01-03T14:01:44 <ThomasWaldmann> ok, i suggest you do test all the pathes in your code and make sure it works as expected
138 2012-01-03T14:02:29 <Dragooon> Did quite a few of them. I got 3 pages with quite weird histories
139 2012-01-03T14:02:29 <ThomasWaldmann> then you split your changeset into at least 2 smaller ones
140 2012-01-03T14:02:36 <Dragooon> 2 smaller ones?
141 2012-01-03T14:03:06 <ThomasWaldmann> like the one where you first fixed the other code (unicode issues) and then the one with your new stuff
142 2012-01-03T14:03:17 <Dragooon> Oh okay
143 2012-01-03T14:03:35 <ThomasWaldmann> before committing, make sure you configured your name/email correctly in mercurial
144 2012-01-03T14:04:00 <ThomasWaldmann> did you clone my repo on bitbucket?
145 2012-01-03T14:04:13 <Dragooon> Yeah
146 2012-01-03T14:04:43 <ThomasWaldmann> ok, then publish your stuff there and submit the repo url to melange
147 2012-01-03T14:04:46 <Dragooon> I'll do that in a minute, a guy is fixing my net so won't upload now
148 2012-01-03T14:05:08 <ThomasWaldmann> ok, i need to leave for a while now anyway
149 2012-01-03T14:05:23 <Dragooon> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/134/mediawiki-parser-throws-exception-on-file that would be easy, right?
150 2012-01-03T14:12:46 <ThomasWaldmann> maybe rather medium
151 2012-01-03T14:12:53 * ThomasWaldmann away now
152 2012-01-03T14:12:57 <Dragooon> Okay
153 2012-01-03T14:13:02 *** qxcv
154 2012-01-03T14:16:08 <Dragooon> Any idea where the logic is for footnotes in join wiki doc type?
155 2012-01-03T14:16:13 <Dragooon> moin*
156 2012-01-03T14:57:52 *** laurion
157 2012-01-03T14:59:46 *** laurion
158 2012-01-03T15:01:39 *** laurion
159 2012-01-03T15:04:10 <Dragooon> dreimark: Is this issue still valid?
160 2012-01-03T15:04:27 <Dragooon> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/76/recursion-on-item-changes
161 2012-01-03T15:16:19 <dreimark> i have had no time to split it yet
162 2012-01-03T15:17:17 <Dragooon> But if I change a title on base, it changes for the above as well
163 2012-01-03T15:17:20 <Dragooon> So does it still apply?
164 2012-01-03T15:19:47 <dreimark> then half of it is fixed.
165 2012-01-03T15:20:05 <dreimark> or total, i can't currently not check whats with the acl part
166 2012-01-03T15:20:32 <dreimark> -not
167 2012-01-03T15:27:31 <dreimark> Dragooon: comment on it that hald of it is fixed if you like
168 2012-01-03T15:27:37 <dreimark> s/d/f/
169 2012-01-03T15:29:02 <Dragooon> hg push keeps saying error 255 : searching for changes
170 2012-01-03T15:33:41 <Dragooon> Deleted remote and tried again, worked :D
171 2012-01-03T15:48:33 <ThomasWaldmann> re
172 2012-01-03T15:49:23 *** RogerHaase
173 2012-01-03T15:50:07 <ThomasWaldmann> RogerHaase: hi :) can you have a look?: http://moinmo.in/vishalpanjwani/gcitask
174 2012-01-03T15:54:54 <RogerHaase> ThomasWaldmann: The 2nd paragraph is OK. The remainder needs a lot of work.
175 2012-01-03T16:24:22 *** qxcv
176 2012-01-03T17:44:47 <ThomasWaldmann> dreimark: i think the sphinx/moin task is near to the end (from my side). i just added a small thing, but other than that it is ok for me, so i think we should close it soon.
177 2012-01-03T18:46:56 *** greg_f
178 2012-01-03T20:52:59 <dreimark> ThomasWaldmann: he is very fast, and it is very good work
179 2012-01-03T21:03:21 <dreimark> bbl
180 2012-01-03T21:56:39 *** Dragooon_
181 2012-01-03T21:56:55 <Dragooon_> Anybody here?
182 2012-01-03T21:57:30 <ThomasWaldmann> yup
183 2012-01-03T21:58:54 <Dragooon> ThomasWaldmann: Can you approve my claim for http://www.google-melange.com/gci/task/view/google/gci2011/7141270
184 2012-01-03T22:00:15 <ThomasWaldmann> done
185 2012-01-03T22:00:38 <Dragooon> Do I send a pull request or just link to the commit/
186 2012-01-03T22:00:39 <Dragooon> ?
187 2012-01-03T22:01:52 <ThomasWaldmann> submit the repo url
188 2012-01-03T22:01:57 <ThomasWaldmann> when done
189 2012-01-03T22:02:30 <Dragooon> Done
190 2012-01-03T22:06:01 <ThomasWaldmann> you didn't do 2 changesets
191 2012-01-03T22:06:22 <Dragooon> Oh damn
192 2012-01-03T22:06:24 <Dragooon> Sorry, I forgot
193 2012-01-03T22:06:28 <Dragooon> Give me 10 minutes
194 2012-01-03T22:08:27 <ThomasWaldmann> also, set a real name please
195 2012-01-03T22:09:55 <Dragooon> I did not see that coming
196 2012-01-03T22:10:20 *** MattMaker
197 2012-01-03T22:24:33 *** dave_largo
198 2012-01-03T22:29:57 <Dragooon> ThomasWaldmann: Okay done
199 2012-01-03T23:04:40 *** Dragooon_
200 2012-01-03T23:28:00 *** MattMaker
201 2012-01-03T23:29:27 *** yufra
202 2012-01-03T23:30:40 *** yufra
203
