MoinMoin: MoinMoinChat/Logs/moin-dev/2012-01-05

   1 2012-01-05T01:00:08  *** xjjk has joined #moin-dev
   2 2012-01-05T01:45:53  *** qxcv has joined #moin-dev
   3 2012-01-05T01:48:59  *** jek has quit IRC
   4 2012-01-05T01:59:12  *** jek has joined #moin-dev
   5 2012-01-05T02:55:27  *** MattMaker has quit IRC
   6 2012-01-05T02:58:46  *** jek has quit IRC
   7 2012-01-05T02:58:46  *** jek has joined #moin-dev
   8 2012-01-05T03:32:34  *** Dragooon has joined #moin-dev
   9 2012-01-05T03:32:46  <Dragooon> eSyr: there?
  10 2012-01-05T03:34:43  <Dragooon> Anybody?
  11 2012-01-05T08:07:25  <Dragooon> eSyr: there?
  12 2012-01-05T09:26:24  <dreimark> moin
  13 2012-01-05T09:26:31  <dreimark> https://bitbucket.org/Dragooon/moin-2.0/changeset/057a7872cf64#chg_MoinMoin/items/_tests/test_Item.py_newline487
  14 2012-01-05T09:26:38  <dreimark> is a extremly long line
  15 2012-01-05T09:28:43  <dreimark> do you have a wiki page created where you have described TODO ?
  16 2012-01-05T09:29:03  <Dragooon> Me?
  17 2012-01-05T09:29:16  <dreimark> isn't that your task ? http://www.google-melange.com/gci/task/view/google/gci2011/7141270
  18 2012-01-05T09:29:18  <Dragooon> I thought Moin had no limit to lines?
  19 2012-01-05T09:29:37  <Dragooon> dreimark: That code isn't related to mine task
  20 2012-01-05T09:29:43  <Dragooon> My repo has code for 2 tasks
  21 2012-01-05T09:29:53  <Dragooon> That code is for a previous bug-fix
  22 2012-01-05T09:30:33  <dreimark> then someone should have told that you earlier. python is nice to read if noone has to scroll right to a few hundred chars
  23 2012-01-05T09:31:00  <dreimark> try to be close to 80 you can have a little more if it makes sense
  24 2012-01-05T09:31:11  <Dragooon> I'll commit a change in a few
  25 2012-01-05T09:31:18  <Dragooon> Till then, can you please review my atom feed?
  26 2012-01-05T09:31:29  <dreimark> cr url please
  27 2012-01-05T09:32:01  <Dragooon> http://codereview.appspot.com/5489133/
  28 2012-01-05T09:32:19  <Dragooon> Most of it was already reviewed and then I committed to repo
  29 2012-01-05T09:32:20  <dreimark> and the wiki page please
  30 2012-01-05T09:32:48  <dreimark> about the todos
  31 2012-01-05T09:32:57  <Dragooon> Let me find
  32 2012-01-05T09:33:06  <Dragooon> http://moinmo.in/EasyToDo/improve%20the%20atom%20feed
  33 2012-01-05T09:33:09  <Dragooon> dreimark: ^
  34 2012-01-05T09:33:33  <dreimark> Dragooon: read ToDo
  35 2012-01-05T09:33:45  <Dragooon> I've done that
  36 2012-01-05T09:33:47  <dreimark> i want your comments
  37 2012-01-05T09:33:51  <dreimark> in a page
  38 2012-01-05T09:34:02  <Dragooon> It's on the task page(melange)
  39 2012-01-05T09:34:08  <Dragooon> http://www.google-melange.com/gci/task/view/google/gci2011/7141270
  40 2012-01-05T09:34:14  <Dragooon> See my comment
  41 2012-01-05T09:35:06  <dreimark> it is not complete. also it is easier to read in context
  42 2012-01-05T09:35:21  <Dragooon> Complete, as in?
  43 2012-01-05T09:35:29  <dreimark> second item
  44 2012-01-05T09:35:47  <dreimark> third item
  45 2012-01-05T09:36:18  <Dragooon> Comparision with other wikis and how they should be present?
  46 2012-01-05T09:36:33  <dreimark> when show a diff, when show full item?
  47 2012-01-05T09:36:38  <dreimark> html diff or text diff?
  48 2012-01-05T09:36:46  <dreimark> look at the feeds of other wikis - how do they present changes to the feed user?
  49 2012-01-05T09:36:47  <Dragooon> I already said html diff
  50 2012-01-05T09:36:53  <Dragooon> Okay, let me reply
  51 2012-01-05T09:36:59  <dreimark> on the page please
  52 2012-01-05T09:37:21  <dreimark> we have no idea how long the melange site exists - hopefully long
  53 2012-01-05T09:37:33  <dreimark> but we took part since 2007 and old data is gone
  54 2012-01-05T09:37:52  <Dragooon> Give me a minute
  55 2012-01-05T09:38:34  <dreimark> add also a screenshots before/after
  56 2012-01-05T09:39:02  <Dragooon> I can't do that, I'm on my phone
  57 2012-01-05T09:40:04  <dreimark> ok, that later
  58 2012-01-05T09:40:20  <Dragooon> In the meanwhile, can you review the code itself?
  59 2012-01-05T09:40:26  <Dragooon> I believe you've done most of that before
  60 2012-01-05T09:42:14  <dreimark> if that would be 1.9 it would be the correct way to improve it.
  61 2012-01-05T09:42:43  <Dragooon> What about 2.0?
  62 2012-01-05T09:43:09  <dreimark> look into the converter dir. diff_html should become one too
  63 2012-01-05T09:43:31  <dreimark> an _out convetor
  64 2012-01-05T09:43:46  <Dragooon> Yeah but that was beyond the scope of the task
  65 2012-01-05T09:44:43  <dreimark> who told that?
  66 2012-01-05T09:46:02  <Dragooon> The task was to improve the atom feed itself
  67 2012-01-05T09:46:04  <Dragooon> So I took that
  68 2012-01-05T09:46:38  <dreimark> ok
  69 2012-01-05T09:48:20  <Dragooon> I've added my discussion
  70 2012-01-05T09:51:30  <Dragooon> Sorry if I'm coming off as aggressive, I'm not feeling well today
  71 2012-01-05T09:52:05  <dreimark> you don't. get well soon ;)
  72 2012-01-05T09:56:28  <dreimark> Dragooon: i did a short review. i have not much time currently.
  73 2012-01-05T09:56:50  <Dragooon> Anything wrong?
  74 2012-01-05T09:56:53  <dreimark> ThomasWaldmann: eSyr we need to discuss the task
  75 2012-01-05T09:57:03  <dreimark> Dragooon: yes html in py sources
  76 2012-01-05T09:57:26  <Dragooon> That's not my code
  77 2012-01-05T09:57:54  <dreimark> but it is your task to improve it
  78 2012-01-05T09:59:05  <dreimark> that is also the "problem" diff_html needs to become a convertor. if the current code becomes improved and don't be refactored completly this work have to be done twice
  79 2012-01-05T09:59:28  <dreimark> we have to discuss this later
  80 2012-01-05T09:59:30  <Dragooon> I'm not sure how converter works, can anyone explain me?
  81 2012-01-05T09:59:46  <Dragooon> Around when will you be on?
  82 2012-01-05T10:00:40  <dreimark> waldi: can you give a helping hand ^
  83 2012-01-05T10:01:09  <dreimark> Dragooon: in principle internal moin has now an own domtree
  84 2012-01-05T10:01:12  <Dragooon> I don't see why diff_html needs to be a converter?
  85 2012-01-05T10:01:31  <Dragooon> It is not a doctype that can be created for a page
  86 2012-01-05T10:02:30  <dreimark> it can then be used on an other item
  87 2012-01-05T10:03:03  <Dragooon> How?
  88 2012-01-05T10:03:09  <Dragooon> binaries can't be diffed easily
  89 2012-01-05T10:03:14  <dreimark> images can
  90 2012-01-05T10:03:29  <Dragooon> Other items already have their own diff functions which handle this
  91 2012-01-05T10:04:34  <Dragooon> I'm also running late, perhaps we can discuss this later
  92 2012-01-05T10:05:45  *** Dragooon is now known as Dragooon|Away
  93 2012-01-05T10:44:58  *** greg_f has joined #moin-dev
  94 2012-01-05T11:17:01  *** Dragooon|Away has quit IRC
  95 2012-01-05T11:17:11  *** Dragooon has joined #moin-dev
  96 2012-01-05T13:05:38  <xorAxAx> bitbucket nfs died :-(
  97 2012-01-05T13:11:03  <ThomasWaldmann> network failure system
  98 2012-01-05T13:19:49  <Dragooon> need for speed?
  99 2012-01-05T13:20:42  <Dragooon> ThomasWaldmann: Can you have a look at dreimark's comments on my task?
 100 2012-01-05T13:27:59  <ThomasWaldmann> the task is about improving the atom feed code and how it looks to a user of it
 101 2012-01-05T13:28:25  <ThomasWaldmann> not about writing a converter or rewriting diff_html with templates
 102 2012-01-05T13:29:42  <ThomasWaldmann> btw, did you work on making the diff methods work in the same way?
 103 2012-01-05T13:30:27  <Dragooon> As in return same data type?
 104 2012-01-05T13:30:42  <ThomasWaldmann> yes
 105 2012-01-05T13:30:50  <Dragooon> Yeah, did that
 106 2012-01-05T13:32:01  <ThomasWaldmann> ok, I'll have a look as soon as bitbucket is back online again. in case that takes longer than few hours, i suggest you use hg export and submit patches to melange. or codereview.
 107 2012-01-05T13:32:38  <Dragooon> I'll wait for an hour
 108 2012-01-05T14:02:35  *** brunomartin has joined #moin-dev
 109 2012-01-05T14:02:50  *** dave_largo has joined #moin-dev
 110 2012-01-05T14:38:09  *** Dragooon has quit IRC
 111 2012-01-05T14:38:15  *** Dragooon has joined #moin-dev
 112 2012-01-05T14:46:46  *** qxcv has quit IRC
 113 2012-01-05T16:23:20  <Dragooon> ThomasWaldmann: http://codereview.appspot.com/5489133/ Since bitbucket is down
 114 2012-01-05T17:04:11  *** RogerHaase has joined #moin-dev
 115 2012-01-05T17:06:27  <RogerHaase> http://test.moinmo.in/Home yields Internal Server Error: other pages work OK
 116 2012-01-05T17:10:36  <ThomasWaldmann> Dragooon: you shouldn't mix typo fixing / whitespace cleanup (== cosmetic stuff) with functional changes, so i suggest you split that into 2 changesets
 117 2012-01-05T17:11:39  *** bilal has quit IRC
 118 2012-01-05T17:15:57  <Dragooon> ThomasWaldmann: Okay, I'll do that. Can you review it?
 119 2012-01-05T17:23:09  <Dragooon> Wait, I've already committed that into the repository
 120 2012-01-05T17:23:37  *** greg_f has quit IRC
 121 2012-01-05T17:24:53  <ThomasWaldmann> Dragooon: you should run all code you modified
 122 2012-01-05T17:25:02  <Dragooon> I have
 123 2012-01-05T17:25:06  <ThomasWaldmann> e.g. you inserted Markup() into a template - does that work?
 124 2012-01-05T17:25:14  <Dragooon> Yea
 125 2012-01-05T17:25:30  <Dragooon> No wait
 126 2012-01-05T17:26:10  <ThomasWaldmann> I am not sure that this is the right way for a template btw
 127 2012-01-05T17:26:42  <ThomasWaldmann> maybe read the jinja2 docs about escaping
 128 2012-01-05T17:27:28  <Dragooon> Or perhaps diff should be rendered before and then passed?
 129 2012-01-05T17:30:02  <ThomasWaldmann> review done
 130 2012-01-05T17:52:25  <Dragooon> ThomasWaldmann: Uploaded another patch
 131 2012-01-05T17:52:30  <Dragooon> Works fine now
 132 2012-01-05T17:54:57  <ThomasWaldmann> ok
 133 2012-01-05T18:17:31  <izibi> bitbucket is back
 134 2012-01-05T18:44:36  <ThomasWaldmann> Dragooon: can you update bb with changesets as discussed?
 135 2012-01-05T18:48:13  <Dragooon> ThomasWaldmann: Done
 136 2012-01-05T18:55:28  * ThomasWaldmann has to leave soon, but will be back later
 137 2012-01-05T18:56:43  <Dragooon> okay, I need to sleep too
 138 2012-01-05T19:00:26  *** Dragooon has quit IRC
 139 2012-01-05T19:19:47  *** dave_largo has quit IRC
 140 2012-01-05T19:20:09  *** dave_largo has joined #moin-dev
 141 2012-01-05T21:31:39  <ThomasWaldmann> re
 142 2012-01-05T21:32:19  *** brunomartin has quit IRC
 143 2012-01-05T22:29:01  *** dave_largo has quit IRC
 144 2012-01-05T22:29:14  <dreimark> re