MoinMoin: MoinMoinChat/Logs/moin-dev/2012-02-20

   1 2012-02-20T00:34:21  *** jek has quit IRC
   2 2012-02-20T00:43:38  *** rdljek has joined #moin-dev
   3 2012-02-20T00:50:20  *** rdljek has quit IRC
   4 2012-02-20T01:02:28  *** rdljek has joined #moin-dev
   5 2012-02-20T01:14:03  *** rdljek is now known as jek
   6 2012-02-20T01:14:03  *** jek has joined #moin-dev
   7 2012-02-20T03:58:16  *** sudo_dirk has quit IRC
   8 2012-02-20T06:05:27  *** sudo_dirk has joined #moin-dev
   9 2012-02-20T08:17:08  *** kanha has joined #moin-dev
  10 2012-02-20T08:33:38  <kanha> moin
  11 2012-02-20T08:36:37  <kanha> In user settings bug in what does 'flaskg.user.openid( MoinMoin/apps/frontend/views.py)' represents?
  12 2012-02-20T08:58:10  *** MattMaker has quit IRC
  13 2012-02-20T09:17:01  <ThomasWaldmann> moin
  14 2012-02-20T09:17:51  <ThomasWaldmann> kanha: please clarify your question
  15 2012-02-20T09:23:56  <kanha> at location MoinMoin/apps/frontend/views.py at line no 1351 what does 'flaskg.user.openid' represents?
  16 2012-02-20T09:26:57  <ThomasWaldmann> a openid url
  17 2012-02-20T09:27:10  *** MattMaker has joined #moin-dev
  18 2012-02-20T09:28:10  <kanha> which openid url?clarify it please
  19 2012-02-20T09:29:15  <ThomasWaldmann> a optional openid url of the current user (flaskg.user is the current user object), if set, he can use it to authenticate with openid
  20 2012-02-20T09:30:10  <kanha> and what is the default value for the openid if that is left empty is it a null value?
  21 2012-02-20T09:32:48  <ThomasWaldmann> MoinMoin.config.default usually initializes this to None
  22 2012-02-20T09:33:59  <kanha> user.search_users(openid=form['openid'].value)  returns true when openid entered in the form matches with the openid of any registered user right?but suppose if the user left this empty then it is None and if another user left
  23 2012-02-20T09:34:44  <kanha> it empty then it is also none and hence they both becomes equal
  24 2012-02-20T09:35:50  <ThomasWaldmann> yes, the problem is similar to what you describe
  25 2012-02-20T09:36:00  <kanha> so the test case in line no 1351(MoinMoin/apps/frontend/views.py) will always satisfy
  26 2012-02-20T09:36:02  <ThomasWaldmann> not precisely maybe, but similar
  27 2012-02-20T09:58:24  *** greg_f has joined #moin-dev
  28 2012-02-20T11:35:01  <ThomasWaldmann> http://geekandpoke.typepad.com/geekandpoke/2011/10/ddt.html
  29 2012-02-20T11:35:35  <kanha> In usersetting bug what is t he default value of 'form['openid'].value' if user doesn't enter anything to this block? its location is MoinMoin/apps/frontend/views.py at line no 1351
  30 2012-02-20T11:36:04  <ThomasWaldmann> find out
  31 2012-02-20T11:36:08  <kanha> and where this default value is assingned?
  32 2012-02-20T11:39:35  <kanha> if i make anychange to code do i need to install it again to test it or simply activating virtual env and running moin will serve my purpose?
  33 2012-02-20T11:40:07  <ThomasWaldmann> this is the line that fills the form: form = form_classes[part].from_flat(request.form) (1333)
  34 2012-02-20T11:40:47  <ThomasWaldmann> but i think you maybe should first think about what goal you want to achieve
  35 2012-02-20T11:49:13  <kanha> I made some change to code pasted at http://paste.pocoo.org/show/553873/
  36 2012-02-20T12:09:36  <ThomasWaldmann> i don't think 1357 is effective
  37 2012-02-20T12:12:09  <ThomasWaldmann> (doesn't it update ALL user attributes with the stuff from the form some lines later?)
  38 2012-02-20T12:14:58  <kanha> how?
  39 2012-02-20T12:16:34  <ThomasWaldmann>                         form.update_object(flaskg.user, omit=['submit']) # don't save submit button value :)
  40 2012-02-20T12:34:17  <kanha> k but even then the error msg is coming that 'This openid is already in use' when the openid box is left empty.If default value of openid in form is none if user doesn't enter anytihng then according to my changes as in line1351 it should not enter into the test.
  41 2012-02-20T12:41:15  <ThomasWaldmann> check the value you get
  42 2012-02-20T12:41:46  <kanha> ok
  43 2012-02-20T12:50:54  <kanha> how to check its value?
  44 2012-02-20T12:54:25  *** kanha has quit IRC
  45 2012-02-20T15:56:45  *** RogerHaase has joined #moin-dev
  46 2012-02-20T16:02:52  <RogerHaase> ThomasWaldmann: built-in server has startup problem at moin2 tip:  http://paste.pocoo.org/show/553973/
  47 2012-02-20T18:30:07  *** greg_f has quit IRC
  48 2012-02-20T18:39:07  <ThomasWaldmann> hi RogerHaase
  49 2012-02-20T18:39:46  <ThomasWaldmann> RogerHaase: MoinMoin.storage.middleware.validation do you have that module?
  50 2012-02-20T18:40:59  <ThomasWaldmann> hmm, likely not
  51 2012-02-20T18:41:10  <ThomasWaldmann> yeah, i know how it happened...
  52 2012-02-20T18:42:13  * ThomasWaldmann adds the missing file
  53 2012-02-20T18:44:36  <CIA-41> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1268:95bf68ca8876 2.0/MoinMoin/storage/middleware/ (_tests/test_validation.py validation.py): add missing validation files for cs 1c66f39aa44f
  54 2012-02-20T18:54:39  <ThomasWaldmann> RogerHaase: ^^
  55 2012-02-20T18:55:23  <RogerHaase> ThomasWaldmann: Thanks, working now :)
  56 2012-02-20T18:55:57  * ThomasWaldmann had those files added, but then reverted, pulled other stuff, reapplied patch (so the files were there, but I forgot to hg add them again)
  57 2012-02-20T21:55:15  <ThomasWaldmann> anyone want to try out 1.9.4 rc?
  58 2012-02-20T22:58:41  <dreimark> ThomasWaldmann: yes, something changed?
  59 2012-02-20T23:29:09  *** RogerHaase has left #moin-dev
  60