MoinMoin: MoinMoinChat/Logs/moin-dev/2012-03-02

   1 2012-03-02T00:44:49  *** brunomartin has left #moin-dev
   2 2012-03-02T01:18:07  *** MattMaker has joined #moin-dev
   3 2012-03-02T01:30:16  *** raignarok has quit IRC
   4 2012-03-02T03:54:43  *** sudo_dirk has quit IRC
   5 2012-03-02T03:56:56  *** yufra has joined #moin-dev
   6 2012-03-02T04:10:47  *** MattMaker has quit IRC
   7 2012-03-02T04:51:02  *** MattMaker has joined #moin-dev
   8 2012-03-02T04:52:08  *** yufra has quit IRC
   9 2012-03-02T06:01:02  *** sudo_dirk has joined #moin-dev
  10 2012-03-02T07:30:09  *** Trip_ has joined #moin-dev
  11 2012-03-02T07:31:04  *** Trip_ has joined #moin-dev
  12 2012-03-02T07:31:26  *** MattMaker has quit IRC
  13 2012-03-02T08:33:29  <dreimark> moin
  14 2012-03-02T09:48:53  *** raignarok has joined #moin-dev
  15 2012-03-02T09:52:46  *** raignarok has quit IRC
  16 2012-03-02T10:02:16  *** raignarok has joined #moin-dev
  17 2012-03-02T10:38:52  *** greg_f has joined #moin-dev
  18 2012-03-02T11:03:39  *** Trip_ has quit IRC
  19 2012-03-02T11:15:02  *** raignarok has quit IRC
  20 2012-03-02T11:19:33  *** raignarok has joined #moin-dev
  21 2012-03-02T11:43:01  *** MattMaker has joined #moin-dev
  22 2012-03-02T13:02:35  <ThomasWaldmann> moin
  23 2012-03-02T14:01:32  *** kanha has joined #moin-dev
  24 2012-03-02T14:09:41  *** dave_largo has joined #moin-dev
  25 2012-03-02T14:39:58  <kanha> I have tried to fix the usersetting bug and have uploaded the patch for review at http://codereview.appspot.com/5723046
  26 2012-03-02T14:42:10  <ThomasWaldmann> review done :)
  27 2012-03-02T14:43:57  <kanha> quite fast
  28 2012-03-02T14:44:40  <ThomasWaldmann> btw, did you successfully reproduce the bug at the beginning (== make it fail)?
  29 2012-03-02T14:46:04  <kanha> it starts with more than 1 account not for the first account
  30 2012-03-02T14:46:33  <ThomasWaldmann> ok, so you made if fail
  31 2012-03-02T14:46:38  <ThomasWaldmann> it*
  32 2012-03-02T14:46:54  <kanha> yes
  33 2012-03-02T14:46:54  <ThomasWaldmann> then you fixed the bug and it does not fail any more?
  34 2012-03-02T14:47:04  <kanha> yes
  35 2012-03-02T14:47:24  <ThomasWaldmann> ok, sounds good. try the stuff i suggested on codereview.
  36 2012-03-02T14:47:42  <ThomasWaldmann> then upload again and give the same id as it has now
  37 2012-03-02T14:47:42  <kanha> ok and thanks :)
  38 2012-03-02T14:48:12  <kanha> how to give same id?
  39 2012-03-02T14:48:22  <ThomasWaldmann> python upload.py --help :)
  40 2012-03-02T14:48:30  <kanha> ok
  41 2012-03-02T14:48:32  <ThomasWaldmann> (or so)
  42 2012-03-02T14:48:46  <ThomasWaldmann> you know what short-circuit evaluation means?
  43 2012-03-02T14:48:50  <kanha> (or so)?
  44 2012-03-02T14:49:11  <ThomasWaldmann> (or similar)
  45 2012-03-02T14:49:15  <kanha> no i dont?can you tell please?
  46 2012-03-02T14:49:28  <kanha> ?*
  47 2012-03-02T14:49:43  <kanha> .*
  48 2012-03-02T14:49:44  <ThomasWaldmann> if python evaluates "A and B", it first looks at A
  49 2012-03-02T14:50:05  <kanha> yes then
  50 2012-03-02T14:50:14  <ThomasWaldmann> if A evaluates to False, the total expression can not get True any more, so it does not evaluate B.
  51 2012-03-02T14:50:48  <kanha> yes i know so you want me to implement that stuff right?
  52 2012-03-02T14:51:10  <ThomasWaldmann> what i suggested on CR uses that
  53 2012-03-02T14:51:43  <kanha> I will do it
  54 2012-03-02T15:01:22  <kanha> done :)
  55 2012-03-02T15:02:40  <ThomasWaldmann> you see the "delta from patch set 1" link?
  56 2012-03-02T15:04:23  <kanha> no.where?
  57 2012-03-02T15:05:21  <dreimark> http://codereview.appspot.com/5723046
  58 2012-03-02T15:07:46  <kanha> delta?
  59 2012-03-02T15:08:14  <dreimark> well search on the page for that word ctrl+F in ff
  60 2012-03-02T15:08:28  <dreimark> "Delta from patch set"
  61 2012-03-02T15:08:40  <dreimark> the link is in the next line
  62 2012-03-02T15:10:24  <dreimark> me wonders a bit about the order after the first and in that long if now
  63 2012-03-02T15:11:06  * dreimark can't login currently to cr. 
  64 2012-03-02T15:12:09  <kanha> but its not present in my code on my sytem.
  65 2012-03-02T15:12:09  <dreimark> i think i would call if form['openid'].value and user.search_users(openid=form['openid'].value) and ...
  66 2012-03-02T15:12:59  <dreimark> kanha: yes because it is a feature of cr
  67 2012-03-02T15:13:11  <dreimark> this helps in reading diffs a lot
  68 2012-03-02T15:14:36  <kanha> then how can i correct it when its not at my machine code?
  69 2012-03-02T15:15:42  <dreimark> hg diff, tells the changes you have done
  70 2012-03-02T15:16:33  <dreimark> you should see the indenting failure
  71 2012-03-02T15:17:52  <kanha> got it
  72 2012-03-02T15:23:08  *** raignarok has quit IRC
  73 2012-03-02T15:24:23  <kanha> done
  74 2012-03-02T15:27:53  <ThomasWaldmann> you didn't fix all I suggested
  75 2012-03-02T15:28:16  <ThomasWaldmann> and you didn't run the tests :)
  76 2012-03-02T15:29:24  <kanha> is it not working?
  77 2012-03-02T15:32:38  <kanha> lab closing time will do tommorrow
  78 2012-03-02T15:32:51  <kanha> bye :)
  79 2012-03-02T15:32:56  *** kanha has left #moin-dev
  80 2012-03-02T17:11:33  *** yufra has joined #moin-dev
  81 2012-03-02T17:30:20  *** raignarok has joined #moin-dev
  82 2012-03-02T18:14:58  *** yufra has quit IRC
  83 2012-03-02T18:36:27  *** greg_f has quit IRC
  84 2012-03-02T19:57:31  *** raignarok has quit IRC
  85 2012-03-02T19:57:41  *** raignarok has joined #moin-dev
  86 2012-03-02T20:15:09  *** raignarok has quit IRC
  87 2012-03-02T20:15:17  *** raignarok has joined #moin-dev
  88 2012-03-02T20:19:38  *** raignarok has quit IRC
  89 2012-03-02T22:01:43  *** raignarok has joined #moin-dev
  90 2012-03-02T22:17:32  *** dave_largo has quit IRC
  91 2012-03-02T23:08:43  *** yufra has joined #moin-dev
  92 2012-03-02T23:09:08  *** raignarok has quit IRC
  93