1 2012-07-11T00:16:09 *** grzywacz
2 2012-07-11T00:22:12 *** spy
3 2012-07-11T01:31:11 *** jaiditya
4 2012-07-11T01:31:29 *** jaiditya
5 2012-07-11T02:02:44 *** RogerHaase
6 2012-07-11T02:35:11 *** MattMaker
7 2012-07-11T03:07:36 *** dwcramer
8 2012-07-11T03:13:59 *** dwcramer
9 2012-07-11T03:27:23 *** dwcramer
10 2012-07-11T04:03:25 *** jaiditya
11 2012-07-11T05:08:50 *** dwcramer
12 2012-07-11T07:48:08 *** josep2
13 2012-07-11T07:59:22 *** xiaq
14 2012-07-11T08:34:24 <MaikuMori> Is there an easy way to enable DEBUG logging level?
15 2012-07-11T08:55:31 <dreimark> MaikuMori: yes, see http://hg.moinmo.in/moin/2.0/file/2a59cb0f0755/MoinMoin/log.py
16 2012-07-11T08:56:12 <MaikuMori> I ended up changing the value in fallback config
17 2012-07-11T08:56:21 <MaikuMori> while I'm debugging
18 2012-07-11T08:56:45 <MaikuMori> But it should be automatic so that if you have DEBUG=True in config it default to DEBUG logging level.
19 2012-07-11T08:56:55 <MaikuMori> defaults*
20 2012-07-11T09:00:18 <dreimark> MaikuMori: create your own logging config file, examples are in 1.9 http://hg.moinmo.in/moin/1.9/file/aba21f8db240/wiki/config/logging
21 2012-07-11T09:00:29 <dreimark> then use the env var to point to it
22 2012-07-11T09:03:09 <MaikuMori> It works in longterm, but to quicky check few debug statements, it's a lot hassle. Thanks though, I'll probably make one later, but for now I got what I wanted by changing fallback config for 10mins.
23 2012-07-11T09:10:32 <dreimark> don't commit it ;)
24 2012-07-11T09:16:05 <MaikuMori> Yeah.
25 2012-07-11T09:16:13 <MaikuMori> ThomasWaldmann: dreimark: http://codereview.appspot.com/6343095/
26 2012-07-11T09:16:25 <MaikuMori> Fix for #184 and user login problems.
27 2012-07-11T09:17:37 <MaikuMori> Seems like the main problem was that session key expired before session cookie did which caused endless loop when you try to logging and the system resets you back because it can't validate the token.
28 2012-07-11T09:18:52 <MaikuMori> But could use a bit more testing since I destroyed my bugged session while I was fixing the bug.
29 2012-07-11T09:19:06 <ThomasWaldmann> oh? hmm, somehow i thought this worked until recently, but i can't remember changing anything related to this.
30 2012-07-11T09:26:12 <MaikuMori> Yeah it worked when I submited the code before as well
31 2012-07-11T09:27:00 <MaikuMori> From what I understand, the session key/token pair generated when user is created and used logs in expired recently which made this bug appear.
32 2012-07-11T09:27:12 *** spy
33 2012-07-11T09:27:18 <MaikuMori> Thougth it should have expired after 1 day, not 1month according to the code.
34 2012-07-11T09:27:44 <MaikuMori> Maybe someone with that bug active can pull in my changes and test it.
35 2012-07-11T09:28:12 <MaikuMori> used = user*
36 2012-07-11T09:30:13 <MaikuMori> But I could be wrong, I can't say I 100% understand the multi stage login process (the order of function calls), I might have missed something, but for now it works on my local repo.
37 2012-07-11T09:49:42 <ThomasWaldmann> MaikuMori: review done
38 2012-07-11T09:56:22 <ThomasWaldmann> spy: hehe, you sneaked around the issue that tags is a list. tags and ACL could be a bit wider. http://box.psviderski.name/share/moin2/moin-meta-form-base.png
39 2012-07-11T09:57:58 <ThomasWaldmann> spy: and of course we'll need that date/time widget, not having to enter a unix timestamp for ptime http://box.psviderski.name/share/moin2/moin-meta-form-blog-entry.png
40 2012-07-11T10:01:15 <ThomasWaldmann> ah, you addressed that already
41 2012-07-11T10:04:30 <MaikuMori> ThomasWaldmann: I managed to break it again and now changed so it's more along the lines how it was before (not using del self.profile[XXX]) should I keep the __delitem__ method I wrote?
42 2012-07-11T10:05:15 <MaikuMori> Tested with 2 logins, logging out 1 and having the other log out autmatically. Also tested with password change where it invalidates all other session except the one which initiated the change.
43 2012-07-11T10:05:22 <MaikuMori> All seem to work.
44 2012-07-11T10:10:12 <MaikuMori> ThomasWaldmann: Also works when new user is created. Updated corereview: http://codereview.appspot.com/6343095/
45 2012-07-11T10:12:45 <ThomasWaldmann> yes, keep it, but maybe separate commit, so one sees it is only for completeness rather than fixing an issue
46 2012-07-11T10:13:06 <MaikuMori> Alright.
47 2012-07-11T10:13:26 <MaikuMori> Now the problem is that the current changes are based off the latest theme implementation
48 2012-07-11T10:13:57 <MaikuMori> How should I handle that? Should I branch and base these changes on the latest main repo?
49 2012-07-11T10:15:46 <MaikuMori> Also regarding latest themes implementation, have you had chance to look at it? I'm quite sure I can do storages next and then maybe something harder like macros/widgets (still need to learn about them)
50 2012-07-11T10:15:57 <ThomasWaldmann> MaikuMori: yes, i think that would be useful
51 2012-07-11T10:17:42 <ThomasWaldmann> were theme plugins already reviewed?
52 2012-07-11T10:17:59 <MaikuMori> Nope, not the last changes where I fixed quite a lot issues.
53 2012-07-11T10:18:22 <MaikuMori> ThomasWaldmann: http://codereview.appspot.com/6344080/
54 2012-07-11T10:21:04 <MaikuMori> ThomasWaldmann: Regarding "that would be useful" is that about making new branch for this issue for merge or the plugin system plan.
55 2012-07-11T10:21:13 <ThomasWaldmann> btw, reviewed the previous one again. one little fix (already mentioned) and it should be ok.
56 2012-07-11T10:22:02 <MaikuMori> ThomasWaldmann: the crypto change? Already done.
57 2012-07-11T10:22:20 <ThomasWaldmann> MaikuMori: just clone main repo, apply fix and send me either a pull request or an exported changeset
58 2012-07-11T10:22:50 <ThomasWaldmann> the timeout data type issue
59 2012-07-11T10:24:57 <MaikuMori> ThomasWaldmann: as in new fork?
60 2012-07-11T10:39:20 <MaikuMori> ThomasWaldmann: Done.
61 2012-07-11T10:39:28 <MaikuMori> https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/46/fix-for-bug-184-and-related-user-login
62 2012-07-11T10:44:48 <ThomasWaldmann> MaikuMori: you didn't reply/react to all comments from previous review, so i added pointers again now
63 2012-07-11T10:48:55 <MaikuMori> ThomasWaldmann: as for why if you look at the init method above
64 2012-07-11T10:49:04 <MaikuMori> there can be edge case when they are not set
65 2012-07-11T10:49:15 <MaikuMori> which caused error before
66 2012-07-11T10:50:20 <MaikuMori> The reason why it got in that state before I'm not quite sure because it should have just been None
67 2012-07-11T10:50:39 <spy> ThomasWaldmann: Please give some comments on http://box.psviderski.name/share/moin2/moin-meta-form-ptime.png http://box.psviderski.name/share/moin2/moin-meta-form-base.png. I want to be sure whether I should continue working on metadata in that direction.
68 2012-07-11T10:52:08 <MaikuMori> As far all_browsers vs all/everywhere, I can ammend the last commit and change that if needed.
69 2012-07-11T11:13:05 <spy> ThomasWaldmann: what types could be for tags? any example to understand that it could be wider than just list?
70 2012-07-11T12:34:51 * ThomasWaldmann was busy otherwise, sorry
71 2012-07-11T12:36:58 <MaikuMori> ThomasWaldmann: Sorry about that, I somehow keep missing something all the time. Tried to fix/reply to all of the comments now: http://codereview.appspot.com/6344080/
72 2012-07-11T12:45:24 * ThomasWaldmann runs tests
73 2012-07-11T12:46:56 <spy> ThomasWaldmann: You pointed me on http://hg.moinmo.in/moin/2.0/rev/a9cd6f2bbc94#l1.53 How should I fill tags field to get multiple values in lookup_form[TAGS] ?
74 2012-07-11T12:47:11 <ThomasWaldmann> spy: it is not "Title for a blog entry", but "Title for (this) blog entry" or just "Title" (as it is all about a blog entry)
75 2012-07-11T12:47:25 <ThomasWaldmann> the first one sounds too unspecific
76 2012-07-11T12:47:43 <spy> ThomasWaldmann: agree
77 2012-07-11T12:48:04 <ThomasWaldmann> and i am not uptodate with that "view-method" stuff currently
78 2012-07-11T12:49:28 <ThomasWaldmann> the "modify" form does not talk about title, just about summary
79 2012-07-11T12:50:12 <spy> ThomasWaldmann: there were not updates for a long time
80 2012-07-11T12:50:17 <ThomasWaldmann> ACL placeholder could be "Access Control List (optional)" or so
81 2012-07-11T12:50:43 <ThomasWaldmann> and as i said already, make both wider form fields
82 2012-07-11T12:52:01 <ThomasWaldmann> as a general comment about metadata editing (for all student dealing with it): that "comment" entry field we have for all sorts of items is nothing else than metadata.
83 2012-07-11T12:52:11 <spy> wider in what sense?
84 2012-07-11T12:52:31 <ThomasWaldmann> spy: MaikuMori: (and dasich, who is absent way too often): ^^
85 2012-07-11T12:52:38 <ThomasWaldmann> more width for the input field
86 2012-07-11T12:54:09 <ThomasWaldmann> spy: and about the tags: they are a list of strings. you can keep it as a comma separated list for now and first work on more important things, but in the end, it likely should be a list of string-input fields
87 2012-07-11T12:55:41 <ThomasWaldmann> (we need that at a lot of places, so there should be a list-of-fields widget with some "+"-button and some "X"-buttons plus some javascript magic)
88 2012-07-11T12:56:56 <spy> ThomasWaldmann: hah, just wanted to write the same :)
89 2012-07-11T13:00:38 <spy> as I correctly understood, flatland's MultiValue 'tags' could be assigned only when we we have a list in the form with fields names like tags_0, tags_1, ...
90 2012-07-11T13:03:26 <ThomasWaldmann> as i said, maybe now work on more important stuff. and whoever wants to work on that list widget please talk to me BEFORE, i have already done something in that area.
91 2012-07-11T13:04:08 <spy> ThomasWaldmann: these all about the appearance of forms, but what about the code design. I divided ModifyForm on two separate Data and Meta forms.
92 2012-07-11T13:05:35 <ThomasWaldmann> MaikuMori: there are 3 failing tests (and i think it used to be 1 "302 == 200" fail before your change only)
93 2012-07-11T13:05:51 * ThomasWaldmann referring to that pull request
94 2012-07-11T13:05:54 <spy> and then created modify_form_factory, that choose an appropriate modify meta form for the item and build ModifyForm(data_form, meta_form)
95 2012-07-11T13:06:51 <ThomasWaldmann> spy: i have still to look at your code, CR tab already open in firefox
96 2012-07-11T13:07:08 <spy> ThomasWaldmann: good
97 2012-07-11T13:09:36 <ThomasWaldmann> MaikuMori: rejected it because of that for now, but it should be easy to fix (you are not obliged to fix that 200 == 302 thing, that was introduced while sprinting iirc)
98 2012-07-11T13:58:48 <MaikuMori> I'm not sure what makes it to fail
99 2012-07-11T13:59:08 <MaikuMori> It doesn't break in browser
100 2012-07-11T14:37:50 *** dave_largo
101 2012-07-11T14:43:58 <spy> ThomasWaldmann: why there was created 'comment' as a separate kw item._save(meta, data, comment=comment) ? Should it be inside the meta dict?
102 2012-07-11T14:55:19 *** dwcramer
103 2012-07-11T15:05:06 <ThomasWaldmann> in old moin, it was one of the few "metadata" items
104 2012-07-11T15:05:15 <ThomasWaldmann> long term, we should remove that specialisation
105 2012-07-11T15:12:43 <ThomasWaldmann> spy: done
106 2012-07-11T15:13:32 <spy> ThomasWaldmann: thank you!
107 2012-07-11T15:13:41 * spy looks at CR
108 2012-07-11T15:27:43 *** dwcramer
109 2012-07-11T15:32:04 <ThomasWaldmann> MaikuMori: review done
110 2012-07-11T15:34:58 * ThomasWaldmann away
111 2012-07-11T15:58:01 *** yufra_
112 2012-07-11T15:59:09 *** yufra
113 2012-07-11T16:07:00 *** spy_
114 2012-07-11T16:26:09 *** dwcramer
115 2012-07-11T16:40:09 *** RogerHaase
116 2012-07-11T16:41:35 *** spy_
117 2012-07-11T17:58:05 *** dave_largo
118 2012-07-11T19:49:06 *** josep2
119 2012-07-11T20:01:29 *** dwcramer
120 2012-07-11T20:03:17 *** josep2
121 2012-07-11T20:03:25 *** josep2
122 2012-07-11T21:08:23 *** technossomy_
123 2012-07-11T21:10:17 *** dwcramer
124 2012-07-11T22:04:24 *** dwcramer
125 2012-07-11T22:12:11 *** technossomy_
126 2012-07-11T22:19:02 *** dwcramer
127 2012-07-11T22:53:25 *** dwcramer
128 2012-07-11T23:06:32 *** spy
129 2012-07-11T23:25:44 *** MattMaker
130 2012-07-11T23:28:16 <ThomasWaldmann> esyr: eSyr-ng: see inbox
