1 2012-07-15T00:00:25 <ThomasWaldmann> i suggested to jaiditya to move the actions below the comment, but he preferred to kill the right sidepanel
2 2012-07-15T00:01:43 <ThomasWaldmann> using icons can solve the width issue, but we get some other issues instead: needing new icons for different themes (not ever, but sometimes), needing scalable icons or different sizes, ...
3 2012-07-15T00:03:00 <RogerHaase> Yes, not sure what a meta icon would look like
4 2012-07-15T00:03:11 <ThomasWaldmann> RogerHaase: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/203/pytest-fails-on-windows-need-newer-or just close it?
5 2012-07-15T00:03:23 <ThomasWaldmann> if one installs the stuff right now, one gets pep8 1.3.3
6 2012-07-15T00:05:40 <RogerHaase> I will do a quickinstall and cloe it if it is fixed.
7 2012-07-15T00:05:47 <RogerHaase> cloe/close
8 2012-07-15T00:16:56 <RogerHaase> ThomasWaldmann: quickinstall did not upgrade pep8, should I be doing something other than quickinstall.bat? http://dpaste.com/770766/
9 2012-07-15T00:27:08 <ThomasWaldmann> i just did pip uninstall pep8 ; pip install pep8
10 2012-07-15T00:31:08 <RogerHaase> thanks, that worked. will close the issue later... gtg
11 2012-07-15T00:31:15 *** RogerHaase
12 2012-07-15T01:12:37 *** spy
13 2012-07-15T05:03:55 *** dcramer_
14 2012-07-15T05:16:30 *** dcramer_
15 2012-07-15T09:17:04 <dreimark> ThomasWaldmann: instead of icons we can use there the unicode chars because no need of colorful icons
16 2012-07-15T09:19:31 <dreimark> http://fortawesome.github.com/Font-Awesome/
17 2012-07-15T10:13:29 *** josep2
18 2012-07-15T10:24:52 *** josep2
19 2012-07-15T14:10:46 *** spy
20 2012-07-15T14:12:16 <ThomasWaldmann> https://codereview.appspot.com/6243064/ < markdown markup converter for moin2
21 2012-07-15T15:10:23 *** dcramer_
22 2012-07-15T15:25:15 *** dcramer_
23 2012-07-15T15:44:37 *** dcramer_
24 2012-07-15T16:10:54 *** RogerHaase
25 2012-07-15T16:22:24 * dreimark had added some issues
26 2012-07-15T16:22:29 <dreimark> bbl
27 2012-07-15T16:33:23 *** dcramer_
28 2012-07-15T16:46:23 *** jaiditya
29 2012-07-15T16:48:11 *** dcramer_
30 2012-07-15T16:59:48 *** dcramer_
31 2012-07-15T17:02:44 <ThomasWaldmann> RogerHaase: iirc we still have no good solution for js i18n
32 2012-07-15T17:03:45 <ThomasWaldmann> the current approach of defining some variables in the template and using them from the js feels a bit hackish
33 2012-07-15T17:05:33 <jaiditya> ThomasWaldmann: xiaq made changes in forms and accordingly only modified default templates not the theme templates due to which many of pages are crashing
34 2012-07-15T17:05:36 <ThomasWaldmann> so i looked at babel.js, which supplies some gettext-like calls for js. but making the translations available to the js isn't really solved by it
35 2012-07-15T17:06:10 <jaiditya> so I'm currently making changes in foobar theme templates
36 2012-07-15T17:06:40 <ThomasWaldmann> jaiditya: yeah, i am aware that this is due to xiaq's changes, that's why i was suggesting you talk to him
37 2012-07-15T17:06:55 <ThomasWaldmann> (if you have questions)
38 2012-07-15T17:08:08 <ThomasWaldmann> RogerHaase: so, my second idea was to maybe just use jinja2 templating also for some *.js that needs i18n
39 2012-07-15T17:10:07 <RogerHaase> ThomasWaldmann: Being english-only speaker, I know little about i18n. But I did google and found the solutions more complex than the hack, and therefore of little advantage.
40 2012-07-15T17:16:53 <RogerHaase> So for jinja2 we just put phrases into a template? How would that change config/default.py, line 369?
41 2012-07-15T17:16:58 <RogerHaase> ('special.comments', L_('Comments'), L_('Show comments|Hide comments'), True, ),
42 2012-07-15T17:18:09 <ThomasWaldmann> babel can extract strings from js (and from jinja2 templates), so the original english string would be there
43 2012-07-15T17:18:27 <ThomasWaldmann> like _("dog") or gettext("dog")
44 2012-07-15T17:19:35 <ThomasWaldmann> the template would be mostly the same as the js file, except the places that need jinja2 to deal with the translations
45 2012-07-15T17:20:33 <ThomasWaldmann> there it would have {{ gettext("dog") }} instead of dog
46 2012-07-15T17:21:16 <ThomasWaldmann> does js use {{ }} for something?
47 2012-07-15T17:21:48 <RogerHaase> oh, jinja2 would render the *.js file?
48 2012-07-15T17:22:00 <ThomasWaldmann> yes, that was my idea
49 2012-07-15T17:22:49 <ThomasWaldmann> first access would be a bit slower, but due to client-side caching maybe not that bad afterwards
50 2012-07-15T17:23:41 <ThomasWaldmann> and we maybe could even split the js stuff into multiple pieces and stitch them together again using templating
51 2012-07-15T17:25:05 <RogerHaase> sounds OK to me. So the primary candidate at the moment is static/index_action.js?
52 2012-07-15T17:25:16 <ThomasWaldmann> that way we do not need to deal with every word at 2 places (html template setting a js variable + js file using that variable)
53 2012-07-15T17:26:50 <ThomasWaldmann> common.js also has a little
54 2012-07-15T17:32:56 <RogerHaase> I do not see it in common.js. We talked about needing translation in .js months back, but for the comments and transclusion patches I put the text in config/default.py
55 2012-07-15T17:35:26 <RogerHaase> ThomasWaldmann: btw, I still have the rewrite of index_action.js in my repo: https://bitbucket.org/RogerHaase/moin-2.0
56 2012-07-15T17:36:15 <ThomasWaldmann> yes, we maybe could avoid passing around stuff in misc strange ways :)
57 2012-07-15T17:37:34 <ThomasWaldmann> RogerHaase: did we finish review and discussion of this already?
58 2012-07-15T17:38:00 * ThomasWaldmann was a bit distracted the last 2 weeks and doing lots of other reviews also doesn't help with concentration either
59 2012-07-15T17:38:09 <RogerHaase> That would be fine with me. The use of the | to separate text was definitely a hack.
60 2012-07-15T17:39:51 <RogerHaase> Yes we did CRs: http://codereview.appspot.com/6348047/ and http://codereview.appspot.com/6349052/
61 2012-07-15T17:49:25 <ThomasWaldmann> ok, I'll pull that...
62 2012-07-15T17:52:18 <CIA-54> Roger Haase <crosseyedpenguin@yahoo.com> default * 1424:c8f2e9122fdb 2.0/MoinMoin/ (3 files in 3 dirs): add comments and rework global index js; workaround IE9 multi-download bug; eliminate use of jquery multiDownload plugin
63 2012-07-15T17:52:18 <CIA-54> Roger Haase <crosseyedpenguin@yahoo.com> default * 1425:74c0a0f65273 2.0/ (setup.py wikiconfig.py): remove multiDownload jquery plugin
64 2012-07-15T17:52:19 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1426:cf62198c81f7 2.0/ (5 files in 4 dirs): merged
65 2012-07-15T17:52:44 <ThomasWaldmann> sometimes a pull request helps if i somehow can't do it ad-hoc or forget doing it
66 2012-07-15T17:53:14 <ThomasWaldmann> jaiditya: ^^ more stuff to pull/merge
67 2012-07-15T17:54:33 <jaiditya> I have just corrected the forms and now foobar theme pages don't crash
68 2012-07-15T17:54:52 <jaiditya> I have pushed them changes to my repo
69 2012-07-15T17:55:53 <jaiditya> I'll pull again
70 2012-07-15T18:00:53 *** dcramer_
71 2012-07-15T18:01:43 <RogerHaase> is jinja2 templating for *.js that needs i18n on jaiditya's todo list? :)
72 2012-07-15T18:04:49 <jaiditya> no not yet. I have other stuff lined up first
73 2012-07-15T18:16:21 *** dcramer_
74 2012-07-15T18:25:39 <dreimark> re
75 2012-07-15T18:26:51 <dreimark> jaiditya i think some parts of the user menu should be accessible while editing
76 2012-07-15T18:27:24 <dreimark> e.g. interwiki entries, or highlighting
77 2012-07-15T18:30:24 <dreimark> see also my question to the admin view
78 2012-07-15T18:58:56 *** dcramer_
79 2012-07-15T19:51:25 <ThomasWaldmann> RogerHaase: http://archive.plugins.jquery.com/project/gettext another approach
80 2012-07-15T19:51:49 <ThomasWaldmann> but it looks like this will get the complete translation via a separate http request
81 2012-07-15T19:55:34 <ThomasWaldmann> https://docs.djangoproject.com/en/1.3/topics/i18n/internationalization/#specifying-translation-strings-in-javascript-code django approach
82 2012-07-15T20:13:52 <RogerHaase> ThomasWaldmann: If we can do it with jinja2, wouldn't fewer tools be better?
83 2012-07-15T20:17:22 <ThomasWaldmann> yes
84 2012-07-15T20:17:40 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/14/i18n-for-javascript-code#comment-1667952 see there
85 2012-07-15T20:47:55 *** dcramer_
86 2012-07-15T20:50:52 <RogerHaase> ThomasWaldmann: the js code part looks simple enough, but I am confused as to what is required to make jinja2 serve a .js file
87 2012-07-15T20:52:51 <ThomasWaldmann> there would be a view for that in our code, that gets the filename/path (at least) and then it would render the template and return a response with correct content-type, caching headers, etag
88 2012-07-15T21:01:34 *** jaiditya
89 2012-07-15T21:16:41 * ThomasWaldmann tries that
90 2012-07-15T21:18:31 <RogerHaase> so you are creating a ~ /apps/js/views.py ?
91 2012-07-15T21:19:49 <ThomasWaldmann> i am currently just putting it into frontend for experimenting with it
92 2012-07-15T21:25:25 *** xorAxAx
93 2012-07-15T21:27:55 *** xorAxAx
94 2012-07-15T21:27:58 *** xorAxAx
95 2012-07-15T21:45:10 <ThomasWaldmann> of course it fell over that markup hacking for transclusions {{ }}
96 2012-07-15T21:51:09 <bretonium> As a result of an unintended, forced fight I have a broken nose, possibly a lost tooth, an already stitched wound and something else. Because of it there won't be any code from me today, tomorrow and the day after tomorrow. And maybe futher, sitting in the hospital now. Will keep you informed.
97 2012-07-15T21:51:58 <bretonium> can post some photos if you want :3
98 2012-07-15T22:05:49 <RogerHaase> bretonium: sorry to hear the bad news. I hope you recover soon.
99 2012-07-15T22:10:47 *** dcramer_
100 2012-07-15T22:17:12 <dreimark> bretonium: ouch, get well soon.
101 2012-07-15T22:19:20 <dreimark> ThomasWaldmann: ^^
102 2012-07-15T22:23:53 *** dcramer_
103 2012-07-15T22:37:13 <ThomasWaldmann> bretonium: ouch. you insulted a php programmer?
104 2012-07-15T22:40:19 <ThomasWaldmann> bretonium: wish you good recovery
105 2012-07-15T22:40:32 <ThomasWaldmann> RogerHaase: it works :)
106 2012-07-15T22:42:37 <RogerHaase> ThomasWaldmann: great! I can do the gettext for index_action.js as I last touched the code (unless you have lalready done so).
107 2012-07-15T22:52:41 <ThomasWaldmann> i experiment with common.js currently, but yeah, that would be great. will commit soon.
108 2012-07-15T23:10:09 <bretonium> Well, there were at least 3 of php programmers there.
109 2012-07-15T23:13:49 <ThomasWaldmann> oh :|
110 2012-07-15T23:26:03 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1427:466a277c72a3 2.0/ (5 files in 5 dirs): (log message trimmed)
111 2012-07-15T23:26:03 <CIA-54> implement i18n for .js by using jinja2 js templates
112 2012-07-15T23:26:03 <CIA-54> /+template/<filename> renders the template <filename> and serves the
113 2012-07-15T23:26:03 <CIA-54> resulting content with the mimetype guessed for filename.
114 2012-07-15T23:26:03 <CIA-54> removed some hacks used for i18n purposes from common.js
115 2012-07-15T23:26:03 <CIA-54> common.js needs to get moved to templates/ directory, will be done in
116 2012-07-15T23:26:04 <CIA-54> next changeset to make review more easy.
117 2012-07-15T23:26:04 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1428:a8d0a52bb45d 2.0/MoinMoin/ (templates/common.js static/js/common.js): move MoinMoin/static/js/common.js to MoinMoin/templates/common.js (no content changed)
118 2012-07-15T23:31:52 <bretonium> no concussion, no lost teeth (yet), broken nose, which was already corrected. Was not put in a hospital. ETA of the first code - tuesday. In wednesday something will happen in the hospital again, so no code in wednesday too.
119 2012-07-15T23:32:13 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1429:de6e9e749a6d 2.0/setup.py: fix message extraction configuration in setup.py
120 2012-07-15T23:51:37 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1430:876e5f4656a0 2.0/MoinMoin/translations/MoinMoin.pot: extract messages, update MoinMoin.pot
121 2012-07-15T23:51:37 <CIA-54> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 1431:33466da28757 2.0/MoinMoin/translations/ (3 files in 3 dirs): updated translations, fixed german translation
