1 2012-07-18T00:02:39 *** eSyr-ng
2 2012-07-18T00:03:59 *** eSyr-ng
3 2012-07-18T03:33:31 *** spy
4 2012-07-18T03:33:39 *** spy
5 2012-07-18T03:34:09 *** ThomasWaldmann
6 2012-07-18T03:34:33 *** ThomasWaldmann
7 2012-07-18T03:34:41 *** ThomasWaldmann
8 2012-07-18T03:41:14 *** esyr
9 2012-07-18T03:41:14 *** bilal
10 2012-07-18T03:41:14 *** MaikuMori
11 2012-07-18T03:41:15 *** vpv
12 2012-07-18T03:46:06 *** esyr
13 2012-07-18T03:46:06 *** bilal
14 2012-07-18T03:46:06 *** MaikuMori
15 2012-07-18T03:46:06 *** vpv
16 2012-07-18T04:57:45 *** jaiditya
17 2012-07-18T05:25:01 *** dcramer_
18 2012-07-18T06:16:45 *** dcramer_
19 2012-07-18T07:29:46 *** dcramer_
20 2012-07-18T07:46:27 *** spy_
21 2012-07-18T07:47:09 *** josep2
22 2012-07-18T07:56:55 *** spy_
23 2012-07-18T09:17:16 *** jaiditya
24 2012-07-18T10:46:25 *** greg_f
25 2012-07-18T11:10:55 <dreimark> moin
26 2012-07-18T11:10:55 *** josep2
27 2012-07-18T11:52:01 <jaiditya> moin
28 2012-07-18T11:52:55 *** josep2
29 2012-07-18T11:56:44 <jaiditya> dreimark: ".moin-item-overlay-ul" and ".moin-item-overlay-lr" has "display: none" still many other properties like border, color, background has been set. Why ?
30 2012-07-18T11:59:14 <jaiditya> for modernized theme
31 2012-07-18T12:05:42 * dreimark looks
32 2012-07-18T12:10:32 <dreimark> jaiditya: http://hg.moinmo.in/moin/2.0/file/9a165b096ff9/MoinMoin/themes/modernized/static/css/common.css#l622
33 2012-07-18T12:10:52 <dreimark> where is display:none
34 2012-07-18T12:11:29 <jaiditya> line 619
35 2012-07-18T12:14:13 <dreimark> that is mostly called from toggleTransclusionOverlays
36 2012-07-18T12:14:21 <dreimark> in comon.js
37 2012-07-18T12:15:03 <dreimark> that generatees the transclusion markers
38 2012-07-18T12:16:07 <dreimark> rogerhaase has added this
39 2012-07-18T12:16:10 <jaiditya> dreimark: but I don't see any transclution markers there and this is because of display: none
40 2012-07-18T12:16:27 <dreimark> click on the view Transclusins
41 2012-07-18T12:19:16 <dreimark> this is currently different in foobar
42 2012-07-18T12:20:10 <jaiditya> ohh...so where is transclusion in foobar ?
43 2012-07-18T12:24:36 <dreimark> looks like it is not implemented yet
44 2012-07-18T12:24:49 <dreimark> you have the old style with the -> ->
45 2012-07-18T12:24:57 <dreimark> and that needs to become replaced
46 2012-07-18T12:26:20 <jaiditya> yeah I was styling that for foobar so was checking how it works in modernized
47 2012-07-18T12:27:15 <dreimark> ah - i just wondered because the navigation element is not in the list
48 2012-07-18T12:27:35 <jaiditya> but with no Transclusion view in foobar how it will work
49 2012-07-18T12:27:46 <jaiditya> yeah
50 2012-07-18T12:28:01 <jaiditya> thats what I was thinking
51 2012-07-18T12:28:23 <dreimark> may be compare all others too, but i guess only this element is missing
52 2012-07-18T12:28:32 <dreimark> because the old style was on mouse over
53 2012-07-18T12:29:00 <dreimark> htg, bbl
54 2012-07-18T12:29:06 <jaiditya> ok
55 2012-07-18T12:57:58 *** josep2
56 2012-07-18T13:16:51 *** josep2
57 2012-07-18T13:31:32 <ThomasWaldmann> moin
58 2012-07-18T14:06:00 *** dcramer_
59 2012-07-18T14:51:18 *** dcramer_
60 2012-07-18T15:04:49 *** dave_largo
61 2012-07-18T15:27:26 *** spy
62 2012-07-18T15:32:21 *** spy_
63 2012-07-18T15:33:53 *** spy
64 2012-07-18T16:04:34 <spy> dreimark: ThomasWaldmann: http://codereview.appspot.com/6356070/
65 2012-07-18T16:06:29 <spy> also working instance: http://vps.psviderski.name:8080/myblog
66 2012-07-18T16:12:06 * xiaq looks at spy's patch set
67 2012-07-18T16:15:39 <xiaq> my metadata editor patch set: http://codereview.appspot.com/6429043
68 2012-07-18T16:15:43 <xiaq> spy: ^^
69 2012-07-18T16:15:45 <xiaq> ThomasWaldmann: ^^
70 2012-07-18T16:15:47 <xiaq> dreimark: ^^
71 2012-07-18T16:24:02 * xiaq finished review of spy's patch set
72 2012-07-18T16:24:58 *** dwcramer
73 2012-07-18T16:46:05 *** xiaq-m
74 2012-07-18T16:48:16 *** xiaq-m
75 2012-07-18T16:48:41 *** xiaq-m
76 2012-07-18T16:49:03 *** RogerHaase
77 2012-07-18T17:04:35 *** dwcramer
78 2012-07-18T17:08:39 *** josep2
79 2012-07-18T17:10:05 <spy> dreimark: ThomasWaldmann: some questions and screens: http://moinmo.in/GoogleSoc2012/WikiBlog/2012-07-18
80 2012-07-18T17:11:20 * spy looks at xiaq's cr patch set
81 2012-07-18T17:12:54 <RogerHaase> ThomasWaldmann: I pushed the fixes for 148, 213, and the horizontal scrollbar to https://bitbucket.org/RogerHaase/moin-2.0
82 2012-07-18T17:15:26 <dreimark> re
83 2012-07-18T17:19:54 *** dwcramer
84 2012-07-18T17:51:35 <spy> xiaq: do you think about moving all forms in separate modules? Move your widgets to forms/__init__.py, meta forms and validators to forms/meta.py.
85 2012-07-18T18:10:13 <ThomasWaldmann> spy: except the wiki's theme header, it almost looks like a blog now :D
86 2012-07-18T18:10:56 <ThomasWaldmann> spy: about the metadata editor: i guess xiaq can review that much better than me :)
87 2012-07-18T18:11:54 <ThomasWaldmann> it would be nice if the render-method EP would contain some docs about how the plan is, maybe we could even put that into the developer docs then for the future
88 2012-07-18T18:16:56 <dreimark> spy: reviewed, about the datetime question, may be that is in flask babel or sim. extension already solved
89 2012-07-18T18:19:52 *** dcramer_
90 2012-07-18T18:23:06 *** dwcramer
91 2012-07-18T18:35:54 *** brunomartin
92 2012-07-18T18:49:32 <dreimark> bbl
93 2012-07-18T19:41:36 *** greg_f
94 2012-07-18T19:51:01 *** spy_
95 2012-07-18T19:52:42 *** spy
96 2012-07-18T21:19:51 *** jaiditya
97 2012-07-18T21:23:25 *** dave_largo
98 2012-07-18T21:29:03 *** bretoniu1
99 2012-07-18T21:34:28 *** bretonium
100 2012-07-18T21:34:29 *** waldi
101 2012-07-18T21:35:55 *** bretoniu1
102 2012-07-18T21:41:00 *** waldi
103 2012-07-18T21:41:01 *** waldi
104 2012-07-18T21:58:55 *** jaiditya
105 2012-07-18T22:02:02 <jaiditya> RogerHaase: there is no transclusion in foobar theme views. So how transclusions are supposed to be styled ?
106 2012-07-18T22:03:07 <RogerHaase> looking...
107 2012-07-18T22:04:54 *** spy
108 2012-07-18T22:04:54 *** spy_
109 2012-07-18T22:06:58 *** esyr
110 2012-07-18T22:07:08 *** musicpd
111 2012-07-18T22:13:48 <RogerHaase> jaiditya: a guess is the js function initTransclusionOverlays() is not working. still looking.
112 2012-07-18T22:16:45 <RogerHaase> jaiditya: the last line is to make .moin-transclusions-button visible. There isn't any.
113 2012-07-18T22:22:38 <jaiditya> no there isn't any transclusion button in views panel
114 2012-07-18T22:25:05 <RogerHaase> look at /templates/itemviews.html ~ line 75. The transclusions and the coments thing above it need to be copied into the foobar itemviews.
115 2012-07-18T22:27:41 <RogerHaase> Then if a given page has comments or transclusions, a js function will make the buttons (links) visible
116 2012-07-18T22:32:24 <jaiditya> RogerHaase: in foobar theme comments is already present but with a different class
117 2012-07-18T22:37:16 <RogerHaase> hm, but to see comments in foobar, I have to login and check Show comment sections under setting options. In modernized, there is a link to turn show commonts on/off.
118 2012-07-18T22:38:20 <jaiditya> RogerHaase: no transclusion is still mising from views
119 2012-07-18T22:39:16 <RogerHaase> Is there a transclusion on the page?
120 2012-07-18T22:40:03 <jaiditya> yes
121 2012-07-18T22:40:33 <RogerHaase> cr time?
122 2012-07-18T22:43:05 <jaiditya> RogerHaase: copying the transclusion section in itemviews template made the foobar itemviews.html exact copy of template present in global template folder
123 2012-07-18T22:46:34 <jaiditya> https://dl.dropbox.com/u/43518659/transclusion-marker-1.jpg
124 2012-07-18T22:47:37 <jaiditya> transclusion marker "display: none" is removed to make them visible
125 2012-07-18T22:51:37 <RogerHaase> hmm, I have copied file. Views has hidden comment link, but no hidden transclusion link.
126 2012-07-18T22:52:40 <RogerHaase> try adding a comment to a page - does comments link display under Views?
127 2012-07-18T22:56:03 <jaiditya> no
128 2012-07-18T22:58:16 <jaiditya> I don't even see comment link in modernized theme
129 2012-07-18T23:02:44 <RogerHaase> jaiditya: The comments link has class toggleCommentsButton, it should be class moin-toggle-comments-button
130 2012-07-18T23:03:18 <jaiditya> I have alread changed that
131 2012-07-18T23:03:29 <jaiditya> already*
132 2012-07-18T23:05:59 <RogerHaase> itemviews.html has class moin-toggle-comments-button. But looking at the html source, the class is toggleCommentsButton. Maybe foobar does not use itemviews.html?
133 2012-07-18T23:08:04 <jaiditya> there is a seperate itemviews.html present in foobar template folder for itemviews
134 2012-07-18T23:08:45 <RogerHaase> looks like the comments link is defined in local.html. See line 86. Try copying the code from itemviews to local.html.
135 2012-07-18T23:11:40 *** MattMaker
136 2012-07-18T23:12:47 *** MattMaker
137 2012-07-18T23:13:22 <jaiditya> RogerHaase: transclusion is now visible and I should change the class of comment link from toggleCommentButton
138 2012-07-18T23:13:56 <RogerHaase> right
139 2012-07-18T23:14:19 <jaiditya> if itemviews.html is not used in foobar why it is present in its template folder ?
140 2012-07-18T23:17:10 <RogerHaase> good question! I was about to suggest you check to see if it is used and delete it if not used.
141 2012-07-18T23:17:42 <jaiditya> no comments link yet.
142 2012-07-18T23:18:12 <jaiditya> yeah .I'll check it
143 2012-07-18T23:19:37 <jaiditya> RogerHaase: If I am not wrong comment is referred to comment which is added while modifying ?
144 2012-07-18T23:21:11 <RogerHaase> Your page must have /* this is a comment */
145 2012-07-18T23:25:19 <jaiditya> RogerHaase: ahh...got it....my bad . I was doing it wrong.
146 2012-07-18T23:25:55 <RogerHaase> great :)
147 2012-07-18T23:32:48 <jaiditya> now as itemviews.html is same as that present in global template folder I think I should delete this file present in foobar theme folder
148 2012-07-18T23:32:50 <jaiditya> also delete the itemviews code from local.html and import that file from global template folder in local.html
149 2012-07-18T23:35:36 <RogerHaase> yes, looks like that would eliminate duplicated code
150 2012-07-18T23:36:12 *** spy
151 2012-07-18T23:55:28 <jaiditya> RogerHaase: done :)
152 2012-07-18T23:56:38 <jaiditya> one thing that I noticed is anywhere on the screen if I double click it opens the modify view
153 2012-07-18T23:56:39 <jaiditya> and most of the times I didn't intended that
154 2012-07-18T23:57:12 <jaiditya> rather it should happen only in content area
155 2012-07-18T23:58:09 <RogerHaase> hmm, remedial wiki training - go to user settings, options, and uncheck Open editor on double click.
MoinMoin: MoinMoinChat/Logs/moin-dev/2012-07-18 (last edited 2012-07-17 22:45:04 by IrcLogImporter)