1 2012-07-23T05:03:04 <xiaq> updated: http://codereview.appspot.com/6432058/ (was actually updated last night)
2 2012-07-23T05:03:07 <xiaq> dreimark: ^^
3 2012-07-23T05:12:41 *** spy
4 2012-07-23T05:17:03 *** spy
5 2012-07-23T05:54:43 <xiaq> a summary on current item creation workflow and how itemtype affects it: http://etherpad.osuosl.org/moin-render-method line 237
6 2012-07-23T05:54:46 <xiaq> dreimark: ^^
7 2012-07-23T05:54:46 <xiaq> ThomasWaldmann: ^^
8 2012-07-23T05:54:48 <xiaq> spy: ^^
9 2012-07-23T05:56:44 <xiaq> ThomasWaldmann: also, i'm thinking about a better name for what i currently name items.content.Default
10 2012-07-23T05:57:08 <xiaq> need a more specific name than "Default" - perhaps "Article" but that's maybe a bit too specific
11 2012-07-23T05:57:30 <xiaq> needs a name more specific than Default, more general than Article
12 2012-07-23T05:58:12 <xiaq> WikiPage?
13 2012-07-23T05:58:42 <xiaq> aha, WikiPage feels good for me
14 2012-07-23T05:59:11 <xiaq> or just Page
15 2012-07-23T06:01:54 <xiaq> by grepping for Page it seems that the name Page is mostly unused, except for some moin1 leftover, which should be called item now
16 2012-07-23T06:14:11 <xiaq> ThomasWaldmann: updated (again): http://codereview.appspot.com/6432058/
17 2012-07-23T06:14:13 <xiaq> dreimark: ^^
18 2012-07-23T07:42:36 *** spy
19 2012-07-23T08:17:21 *** spy
20 2012-07-23T09:00:06 <dreimark> xiaq: i can't create the Home item
21 2012-07-23T09:00:09 <dreimark> http://localhost:8080/%2Bmodify/Home?contenttype=text%2Fx.moin.wiki%3Bcharset%3Dutf-8
22 2012-07-23T09:00:34 <dreimark> gives again the initial selection of contenttype
23 2012-07-23T09:00:56 <dreimark> hg tip is changeset: 1436:1122533f76e6
24 2012-07-23T09:02:12 <dreimark> there are also lots of failing tests
25 2012-07-23T09:02:38 <dreimark> 24 failed, 860 passed, 58 skipped in 37.69 seconds
26 2012-07-23T09:03:39 <dreimark> run make test
27 2012-07-23T09:08:34 <xiaq> dreimark: uh, my tip is only one more changeset than official branch, so the failing tests are not my fault :)
28 2012-07-23T09:09:22 <xiaq> dreimark: the itemtype changeset are published as a patch queue: https://bitbucket.org/xiaq/itemtype/
29 2012-07-23T09:09:43 <dreimark> have you run the tests?
30 2012-07-23T09:10:08 <dreimark> I wonder that you had not to modify one with doing all the experimental changes
31 2012-07-23T09:10:28 <dreimark> and I just downloaded the patch from cr
32 2012-07-23T09:10:31 <xiaq> dreimark: modify one what?
33 2012-07-23T09:10:56 <dreimark> http://codereview.appspot.com/6432058/
34 2012-07-23T09:11:02 <dreimark> has no test modification
35 2012-07-23T09:11:17 * xiaq trying to reproduce dreimark's working directory
36 2012-07-23T09:11:43 <dreimark> I did a clone from my local repo from yours
37 2012-07-23T09:11:52 <dreimark> then applied the patch
38 2012-07-23T09:12:01 <dreimark> quickinstall ...
39 2012-07-23T09:14:50 * dreimark gets breakfast
40 2012-07-23T09:17:27 * xiaq has problem with pypi.python.org :(
41 2012-07-23T09:22:39 <xiaq> dreimark: i think keeping all tests pass while doing some experimental dev is not that worthwhile, i'd rather fix tests after code stablize a bit
42 2012-07-23T10:08:10 *** spy
43 2012-07-23T10:22:26 <dreimark> hmm, ok for playing with code but usually one can do the same with tests
44 2012-07-23T10:23:11 <dreimark> before changing the code then the changes are covered
45 2012-07-23T10:33:25 <dreimark> xiaq: i try the itemtype patch queue
46 2012-07-23T10:44:36 <dreimark> xiaq: patch queue works
47 2012-07-23T10:44:40 *** MattMaker
48 2012-07-23T10:50:47 * xiaq has no problem with fresh clone + cr patch either
49 2012-07-23T10:51:39 <dreimark> hmm, strange I repeat that
50 2012-07-23T10:52:02 <dreimark> also the patch queue
51 2012-07-23T10:52:25 <xiaq> wait,
52 2012-07-23T10:52:52 * xiaq gets bug accessing /+modify/Home on a fresh clone + cr patch
53 2012-07-23T10:53:06 <xiaq> seems i missed out something in the patch
54 2012-07-23T10:54:23 *** greg_f
55 2012-07-23T10:54:25 <dreimark> and i did mqclone wrong
56 2012-07-23T11:00:39 * xiaq checked and seems to haven't missed anything important in cr patch
57 2012-07-23T11:00:48 <xiaq> also, i just updated the patch queue...
58 2012-07-23T11:01:48 <dreimark> xiaq: hg qseries
59 2012-07-23T11:01:56 <dreimark> tells a list of queues
60 2012-07-23T11:02:06 <dreimark> how can I activate itemtype?
61 2012-07-23T11:02:41 <xiaq> dreimark: just `hg qgoto itemtype`
62 2012-07-23T11:42:08 *** spy
63 2012-07-23T11:44:22 <dreimark> xiaq ok i do so after i m back in the hotel
64 2012-07-23T11:45:32 <dreimark> can you please add on a page or EP what i have to enter to create a
65 2012-07-23T11:46:03 <dreimark> ticket and to get the list of tickets
66 2012-07-23T11:56:38 <dreimark> esyr got you some news from your student
67 2012-07-23T12:01:04 *** spy
68 2012-07-23T12:39:29 <dreimark> spy please prepare also some info how to make a blog post and to get the blog shown
69 2012-07-23T13:10:45 <spy> dreimark: using itemtype?
70 2012-07-23T13:12:46 <spy> xiaq: I rewrote my meta editor with macros meta_editor. How could we merge our changes?
71 2012-07-23T14:09:52 *** spy
72 2012-07-23T14:09:53 *** ThomasWaldmann
73 2012-07-23T14:09:55 *** CIA-54
74 2012-07-23T14:10:24 *** spy
75 2012-07-23T14:10:24 *** ThomasWaldmann
76 2012-07-23T14:10:24 *** CIA-54
77 2012-07-23T14:21:49 *** spy
78 2012-07-23T14:21:50 *** ThomasWaldmann
79 2012-07-23T14:21:51 *** CIA-54
80 2012-07-23T14:22:41 *** spy
81 2012-07-23T14:22:41 *** ThomasWaldmann
82 2012-07-23T14:22:41 *** CIA-54
83 2012-07-23T14:26:26 <dreimark> spy: there is no ui element yet or?
84 2012-07-23T14:29:54 <spy> dreimark: which ui element do you mean?
85 2012-07-23T14:40:54 *** dave_largo
86 2012-07-23T15:10:10 *** ronny
87 2012-07-23T15:16:33 *** dwcramer
88 2012-07-23T15:29:21 *** eSyr
89 2012-07-23T15:30:50 *** eSyr
90 2012-07-23T16:45:13 *** RogerHaase
91 2012-07-23T17:05:22 <MaikuMori> Moin
92 2012-07-23T17:05:30 <MaikuMori> which revision is http://test.moinmo.in/ running on?
93 2012-07-23T17:28:58 <MaikuMori> https://bitbucket.org/thomaswaldmann/moin-2.0/changeset/100197cb69ab#chg-MoinMoin/templates/forms.html broke FooBar theme as it depends on render_field method/macro.
94 2012-07-23T17:32:13 <xiaq> dreimark: ticket creation is currently broken, sorry :(
95 2012-07-23T17:33:45 <xiaq> spy: itemtype is still my proposal. if you found it a good methodology, you can rebase your code on my itemtype patch set.
96 2012-07-23T17:35:37 * xiaq will look at spy's latest metadata editor patch set
97 2012-07-23T17:39:16 * xiaq 's town is suffering from constant electricity failures which somehow slows my work down :(
98 2012-07-23T17:41:08 <spy> xiaq: also you can play with it here: http://vps.psviderski.name:8080/myblog
99 2012-07-23T17:43:30 <dreimark> re
100 2012-07-23T17:44:19 <dreimark> MaikuMori: ignore test.moinmo.in
101 2012-07-23T17:44:58 <dreimark> and ignore FooBar too because it becomes refactored by jaidityq
102 2012-07-23T17:45:22 <dreimark> you can look on his repo for the new code
103 2012-07-23T17:47:10 <dreimark> xiaq: ok, recog. electricity failures are a problem
104 2012-07-23T17:47:42 <dreimark> spy: i meant what i need to do to make a blog entry
105 2012-07-23T17:47:59 <dreimark> and if that is somewhere in the navibar already?
106 2012-07-23T17:48:01 <spy> xiaq: It seems my approach can be easily adapted to your new proposal. Just replace the part that uses view_method on itemtype one.
107 2012-07-23T17:48:13 <xiaq> spy: looks great :)
108 2012-07-23T17:54:01 <dreimark> MaikuMori: we missed you on saturday what happens?
109 2012-07-23T17:54:33 <spy> dreimark: in order to create a new blog entry, a new wiki page must be created as a subpage of the blog page. Do you think we might want to have a special links/buttons/forms to create new entries?
110 2012-07-23T17:55:42 <dreimark> spy: where is the blog page defined?
111 2012-07-23T17:55:57 <dreimark> can it be each home page?
112 2012-07-23T17:56:18 <dreimark> if many users want a blog
113 2012-07-23T17:56:23 <dreimark> how ist that archieved
114 2012-07-23T17:56:28 <dreimark> -t
115 2012-07-23T17:57:15 <dreimark> achieved
116 2012-07-23T17:58:24 <spy> dreimark: blog page is an ordinary wiki page too. when +blog/<item> view is used the 'item' is considered as a blog page and all subpages as its blog entries
117 2012-07-23T17:59:22 <spy> currently view_method meta value is used just not to directly set +blog view
118 2012-07-23T18:00:02 <spy> so every page could be a blog page
119 2012-07-23T18:01:29 <spy> but no entries will be listed on it if there no correct 'ptime' meta value on its subpages
120 2012-07-23T18:04:55 <dreimark> spy: can it also work on a subpage of the users homepage. I mean is it important that it is a major page
121 2012-07-23T18:05:05 <dreimark> can we have e.g. ReimarBauer/Blog
122 2012-07-23T18:05:49 <dreimark> and the subpages then below e.g. ReimarBauer/Blog/entry1
123 2012-07-23T18:06:31 <spy> sure
124 2012-07-23T18:08:40 <dreimark> great
125 2012-07-23T18:11:52 <spy> dreimark: currently there is no way to modify blog/blogentry item instead of inserting '+modify' before its name in the url. Do you have some suggestions on how to use the itemviews bar and navibar for that?
126 2012-07-23T18:11:54 <dreimark> spy: tags are csv values or a special separtor?
127 2012-07-23T18:12:18 <spy> csv values
128 2012-07-23T18:14:07 <spy> ideally tags should be a list that is modified by some JS interface
129 2012-07-23T18:14:29 <spy> ThomasWaldmann said that he already have some ideas on this point
130 2012-07-23T18:14:48 <dreimark> ok, it is not any csv char, at least not a blank
131 2012-07-23T18:14:52 <dreimark> but ok
132 2012-07-23T18:15:03 <dreimark> how can a blog post be edited again
133 2012-07-23T18:15:34 <spy> type +modify/myblog/<PAGE>
134 2012-07-23T18:16:12 <dreimark> that is manual, so you could also show some parts of the editbar, where modify is located
135 2012-07-23T18:17:01 <dreimark> i missed the question from 18:11
136 2012-07-23T18:17:43 <spy> it would be a bit strange for a common blog listener to see 'Modify' in the header bar (itemviews bar), right?
137 2012-07-23T18:18:07 <dreimark> you could enable it for the owner of the post
138 2012-07-23T18:18:29 <dreimark> which means we have to discuss if anonymous blogs entries make sense
139 2012-07-23T18:18:57 <dreimark> and who edits , so likly no good idea to show it
140 2012-07-23T18:19:05 <dreimark> you are right
141 2012-07-23T18:19:12 <spy> or display it for all loged users
142 2012-07-23T18:20:16 <dreimark> I think until the entry is published it should have the edit functions
143 2012-07-23T18:20:43 <dreimark> that makes also a bit the separation between published and not
144 2012-07-23T18:21:44 <dreimark> then there could be in the navigation also a helper for "publish now"
145 2012-07-23T18:23:11 <dreimark> if it is published we should think a little bit what we want. a) make it only editable by the one who created the entry
146 2012-07-23T18:24:22 <spy> yes that is good. Also we have almost empty sidebar, is it reasonable to place all these modificators there?
147 2012-07-23T18:28:04 <xiaq> itemtype patch set updated again: http://codereview.appspot.com/6432058/
148 2012-07-23T18:28:06 <xiaq> dreimark: ^^
149 2012-07-23T18:28:08 <xiaq> ThomasWaldmann: ^^
150 2012-07-23T18:28:09 <xiaq> spy: ^^
151 2012-07-23T18:28:20 <xiaq> patch queue on bb is updated too
152 2012-07-23T18:28:27 <spy> may be the case when one man (writer) write and save a blog entry as Draft, and another one has the authority to review and publish it.
153 2012-07-23T18:29:39 <dreimark> b) we could also maybe set a predefined acl after publishing
154 2012-07-23T18:29:46 <dreimark> and who has rights can edit
155 2012-07-23T18:30:52 <dreimark> yes, get jaiditya when he is available and point him to the requirements for blog posts
156 2012-07-23T18:30:56 <dreimark> xiaq: you too
157 2012-07-23T18:31:26 <dreimark> xiaq: I will look at it after i am back from dinner, sorry that we have always this overlap with my belongings
158 2012-07-23T18:32:39 <xiaq> alright
159 2012-07-23T18:34:42 <spy> xiaq: maybe for now use a radio input to select the 'itemtype' value on modify_show_itemtype_selection.html
160 2012-07-23T18:35:25 <xiaq> spy: i just copied modify_show_type_selection.html and made minumum modification :)
161 2012-07-23T18:35:42 <spy> I see :)
162 2012-07-23T18:35:56 <xiaq> the template name is becoming a problem... modify_show_{item,content}type_selection.html is just toooo long
163 2012-07-23T18:36:02 <dreimark> spy: have you somewhere this kind of workflows, the one you described is the "four-eye principle"
164 2012-07-23T18:36:18 <xiaq> what about just modify_select_{item,content}type.html?
165 2012-07-23T18:36:31 <dreimark> Is there an other limitation like that possible?
166 2012-07-23T18:37:55 *** kanha
167 2012-07-23T18:38:36 <dreimark> bbl
168 2012-07-23T18:40:10 <spy> dreimark: do you mean some other blog engines with this workflows?
169 2012-07-23T18:41:49 <spy> xiaq: the last names looks ok
170 2012-07-23T18:42:33 <spy> xiaq: how could I play with your itemtype changesets?
171 2012-07-23T18:43:07 <xiaq> spy: clone the patch queue https://bitbucket.org/xiaq/itemtype/
172 2012-07-23T18:43:10 <spy> do you have any public moin2 instance with your changes?
173 2012-07-23T18:43:23 <dreimark> spy: with the Draftr and Pubplish cycle we have now some CMS like feature for items
174 2012-07-23T18:43:26 <xiaq> spy: not yet :(
175 2012-07-23T18:44:40 *** jaiditya
176 2012-07-23T18:44:53 <dreimark> if the owner should not be the one who sets the publish time
177 2012-07-23T18:44:54 <spy> xiaq: what is a cms like feature, where do we have that?
178 2012-07-23T18:45:18 <dreimark> how is that done?
179 2012-07-23T18:46:02 <dreimark> that sounds like some meta entries need different rights
180 2012-07-23T18:46:37 <dreimark> jaiditya: can you push the modernized changes in the next 12h?
181 2012-07-23T18:46:47 <jaiditya> yeah
182 2012-07-23T18:46:54 <dreimark> I like to play with the theme while sitting in the train
183 2012-07-23T18:47:03 <dreimark> ok thx,
184 2012-07-23T18:47:25 <dreimark> htg now
185 2012-07-23T18:47:26 <dreimark> bbl
186 2012-07-23T18:48:01 <jaiditya> I haven't changed anything visually but you can see if css generated thriugh stylus is missing something
187 2012-07-23T18:50:24 <spy> xiaq: why do you prefer using mercurial queues instead of general commits?
188 2012-07-23T18:51:07 <MaikuMori> dreimark: I forgot to update doodle, I'm now 50%/50% avaiable during weekends.
189 2012-07-23T18:52:07 <ThomasWaldmann> xiaq: review done
190 2012-07-23T18:52:42 <xiaq> spy: was just some kind of brainstorm product. don't remember who proposed it...
191 2012-07-23T18:53:01 <xiaq> spy: you cannot alter commits after pushing them
192 2012-07-23T18:57:32 <spy> xiaq: ok, will try to get familiar with it
193 2012-07-23T18:58:51 <xiaq> spy: it's basically mutable commits...
194 2012-07-23T19:01:25 <ThomasWaldmann> btw, did someone cleanup/clarify the EP meanwhile?
195 2012-07-23T19:02:22 <xiaq> ThomasWaldmann: nope
196 2012-07-23T19:07:56 <ThomasWaldmann> so, how do we know the current solution covers the stuff needed?
197 2012-07-23T19:08:38 * ThomasWaldmann needs to go, bbl
198 2012-07-23T19:09:17 <xiaq> ThomasWaldmann: see my comment on l162
199 2012-07-23T19:17:12 <xiaq> ThomasWaldmann: replied cr
200 2012-07-23T19:21:00 * xiaq updated patch set http://codereview.appspot.com/6432058/
201 2012-07-23T19:21:04 <xiaq> dreimark: ^^
202 2012-07-23T19:21:05 <xiaq> spy: ^^
203 2012-07-23T19:21:10 * xiaq needs to go to bed, gn
204 2012-07-23T19:23:36 <spy> gn
205 2012-07-23T20:01:02 *** greg_f
206 2012-07-23T21:12:21 *** spy
207 2012-07-23T21:18:24 *** spy
208 2012-07-23T21:21:46 *** spy
209 2012-07-23T21:22:27 *** spy
210 2012-07-23T21:28:10 *** jaiditya
211 2012-07-23T21:39:45 *** MattMaker
212 2012-07-23T21:44:48 *** jaiditya
213 2012-07-23T22:07:54 *** RogerHaase
214 2012-07-23T22:35:17 <dreimark> MaikuMori: well you missed the last three meetings and you could also make a meeting with eSyr here
215 2012-07-23T22:35:44 <dreimark> I can't read any status update and also no workplan from you
216 2012-07-23T22:36:04 <dreimark> and no diary entry also no codereview
217 2012-07-23T22:37:09 <dreimark> diary quite seldom
218 2012-07-23T22:37:32 <dreimark> so what are you doing
219 2012-07-23T23:16:03 *** dave_largo
220 2012-07-23T23:39:56 *** dwcramer
221 2012-07-23T23:47:14 <dreimark> eSyr: please get a meeting with MaikuMori in the next days here
222 2012-07-23T23:47:33 <dreimark> there should be the usual information given to us
223 2012-07-23T23:53:04 <dreimark> jaiditya: still woking on modernized?
224 2012-07-23T23:54:48 <jaiditya> dreimark: yeah...just 30-40 mins more then I'll push the basic structure of it
225 2012-07-23T23:55:36 <jaiditya> was stuck with some bug, just resolved it
