1 2012-07-24T00:17:21 <dreimark> jaiditya: ok
2 2012-07-24T00:22:20 <dreimark> i fetch it in 6h have to get some sleep now
3 2012-07-24T00:30:33 *** jaiditya|2
4 2012-07-24T00:30:56 <jaiditya|2> ok
5 2012-07-24T00:31:13 *** jaiditya
6 2012-07-24T00:34:36 *** jaiditya|2
7 2012-07-24T00:56:39 *** Gnarlodious
8 2012-07-24T01:00:33 *** Gnarlodious
9 2012-07-24T01:12:57 *** dwcramer
10 2012-07-24T01:25:11 *** bilal
11 2012-07-24T01:25:40 *** bilal
12 2012-07-24T01:48:26 *** jaiditya|2
13 2012-07-24T01:49:16 *** jaiditya
14 2012-07-24T01:49:20 *** jaiditya|2
15 2012-07-24T01:49:56 <jaiditya> dreimark: https://Jaiditya@bitbucket.org/Jaiditya/moin-2.0
16 2012-07-24T02:37:46 *** spy
17 2012-07-24T04:07:33 *** yufra
18 2012-07-24T04:08:40 *** yufra
19 2012-07-24T04:14:13 *** xiaq
20 2012-07-24T04:14:22 *** xiaq
21 2012-07-24T04:45:55 <xiaq> hey let's clean up the render-method EP http://etherpad.osuosl.org/moin-render-method :)
22 2012-07-24T04:46:24 <xiaq> ThomasWaldmann: used_as is abandoned. (re)move your comments in that section?
23 2012-07-24T04:47:26 <xiaq> spy: you had contribution in that section too, (re)move them?
24 2012-07-24T04:48:54 <xiaq> ThomasWaldmann: i think itemtype + (content_render_method | contenttype_output) would cover the use cases proposed on the EP
25 2012-07-24T04:49:10 *** jaiditya
26 2012-07-24T04:49:12 <xiaq> and these two are pretty orthogonal
27 2012-07-24T05:23:00 *** RogerHaase
28 2012-07-24T05:23:22 *** dwcramer
29 2012-07-24T05:23:59 *** RogerHaase
30 2012-07-24T05:32:27 <xiaq> there are problems with html lang and dir attribute of <textarea>s in the templates:
31 2012-07-24T05:33:04 <xiaq> http://hg.moinmo.in/moin/2.0/file/9a165b096ff9/MoinMoin/templates/modify_text.html#l17 modify_text.html checks direction variable and then only sets the dir attribute when it's truthy;
32 2012-07-24T05:33:55 <xiaq> http://hg.moinmo.in/moin/2.0/file/9a165b096ff9/MoinMoin/templates/modify_text_html.html#l11 while modify_text_html.html always calls gen.textarea with a dir attribute
33 2012-07-24T05:34:37 <xiaq> besides the inconsistency, i cannot find the definition of `direction` and `lang` template variables
34 2012-07-24T05:35:12 <xiaq> hm, perhaps it's installed by flask?
35 2012-07-24T05:35:16 * xiaq looks up flask doc
36 2012-07-24T05:36:21 <xiaq> no it's not installed by flask
37 2012-07-24T05:38:59 * xiaq did a grep for '\bdirection\b' and then '\blang\b' in moin source tree
38 2012-07-24T05:40:00 <xiaq> after manual filtering i still cannot find where they are defined - they are not jinja2 globals, not passed to render_template as template context variable
39 2012-07-24T05:42:14 <xiaq> by inserting a bogus "{{ a.a }}" intentionally in modify_text.html thus triggering the werkzeug debugger, both `direction` and `lang` are just `Undefined`...
40 2012-07-24T05:46:40 <xiaq> so, seems someone has done the jinja2 template part of html `dir` and `lang` attribute, but not the python part yet?
41 2012-07-24T05:50:44 <xiaq> i'd like to convert the `gen.textarea` calls to forms.render (which in turn dispatches to forms.multiline_text), but there is no `lang` and `dir` support in forms.multiline_text yet. so i read modify_text.html and modify_text_html.html and noticed the problems...
42 2012-07-24T05:58:32 * xiaq sent pull request to ThomasWaldmann - just 2 minor fixes to forms.py, no itemtype stuff yet
43 2012-07-24T05:58:35 <xiaq> ThomasWaldmann: ^^
44 2012-07-24T06:28:18 <xiaq> seems everyone else is asleep atm :D
45 2012-07-24T07:07:10 *** spy
46 2012-07-24T07:08:29 <xiaq> spy: please see my messages while you are offline http://moinmo.in/MoinMoinChat/Logs/moin-dev/2012-07-24
47 2012-07-24T07:39:48 <dreimark> xiaq: for the second changeset
48 2012-07-24T07:40:02 <dreimark> move import re on top of imports
49 2012-07-24T07:40:42 <dreimark> it is, forget what i said
50 2012-07-24T07:42:04 <dreimark> hmm separator=', '
51 2012-07-24T07:42:16 <dreimark> does it mean ',' or ', ' ?
52 2012-07-24T07:42:46 <dreimark> the regex is without the blank
53 2012-07-24T08:12:42 *** spy
54 2012-07-24T08:17:23 <xiaq> dreimark: separator is used when generating, not parsing. see JoinedStrring doc
55 2012-07-24T08:17:48 <dreimark> ok
56 2012-07-24T08:17:49 <xiaq> dreimark: having a space looks nicer, and it is in the sample code of flatlannd doc too
57 2012-07-24T08:18:13 <dreimark> the question is if that space is then required and what happens if someone makes two or more spaces
58 2012-07-24T08:18:45 <dreimark> i like usually the , and strip() internally
59 2012-07-24T08:19:03 <dreimark> just check if it works like that
60 2012-07-24T08:19:24 <dreimark> have to package some stuff
61 2012-07-24T08:19:27 <dreimark> bbl
62 2012-07-24T08:20:35 <xiaq> dreimark: for parsing separator_re is used, where space is optional
63 2012-07-24T08:20:55 <xiaq> separator_regex it is
64 2012-07-24T08:22:49 <xiaq> there is one problem though, when tags contain leading/trailing spaces, or embeded commas
65 2012-07-24T08:24:28 <xiaq> dreimark: it is no problem if tags are only edited with the widget, but with the json metadata editor (ie. what we have now), it is possible
66 2012-07-24T08:26:02 <xiaq> hm, should write a validator to forbid that
67 2012-07-24T09:04:01 *** MattMaker
68 2012-07-24T09:12:53 *** MattMaker
69 2012-07-24T09:43:52 <xiaq> dreimark: for the spelling of contenttype... it's a bit complicated
70 2012-07-24T09:44:57 <xiaq> dreimark: the two spellings content_type are both used in other places...
71 2012-07-24T09:46:31 <xiaq> although doing "ack -hc contenttype" and "ack hc content_type" on a source tree of default branch reveals that the former spelling occurs 332 times while the latter just 48 times :)
72 2012-07-24T09:47:01 <xiaq> ah no, it's 286 vs. 82
73 2012-07-24T09:47:11 <xiaq> in my tree it's 332 vs. 48
74 2012-07-24T09:47:43 <xiaq> my tree correponds to patch set 9 on http://codereview.appspot.com/6432058/
75 2012-07-24T10:18:12 <dreimark> then if a comma is in the tag, maybe it can be escaped by using "the,is escaped", "other tag"
76 2012-07-24T10:18:59 <dreimark> the spelling fix should go separately
77 2012-07-24T10:23:52 <xiaq> dreimark: okay
78 2012-07-24T10:24:30 <xiaq> dreimark: escaping commas would make things a bit complicated...
79 2012-07-24T10:31:37 <ThomasWaldmann> xiaq: in which cases does template_name NOT make sense?
80 2012-07-24T10:32:57 <xiaq> ThomasWaldmann: an Item subclass may not implement a template selection step in item creation
81 2012-07-24T10:33:26 <ThomasWaldmann> why?
82 2012-07-24T10:36:01 <xiaq> ThomasWaldmann: eg. template selection won't be very useful for Ticket
83 2012-07-24T10:38:24 <ThomasWaldmann> i am not so sure about that
84 2012-07-24T10:39:21 <ThomasWaldmann> in a bigger project, there could be maybe lots of issues of similar kind that shall get filed in some specific way. for such stuff a template could make sense maybe.
85 2012-07-24T10:41:56 <ThomasWaldmann> btw, about avoiding review issues when moving stuff around: guess there are only 2 options to improve that: a) document unchanged stuff, like you did b) do not move and change within same changeset
86 2012-07-24T10:45:20 <xiaq> ThomasWaldmann: there is another argument against including template_name in the signature - the `template` query argument is always avaiable as just `request.values.get('template')`, obtaining the value early in the +modify handler makes the code a little more fragmented
87 2012-07-24T10:46:33 <xiaq> ThomasWaldmann: though most likely an Item subclass *will* implement template selection, what if it wants more information in the request.values? Things become asymmetric then...
88 2012-07-24T10:47:03 <xiaq> ThomasWaldmann: btw one place where template_name doesn't make sense is when calling NonExistent.do_modify :)
89 2012-07-24T10:49:19 <xiaq> ThomasWaldmann: one of the ideas about the Item hierarchy is to assume as little as possible about the behaviors of Item subclasses, and template_name in do_modify somehow breaks it - once the itemtype and contenttype are determined the rest is all up to the specific Item subclass
90 2012-07-24T10:49:42 <ThomasWaldmann> hmm, ok
91 2012-07-24T10:50:29 <ThomasWaldmann> but you'll have to duplicate the template_name getting code then at many places
92 2012-07-24T10:52:45 <xiaq> ThomasWaldmann: hm, what about defining some helper in Contentful
93 2012-07-24T10:53:05 <ThomasWaldmann> that change in the pull request, is it compatible with the code already in main repo?
94 2012-07-24T10:54:05 <ThomasWaldmann> xiaq: having to do a 1 line call to a helper instead of a 1 line .get isn't that much helpful
95 2012-07-24T10:57:37 <xiaq> ThomasWaldmann: no incompatibility. Tags was introduced by unused (intended to be used in the metadata editor which hasn't happened in main repo). The absense of two unused imports surely won't break anything either :)
96 2012-07-24T10:58:47 <ThomasWaldmann> ok
97 2012-07-24T10:59:49 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1436:1122533f76e6 2.0/MoinMoin/forms.py: Remove two unused imports from forms.py.
98 2012-07-24T10:59:51 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1437:368899856333 2.0/MoinMoin/forms.py:
99 2012-07-24T10:59:51 <CIA-54> Alter the Tags widget to use JoinedString instead of MultiValue.
100 2012-07-24T10:59:51 <CIA-54> With MultiValue, the flatland element is supposed to be flattened into
101 2012-07-24T10:59:51 <CIA-54> multiple widgets, a mechanism we don't yet have in forms.html. With a single
102 2012-07-24T10:59:51 <CIA-54> widget (WIDGET_TEXT), it is better to use JoinedString so that the list could
103 2012-07-24T10:59:51 <CIA-54> be flattened into a single widget.
104 2012-07-24T11:00:47 <xiaq> ThomasWaldmann: yeah that does result in a bit more code...
105 2012-07-24T11:03:13 <xiaq> ThomasWaldmann: but currently template codes are a bit too wrapped up - there is _do_modify_show_templates, get_templates, and the handling in do_modify
106 2012-07-24T11:26:36 *** greg_f
107 2012-07-24T11:28:50 <xiaq> i'm thinking about a solution to the POSTing of *Draw items. a question: is it possible to intercept the POST request from the applet with javascript?
108 2012-07-24T11:36:31 <ThomasWaldmann> as 2 of these are java applets, i don't think that is possible
109 2012-07-24T11:53:50 *** spy
110 2012-07-24T12:33:57 <dreimark> re
111 2012-07-24T12:40:33 <dreimark> esyr when do we get a status update from your studet?
112 2012-07-24T12:51:36 <ThomasWaldmann> and maybe not only status update, but see some work :)
113 2012-07-24T13:07:30 <xiaq> ThomasWaldmann: another idea - what about embedding the applet in a <frame>?
114 2012-07-24T13:08:10 <xiaq> that will normally require the user to do two clicks (one to save in the applet, another to save metadata etc.)
115 2012-07-24T13:09:08 <xiaq> but if we can watch changes in the <frame> with javascript, we can eliminate the second click - though i doubt that can be done seamlessly
116 2012-07-24T13:11:29 * xiaq found that MDN discourages use of <frame> in favor of <iframe>
117 2012-07-24T13:11:38 <xiaq> but the proposal is still valid
118 2012-07-24T13:11:59 <xiaq> and i guess the <frame> solution has been proposed before :)
119 2012-07-24T13:21:01 <dreimark> xiaq the applets do many posts
120 2012-07-24T13:23:09 <dreimark> also i have no idea what user java stuf people have
121 2012-07-24T13:23:40 <dreimark> i would prefer a js / html5 solution only
122 2012-07-24T13:56:28 <xiaq> dreimark: me too, java applet feel so 20th century :) does svgdraw cover the same functionality as anywikidraw and twikidraw
123 2012-07-24T13:57:23 <xiaq> still, i agree that it will be good to not break anywikidraw and twikidraw unless they become too clumsy to support
124 2012-07-24T14:01:07 <dreimark> svgdraw is close to both it misses some of the elbow connection features
125 2012-07-24T14:02:02 <dreimark> and it is not able to read every svg
126 2012-07-24T14:02:28 * dreimark luckily the air condition works
127 2012-07-24T14:04:21 <xiaq> dreimark: has the <(i)frame> solution been proposed before?
128 2012-07-24T14:05:08 <ThomasWaldmann> btw, solving that drawing integration problem is welcome, but not part of your GSOC task
129 2012-07-24T14:05:38 <xiaq> ThomasWaldmann: yeah i'll do ticket stuff first :)
130 2012-07-24T14:23:10 <xiaq> ThomasWaldmann: (re)move your comments within the section of abandoned used_as proposal on render-method EP?
131 2012-07-24T14:36:49 *** dwcramer
132 2012-07-24T14:40:36 <MaikuMori> eSyr: can we have a meeting tomorrow?
133 2012-07-24T14:41:26 <MaikuMori> ThomasWaldmann: are you happy with how storages are right now? If I'm reimplementing them as plugins how much should I try to match the current "system".
134 2012-07-24T14:42:27 <MaikuMori> There seems to be a lot of ABCs when only MutableStorages are ever used. See: http://etherpad.osuosl.org/moin2-PluginSystem-thoughts 83+
135 2012-07-24T14:44:44 <ThomasWaldmann> MaikuMori: well, for first attempt I think you should rather precisely match the current system, otherwise nothing might work...
136 2012-07-24T14:45:30 <ThomasWaldmann> and the different between mutable and immutable storage is rather minor...
137 2012-07-24T14:45:38 <ThomasWaldmann> ...ence*
138 2012-07-24T14:46:37 <MaikuMori> I'm not thinking about changing the actual storage ABCs, just thinking about dropping/mergin some of those ABCs so there is just StorageBase
139 2012-07-24T14:46:58 <MaikuMori> or StoreBase
140 2012-07-24T14:48:27 <ThomasWaldmann> no, keep that as is
141 2012-07-24T14:48:43 <ThomasWaldmann> it is very systematic currently and might be useful even if not currently used
142 2012-07-24T14:50:35 <MaikuMori> Hmm, can do. Just seems a bit Javaish with all those classes
143 2012-07-24T14:52:20 *** kanha_
144 2012-07-24T14:52:31 <eSyr> MaikuMori: нуыю
145 2012-07-24T14:52:33 <eSyr> MaikuMori: yes.
146 2012-07-24T14:53:09 *** kanha
147 2012-07-24T14:53:12 <MaikuMori> Any specific time?
148 2012-07-24T14:53:26 <eSyr> mmm, let me think.
149 2012-07-24T14:53:43 <eSyr> after 16:00 UTC or before 08:00 UTC, i think.
150 2012-07-24T14:54:03 <eSyr> *before 07:00 UTC
151 2012-07-24T14:56:09 <MaikuMori> 7:00 UTC is 4am for me, so I'd prefer after 16:00UTC
152 2012-07-24T14:56:51 <eSyr> MaikuMori: are you not in Latvia currently?
153 2012-07-24T14:56:57 <eSyr> ok, good.
154 2012-07-24T14:56:58 <MaikuMori> I am
155 2012-07-24T14:57:35 <eSyr> i thought Latvia is UTC+0300, hm.
156 2012-07-24T14:58:00 <MaikuMori> Oh yeah -_-', I calculated it the other way around :/
157 2012-07-24T14:58:19 <eSyr> фрю
158 2012-07-24T14:58:22 <eSyr> ah.
159 2012-07-24T14:58:38 <MaikuMori> so before 8:00 then
160 2012-07-24T14:58:44 <eSyr> ok, good.
161 2012-07-24T14:59:24 <eSyr> i'll be near keyboard since about 0400-0500 UTC, so just ping me when you're ready.
162 2012-07-24T14:59:55 <MaikuMori> I should be up just beore 0600 UTC
163 2012-07-24T15:00:09 <eSyr> ok, good.
164 2012-07-24T15:03:23 <eSyr> MaikuMori: btw, afaik last time you've said that you would provide some codereview, have you done one, or just pushed it to bitbucket repo, or?…
165 2012-07-24T15:03:35 <eSyr> *afair
166 2012-07-24T15:04:58 <xiaq> dreimark: i pushed a "just works" itemtype-based ticket implementation to my patch queue https://bitbucket.org/xiaq/itemtype/
167 2012-07-24T15:05:11 <xiaq> dreimark: just `hg pull --mq; hg qgoto ticket`
168 2012-07-24T15:06:16 <xiaq> dreimark: to create an item, just access a nonexistent path name, like how you create anything else. an itemtype selection step is already working
169 2012-07-24T15:07:16 <MaikuMori> eSyr: I crashed my linux that day and then was away from PC during weekend. Working on it today.
170 2012-07-24T15:07:30 <eSyr> oookay.
171 2012-07-24T15:07:43 <xiaq> dreimark: there are still major quirks about the implementation, but i think the "big" things are already there
172 2012-07-24T15:08:25 <MaikuMori> Just got an idea how to make storages almost the same as they are now and at the same time provide the as plugins.
173 2012-07-24T15:12:35 *** dwcramer
174 2012-07-24T15:17:25 *** spy
175 2012-07-24T15:17:40 *** dave_largo
176 2012-07-24T15:26:15 *** spy
177 2012-07-24T16:31:20 *** dwcramer
178 2012-07-24T16:38:35 *** josep2
179 2012-07-24T16:53:11 *** RogerHaase
180 2012-07-24T17:02:43 <spy> xiaq: when you qclone your itemtype repo you then you are working inside 'itemtype', right? Are commits to your main repo also run from there?
181 2012-07-24T17:03:32 <dreimark> MaikuMori can you visualze in some cr your progress?
182 2012-07-24T17:03:46 *** dwcramer
183 2012-07-24T17:04:57 <xiaq> spy: yeah
184 2012-07-24T17:06:12 <spy> xiaq: so it is like a new repo with some redirections
185 2012-07-24T17:06:16 <dreimark> xiaq umts in the train is to instabile to pull
186 2012-07-24T17:06:47 *** dwcramer
187 2012-07-24T17:13:38 <dreimark> xiaq there are more heads now in your itemtype repo
188 2012-07-24T17:14:17 *** xorAxAx
189 2012-07-24T17:15:00 *** xorAxAx
190 2012-07-24T17:17:20 <xiaq> spy: "some redirections"?
191 2012-07-24T17:18:45 *** jaiditya
192 2012-07-24T17:19:49 <spy> xiaq: you commit in your itemtype repo and changes are applied to your main repo
193 2012-07-24T17:35:31 <xiaq> spy: nope, the main repo is not touched
194 2012-07-24T17:36:50 <xiaq> spy: the patch queue is a queue of changesets overlaying on the main repo
195 2012-07-24T17:37:38 <xiaq> spy: in the simplest setup the patch queue is not versioned
196 2012-07-24T17:39:06 <xiaq> spy: you may put it under version control, in which case you get a history of how the patches revolve - you get changesets of changesets :)
197 2012-07-24T17:39:55 <xiaq> spy: patches in a patch queue are basically volatile changesets, and mq provides an extensive set of commands to create that "illusion"
198 2012-07-24T17:40:13 <xiaq> (the illusion that patches are akin to changesets, but volatile)
199 2012-07-24T17:41:46 <xiaq> spy: if you have experience with git's index (aka. staging area) Steve Losh has a really nice mq tutorial http://stevelosh.com/blog/2010/08/a-git-users-guide-to-mercurial-queues/
200 2012-07-24T17:46:54 <xiaq> dreimark: hm, more heads? what's the problem?
201 2012-07-24T18:09:07 <spy> thanks xiaq
202 2012-07-24T18:15:29 *** josep2
203 2012-07-24T18:35:42 *** josep2
204 2012-07-24T18:58:08 *** josep2
205 2012-07-24T19:00:43 *** dwcramer
206 2012-07-24T19:02:49 *** dwcramer
207 2012-07-24T19:32:44 *** josep2
208 2012-07-24T19:49:59 *** greg_f
209 2012-07-24T19:52:46 *** spy
210 2012-07-24T19:52:58 *** spy
211 2012-07-24T20:21:13 *** jaiditya
212 2012-07-24T21:27:01 *** josep2
213 2012-07-24T21:32:56 *** jaiditya
214 2012-07-24T23:15:10 *** dwcramer
215 2012-07-24T23:22:15 *** dave_largo
216 2012-07-24T23:51:14 *** dwcramer
217 2012-07-24T23:52:37 *** jaiditya
218
