1 2012-07-30T00:54:40 *** dwcramer
2 2012-07-30T02:23:02 *** breton
3 2012-07-30T02:44:43 *** bilal
4 2012-07-30T02:45:57 *** bilal
5 2012-07-30T03:08:38 *** Trip_
6 2012-07-30T03:08:54 *** MattMaker
7 2012-07-30T03:12:48 *** MattMaker
8 2012-07-30T03:14:51 *** Trip_
9 2012-07-30T03:25:19 *** MattMaker
10 2012-07-30T03:55:48 <xiaq> waldi: please (un)justify the priority parameter present in RegistryContent.Entry (formerly RegistryItem.Entry)
11 2012-07-30T03:56:35 <xiaq> it is currently unused, and i can't think of a practical use case
12 2012-07-30T03:59:41 <xiaq> if there is a use case, i wonder whether priority is intrinsic to the class or not - if it is intrinsic, i will add another class property and the decorator factory is no longer needed; if not, a decorator factory is needed as is currently done
13 2012-07-30T04:00:03 <xiaq> if there is no use case, i'll directly remove the priority parameter and a decorator factory won't be needed either.
14 2012-07-30T04:00:44 <xiaq> and... this pseudocode :) :
15 2012-07-30T04:00:57 <xiaq> if has_usecase:
16 2012-07-30T04:01:14 <xiaq> if intrinsic(priority):
17 2012-07-30T04:01:29 <xiaq> add_class_property(priority)
18 2012-07-30T04:01:43 <xiaq> remove_decorator_factory() # we can use the decorator directly
19 2012-07-30T04:01:50 <xiaq> else:
20 2012-07-30T04:02:14 <xiaq> pass # current implementation assumes priority is not intrinsic
21 2012-07-30T04:02:22 <xiaq> else:
22 2012-07-30T04:02:41 <xiaq> del priority_parameter of Entry
23 2012-07-30T04:02:48 <xiaq> remove_decorator_factory()
24 2012-07-30T04:05:28 <xiaq> spy: ah sorry. i'll publish my itemtype-based metadata editor patch set asap. i need to see your rebased patch set too. then we can take the best from the 2 implementations, though i doubt them to be mostly identical. :)
25 2012-07-30T04:05:36 *** breton
26 2012-07-30T04:07:26 <xiaq> ThomasWaldmann: http://codereview.appspot.com/6457048 (seems you missed it, i have two patch sets under review in parellel)
27 2012-07-30T04:07:29 <xiaq> dreimark: ^
28 2012-07-30T04:25:15 *** MattMaker
29 2012-07-30T04:31:19 *** MattMaker
30 2012-07-30T05:42:55 *** dwcramer
31 2012-07-30T05:46:02 *** jaiditya
32 2012-07-30T08:05:54 <dreimark> moin
33 2012-07-30T08:37:18 <dreimark> xiaq: done
34 2012-07-30T09:46:29 <waldi> xiaq: priority changes the sorting, it is a priority. and it is tied to the registration, not the class
35 2012-07-30T09:59:23 *** spy
36 2012-07-30T10:35:53 *** greg_f
37 2012-07-30T10:37:54 <xiaq> waldi: yeah. is there a use case?
38 2012-07-30T11:04:53 <waldi> xiaq: use grep? i found on immediately
39 2012-07-30T11:05:30 <waldi> (hint: default_registry.PRIORITY)
40 2012-07-30T11:07:36 <waldi> and there is no decorator
41 2012-07-30T11:08:20 <xiaq> waldi: ah, got it
42 2012-07-30T11:08:27 * xiaq goes to play tennis, be back in ~1.5h
43 2012-07-30T11:24:19 *** xjjk
44 2012-07-30T11:32:15 *** xjjk
45 2012-07-30T12:38:30 <MaikuMori> moin
46 2012-07-30T12:59:23 <dreimark> hi MaikuMori
47 2012-07-30T13:00:37 <dreimark> 12:15 < dreimark> MaikuMori: i remember there was something to review, can you put the url always on the diary page too
48 2012-07-30T13:05:35 <spy> xiaq: http://codereview.appspot.com/6447057
49 2012-07-30T13:06:05 <spy> dreimark: ^
50 2012-07-30T13:13:18 * dreimark looks
51 2012-07-30T13:13:36 <dreimark> spy: have you practical tested it on a fresh clone?
52 2012-07-30T13:15:56 <spy> dreimark: not yet, will try to right now
53 2012-07-30T13:25:20 <dreimark> spy: done
54 2012-07-30T13:25:39 <dreimark> MaikuMori: can you please repeat the url for the cr
55 2012-07-30T13:54:58 <spy> dreimark: tested on a fresh clone, added some fixes to CR
56 2012-07-30T13:55:01 *** jaiditya
57 2012-07-30T14:07:38 *** MattMaker
58 2012-07-30T14:10:13 <spy> dreimark: replied
59 2012-07-30T14:36:02 *** dave_largo
60 2012-07-30T14:46:11 *** spy
61 2012-07-30T15:28:47 *** spy
62 2012-07-30T15:30:24 <dreimark> ThomasWaldmann: spy that was my fault with import json, we have the
63 2012-07-30T15:30:38 <dreimark> simplejson import on some other places
64 2012-07-30T15:35:26 <spy> dreimark: yeah, those places should be replaced with 'import json' too
65 2012-07-30T15:50:57 <jaiditya> Failed test http://dpaste.com/777970/
66 2012-07-30T15:51:19 <jaiditya> how to resolve it ?
67 2012-07-30T15:54:10 <breton> that "print f.readlines()" was inserted after my advice
68 2012-07-30T15:54:36 <jaiditya> yeah
69 2012-07-30T15:55:21 <breton> I'd say "f.seek(1)" works some other way on windows
70 2012-07-30T15:57:03 <jaiditya> dreimark: ^
71 2012-07-30T15:58:20 <jaiditya> waldi: ^
72 2012-07-30T16:00:24 <waldi> jaiditya: why is this print there?
73 2012-07-30T16:01:33 <jaiditya> It is added to see what was in f.readlines
74 2012-07-30T16:01:41 <waldi> yep. please read the documentation
75 2012-07-30T16:01:48 <breton> waldi: because I suggested to insert there for debugging purposes
76 2012-07-30T16:01:55 <jaiditya> I was discussing with breton
77 2012-07-30T16:01:55 <waldi> about file.seek, it tells you why this is incorrect
78 2012-07-30T16:03:48 <breton> and why's that?
79 2012-07-30T16:04:20 <waldi> "If the file is opened in text mode (without 'b'), only offsets returned by tell() are legal. Use of other offsets causes undefined behavior."
80 2012-07-30T16:13:57 <breton> well
81 2012-07-30T16:14:02 <breton> hello to Mr Prashant Kumar
82 2012-07-30T16:14:45 * breton wondering why it can fail
83 2012-07-30T16:15:43 *** spy_
84 2012-07-30T16:16:04 <jaiditya> reading python docs
85 2012-07-30T16:17:00 *** spy
86 2012-07-30T16:17:41 <breton> I don't remember fseek in C having this problem. Well, ok.
87 2012-07-30T16:20:09 <jaiditya> It seems to be a windows specific problem
88 2012-07-30T16:20:23 <waldi> breton: did you actually check the documentation?
89 2012-07-30T16:25:20 *** dwcramer
90 2012-07-30T16:37:37 *** RogerHaase
91 2012-07-30T16:39:20 <breton> yep.
92 2012-07-30T16:39:31 <breton> http://dpaste.org/1VSTC/, lol.
93 2012-07-30T16:40:20 <breton> that's on windows.
94 2012-07-30T16:52:17 <spy_> xiaq: curently itemtype isn't stored in meta, right? When I create a Default item there is no itemtype:default value in its meta.
95 2012-07-30T17:14:54 <xiaq> spy_: yes it's a TODO
96 2012-07-30T17:27:52 *** spy_
97 2012-07-30T17:32:56 *** kanha
98 2012-07-30T17:34:01 *** kanha_
99 2012-07-30T17:54:54 <breton> ThomasWaldmann: mind finishing that ep session?
100 2012-07-30T18:00:08 *** xiaq2
101 2012-07-30T18:03:28 *** xiaq2
102 2012-07-30T18:08:08 <ThomasWaldmann> breton: still at work, likely for ~2h
103 2012-07-30T18:39:43 <breton> ThomasWaldmann: ok. Poke me please, when available.
104 2012-07-30T18:40:03 * breton will write moar tests
105 2012-07-30T18:59:48 *** greg_f
106 2012-07-30T19:22:34 *** spy
107 2012-07-30T19:55:40 *** dave_largo
108 2012-07-30T19:56:25 *** dave_largo
109 2012-07-30T19:56:33 *** jaiditya
110 2012-07-30T20:04:13 <spy> dreimark: you asked about how much work it is to use current itemtype implementation for blog entries. I have rebased my metaeditor implementation. Also prepared meta_forms for blog and blog-entry. Due to some current itemtype limitations (TODOs) they can't be applied right now. So, it will take me a little time to use itemtype for blog.
111 2012-07-30T20:05:48 <spy> I hope to talk with xiaq on metaeditor tomorrow
112 2012-07-30T20:06:44 * spy looks at some comments on 'Search in subitems'
113 2012-07-30T20:21:11 <spy> dreimark: about your comment on the diary page http://moinmo.in/GoogleSoc2012/WikiBlog/2012-07-27. You can see that {{Home}} is transcluded in 'myblog/GSoC' and {{Home/subpage}} is transcluded in 'Home'. That is why you can see 'Home/subpage' in searchresults when you search for 'bla' on the 'myblog' item (http://vps.psviderski.name:8080/+blog/myblog).
114 2012-07-30T20:21:50 <spy> is it a bad behaviour?
115 2012-07-30T20:33:02 <dreimark> spy: i thought it will only search in the given hierarchy
116 2012-07-30T20:33:22 <dreimark> i have not seen that it is transcluded
117 2012-07-30T20:34:31 <dreimark> spy: can you split the work on itemtype with xiaq and work on that together?
118 2012-07-30T20:40:13 <dreimark> why i searched that was that i wanted to see if i don't find something which is not in the blog
119 2012-07-30T20:48:12 <spy> dreimark: think so, will talk to xiaq about itemtype
120 2012-07-30T20:56:00 <dreimark> ok
121 2012-07-30T21:12:12 *** jaiditya
122 2012-07-30T21:12:22 <ThomasWaldmann> re
123 2012-07-30T21:12:59 <ThomasWaldmann> breton: ok, i am partially here now :)
124 2012-07-30T21:24:16 <breton> ThomasWaldmann:
125 2012-07-30T21:42:26 *** spy
126 2012-07-30T21:42:29 *** spy_
127 2012-07-30T21:43:06 <ThomasWaldmann> we need some better ideas / additional input for branch/merge/sync, see http://etherpad.osuosl.org/moin2-bms 176 +/-
128 2012-07-30T21:43:14 <ThomasWaldmann> waldi: ^
129 2012-07-30T21:43:32 <ThomasWaldmann> eSyr: ^
130 2012-07-30T21:43:39 <ThomasWaldmann> eSyr-ng: ^
131 2012-07-30T21:43:52 <ThomasWaldmann> RogerHaase: ^
132 2012-07-30T21:44:06 <ThomasWaldmann> xorAxAx: ^ :)
133 2012-07-30T22:05:40 * ThomasWaldmann is rather tired. if you have an idea or question, leave it on the pad.
134 2012-07-30T22:22:44 <breton> err, there is difference between #channel and ##channel?
135 2012-07-30T22:33:06 <breton> oh, ok.
136 2012-07-30T22:54:01 <MattMaker> it seems kind o
137 f odd that http://moinmo.in/HelpOnInstalling?
138 action=show handles redirecting by instead telling you "This page redirects to page "InstallDocs"", but not doing
139 so (and thus not showing you the information you wanted) unt
140 il after you click the "Clear message" link... if it occurs to you to do so. I assumed at first that redirecting was broken.
141 2012-07-30T22:56:06 *** jaiditya
142 2012-07-30T22:56:31 <MattMaker> the smallest possible
143 suggested change that would address this: in 'This page redirects to page "X"', X should be a clickable link.
144 2012-07-30T22:59:38 <MattMaker> also, as a Texan, I am delighted/flattered that (as we see on http://moinmo.in/MoinMoinHosting) the rest of the world often thinks of my home state of Texas as its own country, rather than as a part of the United States. :)
145 2012-07-30T23:05:21 <ThomasWaldmann> MattMaker: it is not redirecting if some action is explicitly given
146 2012-07-30T23:05:38 <ThomasWaldmann> otherwise you'ld have no chance to do something there
147 2012-07-30T23:06:15 <MattMaker> entering the URI http://moinmo.in/HelpOnInstalling produces this same result
148 2012-07-30T23:06:34 <ThomasWaldmann> haha about texas :)
149 2012-07-30T23:06:38 <MattMaker> :)
150 2012-07-30T23:07:21 <ThomasWaldmann> ah, double redirect...
151 2012-07-30T23:08:12 <ThomasWaldmann> well, looks strange, but it would be worse without that provision
152 2012-07-30T23:08:12 *** dave_largo
153 2012-07-30T23:08:58 * ThomasWaldmann listens to di.fm, made him more awake again :)
154 2012-07-30T23:09:14 *** spy_
155 2012-07-30T23:11:32 *** kanha
156 2012-07-30T23:11:47 *** kanha
157 2012-07-30T23:14:27 <MattMaker> in (pedantic) English
158 , "This page redirects to" may be uncle
159 ar about when or if the redi
160 recting will actually occur (or did occu
161 r). I might say 'This page will redirect to
162 page "X". Click to continue:' or 'This page will redirect to
163 page
164 "X" when you clear this message'.
165 2012-07-30T23:15:22 <ThomasWaldmann> it depends whether it will redirect or not :)
166 2012-07-30T23:15:23 <MattMaker> not technically incorrect, but it left it open to my interpretation of 'This page sometimes redirects to "X", but for some reason did not this time.'
167 2012-07-30T23:15:36 <MattMaker> yes
168 2012-07-30T23:16:30 <ThomasWaldmann> aside from the issue of how to say best, we also have the issue that if we change english phrasing, we kill all translations...
169 2012-07-30T23:16:52 <MattMaker> hmm, 'Clear message' actually is the link to where we want t
170 o go
171
172 2012-07-30T23:17:00 <MattMaker> but that wasn't... clear
173 2012-07-30T23:17:02 <MattMaker> :D
174 2012-07-30T23:17:11 <ThomasWaldmann> heh
175 2012-07-30T23:17:20 <MattMaker> re changing English: ah. I can see how that would be a problem
176 2012-07-30T23:18:11 <ThomasWaldmann> and the other problem is our uber active translators :P
177 2012-07-30T23:18:20 <MattMaker> in This page redirects to page "InstallDocs-1.9", is there a reason that "InstallDocs-1.9" is not a link?
178 2012-07-30T23:18:32 <MattMaker> that would solve my complaint
179 2012-07-30T23:18:55 <MattMaker> not that it's a huge deal, but I like to comment when I notice such t
180 hings
181 2012-07-30T23:19:34 <ThomasWaldmann> well, would make almost as much sense as the other link
182 2012-07-30T23:20:00 <ThomasWaldmann> (except that you get redirected there anyway, sometimes)
183 2012-07-30T23:20:23 <ThomasWaldmann> but changing it to a link would also change original text likely
184 2012-07-30T23:20:35 <MattMaker> I understand now that MoinMoin *is* displaying the page I asked for, and the page *is* empty, because of the redirect. I interpreted the empty content as an error.
185 2012-07-30T23:21:07 <MattMaker> right above that message, it says Redirected from page "HelpOnInstalling", and that one is a link
186 2012-07-30T23:21:19 <MattMaker> making me feel I can go back, but not forward
187 2012-07-30T23:23:22 <MattMaker> maybe the Computer Science answer would be to detect the double redirect situation and not stop in the middle
188 2012-07-30T23:23:22 <ThomasWaldmann> yup
189 2012-07-30T23:24:00 <ThomasWaldmann> MattMaker: that can lead to endless redirect if there is a loop :)
190 2012-07-30T23:24:44 <MattMaker> so action=show would notice that the page is a redirect, and the user came from a redirect... hmm, well you could also check for a loop of size 0-2 :)
191 2012-07-30T23:25:26 <MattMaker> I think the endless redirect would still be preferable to stopping on the second redirected page
192 2012-07-30T23:26:08 <MattMaker> does transcluded (sp?) content check for loops?
193 2012-07-30T23:31:46 <ThomasWaldmann> in moin2 yes
194 2012-07-30T23:32:14 <ThomasWaldmann> don't remember for moin1, but include was somehow hackish there anyway
