1 2012-08-01T00:08:05 *** grzywacz
2 2012-08-01T00:08:59 *** RogerHaase
3 2012-08-01T00:11:11 *** spy
4 2012-08-01T00:11:46 *** spy
5 2012-08-01T01:04:46 *** dwcramer
6 2012-08-01T01:17:16 *** dwcramer
7 2012-08-01T01:30:53 *** dwcramer
8 2012-08-01T04:07:46 *** dwcramer
9 2012-08-01T04:13:54 *** xiaq_
10 2012-08-01T04:13:54 *** xiaq_
11 2012-08-01T04:44:13 *** xiaq2
12 2012-08-01T06:14:47 *** dwcramer
13 2012-08-01T06:30:23 *** dwcramer
14 2012-08-01T07:37:58 <dreimark> moin
15 2012-08-01T07:43:08 <dreimark> ThomasWaldmann: i think you want to see the result where something is transcluded. usually one is interested in the whole context. May be set the transclusion marker for the object and highlight it there.
16 2012-08-01T07:44:16 <dreimark> hmm, have we the opposite of transcluded on the item itselfs, as this is transcluded_in?
17 2012-08-01T07:44:43 <dreimark> then we can look for the item and just add all where it is used
18 2012-08-01T10:17:16 *** grzywacz
19 2012-08-01T10:44:46 <ThomasWaldmann> moin
20 2012-08-01T11:10:23 *** greg_f
21 2012-08-01T12:25:30 *** dwcramer
22 2012-08-01T13:16:00 *** dwcramer
23 2012-08-01T13:27:21 * dreimark silent here
24 2012-08-01T13:57:24 <dreimark> MaikuMori: have you replied on the cr already?
25 2012-08-01T14:06:07 <MaikuMori> not yet just quickly looked over them
26 2012-08-01T14:35:49 *** dwcramer
27 2012-08-01T14:53:35 *** dave_largo
28 2012-08-01T14:54:57 *** dwcramer
29 2012-08-01T15:02:00 <MaikuMori> ThomasWaldmann: replied to both codereview, both commets and new code.
30 2012-08-01T15:02:41 <MaikuMori> Is it worth rewriting the themes implementation a bit to make it easier to understand and remove some of the flask-themes code which is still there.
31 2012-08-01T15:07:13 *** dwcramer
32 2012-08-01T15:07:36 <ThomasWaldmann> well, as i already suggested, the theme plugin code should be clearer and better commented, because the different cases are hard to understand otherwise. armin ronacher also suggested using that special call (i also already mentioned that) instead of flask themes.
33 2012-08-01T15:08:46 <MaikuMori> That function is being called internally, I could write my own code and call it manually and maybe make it simpler.
34 2012-08-01T15:09:39 <ThomasWaldmann> it is? do you have a url?
35 2012-08-01T15:10:03 <MaikuMori> I was looking at it before, I think it was. Lemme try to find it again
36 2012-08-01T15:12:17 <MaikuMori> Hmm it's called in flasks _render method
37 2012-08-01T15:13:08 <MaikuMori> actually render_template
38 2012-08-01T15:15:44 <MaikuMori> https://github.com/mitsuhiko/flask/blob/master/flask/templating.py#L112
39 2012-08-01T15:16:40 <MaikuMori> And since we call that method anyway it does get called.
40 2012-08-01T15:20:22 <MaikuMori> It's just the way flask-themes was coded is a bit long, but once you understand what's happening it more or less makes sense. Then again there is extra stuff which will probably will never be used (such as those 2 use cases I described in CR) and some things can be made shorter because the code is universal and MoinMoin structure is just one case it describes (can get rid of the other stuff).
41 2012-08-01T15:24:02 <ThomasWaldmann> well, i guess it would only make sense for theming if it is called with a list
42 2012-08-01T15:25:11 <ThomasWaldmann> (render_template)
43 2012-08-01T15:25:41 <ThomasWaldmann> and I am happy with any solution that a) works b) has well-documented, maintainable code
44 2012-08-01T15:27:32 <ThomasWaldmann> as you might have seen, i tried to fix flask-themes for recent flasks and it was just confusing me. i got something that worked, but a pull request was rejected because author wanted another fix. and it is still unfixed in flask-themes upstream repo (dead since 2011-07).
45 2012-08-01T15:32:08 <MaikuMori> ThomasWaldmann: Did you look at both CRs
46 2012-08-01T15:32:45 <MaikuMori> I'll take a look at blueprints while you're at it.
47 2012-08-01T15:32:59 <MaikuMori> Still haven't got that priority list for each plugin type
48 2012-08-01T15:33:41 <MaikuMori> (from eSyr) Maybe you have some ideas which plugin types I should try to implement first.
49 2012-08-01T15:43:26 * ThomasWaldmann just filed a new "issue" to flask-themes
50 2012-08-01T15:44:00 <ThomasWaldmann> where's that (unordered) list?
51 2012-08-01T15:49:13 *** dwcramer
52 2012-08-01T15:54:18 <MaikuMori> Ep
53 2012-08-01T15:54:22 <MaikuMori> I'll find the line
54 2012-08-01T15:54:58 <MaikuMori> Should be line 22, maybe something is left out
55 2012-08-01T16:00:19 <ThomasWaldmann> if you continue NOT giving urls when I need to look at something, I might get tired of looking stuff up all the time...
56 2012-08-01T16:00:49 <MaikuMori> Ah sorry, http://etherpad.osuosl.org/moin2-PluginSystem
57 2012-08-01T16:05:08 <ThomasWaldmann> see EP
58 2012-08-01T16:05:44 <ThomasWaldmann> also, did you practically try to make some plugin for what you already have? like make a package, install it, configure it, load it, test it...
59 2012-08-01T16:06:21 <ThomasWaldmann> eSyr-ng: eSyr ^
60 2012-08-01T16:08:50 <ThomasWaldmann> MaikuMori: ^ :)
61 2012-08-01T16:10:00 <ThomasWaldmann> MaikuMori: btw, calendar still looks rather thinly populated
62 2012-08-01T16:12:32 <MaikuMori> There is a plugin, does everything except configuartion because at the moment there are no plugins which need it
63 2012-08-01T16:14:06 <MaikuMori> Regarding translations, they scare me a bit, right now I think they should be handled by plugin code
64 2012-08-01T16:14:58 <MaikuMori> Plugins can read current locale/language from config and then check if they have translation files for it.
65 2012-08-01T16:17:29 <ThomasWaldmann> well, yes, that's bit about researching how to do it best and propose that way to plugin authors so that not every single developer has to invent his own (different?) way to deal with that
66 2012-08-01T16:17:52 <MaikuMori> Could provide helper functions
67 2012-08-01T16:18:15 <ThomasWaldmann> docs & helpers would maybe be enough
68 2012-08-01T16:18:54 <ThomasWaldmann> if you have questions about i18n code (gettext, (flask-)babel), i can maybe help a little.
69 2012-08-01T16:19:14 <MaikuMori> I've seen other projects use some sort list of translations and then plugins patch into them, but it has it's own problem like conflicts, etc.
70 2012-08-01T16:19:59 <ThomasWaldmann> btw, i recently had an idea to just use templating for .js to solve the translation issue there.
71 2012-08-01T16:20:04 <MaikuMori> The up side is that you can have plugin which only provides translation for other plugins, but I believe that should be handled in plugin repo consulting plugin author
72 2012-08-01T16:20:14 <ThomasWaldmann> have to look at that again, not sure if i committed it.
73 2012-08-01T16:20:37 <MaikuMori> You don't like JS compilers?
74 2012-08-01T16:21:09 <MaikuMori> There are compilers which can substitute placeholders which language strings
75 2012-08-01T16:21:23 <ThomasWaldmann> yes, i agree, translations should get managed by code maintainers, so it is a bit simpler to manage for us
76 2012-08-01T16:22:06 <ThomasWaldmann> MaikuMori: i18n is a dynamic thing. it is not just like you configure "german" and then everything is in german for everybody.
77 2012-08-01T16:22:31 <ThomasWaldmann> user can setup his desired language in his profile and then moin needs to switch depending on the user.
78 2012-08-01T16:23:13 *** RogerHaase
79 2012-08-01T16:23:25 <MaikuMori> What I meant is that you end up with combination of JS files for each supported language and js helper functions (to help dealing with different forms).
80 2012-08-01T16:23:34 * ThomasWaldmann is not sure about the best solution either, but I know the requirements :)
81 2012-08-01T16:23:55 <MaikuMori> Then based on users settings you just serve the right js file
82 2012-08-01T16:24:29 <ThomasWaldmann> that might work also. as i said: research needed and good guidelines as output
83 2012-08-01T16:25:39 <MaikuMori> I remember quickly researching it several years ago for my own project, didn't implement anything though.
84 2012-08-01T16:26:36 <ThomasWaldmann> yeah, that's exactly the problem if every developer needs to do that
85 2012-08-01T16:26:55 <ThomasWaldmann> for project maybe not avoidable, but we can save plugins devs from it maybe
86 2012-08-01T16:26:56 <MaikuMori> Agree
87 2012-08-01T16:27:52 <dreimark> MaikuMori: is there a pypi example plugin already to try ?
88 2012-08-01T16:28:28 <MaikuMori> It's the very same that is in contrib directory
89 2012-08-01T16:28:47 <MaikuMori> haven't added anything to it but it does get loaded each time in my dev setup
90 2012-08-01T16:29:10 <dreimark> so you have a dist package from it?
91 2012-08-01T16:29:17 <MaikuMori> Though it does nothing
92 2012-08-01T16:29:41 <MaikuMori> Can make one if you want
93 2012-08-01T16:29:45 <dreimark> can it be done for an item like anywikidraw?
94 2012-08-01T16:29:55 <dreimark> as plugin?
95 2012-08-01T16:30:00 <MaikuMori> items aren't implemented yet
96 2012-08-01T16:30:07 <MaikuMori> just themes and stores at the moment
97 2012-08-01T16:30:16 <dreimark> I suggest to do that next
98 2012-08-01T16:30:39 <MaikuMori> going to do blueprints next because I think they should be rather easy to do
99 2012-08-01T16:30:39 <dreimark> because that is what I guess usually user want to extend
100 2012-08-01T16:30:56 <MaikuMori> I'll check ThomasWaldmann recomendations and items after that.
101 2012-08-01T16:31:16 <MaikuMori> Well Thomas mentioned auth modules
102 2012-08-01T16:32:00 <dreimark> ok
103 2012-08-01T16:32:15 <MaikuMori> Which makes sense since I usually have problems integrating different apps together (the auth part that is).
104 2012-08-01T16:32:35 <xiaq> ThomasWaldmann: care to look at my pull request? https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/57/registry-code-cleanup-and-fix
105 2012-08-01T16:33:33 <xiaq> ThomasWaldmann: and... this cr: http://codereview.appspot.com/6457048
106 2012-08-01T16:34:21 <dreimark> MaikuMori: yes but item plugin shows that the concept works because they need different plugin types done together. you need view, template, item (different meta)
107 2012-08-01T16:34:48 <dreimark> but ok, i agree auth is more important
108 2012-08-01T16:36:04 <MaikuMori> dreimark: it's good feedback at least now I have a short list :)
109 2012-08-01T16:40:02 <dreimark> bbl
110 2012-08-01T17:35:57 *** kanha_
111 2012-08-01T17:36:37 *** kanha
112 2012-08-01T18:00:41 <ThomasWaldmann> dreimark: MaikuMori: the item stuff is currently a bit unstable (considering render-method/view-method stuff), so i don't think a 3rd person should also work on that
113 2012-08-01T18:01:33 <MaikuMori> Got it, I think blueprints will already provide interesting material for plugins
114 2012-08-01T18:22:30 * xiaq calls for ThomasWaldmann to process the pull request
115 2012-08-01T18:45:07 <ThomasWaldmann> xiaq: the pull request is the stuff as reviewed with final fixes after last review?
116 2012-08-01T18:45:37 <xiaq> ThomasWaldmann: yes, should be identical to patch set 4 of http://codereview.appspot.com/6453060/
117 2012-08-01T18:45:53 <ThomasWaldmann> did you check the test coverage for that stuff?
118 2012-08-01T18:48:46 <xiaq> ThomasWaldmann: no regression with `make test`
119 2012-08-01T18:48:58 <ThomasWaldmann> and whether the wiki still finds the right converters for the different contenttypes?
120 2012-08-01T18:49:08 <ThomasWaldmann> that was not the question :)
121 2012-08-01T18:49:26 <ThomasWaldmann> (if there are no or few tests, you rarely have regressions :)
122 2012-08-01T18:49:48 <ThomasWaldmann> and you better not assume complete coverage for moin
123 2012-08-01T18:50:14 <xiaq> hm, seems no test case for converter registry yet
124 2012-08-01T18:51:48 <ThomasWaldmann> then it would be great if you add a few simple tests based on the old code, make them succeed there (as far as possible :) and also on your new code
125 2012-08-01T18:52:38 <xiaq> ThomasWaldmann: like testClassFinder in test_Item.py. shouldn't be too hard...
126 2012-08-01T18:52:50 <ThomasWaldmann> no need to be bug-compatible, of course, if it definitely is a bug
127 2012-08-01T18:53:51 <ThomasWaldmann> and talk to spy about agreeing on how to handle stuff
128 2012-08-01T18:55:04 <xiaq> ThomasWaldmann: alright
129 2012-08-01T18:56:06 <RogerHaase> ThomasWaldmann: fix for transcluded csv and A items ready for review: http://codereview.appspot.com/6427059/
130 2012-08-01T18:56:40 <RogerHaase> ThomasWaldmann: a test page for above: http://www.digitalrockart.org/moin2/TestAllTranscludableItems
131 2012-08-01T19:06:22 * ThomasWaldmann needs to go to a LUG meeting now, but I guess I might have some time after dinner for more reviews.
132 2012-08-01T19:10:03 <ThomasWaldmann> RogerHaase: if you can explain it a bit (on CR or even better with src comments), my review might be faster for such stuff :)
133 2012-08-01T19:10:12 * ThomasWaldmann away
134 2012-08-01T19:17:26 *** greg_f
135 2012-08-01T19:32:24 <xiaq> hm, is there a better way to write `import MoinMoin.converter.html_in, MoinMoin.converter.moinwiki_in, MoinMoin.converter.pygments_in`?
136 2012-08-01T19:38:37 <xiaq> http://docs.python.org/reference/simple_stmts.html#the-import-statement a submodule name seems not qualified for an "identifier"...
137 2012-08-01T19:41:15 * xiaq goes to bed, gn
138 2012-08-01T20:27:56 * dreimark too somehow i am very tired
139 2012-08-01T21:29:07 *** dwcramer
140 2012-08-01T21:51:10 *** MattMaker
141 2012-08-01T21:56:09 *** dwcramer
142 2012-08-01T22:26:17 *** dwcramer
143 2012-08-01T22:33:28 *** dwcramer
144 2012-08-01T23:03:32 *** dwcramer
145 2012-08-01T23:11:27 *** dave_largo
146 2012-08-01T23:15:03 *** grzywacz
147 2012-08-01T23:40:11 *** dcramer_
148 2012-08-01T23:42:19 *** dwcramer
149
