1 2012-08-08T00:06:46 *** jaiditya
2 2012-08-08T00:46:41 *** RogerHaase
3 2012-08-08T01:31:02 *** dwcramer
4 2012-08-08T04:11:22 *** dwcramer
5 2012-08-08T04:23:53 *** dwcramer
6 2012-08-08T04:41:12 *** jaiditya
7 2012-08-08T04:49:14 *** dwcramer
8 2012-08-08T05:21:06 *** MattMaker
9 2012-08-08T05:21:23 *** MattMaker
10 2012-08-08T05:35:51 *** bilal
11 2012-08-08T05:37:03 *** bilal
12 2012-08-08T05:52:37 <xiaq> ThomasWaldmann: http://codereview.appspot.com/6459047/ http://codereview.appspot.com/6449094/ http://codereview.appspot.com/6458084/ http://codereview.appspot.com/6446091/ (seems emails weren't sufficient...)
13 2012-08-08T05:52:42 <xiaq> dreimark: ^
14 2012-08-08T05:52:55 <xiaq> spy_: you might be interested too ^^
15 2012-08-08T06:00:49 <xiaq> ThomasWaldmann: http://codereview.appspot.com/6457091/
16 2012-08-08T06:00:50 <xiaq> dreimark: ^
17 2012-08-08T06:00:52 <xiaq> spy_: ^
18 2012-08-08T06:00:56 *** xiaq
19 2012-08-08T06:02:02 *** xiaq
20 2012-08-08T06:02:18 *** xiaq
21 2012-08-08T06:03:07 *** xiaq
22 2012-08-08T08:56:58 <dreimark> moin
23 2012-08-08T08:57:01 * dreimark looks
24 2012-08-08T09:32:38 * xiaq saw the replies :)
25 2012-08-08T10:11:11 *** grzywacz
26 2012-08-08T10:11:11 *** grzywacz
27 2012-08-08T10:16:13 *** kanha_
28 2012-08-08T10:16:40 *** kanha
29 2012-08-08T11:01:36 *** DasIch-m
30 2012-08-08T11:06:02 <breton> ThomasWaldmann: saw the replies, but was working on somethin else. Will review and comment later.
31 2012-08-08T11:07:21 <breton> ThomasWaldmann: please review http://codereview.appspot.com/6446100. The code is not finished and doesn't even work yet.
32 2012-08-08T11:07:54 <breton> also, was without internet at night. Will post a blog entry a bit later today.
33 2012-08-08T11:08:12 <breton> ThomasWaldmann: so only general comments please.
34 2012-08-08T11:11:13 <spy_> xiaq: what are your future plans on the +index after cleanup?
35 2012-08-08T11:11:40 *** greg_f
36 2012-08-08T11:12:48 <xiaq> spy_: "detailed view" and after that itemtype-specific metadata keys
37 2012-08-08T11:17:37 <spy_> xiaq: what is a "detailed view"? Do you consider to override it for itemtype-specific items? E.g. tickets/blogposts listing/management
38 2012-08-08T11:18:07 <xiaq> spy_: exposing more metadata properties - summary, tags, maybe more in future
39 2012-08-08T11:19:34 <xiaq> there are 2 approaches to make an itemtype-specific index, either make the index smarter to bring in itemtype-specific keys automagically, or let the itemtype provide some macro to guide the +index view (like data_editor macro contenttypes provide)
40 2012-08-08T11:19:45 * xiaq goes out to play tennis, be back in ~1.5h
41 2012-08-08T11:53:17 <spy_> xiaq: I would like to render different *_index.html templates depending on itemtype. Those *_index templates extend index.html and are able to override some blocks. Wrap the parts to be overrided in the index.html template into blocks. This way we can adapt the +index to manage a blog. E.g. override popup newitem window to create new blog posts, extend items listing to view published/draft posts,...
42 2012-08-08T12:41:17 <xiaq> spy_: yes that's a possible approach too
43 2012-08-08T12:43:34 *** ebo^
44 2012-08-08T13:28:36 *** dwcramer
45 2012-08-08T13:30:41 <spy_> do we want to have an advanced threaded commenting system in addition to simple "Discussion" pages? Something like mediawiki has http://www.mediawiki.org/wiki/Talk:MediaWiki or Trac comments for issues. Each comment is an independent wiki markup item. It is needed for Blog and Ticket projects. Do we have any developments/ideas/suggestions on this subject? There is also macro-based comments extension for moin1.9 http://code.google.c
46 2012-08-08T13:31:16 <spy_> dreimark: ThomasWaldmann: xiaq: ^^
47 2012-08-08T14:01:42 *** dwcramer
48 2012-08-08T14:19:16 <dreimark> spy_: in 1.9 it is {{{#!wiki comment ... }}}
49 2012-08-08T14:19:29 <dreimark> and it is used inside normal markup
50 2012-08-08T14:20:27 <dreimark> http://moinmo.in/HelpOnMoinWikiSyntax
51 2012-08-08T14:20:36 <dreimark> see comments link to activate them
52 2012-08-08T14:21:00 <dreimark> on bottom of page
53 2012-08-08T14:21:24 <dreimark> this is a different one
54 2012-08-08T14:22:14 <dreimark> another example we often use is the bitbucket issue tracker
55 2012-08-08T15:21:03 <spy_> dreimark: so, you want to say that ordinary blog users would like to modify blog-post item and append {{{#!wiki comment ... }}} in order to comment a post? I doubt very much, that is why we need to provide a simple and clear commenting system for any user of a blog.
56 2012-08-08T15:21:17 <dreimark> spy_: no, they don't
57 2012-08-08T15:21:41 <dreimark> i just wated to describe what the builtin comment function is
58 2012-08-08T15:22:33 <dreimark> what you want is an subitem which preferable is only editable by its creator and an admin
59 2012-08-08T15:22:51 <dreimark> or the blog moderator
60 2012-08-08T15:23:43 <dreimark> if the creator is not editing a comment you want just a new subitem added
61 2012-08-08T15:23:58 <dreimark> it is quite similar to bitbucket workflow
62 2012-08-08T15:24:48 *** ebo^
63 2012-08-08T15:37:53 <spy_> yes, but another approach is to use only one subitem for all comments. Append or edit some parts of it. In this case it is more difficult to monitor access right.
64 2012-08-08T15:49:52 *** jaiditya
65 2012-08-08T15:55:14 <spy_> dreimark: could ACL be applied to all items matched specified regex?
66 2012-08-08T16:05:40 <dreimark> why do you want that?
67 2012-08-08T16:06:07 <dreimark> currently you can enable hacl then rights are inherited from item to subitem
68 2012-08-08T16:06:36 <dreimark> btw. append has xiaq resolved
69 2012-08-08T16:06:52 <dreimark> edit some parts sounds like section editing, which we haven't yet
70 2012-08-08T16:13:57 <spy_> though separate comment items is more flexible approach. Suppose comments have names that match a particular regex, we could specify ACL for all comments in the configuration file.
71 2012-08-08T16:14:08 *** jaiditya|2
72 2012-08-08T16:15:23 <spy_> or apply it to evert newly created comment
73 2012-08-08T16:16:01 <dreimark> this is problematic
74 2012-08-08T16:16:11 <dreimark> i think we need the acl on the ite,
75 2012-08-08T16:16:14 <dreimark> item
76 2012-08-08T16:16:18 *** jaiditya
77 2012-08-08T16:16:40 <dreimark> otherwise a move or copy will change its effective rights
78 2012-08-08T16:19:06 <spy_> uh, okay. There will no problem if if it is applied when the item is created. Another question is where to store all those comments of an item.
79 2012-08-08T16:21:08 <spy_> rather what name is assigned to a comment
80 2012-08-08T16:21:34 <dreimark> for now i think we have to use subitems. may be a a prefix comment and some rule how they should be displayed also a meta key
81 2012-08-08T16:21:53 <spy_> currently there is no hierarchy control in moin2, right?
82 2012-08-08T16:22:09 <dreimark> only items/subitems/subitems
83 2012-08-08T16:22:36 <spy_> so if I rename my blog item, then all my subitem(posts) will be renamed accordingly?
84 2012-08-08T16:24:57 <dreimark> yes
85 2012-08-08T16:25:15 <spy_> great :)
86 2012-08-08T16:25:35 <jaiditya|2> dreimark: https://dl.dropbox.com/u/43518659/index-menus.jpg
87 2012-08-08T16:25:55 *** jaiditya|2
88 2012-08-08T16:27:44 <dreimark> jaiditya: :)
89 2012-08-08T16:32:35 <xiaq> spy_: i have implemented an adhoc comment system in the ticket system
90 2012-08-08T16:33:19 <xiaq> spy_: it's basically '{user} said on <<DateTime({time})>>: {msg}'.format(...)
91 2012-08-08T16:33:28 <xiaq> appended to the markup data
92 2012-08-08T16:33:58 <spy_> xiaq: do you think it is powerfull enough for tickets?
93 2012-08-08T16:34:12 <xiaq> spy_: it's usable, but not good enough imo
94 2012-08-08T16:34:33 <xiaq> spy_: one problem is that i haven't found a way to do i18n on the autogenerated text
95 2012-08-08T16:34:54 <xiaq> spy_: the "said on" - and some languages might have a preference to place the time before the commentor's name
96 2012-08-08T16:35:24 <xiaq> i would prefer make each comment a single item
97 2012-08-08T16:36:34 <xiaq> you no longer need to put {user} and {time} into the data - it's kept in the meta
98 2012-08-08T16:37:17 <xiaq> you can easily modify a single comment (like stackoverflow) and keep track of its history (stackoverflow shows an "edited" icon when some comment has >1 revisions)
99 2012-08-08T16:38:41 <xiaq> one minor drawback is that when you search for some text that appears in a message, whoosh brings you the message item instead of the "mainstream" item - but that can be solved in the ui layer
100 2012-08-08T16:38:52 <spy_> yes, for time could be used PTIME (publication time) meta
101 2012-08-08T16:40:16 <spy_> I've also introduced +search/<item_name> view to search subitems. That could be reused for that too.
102 2012-08-08T16:43:05 <spy_> will describe some ideas/possible approaches on commenting system on etherpad soon
103 2012-08-08T16:43:29 <xiaq> spy_: which ep? blog?
104 2012-08-08T16:43:48 <spy_> create new
105 2012-08-08T16:44:24 <spy_> bbl
106 2012-08-08T16:44:56 <xiaq> dreimark: http://codereview.appspot.com/6446091/ (Reference widget) updated
107 2012-08-08T16:44:58 <xiaq> ThomasWaldmann: ^
108 2012-08-08T17:12:44 <jaiditya> dreimark: not able to comment on issue https://bitbucket.org/thomaswaldmann/moin-2.0/issue/232/cant-create-item
109 2012-08-08T17:13:08 <jaiditya> issue is resolved changeset# https://bitbucket.org/Jaiditya/moin-2.0/changeset/669779fc2fb19fc19c22ef407fb906a041fdbc5c
110 2012-08-08T17:18:25 <dreimark> ThomasWaldmann: ^
111 2012-08-08T17:18:29 <dreimark> jaiditya: :)
112 2012-08-08T17:24:22 <dreimark> bbl
113 2012-08-08T17:26:33 *** RogerHaase
114 2012-08-08T17:38:38 <xiaq> when trying to convert index code to use whoosh for filtering
115 2012-08-08T17:39:10 <xiaq> it turn out to be a nontrivial task unless we agree on one behavior change...
116 2012-08-08T17:45:36 <xiaq> currently the filtering is done after flatenning the index
117 2012-08-08T17:45:55 *** kanha
118 2012-08-08T17:46:00 *** kanha_
119 2012-08-08T17:46:34 <xiaq> that is, if you have lorem (contenttype=a) and lorem/ipsum (contenttype=b)
120 2012-08-08T17:46:57 <xiaq> and when filtering for contenttype=b, lorem won't be included
121 2012-08-08T17:47:41 <xiaq> if we rely on whoosh to do filtering, we have to do this alongside searching, that is before flatenning the index
122 2012-08-08T17:48:32 <xiaq> we can fix that by applying one more pass of filtering after flatenning the index, but that defeats the purpose of using whoosh...
123 2012-08-08T17:49:24 <xiaq> ps. by "flatenning" i mean to "fold" indirect children like lorem/ipsum/foo/bar/quux into corresponding direct children like lorem
124 2012-08-08T17:49:46 <xiaq> and create a dummy item (with contenttype=application/x.nonexistent) when the direct child doesn't exist yet
125 2012-08-08T18:03:49 <xiaq> dumped to ep http://etherpad.osuosl.org/moin-rich-index line 54
126 2012-08-08T18:03:53 <xiaq> ThomasWaldmann: ^
127 2012-08-08T18:03:55 <xiaq> dreimark: ^
128 2012-08-08T18:03:57 <xiaq> spy_: ^
129 2012-08-08T18:33:53 *** breton
130 2012-08-08T18:34:54 *** breton
131 2012-08-08T18:44:32 <dreimark> xiaq: i look later i'm currently at pyuser group meeting
132 2012-08-08T18:45:26 *** breton
133 2012-08-08T18:45:33 *** breton
134 2012-08-08T19:32:49 *** kanha
135 2012-08-08T19:33:48 *** kanha_
136 2012-08-08T19:41:02 *** kanha_
137 2012-08-08T19:42:26 *** kanha
138 2012-08-08T19:49:33 *** greg_f
139 2012-08-08T20:39:20 *** grzywacz
140 2012-08-08T21:22:47 *** MattMaker
141 2012-08-08T21:37:13 *** MattMaker
142
