1 2012-08-10T00:16:45 <dreimark> gn
2 2012-08-10T00:25:23 *** RogerHaase
3 2012-08-10T00:31:14 <breton> dreimark: reviews on patchsets 1 and 2 would be appreciated too.
4 2012-08-10T03:07:21 <xiaq> ThomasWaldmann: since related cr's are all ok, accept my pull req?
5 2012-08-10T03:58:09 *** MattMaker
6 2012-08-10T04:03:55 *** jaiditya
7 2012-08-10T08:06:30 *** MattMaker
8 2012-08-10T08:13:20 *** MattMaker
9 2012-08-10T08:18:10 *** MattMaker
10 2012-08-10T08:32:33 *** MattMaker
11 2012-08-10T08:36:44 *** MattMaker
12 2012-08-10T08:48:53 *** MattMaker
13 2012-08-10T08:49:54 *** MattMaker
14 2012-08-10T09:19:49 *** MattMaker
15 2012-08-10T09:32:04 *** MattMaker
16 2012-08-10T10:22:25 <dreimark> moin
17 2012-08-10T11:23:12 *** greg_f
18 2012-08-10T11:45:08 <ThomasWaldmann> moin
19 2012-08-10T12:16:45 <ThomasWaldmann> xiaq: i still have on CR to do...
20 2012-08-10T12:16:49 <ThomasWaldmann> one*
21 2012-08-10T12:18:21 <ThomasWaldmann> xiaq: http://codereview.appspot.com/6450075/ is that the stuff we agreed to do later?
22 2012-08-10T13:23:09 <xiaq> ThomasWaldmann: template tree restructure?
23 2012-08-10T13:33:36 <dreimark> bbö
24 2012-08-10T13:33:38 <dreimark> bbl
25 2012-08-10T13:36:09 <ThomasWaldmann> xiaq: yes
26 2012-08-10T13:38:02 *** jaiditya
27 2012-08-10T13:39:41 <jaiditya> index page Actions are not working
28 2012-08-10T13:40:53 <jaiditya> except new item
29 2012-08-10T13:42:33 <ThomasWaldmann> btw, in general, if you are making changes to some code, i expect that you run the automated tests AND also do manual tests [practically using the wiki and checking functionality that might be affected] (as you can not assume 100% coverage) to make sure you did not break stuff
30 2012-08-10T13:44:10 <ThomasWaldmann> jaiditya: can you say which changeset broke it?
31 2012-08-10T13:45:10 <jaiditya> no, I'll have to check
32 2012-08-10T13:46:07 <ThomasWaldmann> if you find it, notify $whoever it was. :)
33 2012-08-10T13:46:43 <xiaq> ThomasWaldmann: yeah i put that off a bit, maybe after soc. and yes - i do `make test` and manual tests after changing some code
34 2012-08-10T13:49:04 <jaiditya> ThomasWaldmann: another issue is while creating home I filled wiki(moinmoin) instead of default in "item type" and now its giving a traceback forever with "/Home"
35 2012-08-10T13:49:22 <jaiditya> is there a way out ?
36 2012-08-10T13:51:58 <ThomasWaldmann> jaiditya: publish the traceback and how to reproduce -> pastebin
37 2012-08-10T13:53:42 <ThomasWaldmann> xiaq: ok, i'll pull/merge your stuff now, assuminging that it got enough review/testing
38 2012-08-10T13:54:36 <xiaq> jaiditya: try +modify/Home?itemtype=default and fill in "default" in itemtype. hopefully after ThomasWaldmann merge my changesets we'll get itemtype filled in when creating an items.
39 2012-08-10T13:55:08 <xiaq> ThomasWaldmann: ok :)
40 2012-08-10T13:56:13 <jaiditya> ThomasWaldmann: traceback http://dpaste.com/783438/
41 2012-08-10T13:57:02 <spy_> xiaq: is it your "Paragraph or block based" proposal?
42 2012-08-10T13:57:18 <xiaq> spy_: nope, i guess it's RogerHaase's
43 2012-08-10T13:57:42 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1647:8652dc6f6443 2.0/MoinMoin/storage/middleware/indexing.py: Add ITEMTYPE to Whoosh index.
44 2012-08-10T13:57:43 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1648:1a2c53092ea1 2.0/MoinMoin/items/ (4 files in 2 dirs): items/content.py: Implement Content.create.
45 2012-08-10T13:57:45 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1649:5dc142ab43d2 2.0/MoinMoin/items/ (__init__.py content.py):
46 2012-08-10T13:57:46 <CIA-54> Keep itemtype and contenttype in Item and Content subclasses.
47 2012-08-10T13:57:46 <CIA-54> Class decorators named @register are provided as helpers in items and
48 2012-08-10T13:57:46 <CIA-54> items.content modules.
49 2012-08-10T13:57:47 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1650:07b2146ba96f 2.0/MoinMoin/items/ (__init__.py _tests/test_Item.py):
50 2012-08-10T13:57:47 <CIA-54> Store `itemtype` metadata entry in DummyRev so that newly created items have
51 2012-08-10T13:57:47 <CIA-54> appropriate itemtype.
52 2012-08-10T13:57:47 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1651:056171aed664 2.0/MoinMoin/items/_tests/test_Item.py:
53 2012-08-10T13:57:48 <CIA-54> items/_tests/test_Item.py: convert MoinMoin.config imports to use
54 2012-08-10T13:57:48 <CIA-54> MoinMoin.constants.keys
55 2012-08-10T13:57:49 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1652:64fe4e3c449b 2.0/MoinMoin/ (5 files in 3 dirs): Automated merge with http://hg.moinmo.in/moin/2.0
56 2012-08-10T13:57:56 <xiaq> jaiditya: try the fix i mentioned...
57 2012-08-10T13:58:31 <jaiditya> and to reproduce it Destroy your "/Home" and while creating it again put wiki(moinmoin) in item type
58 2012-08-10T13:59:17 <jaiditya> xiaq: didn't worked
59 2012-08-10T14:00:35 <ThomasWaldmann> spy_: clicking on ticket in most recent code in main repo still blows up with a traceback
60 2012-08-10T14:00:45 <ThomasWaldmann> (when creating an item)
61 2012-08-10T14:01:25 <xiaq> ThomasWaldmann: yes it's a stub there
62 2012-08-10T14:01:45 <spy_> ThomasWaldmann: why is it addressed to me? :)
63 2012-08-10T14:02:51 <ThomasWaldmann> ehrm, %)
64 2012-08-10T14:03:07 <spy_> does the HTML markup support macroses?
65 2012-08-10T14:03:12 <ThomasWaldmann> spy_: ok, "Blog" ist still missing there. that should be addressed to you. :)
66 2012-08-10T14:03:26 <ThomasWaldmann> xiaq: and the ticket blow up is for you, of course.
67 2012-08-10T14:04:04 <ThomasWaldmann> spy_: html is just html, nothing special (except that we filter out dangerous stuff)
68 2012-08-10T14:05:15 <ThomasWaldmann> wasn't that "create item" stuff on high prio for this week?
69 2012-08-10T14:05:52 <xiaq> ThomasWaldmann: yes i'm looking forward to publishing ticket code on cr on tomorrow or so
70 2012-08-10T14:06:17 * spy_ pulls new changes
71 2012-08-10T14:06:29 * xiaq currently lives at a relative's house where the Internet access requires some funny proprietary PPPoE software only for Windows :(
72 2012-08-10T14:07:25 * xiaq has no access to the vpn network i use to get around "the wall" either
73 2012-08-10T14:07:48 <xiaq> and... appspot is blocked here, for some funny reason i guess
74 2012-08-10T14:07:58 <ThomasWaldmann> PPPoE is quite the normal thing here in germany with DSL providers
75 2012-08-10T14:08:34 <xiaq> ThomasWaldmann: yeah they do some funny crypto over PPPoE to prevent you to know the real username/password
76 2012-08-10T14:08:58 <ThomasWaldmann> ah
77 2012-08-10T14:09:28 <ThomasWaldmann> would a ssh user account on some german server help you?
78 2012-08-10T14:09:32 <xiaq> ThomasWaldmann: it would be a good reverse engineering homework though :)
79 2012-08-10T14:10:36 <xiaq> ThomasWaldmann: no, the problem is i cannot use PPPoE here on Linux - the "wall" stuff is relatively minor
80 2012-08-10T14:11:13 <xiaq> ThomasWaldmann: luckily i'll be back home where we have more sane Internet on Sunday :)
81 2012-08-10T14:11:19 <ThomasWaldmann> ok
82 2012-08-10T14:12:06 <ThomasWaldmann> we have shell.moinmo.in for moin developers. and as you are moin developers now, feel free to ask for an account if you want one.
83 2012-08-10T14:12:36 * ThomasWaldmann runs irssi in screen there, so irc client is permanently connected.
84 2012-08-10T14:12:54 <xiaq> ThomasWaldmann: it would be awesome :)
85 2012-08-10T14:13:26 * xiaq runs irssi in tmux on a university server so permanantly connected too
86 2012-08-10T14:14:05 <ThomasWaldmann> everybody who wants one just sends me an email please and attaches his password-protected ssh pubkey.
87 2012-08-10T14:15:32 <ThomasWaldmann> spy_: jaiditya: MaikuMori: breton: btw, the most recent changes in main repo require an index rebuild.
88 2012-08-10T14:15:36 <xiaq> ThomasWaldmann: hm, am i required to password-protect my ssh pubkey?
89 2012-08-10T14:15:46 <ThomasWaldmann> of course
90 2012-08-10T14:16:13 <ThomasWaldmann> well, it is rather the secret key that is protected (and the pubkey that comes with that)
91 2012-08-10T14:16:16 <eSyr-ng_> xiaq: we can't check it but it's usually more secure.
92 2012-08-10T14:16:26 *** eSyr-ng_
93 2012-08-10T14:16:45 * xiaq has always been using passphrase-less ssh public key
94 2012-08-10T14:17:20 <ThomasWaldmann> just imagine someone getting your secret key somehow (stolen laptop, hacked machine, ...), you don't want that he can log in into any other machine that has the pubkey in authorized_keys
95 2012-08-10T14:18:01 <eSyr-ng> xiaq: man ssh-agent
96 2012-08-10T14:19:10 <ThomasWaldmann> so, a non-trivial password/passphrase is very important
97 2012-08-10T14:19:51 <eSyr-ng> xiaq: btw, you can always encrypt existing private kay, ssh-keygen -p
98 2012-08-10T14:20:12 <xiaq> ThomasWaldmann: i guess when someone stole your laptop the first thing s/he does is to install Windows :)
99 2012-08-10T14:20:24 <xiaq> (at least in China i think)
100 2012-08-10T14:20:51 <xiaq> anyway i'll encrypt my private key... :)
101 2012-08-10T14:21:58 * xiaq uses cygwin here to ssh onto the university server
102 2012-08-10T14:22:54 <spy_> xiaq: what is better to use for itemtype value "blog_entry", "blog-entry" or "blogentry" ?
103 2012-08-10T14:24:14 <xiaq> spy_: whichever you prefer :)
104 2012-08-10T14:27:37 <spy_> rather without any delimiter :)
105 2012-08-10T14:29:18 * ThomasWaldmann has a bios password and everything except /boot on crypted block device
106 2012-08-10T14:29:39 <ThomasWaldmann> s/bios pw/power-on pw/
107 2012-08-10T14:39:07 <spy_> ThomasWaldmann: sent pull request
108 2012-08-10T14:39:41 <spy_> ThomasWaldmann: where do you store the key to your encrypted block devices?
109 2012-08-10T14:40:13 <spy_> or is it require to enter it on every reboot?
110 2012-08-10T14:44:15 <xiaq> spy_: i guess so...
111 2012-08-10T14:48:52 <xiaq> hm, now we have blog metadata keys in storage/middleware/indexing.py, and i put ticket keys there too. perhaps we need something cleaner (and separation of userprofile keys too)
112 2012-08-10T14:48:52 <spy_> I had such configuration at my job. It is a very annoying to lose the opportunity to connect to a computer by ssh after a power surge.
113 2012-08-10T14:52:55 <ThomasWaldmann> spy_: the passphrase is in my brain :)
114 2012-08-10T14:53:41 <ThomasWaldmann> and yes, i need to enter it on reboot. but as i use suspend to ram usually, i rarely do a full reboot
115 2012-08-10T14:54:30 <spy_> ThomasWaldmann: do you have an ups?
116 2012-08-10T14:54:42 <ThomasWaldmann> of course that means that the cryptodevice is unlocked after waking up from suspend, but it asks for login password then
117 2012-08-10T14:55:03 <ThomasWaldmann> yes, my laptop's battery :D
118 2012-08-10T14:55:34 <spy_> ahh, okay :)
119 2012-08-10T14:56:27 <xiaq> aha http://moinmo.in/MoinMoin2.0#Release_date
120 2012-08-10T14:56:37 <xiaq> change this to "maybe 2013"? :-P
121 2012-08-10T14:57:04 <xiaq> hopefully we can get moin2 released before perl 6 :D
122 2012-08-10T14:57:11 <spy_> :D
123 2012-08-10T14:58:31 <ThomasWaldmann> xiaq: i want something at 12.12.12 :D
124 2012-08-10T14:59:43 <xiaq> ThomasWaldmann: that's a good date - as a bonus you avoid the MM-DD vs. DD-MM confusion
125 2012-08-10T15:05:40 <ThomasWaldmann> 11.11.11 didn't work for moin2
126 2012-08-10T15:05:57 <ThomasWaldmann> and there won't be any such date again in the near future
127 2012-08-10T15:06:00 <xiaq> ThomasWaldmann: seems 12.12.12 is the last chance
128 2012-08-10T15:06:40 <xiaq> ah, just in time. in my spacetime i posted the remark earlier than you.
129 2012-08-10T15:07:20 <spy_> ThomasWaldmann: sent mail with pubkey :)
130 2012-08-10T15:08:50 <ThomasWaldmann> xiaq: yes, while i was typing it :)
131 2012-08-10T15:09:13 <ThomasWaldmann> so, you all see: we need help to hold that date :D
132 2012-08-10T15:10:40 <xiaq> ThomasWaldmann: what is still terribly missing? i had a feeling "ah we can get this released" after jaiditya's theme got merged. :-P
133 2012-08-10T15:11:41 <spy_> xiaq: have a question on http://etherpad.osuosl.org/moin-commenting
134 2012-08-10T15:14:28 <ThomasWaldmann> xiaq: i think the UI still needs more polishing, templates rearranged, deduplicated, ...
135 2012-08-10T15:14:37 <ThomasWaldmann> then there are 100 bugs open
136 2012-08-10T15:14:53 <ThomasWaldmann> no conflict merging yet
137 2012-08-10T15:15:06 <ThomasWaldmann> ...
138 2012-08-10T15:15:51 <ThomasWaldmann> then there is namespaces branch stale and unmerged since months
139 2012-08-10T15:16:20 <ThomasWaldmann> and branching/merging/syncing stuff has to be seen
140 2012-08-10T15:17:46 <spy_> ThomasWaldmann: did you read the commenting system proposal?
141 2012-08-10T15:18:34 <xiaq> ThomasWaldmann: oh, breton's project (bms)?
142 2012-08-10T15:34:24 <ThomasWaldmann> spy_: no, was busy with other stuff (and a ton of CR)
143 2012-08-10T15:35:25 <ThomasWaldmann> xiaq: also there is no network api yet
144 2012-08-10T15:35:57 <xiaq> ThomasWaldmann: jsonrpc?
145 2012-08-10T15:36:22 <ThomasWaldmann> in moin1 we had xmlrpc, so you could read/write/list pages via network
146 2012-08-10T15:37:09 <ThomasWaldmann> we won't do the same api again as it is too limited for moin2 anyway, but something like that should be there
147 2012-08-10T15:38:42 <ThomasWaldmann> (working on that field was part of dasich's and breton's project, but that part obviously won't come to a result)
148 2012-08-10T16:06:03 <breton> err, how to set a value to a form field? `form['branch'] = self.branch' and `{{ forms.render_field(gen, form['branch'], 'text') }}' seems not to be working
149 2012-08-10T16:06:56 <ThomasWaldmann> breton: you have quite some sample code to look this up
150 2012-08-10T16:34:54 <breton> // if someone will be looking: render_field sets `auto_value` to False, it shouldn't be used. The only way I found - copypaste everything from render_field and set `auto_value` to True.
151 2012-08-10T16:41:06 <ThomasWaldmann> breton: answered EP 140 http://etherpad.osuosl.org/moin2-bms
152 2012-08-10T16:42:46 <ThomasWaldmann> breton: http://codereview.appspot.com/6446100 < is that still uptodate? i might have time today to review it.
153 2012-08-10T16:57:10 <breton> ThomasWaldmann: it's not. http://codereview.appspot.com/6459066/
154 2012-08-10T17:00:17 <jaiditya> after removing duplication just left with 6 templates in foobar theme template folder :)
155 2012-08-10T17:06:22 <xiaq> jaiditya: good
156 2012-08-10T17:18:13 <ThomasWaldmann> breton: ok
157 2012-08-10T17:18:42 *** RogerHaase
158 2012-08-10T17:19:00 <xiaq> i wonder...
159 2012-08-10T17:19:08 <xiaq> how do i index a list with whoosh?
160 2012-08-10T17:19:37 * xiaq is trying to make whoosh index subscribed_items
161 2012-08-10T17:21:55 <xiaq> breton: i think render_field is gone after my flatland widgets changesets were merged
162 2012-08-10T17:22:49 <xiaq> (which was quite some time ago)
163 2012-08-10T17:26:51 <jaiditya> need review http://codereview.appspot.com/6454130/ if I have skipped something there
164 2012-08-10T17:32:01 <xiaq> ThomasWaldmann: i mentioned that indenting is not consistent in current template codes several days ago, but seemed everyone was busy then
165 2012-08-10T17:37:44 <ThomasWaldmann> xiaq: i answered that to not fix it while work is going on on several branches in parallel
166 2012-08-10T17:50:44 <xiaq> ThomasWaldmann: ok, missed it
167 2012-08-10T18:52:23 <ThomasWaldmann> (that's a rather general thing for source reformattings, especially indenting or line end changes)
168 2012-08-10T19:32:09 *** greg_f
169 2012-08-10T20:04:09 *** xjjk
170 2012-08-10T20:21:34 *** xjjk
171 2012-08-10T20:58:53 <dreimark> re
172 2012-08-10T21:20:32 <dreimark> spy_: 3 days no diary page, when do we get Blog into item_type selection?
173 2012-08-10T21:21:40 <dreimark> jaiditya: also ^
174 2012-08-10T21:22:48 <dreimark> jaiditya: have you still a traceback on creating new items?
175 2012-08-10T21:23:36 <jaiditya> I'll update diary after today's work
176 2012-08-10T21:25:07 <jaiditya> I get a traceback when I try to access anything related Home
177 2012-08-10T21:26:38 <breton> post it somewhere again please
178 2012-08-10T21:27:39 <jaiditya> as I filled wiki(moinmoin) general meta item type while creating it
179 2012-08-10T21:27:57 <jaiditya> wiki(moinmoin) in*
180 2012-08-10T21:28:57 <dreimark> jaiditya: have you run moin index-build -s -i
181 2012-08-10T21:29:12 <dreimark> after pulling from main?
182 2012-08-10T21:29:33 <dreimark> and if you destroy that item can you create a new one
183 2012-08-10T21:29:48 <dreimark> there you have not to enter something for item_type
184 2012-08-10T21:30:03 <dreimark> it is there as "default"
185 2012-08-10T21:30:29 <jaiditya> I have a pending cr http://codereview.appspot.com/6454130/ after which I'll pull
186 2012-08-10T21:30:41 <dreimark> ah, ok
187 2012-08-10T21:30:45 * dreimark looks
188 2012-08-10T21:30:48 <jaiditya> and problem is index page actions are broken
189 2012-08-10T21:31:11 <jaiditya> so not able to delete anything from index page
190 2012-08-10T21:32:09 <dreimark> jaiditya: you can do by e.g. http://localhost:8080/+delete/home
191 2012-08-10T21:32:16 <dreimark> if home is the item
192 2012-08-10T21:32:31 <dreimark> +delete is the action you want to do
193 2012-08-10T21:32:44 <dreimark> but before the merge it will make no difference
194 2012-08-10T21:32:54 * dreimark looks at the cr
195 2012-08-10T21:33:19 <jaiditya> anything containing "/Home" gives a traceback
196 2012-08-10T21:36:23 <spy_> dreimark: Blog selection is already in pull request
197 2012-08-10T21:36:41 * spy_ fills diary pages
198 2012-08-10T21:38:54 <dreimark> jaiditya: try moin item-get --name Home --data Home.data --meta Home.meta
199 2012-08-10T21:39:40 <dreimark> if that works, fix Home.meta and try them item-put option to update it
200 2012-08-10T21:39:56 <dreimark> spy_: :)
201 2012-08-10T21:41:54 <spy_> dreimark: done :)
202 2012-08-10T21:43:04 <jaiditya> dreimark: didn't worked
203 2012-08-10T21:43:30 <dreimark> what tells that?
204 2012-08-10T21:43:34 <dreimark> pastebin
205 2012-08-10T21:44:26 <jaiditya> "moin item-get --name Home --data Home.data --meta Home.meta" whats its purpose ?
206 2012-08-10T21:45:44 <dreimark> it gets a revision from the wiki and stores it in its meta and data part as file on your disk
207 2012-08-10T21:46:19 <dreimark> the moin item-put uploads a revision to the wiki. you have to give its meta and data
208 2012-08-10T21:46:48 <dreimark> http://hg.moinmo.in/moin/2.0/file/64fe4e3c449b/MoinMoin/script/maint/modify_item.py
209 2012-08-10T21:48:33 <jaiditya> http://dpaste.com/784518/ when executed the command
210 2012-08-10T21:49:28 <jaiditya> traceback http://dpaste.com/783438/
211 2012-08-10T21:49:40 <dreimark> jaiditya: this is no failure report, it is just timing information
212 2012-08-10T21:50:35 <dreimark> look in the dir where you executed the command for 784518
213 2012-08-10T21:50:44 <dreimark> you should have 2 new files there
214 2012-08-10T21:50:53 <dreimark> or search for Home.meta Home.data
215 2012-08-10T21:52:33 <jaiditya> http://dpaste.com/784519/
216 2012-08-10T21:54:37 <dreimark> jaiditya: s/"itemtype": "plain text", /"itemtype": "default", /
217 2012-08-10T21:55:05 <dreimark> replace "plain text" by "default"
218 2012-08-10T21:55:21 <dreimark> and upload the revision then back to the wiki
219 2012-08-10T21:55:35 <dreimark> moin item-put ....
220 2012-08-10T21:57:02 <spy_> dreimark: I would like to summarize the necessary improvements for the blog. Move +blog and +blog_entry views to Blog and BlogEntry classes as do_show methods (that would be done after accepting xiaq's "Let Item subclasses handle +show" changeset). Then there is still no easy way to create new blogposts (currently you have to create a BlogEntry subitem of a blog item). This functionality I will add on +index view. Since xiaq is wor
221 2012-08-10T21:57:15 <dreimark> spy_: too long line
222 2012-08-10T21:58:02 <dreimark> it ends at "Since xiaq is wor"
223 2012-08-10T21:59:06 <dreimark> spy_: we have also the sidebar for subitems.
224 2012-08-10T21:59:21 <dreimark> there could be also something added to create Blog entries
225 2012-08-10T22:00:23 <dreimark> i am not sure if one wants to navigate to index always to create a new blogentry if he already sees subitems
226 2012-08-10T22:00:38 <dreimark> or could see
227 2012-08-10T22:01:00 <jaiditya> moin item-put --name Home --data Home.data --meta Home.meta
228 2012-08-10T22:01:11 <jaiditya> right ?
229 2012-08-10T22:01:22 <dreimark> yes
230 2012-08-10T22:01:35 <jaiditya> http://dpaste.com/784526/
231 2012-08-10T22:01:46 <jaiditya> gives a fallback
232 2012-08-10T22:01:50 <dreimark> --overwrite
233 2012-08-10T22:02:01 <RogerHaase> I had to add -- overwrite
234 2012-08-10T22:02:22 <spy_> Since xiaq is working on +index refactoring, I don't want to submit any new changes to it now. There is new commenting system proposal. So let's decide what is most important to work on now.
235 2012-08-10T22:02:33 <dreimark> jaiditya: without --name
236 2012-08-10T22:02:47 <RogerHaase> ... and remove --name
237 2012-08-10T22:03:29 <jaiditya> done :)
238 2012-08-10T22:03:54 <jaiditya> works
239 2012-08-10T22:03:58 <jaiditya> thanks
240 2012-08-10T22:04:05 <dreimark> \o/
241 2012-08-10T22:04:17 <dreimark> spy_: agreed
242 2012-08-10T22:04:21 <jaiditya> dreimark: Index page actions are not working
243 2012-08-10T22:04:31 <spy_> RogerHaase: we have some replies on http://etherpad.osuosl.org/moin-commenting
244 2012-08-10T22:04:38 <dreimark> jaiditya: i look at it in a minute
245 2012-08-10T22:04:43 <jaiditya> ok
246 2012-08-10T22:05:04 <jaiditya> except new-item
247 2012-08-10T22:05:33 <dreimark> if there won't be so much new changes we could have selnium webdriver using to get unit tests for the ui
248 2012-08-10T22:06:00 <dreimark> at some time it is more stablilized we can add those tests
249 2012-08-10T22:06:25 <dreimark> currently everyone who adds / changes something has to do some manual tests
250 2012-08-10T22:06:33 <dreimark> besides make test
251 2012-08-10T22:07:59 <dreimark> spy_: is it possible to have a simple solution for adding blog entries
252 2012-08-10T22:15:54 <dreimark> jaiditya: have you looked on both themes with your changes?
253 2012-08-10T22:16:51 <spy_> dreimark: create a subitem of a blog item is a simple solution, isn't it? In addition it is a wiki-style solution :D
254 2012-08-10T22:18:53 <dreimark> spy_: i know besides wiki users often write item names in the content
255 2012-08-10T22:19:06 *** RogerHaase
256 2012-08-10T22:19:10 <dreimark> and create then the item by clicking on it
257 2012-08-10T22:19:30 <dreimark> while the current approach is to extend the url by a /subitem
258 2012-08-10T22:19:41 <jaiditya> I was looking at all changesets which involved any changes related to index page
259 2012-08-10T22:19:53 <jaiditya> didn't find anything yet
260 2012-08-10T22:20:21 <dreimark> jaiditya: i think that means you looked up in a browser what happens with the changes
261 2012-08-10T22:20:44 <jaiditya> yeah
262 2012-08-10T22:21:18 <dreimark> hmm
263 2012-08-10T22:21:37 <dreimark> index delete seems to work with modernized theme
264 2012-08-10T22:21:48 <dreimark> can you check that again please
265 2012-08-10T22:22:50 <jaiditya> yeah delete works
266 2012-08-10T22:22:55 <dreimark> download too
267 2012-08-10T22:23:15 <dreimark> and destroy also (you have to login)
268 2012-08-10T22:24:15 <jaiditya> I am already logged in and download and destroy didn't work for me here as I am already logged in
269 2012-08-10T22:24:51 <dreimark> ok, for me delete and destroy work in modernized but not in foobar
270 2012-08-10T22:25:04 <dreimark> download works in both
271 2012-08-10T22:25:37 <jaiditya> dreimark: try downloading a user
272 2012-08-10T22:25:52 <dreimark> jaiditya: don't do with a user
273 2012-08-10T22:25:57 <dreimark> this is not implemented
274 2012-08-10T22:26:14 <dreimark> make Home/a
275 2012-08-10T22:26:26 <dreimark> go to +index/Home
276 2012-08-10T22:26:33 <dreimark> and try everything with a
277 2012-08-10T22:27:20 <spy_> jaiditya: everything seems work for me http://vps.psviderski.name:8080 (latest revision of Thomas repo)
278 2012-08-10T22:27:32 <jaiditya> dreimark: download works but not destroy destroy
279 2012-08-10T22:29:04 <dreimark> jaiditya: works with cs 1652:64fe4e3c449b here
280 2012-08-10T22:29:22 <dreimark> with modernized but not with foobar
281 2012-08-10T22:29:32 <dreimark> spy_: can you verify this ?
282 2012-08-10T22:32:13 <dreimark> jaiditya: check if that could be because of the template movements for foobar
283 2012-08-10T22:32:32 <dreimark> in the cr there is destroy and delete removed
284 2012-08-10T22:33:40 <dreimark> ignore, that is in the future, not yet pushed
285 2012-08-10T22:34:14 <jaiditya> dreimark: yeah as they are being used from main template folder
286 2012-08-10T22:35:15 <jaiditya> I get a KeyError now when I switched to foobar theme http://dpaste.com/784541/
287 2012-08-10T22:37:51 <dreimark> http://dpaste.com/784519/ this is again the Home item
288 2012-08-10T22:38:03 <dreimark> can you destroy it with modernized
289 2012-08-10T22:38:57 <dreimark> this is maybe also a bug there should be no tracebacl for a theme change if it an item works in one theme
290 2012-08-10T22:39:30 <jaiditya> I can't access anything now
291 2012-08-10T22:39:45 <dreimark> try again index-build -s -i
292 2012-08-10T22:45:02 <jaiditya> dreimark: its confusing now neither delete nor download is working
293 2012-08-10T22:45:15 <jaiditya> in modernized
294 2012-08-10T22:46:46 <spy_> just see Destroying.. with foobar theme
295 2012-08-10T22:46:54 <spy_> modernized works well
296 2012-08-10T22:47:15 <jaiditya> download works in foobar
297 2012-08-10T22:47:33 <jaiditya> but delete and destroy don't
298 2012-08-10T22:49:09 <spy_> hm, weird
299 2012-08-10T22:51:14 *** jaiditya|2
300 2012-08-10T22:51:44 <dreimark> jaiditya: that is a bug cs after the cr merge
301 2012-08-10T22:51:48 <dreimark> +fix
302 2012-08-10T22:52:41 *** jaiditya
303 2012-08-10T22:52:50 *** jaiditya|2
304 2012-08-10T22:53:13 <jaiditya> dreimark: I'll look at the whole thing once again
305 2012-08-10T22:53:50 <jaiditya> Its confusing at the moment
306 2012-08-10T22:54:04 <dreimark> ok, i have looked through the cr, try next a patch applied
307 2012-08-10T22:55:04 <dreimark> this is too much to read while visualized i think we find faster where something is wrong
308 2012-08-10T22:56:11 <dreimark> jaiditya: this problem is independent from the current refactoring as it also don't work in main momentanly
309 2012-08-10T22:56:41 <dreimark> so make an additional fix, i guess it is something similiar as it was with the uploader
310 2012-08-10T22:56:54 <jaiditya> dreimark: should I push the cr code to main repo ?
311 2012-08-10T22:57:01 <dreimark> yes
312 2012-08-10T22:57:09 <jaiditya> ok
313 2012-08-10T22:57:10 <dreimark> oops
314 2012-08-10T22:57:18 <dreimark> can you to your repo first
315 2012-08-10T22:57:57 <dreimark> then i like to play some minutes with it and then you can semd a pull request
316 2012-08-10T22:58:10 <jaiditya> sure
317 2012-08-10T23:03:00 <jaiditya> https://bitbucket.org/Jaiditya/moin-2.0
318 2012-08-10T23:03:05 <jaiditya> updated
319 2012-08-10T23:08:05 <dreimark> jaiditya: some further findings:
320 2012-08-10T23:08:37 <dreimark> look at image size on modernized, in foobar it is scaled
321 2012-08-10T23:09:07 <dreimark> hmm, no not now
322 2012-08-10T23:09:50 <dreimark> ok in foobar but image in modernized too big
323 2012-08-10T23:10:18 <jaiditya> a snapshot please
324 2012-08-10T23:18:14 <dreimark> not so easy, too big, i try a smaller example
325 2012-08-10T23:22:30 <dreimark> jaiditya: http://test.moinmo.in/modenized_example
326 2012-08-10T23:22:37 <dreimark> 10% of the original
327 2012-08-10T23:24:16 <dreimark> btw. with your cs in your repo clone i can delete and destroy in foobar theme
328 2012-08-10T23:25:40 <dreimark> with the normal actions on the item itself
329 2012-08-10T23:26:22 <dreimark> it is only in index not working, that means it is related to the ajax calls
330 2012-08-10T23:29:48 <dreimark> jaiditya: cs looks good to me
331 2012-08-10T23:35:46 <dreimark> gn
332 2012-08-10T23:40:26 <spy_> gn
