1 2012-08-12T00:13:33 <dreimark> gn
2 2012-08-12T00:19:06 *** kanha_
3 2012-08-12T01:09:30 *** dreimark
4 2012-08-12T01:09:38 *** dreimark
5 2012-08-12T01:10:35 *** eSyr-ng
6 2012-08-12T01:10:43 *** eSyr-ng
7 2012-08-12T06:03:06 * breton thinking
8 2012-08-12T06:04:54 <breton> polish branches and drive them to some close-to-ideal state, or start merging, which will highly unlikely be 100% ready by the end?
9 2012-08-12T06:05:12 <breton> merging = merging of wik i items
10 2012-08-12T08:06:01 <dreimark> polishing fixing branches first
11 2012-08-12T08:06:38 <dreimark> on spare time you can work on merging
12 2012-08-12T08:11:32 <dreimark> breton: ^
13 2012-08-12T09:41:13 * xiaq sent a bundled pull req to ThomasWaldmann: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/68/
14 2012-08-12T10:21:52 <xiaq> http://z.tuna.tsinghua.edu.cn:8088/ ticket creation fixed ^_^
15 2012-08-12T10:21:57 <xiaq> dreimark: ^
16 2012-08-12T10:21:58 <xiaq> spy: ^
17 2012-08-12T10:22:00 <xiaq> ThomasWaldmann: ^
18 2012-08-12T10:26:46 <xiaq> breton: :) is this your first soc too?
19 2012-08-12T10:29:06 <xiaq> ThomasWaldmann: my real purpose is not to benchmark item creation but to benchmark +index and see whether it will get faster by using whoosh for filtering :) btw i'm wondering will the performance be improved by using a sql database?
20 2012-08-12T10:30:49 <spy> xiaq: which performance problems do you have now?
21 2012-08-12T10:31:47 <xiaq> spy: creating 2000 items took 250s, that is 250ms per item
22 2012-08-12T10:32:24 <xiaq> oh, i realize there are a couple of things i should have shared...
23 2012-08-12T10:33:18 <dreimark> xiaq: it gives a traceback
24 2012-08-12T10:33:45 <xiaq> http://rn0.ru/show/joPYmDhetca17Lhgs9r7/ This is the logging.ini i've been using for development. set environment variable MOINLOGGINGCONF to the filename...
25 2012-08-12T10:33:59 <dreimark> http://dpaste.com/785113/
26 2012-08-12T10:34:56 <xiaq> dreimark: seems to be some silly mistake...
27 2012-08-12T10:35:15 <dreimark> yeah sure, but do those tests on your own
28 2012-08-12T10:35:25 <dreimark> sometimes i miss also to try out
29 2012-08-12T10:37:44 * xiaq fixing...
30 2012-08-12T10:40:27 <xiaq> fixed :D
31 2012-08-12T10:41:06 <xiaq> (but there is an obvious bug concerning the reference widget...)
32 2012-08-12T10:42:04 <xiaq> aha, i saw it, /NewTest
33 2012-08-12T10:42:50 <xiaq> also btw, rn0.ru seems to be using the same pastebin software as paste.pacoo.org
34 2012-08-12T10:42:53 <dreimark> for the search box jaiditya is already looking that it fits the theme boundings
35 2012-08-12T10:43:12 <dreimark> xiaq: i want to use the ticket system for it
36 2012-08-12T10:43:19 <dreimark> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/244/change-the-pastebin-for-werkzeug
37 2012-08-12T10:43:54 <dreimark> we likly don't need a pastebin because it is only text
38 2012-08-12T10:44:55 <xiaq> dreimark: "we should change the way how werkzeug debugger sends pastes to a site." - change to how?
39 2012-08-12T10:45:08 <dreimark> if you resize the window look on the message box that it did not move out of the theme
40 2012-08-12T10:45:28 <dreimark> or tell jaiditya to look at it
41 2012-08-12T10:46:01 <dreimark> xiaq: currently it is an idea onle. one way is to give it a different url
42 2012-08-12T10:46:18 <dreimark> the other is to have later a way to make tickets instead of pastes
43 2012-08-12T10:47:05 <xiaq> dreimark: how does that relate to werkzeug debugger then...?
44 2012-08-12T10:47:41 <xiaq> ah!
45 2012-08-12T10:47:49 <xiaq> you can directly create a paste from it
46 2012-08-12T10:47:54 * xiaq never used that before :)
47 2012-08-12T10:48:47 <dreimark> I miss that a lot
48 2012-08-12T10:48:52 <xiaq> i wonder - the url should be configurable isn't it
49 2012-08-12T10:49:28 <dreimark> it is but we have not implemented to do so
50 2012-08-12T10:49:48 <dreimark> and for moin problems i anyway want it as a ticket
51 2012-08-12T10:50:07 <dreimark> either in moin itselfs or on bitbucket
52 2012-08-12T10:50:23 <xiaq> dreimark: ah that sounds good
53 2012-08-12T10:51:49 * xiaq wonders is there a standard secure way to do cross-site POST?
54 2012-08-12T10:52:04 <xiaq> you need that if you want to put the traceback directly to a ticket
55 2012-08-12T10:54:07 <dreimark> it could be done in two steps. first show a link to create a new ticket
56 2012-08-12T10:54:15 <dreimark> then append to the ticket
57 2012-08-12T10:55:25 <dreimark> but lets do first the basics
58 2012-08-12T10:55:52 <dreimark> (we can also look on ubuntu how they had solved it)
59 2012-08-12T10:57:40 <dreimark> or upload.py is also a good source
60 2012-08-12T10:58:47 <xiaq> dreimark: upload.py keeps http cookies. it asks you password doesn't it
61 2012-08-12T10:59:41 <dreimark> xiaq: Supersedes
62 2012-08-12T11:00:01 <dreimark> may be its values can be links to the other tickets
63 2012-08-12T11:00:47 <dreimark> xiaq: yes, that is different just only an example for a smart uploader
64 2012-08-12T11:00:56 <xiaq> dreimark: agreed, implementing that
65 2012-08-12T11:02:08 <xiaq> oh there is an important meta key missing... status
66 2012-08-12T11:02:46 <dreimark> xiaq: if message is empty but effort, difficulty changes one don't see that there was an update
67 2012-08-12T11:02:52 <dreimark> is that in status then?
68 2012-08-12T11:03:19 <dreimark> no you meant meta key
69 2012-08-12T11:03:43 <dreimark> there should also a status information somehow to tell that there was a change
70 2012-08-12T11:08:56 <xiaq> dreimark: yeah, actually i once thought it this
71 2012-08-12T11:09:12 <xiaq> this makes the ticket's do_show view more like a detailed +history
72 2012-08-12T11:12:12 <dreimark> yes
73 2012-08-12T11:14:48 <dreimark> http://z.tuna.tsinghua.edu.cn:8088/NewTest the last one indicates a problem
74 2012-08-12T11:16:43 <xiaq> dreimark: ah yes. the adhoc comment system breaks miserably at some situations...
75 2012-08-12T11:17:04 <dreimark> do you add {{{#!wiki info or so?
76 2012-08-12T11:17:26 <dreimark> you could have a lot more {{{{ and also a key there
77 2012-08-12T11:17:53 <xiaq> the template is u'''{{{#!wiki tip
78 2012-08-12T11:17:53 <xiaq> %(author)s wrote on <<DateTime(%(timestamp)d)>>:
79 2012-08-12T11:17:53 <xiaq> %(message)s
80 2012-08-12T11:17:53 <xiaq> }}}
81 2012-08-12T11:17:54 <xiaq> '''
82 2012-08-12T11:18:24 <xiaq> it's adhoc. i'm relying on spy's comment system. :)
83 2012-08-12T11:19:32 <dreimark> {{{{{ #!wiki tip
84 2012-08-12T11:19:32 <dreimark> TEST
85 2012-08-12T11:19:33 <dreimark> }}}}}
86 2012-08-12T11:19:36 <dreimark> works also
87 2012-08-12T11:20:05 <dreimark> or much more repeated
88 2012-08-12T11:20:29 <dreimark> that is a limitation of the convertor
89 2012-08-12T11:21:05 <dreimark> the outer one should have just a longer length
90 2012-08-12T11:22:13 <dreimark> http://moinmo.in/HelpOnMoinWikiSyntax?action=raw
91 2012-08-12T11:22:22 <dreimark> see the example on bottom
92 2012-08-12T11:24:00 <xiaq> dreimark: that feels quite evil :)
93 2012-08-12T11:24:47 <dreimark> nesting of that is not easily
94 2012-08-12T11:36:02 <dreimark> xiaq: after that is fixed you can do it named again
95 2012-08-12T11:36:05 <dreimark> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/245/convertor-moin-wiki-misses-a-nesting
96 2012-08-12T11:36:58 <dreimark> {{{ticket
97 2012-08-12T11:36:58 <dreimark> test first
98 2012-08-12T11:36:59 <dreimark> ticket}}}
99 2012-08-12T11:38:19 <xiaq> dreimark: what is "do it named again"? :)
100 2012-08-12T11:38:57 <dreimark> http://moinmo.in/WikiSandBox?action=raw see bottom
101 2012-08-12T11:39:24 <xiaq> `moin maint_set_meta` crashes: http://rn0.ru/show/0ma8wtt3Ula4X3w2kLLk/
102 2012-08-12T11:39:39 <xiaq> and i found this: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/130/account_create-fails
103 2012-08-12T11:40:34 <xiaq> dreimark: no, i think i'll use spy's commenting system in the end, no such tricks anymore
104 2012-08-12T11:41:03 <dreimark> yes, but we need it because the markup allows to use anonther convertor inline
105 2012-08-12T11:41:52 <dreimark> and if we don't implement it we need to do in the migration script
106 2012-08-12T11:42:45 <dreimark> file an issue about set_meta crashing
107 2012-08-12T11:44:40 <xiaq> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/246/maint_-commands-crash
108 2012-08-12T11:44:42 <xiaq> ThomasWaldmann: ^
109 2012-08-12T11:46:42 <dreimark> look at http://hg.moinmo.in/moin/2.0/file/ad8995d32748/MoinMoin/script/maint/modify_item.py#l42
110 2012-08-12T11:46:51 <dreimark> it must be similar done
111 2012-08-12T11:49:37 * xiaq is busy with ticket code :)
112 2012-08-12T11:50:23 <dreimark> yeah, good answer just wanted to comment on it :)
113 2012-08-12T11:50:52 <dreimark> i need some food bbl
114 2012-08-12T11:51:14 <ThomasWaldmann> moin
115 2012-08-12T11:51:26 <dreimark> ThomasWaldmann: good timings
116 2012-08-12T11:51:36 <ThomasWaldmann> xiaq: can you edit the original post of #246 and delete the comment? https://bitbucket.org/thomaswaldmann/moin-2.0/issue/246
117 2012-08-12T11:54:23 <ThomasWaldmann> dreimark: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/245 completely unclear what the problem is
118 2012-08-12T11:56:23 <dreimark> ThomasWaldmann: http://test.moinmo.in/Ex1
119 2012-08-12T11:58:02 <dreimark> http://moinmo.in/WikiSandBox#Nesting
120 2012-08-12T11:58:10 <dreimark> in 1.9 that works but not in 2
121 2012-08-12T11:59:12 <dreimark> http://hg.moinmo.in/moin/1.9/file/0e58d9bcd3bd/MoinMoin/parser/text_moin_wiki.py#l334
122 2012-08-12T11:59:24 <dreimark> that is different now
123 2012-08-12T12:00:33 <xiaq> ThomasWaldmann: i was looking for that too, but seems there is no way to edit the original message...
124 2012-08-12T12:02:57 <dreimark> xiaq: on the right column is edit
125 2012-08-12T12:03:17 <dreimark> below the moin sign
126 2012-08-12T12:03:21 <dreimark> logo
127 2012-08-12T12:03:57 <xiaq> dreimark: no there isn't...
128 2012-08-12T12:07:35 <dreimark> for mine it looks like this http://test.moinmo.in/bb in firefox
129 2012-08-12T12:07:53 <dreimark> xiaq: ^
130 2012-08-12T12:08:44 <ThomasWaldmann> using {{{ticket was completely misleading
131 2012-08-12T12:09:26 <ThomasWaldmann> why don't you just use {{{abc if it can be anything? i thought it is somehow related to how ticket items gets processed.
132 2012-08-12T12:09:50 <dreimark> sorry it was taken from an example i wanted to show xiaq
133 2012-08-12T12:10:08 <dreimark> ouch
134 2012-08-12T12:10:40 <dreimark> ok, i try to improve my reportings
135 2012-08-12T12:11:54 <xiaq> ThomasWaldmann: unfortunately for me it looks like this http://test.moinmo.in/mybb.png
136 2012-08-12T12:12:41 <xiaq> alright, i saw you edited the description :)
137 2012-08-12T12:12:45 <ThomasWaldmann> yes
138 2012-08-12T12:13:15 <ThomasWaldmann> seems like a new stupid bb feature like OP may not edit his own post...
139 2012-08-12T12:13:33 <xiaq> ThomasWaldmann: in case you missed it: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/68/converter-improvment-do_show
140 2012-08-12T12:14:15 <ThomasWaldmann> i am looking at it right now
141 2012-08-12T12:14:33 <xiaq> ThomasWaldmann: ah, alright
142 2012-08-12T12:16:42 <ThomasWaldmann> xiaq: http://codereview.appspot.com/6457048/diff2/9004:12008/MoinMoin/items/__init__.py line 662 on the right, isn't there a 404 missing?
143 2012-08-12T12:17:41 <ThomasWaldmann> maybe it should first compute the html for both cases and then make the 404 response for the html
144 2012-08-12T12:17:58 <xiaq> ah, stupid me
145 2012-08-12T12:24:59 <xiaq> so i fixed it, not pushed yet. the problem is i pushed another 2 changesets after sending the pull req...
146 2012-08-12T12:25:30 <xiaq> ThomasWaldmann: so you have to review them as well...
147 2012-08-12T12:25:34 <xiaq> https://bitbucket.org/xiaq/moin-2.0/changeset/0104f76e30d0ec141c0de57fc58012da2ef2b015 this is a trivial one.
148 2012-08-12T12:26:04 <xiaq> ThomasWaldmann: https://bitbucket.org/xiaq/moin-2.0/changeset/237f790c029046fc770e80b1323e031c7dc02b62 this one is same as cr http://codereview.appspot.com/6446091/ but there is a problem...
149 2012-08-12T12:28:06 <dreimark> xiaq: you mean the 149 XXX problem?
150 2012-08-12T12:28:17 <xiaq> dreimark: nope
151 2012-08-12T12:28:26 <dreimark> then tell
152 2012-08-12T12:28:46 <xiaq> ValidReference is wrong
153 2012-08-12T12:30:10 <ThomasWaldmann> xiaq: you removed the ticket stub, but what does replace it?
154 2012-08-12T12:32:11 <xiaq> ThomasWaldmann: nothing yet - perhaps i should add another stub as items/ticket.py
155 2012-08-12T12:32:48 * xiaq has to go out now. :( i have an appointment...
156 2012-08-12T12:33:18 <ThomasWaldmann> ok, cu :)
157 2012-08-12T12:34:13 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1662:465b22852fae 2.0/MoinMoin/ (4 files in 3 dirs): Let Item subclasses handle +show.
158 2012-08-12T12:34:13 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1663:28fcf53d11cd 2.0/MoinMoin/converter/_tests/test_registry.py: Add test cases for converter registry.
159 2012-08-12T12:34:15 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1664:a11de88b6da1 2.0/MoinMoin/converter/highlight.py:
160 2012-08-12T12:34:15 <CIA-54> Make converter.highlight._factory behave like factories of other DOM
161 2012-08-12T12:34:15 <CIA-54> converters.
162 2012-08-12T12:34:16 <CIA-54> Cheer Xiao <xiaqqaix@gmail.com> default * 1665:c7cc251e08bd 2.0/MoinMoin/ (6 files in 5 dirs): Automated merge with http://hg.moinmo.in/moin/2.0
163 2012-08-12T12:58:52 *** betelgeuse_
164 2012-08-12T13:00:03 <dreimark> spy: ^^
165 2012-08-12T13:09:16 *** betelgeuse_
166 2012-08-12T13:14:42 <spy> moin
167 2012-08-12T13:14:56 * spy pulls new changes
168 2012-08-12T14:02:40 *** Trip_
169 2012-08-12T14:02:56 *** MattMaker
170 2012-08-12T14:19:57 *** MattMaker
171 2012-08-12T14:19:58 *** Trip_
172 2012-08-12T15:13:36 <breton> http://codereview.appspot.com/6459066/#ps1008
173 2012-08-12T15:32:50 * ThomasWaldmann looks
174 2012-08-12T16:17:27 <spy> ThomasWaldmann: http://codereview.appspot.com/6463045
175 2012-08-12T16:17:31 <spy> dreimark: ^
176 2012-08-12T16:20:38 <ThomasWaldmann> breton: review done. lots of stuff hardly understandable, duplicate, still needing cleanup. please vastly improve that, i can't review your code if i have no idea what you are doing and why.
177 2012-08-12T16:23:42 <ThomasWaldmann> maybe start with removing all crap that is not needed. then review all those 1,2,3,... comments and make sure they are understandable on their own.
178 2012-08-12T16:24:04 <ThomasWaldmann> don't just repeat there what you are doing, but also tell WHY you do it.
179 2012-08-12T16:24:31 <ThomasWaldmann> (and have it in sync with what you are really doing in the code below it)
180 2012-08-12T16:40:03 <breton> ThomasWaldmann: in fact, I've posted another patchset - 6. I'll remove it now though and will post a new with fixes.
181 2012-08-12T17:30:40 <dreimark> spy: done
182 2012-08-12T17:54:02 * ThomasWaldmann also added a little comment
183 2012-08-12T20:00:16 <ThomasWaldmann> dreimark: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/244/change-the-pastebin-for-werkzeug
184 2012-08-12T20:00:31 <ThomasWaldmann> your intention is a bit unclear there
185 2012-08-12T20:00:59 <ThomasWaldmann> there is the issue that the werkzeug pastebin url currently is invalid. this is a werkzeug bug, not a moin bug.
186 2012-08-12T20:01:31 <ThomasWaldmann> we could add code to work around it, though, and just use another pastebin url that runs lodgeit.
187 2012-08-12T20:01:54 <ThomasWaldmann> if it is that what you meant, change the issue title so it is understandable
188 2012-08-12T20:03:56 <ThomasWaldmann> we don't have a pastebin yet in moin, so there is no other easy option. a new ticket should NOT just consist of an automatically generated traceback posting.
189 2012-08-12T20:22:14 <dreimark> ThomasWaldmann: yes, simple solution is to exchange it in werkzeug. but also what we want is in such a case not living that traceback in a pastebin
190 2012-08-12T20:22:51 <dreimark> it should be connected with a ticket or it should be added to that
191 2012-08-12T20:23:26 <ThomasWaldmann> yes, but that can only be done manually. otherwise you'll get a lot of duplicate and low quality tickets.
192 2012-08-12T20:23:41 <dreimark> hm, yes
193 2012-08-12T20:25:41 <dreimark> changed
194 2012-08-12T20:40:49 <ThomasWaldmann> spy: you have a shell account now
195 2012-08-12T20:51:11 *** dreimark
196 2012-08-12T20:51:11 *** dreimark
197 2012-08-12T21:28:16 * ThomasWaldmann plays with markdown converter
198
