1 2012-10-01T00:01:11 <ThomasWaldmann> http://codereview.appspot.com/6596046 < whoosh fix, please review
2 2012-10-01T00:05:09 <RogerHaase> dreimark: wants to work but format is messed up in IE9: http://test.moinmo.in/SVGTEST-IE9svgdraw
3 2012-10-01T00:05:37 <ThomasWaldmann> xiaq: ^^
4 2012-10-01T00:08:20 <RogerHaase> gtg
5 2012-10-01T00:08:25 *** RogerHaase
6 2012-10-01T00:27:27 *** spy
7 2012-10-01T00:31:44 <dreimark> ThomasWaldmann: added some comments
8 2012-10-01T00:36:12 <ThomasWaldmann> replied
9 2012-10-01T06:11:22 <sunu> ThomasWaldmann: http://pastebin.com/2bmSnXvU
10 2012-10-01T06:11:55 <sunu> ThomasWaldmann: may be we should not remove pytest while creating support directory ?
11 2012-10-01T07:54:28 *** grzywacz
12 2012-10-01T07:54:28 *** grzywacz
13 2012-10-01T08:45:52 <xiaq> ThomasWaldmann: i came to notice that are at least 4 places where discussions on moin development happen: irc, bitbucket issue tracker, codereview, etherpad. do you find this a problem? :)
14 2012-10-01T08:54:19 <xiaq> ThomasWaldmann: http://etherpad.osuosl.org/moin-priority-in-registry line28
15 2012-10-01T09:06:32 <xiaq> ThomasWaldmann: http://codereview.appspot.com/6589046/ i've added back priority to RegistryContent.Entry
16 2012-10-01T09:31:35 <xiaq> ThomasWaldmann: http://codereview.appspot.com/6497100/ updated
17 2012-10-01T09:36:07 <xiaq> ThomasWaldmann: pull request sent, please check
18 2012-10-01T09:36:51 <xiaq> (pull request for "Replace ITEMTYPES with information collected in item_registry")
19 2012-10-01T09:45:01 <xiaq> ah, turns out i have the privilege to edit my issues on whoosh's issue tracker...
20 2012-10-01T09:45:55 <xiaq> ThomasWaldmann: how would you like https://bitbucket.org/mchaput/whoosh/issue/292/query-term-a-b-not-term-a-b-finds-nothing edited?
21 2012-10-01T10:10:02 *** spy
22 2012-10-01T10:42:38 <dreimark> moin
23 2012-10-01T10:44:56 <dreimark> xiaq: and the wiki ;)
24 2012-10-01T10:46:22 <dreimark> if we had etherpad functionality in +modify we could remove this dependency
25 2012-10-01T10:46:48 <dreimark> but cr and bitbucket is difficultier
26 2012-10-01T10:58:07 <xiaq> dreimark: comparitive case of difficult is "more difficult" :)
27 2012-10-01T11:24:41 <sunu> dreimark: going through all the resources you have collected at http://moinmo.in/ReimarBauer . Nice :)
28 2012-10-01T11:24:53 *** greg_f
29 2012-10-01T11:39:40 *** grzywacz
30 2012-10-01T13:06:09 *** ChanServ
31 2012-10-01T13:07:27 *** ChanServ
32 2012-10-01T13:07:27 *** zelazny.freenode.net
33 2012-10-01T13:20:49 <ThomasWaldmann> sunu: moin does not need pytest for production, only for testing (usually by developers)
34 2012-10-01T13:23:03 <ThomasWaldmann> sunu: you found a bug :)
35 2012-10-01T13:24:00 <ThomasWaldmann> rst_in should of course not import pytest and there is also a TODO
36 2012-10-01T13:26:53 <ThomasWaldmann> xiaq: the whoosh issue doesn't need editing any more. i though about a slightly improved code sample for there, but there is now a unit test
37 2012-10-01T13:36:41 <ThomasWaldmann> xiaq: i don't find using different services at different places a problem. it just should be made sure that stuff that should be permanent is not put at temporary locations (like pastebins, etherpads).
38 2012-10-01T13:42:34 <ThomasWaldmann> xiaq: http://etherpad.osuosl.org/moin-priority-in-registry looks ok
39 2012-10-01T13:49:34 *** dwcramer
40 2012-10-01T13:55:27 <ThomasWaldmann> xiaq: reviews done
41 2012-10-01T14:02:10 <moinBot> http://hg.moinmo.in/moin/2.0/rev/a38ad19c9e7c 2012-10-01 Cheer Xiao Replace ITEMTYPES with information collected in item_registry.
42 2012-10-01T14:34:47 <sunu> ThomasWaldmann:after commenting out the pytest lines it all works fine. So what should I do now ?
43 2012-10-01T14:35:48 <ThomasWaldmann> you can make a separate commit from that
44 2012-10-01T14:38:21 <sunu> A commit to comment out tose 2 lines ?
45 2012-10-01T14:38:35 *** spy
46 2012-10-01T14:42:02 <ThomasWaldmann> sunu: no, to remove them
47 2012-10-01T14:53:59 <sunu> ThomasWaldmann: ok :)
48 2012-10-01T15:06:10 <sunu> ThomasWaldmann: sent a pull request
49 2012-10-01T15:08:33 *** sunu
50 2012-10-01T15:10:54 *** sunu
51 2012-10-01T15:13:19 *** moinBot
52 2012-10-01T15:17:49 <sunu> ThomasWaldmann: another pull request sent ( the makefile )
53 2012-10-01T15:19:51 <sunu> ThomasWaldmann: btw the previous one the 100th pull request :D
54 2012-10-01T15:20:03 *** dave_largo
55 2012-10-01T15:23:22 *** greg_f
56 2012-10-01T15:34:20 <ThomasWaldmann> sunu: :)
57 2012-10-01T15:35:14 <sunu> ThomasWaldmann: what next ?
58 2012-10-01T15:37:28 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/267/gae-optimize-static-files-serving
59 2012-10-01T15:39:36 <sunu> which sections of the repo should I look into ?
60 2012-10-01T15:43:06 <ThomasWaldmann> you could maybe start with optimizing the favicon
61 2012-10-01T15:44:07 <ThomasWaldmann> you need to keep the python code related to it, just let GAE handle the request (before moin's python code gets it)
62 2012-10-01T16:02:17 *** dwcramer
63 2012-10-01T16:04:42 <sunu> ThomasWaldmann: specifying handlers for static files in app.yaml will do ?
64 2012-10-01T16:06:34 <ThomasWaldmann> try :)
65 2012-10-01T16:07:56 <ThomasWaldmann> (not sure, but maybe it can be seen from the response headers what exactly handled the request. if not, you could just send different data to see whether it works.
66 2012-10-01T16:07:59 <ThomasWaldmann> )
67 2012-10-01T16:08:22 <sunu> ok :)
68 2012-10-01T16:19:15 <dreimark> sunu: thx
69 2012-10-01T16:21:30 <dreimark> late answer 09:24
70 2012-10-01T17:24:53 <xiaq> ThomasWaldmann: what about having some fancy colors in RepoMonitor's changeset message like CIA did, as i mentioned yesterday? :)
71 2012-10-01T17:26:23 *** spy
72 2012-10-01T17:40:10 <xiaq> ThomasWaldmann: how do i test whether `Prefix(k, '') & Prefix(k, 'lorem')` gets optimized by Whoosh or not? I supposed there to be a Query.optimize, but there isn't :)
73 2012-10-01T17:42:36 <xiaq> ThomasWaldmann: pull request sent please check :)
74 2012-10-01T18:03:19 <sunu> ThomasWaldmann: http://codereview.appspot.com/6586053 . review please :)
75 2012-10-01T18:03:31 *** Trip_
76 2012-10-01T18:08:35 * dreimark can't remember if there were colors for cia.vc enabled on irssi, was it?
77 2012-10-01T18:09:59 <dreimark> sunu: is robots.txt needed as file?
78 2012-10-01T18:13:14 <dreimark> http://hg.moinmo.in/moin/2.0/file/7657798d40f3/MoinMoin/apps/frontend/views.py#l79
79 2012-10-01T18:13:20 <dreimark> this did not work ?
80 2012-10-01T18:17:12 <sunu> dreimark: ThomasWaldmann commented in the issue about making a separate file for robots.txt
81 2012-10-01T18:17:24 <sunu> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/267/gae-optimize-static-files-serving
82 2012-10-01T18:17:31 <sunu> ^ there
83 2012-10-01T18:18:21 <dreimark> ah, ok missed that 2h ago
84 2012-10-01T18:26:10 <dreimark> bbl
85 2012-10-01T18:37:23 <xiaq> ThomasWaldmann: http://codereview.appspot.com/6595048/ i feel a better commit log is required
86 2012-10-01T18:37:29 <xiaq> dreimark: ^^
87 2012-10-01T18:52:54 <ThomasWaldmann> xiaq: i tried colour, but it somehow didn't work
88 2012-10-01T18:53:21 <ThomasWaldmann> (but crashed RepoMonitor or supybot)
89 2012-10-01T18:57:28 <ThomasWaldmann> sunu: review done
90 2012-10-01T18:58:16 <ThomasWaldmann> dreimark: i think it is better to have robots.txt as a file as it can then be served by moin as well as by the web server
91 2012-10-01T19:01:03 <ThomasWaldmann> xiaq: review doen
92 2012-10-01T19:01:05 <ThomasWaldmann> done
93 2012-10-01T19:01:54 <ThomasWaldmann> xiaq: about whoosh optimizations: read the code? or practically try with huge dataset...
94 2012-10-01T19:02:07 <xiaq> ThomasWaldmann: suggestions for the commit log "demote priority ..."?
95 2012-10-01T19:02:36 <xiaq> ThomasWaldmann: ok, i'll go the latter :)
96 2012-10-01T19:02:45 <xiaq> (about testing whoosh optimization)
97 2012-10-01T19:02:48 <ThomasWaldmann> demote priority in ... registries?
98 2012-10-01T19:03:46 <xiaq> ThomasWaldmann: "demote" is perhaps not the best word
99 2012-10-01T19:12:34 <xiaq> how do i pour a local name into timeit() ?
100 2012-10-01T19:15:09 <xiaq> hm, i used a null-argument lambda instead
101 2012-10-01T19:16:45 <xiaq> concluded: there is no optimization for Prefix(k, '') in whoosh 1.4. it is considerably slower than Every() in an index of 2000 documents
102 2012-10-01T19:16:56 <ThomasWaldmann> 1.4?
103 2012-10-01T19:17:03 <ThomasWaldmann> you mean 2.4?
104 2012-10-01T19:17:34 <xiaq> ThomasWaldmann: ah, the version moin2 current depends on :)
105 2012-10-01T19:17:36 <ThomasWaldmann> if you have a repo checkout, also try 2.5 branch, it is quite different at some places
106 2012-10-01T19:17:49 <ThomasWaldmann> or give me you test code then i run it later
107 2012-10-01T19:21:59 <xiaq> ThomasWaldmann: http://bpaste.net/show/nHNGo4NmwAxSsoFXpKQN/
108 2012-10-01T19:23:05 <sunu> ThomasWaldmann: http://codereview.appspot.com/6586053 updated, but the previous ones worked too. I got 304 ok in both the server logs and chrome developer tools. Not sure about favicon and robots.txt though. They were not there
109 2012-10-01T19:25:27 <xiaq> ThomasWaldmann: installed whoosh 2.5, similiar result for first 3, the last crashes whoosh
110 2012-10-01T19:28:33 <ThomasWaldmann> oops. can you file a bug for the crasher?
111 2012-10-01T19:29:56 * xiaq goes to bed, will look into that tomorrow :) gn
112 2012-10-01T19:30:22 <xiaq> ThomasWaldmann: i have a pull req in case you missed it
113 2012-10-01T19:32:42 <ThomasWaldmann> xiaq: btw, "with" works for the writer also
114 2012-10-01T19:33:04 <ThomasWaldmann> xiaq: i'll have a look at the PR later
115 2012-10-01T19:33:11 <ThomasWaldmann> gn xiaq
116 2012-10-01T19:33:37 <xiaq> ThomasWaldmann: gn :)
117 2012-10-01T19:36:42 <sunu> ThomasWaldmann: http://bpaste.net/show/48765/
