1 2012-12-13T00:13:12  <dreimark> gn
   2 2012-12-13T01:09:08  *** xjjk has joined #moin-dev
   3 2012-12-13T02:16:43  *** xiaq_ has joined #moin-dev
   4 2012-12-13T02:17:45  *** breton_ has joined #moin-dev
   5 2012-12-13T02:20:13  *** breton has quit IRC
   6 2012-12-13T02:20:13  *** xiaq has quit IRC
   7 2012-12-13T03:50:58  *** MattMaker has quit IRC
   8 2012-12-13T03:57:45  *** MattMaker has joined #moin-dev
   9 2012-12-13T05:27:51  *** dwcramer has quit IRC
  10 2012-12-13T09:26:40  <dreimark> moin
  11 2012-12-13T10:43:22  *** MattMaker has quit IRC
  12 2012-12-13T11:31:05  *** greg_f has joined #moin-dev
  13 2012-12-13T12:30:05  *** eSyr has quit IRC
  14 2012-12-13T12:30:59  *** eSyr has joined #moin-dev
  15 2012-12-13T13:55:14  <sunu> ThomasWaldmann: https://codereview.appspot.com/6847099/ Updated.
  16 2012-12-13T14:16:22  *** dave_largo has joined #moin-dev
  17 2012-12-13T14:24:36  *** bruno_ has joined #moin-dev
  18 2012-12-13T15:15:19  *** RogerHaase has joined #moin-dev
  19 2012-12-13T17:07:46  <ThomasWaldmann> hi sunu
  20 2012-12-13T17:09:47  <sunu> hi ThomasWaldmann :)
  21 2012-12-13T17:11:47  *** dwcramer has joined #moin-dev
  22 2012-12-13T17:25:37  <ThomasWaldmann> sunu: review done
  23 2012-12-13T17:26:01  <ThomasWaldmann> we are getting closer to a good solution. :)
  24 2012-12-13T17:27:37  <ThomasWaldmann> TarFile.close()
  25 2012-12-13T17:27:37  <ThomasWaldmann> Close the TarFile. In write mode, two finishing zero blocks are appended to the archive.
  26 2012-12-13T17:27:52  <ThomasWaldmann> hmm, maybe check that.
  27 2012-12-13T17:28:48  <ThomasWaldmann> the code currently just closes the fileobj (StringIO), but i think it likely should first close the TarFile, then store the stuff from the StringIO into our storage, the close the StringIO
  28 2012-12-13T17:29:46  <ThomasWaldmann> sunu: btw, what do you think about using a dict instead of a tuple of 2 lists?
  29 2012-12-13T17:30:28  <ThomasWaldmann> i think it would make the code easier and the set stuff would be as easy as now.
  30 2012-12-13T17:31:55  <sunu> ThomasWaldmann: Yeah using dict will make it easier to read and understand too :)
  31 2012-12-13T17:32:14  <sunu> I'll update nd upload.
  32 2012-12-13T17:50:44  <ThomasWaldmann> sunu: one more thing
  33 2012-12-13T17:51:22  <ThomasWaldmann> if you look at the put_member docstring, you see that content maybe either file-like or str
  34 2012-12-13T17:52:11  <ThomasWaldmann> so, you'll still need that delete code we wondered about recently
  35 2012-12-13T17:54:27  <ThomasWaldmann> deleted* code
  36 2012-12-13T18:10:39  <sunu> ThomasWaldmann: updated https://codereview.appspot.com/6847099/
  37 2012-12-13T18:15:31  <dreimark> is it possible to set a flag, or how can I see if there is data still submitting
  38 2012-12-13T18:16:33  <dreimark> e.g. if the file is finished, send redirect
  39 2012-12-13T18:36:33  *** greg_f has quit IRC
  40 2012-12-13T19:02:53  <ThomasWaldmann> sunu: review done, hope it's clearer now
  41 2012-12-13T19:07:22  <ThomasWaldmann> dreimark: the code only knows that by comparing the files it has with the set of filenames it expects
  42 2012-12-13T19:11:34  *** dave_largo has quit IRC
  43 2012-12-13T19:21:01  *** ebo^ has joined #moin-dev
  44 2012-12-13T20:10:25  *** MattMaker has joined #moin-dev
  45 2012-12-13T20:50:28  *** MattMaker has quit IRC
  46 2012-12-13T21:03:19  *** MattMaker has joined #moin-dev
  47 2012-12-13T21:28:36  *** Trip_ has joined #moin-dev
  48 2012-12-13T21:36:40  *** MattMaker has quit IRC
  49 2012-12-13T21:44:18  *** ebo_ has joined #moin-dev
  50 2012-12-13T21:45:37  *** eSyr-ng_ has joined #moin-dev
  51 2012-12-13T21:48:03  *** jek_ has joined #moin-dev
  52 2012-12-13T21:49:29  *** ebo^ has quit IRC
  53 2012-12-13T21:49:29  *** eSyr-ng has quit IRC
  54 2012-12-13T21:49:29  *** jek has quit IRC
  55 2012-12-13T21:51:18  <RogerHaase> ThomasWaldmann:  have time to review 3 small changes?  https://codereview.appspot.com/6928049/  https://codereview.appspot.com/6902067/  https://codereview.appspot.com/6904063/
  56 2012-12-13T22:35:07  <ThomasWaldmann> hi RogerHaase
  57 2012-12-13T22:35:38  <RogerHaase> moin :)
  58 2012-12-13T22:46:26  *** ebo_ has quit IRC
  59 2012-12-13T22:49:20  *** Trip_ is now known as MattMaker
  60 2012-12-13T22:49:21  <ThomasWaldmann> RogerHaase: made some comments
  61 2012-12-13T23:18:05  *** RogerHaase has left #moin-dev
  62 2012-12-13T23:22:05  *** bruno_ has quit IRC
  63

MoinMoin: MoinMoinChat/Logs/moin-dev/2012-12-13 (last edited 2012-12-12 23:15:04 by IrcLogImporter)