MoinMoin: MoinMoinChat/Logs/moin-dev/2013-01-30

   1 2013-01-30T00:10:38  *** dwcramer has quit IRC
   2 2013-01-30T00:15:50  *** ronny has quit IRC
   3 2013-01-30T01:27:19  *** dwcramer has joined #moin-dev
   4 2013-01-30T03:01:38  *** MattMaker has quit IRC
   5 2013-01-30T03:07:47  *** MattMaker has joined #moin-dev
   6 2013-01-30T04:34:07  *** MattMaker has quit IRC
   7 2013-01-30T04:40:31  *** MattMaker has joined #moin-dev
   8 2013-01-30T06:08:13  *** dwcramer has quit IRC
   9 2013-01-30T06:23:09  *** dwcramer has joined #moin-dev
  10 2013-01-30T08:33:43  *** ronny has joined #moin-dev
  11 2013-01-30T08:33:43  *** ronny has joined #moin-dev
  12 2013-01-30T09:21:45  *** greg_f has joined #moin-dev
  13 2013-01-30T09:27:26  <xiaq> ThomasWaldmann: https://codereview.appspot.com/7232058/
  14 2013-01-30T09:37:56  <xiaq> ThomasWaldmann: empty and not-present (in metadata editor) can be differentiated by adding a checkbox for each field
  15 2013-01-30T10:33:58  <dreimark> moin
  16 2013-01-30T11:11:03  *** ronny has quit IRC
  17 2013-01-30T12:28:11  *** ronny has joined #moin-dev
  18 2013-01-30T12:28:13  *** ronny has joined #moin-dev
  19 2013-01-30T13:39:36  <ThomasWaldmann> wb xiaq
  20 2013-01-30T13:40:11  <xiaq> i just found out that unusual http headers break moin2 in various places, where `request.method in ['POST', 'GET']` is assumed to be true
  21 2013-01-30T13:40:21  <xiaq> ThomasWaldmann: thanks :)
  22 2013-01-30T13:41:02  <xiaq> e.g. try this: `curl -I http://127.0.0.1:8080/+modify/Home` (assuming you run moin at :8080)
  23 2013-01-30T13:41:54  <xiaq> btw curl -I means request.method = 'HEAD'
  24 2013-01-30T13:43:06  * ThomasWaldmann will try soon, just updating the venv
  25 2013-01-30T13:43:23  <xiaq> guess how i spot it - i installed a firefox addon that actively checks for broken links in my history and deletes them. turns out it works by sending HEAD requests
  26 2013-01-30T13:43:25  <xiaq> ThomasWaldmann: ok :)
  27 2013-01-30T13:47:48  <xiaq> ah, seems like a flask bug. @frontend.route('/+modify/<itemname:item_name>', methods=['GET', 'POST'])nevertheless HEAD requests do get routed...
  28 2013-01-30T13:49:07  <ThomasWaldmann> yeah, got an exception UnboundLocalError: local variable 'form' referenced before assignment
  29 2013-01-30T13:49:20  <ThomasWaldmann> can you file a bug, please?
  30 2013-01-30T13:49:58  <xiaq> ThomasWaldmann: uh, just found out this: By default a rule just listens for GET (and implicitly HEAD).
  31 2013-01-30T13:50:28  <xiaq> http://http://flask.pocoo.org/docs/api (and search for HEAD, matching case)
  32 2013-01-30T13:51:22  <xiaq> so it's still moin's bug :)
  33 2013-01-30T13:51:54  <ThomasWaldmann> yes, i also think so. likely some == HEAD instead of 'in ["HEAD", "GET", ]'
  34 2013-01-30T13:53:02  *** dave_largo has joined #moin-dev
  35 2013-01-30T13:54:55  <xiaq> ThomasWaldmann: O.o "== HEAD" for what?
  36 2013-01-30T13:54:59  * xiaq afk for a moment...
  37 2013-01-30T13:59:48  <ThomasWaldmann> or == "GET". I mean just checking a single case instead of both.
  38 2013-01-30T13:59:57  <ThomasWaldmann> review done
  39 2013-01-30T14:19:44  <xiaq> ThomasWaldmann: i'd rather go "!= 'POST'" which requires fewest code changes :)
  40 2013-01-30T14:38:00  <xiaq> ThomasWaldmann: https://codereview.appspot.com/7221074
  41 2013-01-30T14:38:40  *** dwcramer has quit IRC
  42 2013-01-30T15:04:21  *** dwcramer has joined #moin-dev
  43 2013-01-30T15:14:59  *** dwcramer has quit IRC
  44 2013-01-30T15:19:20  *** bruno_ has joined #moin-dev
  45 2013-01-30T15:34:01  *** RogerHaase has joined #moin-dev
  46 2013-01-30T15:35:02  <ThomasWaldmann> xiaq: the question is if != POST is precise enough. there are some other methods...
  47 2013-01-30T16:15:49  <xiaq> ThomasWaldmann: as long as only GET, POST and HEAD are concerned, which is the case now. perhaps moin can use PUT for rpc later?
  48 2013-01-30T16:40:16  *** dennda_ has joined #moin-dev
  49 2013-01-30T16:40:24  *** dennda_ has joined #moin-dev
  50 2013-01-30T16:40:54  *** dennda_ has left #moin-dev
  51 2013-01-30T16:58:25  *** dwcramer has joined #moin-dev
  52 2013-01-30T17:28:25  <dreimark> at least a # XXX should be added to find this location next time faster#
  53 2013-01-30T17:31:31  <dreimark> bbl
  54 2013-01-30T17:36:18  <RogerHaase> ThomasWaldmann: test.moinmo.in is giving internal server errors
  55 2013-01-30T18:04:46  <ThomasWaldmann> RogerHaase: trying to fix it ...
  56 2013-01-30T18:10:57  <ThomasWaldmann> ah, now it has the new error handling :P
  57 2013-01-30T18:23:24  <ThomasWaldmann> ok, fresh and empty wiki there now
  58 2013-01-30T18:28:15  *** greg_f has quit IRC
  59 2013-01-30T18:48:40  <RogerHaase> ThomasWaldmann:  another try on #314 Comments with internal markup render incorrectly:  https://codereview.appspot.com/7220049/
  60 2013-01-30T18:51:28  *** dwcramer has quit IRC
  61 2013-01-30T20:08:38  *** dwcramer has joined #moin-dev
  62 2013-01-30T20:17:43  * ThomasWaldmann is at LUG meeting
  63 2013-01-30T21:12:38  *** ronny has quit IRC
  64 2013-01-30T21:46:07  <dreimark> re
  65 2013-01-30T21:56:35  *** ronny has joined #moin-dev
  66 2013-01-30T22:11:58  <dreimark> RogerHaase: have we a test wich also looks at mismatches of amount of "'" ?
  67 2013-01-30T22:12:25  <dreimark> and are now all variations of those in the tests
  68 2013-01-30T22:14:36  <RogerHaase> dreimark: there is one with 6 ' before and 4 after:  ("Text''''''Text''''",
  69 2013-01-30T22:21:42  *** dave_largo has quit IRC
  70 2013-01-30T22:28:19  <dreimark> RogerHaase: in the past the following words in the rest of the page had the formatting of the leftovers
  71 2013-01-30T22:28:41  <dreimark> (sometimes not wanted but likly correct)
  72 2013-01-30T22:37:44  <RogerHaase> tried various combinations of wrong numbers of ' , the output seems reasonable given the erroneous input
  73 2013-01-30T22:42:04  <dreimark> ok