1 2013-02-10T00:29:24 * ThomasWaldmann bets the new acl processing will blow some minds
2 2013-02-10T00:40:54 <xiaq> ThomasWaldmann: better move to main tracker :)
3 2013-02-10T00:43:15 <ThomasWaldmann> xiaq: ok, can you do it?
4 2013-02-10T00:44:34 <xiaq> ThomasWaldmann: ok, will do it later
5 2013-02-10T00:46:16 <ThomasWaldmann> acls -> users might have multiple names, items might have multiple names, multiple parents for hierarchical acls
6 2013-02-10T01:25:07 *** ronny
7 2013-02-10T01:59:36 *** bilal
8 2013-02-10T02:05:42 <ThomasWaldmann> existing tests succeed with new algorithm \o/
9 2013-02-10T02:55:56 <xiaq> ThomasWaldmann: http://codereview.appspot.com/7305073 minor refactor
10 2013-02-10T02:56:56 <xiaq> ThomasWaldmann: PR: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/128 fixing HEAD
11 2013-02-10T02:58:57 <xiaq> ThomasWaldmann: there are quite some duplicate codes in stylesheets of modernized and foobar - i think we need a clear line between styles customizable by themes and not customizable. do you have any ideas?
12 2013-02-10T03:02:01 <xiaq> things are simple for color_palette.styl, mime_type_icons.styl - themes simply fill in the slots. but where styles involve a lot of layout it can be tricky
13 2013-02-10T03:05:48 <xiaq> ThomasWaldmann: there seems no direct support to move issues around in BB. have to copy-paste
14 2013-02-10T03:15:40 *** bilal
15 2013-02-10T03:29:24 <ThomasWaldmann> xiaq: yeah, i expected c&p
16 2013-02-10T03:30:41 <ThomasWaldmann> about cleaning up themes: maybe rather wait until the merge is done (and help making it possible)
17 2013-02-10T03:46:43 <ThomasWaldmann> index stuff is more important for that
18 2013-02-10T05:23:27 *** xorAxAx
19 2013-02-10T05:24:09 *** xorAxAx
20 2013-02-10T08:32:30 *** ronny
21 2013-02-10T12:11:59 <xiaq> ThomasWaldmann: https://codereview.appspot.com/7300080/ Remove Submit widget (which was a mistake)
22 2013-02-10T12:18:18 *** xiaq
23 2013-02-10T12:20:04 *** xiaq
24 2013-02-10T12:21:01 <xiaq> server down :(, came back on laptop
25 2013-02-10T13:01:29 * xiaq having a sloooooooooooooow connection to bb...
26 2013-02-10T13:08:39 <dreimark> xiaq: i missed the discussion about removing Submit. Is Submit anywhere else used?
27 2013-02-10T13:09:22 <xiaq> dreimark: i brought that up long ago... i've converted all usages of Submit
28 2013-02-10T13:09:34 <dreimark> ah, ok
29 2013-02-10T13:09:46 <xiaq> making Submit a widget screws up http form handling
30 2013-02-10T13:10:05 <xiaq> it doesn't carry any user-supplied information, so the semantics is also questionable
31 2013-02-10T13:10:44 <xiaq> dreimark: check out the diff and it does improve the code somehow :)
32 2013-02-10T13:11:13 <dreimark> less code doing the same is always wanted ;)
33 2013-02-10T13:13:03 <xiaq> dreimark: natürlich :)
34 2013-02-10T13:20:08 <dreimark> xiaq: i looked in it but unfortunately i have to run now, added one comment yet
35 2013-02-10T13:20:13 <dreimark> bbl
36 2013-02-10T13:21:25 <xiaq> dreimark: replied
37 2013-02-10T13:57:44 <xiaq> ThomasWaldmann: which branches will likely have merge conflicts if i get down to refactoring themes? `hg diff -r default -r namespaces` reveals that namespaces branch doesn't involve themes code
38 2013-02-10T14:28:23 *** RogerHaase
39 2013-02-10T14:50:34 *** xiaq
40 2013-02-10T15:03:40 <ThomasWaldmann> moin
41 2013-02-10T15:20:03 *** bilal
42 2013-02-10T15:32:24 * ThomasWaldmann fine tweaks some stuff
43 2013-02-10T15:32:45 <ThomasWaldmann> guess the not-logged in user will now have the name "anonymous"
44 2013-02-10T15:33:28 <ThomasWaldmann> (it had 0 names yet, but that causes special cases that can be avoided that way)
45 2013-02-10T16:18:53 *** bilal
46 2013-02-10T16:23:58 *** dwcramer
47 2013-02-10T16:55:19 <sunu> ThomasWaldmann: is https://codereview.appspot.com/7289046 ok now ?
48 2013-02-10T16:58:29 <ThomasWaldmann> hmm, somehow modifying wiki items is broken in namespaces branch...
49 2013-02-10T16:58:48 <ThomasWaldmann> (itemtype form field is empty)
50 2013-02-10T17:00:11 <ThomasWaldmann> sunu: i left some comments 21h ago
51 2013-02-10T17:01:07 <ThomasWaldmann> e.g. "did you test the scripts after your changes"
52 2013-02-10T17:05:44 <ThomasWaldmann> hmm, default branch also broken
53 2013-02-10T17:06:51 <ThomasWaldmann> ah, it's the serialized items, they don't have the "itemtype" stuff yet
54 2013-02-10T17:11:09 *** dwcramer
55 2013-02-10T17:15:53 *** dwcramer
56 2013-02-10T17:18:29 <moinBot> http://hg.moinmo.in/moin/2.0/rev/b0bb5cb08e44 2013-02-10 Cheer Xiao add (failing) tests for HEAD requests
57 2013-02-10T17:18:30 <moinBot> http://hg.moinmo.in/moin/2.0/rev/f05af7eb6f50 2013-02-10 Cheer Xiao fix handling of HEAD requests
58 2013-02-10T17:18:31 <moinBot> http://hg.moinmo.in/moin/2.0/rev/0ae95dd0969e 2013-02-10 Thomas Waldmann <tw AT waldmann-edv DOT de> temporary hack to add itemtype meta when unserializing files that don't have it
59 2013-02-10T17:18:32 <moinBot> http://hg.moinmo.in/moin/2.0/rev/7fe3283f9eeb 2013-02-10 Thomas Waldmann <tw AT waldmann-edv DOT de> added itemtype meta to serialized sample items
60 2013-02-10T17:27:47 <moinBot> http://hg.moinmo.in/moin/2.0/rev/46e8aa18c4d1 2013-02-10 Thomas Waldmann <tw AT waldmann-edv DOT de> namespaces merged default branch into namespaces branch
61 2013-02-10T17:27:48 <moinBot> http://hg.moinmo.in/moin/2.0/rev/2a61ee6e35a5 2013-02-10 Thomas Waldmann <tw AT waldmann-edv DOT de> namespaces added itemtype meta to serialized sample items
62 2013-02-10T17:28:49 *** dwcramer
63 2013-02-10T17:34:49 <ThomasWaldmann> guess i'll merge namespaces into default branch rather soon if noone/nothing stops me :)
64 2013-02-10T17:38:18 <sunu> ThomasWaldmann: sorry. forgot to reply. all commands do work.
65 2013-02-10T17:38:36 <ThomasWaldmann> ok, then commit
66 2013-02-10T17:40:22 <sunu> ok
67 2013-02-10T17:43:52 <ThomasWaldmann> interesting, global index is now empty in namespaces. maybe xiaq's changes were not compatible. but it was somehow broken before also...
68 2013-02-10T17:51:29 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0/rev/70c534eb5596#l1.63
69 2013-02-10T17:51:34 *** RogerHaase
70 2013-02-10T17:51:41 <ThomasWaldmann> to be OR not(to be) ?
71 2013-02-10T17:52:22 <ThomasWaldmann> xiaq: ^^^
72 2013-02-10T17:53:35 *** RogerHaase
73 2013-02-10T17:54:28 <ThomasWaldmann> if i deselect "unkown items", it shows all items (when having it selected: it shows nothing)
74 2013-02-10T17:55:00 <ThomasWaldmann> so this does not work as expected, but also not as a tautology
75 2013-02-10T17:56:19 <RogerHaase> I pulled 5 min ago, global index shows all items for me
76 2013-02-10T17:56:36 * ThomasWaldmann is on namespaces branch
77 2013-02-10T17:56:46 <RogerHaase> same here
78 2013-02-10T17:57:01 <ThomasWaldmann> do you have unknown items checked in the item filter?
79 2013-02-10T17:58:48 <RogerHaase> when I deselect unknown items, my userid is omitted from the list
80 2013-02-10T17:59:11 <ThomasWaldmann> ok, that sounds like expected
81 2013-02-10T17:59:12 <RogerHaase> all other items are displayed
82 2013-02-10T18:00:11 <ThomasWaldmann> ok, i'll kill wiki/data and wiki/index, index-create -s -i, load the sample items, index-build, restart moin - can you do the same?
83 2013-02-10T18:01:50 <ThomasWaldmann> and delete the session cookie, otherwise it crashes
84 2013-02-10T18:02:31 <ThomasWaldmann> http://localhost:8080/%2Bindex/ empty for me
85 2013-02-10T18:03:49 <ThomasWaldmann> uncheck "unknown items" in filter -> shows all items
86 2013-02-10T18:04:11 <RogerHaase> where are the sample items?
87 2013-02-10T18:05:29 <ThomasWaldmann> rm -rf wiki/data/ wiki/index/
88 2013-02-10T18:05:39 <ThomasWaldmann> moin index-create -s -i
89 2013-02-10T18:05:49 <ThomasWaldmann> moin load --file contrib/serialized/items.moin
90 2013-02-10T18:05:59 <ThomasWaldmann> moin index-build
91 2013-02-10T18:08:22 <RogerHaase> global index shows 12 items, with or withou unknown checked
92 2013-02-10T18:09:12 <RogerHaase> my tip is 2a61ee6e35a5
93 2013-02-10T18:09:44 <ThomasWaldmann> 2a61ee6e35a5+ (namespaces) tip
94 2013-02-10T18:09:47 <ThomasWaldmann> hg id
95 2013-02-10T18:10:19 <ThomasWaldmann> oh, i didn't commit my acl/names stuff yet
96 2013-02-10T18:12:40 <ThomasWaldmann> i reverted all, now exactly on 2a61ee6e35a5
97 2013-02-10T18:12:45 <ThomasWaldmann> but still empty index
98 2013-02-10T18:13:56 <ThomasWaldmann> Whoosh==2.4.1 in pip freeze output, same for you?
99 2013-02-10T18:14:38 <RogerHaase> right 2.4.1
100 2013-02-10T18:15:02 <ThomasWaldmann> now it's getting weird :) what else could be different, aside from the OS?
101 2013-02-10T18:15:22 <ThomasWaldmann> shall we both rebuild the env?
102 2013-02-10T18:16:24 * ThomasWaldmann runs quickinstall
103 2013-02-10T18:18:03 <RogerHaase> ran quickinstall, still works. will delete env and try quickinstall again
104 2013-02-10T18:21:01 * ThomasWaldmann deleted env, ran quickinstall, erased storage, loaded items, ... and it is still empty
105 2013-02-10T18:21:29 <ThomasWaldmann> python 2.7.3
106 2013-02-10T18:23:03 <RogerHaase> python 2.6.5
107 2013-02-10T18:24:45 * ThomasWaldmann tries 2.6
108 2013-02-10T18:24:49 <RogerHaase> Have new env, index displays 12 items. Will delete and rebuild wiki next
109 2013-02-10T18:27:42 <RogerHaase> global index still working
110 2013-02-10T18:32:31 <RogerHaase> does history work for you? Global Index uses index_action.js
111 2013-02-10T18:33:52 <ThomasWaldmann> now with 2.6.8,index still empty
112 2013-02-10T18:37:09 <ThomasWaldmann> history shows some items for 2012-01-31
113 2013-02-10T18:37:30 <RogerHaase> did you try to view source to see if list is there but somehow hidden?
114 2013-02-10T18:37:39 <ThomasWaldmann> do you have some wikiconfig_local.py?
115 2013-02-10T18:38:45 <ThomasWaldmann> nothing in the html source
116 2013-02-10T18:39:37 <RogerHaase> yes http://rn0.ru/show/hkHQgSsFq87EAWRhPVSy/
117 2013-02-10T18:40:12 <ThomasWaldmann> can you temporarily rename it and try without?
118 2013-02-10T18:41:49 <ThomasWaldmann> RogerHaase: -> query
119 2013-02-10T18:42:49 <RogerHaase> renamed, global index still works
120 2013-02-10T18:47:08 <ThomasWaldmann> ok, what's left? python minor version, OS, anything else?
121 2013-02-10T18:51:42 <RogerHaase> back in 15 min
122 2013-02-10T19:02:45 <ThomasWaldmann> hmm, am i overlooking something?
123 2013-02-10T19:03:40 <ThomasWaldmann> as soon as one says "unknown items" in that filter, it means "all contenttypes", so we don't need to filter at all for them, right?
124 2013-02-10T19:05:41 <ThomasWaldmann> when patching it like that, it works for me as expected
125 2013-02-10T19:06:44 <RogerHaase> when I have only Unknown Items checked, only my logon item appears
126 2013-02-10T19:07:23 <ThomasWaldmann> yeah, also just noticed ...
127 2013-02-10T19:10:45 <ThomasWaldmann> it somehow looks like a whoosh bug. "or" should never reduce results.
128 2013-02-10T19:15:08 * ThomasWaldmann killed *whoosh* from the downloadcache
129 2013-02-10T19:15:38 <ThomasWaldmann> (not bold, but with wildcards :)
130 2013-02-10T19:20:08 <ThomasWaldmann> fsck, it was just me using a outdated whoosh version
131 2013-02-10T19:20:24 <ThomasWaldmann> from the downloadcache, it seems not to notice if it is stale
132 2013-02-10T19:20:55 <ThomasWaldmann> it now works as expected for the filters on index page
133 2013-02-10T19:25:23 * ThomasWaldmann runs tests again
134 2013-02-10T19:27:53 <RogerHaase> hmm, seems I have deleted things from the dlc with good results in the past.
135 2013-02-10T19:31:56 <moinBot> http://hg.moinmo.in/moin/2.0/rev/70b9962f1860 2013-02-10 Thomas Waldmann <tw AT waldmann-edv DOT de> namespaces acl processing: deal with users having multiple names, add tests
136 2013-02-10T19:36:21 <ThomasWaldmann> guess i'll try the merge-back now
137 2013-02-10T19:44:21 <ThomasWaldmann> merged flawlessly - somehow expected as i recently merged in the other direction.
138 2013-02-10T19:47:18 <moinBot> http://hg.moinmo.in/moin/2.0/rev/1bec42a6047b 2013-02-10 Thomas Waldmann <tw AT waldmann-edv DOT de> merged namespaces branch into default branch - expect some breakage
139 2013-02-10T19:55:42 <moinBot> http://hg.moinmo.in/moin/2.0/rev/7504b3dc43ac 2013-02-10 Thomas Waldmann <tw AT waldmann-edv DOT de> gae merged default branch into gae branch
140 2013-02-10T19:56:48 <ThomasWaldmann> sunu: ^^
141 2013-02-10T19:59:13 * ThomasWaldmann will do some global refactorings now
142 2013-02-10T20:03:14 <moinBot> http://hg.moinmo.in/moin/2.0/rev/7ad25fc92ee4 2013-02-10 Tarashish Mishra gae Added web interface for index operations
143 2013-02-10T20:03:15 <moinBot> http://hg.moinmo.in/moin/2.0/rev/a53c04dd16b6 2013-02-10 Thomas Waldmann <tw AT waldmann-edv DOT de> gae merged
144 2013-02-10T20:05:35 *** bilal
145 2013-02-10T20:07:54 *** dwcramer
146 2013-02-10T20:23:36 <RogerHaase> ThomasWaldmann: have some breakage on empty wiki: http://rn0.ru/show/1WsC5yJLhwkGEdNdV6Ry/ where user_names = [] and [] is from self.protector.user.name
147 2013-02-10T20:45:23 <RogerHaase> no, problem is in /security/__init__.py line 67. maybe should be self.names = user.name or 'anonymous'
148 2013-02-10T20:54:44 <ThomasWaldmann> hmm
149 2013-02-10T20:56:07 <dreimark> re
150 2013-02-10T20:56:24 <ThomasWaldmann> RogerHaase: did you kill the old backend contents?
151 2013-02-10T20:57:23 <RogerHaase> I deleted wiki and did index-build -s -i
152 2013-02-10T20:57:47 <ThomasWaldmann> 20:45 RogerHaase$ no, problem is in /security/__init__.py line 67. maybe should be self.names = user.name or 'anonymous'
153 2013-02-10T20:58:05 <ThomasWaldmann> no, user.name is a list and self.names should be also only a list
154 2013-02-10T20:58:36 <ThomasWaldmann> did you delete your old cookie?
155 2013-02-10T20:58:57 <RogerHaase> no, will try that
156 2013-02-10T20:59:31 <dreimark> should I also try to verify this issue ?
157 2013-02-10T20:59:58 <RogerHaase> deleting cookie works :)
158 2013-02-10T21:04:11 <ThomasWaldmann> if it accesses a userid with nothing in storage, that leads to this malfunction
159 2013-02-10T21:10:52 <dreimark> can this become a security issue?
160 2013-02-10T21:19:37 <ThomasWaldmann> well, it crashes
161 2013-02-10T22:06:59 *** dwcramer
162 2013-02-10T22:29:42 *** MattMaker
163 2013-02-10T22:32:30 *** MattMaker
164 2013-02-10T22:50:52 <moinBot> http://hg.moinmo.in/moin/2.0/rev/286e315935ae 2013-02-10 Thomas Waldmann <tw AT waldmann-edv DOT de> refactor usage of constants
165 2013-02-10T23:16:01 <RogerHaase> ThomasWaldmann: fix for 196 traceback when uploading multiple files on windows: https://codereview.appspot.com/7314078/
166 2013-02-10T23:17:06 <RogerHaase> traceback looks like this: http://rn0.ru/show/n7z8lkpXVeDwcfFZaXQi/
167 2013-02-10T23:27:51 *** RogerHaase
168 2013-02-10T23:28:50 *** MattMaker
169 2013-02-10T23:33:21 *** ronny
170 2013-02-10T23:47:55 *** bilal
171 2013-02-10T23:54:40 <moinBot> http://hg.moinmo.in/moin/2.0/rev/87272c032485 2013-02-10 Thomas Waldmann <tw AT waldmann-edv DOT de> remove unused imports
