1 2013-03-25T00:04:03  *** SteveMcIntyre has joined #moin-dev
   2 2013-03-25T00:11:20  *** SteveMcIntyre has quit IRC
   3 2013-03-25T00:11:20  *** SteveMcIntyre has joined #moin-dev
   4 2013-03-25T00:15:28  *** moinBot has joined #moin-dev
   5 2013-03-25T00:21:32  *** moinBot` has quit IRC
   6 2013-03-25T00:24:19  *** xiaq_ has quit IRC
   7 2013-03-25T00:28:15  *** MaikuMori has joined #moin-dev
   8 2013-03-25T00:32:27  *** vpv has quit IRC
   9 2013-03-25T00:32:31  *** vpv_ has joined #moin-dev
  10 2013-03-25T00:34:47  *** MaikuMori_ has quit IRC
  11 2013-03-25T00:43:12  *** xiaq_ has joined #moin-dev
  12 2013-03-25T00:56:36  *** eSyr has quit IRC
  13 2013-03-25T01:05:26  *** eSyr has joined #moin-dev
  14 2013-03-25T01:28:04  *** eSyr has quit IRC
  15 2013-03-25T01:29:37  <ThomasWaldmann> https://www.youtube.com/watch?v=nJff23UdNAI
  16 2013-03-25T01:30:56  *** eSyr has joined #moin-dev
  17 2013-03-25T01:44:28  *** xiaq_ has quit IRC
  18 2013-03-25T01:48:06  *** xiaq_ has joined #moin-dev
  19 2013-03-25T02:32:00  *** xiaq has joined #moin-dev
  20 2013-03-25T02:32:25  *** xiaq is now known as Guest24003
  21 2013-03-25T02:33:17  *** xiaq_ has quit IRC
  22 2013-03-25T04:07:18  *** ronny has joined #moin-dev
  23 2013-03-25T05:45:04  *** ThomasWaldman2 has joined #moin-dev
  24 2013-03-25T05:46:26  *** ThomasWaldmann has quit IRC
  25 2013-03-25T06:23:52  *** sharky93 has joined #moin-dev
  26 2013-03-25T07:12:24  *** sharky93 has quit IRC
  27 2013-03-25T07:57:30  *** rick_ has joined #moin-dev
  28 2013-03-25T08:06:22  *** nathen has joined #moin-dev
  29 2013-03-25T08:07:29  <nathen> hello
  30 2013-03-25T08:23:01  *** nathen has quit IRC
  31 2013-03-25T08:41:39  *** nathen has joined #moin-dev
  32 2013-03-25T08:41:51  <nathen> hello
  33 2013-03-25T08:43:09  <nathen> is it necesary to fix bugs before gsoc proposal application period?
  34 2013-03-25T08:52:45  <nathen> ThomasWaldman2:  dreimark ?
  35 2013-03-25T08:59:15  *** nathen has quit IRC
  36 2013-03-25T09:00:11  *** rihnapstor has joined #moin-dev
  37 2013-03-25T09:02:03  *** rihnapstor has quit IRC
  38 2013-03-25T09:02:03  *** rihnapstor has joined #moin-dev
  39 2013-03-25T09:02:03  *** rihnapstor has joined #moin-dev
  40 2013-03-25T09:03:44  *** greg_f has joined #moin-dev
  41 2013-03-25T09:19:02  <dreimark> moin
  42 2013-03-25T09:24:01  *** rihnapstor has quit IRC
  43 2013-03-25T10:06:19  *** haseeb has joined #moin-dev
  44 2013-03-25T11:09:19  *** ashutosh1461 has joined #moin-dev
  45 2013-03-25T12:13:37  <ashutosh1461> moin everyone :)
  46 2013-03-25T12:13:48  <ashutosh1461> ThomasWaldman2, issue updated https://codereview.appspot.com/7610050/#ps29001
  47 2013-03-25T12:27:36  *** Guest24003 is now known as xiaq
  48 2013-03-25T12:40:25  *** bruno_ has joined #moin-dev
  49 2013-03-25T13:00:03  *** dave_largo has joined #moin-dev
  50 2013-03-25T13:18:55  *** haseeb has quit IRC
  51 2013-03-25T13:46:52  *** vpv_ is now known as vpv
  52 2013-03-25T13:48:19  *** ronny_ has joined #moin-dev
  53 2013-03-25T13:50:13  *** ThomasWaldman2 is now known as ThomasWaldmann
  54 2013-03-25T13:50:40  *** ThomasWaldmann has joined #moin-dev
  55 2013-03-25T13:52:01  *** ronny has quit IRC
  56 2013-03-25T13:55:19  <ThomasWaldmann> ashutosh1461: review done
  57 2013-03-25T14:03:45  <ashutosh1461> ThomasWaldmann, @your comment, We combine files and dirs using MixedIndexEntry. It is useful when the item has further sub-items. see, https://bitbucket.org/thomaswaldmann/moin-2.0/src/4307c3e76076b9d8accc8ed13b5ac884a8f471a0/MoinMoin/items/__init__.py?at=default#cl-606
  58 2013-03-25T14:08:14  <ThomasWaldmann> ok
  59 2013-03-25T14:08:42  <ashutosh1461> and there are some tests, build_index, build_mixed_index and testIndex out of which  build_index and testIndex are failing due to the change in  IndexEntry.
  60 2013-03-25T14:12:27  <ashutosh1461> and the div change is irrelevant, no idea how it got there.
  61 2013-03-25T14:15:09  *** RogerHaase has joined #moin-dev
  62 2013-03-25T14:26:49  <ThomasWaldmann> ashutosh1461: ok, so do some practical tests and if you think stuff works ok already, have a look at the tests and make sure they are correct also
  63 2013-03-25T14:27:08  <ThomasWaldmann> (== not quite TDD :)
  64 2013-03-25T14:29:54  <ashutosh1461> hmm.. fine :)
  65 2013-03-25T14:34:53  <ashutosh1461> ThomasWaldmann, are there any other issues related to sub-items ?
  66 2013-03-25T14:43:48  <ashutosh1461> from where does this caller variable come? https://bitbucket.org/thomaswaldmann/moin-2.0/src/1faff598bbae2d41c7bcf9a5c4d06fb97800debb/MoinMoin/templates/utils.html?at=default#cl-85
  67 2013-03-25T15:01:57  <ThomasWaldmann> the issues come from NAME being a list
  68 2013-03-25T15:02:20  <ThomasWaldmann> and just see the issue tracker or click around practically :)
  69 2013-03-25T15:02:44  <ThomasWaldmann> index view and subitems panel is the stuff that comes to my mind, but there might be more
  70 2013-03-25T15:02:47  <ThomasWaldmann> ashutosh1461: ^
  71 2013-03-25T15:35:40  *** haseeb has joined #moin-dev
  72 2013-03-25T15:48:40  <RogerHaase> ThomasWaldmann: rihnapstor: added thoughts on alternatives to https://bitbucket.org/thomaswaldmann/moin-2.0/issue/347/navibar-link-for-home-should-be-item_root
  73 2013-03-25T15:50:31  <sunu> moin
  74 2013-03-25T15:50:57  <sunu> ThomasWaldmann: https://codereview.appspot.com/7988046 check for support directory before running moin.
  75 2013-03-25T15:57:23  <RogerHaase> ThomasWaldmann: gave up on trying to install pillow with pip on windows, installed binary version instead.  Also replaced PIL on my 1.9 test system to give it a better workout.  No issues other than have to change "import Image" to "from PIL import Image"
  76 2013-03-25T16:11:45  *** dcramer_ has quit IRC
  77 2013-03-25T16:50:01  *** dcramer_ has joined #moin-dev
  78 2013-03-25T17:01:47  <ashutosh1461> RogerHaase, I see no cancel button on the modification page in case a user has to cancel his current progress, and revert back to the previous version.
  79 2013-03-25T17:05:57  <RogerHaase> ashutaosh1461:  you can click any link to stop edit.  the cancel button was removed about a year ago.  If we implement edit lock on a page we may need the cancel button back
  80 2013-03-25T17:11:06  *** greg_f has quit IRC
  81 2013-03-25T17:17:44  *** sonakshi has joined #moin-dev
  82 2013-03-25T17:22:00  <ashutosh1461> RogerHaase, Please check the link the subitem and transclude sub item features, i guess they are not working properly.
  83 2013-03-25T17:24:11  *** sonakshi has quit IRC
  84 2013-03-25T17:51:41  *** haseeb has quit IRC
  85 2013-03-25T18:02:40  *** rihnapstor has joined #moin-dev
  86 2013-03-25T18:03:37  *** dcramer_ has quit IRC
  87 2013-03-25T18:07:18  *** rihen_ has joined #moin-dev
  88 2013-03-25T18:07:32  *** rihen_ has quit IRC
  89 2013-03-25T18:08:52  *** rihnapstor has quit IRC
  90 2013-03-25T18:08:52  *** rihnapstor has joined #moin-dev
  91 2013-03-25T18:12:28  *** sonakshi has joined #moin-dev
  92 2013-03-25T18:13:44  *** haseeb has joined #moin-dev
  93 2013-03-25T18:16:42  <ashutosh1461> ThomasWaldmann, linking and transcluding of subitems were not functioning properly, i have made some changes, https://codereview.appspot.com/7610050/#ps40001
  94 2013-03-25T18:17:04  <ashutosh1461> please review, testing done  2 failed, 612 passed, 59 skipped in 38.68 seconds.
  95 2013-03-25T18:19:02  *** dcramer_ has joined #moin-dev
  96 2013-03-25T18:24:12  <RogerHaase> ashutosh1461:  modify.html has tabs -- you need to set your editor to insert blanks instead of tabs or get another editor :)
  97 2013-03-25T18:25:12  <ashutosh1461> RogerHaase, which editor do you prefer? :)
  98 2013-03-25T18:31:48  <RogerHaase> I am usually on Windows and I use SciTe, but only because in year 2000 SciTE was only editor that I found that ran on Windows and Linux.  Maybe try Sublime Text 2 because that has highlighting for Stylus files.  Or maybe someone else can advise.
  99 2013-03-25T18:37:10  * ThomasWaldmann uses vim for small work, PyCharm for bigger/longer stuff
 100 2013-03-25T18:38:29  * sunu loves sublime test :)
 101 2013-03-25T18:38:53  * sunu loves sublime text 2*
 102 2013-03-25T18:41:53  <RogerHaase> ashutosh1461: ^^ another thing you can do is when you upload a patch, check code review yourself before you ask for review.  If you find an error, there is a "Delete patch set" link so you erase your mistake before anyone notices
 103 2013-03-25T18:42:59  <rihnapstor> moin all :)
 104 2013-03-25T18:51:37  * ThomasWaldmann fixes some old moin plugin code
 105 2013-03-25T18:54:59  *** dcramer_ has quit IRC
 106 2013-03-25T19:02:42  *** sonakshi has quit IRC
 107 2013-03-25T19:10:03  *** dcramer_ has joined #moin-dev
 108 2013-03-25T19:17:50  <RogerHaase> ashutosh1461: updated #335 noting another subitem link problem
 109 2013-03-25T19:30:50  <ashutosh1461> RogerHaase, updated :) https://codereview.appspot.com/7610050/#ps42001 . I guess this patch fixes all the problems related to sub-items present yet.
 110 2013-03-25T19:44:13  *** dcramer_ has quit IRC
 111 2013-03-25T19:47:35  <dreimark> moin
 112 2013-03-25T19:48:12  <dreimark> have also a look on the tests and if a test is missing add it before doing a code change
 113 2013-03-25T20:17:43  *** rihnapstor has quit IRC
 114 2013-03-25T20:45:12  *** sharky93 has joined #moin-dev
 115 2013-03-25T20:48:03  *** sharky__ has joined #moin-dev
 116 2013-03-25T20:50:58  *** sharky93 has quit IRC
 117 2013-03-25T20:51:46  *** haseeb has quit IRC
 118 2013-03-25T21:12:09  <ashutosh1461> ThomasWaldmann, take a look https://codereview.appspot.com/7610050/ :)
 119 2013-03-25T21:12:10  *** ashutosh1461 has quit IRC
 120 2013-03-25T21:19:31  *** spy has joined #moin-dev
 121 2013-03-25T21:19:54  *** spy is now known as Guest66085
 122 2013-03-25T21:20:51  *** sharky__ has quit IRC
 123 2013-03-25T21:27:59  *** dave_largo has quit IRC
 124 2013-03-25T21:30:15  <ThomasWaldmann> https://docs.google.com/spreadsheet/ccc?key=0Aq4ThyUfrogvdDZRZUxtUFIzT1VFeFRQTlkzZE1RcUE#gid=0
 125 2013-03-25T21:31:09  *** Guest66085 is now known as spy_
 126 2013-03-25T22:29:26  *** RogerHaase has left #moin-dev
 127 2013-03-25T22:29:54  *** bruno_ has quit IRC
 128 2013-03-25T22:59:22  *** ronny_ has quit IRC
 129 2013-03-25T23:32:30  *** spy_ has quit IRC
 130

MoinMoin: MoinMoinChat/Logs/moin-dev/2013-03-25 (last edited 2013-03-25 00:15:09 by IrcLogImporter)