1 2013-04-01T06:10:14 *** dwcramer
2 2013-04-01T06:23:25 *** dwcramer
3 2013-04-01T06:37:23 *** dwcramer
4 2013-04-01T06:39:52 *** dwcramer
5 2013-04-01T07:14:44 *** dwcramer
6 2013-04-01T09:17:35 *** greg_f
7 2013-04-01T12:25:04 *** pooryorick
8 2013-04-01T12:48:47 *** dave_largo
9 2013-04-01T12:55:22 *** pooryorick
10 2013-04-01T13:21:19 <sunu> moin
11 2013-04-01T13:30:07 *** bruno_
12 2013-04-01T13:37:08 <ThomasWaldmann> moin
13 2013-04-01T13:43:57 *** dwcramer
14 2013-04-01T13:47:06 *** RogerHaase
15 2013-04-01T13:48:51 <sunu> ThomasWaldmann: https://codereview.appspot.com/7988046
16 2013-04-01T13:51:37 <sunu> and https://codereview.appspot.com/8153044
17 2013-04-01T14:10:48 *** rihnapstor
18 2013-04-01T14:12:54 * ThomasWaldmann looking...
19 2013-04-01T14:18:34 <ThomasWaldmann> sunu: first review done
20 2013-04-01T14:19:09 <ThomasWaldmann> btw, after you change some code, are you doing the very first review yourself?
21 2013-04-01T14:23:10 <ThomasWaldmann> same question for docs...
22 2013-04-01T14:28:42 <sunu> ThomasWaldmann: I did review them. for the dos issue admin privileges mean the user has to be admin. In the app.yaml we have login: admin for +cli/index.
23 2013-04-01T14:29:03 <sunu> That checks for admin privileges.
24 2013-04-01T14:29:54 *** rihnapstor
25 2013-04-01T14:30:07 <sunu> And for the support dir issue by precisely do you mean the full path where we want the support directory ?
26 2013-04-01T14:43:03 *** rihnapstor
27 2013-04-01T14:43:09 <ThomasWaldmann> sunu: you are thinking about gae, but most of the code is generic. you didn't document that "admin privilege" refers to gae admin.
28 2013-04-01T14:43:31 <ThomasWaldmann> (and you are not checking any permissions if the code is not run on gae)
29 2013-04-01T14:43:54 *** greg_f
30 2013-04-01T14:43:55 <ThomasWaldmann> you compute the support dir path, so you can just tell where you looked
31 2013-04-01T14:47:13 *** greg_f
32 2013-04-01T14:48:16 <sunu> ThomasWaldmann: Currently the +cli/index is accessible only on gae, but even in generic cases index operations should be performed by the wiki administrator, no ?
33 2013-04-01T14:48:54 <ThomasWaldmann> sure
34 2013-04-01T14:49:22 <ThomasWaldmann> you just have to be more precise, otherwise the new user will not know what you are talking about
35 2013-04-01T14:49:24 *** puneet
36 2013-04-01T14:49:56 <ThomasWaldmann> and we will use the same stuff on non-gae also as soon as we found a good way
37 2013-04-01T14:50:57 <ThomasWaldmann> (just imagine someone ftping moin to some shared hosting with no shell access, how shall he build the index there? needs same functionality as on gae)
38 2013-04-01T14:51:34 <sunu> ok. So for now I am just specifying that the user has to be gae admin. later when we do it for non-gae we can modify the docs :)
39 2013-04-01T14:54:21 <ThomasWaldmann> "If you are running on GAE ..."
40 2013-04-01T14:54:47 <sunu> and for adding that functionality to non-gae we can just add the endpoint to admin/views.py ?
41 2013-04-01T14:54:52 <ThomasWaldmann> (or maybe rather "Google AppEngine")
42 2013-04-01T14:55:11 <sunu> ok.
43 2013-04-01T14:55:23 <ThomasWaldmann> well, you need to be careful. it must not try to open the index or it'll crash because there is none.
44 2013-04-01T14:55:54 <sunu> ok I'll try that later.
45 2013-04-01T14:56:14 <ThomasWaldmann> and as soon as we have that in normal url dispatching, we don't need it in app.yaml any more, so the check done by gae will go away
46 2013-04-01T14:57:25 <sunu> yes.
47 2013-04-01T14:58:51 <sunu> ThomasWaldmann: https://codereview.appspot.com/8153044 ok now ?
48 2013-04-01T15:01:02 <ThomasWaldmann> almost, see there
49 2013-04-01T15:01:09 <ThomasWaldmann> (commit after fixing)
50 2013-04-01T15:04:14 *** vaishaks
51 2013-04-01T15:43:24 <rihnapstor> ThomasWaldmann: for unit testing i need to download pytest ?
52 2013-04-01T15:46:58 <sunu> rihnapstor: pytest is already there. Running ./quickinstall installed it for you.
53 2013-04-01T15:47:53 <rihnapstor> yes got it thanks sunu
54 2013-04-01T15:52:46 <ThomasWaldmann> you need to activate the env
55 2013-04-01T15:53:51 <rihnapstor> yes
56 2013-04-01T15:56:29 <sunu> ThomasWaldmann: https://codereview.appspot.com/7988046/
57 2013-04-01T16:02:13 <rihnapstor> ThomasWaldmann: can you please help me in understanding line no. 22 "feed.atom" here http://dpaste.com/1043060/
58 2013-04-01T16:08:55 <ThomasWaldmann> rihnapstor: it computes the url for the atom feed, does a http GET there and returns the stuff (and assigns to rv)
59 2013-04-01T16:12:04 <rihnapstor> i understood views.py contains atom function but then i am kinda confused with feed.
60 2013-04-01T16:15:03 <ThomasWaldmann> there are frontend, feed, misc and admin packages.
61 2013-04-01T16:15:34 * ThomasWaldmann gtg
62 2013-04-01T16:15:39 *** spy
63 2013-04-01T16:16:04 *** spy
64 2013-04-01T16:20:48 *** Guest62747
65 2013-04-01T16:21:45 <RogerHaase> dreimark, rihnapstor: fyi, opened an issue based on yesterday's stylus discussion: https://bitbucket.org/thomaswaldmann/moin-2.0/issue/356/foobar-css-generated-by-stylus-differs
66 2013-04-01T16:24:31 <sunu> ThomasWaldmann: https://codereview.appspot.com/7988046/ ok now ?
67 2013-04-01T16:34:12 <rihnapstor> RogerHaase: issue #308,where do i define css for table tag ,should css be inlined , or do i make it external. ? see http://moinmo.in/MoinMoinChat/Logs/moin-dev/2013-03-28 . dreimark want to make changes in belonging css. but the neither any atom files contain stylesheets .
68 2013-04-01T16:43:15 * rihnapstor will be right back
69 2013-04-01T16:43:21 *** rihnapstor
70 2013-04-01T17:26:02 *** greg_f
71 2013-04-01T18:06:40 *** rihnapstor
72 2013-04-01T18:07:06 *** rihnapstor
73 2013-04-01T18:07:55 *** puneet
74 2013-04-01T18:17:49 <RogerHaase> rihnapstor: you add "css" to ...themes/modernized/static/css/stylus/main.styl AND .../foobar/..... Maybe insert after table.zebra or find a better place; then run stylus to generate common.css
75 2013-04-01T19:04:53 <rihnapstor> RogerHaase: ok, common.css will need to be added to atom.html as well as diff_text_atom.html.
76 2013-04-01T19:21:41 *** rihnapstor
77 2013-04-01T19:29:22 <RogerHaase> rihnapstor: ummmm, I may have told you wrong. Show a codereview so we can see where you are working.
78 2013-04-01T20:57:19 *** sharky
79 2013-04-01T20:57:57 *** dave_largo
80 2013-04-01T20:58:36 *** sharky
81 2013-04-01T20:59:22 *** sharky93
82 2013-04-01T20:59:50 <sharky93> moin everyone :)
83 2013-04-01T21:02:04 <dreimark> hi sharky93
84 2013-04-01T21:02:12 <dreimark> moin ;)
85 2013-04-01T21:30:49 <sharky93> RogerHaase, wrt http://goo.gl/Gm6dU by simplifying formulas do you mean to reduce the floating point division ?, is there some protocol that needs to be followed or we just need to find a way to get it working ?
86 2013-04-01T21:47:05 <RogerHaase> sharkey93: not sure, I think only 4 of the constants cause problems. A first step is to determine what the "failing" constants have in common. Could be subtraction, division, line numbers are fibonacci, combination of...?
87 2013-04-01T21:49:44 <ThomasWaldmann> http://markitup.jaysalvat.com/home/
88 2013-04-01T21:56:56 <sharky93> RogerHaase, yeah the diff output @ https://github.com/LearnBoost/stylus/issues/993 suggests that only 4 of the constants are causing issues since they are inter-dependent, on it.
89 2013-04-01T22:02:21 <sharky93> RogerHaase, its a bit weird but i'm getting the output for Windows as mentioned by you @ https://github.com/LearnBoost/stylus/issues/993 on my Linux
90 2013-04-01T22:03:19 <sharky93> i.e using stylus version 0.29.0
91 2013-04-01T22:05:56 <RogerHaase> sharkey93: right, using version 30, windows output stays the same as version 29. Using 30, Linux changes. Using 31, both Windows and Linux change.
92 2013-04-01T22:08:37 <sharky93> hmm, understood, i'll try a few things tomorrow, a bit sleepy now :)
93 2013-04-01T22:13:24 *** RogerHaase
94 2013-04-01T22:13:56 *** sharky93
95 2013-04-01T22:32:53 *** bruno_
96 2013-04-01T22:45:16 * ThomasWaldmann merged some pull requests
97 2013-04-01T23:32:23 *** spy_
98 2013-04-01T23:48:29 *** dwcramer
99
