MoinMoin: MoinMoinChat/Logs/moin-dev/2013-04-07

   1 2013-04-07T00:12:13  *** spy_ has quit IRC
   2 2013-04-07T01:39:33  *** dwcramer has quit IRC
   3 2013-04-07T01:53:31  *** dwcramer has joined #moin-dev
   4 2013-04-07T04:43:24  *** gugu has joined #moin-dev
   5 2013-04-07T07:27:48  <ronny> moin
   6 2013-04-07T07:35:00  *** spy has joined #moin-dev
   7 2013-04-07T07:35:00  *** spy is now known as spy_
   8 2013-04-07T07:45:07  *** dwcramer has quit IRC
   9 2013-04-07T09:39:12  *** ashutosh1461 has joined #moin-dev
  10 2013-04-07T09:39:20  <ashutosh1461> moin
  11 2013-04-07T11:00:35  *** gugu has left #moin-dev
  12 2013-04-07T11:09:34  *** sharky93 has joined #moin-dev
  13 2013-04-07T11:10:26  <sunu> moin
  14 2013-04-07T11:17:15  <ashutosh1461> Hello ThomasWaldmann, please review https://codereview.appspot.com/7751045/ :)
  15 2013-04-07T11:22:16  *** ronny has quit IRC
  16 2013-04-07T11:24:21  *** ronny has joined #moin-dev
  17 2013-04-07T11:29:41  *** ashutosh1461 has quit IRC
  18 2013-04-07T11:35:08  *** birkenfeld has quit IRC
  19 2013-04-07T11:38:03  *** xorAxAx has quit IRC
  20 2013-04-07T11:39:36  *** birkenfeld has joined #moin-dev
  21 2013-04-07T11:39:59  *** xorAxAx has joined #moin-dev
  22 2013-04-07T11:40:03  *** birkenfeld has quit IRC
  23 2013-04-07T11:40:03  *** birkenfeld has joined #moin-dev
  24 2013-04-07T12:09:38  *** sharky93 has quit IRC
  25 2013-04-07T12:14:54  <ThomasWaldmann> moin
  26 2013-04-07T12:20:20  <sunu> Is there a way to know the calling function of a particular function ?
  27 2013-04-07T12:22:14  <sunu> never mind, inspect.stack() it is :D
  28 2013-04-07T12:25:11  <ThomasWaldmann> for what do you need that?
  29 2013-04-07T12:32:04  <sunu> ThomasWaldmann: useful while fixing bugs.
  30 2013-04-07T12:32:27  <sunu> When I don't exactly know how the function is being called
  31 2013-04-07T12:33:41  <sunu> ipdb + inspect.stack() help a lot
  32 2013-04-07T12:48:35  <ThomasWaldmann> sunu: one can also check for some condition that triggers when you want to know and then raise an Exception - you'll have the full traceback in the log then
  33 2013-04-07T12:56:00  <sunu> ThomasWaldmann: yes, that would be a better trick :D
  34 2013-04-07T13:02:32  *** birkenfeld has quit IRC
  35 2013-04-07T13:03:09  *** xorAxAx has quit IRC
  36 2013-04-07T13:04:11  *** birkenfeld has joined #moin-dev
  37 2013-04-07T13:04:40  *** birkenfeld has joined #moin-dev
  38 2013-04-07T13:05:47  *** xorAxAx has joined #moin-dev
  39 2013-04-07T13:25:10  *** ashutosh1461 has joined #moin-dev
  40 2013-04-07T13:26:20  <ashutosh1461> moin
  41 2013-04-07T13:29:34  <ashutosh1461> ThomasWaldmann, i need some help, i was editing the forms.py file and need to import a function defined in the MoinMoin/items/__init__.py file, but it is giving me an ImportError.
  42 2013-04-07T13:29:36  <ashutosh1461>  http://rn0.ru/show/Y30bZveHSCCgtZyfzG1Q/
  43 2013-04-07T13:40:05  <ThomasWaldmann> strange import errors are often cyclic imports, just don't do them
  44 2013-04-07T13:41:02  <ashutosh1461> so, what should i do ?
  45 2013-04-07T13:41:45  <ashutosh1461> i need to call the NameNotUniqueError class there in the forms.py.
  46 2013-04-07T13:41:48  <ThomasWaldmann> well, i think a flatland-like validator should not raise an exception
  47 2013-04-07T13:42:25  <ThomasWaldmann> btw, that src looks badly formatted
  48 2013-04-07T13:42:40  <dreimark> moin
  49 2013-04-07T13:42:51  <dreimark> looks like tabs
  50 2013-04-07T13:44:23  <ThomasWaldmann> also, if i read stuff like "sel" instead of "self", i somehow get the impression that you didn't read it yourself.
  51 2013-04-07T13:45:23  <dreimark> and that there is no unit test
  52 2013-04-07T13:45:51  <ashutosh1461> i was just trying to point out the import error which i am getting, the code is not final yet.
  53 2013-04-07T13:46:39  <ThomasWaldmann> maybe we need to make clear for GSOC that it is not the mentors job to waste a lot of time to find the student's typos and other trivial errors that the student could have found himself, if he had done the first review himself
  54 2013-04-07T13:48:19  *** ronny_ has joined #moin-dev
  55 2013-04-07T13:50:11  <ThomasWaldmann> ashutosh1461: and for code, please use codereview. i could've made some more comments, but as it is in a pastebin, I can't do that easily.
  56 2013-04-07T13:51:59  *** ronny has quit IRC
  57 2013-04-07T13:52:49  <ThomasWaldmann> ashutosh1461: btw, currently you check validity "for each name in new_names"
  58 2013-04-07T13:52:59  *** greg_f has joined #moin-dev
  59 2013-04-07T13:53:26  <ashutosh1461> i fully understand ThomasWaldmann , sorry for the typo's.
  60 2013-04-07T13:53:37  <ThomasWaldmann>  how many whoosh index operations are you doing with that?
  61 2013-04-07T13:54:24  *** dwcramer has joined #moin-dev
  62 2013-04-07T13:55:14  <ashutosh1461> so what if the user has added more than one name in the json name meta say changed ["foo"] to ["foo1","foo2","foo3"] ?
  63 2013-04-07T13:56:28  <ThomasWaldmann> that's not an answer to my question
  64 2013-04-07T13:57:35  <ThomasWaldmann> (addtl question: how many non-index storage operations are you doing?)
  65 2013-04-07T13:58:04  <ashutosh1461> just the index operations to check whether the name exists or not
  66 2013-04-07T13:58:48  <ThomasWaldmann> so for N new names it is N operation
  67 2013-04-07T13:58:50  <ThomasWaldmann> s
  68 2013-04-07T13:59:42  <ashutosh1461> ThomasWaldmann, the code is not the final one, i showed it to you in pastebin just to point out the import error it does not have the isvalid_name function yet as i defined it in __init__ file.
  69 2013-04-07T13:59:48  <ashutosh1461> yes it would be N for N new names
  70 2013-04-07T14:00:23  <ThomasWaldmann> plus accessing storage once for the current revison
  71 2013-04-07T14:01:13  <ashutosh1461> and non-index operations to obtain the names list, checking if the names are unique or not, and getting the new names added.
  72 2013-04-07T14:01:28  <ThomasWaldmann> i somehow feel that it could be done with 1 index operation only
  73 2013-04-07T14:03:27  *** RogerHaase has joined #moin-dev
  74 2013-04-07T14:03:50  <ashutosh1461> umm.. how come ?
  75 2013-04-07T14:03:57  <ashutosh1461> or i will think about it.
  76 2013-04-07T14:04:37  <ThomasWaldmann> always remember that the upper layer of storage is whoosh, a powerful search library
  77 2013-04-07T14:04:57  <ashutosh1461> and what should i do about importing NameNotUniqueError class ?
  78 2013-04-07T14:05:45  <ThomasWaldmann> well, you either could find that you don't need it for a flatland validator
  79 2013-04-07T14:05:58  <ThomasWaldmann> or you could move the definition of it
  80 2013-04-07T14:08:37  <ThomasWaldmann> and think about THE fundamental property of a valid names list, then you almost have the solution
  81 2013-04-07T14:10:57  <ThomasWaldmann> (and also think about order of validation checks regarding the estimated execution time of them)
  82 2013-04-07T14:14:07  <xiaq> http://www.whatcanidoformozilla.org/ calls Python development "backtrace-driven" :)
  83 2013-04-07T14:14:47  <xiaq> which IMO is pretty true for all dynamic languages
  84 2013-04-07T14:21:22  <sunu> xiaq: the link it forwards you to for python is not python specific at all :/
  85 2013-04-07T14:26:31  *** ashutosh1461 has quit IRC
  86 2013-04-07T14:27:37  <ThomasWaldmann> waldi: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/156/allow-colons-in-arguments-this-allows/diff#chg-MoinMoin/converter/_args_wiki.py
  87 2013-04-07T14:46:19  <sunu> ThomasWaldmann: https://codereview.appspot.com/8277048 fix for #353
  88 2013-04-07T14:54:55  <ThomasWaldmann> waldi: see sunu's codereview, too
  89 2013-04-07T14:59:03  *** rihnapstor has joined #moin-dev
  90 2013-04-07T15:04:03  *** xorAxAx has quit IRC
  91 2013-04-07T15:04:41  *** xorAxAx has joined #moin-dev
  92 2013-04-07T15:11:06  *** birkenfeld has quit IRC
  93 2013-04-07T15:12:10  *** xorAxAx has quit IRC
  94 2013-04-07T15:12:13  *** birkenfeld has joined #moin-dev
  95 2013-04-07T15:12:42  *** birkenfeld has joined #moin-dev
  96 2013-04-07T15:13:14  *** xorAxAx has joined #moin-dev
  97 2013-04-07T15:29:36  *** sharky93 has joined #moin-dev
  98 2013-04-07T15:39:21  *** dwcramer has quit IRC
  99 2013-04-07T15:47:37  <sharky93> RogerHaase, please have a look at the comment here https://bitbucket.org/thomaswaldmann/moin-2.0/issue/356/foobar-css-generated-by-stylus-differs
 100 2013-04-07T15:57:51  *** xorAxAx has quit IRC
 101 2013-04-07T15:58:28  *** birkenfeld has quit IRC
 102 2013-04-07T15:58:28  *** birkenfeld has joined #moin-dev
 103 2013-04-07T15:58:54  *** xorAxAx has joined #moin-dev
 104 2013-04-07T16:04:20  *** xorAxAx has quit IRC
 105 2013-04-07T16:07:40  *** xorAxAx has joined #moin-dev
 106 2013-04-07T16:16:18  *** xorAxAx has quit IRC
 107 2013-04-07T16:31:59  *** xorAxAx has joined #moin-dev
 108 2013-04-07T16:39:41  * ThomasWaldmann updates the moin2 password_checker
 109 2013-04-07T16:48:32  *** rihnapstor has quit IRC
 110 2013-04-07T17:06:55  *** greg_f has quit IRC
 111 2013-04-07T17:27:30  *** rihnapstor has joined #moin-dev
 112 2013-04-07T17:28:11  *** rihnapstor has joined #moin-dev
 113 2013-04-07T17:36:09  <RogerHaase> sharky93: show diff again, but use codereview  https://codereview.appspot.com/8416046/
 114 2013-04-07T17:44:40  <sharky93> RogerHaase, I get the exact same diff as https://codereview.appspot.com/8416046/
 115 2013-04-07T17:46:25  <RogerHaase> sharky93: show that you can use codereview
 116 2013-04-07T17:47:39  <RogerHaase> sharky93: show 29, 30, 31 differences (if any)
 117 2013-04-07T18:12:05  * ThomasWaldmann updates moin2 account resetpw
 118 2013-04-07T18:12:34  *** ronny_ has quit IRC
 119 2013-04-07T18:21:28  *** ronny_ has joined #moin-dev
 120 2013-04-07T19:42:35  *** dwcramer has joined #moin-dev
 121 2013-04-07T20:59:18  *** rihnapstor has quit IRC
 122 2013-04-07T21:51:18  *** dwcramer has quit IRC
 123 2013-04-07T21:59:10  *** RogerHaase has left #moin-dev
 124 2013-04-07T22:19:55  *** ronny_ has quit IRC
 125 2013-04-07T22:34:19  *** sharky93 has quit IRC
 126 2013-04-07T22:34:54  *** spy_ has quit IRC
 127