1 2013-04-09T02:02:55 *** GorillaWarfare
2 2013-04-09T02:16:55 *** dwcramer
3 2013-04-09T02:26:29 *** vaishaks
4 2013-04-09T02:33:17 *** dwcramer
5 2013-04-09T03:08:49 *** dwcramer
6 2013-04-09T03:28:02 *** dwcramer
7 2013-04-09T05:26:43 *** dwcramer
8 2013-04-09T05:58:12 *** sharky93
9 2013-04-09T06:00:45 *** ronny
10 2013-04-09T06:45:31 *** spy
11 2013-04-09T06:45:55 *** spy
12 2013-04-09T07:32:30 *** Guest9891
13 2013-04-09T07:50:34 *** sharky93
14 2013-04-09T07:52:04 *** sharky93
15 2013-04-09T08:07:15 *** ashutosh1461
16 2013-04-09T08:08:10 *** sharky93
17 2013-04-09T08:16:09 *** macobo
18 2013-04-09T08:17:27 *** macobo
19 2013-04-09T08:17:34 *** macobo
20 2013-04-09T08:27:20 <ThomasWaldmann> moin
21 2013-04-09T08:28:25 *** sharky93
22 2013-04-09T08:28:27 <macobo> moin! :)
23 2013-04-09T08:29:12 <macobo> Just looking through the ideas list, the XML-related tasks seem interesting.
24 2013-04-09T08:31:25 <ThomasWaldmann> hi macobo
25 2013-04-09T08:32:17 <macobo> Any chance of meeting Bastian on here?
26 2013-04-09T08:36:40 <ashutosh1461> Hello ThomasWaldmann :)
27 2013-04-09T08:37:14 <sunu> macobo: he is waldi in here on irc.
28 2013-04-09T08:37:34 <macobo> Ah, thank you. I'll ping him later. :)
29 2013-04-09T08:38:23 <ashutosh1461> ThomasWaldmann, please review, https://codereview.appspot.com/8180044/ fix for https://bitbucket.org/thomaswaldmann/moin-2.0/issue/250/ (ignore the wikiconfig.py file in the changeset)
30 2013-04-09T08:39:00 <sunu> macobo: or ThomasWaldmann is a mentor too, you can ask him :)
31 2013-04-09T08:39:42 <macobo> sunu: thank you :)
32 2013-04-09T08:40:44 <sunu> macobo: yw :)
33 2013-04-09T08:49:16 <macobo> Sadly I won't have any time this week to help; Will give my best to get started next week. :)
34 2013-04-09T08:51:13 <ashutosh1461> ThomasWaldmann, regarding your comment, the cursor position is after the name inserted, if we set the params to 0,0 it would appear at the starting of the text.
35 2013-04-09T08:53:01 <ashutosh1461> the parameters matter in the sense that they tell what should be the selection/or can define the cursor position, suppose if we set the params to 0,5 we will have a selection going from starting to 5th character of our text.
36 2013-04-09T08:53:30 <ashutosh1461> or if we set it to 5,5 then we would have our cursor at the 5th position.
37 2013-04-09T08:58:24 <ThomasWaldmann> ashutosh1461: done the previous reviews.
38 2013-04-09T08:59:18 <ThomasWaldmann> macobo: it helps if you ask specific questions and expect also async replies
39 2013-04-09T08:59:58 <ThomasWaldmann> ashutosh1461: so, selection also determines cursor pos?
40 2013-04-09T09:00:30 <macobo> will take that into account.
41 2013-04-09T09:00:33 <ThomasWaldmann> ah, ok
42 2013-04-09T09:00:42 <ThomasWaldmann> ashutosh1461: clear now
43 2013-04-09T09:03:26 *** greg_f
44 2013-04-09T09:04:28 <ashutosh1461> ThomasWaldmann, so is the patchset 5 fine? (Transcluding and Linking subitems bug, ignore the wikiconfig.py file)
45 2013-04-09T09:04:29 *** sharky93
46 2013-04-09T09:20:44 <ThomasWaldmann> https://codereview.appspot.com/7751045/ yes, looks ok. maybe give it a final test and make sure you do not commit any unintended change.
47 2013-04-09T09:22:56 <ThomasWaldmann> marktraceur: "lack of maintainership" is one of the concerns I personally would have about major amounts of js code, too.
48 2013-04-09T09:23:40 <ThomasWaldmann> moin is primarily a python based project and many of us rather like to work in python than in js
49 2013-04-09T09:24:10 <ThomasWaldmann> but the stuff you pointed to is somehow having similar goals, yes
50 2013-04-09T09:25:02 <ThomasWaldmann> (as our dom converters)
51 2013-04-09T11:02:52 *** ronny_
52 2013-04-09T11:04:20 <ashutosh1461> ThomasWaldmann, updated issue, https://codereview.appspot.com/8127044/
53 2013-04-09T11:06:45 *** ronny
54 2013-04-09T11:07:23 *** macobo_
55 2013-04-09T11:07:57 *** macobo
56 2013-04-09T11:28:27 <ThomasWaldmann> ashutosh1461: done. getting better, but still room for improvements.
57 2013-04-09T11:33:54 <ashutosh1461> ThomasWaldmann, we talked about the case when there is no meta list or the meta list is empty, currently we get redirected to the original meta without showing any error, what can be done?
58 2013-04-09T11:34:51 <ashutosh1461> i think it is a different issue, in the case when a user deletes a meta field or something like that, should be handled separately.
59 2013-04-09T11:56:59 *** rihnapstor
60 2013-04-09T12:00:46 *** rihnapstor
61 2013-04-09T12:00:46 *** rihnapstor
62 2013-04-09T12:19:42 <ThomasWaldmann> ashutosh1461: what i wanted to point out in the CR is that you'll get a KeyError then
63 2013-04-09T12:20:19 <ThomasWaldmann> (except if some other previous validator makes sure the code doesn't get executed)
64 2013-04-09T12:23:51 <ashutosh1461> ThomasWaldmann, so should i user meta.get(NAME) ? or wrap it in a try-catch block ?
65 2013-04-09T12:24:52 <ashutosh1461> or we can do nothing, as here some-other validator is taking care of it, so the key NAME would exist certainly if the code gets executed.
66 2013-04-09T12:31:29 * rihnapstor bbl
67 2013-04-09T12:31:45 *** rihnapstor
68 2013-04-09T12:41:30 <ThomasWaldmann> ashutosh1461: well, strictly taken the validator for NAME should make sure there is at least an empty list of names, if there is no NAME key, that is invalid.
69 2013-04-09T12:42:27 <ThomasWaldmann> (and i guess there is no other validator for NAME as long as it is just part of the json metadata field)
70 2013-04-09T12:51:10 <ashutosh1461> yes, you are right. So, finally i am showing an error message if a user inputs an empty list and ignoring the case in which there is no NAME key.
71 2013-04-09T12:59:36 *** dave_largo
72 2013-04-09T13:19:02 *** ronny_
73 2013-04-09T13:31:14 *** spy_
74 2013-04-09T13:31:29 <ashutosh1461> ThomasWaldmann, issue updated https://codereview.appspot.com/8127044/
75 2013-04-09T13:46:00 <ThomasWaldmann> ashutosh1461: did you update the codereview in the recent few minutes?
76 2013-04-09T13:48:27 <ThomasWaldmann> (it killed my comments, but i just reentered them...)
77 2013-04-09T13:52:24 <ashutosh1461> yes, there was a slight error in the cr, also published some comments, and how come empty list is valid? How will we access the item again if we want to ?
78 2013-04-09T13:54:02 <ThomasWaldmann> ashutosh1461: it's still in the index, moin can access it via itemid, for example
79 2013-04-09T13:54:38 <ashutosh1461> hmm fine.
80 2013-04-09T13:54:41 <ThomasWaldmann> items with empty names are just not referenced from the namespace, so it usually means they are trash
81 2013-04-09T13:54:50 <ThomasWaldmann> waiting for a garbage collection...
82 2013-04-09T13:58:59 *** ronny
83 2013-04-09T13:58:59 *** ronny
84 2013-04-09T13:59:40 <marktraceur> ThomasWaldmann: Well, and we tend to work in PHP on the backend, so Parsoid is written with cross-language in mind :)
85 2013-04-09T14:00:01 <marktraceur> ThomasWaldmann: But if you'd prefer not to use the solutions verbatim, I'm still lurking :)
86 2013-04-09T14:01:13 <ThomasWaldmann> if I had the choice between php and js, i maybe also would take js :D
87 2013-04-09T14:01:41 <marktraceur> ThomasWaldmann: No comment :)
88 2013-04-09T14:06:23 <ThomasWaldmann> marktraceur: btw, we have a slightly different approach
89 2013-04-09T14:07:01 <ashutosh1461> ThomasWaldmann, i guess this should be it, https://codereview.appspot.com/8127044/
90 2013-04-09T14:07:03 <ThomasWaldmann> we use multiple converter steps and a internal dom-like intermediate format in between the input and output format
91 2013-04-09T14:08:19 <marktraceur> ThomasWaldmann: Right - we use something similar but we've opted for HTML as our DOM format. I suspected that it wouldn't take much change to get Parsoid to output some other form of XML.
92 2013-04-09T14:09:55 *** bruno_
93 2013-04-09T14:10:23 <ThomasWaldmann> ashutosh1461: almost.
94 2013-04-09T14:11:05 <sunu> moin
95 2013-04-09T14:12:14 *** RogerHaase
96 2013-04-09T14:16:01 <sunu> ThomasWaldmann: Any comments on my gsoc application now that the discussion period has started officially ? :)
97 2013-04-09T14:16:04 <sunu> http://moinmo.in/TarashishMishra/GSOC-2013
98 2013-04-09T14:18:32 <ThomasWaldmann> sunu: can't read it now, but maybe in 4h or so
99 2013-04-09T14:20:32 <sunu> ThomasWaldmann: sure.
100 2013-04-09T14:25:40 *** dwcramer
101 2013-04-09T14:26:34 <ashutosh1461> ThomasWaldmann, i am not understanding what is wrong in that statement :/ ?
102 2013-04-09T14:27:16 * dreimark no p* language fight here
103 2013-04-09T14:43:02 <ThomasWaldmann> ashutosh1461: the translation stuff? just execute it in the order python would do.
104 2013-04-09T14:51:20 <ashutosh1461> still not getting it :/
105 2013-04-09T14:51:25 *** rihnapstor
106 2013-04-09T14:51:31 *** badescunicu
107 2013-04-09T14:53:43 *** rihnapstor
108 2013-04-09T14:53:43 *** rihnapstor
109 2013-04-09T14:55:00 <ThomasWaldmann> ashutosh1461: what happens when python executes _("The name is: %s" % pagename) ?
110 2013-04-09T15:01:37 <ashutosh1461> it replaces %s with the value of pagename, and produces the desired string.
111 2013-04-09T15:03:05 <ThomasWaldmann> yes, no
112 2013-04-09T15:03:35 <ThomasWaldmann> you know how the gettext-based translations usually work?
113 2013-04-09T15:04:15 <ashutosh1461> no, not really
114 2013-04-09T15:04:32 <ThomasWaldmann> the .po files contain pairs of strings, e.g.
115 2013-04-09T15:04:41 <ThomasWaldmann> msgid "The name is: %s"
116 2013-04-09T15:04:53 <ThomasWaldmann> msgtxt: "Der Name ist: %s"
117 2013-04-09T15:04:58 <ThomasWaldmann> (for german)
118 2013-04-09T15:05:12 <ThomasWaldmann> it looks up by msgid and returns the value of msgtxt
119 2013-04-09T15:06:52 <ThomasWaldmann> ^^ _(x) is doing that
120 2013-04-09T15:09:43 <ashutosh1461> so i infer that my code would not translate the item_names and you want them as well to be translated?
121 2013-04-09T15:13:37 <ThomasWaldmann> it can only translate when it finds an entry in the translation file
122 2013-04-09T15:13:59 <ThomasWaldmann> and as the translater can't know all the pagenames you would insert there, you can't do it that way
123 2013-04-09T15:14:18 <ThomasWaldmann> no, of course the item name shall not get translated
124 2013-04-09T15:18:16 <ashutosh1461> oh! clear now.
125 2013-04-09T15:19:17 <ashutosh1461> thanks :)
126 2013-04-09T15:19:32 <dreimark> btw. we have agreed to use named sublementations, because a translator has no idea about the meaning of %s
127 2013-04-09T15:19:59 <dreimark> and the other problem is that it is not the right type
128 2013-04-09T15:20:08 <ThomasWaldmann> ashutosh1461: _("... %(foo)s ...", foo=...) is the way we use
129 2013-04-09T15:20:32 <ThomasWaldmann> that's a special kind of call offered by (flask-)babel
130 2013-04-09T15:22:27 <dreimark> s/sublementations/substitutions/ i think is better
131 2013-04-09T15:25:35 <ThomasWaldmann> that way it doesn't work without names anyway
132 2013-04-09T15:31:00 <ashutosh1461> ThomasWaldmann, finally https://codereview.appspot.com/8127044/ :)
133 2013-04-09T15:34:03 <dreimark> ashutosh1461: are you sure it works with chinese translations?
134 2013-04-09T15:34:39 <ashutosh1461> dreimark, no idea about it.
135 2013-04-09T15:34:40 <ashutosh1461> brb
136 2013-04-09T15:35:08 <dreimark> what is the difference between "ä" and u"ä" ?
137 2013-04-09T15:35:32 <dreimark> bbl
138 2013-04-09T15:36:39 <sunu> first one is str and second is unicode ?
139 2013-04-09T15:54:00 <ThomasWaldmann> as soon as it is non-ascii you usually want unicode object. otherwise you usually will get into trouble.
140 2013-04-09T16:07:03 * rihnapstor bbl
141 2013-04-09T16:07:12 *** rihnapstor
142 2013-04-09T16:08:19 <RogerHaase> were we using a different issue # on codereview yesterday?
143 2013-04-09T16:10:00 <RogerHaase> oops
144 2013-04-09T16:17:01 *** puneet
145 2013-04-09T16:22:21 <sharky93> moin
146 2013-04-09T16:27:03 *** macobo_
147 2013-04-09T16:27:10 *** macobo__
148 2013-04-09T16:33:05 <sharky93> ThomasWaldmann, could you please review https://codereview.appspot.com/8523043
149 2013-04-09T16:36:11 <sharky93> i have a doubt in https://bitbucket.org/thomaswaldmann/moin-2.0/issue/355/svgdraw-does-not-redirect-after-saving
150 2013-04-09T16:36:57 <sharky93> is the issue, really a bug ?, what about the scenario i want to keep periodically saving whatever i've done.
151 2013-04-09T16:38:57 <dreimark> sharky93: no bug, and I have already a newer release of svg-edit but not pushed yet
152 2013-04-09T16:41:37 <dreimark> the question is when should the editor be loaded and when the result of it
153 2013-04-09T16:42:50 <dreimark> the more interesting apect is when will the meta data written
154 2013-04-09T16:44:13 <dreimark> in one scenario i renabled the ok button and have you use save for "periodically save" and ok for saving meta and data and to redirect
155 2013-04-09T16:45:31 <sharky93> yeah, so is there an issue with that scenario ?
156 2013-04-09T16:47:37 <dreimark> sharky93: i add the patch later i have already
157 2013-04-09T16:48:36 * dreimark added a comment
158 2013-04-09T16:49:11 <ashutosh1461> ThomasWaldmann, updated, https://codereview.appspot.com/8127044
159 2013-04-09T16:50:36 <ThomasWaldmann> ashutosh1461: btw, did you do make test and manual tests on that recently?
160 2013-04-09T16:51:57 <ThomasWaldmann> review done :)
161 2013-04-09T16:53:12 <ashutosh1461> yes did tests :)
162 2013-04-09T16:53:35 <ashutosh1461> Thanks :)
163 2013-04-09T16:53:54 <ThomasWaldmann> btw, for some stuff it would also be nice to get unit tests with the code
164 2013-04-09T16:54:29 <ThomasWaldmann> it also makes the testing you have to do more automated and less manual
165 2013-04-09T16:56:37 *** dave_largo
166 2013-04-09T17:00:46 *** macobo__
167 2013-04-09T17:08:57 *** puneet
168 2013-04-09T17:09:34 *** puneet
169 2013-04-09T17:12:02 *** rihnapstor
170 2013-04-09T17:23:15 *** aplavin
171 2013-04-09T17:23:51 <aplavin> hello everyone! Is this the right place to ask GSoC-related questions
172 2013-04-09T17:23:52 <aplavin> ?
173 2013-04-09T17:24:49 <dreimark> aplavin: yes, please ask
174 2013-04-09T17:25:09 <dreimark> but be a bit patient
175 2013-04-09T17:25:27 <aplavin> ok)
176 2013-04-09T17:26:17 <aplavin> after reading the list of suggested ideas, I liked "Improve moin-related xml code" most
177 2013-04-09T17:27:03 <aplavin> so questions about it: is there a suitable amount of work for a GSoC project? what would you advice to start with (now)?
178 2013-04-09T17:28:33 <ThomasWaldmann> aplavin: planning how much time is needed for YOU to do X is part of the project proposal you have to create
179 2013-04-09T17:28:33 <rihnapstor> hi dreimark :)
180 2013-04-09T17:29:43 <sharky93> ThomasWaldmann, could you please review https://codereview.appspot.com/8523043
181 2013-04-09T17:29:58 <ThomasWaldmann> and these ideas on the wiki page are just ... ideas. not every idea is enough for a gsoc project, so you may have to combine some.
182 2013-04-09T17:30:29 *** greg_f
183 2013-04-09T17:31:14 <dreimark> aplavin: have you tried moin2 already ?
184 2013-04-09T17:37:26 <rihnapstor> RogerHaase: ThomasWaldmann hello, I would like to solve issue #313 https://bitbucket.org/thomaswaldmann/moin-2.0/issue/313/combine-navibar-user-and-admin-tabs .can you explain me more about it ?
185 2013-04-09T17:41:52 <dreimark> rihnapstor: have you looked on both tabs in your local instance ?
186 2013-04-09T17:43:33 <dreimark> as the sentence says both tabs contents should be merged in one
187 2013-04-09T17:43:52 <dreimark> and if a user has not enough rights the feature should not be visible
188 2013-04-09T17:44:23 <dreimark> instead of telling "not enough rights"
189 2013-04-09T17:48:59 <rihnapstor> dreimark:Currently my local Instance shows 6 options out of which [item Sizes,InterWIki Names,Highlighters] these options need to be moved to the admin tab.
190 2013-04-09T17:49:14 <RogerHaase> ThomasWaldmann: update to development docs ready for review https://codereview.appspot.com/8582043/
191 2013-04-09T17:49:40 <dreimark> rihnapstor: it must not be admin tab, the name could also replaced
192 2013-04-09T17:50:05 <dreimark> at the end there should be only one tab having all of what now is in user and admin
193 2013-04-09T18:01:04 <rihnapstor> dreimark: so if User logs in,only the User privilege options should be shown and admin options should be hidden so that User will not see "access denied error" ?
194 2013-04-09T18:01:57 <dreimark> yes
195 2013-04-09T18:03:14 <dreimark> and I also won't name the new tab Admin or User
196 2013-04-09T18:03:56 <dreimark> usually such stuff is named "Tools"
197 2013-04-09T18:04:27 <rihnapstor> 'Tools' ok dreimark
198 2013-04-09T18:05:42 <ashutosh1461> ThomasWaldmann, issue updated, https://codereview.appspot.com/8180044/ Bug (Problem in Destroying prev existing rev) ,
199 2013-04-09T18:06:03 <ashutosh1461> testing done, ============== 1 failed, 613 passed, 59 skipped in 41.44 seconds ===============
200 2013-04-09T18:07:00 <rihnapstor> dreimark: if admin logs in since i am the superuser then admin+user options should be shown?
201 2013-04-09T18:13:24 <dreimark> rihnapstor: acl_functions = u'+YourName:superuser' in wikiconfig_editme.py
202 2013-04-09T18:13:31 <dreimark> enables it for your account
203 2013-04-09T18:13:46 <dreimark> then the complete list should be shown
204 2013-04-09T18:13:51 <rihnapstor> dreimark: admin access enabled
205 2013-04-09T18:14:09 <dreimark> of course in good named sections
206 2013-04-09T18:15:18 *** badescunicu
207 2013-04-09T18:18:07 *** macobo__
208 2013-04-09T18:23:26 *** dave_largo
209 2013-04-09T18:33:01 *** puneet
210 2013-04-09T18:38:45 <ThomasWaldmann> RogerHaase: review done
211 2013-04-09T18:51:21 <ashutosh1461> ThomasWaldmann, when you are free also review, V
212 2013-04-09T18:51:23 <ashutosh1461> https://codereview.appspot.com/8180044/ *
213 2013-04-09T18:52:58 *** macobo__
214 2013-04-09T18:55:36 <sharky93> i am a bit unclear with https://bitbucket.org/thomaswaldmann/moin-2.0/src/88660eb0ca43f98d603348084e8aca9c697e8c75/MoinMoin/util/tree.py?at=default#cl-52
215 2013-04-09T18:56:13 <sharky93> what is the value that is desirable by __repr__ ?
216 2013-04-09T19:07:21 *** macobo__
217 2013-04-09T19:11:47 *** macobo__
218 2013-04-09T19:15:34 *** sharky93
219 2013-04-09T19:15:48 *** sharky93
220 2013-04-09T19:29:37 *** badescunicu
221 2013-04-09T20:03:23 *** dwcramer
222 2013-04-09T20:04:29 *** dwcramer
223 2013-04-09T20:07:38 *** badescunicu
224 2013-04-09T20:16:10 <sharky93> can you give me a use case for __repr__ here ?
225 2013-04-09T20:23:00 * ashutosh1461 says bye :)
226 2013-04-09T20:23:02 *** ashutosh1461
227 2013-04-09T20:28:15 <sharky93> ThomasWaldmann, ^
228 2013-04-09T20:44:18 *** badescunicu
229 2013-04-09T20:46:06 <sharky93> i.e what do we want as the output, if the instance is represented as a string
230 2013-04-09T20:52:35 * rihnapstor says gn
231 2013-04-09T20:52:52 *** rihnapstor
232 2013-04-09T21:00:07 *** macobo__
233 2013-04-09T21:09:44 *** badescunicu
234 2013-04-09T21:12:53 <ThomasWaldmann> sharky93: __repr__ shall give a printable representation of the object
235 2013-04-09T21:13:16 <ThomasWaldmann> it's nice for debugging
236 2013-04-09T21:26:45 *** dave_largo
237 2013-04-09T21:28:43 *** sunu_
238 2013-04-09T21:28:49 *** dreimark_
239 2013-04-09T21:33:37 *** macobo__
240 2013-04-09T21:33:37 *** dreimark
241 2013-04-09T21:33:38 *** sunu
242 2013-04-09T21:34:25 *** aplavin
243 2013-04-09T21:50:41 <ThomasWaldmann> dreimark_: did some "raul" show up somewhere?
244 2013-04-09T21:53:59 <dreimark_> ThomasWaldmann: have not seen him
245 2013-04-09T21:54:14 *** dreimark_
246 2013-04-09T21:54:39 *** macobo__
247 2013-04-09T21:55:43 * ThomasWaldmann replied on melange.
248 2013-04-09T21:59:45 <dreimark> gn
249 2013-04-09T22:15:48 *** RogerHaase
250 2013-04-09T22:15:52 *** ronny
251 2013-04-09T22:29:31 *** macobo__
252 2013-04-09T23:01:02 *** dwcramer
253 2013-04-09T23:20:53 *** marktraceur
254 2013-04-09T23:26:33 *** bruno_
255 2013-04-09T23:27:06 *** marktrasheesh
256
