1 2013-04-13T00:16:38 *** brunomartin
2 2013-04-13T00:17:59 *** brunomartin
3 2013-04-13T00:20:12 *** n00bz0rz
4 2013-04-13T00:26:28 *** desophos
5 2013-04-13T01:09:51 *** desophos
6 2013-04-13T01:24:16 *** brunomartin
7 2013-04-13T01:40:36 *** xorAxAx
8 2013-04-13T01:41:29 *** xorAxAx
9 2013-04-13T01:50:58 *** birkenfeld
10 2013-04-13T01:51:32 *** birkenfeld
11 2013-04-13T01:51:38 *** xorAxAx
12 2013-04-13T01:52:17 *** xorAxAx
13 2013-04-13T01:59:22 <desophos> i would really like to get started with moinmoin development; can anyone recommend a way to introduce myself to the codebase?
14 2013-04-13T02:03:35 *** xorAxAx
15 2013-04-13T02:05:32 *** xorAxAx
16 2013-04-13T02:06:53 *** ronny
17 2013-04-13T02:12:59 *** sharky93
18 2013-04-13T02:42:03 *** ashutosh1461
19 2013-04-13T02:44:39 *** xorAxAx
20 2013-04-13T02:45:52 *** xorAxAx
21 2013-04-13T02:49:22 *** xorAxAx
22 2013-04-13T02:57:49 *** xorAxAx
23 2013-04-13T03:50:36 *** ashutosh1461
24 2013-04-13T03:56:53 *** desophos
25 2013-04-13T04:37:39 *** sharky93
26 2013-04-13T04:52:20 *** dwcramer
27 2013-04-13T05:47:02 <sharky93> ThomasWaldmann, need some clarity on one thing, will it be better if the user enters {{ someimage.jpg | | width=100px, height=100px}} (the markup in moin1.9 and we parse it somehow to convert the query to ?w=100&h=100 or change the markup to {{somepage.jpg | | w=100,h=100}}
28 2013-04-13T05:47:05 <sharky93> dreimark, ^
29 2013-04-13T05:48:22 <sharky93> in the prior case, the query by default becomes ?width=100px&height=100px
30 2013-04-13T05:48:35 <sharky93> as in the parsing in place now
31 2013-04-13T05:50:41 *** dwcramer
32 2013-04-13T06:01:13 *** rihnapstor
33 2013-04-13T06:11:42 *** birkenfeld
34 2013-04-13T06:11:42 *** birkenfeld
35 2013-04-13T06:17:02 *** ronny
36 2013-04-13T06:31:12 *** ashutosh1461
37 2013-04-13T07:15:00 *** ashutosh1461
38 2013-04-13T07:17:28 *** rihnapstor
39 2013-04-13T07:19:28 *** sharky93
40 2013-04-13T08:15:39 *** sharky93
41 2013-04-13T08:24:47 *** ashutosh1461
42 2013-04-13T08:40:31 *** rihnapstor
43 2013-04-13T09:43:35 <dreimark> sharky93: i prefer with unit
44 2013-04-13T09:45:27 <dreimark> and as long there is no ambigous keyword name may be it can be shortened
45 2013-04-13T09:54:07 <ashutosh1461> moin dreimark , please review https://codereview.appspot.com/8540045/ in relation with bug https://bitbucket.org/thomaswaldmann/moin-2.0/issue/288/
46 2013-04-13T09:56:47 *** rihnapstor
47 2013-04-13T10:03:15 *** kuzman0v
48 2013-04-13T10:03:34 *** kuzman0v
49 2013-04-13T10:30:50 <ashutosh1461> dreimark, yes practical tests done.
50 2013-04-13T10:34:48 <dreimark> :)
51 2013-04-13T10:41:49 *** n00bz0rz
52 2013-04-13T10:59:32 *** n00bz0rz
53 2013-04-13T11:03:15 *** n00bz0rz
54 2013-04-13T11:11:51 *** n00bz0rz
55 2013-04-13T11:19:52 <sharky93> dreimark, for transcluded items such as {{http://moimo.in}} can they have attributes sich as height and width ?
56 2013-04-13T11:20:13 <sharky93> should we support that ?
57 2013-04-13T11:20:15 <sharky93> ThomasWaldmann, ^
58 2013-04-13T11:26:23 <sharky93> IMO, it's pretty useful
59 2013-04-13T11:40:23 <ThomasWaldmann> try out how it looks
60 2013-04-13T11:49:35 *** ashutosh1461
61 2013-04-13T12:02:44 <ThomasWaldmann> sharky93: for the first changeset, please keep pixels, we can change that later
62 2013-04-13T12:03:42 <ThomasWaldmann> remember "clean changesets" - expanding to other units is not part of the problem you're trying to solve NOW
63 2013-04-13T12:05:48 <ThomasWaldmann> and make sure you realize the difference between tag attributes and query string params
64 2013-04-13T12:09:00 <sharky93> yup, almost done, cleaning stuff now
65 2013-04-13T12:31:25 *** ashutosh1461
66 2013-04-13T12:32:07 <sharky93> ThomasWaldmann, please review https://codereview.appspot.com/8717045/
67 2013-04-13T12:32:47 *** ashutosh1461
68 2013-04-13T12:34:26 <sharky93> umm, well lots of pep8 errors, let me get that fixed if you've not seen already, sorry for that.
69 2013-04-13T12:50:44 <sharky93> ThomasWaldmann, updated, please review https://codereview.appspot.com/8717045/
70 2013-04-13T12:51:00 <sharky93> brb
71 2013-04-13T12:53:02 *** ashutosh1461
72 2013-04-13T13:05:40 *** kuzman0v
73 2013-04-13T13:06:51 *** kuzman0v
74 2013-04-13T14:18:03 *** dwcramer
75 2013-04-13T14:46:28 *** dwcramer
76 2013-04-13T15:07:59 <sharky93> ThomasWaldmann, I added a comment here, please reply https://codereview.appspot.com/8717045/patch/2001/3002
77 2013-04-13T15:26:46 *** dwcramer
78 2013-04-13T15:29:58 *** ashutosh1461
79 2013-04-13T15:39:53 *** dwcramer
80 2013-04-13T15:41:15 *** RogerHaase
81 2013-04-13T16:01:17 <ThomasWaldmann> sharky93: first fix or react to all issues before requesting a new review
82 2013-04-13T16:20:04 *** greg_f
83 2013-04-13T16:37:22 *** rihnapstor
84 2013-04-13T16:40:54 *** dwcramer
85 2013-04-13T16:44:58 *** sharky93
86 2013-04-13T16:53:49 *** sharky93
87 2013-04-13T16:54:17 *** dwcramer
88 2013-04-13T17:20:59 *** sharky93
89 2013-04-13T17:32:30 *** sharky93
90 2013-04-13T17:41:37 *** n00bz0rz
91 2013-04-13T17:54:30 *** n00bz0rz
92 2013-04-13T18:04:48 *** greg_f
93 2013-04-13T18:40:06 *** desophos
94 2013-04-13T19:01:59 *** n00bz0rz
95 2013-04-13T19:23:32 *** dwcramer
96 2013-04-13T20:11:13 *** n00bz0rz
97 2013-04-13T20:12:05 *** n00bz0rz
98 2013-04-13T20:44:41 <dreimark> re
99 2013-04-13T20:50:00 <desophos> hey, someone actually said something
100 2013-04-13T20:50:56 <desophos> i guess everyone has been busy
101 2013-04-13T20:56:51 *** macobo
102 2013-04-13T21:14:01 *** RogerHaase
103 2013-04-13T21:17:44 <sharky93> ThomasWaldmann, please review https://codereview.appspot.com/8717045/
104 2013-04-13T21:18:17 *** n00bz0rz
105 2013-04-13T21:26:05 <dreimark> desophos: hmm?
106 2013-04-13T21:31:30 <dreimark> desophos: have you looked at http://moinmo.in/MoinMoin2.0
107 2013-04-13T21:32:15 <dreimark> sharky93: there is not a test in the codereview
108 2013-04-13T21:36:04 <sharky93> dreimark, would a dom > html test suffice ?
109 2013-04-13T21:38:41 <sharky93> dreimark, i had added a test with #360, https://codereview.appspot.com/8660044
110 2013-04-13T21:40:47 *** rihnapstor
111 2013-04-13T21:44:00 <sharky93> ThomasWaldmann,
112 2013-04-13T21:44:10 <sharky93> ^
113 2013-04-13T21:44:20 <sharky93> oops
114 2013-04-13T21:44:37 <dreimark> sharky93: add your copyright string
115 2013-04-13T21:45:06 <dreimark> the test has no query parameter for width or height
116 2013-04-13T21:45:08 <sharky93> really :D
117 2013-04-13T21:46:05 <sharky93> yeah, that test just checks if a 'svg+xml' sub-mimetype gets converted to an 'img' tag
118 2013-04-13T21:46:13 <sharky93> specific for #360
119 2013-04-13T21:47:08 <ThomasWaldmann> desophos: irc is not radio
120 2013-04-13T21:48:22 <dreimark> sharky93: you added new code, so it could have tested that beforehand
121 2013-04-13T21:49:35 <dreimark> gn
122 2013-04-13T21:50:03 <sharky93> dreimark, I dont understand, please clarify your last comment once more
123 2013-04-13T22:24:44 *** macobo
124 2013-04-13T22:33:52 *** macobo
125 2013-04-13T23:16:35 *** dwcramer
126 2013-04-13T23:30:19 *** sharky93
127 2013-04-13T23:40:23 *** macobo
128 2013-04-13T23:51:17 *** ronny
129 2013-04-13T23:59:45 *** dwcramer
130
