1 2013-04-17T00:48:24  *** n00bz0rz has joined #moin-dev
   2 2013-04-17T01:19:52  *** desophos has joined #moin-dev
   3 2013-04-17T01:31:47  *** desophos has quit IRC
   4 2013-04-17T01:43:32  *** desophos has joined #moin-dev
   5 2013-04-17T01:53:19  *** n00bz0rz has quit IRC
   6 2013-04-17T01:58:28  *** n00bz0rz has joined #moin-dev
   7 2013-04-17T02:16:49  *** n00bz0rz has quit IRC
   8 2013-04-17T02:42:54  *** desophos has quit IRC
   9 2013-04-17T03:13:47  *** brunomartin has quit IRC
  10 2013-04-17T03:16:26  *** brunomartin has joined #moin-dev
  11 2013-04-17T04:21:34  *** ronny has joined #moin-dev
  12 2013-04-17T04:36:40  *** desophos has joined #moin-dev
  13 2013-04-17T05:07:14  *** vaishaks has quit IRC
  14 2013-04-17T05:20:19  *** vaishaks has joined #moin-dev
  15 2013-04-17T05:25:44  *** sharky93 has joined #moin-dev
  16 2013-04-17T06:08:57  <sharky93> ThomasWaldmann, updated @ https://codereview.appspot.com/8660044/
  17 2013-04-17T06:18:48  *** rubocoptero has joined #moin-dev
  18 2013-04-17T06:31:17  <sharky93> moin :)
  19 2013-04-17T07:31:45  *** dwcramer has quit IRC
  20 2013-04-17T07:49:40  *** vaishaks has quit IRC
  21 2013-04-17T08:01:50  *** vaishaks has joined #moin-dev
  22 2013-04-17T09:16:27  *** greg_f has joined #moin-dev
  23 2013-04-17T09:24:35  *** vaishaks has quit IRC
  24 2013-04-17T09:30:54  *** ana-balica has joined #moin-dev
  25 2013-04-17T10:09:11  *** vaishaks has joined #moin-dev
  26 2013-04-17T10:14:25  *** vaishaks has quit IRC
  27 2013-04-17T10:15:43  <ThomasWaldmann> sharky93: done
  28 2013-04-17T10:24:44  *** ana-balica has quit IRC
  29 2013-04-17T10:26:31  <sharky93> ThomasWaldmann, please not get_links(), @ https://bitbucket.org/thomaswaldmann/moin-2.0/src/7c00da767896c6cf52d94b1b1d936d480abe94b9/MoinMoin/converter/_tests/test_link.py?at=default#cl-155
  30 2013-04-17T10:28:04  <sharky93> in relation to your comment @ https://codereview.appspot.com/8660044/diff/48001/MoinMoin/converter/html_out.py
  31 2013-04-17T10:30:26  <sharky93> get_links() has been specially defined for testing purpose, i think it could be reused may be for other tests which require list of objects in the XML they input.
  32 2013-04-17T10:31:43  <sharky93> I understand your concern about just testing the the output that is generated, without depending much on the application, but imho there could be such small degree of abstraction allowed ?
  33 2013-04-17T10:32:20  <sharky93> simply because it helps and makes the testing part easier. as in the case of get_links()
  34 2013-04-17T10:32:27  <sharky93> ThomasWaldmann, dreimark, ^
  35 2013-04-17T10:45:38  *** ashutosh1461 has joined #moin-dev
  36 2013-04-17T10:45:39  <ashutosh1461> moin ThomasWaldmann
  37 2013-04-17T10:46:30  <ashutosh1461> still not decided where to fix, https://bitbucket.org/thomaswaldmann/moin-2.0/issue/361/ .
  38 2013-04-17T10:49:05  <ThomasWaldmann> sharky93: if you do a very little test (as you do), it should be at least testing the direct thing
  39 2013-04-17T10:49:29  <ThomasWaldmann> and (iirc) we nowhere have special code that makes up data just for tests
  40 2013-04-17T10:49:54  <ThomasWaldmann> ashutosh1461: you could use the analyzer which we already have
  41 2013-04-17T10:52:35  <ashutosh1461> and the <comment being passed on rename> bug ?
  42 2013-04-17T10:53:36  <ThomasWaldmann> and what about results.matched_terms() - can't you somehow use that?
  43 2013-04-17T10:54:55  <sharky93> ThomasWaldmann, i did a grep "get_links" it has been mentioned only three times in the codebase.
  44 2013-04-17T10:54:57  <ThomasWaldmann> about rename comment: ask more specific questions
  45 2013-04-17T10:55:19  <sharky93> once in tests, once in the function the test is for
  46 2013-04-17T10:56:44  <ThomasWaldmann> get_links, get_transclusions and get_external_links are not just for tests
  47 2013-04-17T10:57:39  <ThomasWaldmann> they are one of the main outputs of that converter
  48 2013-04-17T10:57:57  <ashutosh1461> the results.matched_terms() would return the token which has matched, not from where the token came.
  49 2013-04-17T11:00:27  *** vaishaks has joined #moin-dev
  50 2013-04-17T11:02:31  <ThomasWaldmann> ashutosh1461: hmm, right. ok, then just use the analyzer for NAME field and the startswith for NAME_EXACT
  51 2013-04-17T11:02:47  <ashutosh1461> so what about doing, result = [ name for name in result[NAME] if name satisfies analyzer(name,"foo")] where analyzer is a function which checks if foo can be tokenized from name ?
  52 2013-04-17T11:02:52  <ThomasWaldmann> (the already existing analyzer)
  53 2013-04-17T11:04:11  <ThomasWaldmann> don't call that analyzer, we already have functions called like that - and you should use them (maybe within your new function)
  54 2013-04-17T11:05:50  <ashutosh1461> fine. and about the rename comment bug, i currently fixed it by removing the comment meta in the final _save function https://codereview.appspot.com/8612044/ .
  55 2013-04-17T11:06:05  <ThomasWaldmann> btw, having to do that seems a bit backwards somehow. maybe open an issue on the whoosh issuetracker and discuss it with matt.
  56 2013-04-17T11:08:51  * ThomasWaldmann looks at rename comment...
  57 2013-04-17T11:09:00  <ashutosh1461> yes, that would be a good idea.
  58 2013-04-17T11:12:10  <ThomasWaldmann> that rename comment bug - does it happen if you enter a non-empty comment?
  59 2013-04-17T11:14:07  <ashutosh1461> no, just if you leave the comment field empty.
  60 2013-04-17T11:18:23  <ThomasWaldmann> ok, then i seem to be right, see codereview
  61 2013-04-17T11:18:37  <ThomasWaldmann> ok, gtg...
  62 2013-04-17T11:27:14  *** ashutosh1461 has quit IRC
  63 2013-04-17T11:43:32  *** Ganz7 has joined #moin-dev
  64 2013-04-17T11:43:37  *** Ganz7 has joined #moin-dev
  65 2013-04-17T12:02:44  *** ashutosh1461 has joined #moin-dev
  66 2013-04-17T12:43:51  <sharky93> ThomasWaldmann, issue updated https://codereview.appspot.com/8660044/ test simplified
  67 2013-04-17T13:22:32  *** dave_largo has joined #moin-dev
  68 2013-04-17T13:25:29  *** sharky93 has quit IRC
  69 2013-04-17T13:29:38  *** sharky93 has joined #moin-dev
  70 2013-04-17T14:20:59  *** rubocoptero has quit IRC
  71 2013-04-17T14:23:53  *** Ganz7 has quit IRC
  72 2013-04-17T14:36:06  *** Ganz7 has joined #moin-dev
  73 2013-04-17T14:37:16  *** ashutosh1461 has quit IRC
  74 2013-04-17T14:41:51  *** dwcramer has joined #moin-dev
  75 2013-04-17T14:46:36  *** dwcramer has quit IRC
  76 2013-04-17T14:48:54  *** rihnapstor has joined #moin-dev
  77 2013-04-17T14:58:13  *** dwcramer has joined #moin-dev
  78 2013-04-17T15:05:24  *** ashutosh1461 has joined #moin-dev
  79 2013-04-17T15:22:00  *** rihnapstor has quit IRC
  80 2013-04-17T15:31:24  *** rihnapstor has joined #moin-dev
  81 2013-04-17T15:55:10  *** rihnapstor has quit IRC
  82 2013-04-17T16:01:41  *** dwcramer has quit IRC
  83 2013-04-17T16:04:51  *** n00bz0rz has joined #moin-dev
  84 2013-04-17T16:20:48  *** Ganz7 has quit IRC
  85 2013-04-17T16:20:49  *** Ganz7 has joined #moin-dev
  86 2013-04-17T16:21:21  *** n00bz0rz has quit IRC
  87 2013-04-17T16:22:26  <sunu> moin
  88 2013-04-17T16:53:02  *** dwcramer has joined #moin-dev
  89 2013-04-17T17:36:49  *** n00bz0rz has joined #moin-dev
  90 2013-04-17T17:42:55  *** dwcramer has quit IRC
  91 2013-04-17T17:44:51  *** botton has joined #moin-dev
  92 2013-04-17T17:44:51  *** botton has left #moin-dev
  93 2013-04-17T17:47:48  *** desophos has quit IRC
  94 2013-04-17T17:48:03  *** desophos has joined #moin-dev
  95 2013-04-17T17:55:38  *** greg_f has quit IRC
  96 2013-04-17T18:14:00  *** Ganz7 has quit IRC
  97 2013-04-17T18:14:31  *** Ganz7 has joined #moin-dev
  98 2013-04-17T18:26:55  *** puneet has joined #moin-dev
  99 2013-04-17T18:30:37  *** sharky93 has quit IRC
 100 2013-04-17T18:32:51  *** desophos has quit IRC
 101 2013-04-17T18:40:48  *** ashutosh1461 has quit IRC
 102 2013-04-17T18:46:51  *** desophos has joined #moin-dev
 103 2013-04-17T18:58:28  *** ashutosh1461 has joined #moin-dev
 104 2013-04-17T19:29:25  *** Ganz7 has left #moin-dev
 105 2013-04-17T19:38:20  *** n00bz0rz has quit IRC
 106 2013-04-17T19:39:02  *** rubocoptero has joined #moin-dev
 107 2013-04-17T19:48:27  *** desophos has quit IRC
 108 2013-04-17T19:57:16  *** desophos has joined #moin-dev
 109 2013-04-17T20:21:55  *** rubocoptero has quit IRC
 110 2013-04-17T20:30:01  *** n00bz0rz has joined #moin-dev
 111 2013-04-17T20:46:55  *** desophos has quit IRC
 112 2013-04-17T20:49:29  *** dwcramer has joined #moin-dev
 113 2013-04-17T21:06:09  *** n00bz0rz has quit IRC
 114 2013-04-17T21:06:22  *** dwcramer has quit IRC
 115 2013-04-17T21:06:44  *** dave_largo has quit IRC
 116 2013-04-17T21:15:56  *** DeNiS_M has joined #moin-dev
 117 2013-04-17T21:17:07  *** ronny has quit IRC
 118 2013-04-17T21:19:58  *** dwcramer has joined #moin-dev
 119 2013-04-17T21:37:20  *** dwcramer has quit IRC
 120 2013-04-17T21:43:22  *** rubocoptero has joined #moin-dev
 121 2013-04-17T21:54:53  *** rubocoptero has quit IRC
 122 2013-04-17T22:02:26  *** DeNiS_M has left #moin-dev
 123 2013-04-17T22:08:12  *** desophos has joined #moin-dev
 124 2013-04-17T22:13:54  *** dwcramer has joined #moin-dev
 125 2013-04-17T22:23:35  *** dwcramer has quit IRC
 126 2013-04-17T22:37:06  *** dwcramer has joined #moin-dev
 127 2013-04-17T22:44:19  * ashutosh1461 says gn :)
 128 2013-04-17T22:44:31  *** ashutosh1461 has left #moin-dev
 129 2013-04-17T22:59:43  *** dwcramer has quit IRC
 130

MoinMoin: MoinMoinChat/Logs/moin-dev/2013-04-17 (last edited 2013-04-17 01:00:02 by IrcLogImporter)