Toggle line numbers
1 2013-04-20T00:00:49 *** brunomartin has quit IRC
2 2013-04-20T01:38:47 *** mtdkw has joined #moin-dev
3 2013-04-20T02:02:40 *** desophos has joined #moin-dev
4 2013-04-20T02:51:39 *** desophos has quit IRC
5 2013-04-20T03:30:10 *** sharky93 has quit IRC
6 2013-04-20T04:10:07 *** mtdkw has quit IRC
7 2013-04-20T04:43:12 *** dwcramer has joined #moin-dev
8 2013-04-20T05:27:35 *** xiaq has joined #moin-dev
9 2013-04-20T05:30:51 *** mtdkw has joined #moin-dev
10 2013-04-20T05:48:03 *** dwcramer has quit IRC
11 2013-04-20T06:44:19 *** sharky93 has joined #moin-dev
12 2013-04-20T07:57:41 *** rubocoptero has joined #moin-dev
13 2013-04-20T08:28:58 *** mtdkw has quit IRC
14 2013-04-20T08:29:22 *** mtdkw has joined #moin-dev
15 2013-04-20T08:35:08 *** mtdkw has quit IRC
16 2013-04-20T09:28:41 <sharky93> moin
17 2013-04-20T10:13:49 <sharky93> ThomasWaldmann, could you please review https://codereview.appspot.com/8660044
18 2013-04-20T10:50:32 *** sharky93 has quit IRC
19 2013-04-20T10:53:31 *** sharky93 has joined #moin-dev
20 2013-04-20T11:19:19 *** sharky93 has quit IRC
21 2013-04-20T11:24:00 *** sharky93 has joined #moin-dev
22 2013-04-20T11:31:47 *** rubocoptero has quit IRC
23 2013-04-20T11:38:05 *** sharky93 has quit IRC
24 2013-04-20T11:39:19 *** sharky93 has joined #moin-dev
25 2013-04-20T11:42:31 *** sharky93 has quit IRC
26 2013-04-20T11:45:25 *** sharky93 has joined #moin-dev
27 2013-04-20T11:50:49 *** rihnapstor has joined #moin-dev
28 2013-04-20T12:11:41 <ThomasWaldmann> moin
29 2013-04-20T12:15:29 *** rihnapstor has left #moin-dev
30 2013-04-20T12:17:28 <ThomasWaldmann> sharky93: done
31 2013-04-20T12:23:05 <sharky93> ThomasWaldmann, why is it advisable to use a list of 2-tuples with (mimetype, tag_expected)? when tag_expected is the same for all ?
32 2013-04-20T12:23:38 <sharky93> just read the styleguide btw
33 2013-04-20T12:24:06 <ThomasWaldmann> well, what if we change that it is not the same any more?
34 2013-04-20T12:24:28 <ThomasWaldmann> with the list of tuples it needs just a data change then. with your solution you need to change the algorithm
35 2013-04-20T12:24:46 <ThomasWaldmann> and having a list of test input tuples is a rather standard pattern
36 2013-04-20T12:25:03 <ThomasWaldmann> input/expected tuples
37 2013-04-20T12:35:55 <sharky93> hmm, i get it
38 2013-04-20T12:58:57 <sharky93> ThomasWaldmann, I have a string in a line that is going to 128 chars in a line, you had earlier mentioned that you'll be enforcing a limit of 120 chars, but that appears much more meaningful that way
39 2013-04-20T12:59:14 <sharky93> should i leave it like that ?
40 2013-04-20T12:59:55 <ThomasWaldmann> well, I'll have to configure some limit, the checker is not intelligent
41 2013-04-20T13:07:46 <sharky93> ThomasWaldmann, issue update @ https://codereview.appspot.com/8660044/
42 2013-04-20T13:14:45 <sharky93> *updated
43 2013-04-20T13:31:02 *** ashutosh1461 has joined #moin-dev
44 2013-04-20T13:43:11 <ashutosh1461> ThomasWaldmann, updated https://codereview.appspot.com/8753043/
45 2013-04-20T13:50:50 <ThomasWaldmann> just one more thing... :D
46 2013-04-20T13:52:01 <sharky93> ThomasWaldmann, issue update @ https://codereview.appspot.com/8660044/
47 2013-04-20T13:55:12 <ThomasWaldmann> yeah, just finished review
48 2013-04-20T14:02:44 *** dwcramer has joined #moin-dev
49 2013-04-20T14:07:27 *** puneet has joined #moin-dev
50 2013-04-20T14:11:47 * ThomasWaldmann bbl
51 2013-04-20T14:21:35 *** dwcramer has quit IRC
52 2013-04-20T14:30:08 *** ashutosh1461 has quit IRC
53 2013-04-20T14:30:08 <sharky93> ThomasWaldmann, in relation to #340, if the input is like {{ image | | &w=50, height=100 }}, args received here @ https://bitbucket.org/thomaswaldmann/moin-2.0/src/7c00da767896c6cf52d94b1b1d936d480abe94b9/MoinMoin/converter/moinwiki_in.py?at=default#cl-832 are ('w':'50','height':'100'), currently the parser ignores an '&', considering we fix that..
54 2013-04-20T14:30:31 <sharky93> after the call to url_encode .. @ https://bitbucket.org/thomaswaldmann/moin-2.0/src/7c00da767896c6cf52d94b1b1d936d480abe94b9/MoinMoin/converter/moinwiki_in.py?at=default#cl-836 it still wont allow a & in the strign
55 2013-04-20T14:30:34 *** ashutosh1461 has joined #moin-dev
56 2013-04-20T14:42:19 *** ashutosh1461 has quit IRC
57 2013-04-20T15:07:18 *** ashutosh1461 has joined #moin-dev
58 2013-04-20T15:10:05 <ashutosh1461> ThomasWaldmann, updated https://codereview.appspot.com/8753043/ ! :)
59 2013-04-20T15:15:54 *** puneet has quit IRC
60 2013-04-20T15:44:41 *** vj14 has joined #moin-dev
61 2013-04-20T15:57:08 *** dwcramer has joined #moin-dev
62 2013-04-20T16:07:50 *** dwcramer has quit IRC
63 2013-04-20T16:12:10 *** puneet has joined #moin-dev
64 2013-04-20T16:16:56 *** dwcramer has joined #moin-dev
65 2013-04-20T16:28:09 *** vaishaks has joined #moin-dev
66 2013-04-20T16:36:23 <sunu> moin
67 2013-04-20T16:59:44 *** dwcramer has quit IRC
68 2013-04-20T17:01:50 *** ashutosh1461 has quit IRC
69 2013-04-20T17:12:01 *** dwcramer has joined #moin-dev
70 2013-04-20T17:47:40 *** vj14 has quit IRC
71 2013-04-20T17:47:54 *** ashutosh1461 has joined #moin-dev
72 2013-04-20T17:54:49 *** dwcramer has quit IRC
73 2013-04-20T18:01:06 *** puneet has quit IRC
74 2013-04-20T19:51:04 *** desophos has joined #moin-dev
75 2013-04-20T19:51:48 *** dwcramer has joined #moin-dev
76 2013-04-20T19:57:55 *** ashutosh1461 has quit IRC
77 2013-04-20T20:58:41 *** dwcramer has quit IRC
78 2013-04-20T21:14:35 *** vj14 has joined #moin-dev
79 2013-04-20T21:46:43 *** desophos has quit IRC
80 2013-04-20T23:28:00 *** desophos has joined #moin-dev
81 2013-04-20T23:38:22 *** ashutosh1461 has joined #moin-dev
82